Re: [Qemu-devel] [PATCH v2 1/2] ps2: add support of auto-repeat

2013-07-23 Thread Gerd Hoffmann
On 07/02/13 08:49, Amos Kong wrote: Actually it's not a urgent/necessary request. Host provided auto-repeat works, and we didn't have real application of holding key by sendkey command now. So it's a solution for a non-existing problem ... Which guests do care about the hardware repeat rate

Re: [Qemu-devel] [PATCH v2 1/2] ps2: add support of auto-repeat

2013-07-02 Thread Amos Kong
On Wed, Jun 26, 2013 at 01:56:33PM +0200, Markus Armbruster wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 14 Jun 2013 13:46:41 +0800 Amos Kong ak...@redhat.com wrote: On Fri, May 31, 2013 at 08:31:17PM +0800, Amos Kong wrote: On Thu, May 30, 2013 at 11:48:46AM -0500,

Re: [Qemu-devel] [PATCH v2 1/2] ps2: add support of auto-repeat

2013-06-26 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 14 Jun 2013 13:46:41 +0800 Amos Kong ak...@redhat.com wrote: On Fri, May 31, 2013 at 08:31:17PM +0800, Amos Kong wrote: On Thu, May 30, 2013 at 11:48:46AM -0500, Anthony Liguori wrote: Amos Kong ak...@redhat.com writes: diff

Re: [Qemu-devel] [PATCH v2 1/2] ps2: add support of auto-repeat

2013-06-17 Thread Luiz Capitulino
On Fri, 14 Jun 2013 13:46:41 +0800 Amos Kong ak...@redhat.com wrote: On Fri, May 31, 2013 at 08:31:17PM +0800, Amos Kong wrote: On Thu, May 30, 2013 at 11:48:46AM -0500, Anthony Liguori wrote: Amos Kong ak...@redhat.com writes: diff --git a/hw/input/ps2.c b/hw/input/ps2.c index

Re: [Qemu-devel] [PATCH v2 1/2] ps2: add support of auto-repeat

2013-06-13 Thread Amos Kong
On Fri, May 31, 2013 at 08:31:17PM +0800, Amos Kong wrote: On Thu, May 30, 2013 at 11:48:46AM -0500, Anthony Liguori wrote: Amos Kong ak...@redhat.com writes: Guest driver sets repeat rate and delay time by KBD_CMD_SET_RATE, but ps2 backend doesn't process it and no auto-repeat

Re: [Qemu-devel] [PATCH v2 1/2] ps2: add support of auto-repeat

2013-06-13 Thread Andreas Färber
Am 31.05.2013 14:31, schrieb Amos Kong: diff --git a/hw/input/ps2.c b/hw/input/ps2.c index cdb18e6..fdb9912 100644 --- a/hw/input/ps2.c +++ b/hw/input/ps2.c @@ -615,7 +615,17 @@ static bool ps2_keyboard_repeatstate_needed(void *opaque) { PS2KbdState *s = opaque; -return

Re: [Qemu-devel] [PATCH v2 1/2] ps2: add support of auto-repeat

2013-06-13 Thread Paolo Bonzini
Il 13/06/2013 06:19, Andreas Färber ha scritto: Am 31.05.2013 14:31, schrieb Amos Kong: diff --git a/hw/input/ps2.c b/hw/input/ps2.c index cdb18e6..fdb9912 100644 --- a/hw/input/ps2.c +++ b/hw/input/ps2.c @@ -615,7 +615,17 @@ static bool ps2_keyboard_repeatstate_needed(void *opaque) {

Re: [Qemu-devel] [PATCH v2 1/2] ps2: add support of auto-repeat

2013-06-13 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: Il 13/06/2013 06:19, Andreas Färber ha scritto: Am 31.05.2013 14:31, schrieb Amos Kong: diff --git a/hw/input/ps2.c b/hw/input/ps2.c index cdb18e6..fdb9912 100644 --- a/hw/input/ps2.c +++ b/hw/input/ps2.c @@ -615,7 +615,17 @@ static bool

Re: [Qemu-devel] [PATCH v2 1/2] ps2: add support of auto-repeat

2013-06-13 Thread Paolo Bonzini
Il 13/06/2013 09:01, Anthony Liguori ha scritto: Paolo Bonzini pbonz...@redhat.com writes: Il 13/06/2013 06:19, Andreas Färber ha scritto: Am 31.05.2013 14:31, schrieb Amos Kong: diff --git a/hw/input/ps2.c b/hw/input/ps2.c index cdb18e6..fdb9912 100644 --- a/hw/input/ps2.c +++

Re: [Qemu-devel] [PATCH v2 1/2] ps2: add support of auto-repeat

2013-06-13 Thread Anthony Liguori
Amos Kong ak...@redhat.com writes: On Fri, May 31, 2013 at 08:31:17PM +0800, Amos Kong wrote: On Thu, May 30, 2013 at 11:48:46AM -0500, Anthony Liguori wrote: Amos Kong ak...@redhat.com writes: Guest driver sets repeat rate and delay time by KBD_CMD_SET_RATE, but ps2 backend doesn't

Re: [Qemu-devel] [PATCH v2 1/2] ps2: add support of auto-repeat

2013-06-13 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: Il 13/06/2013 09:01, Anthony Liguori ha scritto: Paolo Bonzini pbonz...@redhat.com writes: Il 13/06/2013 06:19, Andreas Färber ha scritto: Am 31.05.2013 14:31, schrieb Amos Kong: diff --git a/hw/input/ps2.c b/hw/input/ps2.c index cdb18e6..fdb9912

Re: [Qemu-devel] [PATCH v2 1/2] ps2: add support of auto-repeat

2013-06-13 Thread Amos Kong
On Thu, Jun 13, 2013 at 01:28:14PM -0500, Anthony Liguori wrote: Paolo Bonzini pbonz...@redhat.com writes: Il 13/06/2013 09:01, Anthony Liguori ha scritto: Paolo Bonzini pbonz...@redhat.com writes: static bool ps2_keyboard_ledstate_needed(void *opaque) @@ -638,9 +648,12 @@ static const

Re: [Qemu-devel] [PATCH v2 1/2] ps2: add support of auto-repeat

2013-06-13 Thread Amos Kong
On Fri, May 31, 2013 at 08:31:17PM +0800, Amos Kong wrote: On Thu, May 30, 2013 at 11:48:46AM -0500, Anthony Liguori wrote: Amos Kong ak...@redhat.com writes: diff --git a/hw/input/ps2.c b/hw/input/ps2.c index 3412079..8adbb4a 100644 --- a/hw/input/ps2.c +++ b/hw/input/ps2.c @@

Re: [Qemu-devel] [PATCH v2 1/2] ps2: add support of auto-repeat

2013-05-31 Thread Amos Kong
On Thu, May 30, 2013 at 11:48:46AM -0500, Anthony Liguori wrote: Amos Kong ak...@redhat.com writes: Guest driver sets repeat rate and delay time by KBD_CMD_SET_RATE, but ps2 backend doesn't process it and no auto-repeat implementation. This patch adds support of auto-repeat feature. The

Re: [Qemu-devel] [PATCH v2 1/2] ps2: add support of auto-repeat

2013-05-30 Thread Anthony Liguori
Amos Kong ak...@redhat.com writes: Guest driver sets repeat rate and delay time by KBD_CMD_SET_RATE, but ps2 backend doesn't process it and no auto-repeat implementation. This patch adds support of auto-repeat feature. The repeated events from host are ignored and re-implements ps2's

[Qemu-devel] [PATCH v2 1/2] ps2: add support of auto-repeat

2013-05-22 Thread Amos Kong
Guest driver sets repeat rate and delay time by KBD_CMD_SET_RATE, but ps2 backend doesn't process it and no auto-repeat implementation. This patch adds support of auto-repeat feature. The repeated events from host are ignored and re-implements ps2's auto-repeat. Guest ps2 driver sets autorepeat