Re: [Qemu-devel] [PATCH v2 2/4] spapr/rtas: disable the decrementer interrupt when a CPU is unplugged

2017-10-12 Thread Cédric Le Goater
On 10/12/2017 11:25 AM, Cédric Le Goater wrote: > On 10/12/2017 12:46 AM, David Gibson wrote: >> On Wed, Oct 11, 2017 at 01:55:20PM +0200, Cédric Le Goater wrote: >>> On 10/11/2017 08:45 AM, David Gibson wrote: On Mon, Oct 09, 2017 at 05:49:28PM +0200, Cédric Le Goater wrote: > When a CPU

Re: [Qemu-devel] [PATCH v2 2/4] spapr/rtas: disable the decrementer interrupt when a CPU is unplugged

2017-10-12 Thread Cédric Le Goater
On 10/12/2017 12:46 AM, David Gibson wrote: > On Wed, Oct 11, 2017 at 01:55:20PM +0200, Cédric Le Goater wrote: >> On 10/11/2017 08:45 AM, David Gibson wrote: >>> On Mon, Oct 09, 2017 at 05:49:28PM +0200, Cédric Le Goater wrote: When a CPU is stopped with the 'stop-self' RTAS call, its state

Re: [Qemu-devel] [PATCH v2 2/4] spapr/rtas: disable the decrementer interrupt when a CPU is unplugged

2017-10-11 Thread David Gibson
On Wed, Oct 11, 2017 at 01:55:20PM +0200, Cédric Le Goater wrote: > On 10/11/2017 08:45 AM, David Gibson wrote: > > On Mon, Oct 09, 2017 at 05:49:28PM +0200, Cédric Le Goater wrote: > >> When a CPU is stopped with the 'stop-self' RTAS call, its state > >> 'halted' is switched to 1 and, in this

Re: [Qemu-devel] [PATCH v2 2/4] spapr/rtas: disable the decrementer interrupt when a CPU is unplugged

2017-10-11 Thread Cédric Le Goater
On 10/11/2017 08:45 AM, David Gibson wrote: > On Mon, Oct 09, 2017 at 05:49:28PM +0200, Cédric Le Goater wrote: >> When a CPU is stopped with the 'stop-self' RTAS call, its state >> 'halted' is switched to 1 and, in this case, the MSR is not taken into >> account anymore in the cpu_has_work()

Re: [Qemu-devel] [PATCH v2 2/4] spapr/rtas: disable the decrementer interrupt when a CPU is unplugged

2017-10-11 Thread David Gibson
On Mon, Oct 09, 2017 at 05:49:28PM +0200, Cédric Le Goater wrote: > When a CPU is stopped with the 'stop-self' RTAS call, its state > 'halted' is switched to 1 and, in this case, the MSR is not taken into > account anymore in the cpu_has_work() routine. Only the pending > hardware interrupts are

Re: [Qemu-devel] [PATCH v2 2/4] spapr/rtas: disable the decrementer interrupt when a CPU is unplugged

2017-10-10 Thread Cédric Le Goater
On 10/10/2017 10:08 AM, Benjamin Herrenschmidt wrote: > On Mon, 2017-10-09 at 17:49 +0200, Cédric Le Goater wrote: >> When a CPU is stopped with the 'stop-self' RTAS call, its state >> 'halted' is switched to 1 and, in this case, the MSR is not taken into >> account anymore in the cpu_has_work()

Re: [Qemu-devel] [PATCH v2 2/4] spapr/rtas: disable the decrementer interrupt when a CPU is unplugged

2017-10-10 Thread Benjamin Herrenschmidt
On Mon, 2017-10-09 at 17:49 +0200, Cédric Le Goater wrote: > When a CPU is stopped with the 'stop-self' RTAS call, its state > 'halted' is switched to 1 and, in this case, the MSR is not taken into > account anymore in the cpu_has_work() routine. Only the pending > hardware interrupts are checked

[Qemu-devel] [PATCH v2 2/4] spapr/rtas: disable the decrementer interrupt when a CPU is unplugged

2017-10-09 Thread Cédric Le Goater
When a CPU is stopped with the 'stop-self' RTAS call, its state 'halted' is switched to 1 and, in this case, the MSR is not taken into account anymore in the cpu_has_work() routine. Only the pending hardware interrupts are checked with their LPCR:PECE* enablement bit. If the DECR timer fires