Re: [Qemu-devel] [PATCH v3] spapr: disable decrementer during reset

2017-09-27 Thread Cédric Le Goater
On 07/17/2017 06:16 AM, Nikunj A Dadhania wrote: > Rebooting a SMP TCG guest is broken for both single/multi threaded TCG. > > When reset happens, all the CPUs are in halted state. First CPU is brought out > of reset and secondary CPUs would be initialized by the guest kernel using a > rtas call

Re: [Qemu-devel] [PATCH v3] spapr: disable decrementer during reset

2017-09-14 Thread Nikunj A Dadhania
David Gibson writes: > On Wed, Jul 19, 2017 at 09:20:52AM +0530, Nikunj A Dadhania wrote: >> David Gibson writes: >> >> > On Tue, Jul 18, 2017 at 10:53:01AM +0530, Nikunj A Dadhania wrote: >> >> David Gibson

Re: [Qemu-devel] [PATCH v3] spapr: disable decrementer during reset

2017-07-18 Thread David Gibson
On Wed, Jul 19, 2017 at 09:20:52AM +0530, Nikunj A Dadhania wrote: > David Gibson writes: > > > On Tue, Jul 18, 2017 at 10:53:01AM +0530, Nikunj A Dadhania wrote: > >> David Gibson writes: > >> > >> > On Mon, Jul 17, 2017 at 09:46:39AM

Re: [Qemu-devel] [PATCH v3] spapr: disable decrementer during reset

2017-07-18 Thread Nikunj A Dadhania
David Gibson writes: > On Tue, Jul 18, 2017 at 10:53:01AM +0530, Nikunj A Dadhania wrote: >> David Gibson writes: >> >> > On Mon, Jul 17, 2017 at 09:46:39AM +0530, Nikunj A Dadhania wrote: >> >> Rebooting a SMP TCG guest is broken for

Re: [Qemu-devel] [PATCH v3] spapr: disable decrementer during reset

2017-07-18 Thread Benjamin Herrenschmidt
On Tue, 2017-07-18 at 10:56 +0530, Nikunj A Dadhania wrote: > In case of reboot, all CPUs are resumed after reboot. So we check the > next condition cpu_has_work() in cpu_thread_is_idle(), where we see a > DECR interrupt and remove the CPU from halted state as the CPU has work. Shouldn't we put

Re: [Qemu-devel] [PATCH v3] spapr: disable decrementer during reset

2017-07-18 Thread David Gibson
On Tue, Jul 18, 2017 at 10:53:01AM +0530, Nikunj A Dadhania wrote: > David Gibson writes: > > > On Mon, Jul 17, 2017 at 09:46:39AM +0530, Nikunj A Dadhania wrote: > >> Rebooting a SMP TCG guest is broken for both single/multi threaded TCG. > >> > >> When reset

Re: [Qemu-devel] [PATCH v3] spapr: disable decrementer during reset

2017-07-17 Thread Nikunj A Dadhania
David Gibson writes: > On Mon, Jul 17, 2017 at 09:46:39AM +0530, Nikunj A Dadhania wrote: >> Rebooting a SMP TCG guest is broken for both single/multi threaded TCG. >> >> When reset happens, all the CPUs are in halted state. First CPU is brought >> out >> of reset

Re: [Qemu-devel] [PATCH v3] spapr: disable decrementer during reset

2017-07-17 Thread Nikunj A Dadhania
David Gibson writes: > On Mon, Jul 17, 2017 at 09:46:39AM +0530, Nikunj A Dadhania wrote: >> Rebooting a SMP TCG guest is broken for both single/multi threaded TCG. >> >> When reset happens, all the CPUs are in halted state. First CPU is brought >> out >> of reset

Re: [Qemu-devel] [PATCH v3] spapr: disable decrementer during reset

2017-07-17 Thread Nikunj A Dadhania
David Gibson writes: > On Mon, Jul 17, 2017 at 09:46:39AM +0530, Nikunj A Dadhania wrote: >> Rebooting a SMP TCG guest is broken for both single/multi threaded TCG. >> >> When reset happens, all the CPUs are in halted state. First CPU is brought >> out >> of reset

Re: [Qemu-devel] [PATCH v3] spapr: disable decrementer during reset

2017-07-17 Thread David Gibson
On Mon, Jul 17, 2017 at 09:46:39AM +0530, Nikunj A Dadhania wrote: > Rebooting a SMP TCG guest is broken for both single/multi threaded TCG. > > When reset happens, all the CPUs are in halted state. First CPU is brought out > of reset and secondary CPUs would be initialized by the guest kernel

[Qemu-devel] [PATCH v3] spapr: disable decrementer during reset

2017-07-16 Thread Nikunj A Dadhania
Rebooting a SMP TCG guest is broken for both single/multi threaded TCG. When reset happens, all the CPUs are in halted state. First CPU is brought out of reset and secondary CPUs would be initialized by the guest kernel using a rtas call start-cpu. However, in case of TCG, decrementer interrupts