Re: [Qemu-devel] [PATCH v3] vnc: added initial websocket protocol support

2012-12-05 Thread Tim Hardeck
Hi Stefan, On 12/03/2012 05:22 PM, Stefan Hajnoczi wrote: Thanks for the patch, Tim. Some general code review comments below. Thanks for the code review. I am going to incorporate them in my new patch. I hope someone has time to review the VNC and WebSocket specific stuff. I didn't check

Re: [Qemu-devel] [PATCH v3] vnc: added initial websocket protocol support

2012-12-03 Thread Stefan Hajnoczi
On Fri, Nov 23, 2012 at 08:00:47PM +0100, Tim Hardeck wrote: Thanks for the patch, Tim. Some general code review comments below. I hope someone has time to review the VNC and WebSocket specific stuff. I didn't check the details of buffers, whether the WebSocket spec is correctly implemented,

[Qemu-devel] [PATCH v3] vnc: added initial websocket protocol support

2012-11-23 Thread Tim Hardeck
This patch adds basic Websocket Protocol version 13 - RFC 6455 - support to QEMU VNC. Binary encoding support on the client side is mandatory. Because of the GnuTLS requirement the Websockets implementation is optional (--enable-vnc-ws). To activate Websocket support the VNC option websocketis