Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-16 Thread Jan Kiszka
On 2013-07-14 17:18, Anthony Liguori wrote: On Sun, Jul 14, 2013 at 9:58 AM, Peter Maydell peter.mayd...@linaro.org wrote: On 14 July 2013 14:05, Anthony Liguori anth...@codemonkey.ws wrote: Also, what devices exactly would have a non-native byte order?!? I'm confused... MMIO/PIO requests

Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-16 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 16/07/2013 09:18, Jan Kiszka ha scritto: Sorry for sending out invitations and then being late to this party - vacation. What is the status now? Do we have a short-term plan to avoid the regression or is this better solved by cleaning up the

Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-16 Thread Hervé Poussineau
Paolo Bonzini a écrit : -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 16/07/2013 09:18, Jan Kiszka ha scritto: Sorry for sending out invitations and then being late to this party - vacation. What is the status now? Do we have a short-term plan to avoid the regression or is this better

Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-16 Thread Paolo Bonzini
Il 16/07/2013 18:59, Hervé Poussineau ha scritto: Paolo Bonzini a écrit : -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 16/07/2013 09:18, Jan Kiszka ha scritto: Sorry for sending out invitations and then being late to this party - vacation. What is the status now? Do we have a short-term

Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-14 Thread Paolo Bonzini
Il 13/07/2013 17:22, Anthony Liguori ha scritto: 1) MMIO request goes to sPAPR PIO area, the vCPU was in BE mode but by the time the handler is called, the value is in host byte order. 2) sPAPR (incorrectly) byte swaps by marking the region as little endian (data is now garbage) 3) The

Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-14 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: Il 13/07/2013 17:22, Anthony Liguori ha scritto: 1) MMIO request goes to sPAPR PIO area, the vCPU was in BE mode but by the time the handler is called, the value is in host byte order. 2) sPAPR (incorrectly) byte swaps by marking the region as

Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-14 Thread Peter Maydell
On 14 July 2013 14:05, Anthony Liguori anth...@codemonkey.ws wrote: Also, what devices exactly would have a non-native byte order?!? I'm confused... MMIO/PIO requests don't have a byte order. It's literally 64 or 32 data pins that are numbered D0..D31 whereas D0 is the LSB. It doesn't

Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-14 Thread Anthony Liguori
On Sun, Jul 14, 2013 at 9:58 AM, Peter Maydell peter.mayd...@linaro.org wrote: On 14 July 2013 14:05, Anthony Liguori anth...@codemonkey.ws wrote: Also, what devices exactly would have a non-native byte order?!? I'm confused... MMIO/PIO requests don't have a byte order. It's literally 64 or

Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-14 Thread Peter Maydell
On 14 July 2013 16:18, Anthony Liguori anth...@codemonkey.ws wrote: On Sun, Jul 14, 2013 at 9:58 AM, Peter Maydell peter.mayd...@linaro.org wrote: Devices themselves do have a byte order, though, right? Specifically, if you do a 32 bit read of address 0 on a device and an 8 bit read, It

Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-13 Thread Paolo Bonzini
Il 11/07/2013 14:46, Andreas Färber ha scritto: sPAPR has its MemoryRegion marked Little Endian:

Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-13 Thread Anthony Liguori
On Sat, Jul 13, 2013 at 9:38 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 11/07/2013 14:46, Andreas Färber ha scritto: sPAPR has its MemoryRegion marked Little Endian:

Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-13 Thread Hervé Poussineau
Anthony Liguori a écrit : On Sat, Jul 13, 2013 at 9:38 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 11/07/2013 14:46, Andreas Färber ha scritto: sPAPR has its MemoryRegion marked Little Endian:

Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-12 Thread Anthony Liguori
Alexander Graf ag...@suse.de writes: On 11.07.2013, at 14:29, Alexander Graf wrote: This patch breaks VGA on PPC as it is in master today. If I don't mark portio as little endian it works as expected. There's probably someone swapping things twice. This is the correct fix. Can you please

Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-12 Thread Alexander Graf
Am 12.07.2013 um 14:56 schrieb Anthony Liguori anth...@codemonkey.ws: Alexander Graf ag...@suse.de writes: On 11.07.2013, at 14:29, Alexander Graf wrote: This patch breaks VGA on PPC as it is in master today. If I don't mark portio as little endian it works as expected. There's

Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-12 Thread Anthony Liguori
Hervé Poussineau hpous...@reactos.org writes: Jan Kiszka a écrit : From: Jan Kiszka jan.kis...@siemens.com The current ioport dispatcher is a complex beast, mostly due to the need to deal with old portio interface users. But we can overcome it without converting all portio users by

Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-11 Thread Alexander Graf
On 24.06.2013, at 08:07, Jan Kiszka wrote: On 2013-06-23 22:50, Hervé Poussineau wrote: Jan Kiszka a écrit : From: Jan Kiszka jan.kis...@siemens.com The current ioport dispatcher is a complex beast, mostly due to the need to deal with old portio interface users. But we can overcome it

Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-11 Thread Alexander Graf
On 11.07.2013, at 14:29, Alexander Graf wrote: On 24.06.2013, at 08:07, Jan Kiszka wrote: On 2013-06-23 22:50, Hervé Poussineau wrote: Jan Kiszka a écrit : From: Jan Kiszka jan.kis...@siemens.com The current ioport dispatcher is a complex beast, mostly due to the need to deal with

Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-11 Thread Andreas Färber
Am 11.07.2013 14:34, schrieb Alexander Graf: On 11.07.2013, at 14:29, Alexander Graf wrote: On 24.06.2013, at 08:07, Jan Kiszka wrote: On 2013-06-23 22:50, Hervé Poussineau wrote: Jan Kiszka a écrit : From: Jan Kiszka jan.kis...@siemens.com The current ioport dispatcher is a complex

Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-11 Thread Alexander Graf
On 11.07.2013, at 14:46, Andreas Färber wrote: Am 11.07.2013 14:34, schrieb Alexander Graf: On 11.07.2013, at 14:29, Alexander Graf wrote: On 24.06.2013, at 08:07, Jan Kiszka wrote: On 2013-06-23 22:50, Hervé Poussineau wrote: Jan Kiszka a écrit : From: Jan Kiszka

Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-11 Thread Alexander Graf
On 11.07.2013, at 14:48, Alexander Graf wrote: On 11.07.2013, at 14:46, Andreas Färber wrote: Am 11.07.2013 14:34, schrieb Alexander Graf: On 11.07.2013, at 14:29, Alexander Graf wrote: On 24.06.2013, at 08:07, Jan Kiszka wrote: On 2013-06-23 22:50, Hervé Poussineau wrote: Jan

Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-11 Thread Alexander Graf
On 11.07.2013, at 15:28, Alexander Graf wrote: On 11.07.2013, at 14:48, Alexander Graf wrote: On 11.07.2013, at 14:46, Andreas Färber wrote: Am 11.07.2013 14:34, schrieb Alexander Graf: On 11.07.2013, at 14:29, Alexander Graf wrote: On 24.06.2013, at 08:07, Jan Kiszka wrote:

Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-06-24 Thread Jan Kiszka
On 2013-06-23 22:50, Hervé Poussineau wrote: Jan Kiszka a écrit : From: Jan Kiszka jan.kis...@siemens.com The current ioport dispatcher is a complex beast, mostly due to the need to deal with old portio interface users. But we can overcome it without converting all portio users by embedding

Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-06-23 Thread Hervé Poussineau
Jan Kiszka a écrit : From: Jan Kiszka jan.kis...@siemens.com The current ioport dispatcher is a complex beast, mostly due to the need to deal with old portio interface users. But we can overcome it without converting all portio users by embedding the required base address of a

[Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-06-22 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com The current ioport dispatcher is a complex beast, mostly due to the need to deal with old portio interface users. But we can overcome it without converting all portio users by embedding the required base address of a MemoryRegionPortio access into that data