Re: [Qemu-devel] [PATCH v5 08/36] ppc/xive: introduce a simplified XIVE presenter

2018-12-04 Thread David Gibson
On Tue, Dec 04, 2018 at 06:04:13PM +0100, Cédric Le Goater wrote: > On 12/4/18 2:54 AM, David Gibson wrote: > > On Mon, Dec 03, 2018 at 06:05:12PM +0100, Cédric Le Goater wrote: > >> I forgot to reply to this one. > >> > >> On 11/29/18 1:47 AM, David Gibson wrote: > >>> On Wed, Nov 28, 2018 at

Re: [Qemu-devel] [PATCH v5 08/36] ppc/xive: introduce a simplified XIVE presenter

2018-12-04 Thread Cédric Le Goater
On 12/4/18 2:54 AM, David Gibson wrote: > On Mon, Dec 03, 2018 at 06:05:12PM +0100, Cédric Le Goater wrote: >> I forgot to reply to this one. >> >> On 11/29/18 1:47 AM, David Gibson wrote: >>> On Wed, Nov 28, 2018 at 11:59:58AM +0100, Cédric Le Goater wrote: On 11/28/18 12:49 AM, David Gibson

Re: [Qemu-devel] [PATCH v5 08/36] ppc/xive: introduce a simplified XIVE presenter

2018-12-03 Thread David Gibson
On Mon, Dec 03, 2018 at 06:05:12PM +0100, Cédric Le Goater wrote: > I forgot to reply to this one. > > On 11/29/18 1:47 AM, David Gibson wrote: > > On Wed, Nov 28, 2018 at 11:59:58AM +0100, Cédric Le Goater wrote: > >> On 11/28/18 12:49 AM, David Gibson wrote: > >>> On Fri, Nov 16, 2018 at

Re: [Qemu-devel] [PATCH v5 08/36] ppc/xive: introduce a simplified XIVE presenter

2018-12-03 Thread Cédric Le Goater
I forgot to reply to this one. On 11/29/18 1:47 AM, David Gibson wrote: > On Wed, Nov 28, 2018 at 11:59:58AM +0100, Cédric Le Goater wrote: >> On 11/28/18 12:49 AM, David Gibson wrote: >>> On Fri, Nov 16, 2018 at 11:57:01AM +0100, Cédric Le Goater wrote: The last sub-engine of the XIVE

Re: [Qemu-devel] [PATCH v5 08/36] ppc/xive: introduce a simplified XIVE presenter

2018-11-29 Thread David Gibson
On Thu, Nov 29, 2018 at 06:51:53PM +0100, Cédric Le Goater wrote: > On 11/29/18 4:39 AM, Benjamin Herrenschmidt wrote: > > On Thu, 2018-11-29 at 11:47 +1100, David Gibson wrote: > >> > >> 1) read/write accessors which take a word number > > ok for single word updates of the structures. > > >> 2)

Re: [Qemu-devel] [PATCH v5 08/36] ppc/xive: introduce a simplified XIVE presenter

2018-11-29 Thread Cédric Le Goater
On 11/29/18 4:39 AM, Benjamin Herrenschmidt wrote: > On Thu, 2018-11-29 at 11:47 +1100, David Gibson wrote: >> >> 1) read/write accessors which take a word number ok for single word updates of the structures. >> 2) A "get" accessor which copies the whole structure, ok >> but "write" >>

Re: [Qemu-devel] [PATCH v5 08/36] ppc/xive: introduce a simplified XIVE presenter

2018-11-28 Thread Benjamin Herrenschmidt
On Thu, 2018-11-29 at 11:47 +1100, David Gibson wrote: > > 1) read/write accessors which take a word number > > 2) A "get" accessor which copies the whole structure, but "write" > accessor which takes a word number. The asymmetry is a bit ugly, but > it's the non-atomic writeback of the whole

Re: [Qemu-devel] [PATCH v5 08/36] ppc/xive: introduce a simplified XIVE presenter

2018-11-28 Thread David Gibson
On Wed, Nov 28, 2018 at 11:59:58AM +0100, Cédric Le Goater wrote: > On 11/28/18 12:49 AM, David Gibson wrote: > > On Fri, Nov 16, 2018 at 11:57:01AM +0100, Cédric Le Goater wrote: > >> The last sub-engine of the XIVE architecture is the Interrupt > >> Virtualization Presentation Engine (IVPE). On

Re: [Qemu-devel] [PATCH v5 08/36] ppc/xive: introduce a simplified XIVE presenter

2018-11-28 Thread Cédric Le Goater
On 11/28/18 12:49 AM, David Gibson wrote: > On Fri, Nov 16, 2018 at 11:57:01AM +0100, Cédric Le Goater wrote: >> The last sub-engine of the XIVE architecture is the Interrupt >> Virtualization Presentation Engine (IVPE). On HW, they share elements, >> the Power Bus interface (CQ), the routing

Re: [Qemu-devel] [PATCH v5 08/36] ppc/xive: introduce a simplified XIVE presenter

2018-11-27 Thread Benjamin Herrenschmidt
On Wed, 2018-11-28 at 10:49 +1100, David Gibson wrote: > On Fri, Nov 16, 2018 at 11:57:01AM +0100, Cédric Le Goater wrote: > > The last sub-engine of the XIVE architecture is the Interrupt > > Virtualization Presentation Engine (IVPE). On HW, they share elements, > > the Power Bus interface (CQ),

Re: [Qemu-devel] [PATCH v5 08/36] ppc/xive: introduce a simplified XIVE presenter

2018-11-27 Thread David Gibson
On Fri, Nov 16, 2018 at 11:57:01AM +0100, Cédric Le Goater wrote: > The last sub-engine of the XIVE architecture is the Interrupt > Virtualization Presentation Engine (IVPE). On HW, they share elements, > the Power Bus interface (CQ), the routing table descriptors, and they > can be combined in

[Qemu-devel] [PATCH v5 08/36] ppc/xive: introduce a simplified XIVE presenter

2018-11-16 Thread Cédric Le Goater
The last sub-engine of the XIVE architecture is the Interrupt Virtualization Presentation Engine (IVPE). On HW, they share elements, the Power Bus interface (CQ), the routing table descriptors, and they can be combined in the same HW logic. We do the same in QEMU and combine both engines in the