Re: [Qemu-devel] [PATCH v6] s390x/cpu: expose the guest crash information

2018-02-08 Thread Cornelia Huck
On Wed, 7 Feb 2018 19:15:22 +0100 Christian Borntraeger wrote: > On 02/07/2018 05:58 PM, Cornelia Huck wrote: > > > > >> +## > >> +# @S390CrashReason: > >> +# > >> +# Reason why the CPU is in a crashed state. > >> +# > >> +# @unknown: no crash reason was set > >> +# >

Re: [Qemu-devel] [PATCH v6] s390x/cpu: expose the guest crash information

2018-02-07 Thread Eric Blake
On 02/07/2018 12:44 PM, Christian Borntraeger wrote: +} else if (info->type == GUEST_PANIC_INFORMATION_TYPE_S390) { +qemu_log_mask(LOG_GUEST_ERROR, " on cpu %d: %s\n" + "PSW: 0x%016" PRIx64 " 0x%016" PRIx64"\n", +

Re: [Qemu-devel] [PATCH v6] s390x/cpu: expose the guest crash information

2018-02-07 Thread Christian Borntraeger
On 02/07/2018 01:38 PM, Christian Borntraeger wrote: > --- a/vl.c > +++ b/vl.c > @@ -1738,7 +1738,7 @@ void qemu_system_reset(ShutdownCause reason) > > void qemu_system_guest_panicked(GuestPanicInformation *info) > { > -qemu_log_mask(LOG_GUEST_ERROR, "Guest crashed\n"); > +

Re: [Qemu-devel] [PATCH v6] s390x/cpu: expose the guest crash information

2018-02-07 Thread Christian Borntraeger
On 02/07/2018 05:58 PM, Cornelia Huck wrote: > >> +## >> +# @S390CrashReason: >> +# >> +# Reason why the CPU is in a crashed state. >> +# >> +# @unknown: no crash reason was set >> +# >> +# @disabledwait: the CPU has entered a disabled wait state >> +# >> +# @extintloop: timer interrupt with

Re: [Qemu-devel] [PATCH v6] s390x/cpu: expose the guest crash information

2018-02-07 Thread Eric Blake
On 02/07/2018 10:58 AM, Cornelia Huck wrote: On Wed, 7 Feb 2018 12:38:33 + Christian Borntraeger wrote: This patch is the s390 implementation of guest crash information, similar to commit d187e08dc4 ("i386/cpu: add crash-information QOM property") and the related

Re: [Qemu-devel] [PATCH v6] s390x/cpu: expose the guest crash information

2018-02-07 Thread Cornelia Huck
On Wed, 7 Feb 2018 12:38:33 + Christian Borntraeger wrote: > This patch is the s390 implementation of guest crash information, > similar to commit d187e08dc4 ("i386/cpu: add crash-information QOM > property") and the related commits. We will detect several crash >

Re: [Qemu-devel] [PATCH v6] s390x/cpu: expose the guest crash information

2018-02-07 Thread Christian Borntraeger
On 02/07/2018 02:21 PM, David Hildenbrand wrote: > On 07.02.2018 13:38, Christian Borntraeger wrote: >> This patch is the s390 implementation of guest crash information, >> similar to commit d187e08dc4 ("i386/cpu: add crash-information QOM >> property") and the related commits. We will detect

Re: [Qemu-devel] [PATCH v6] s390x/cpu: expose the guest crash information

2018-02-07 Thread David Hildenbrand
On 07.02.2018 13:38, Christian Borntraeger wrote: > This patch is the s390 implementation of guest crash information, > similar to commit d187e08dc4 ("i386/cpu: add crash-information QOM > property") and the related commits. We will detect several crash > reasons, with the "disabled wait" being

Re: [Qemu-devel] [PATCH v6] s390x/cpu: expose the guest crash information

2018-02-07 Thread Christian Borntraeger
On 02/07/2018 02:07 PM, no-re...@patchew.org wrote: > CC s390x-linux-user/target/s390x/cpu.o > /var/tmp/patchew-tester-tmp-ctncjhw8/src/target/s390x/cpu.c: In function > ‘s390_cpu_get_crash_info’: > /var/tmp/patchew-tester-tmp-ctncjhw8/src/target/s390x/cpu.c:251:39: error: >

[Qemu-devel] [PATCH v6] s390x/cpu: expose the guest crash information

2018-02-07 Thread Christian Borntraeger
This patch is the s390 implementation of guest crash information, similar to commit d187e08dc4 ("i386/cpu: add crash-information QOM property") and the related commits. We will detect several crash reasons, with the "disabled wait" being the most important one, since this is used by all s390