Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-12-10 Thread Igor Mammedov
On Mon, 14 Oct 2013 18:01:20 +0300 Michael S. Tsirkin m...@redhat.com wrote: Add support for acpi pci hotplug using the new infrastructure. PIIX4 legacy interface is maintained as is for machine types 1.6 and older. Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-17 Thread Gerd Hoffmann
Hi, By far the best way to test this is to boot some guest, download tables, then run iasl -d on them. Fully agree. /me did the same when testing with coreboot. Boot linux, with old seabios, with new seabios, with (patched) coreboot, then diffed the iasl decompiled tables. cheers, Gerd

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-17 Thread Paolo Bonzini
Il 17/10/2013 07:34, Michael S. Tsirkin ha scritto: So we could have a qtest for sanity checking ACPI tables. At least fw_cfg is one of the few components that has qtest infrastructure... I don't think we need to do more than that though. The set of sanity checks can start with a simple

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-16 Thread Paolo Bonzini
Il 15/10/2013 22:17, Michael S. Tsirkin ha scritto: OK so I can interpret this in 2 ways wrt bridge hotplug: - it's in shape for 1.7 except the migration which should use subsections (and needs cross-version testing) - it's not in shape for 1.7 Can you tell me which it is please? If

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-16 Thread Anthony Liguori
On Tue, Oct 15, 2013 at 1:17 PM, Michael S. Tsirkin m...@redhat.com wrote: On Tue, Oct 15, 2013 at 09:27:33AM -0700, Anthony Liguori wrote: Paolo Bonzini pbonz...@redhat.com writes: Il 15/10/2013 16:35, Michael S. Tsirkin ha scritto: On Tue, Oct 15, 2013 at 04:31:31PM +0200, Paolo Bonzini

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-16 Thread Michael S. Tsirkin
On Wed, Oct 16, 2013 at 09:38:29AM -0700, Anthony Liguori wrote: On Tue, Oct 15, 2013 at 1:17 PM, Michael S. Tsirkin m...@redhat.com wrote: On Tue, Oct 15, 2013 at 09:27:33AM -0700, Anthony Liguori wrote: Paolo Bonzini pbonz...@redhat.com writes: Il 15/10/2013 16:35, Michael S. Tsirkin

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-16 Thread Anthony Liguori
On Wed, Oct 16, 2013 at 11:18 AM, Michael S. Tsirkin m...@redhat.com wrote: On Wed, Oct 16, 2013 at 09:38:29AM -0700, Anthony Liguori wrote: On Tue, Oct 15, 2013 at 1:17 PM, Michael S. Tsirkin m...@redhat.com wrote: On Tue, Oct 15, 2013 at 09:27:33AM -0700, Anthony Liguori wrote: Paolo

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-16 Thread Michael S. Tsirkin
On Wed, Oct 16, 2013 at 11:18:42AM -0700, Anthony Liguori wrote: On Wed, Oct 16, 2013 at 11:18 AM, Michael S. Tsirkin m...@redhat.com wrote: On Wed, Oct 16, 2013 at 09:38:29AM -0700, Anthony Liguori wrote: On Tue, Oct 15, 2013 at 1:17 PM, Michael S. Tsirkin m...@redhat.com wrote: On

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-16 Thread Paolo Bonzini
Il 16/10/2013 20:37, Michael S. Tsirkin ha scritto: Gleb, Paolo, what do you think? OK to merge kvm unit test into qemu? It depends on qemu anyway, in-tree will make it easier. Maybe someone's looking at this already? I think merging KVM unit tests doesn't make much sense because, with some

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-16 Thread Michael S. Tsirkin
On Wed, Oct 16, 2013 at 11:26:11PM +0200, Paolo Bonzini wrote: Il 16/10/2013 20:37, Michael S. Tsirkin ha scritto: Gleb, Paolo, what do you think? OK to merge kvm unit test into qemu? It depends on qemu anyway, in-tree will make it easier. Maybe someone's looking at this already? I think

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-16 Thread Paolo Bonzini
Il 17/10/2013 00:03, Michael S. Tsirkin ha scritto: On Wed, Oct 16, 2013 at 11:26:11PM +0200, Paolo Bonzini wrote: Il 16/10/2013 20:37, Michael S. Tsirkin ha scritto: Gleb, Paolo, what do you think? OK to merge kvm unit test into qemu? It depends on qemu anyway, in-tree will make it easier.

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-16 Thread Anthony Liguori
On Wed, Oct 16, 2013 at 3:25 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 17/10/2013 00:03, Michael S. Tsirkin ha scritto: On Wed, Oct 16, 2013 at 11:26:11PM +0200, Paolo Bonzini wrote: Il 16/10/2013 20:37, Michael S. Tsirkin ha scritto: Gleb, Paolo, what do you think? OK to merge kvm unit

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-16 Thread Michael S. Tsirkin
On Wed, Oct 16, 2013 at 04:52:35PM -0700, Anthony Liguori wrote: On Wed, Oct 16, 2013 at 3:25 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 17/10/2013 00:03, Michael S. Tsirkin ha scritto: On Wed, Oct 16, 2013 at 11:26:11PM +0200, Paolo Bonzini wrote: Il 16/10/2013 20:37, Michael S.

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-16 Thread Michael S. Tsirkin
On Thu, Oct 17, 2013 at 12:25:32AM +0200, Paolo Bonzini wrote: Il 17/10/2013 00:03, Michael S. Tsirkin ha scritto: On Wed, Oct 16, 2013 at 11:26:11PM +0200, Paolo Bonzini wrote: Il 16/10/2013 20:37, Michael S. Tsirkin ha scritto: Gleb, Paolo, what do you think? OK to merge kvm unit test

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-16 Thread Michael S. Tsirkin
On Thu, Oct 17, 2013 at 12:25:32AM +0200, Paolo Bonzini wrote: qtest could at best host some sanity checks on the ACPI tables, which would catch the MCFG problems that Gerd reported on v5. Depends on how deep the test understands ACPI - the signature was wrong I think. Note I was

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-16 Thread Gleb Natapov
On Thu, Oct 17, 2013 at 08:32:14AM +0300, Michael S. Tsirkin wrote: On Thu, Oct 17, 2013 at 12:25:32AM +0200, Paolo Bonzini wrote: Il 17/10/2013 00:03, Michael S. Tsirkin ha scritto: On Wed, Oct 16, 2013 at 11:26:11PM +0200, Paolo Bonzini wrote: Il 16/10/2013 20:37, Michael S. Tsirkin ha

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-15 Thread Paolo Bonzini
Il 14/10/2013 17:01, Michael S. Tsirkin ha scritto: -VMSTATE_STRUCT(pci0_status, PIIX4PMState, 2, vmstate_pci_status, - struct pci_status), +VMSTATE_STRUCT_TEST(pci0_status, PIIX4PMState, +vmstate_test_no_use_acpi_pci_hotplug,

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-15 Thread Michael S. Tsirkin
On Tue, Oct 15, 2013 at 04:31:31PM +0200, Paolo Bonzini wrote: Il 14/10/2013 17:01, Michael S. Tsirkin ha scritto: -VMSTATE_STRUCT(pci0_status, PIIX4PMState, 2, vmstate_pci_status, - struct pci_status), +VMSTATE_STRUCT_TEST(pci0_status, PIIX4PMState,

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-15 Thread Paolo Bonzini
Il 15/10/2013 16:35, Michael S. Tsirkin ha scritto: On Tue, Oct 15, 2013 at 04:31:31PM +0200, Paolo Bonzini wrote: Il 14/10/2013 17:01, Michael S. Tsirkin ha scritto: -VMSTATE_STRUCT(pci0_status, PIIX4PMState, 2, vmstate_pci_status, - struct pci_status), +

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-15 Thread Michael S. Tsirkin
On Tue, Oct 15, 2013 at 04:50:24PM +0200, Paolo Bonzini wrote: Il 15/10/2013 16:35, Michael S. Tsirkin ha scritto: On Tue, Oct 15, 2013 at 04:31:31PM +0200, Paolo Bonzini wrote: Il 14/10/2013 17:01, Michael S. Tsirkin ha scritto: -VMSTATE_STRUCT(pci0_status, PIIX4PMState, 2,

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-15 Thread Paolo Bonzini
Il 15/10/2013 16:54, Michael S. Tsirkin ha scritto: Seemed cleaner not to. It certainly would be if we had a self-descriptive migration stream format. However, what we have is send bytes, parse them on the destination, hope the format matches. Hence, anything that makes the format

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-15 Thread Michael S. Tsirkin
On Tue, Oct 15, 2013 at 04:54:24PM +0200, Paolo Bonzini wrote: Il 15/10/2013 16:54, Michael S. Tsirkin ha scritto: Seemed cleaner not to. It certainly would be if we had a self-descriptive migration stream format. However, what we have is send bytes, parse them on the

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-15 Thread Paolo Bonzini
Il 15/10/2013 17:07, Michael S. Tsirkin ha scritto: Because the same version can have multiple formats depending on a datum that is not part of the migration stream. I see. Will it be OK if I'll update the version? The version is constant, you cannot change it depending on which PCI flavor

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-15 Thread Michael S. Tsirkin
On Tue, Oct 15, 2013 at 05:09:36PM +0200, Paolo Bonzini wrote: Il 15/10/2013 17:07, Michael S. Tsirkin ha scritto: Because the same version can have multiple formats depending on a datum that is not part of the migration stream. I see. Will it be OK if I'll update the version? The

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-15 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: Il 15/10/2013 16:35, Michael S. Tsirkin ha scritto: On Tue, Oct 15, 2013 at 04:31:31PM +0200, Paolo Bonzini wrote: Il 14/10/2013 17:01, Michael S. Tsirkin ha scritto: -VMSTATE_STRUCT(pci0_status, PIIX4PMState, 2, vmstate_pci_status, -

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-15 Thread Michael S. Tsirkin
On Tue, Oct 15, 2013 at 09:27:33AM -0700, Anthony Liguori wrote: Paolo Bonzini pbonz...@redhat.com writes: Il 15/10/2013 16:35, Michael S. Tsirkin ha scritto: On Tue, Oct 15, 2013 at 04:31:31PM +0200, Paolo Bonzini wrote: Il 14/10/2013 17:01, Michael S. Tsirkin ha scritto: -

[Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-14 Thread Michael S. Tsirkin
Add support for acpi pci hotplug using the new infrastructure. PIIX4 legacy interface is maintained as is for machine types 1.6 and older. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/i386/pc.h | 5 hw/acpi/piix4.c | 75