[Qemu-devel] Re: [FOR 0.12][PATCH] monitor: Accept input only byte-wise

2010-04-16 Thread Paolo Bonzini
The QEMU code appears to be written to assume that it will recvmsg() a complete monitor command in one go + process that, because it closes the FD the moment the data from any recvmsg() is dealt with. This is buggy anyway. This should fix it too: diff --git a/monitor.c b/monitor.c index

[Qemu-devel] Re: [FOR 0.12][PATCH] monitor: Accept input only byte-wise

2010-04-16 Thread Daniel P. Berrange
On Fri, Apr 16, 2010 at 01:14:11PM +0200, Paolo Bonzini wrote: The QEMU code appears to be written to assume that it will recvmsg() a complete monitor command in one go + process that, because it closes the FD the moment the data from any recvmsg() is dealt with. This is buggy anyway.

[Qemu-devel] Re: [FOR 0.12][PATCH] monitor: Accept input only byte-wise

2010-04-16 Thread Paolo Bonzini
On 04/16/2010 03:17 PM, Daniel P. Berrange wrote: On Fri, Apr 16, 2010 at 01:14:11PM +0200, Paolo Bonzini wrote: The QEMU code appears to be written to assume that it will recvmsg() a complete monitor command in one go + process that, because it closes the FD the moment the data from any