[Qemu-devel] Re: [PATCH v6 08/12] pcie/aer: helper functions for pcie aer capability

2010-10-22 Thread Michael S. Tsirkin
On Fri, Oct 22, 2010 at 08:53:15AM +0900, Isaku Yamahata wrote: On Thu, Oct 21, 2010 at 10:07:01AM +0200, Michael S. Tsirkin wrote: On Thu, Oct 21, 2010 at 02:15:24PM +0900, Isaku Yamahata wrote: Thank you for detailed review. On Wed, Oct 20, 2010 at 11:56:16AM +0200, Michael S.

Re: [Qemu-devel] Re: [PATCH v6 08/12] pcie/aer: helper functions for pcie aer capability

2010-10-22 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: On Wed, Oct 20, 2010 at 05:18:57PM +0900, Isaku Yamahata wrote: This patch implements helper functions for pcie aer capability which will be used later. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp Some style comments and a couple of

[Qemu-devel] Re: [PATCH v6 08/12] pcie/aer: helper functions for pcie aer capability

2010-10-21 Thread Michael S. Tsirkin
On Thu, Oct 21, 2010 at 02:15:24PM +0900, Isaku Yamahata wrote: Thank you for detailed review. On Wed, Oct 20, 2010 at 11:56:16AM +0200, Michael S. Tsirkin wrote: +static uint32_t aer_log_del(PCIEAERLog *aer_log) +{ +uint32_t i = aer_log-consumer; +aer_log-consumer =

[Qemu-devel] Re: [PATCH v6 08/12] pcie/aer: helper functions for pcie aer capability

2010-10-21 Thread Isaku Yamahata
On Thu, Oct 21, 2010 at 10:07:01AM +0200, Michael S. Tsirkin wrote: On Thu, Oct 21, 2010 at 02:15:24PM +0900, Isaku Yamahata wrote: Thank you for detailed review. On Wed, Oct 20, 2010 at 11:56:16AM +0200, Michael S. Tsirkin wrote: +static uint32_t aer_log_del(PCIEAERLog *aer_log)

[Qemu-devel] Re: [PATCH v6 08/12] pcie/aer: helper functions for pcie aer capability

2010-10-20 Thread Michael S. Tsirkin
On Wed, Oct 20, 2010 at 05:18:57PM +0900, Isaku Yamahata wrote: This patch implements helper functions for pcie aer capability which will be used later. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp Some style comments and a couple of minor bugs. --- Chnages v5 - v6: - cleaned up

[Qemu-devel] Re: [PATCH v6 08/12] pcie/aer: helper functions for pcie aer capability

2010-10-20 Thread Isaku Yamahata
Thank you for detailed review. On Wed, Oct 20, 2010 at 11:56:16AM +0200, Michael S. Tsirkin wrote: +static uint32_t aer_log_del(PCIEAERLog *aer_log) +{ +uint32_t i = aer_log-consumer; +aer_log-consumer = aer_log_next(aer_log-consumer, aer_log-log_max); +return i; +}