Re: [RFC PATCH-for-8.0 3/3] hw/net/xilinx_ethlite: Replace tswap32() by be32_to_cpu()

2024-04-22 Thread Philippe Mathieu-Daudé
On 13/12/22 14:53, Peter Maydell wrote: On Tue, 13 Dec 2022 at 12:52, Philippe Mathieu-Daudé wrote: This partly revert commit d48751ed4f ("xilinx-ethlite: Simplify byteswapping to/from brams") which states the packet data is stored in big-endian. Signed-off-by: Philippe Mathieu-Daudé @@

Re: [RFC PATCH-for-8.0 3/3] hw/net/xilinx_ethlite: Replace tswap32() by be32_to_cpu()

2022-12-13 Thread Edgar E. Iglesias
On Tue, Dec 13, 2022 at 03:22:54PM +, Peter Maydell wrote: > On Tue, 13 Dec 2022 at 14:23, Edgar E. Iglesias > wrote: > > > > On Tue, Dec 13, 2022 at 02:18:42PM +, Peter Maydell wrote: > > > On Tue, 13 Dec 2022 at 14:14, Edgar E. Iglesias > > > wrote: > > > > > > > > On Tue, Dec 13, 2022

Re: [RFC PATCH-for-8.0 3/3] hw/net/xilinx_ethlite: Replace tswap32() by be32_to_cpu()

2022-12-13 Thread Peter Maydell
On Tue, 13 Dec 2022 at 14:23, Edgar E. Iglesias wrote: > > On Tue, Dec 13, 2022 at 02:18:42PM +, Peter Maydell wrote: > > On Tue, 13 Dec 2022 at 14:14, Edgar E. Iglesias > > wrote: > > > > > > On Tue, Dec 13, 2022 at 01:53:15PM +, Peter Maydell wrote: > > > > On Tue, 13 Dec 2022 at

Re: [RFC PATCH-for-8.0 3/3] hw/net/xilinx_ethlite: Replace tswap32() by be32_to_cpu()

2022-12-13 Thread Edgar E. Iglesias
On Tue, Dec 13, 2022 at 02:18:42PM +, Peter Maydell wrote: > On Tue, 13 Dec 2022 at 14:14, Edgar E. Iglesias > wrote: > > > > On Tue, Dec 13, 2022 at 01:53:15PM +, Peter Maydell wrote: > > > On Tue, 13 Dec 2022 at 12:52, Philippe Mathieu-Daudé > > > wrote: > > > > > > > > This partly

Re: [RFC PATCH-for-8.0 3/3] hw/net/xilinx_ethlite: Replace tswap32() by be32_to_cpu()

2022-12-13 Thread Peter Maydell
On Tue, 13 Dec 2022 at 14:14, Edgar E. Iglesias wrote: > > On Tue, Dec 13, 2022 at 01:53:15PM +, Peter Maydell wrote: > > On Tue, 13 Dec 2022 at 12:52, Philippe Mathieu-Daudé > > wrote: > > > > > > This partly revert commit d48751ed4f ("xilinx-ethlite: > > > Simplify byteswapping to/from

Re: [RFC PATCH-for-8.0 3/3] hw/net/xilinx_ethlite: Replace tswap32() by be32_to_cpu()

2022-12-13 Thread Edgar E. Iglesias
On Tue, Dec 13, 2022 at 01:53:15PM +, Peter Maydell wrote: > On Tue, 13 Dec 2022 at 12:52, Philippe Mathieu-Daudé > wrote: > > > > This partly revert commit d48751ed4f ("xilinx-ethlite: > > Simplify byteswapping to/from brams") which states the > > packet data is stored in big-endian. > > >

Re: [RFC PATCH-for-8.0 3/3] hw/net/xilinx_ethlite: Replace tswap32() by be32_to_cpu()

2022-12-13 Thread Peter Maydell
On Tue, 13 Dec 2022 at 12:52, Philippe Mathieu-Daudé wrote: > > This partly revert commit d48751ed4f ("xilinx-ethlite: > Simplify byteswapping to/from brams") which states the > packet data is stored in big-endian. > > Signed-off-by: Philippe Mathieu-Daudé > @@ -102,8 +102,8 @@ eth_read(void

[RFC PATCH-for-8.0 3/3] hw/net/xilinx_ethlite: Replace tswap32() by be32_to_cpu()

2022-12-13 Thread Philippe Mathieu-Daudé
This partly revert commit d48751ed4f ("xilinx-ethlite: Simplify byteswapping to/from brams") which states the packet data is stored in big-endian. Signed-off-by: Philippe Mathieu-Daudé --- hw/net/xilinx_ethlite.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git