Re: [PATCH] target/loongarch/kvm: Fix VM recovery from disk failures

2024-05-07 Thread Peter Maydell
On Tue, 7 May 2024 at 16:47, Peter Xu wrote: > > On Tue, May 07, 2024 at 04:12:34PM +0800, gaosong wrote: > > Just remove CONIFG_KVM would be OK? > > You're the loongarch maintainer so I'd say your call. :) > > If you're not yet sure, IMHO we should go with the simplest, which is the > original

Re: [PATCH] target/loongarch/kvm: Fix VM recovery from disk failures

2024-05-07 Thread Peter Xu
On Tue, May 07, 2024 at 04:12:34PM +0800, gaosong wrote: > Just remove CONIFG_KVM  would be OK? You're the loongarch maintainer so I'd say your call. :) If you're not yet sure, IMHO we should go with the simplest, which is the original oneliner patch. Thanks, -- Peter Xu

Re: [PATCH] target/loongarch/kvm: Fix VM recovery from disk failures

2024-05-07 Thread gaosong
Thanks for the comments ! 在 2024/5/2 下午8:45, Fabiano Rosas 写道: Peter Xu writes: On Tue, Apr 30, 2024 at 11:00:24AM -0300, Fabiano Rosas wrote: Philippe Mathieu-Daudé writes: (Cc'ing migration maintainers) On 30/4/24 03:23, Song Gao wrote: vmstate does not save kvm_state_conter, which

Re: [PATCH] target/loongarch/kvm: Fix VM recovery from disk failures

2024-05-02 Thread Fabiano Rosas
Peter Xu writes: > On Tue, Apr 30, 2024 at 11:00:24AM -0300, Fabiano Rosas wrote: >> Philippe Mathieu-Daudé writes: >> >> > (Cc'ing migration maintainers) >> > >> > On 30/4/24 03:23, Song Gao wrote: >> >> vmstate does not save kvm_state_conter, >> >> which can cause VM recovery from disk to

Re: [PATCH] target/loongarch/kvm: Fix VM recovery from disk failures

2024-05-01 Thread Peter Xu
On Tue, Apr 30, 2024 at 11:00:24AM -0300, Fabiano Rosas wrote: > Philippe Mathieu-Daudé writes: > > > (Cc'ing migration maintainers) > > > > On 30/4/24 03:23, Song Gao wrote: > >> vmstate does not save kvm_state_conter, > >> which can cause VM recovery from disk to fail. > > > > Cc:

Re: [PATCH] target/loongarch/kvm: Fix VM recovery from disk failures

2024-04-30 Thread Fabiano Rosas
Philippe Mathieu-Daudé writes: > (Cc'ing migration maintainers) > > On 30/4/24 03:23, Song Gao wrote: >> vmstate does not save kvm_state_conter, >> which can cause VM recovery from disk to fail. > > Cc: qemu-sta...@nongnu.org > Fixes: d11681c94f ("target/loongarch: Implement kvm_arch_init_vcpu")

Re: [PATCH] target/loongarch/kvm: Fix VM recovery from disk failures

2024-04-30 Thread Philippe Mathieu-Daudé
(Cc'ing migration maintainers) On 30/4/24 03:23, Song Gao wrote: vmstate does not save kvm_state_conter, which can cause VM recovery from disk to fail. Cc: qemu-sta...@nongnu.org Fixes: d11681c94f ("target/loongarch: Implement kvm_arch_init_vcpu") Signed-off-by: Song Gao ---