Re: [PATCH 26/52] migration/rdma: Replace int error_state by bool errored

2023-09-27 Thread Markus Armbruster
Eric Blake writes: > On Mon, Sep 18, 2023 at 04:41:40PM +0200, Markus Armbruster wrote: >> All we do with the value of RDMAContext member @error_state is test >> whether it's zero. Change to bool and rename to @errored. >> >> Signed-off-by: Markus Armbruster >> --- >> migration/rdma.c | 66

Re: [PATCH 26/52] migration/rdma: Replace int error_state by bool errored

2023-09-27 Thread Eric Blake
On Mon, Sep 18, 2023 at 04:41:40PM +0200, Markus Armbruster wrote: > All we do with the value of RDMAContext member @error_state is test > whether it's zero. Change to bool and rename to @errored. > > Signed-off-by: Markus Armbruster > --- > migration/rdma.c | 66

Re: [PATCH 26/52] migration/rdma: Replace int error_state by bool errored

2023-09-26 Thread Zhijian Li (Fujitsu)
On 25/09/2023 15:09, Markus Armbruster wrote: > "Zhijian Li (Fujitsu)" writes: > >> On 18/09/2023 22:41, Markus Armbruster wrote: >>> All we do with the value of RDMAContext member @error_state is test >>> whether it's zero. Change to bool and rename to @errored. >>> >> >> make sense! >> >>

Re: [PATCH 26/52] migration/rdma: Replace int error_state by bool errored

2023-09-25 Thread Markus Armbruster
"Zhijian Li (Fujitsu)" writes: > On 18/09/2023 22:41, Markus Armbruster wrote: >> All we do with the value of RDMAContext member @error_state is test >> whether it's zero. Change to bool and rename to @errored. >> > > make sense! > > Reviewed-by: Li Zhijian > > Can we move this patch ahead

Re: [PATCH 26/52] migration/rdma: Replace int error_state by bool errored

2023-09-25 Thread Zhijian Li (Fujitsu)
On 18/09/2023 22:41, Markus Armbruster wrote: > All we do with the value of RDMAContext member @error_state is test > whether it's zero. Change to bool and rename to @errored. > make sense! Reviewed-by: Li Zhijian Can we move this patch ahead "[PATCH 23/52] migration/rdma: Clean up