Re: [PATCH v3] smb daemon get additional command line parameters from env variable

2019-11-01 Thread Samuel Thibault
Jordi Pujol, le ven. 01 nov. 2019 15:38:19 +0100, a ecrit: > +options = g_getenv("SMBDOPTIONS"); > +if (options) { > +smb_cmdline = g_strdup_printf("%s %s", smb_cmdline, options); > +} > +g_free(options); But then do not free it :) Samuel

Re: [PATCH v3] smb daemon get additional command line parameters from env variable

2019-11-01 Thread Jordi Pujol
On Thu, Oct 31, 2019 at 11:50 PM Samuel Thibault wrote: > Why strduping it? you can just use g_getenv. ACK, I have also placed the variable declaration after the others. Here is the v3 of this patch. ** From: Jordi Pujol Palomer