Re: [Qemu-devel] [PATCH v2] linux-user: Fix 32-on-64 mmap for x86_64

2011-12-20 Thread Alexander Graf
On 20.12.2011, at 08:46, 陳韋任 wrote: This patch is actually wrong and we should rather make proper -R values the default instead of relying on MAP_32BIT. I don't understand what make proper -R values means. Where/how

Re: [Qemu-devel] [PATCH v2] linux-user: Fix 32-on-64 mmap for x86_64

2011-12-20 Thread 陳韋任
This patch is actually wrong and we should rather make proper -R values the default instead of relying on MAP_32BIT. I don't understand what make proper -R values means. Where/how we can apply -R? Please see

Re: [Qemu-devel] [PATCH v2] linux-user: Fix 32-on-64 mmap for x86_64

2011-12-20 Thread Alexander Graf
On 21.12.2011, at 03:43, 陳韋任 che...@iis.sinica.edu.tw wrote: This patch is actually wrong and we should rather make proper -R values the default instead of relying on MAP_32BIT. I don't understand what make proper -R

Re: [Qemu-devel] [PATCH v2] linux-user: Fix 32-on-64 mmap for x86_64

2011-12-19 Thread 陳韋任
This patch is actually wrong and we should rather make proper -R values the default instead of relying on MAP_32BIT. I don't understand what make proper -R values means. Where/how we can apply -R? Regards, chenwj --

Re: [Qemu-devel] [PATCH v2] linux-user: Fix 32-on-64 mmap for x86_64

2011-12-19 Thread Alexander Graf
On 25.11.2011, at 14:06, Peter Maydell wrote: On 24 November 2011 23:43, Alexander Graf ag...@suse.de wrote: --- v1 - v2: - make prettier by just wrapping mmap in linux-user/mmap.c Hmm. I prefer the non-wrapped version :-) In particular, qemu_mmap() implies that (like other qemu_foo

Re: [Qemu-devel] [PATCH v2] linux-user: Fix 32-on-64 mmap for x86_64

2011-11-25 Thread Peter Maydell
On 24 November 2011 23:43, Alexander Graf ag...@suse.de wrote: --- v1 - v2:  - make prettier by just wrapping mmap in linux-user/mmap.c Hmm. I prefer the non-wrapped version :-) In particular, qemu_mmap() implies that (like other qemu_foo wrappers) this is a portability wrapper that should