[Qemu-devel] Re: [PATCH 1/8] pci: pci_default_cap_write_config ignores wmask

2010-11-12 Thread Michael S. Tsirkin
On Thu, Nov 11, 2010 at 11:03:19PM -0700, Alex Williamson wrote: On Fri, 2010-11-12 at 07:22 +0200, Michael S. Tsirkin wrote: On Thu, Nov 11, 2010 at 07:55:01PM -0700, Alex Williamson wrote: Make use of wmask, just like the rest of config space. Signed-off-by: Alex Williamson

[Qemu-devel] Re: [PATCH 4/8] pci: Replace used bitmap with capability byte map

2010-11-12 Thread Michael S. Tsirkin
On Thu, Nov 11, 2010 at 11:07:15PM -0700, Alex Williamson wrote: On Fri, 2010-11-12 at 07:40 +0200, Michael S. Tsirkin wrote: On Thu, Nov 11, 2010 at 07:55:43PM -0700, Alex Williamson wrote: Capabilities are allocated in bytes, so we can track both whether a byte is used and by what

[Qemu-devel] Re: [RFC PATCH 8/8] device-assignment: pass through and stub more PCI caps

2010-11-12 Thread Michael S. Tsirkin
On Thu, Nov 11, 2010 at 11:30:07PM -0700, Alex Williamson wrote: On Fri, 2010-11-12 at 07:36 +0200, Michael S. Tsirkin wrote: On Thu, Nov 11, 2010 at 07:56:46PM -0700, Alex Williamson wrote: Some drivers depend on finding capabilities like power management, PCI express/X, vital product

[Qemu-devel] Re: [PATCH 2/3] virtio-pci: Use ioeventfd for virtqueue notify

2010-11-12 Thread Stefan Hajnoczi
On Thu, Nov 11, 2010 at 3:53 PM, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Nov 11, 2010 at 01:47:21PM +, Stefan Hajnoczi wrote: Care must be taken not to interfere with vhost-net, which already uses ioeventfd host notifiers.  The following list shows the behavior implemented in

[Qemu-devel] Re: Cannot not unplug cold-plugged devices

2010-11-12 Thread Michael S. Tsirkin
On Fri, Nov 12, 2010 at 04:24:11PM +0900, Isaku Yamahata wrote: On Thu, Nov 11, 2010 at 11:29:39PM -0700, Cam Macdonell wrote: Hi, I was trying to do a device_del on my ivshmem device and it won't work unless the device is added via hotplug. If the device is coldplugged (added at

[Qemu-devel] Re: [PATCH 6/8] device-assignment: Move PCI capabilities to match physical hardware

2010-11-12 Thread Michael S. Tsirkin
On Thu, Nov 11, 2010 at 07:56:13PM -0700, Alex Williamson wrote: Now that common PCI code doesn't have a hangup on capabilities being contiguous, Hmm, this comment confused me : there's no requirement of contigious allocations in current code in pci.c, is there? -- MST

Re: [Qemu-devel] Re: [PATCH 2/3] virtio-pci: Use ioeventfd for virtqueue notify

2010-11-12 Thread Stefan Hajnoczi
On Thu, Nov 11, 2010 at 4:45 PM, Christoph Hellwig h...@infradead.org wrote: On Thu, Nov 11, 2010 at 01:47:21PM +, Stefan Hajnoczi wrote: Some virtio devices are known to have guest drivers which expect a notify to be processed synchronously and spin waiting for completion.  Only enable

[Qemu-devel] Re: [PATCH 2/3] virtio-pci: Use ioeventfd for virtqueue notify

2010-11-12 Thread Michael S. Tsirkin
On Fri, Nov 12, 2010 at 09:18:48AM +, Stefan Hajnoczi wrote: On Thu, Nov 11, 2010 at 3:53 PM, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Nov 11, 2010 at 01:47:21PM +, Stefan Hajnoczi wrote: Care must be taken not to interfere with vhost-net, which already uses ioeventfd host

[Qemu-devel] [Bug 671831] Re: Sparc guest assert error

2010-11-12 Thread Stefan Hajnoczi
** Changed in: qemu Status: New = In Progress ** Changed in: qemu Assignee: (unassigned) = Stefan Hajnoczi (stefanha) -- Sparc guest assert error https://bugs.launchpad.net/bugs/671831 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

[Qemu-devel] (no subject)

2010-11-12 Thread Stefan Hajnoczi

Re: [Qemu-devel] No Virtual Console

2010-11-12 Thread qemu
Yes - that's it! The SDL window. I can't get it to show up ... any ideas? Thanks! On Fri, Nov 12, 2010 00:18 AM, Mulyadi Santosa mulyadi.sant...@gmail.com wrote: Hi... On Fri, Nov 12, 2010 at 03:30, Russell Morris rmor...@rkmorris.us wrote: Hi, Yes, I am in runlevel 5.

[Qemu-devel] [PATCH 4/4] pci: clean up of pci status register

2010-11-12 Thread Isaku Yamahata
This patch refine the initialization/reset of pci status registers. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/pci.c | 40 ++-- 1 files changed, 38 insertions(+), 2 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index a16e763..184db6c 100644

[Qemu-devel] [PATCH 0/4] pci: clean up of command/status register

2010-11-12 Thread Isaku Yamahata
This patch set cleans up of initialization of pci command/status register. Isaku Yamahata (4): pci: revise pci command register initialization pci: clean up pci command register io/memory bit initialization pci: fix accesses to pci status register pci: clean up of pci status register

[Qemu-devel] [PATCH 1/4] pci: revise pci command register initialization

2010-11-12 Thread Isaku Yamahata
This patch cleans up command register initialization with comments. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/pci.c | 42 ++ 1 files changed, 42 insertions(+), 0 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 8b79ad6..86900a2

[Qemu-devel] [PATCH 2/4] pci: clean up pci command register io/memory bit initialization

2010-11-12 Thread Isaku Yamahata
This patch fixes the initialization of io/memory bit of command register. Those bits for type 1 device is RW. Those bits for type 0 device is RO = 0 if it has no io/memory BAR RW if it has io/memory BAR Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/pci.c | 20

[Qemu-devel] [PATCH] scsi-disk: Move active request asserts

2010-11-12 Thread Stefan Hajnoczi
SCSI read/write requests should not be re-issued before the current fragment of I/O completes. There are asserts in scsi-disk.c that guard this constraint but they trigger on SPARC Linux 2.4. It turns out that the asserts are too early in the code path and don't allow for read requests to

[Qemu-devel] [PATCH 3/4] pci: fix accesses to pci status register

2010-11-12 Thread Isaku Yamahata
pci status register is 16 bit, not 8 bit. So use helper function to manipulate status register. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/pci.c | 21 + 1 files changed, 13 insertions(+), 8 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index

[Qemu-devel] Re: [patch] fix scsi-generic

2010-11-12 Thread Paolo Bonzini
On 08/09/2010 01:51 AM, adq wrote: Figured out what the problem is - READ DVD STRUCTURE has its xfer length in an unexpected place, so hw/scsi-bus.c retrieves completely the wrong value for the transfer length. Attached nasty hacky (!) patch fixes it as a proof of concept, will see what I can do

[Qemu-devel] Re: Cannot not unplug cold-plugged devices

2010-11-12 Thread Isaku Yamahata
On Fri, Nov 12, 2010 at 11:18:57AM +0200, Michael S. Tsirkin wrote: On Fri, Nov 12, 2010 at 04:24:11PM +0900, Isaku Yamahata wrote: On Thu, Nov 11, 2010 at 11:29:39PM -0700, Cam Macdonell wrote: Hi, I was trying to do a device_del on my ivshmem device and it won't work unless the

[Qemu-devel] Re: [PATCH] scsi-disk: Move active request asserts

2010-11-12 Thread Kevin Wolf
Am 12.11.2010 10:57, schrieb Stefan Hajnoczi: SCSI read/write requests should not be re-issued before the current fragment of I/O completes. There are asserts in scsi-disk.c that guard this constraint but they trigger on SPARC Linux 2.4. It turns out that the asserts are too early in the

Re: [Qemu-devel] [PATCH 1/3] qemu-char: Introduce Memory driver

2010-11-12 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: This driver handles in-memory chardev operations. That's, all writes to this driver are stored in an internal buffer and it doesn't talk to the external world in any way. Right now it's very simple: it supports only writes. But it can be easily

Re: [Qemu-devel] [PATCH 1/3] qemu-char: Introduce Memory driver

2010-11-12 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Thu, 11 Nov 2010 17:32:06 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Thu, 11 Nov 2010 16:30:26 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino

[Qemu-devel] Re: Cannot not unplug cold-plugged devices

2010-11-12 Thread Michael S. Tsirkin
On Fri, Nov 12, 2010 at 06:59:52PM +0900, Isaku Yamahata wrote: On Fri, Nov 12, 2010 at 11:18:57AM +0200, Michael S. Tsirkin wrote: On Fri, Nov 12, 2010 at 04:24:11PM +0900, Isaku Yamahata wrote: On Thu, Nov 11, 2010 at 11:29:39PM -0700, Cam Macdonell wrote: Hi, I was trying to

Re: [Qemu-devel] Re: [PATCH] Implement a virtio GPU transport

2010-11-12 Thread Ian Molton
On 10/11/10 17:47, Anthony Liguori wrote: On 11/10/2010 11:22 AM, Ian Molton wrote: Ping ? I think the best way forward is to post patches. I posted links to the git trees. I can post patches, but they are *large*. Do you really want me to post them? To summarize what I was trying to

Re: [Qemu-devel] [PATCH] virtio-9p: fix build on !CONFIG_UTIMENSAT v2

2010-11-12 Thread Jes Sorensen
On 11/08/10 07:44, M. Mohan Kumar wrote: This patch introduce a fallback mechanism for old systems that do not support utimensat. This will fix build failure with following warnings: hw/virtio-9p-local.c: In function 'local_utimensat': hw/virtio-9p-local.c:479: warning: implicit declaration

Re: [Qemu-devel] Access to specific isa card with Qemu???

2010-11-12 Thread Jes Sorensen
On 11/08/10 17:21, Djamel Hakkar wrote: Hello, We have a software that runs on MS-DOS and must communicate with a specific card installed on port isa. We want to use this software in Qemu with a machine that runs XP. Is it possible to access to the ISA port with Qemu in this case? Do

[Qemu-devel] Re: Cannot not unplug cold-plugged devices

2010-11-12 Thread Isaku Yamahata
On Fri, Nov 12, 2010 at 01:26:30PM +0200, Michael S. Tsirkin wrote: No, I am just trying to understand why is hotplug event dangerous. We still get it if we do device add before starting the VM, right? I'm not sure if it's safe to call enable/disable_device() and pm_update_sci() before starting

[Qemu-devel] Re: [PATCH 2/3] virtio-pci: Use ioeventfd for virtqueue notify

2010-11-12 Thread Stefan Hajnoczi
On Fri, Nov 12, 2010 at 9:25 AM, Michael S. Tsirkin m...@redhat.com wrote: On Fri, Nov 12, 2010 at 09:18:48AM +, Stefan Hajnoczi wrote: On Thu, Nov 11, 2010 at 3:53 PM, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Nov 11, 2010 at 01:47:21PM +, Stefan Hajnoczi wrote: Care must be

[Qemu-devel] Add support for SystemTAP and DTrace tracing backends (v6)

2010-11-12 Thread Daniel P. Berrange
An update of the SystemTAP/DTrace patches from http://lists.gnu.org/archive/html/qemu-devel/2010-11/msg00563.html The first patch contains the generic DTrace tracing backend support. The second patch contains additional pieces for SystemTAP to generate a tapset for each of the qemu-system-XXX

[Qemu-devel] [PATCH 1/2] Add a DTrace tracing backend targetted for SystemTAP compatability

2010-11-12 Thread Daniel P. Berrange
This introduces a new tracing backend that targets the SystemTAP implementation of DTrace userspace tracing. The core functionality should be applicable and standard across any DTrace implementation on Solaris, OS-X, *BSD, but the Makefile rules will likely need some small additional changes to

[Qemu-devel] [PATCH 2/2] Add support for generating a systemtap tapset static probes

2010-11-12 Thread Daniel P. Berrange
This introduces generation of a qemu.stp/qemu-system-XXX.stp files which provides tapsets with friendly names for static probes their arguments. Instead of probe process(qemu).mark(qemu_malloc) { printf(Malloc %d %p\n, $arg1, $arg2); } It is now possible todo probe

[Qemu-devel] [PATCH v3 2/3] virtio-pci: Use ioeventfd for virtqueue notify

2010-11-12 Thread Stefan Hajnoczi
Virtqueue notify is currently handled synchronously in userspace virtio. This prevents the vcpu from executing guest code while hardware emulation code handles the notify. On systems that support KVM, the ioeventfd mechanism can be used to make virtqueue notify a lightweight exit by deferring

Re: [Qemu-devel] Re: [PATCH] Implement a virtio GPU transport

2010-11-12 Thread Anthony Liguori
On 11/12/2010 06:14 AM, Ian Molton wrote: On 10/11/10 17:47, Anthony Liguori wrote: On 11/10/2010 11:22 AM, Ian Molton wrote: Ping ? I think the best way forward is to post patches. I posted links to the git trees. I can post patches, but they are *large*. Do you really want me to post

[Qemu-devel] [PATCH v3 1/3] virtio-pci: Rename bugs field to flags

2010-11-12 Thread Stefan Hajnoczi
The VirtIOPCIProxy bugs field is currently used to enable workarounds for older guests. Rename it to flags so that other per-device behavior can be tracked. A later patch uses the flags field to remember whether ioeventfd should be used for virtqueue host notification. Signed-off-by: Stefan

Re: [Qemu-devel] [PATCH 1/2] Add a DTrace tracing backend targetted for SystemTAP compatability

2010-11-12 Thread Stefan Hajnoczi
On Fri, Nov 12, 2010 at 1:20 PM, Daniel P. Berrange berra...@redhat.com wrote: This introduces a new tracing backend that targets the SystemTAP implementation of DTrace userspace tracing. The core functionality should be applicable and standard across any DTrace implementation on Solaris,

[Qemu-devel] [PATCH v3 3/3] virtio-pci: Don't use ioeventfd on old kernels

2010-11-12 Thread Stefan Hajnoczi
There used to be a limit of 6 KVM io bus devices inside the kernel. On such a kernel, don't use ioeventfd for virtqueue host notification since the limit is reached too easily. This ensures that existing vhost-net setups (which always use ioeventfd) have ioeventfds available so they can continue

Re: [Qemu-devel] [PATCH 1/3] qemu-char: Introduce Memory driver

2010-11-12 Thread Luiz Capitulino
On Fri, 12 Nov 2010 11:16:54 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Thu, 11 Nov 2010 17:32:06 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Thu, 11 Nov 2010 16:30:26

Re: [Qemu-devel] [PATCH 2/2] Add support for generating a systemtap tapset static probes

2010-11-12 Thread Stefan Hajnoczi
On Fri, Nov 12, 2010 at 1:20 PM, Daniel P. Berrange berra...@redhat.com wrote: This introduces generation of a qemu.stp/qemu-system-XXX.stp files which provides tapsets with friendly names for static probes their arguments. Instead of    probe process(qemu).mark(qemu_malloc) {        

[Qemu-devel] Re: [PATCH 6/8] device-assignment: Move PCI capabilities to match physical hardware

2010-11-12 Thread Alex Williamson
On Fri, 2010-11-12 at 11:20 +0200, Michael S. Tsirkin wrote: On Thu, Nov 11, 2010 at 07:56:13PM -0700, Alex Williamson wrote: Now that common PCI code doesn't have a hangup on capabilities being contiguous, Hmm, this comment confused me : there's no requirement of contigious allocations

Re: [Qemu-devel] [PATCH 1/3] qemu-char: Introduce Memory driver

2010-11-12 Thread Luiz Capitulino
On Fri, 12 Nov 2010 11:21:57 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: This driver handles in-memory chardev operations. That's, all writes to this driver are stored in an internal buffer and it doesn't talk to the external world in

[Qemu-devel] Re: [PATCH v4 1/5] docs: Add QED image format specification

2010-11-12 Thread Kevin Wolf
Am 28.10.2010 13:01, schrieb Stefan Hajnoczi: Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- docs/specs/qed_spec.txt | 128 +++ 1 files changed, 128 insertions(+), 0 deletions(-) create mode 100644 docs/specs/qed_spec.txt

[Qemu-devel] Re: [PATCH v3 3/3] virtio-pci: Don't use ioeventfd on old kernels

2010-11-12 Thread Stefan Hajnoczi
On Fri, Nov 12, 2010 at 1:24 PM, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: @@ -1046,6 +1087,11 @@ int kvm_has_xcrs(void)     return kvm_state-xcrs;  } +int kvm_has_many_ioeventfds(void) +{ +    return kvm_state-many_ioeventfds; +} + Missing if (!kvm_enabled()) { return 0; }.

Re: [Qemu-devel] Re: [PATCH v4 1/5] docs: Add QED image format specification

2010-11-12 Thread Stefan Hajnoczi
On Fri, Nov 12, 2010 at 1:58 PM, Kevin Wolf kw...@redhat.com wrote: Am 28.10.2010 13:01, schrieb Stefan Hajnoczi: Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com ---  docs/specs/qed_spec.txt |  128 +++  1 files changed, 128

Re: [Qemu-devel] [PATCH 1/3] qemu-char: Introduce Memory driver

2010-11-12 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 12 Nov 2010 11:21:57 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: [...] +QString *qemu_chr_mem_to_qs(CharDriverState *chr) +{ +MemoryDriver *d = chr-opaque; + +if

Re: [Qemu-devel] Re: [Try2][PATCH] Initial implementation of a mpeg1 layer2 streaming audio driver.

2010-11-12 Thread Anthony Liguori
On 11/08/2010 12:15 AM, François Revol wrote: Le 8 nov. 2010 à 04:57, malc a écrit : And can you, please, elaborate some more on usage scenarios of this thing? cf. http://dev.haiku-os.org/browser/haiku/trunk/3rdparty/mmu_man/onlinedemo/haiku.php Sorry my PHP skills have

Re: [Qemu-devel] [PATCH 1/3] qemu-char: Introduce Memory driver

2010-11-12 Thread Luiz Capitulino
On Fri, 12 Nov 2010 15:16:33 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 12 Nov 2010 11:21:57 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: [...] +QString

[Qemu-devel] [PATCH] Makefile: Fix check dependency breakage

2010-11-12 Thread Luiz Capitulino
Commit b152aa84d52882bb1846485a89baf13aa07c86bc broke the unit-tests build, fix it. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- Makefile | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/Makefile b/Makefile index 02698e9..719aca9 100644 ---

Re: [Qemu-devel] [PATCH 1/3] qemu-char: Introduce Memory driver

2010-11-12 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 12 Nov 2010 15:16:33 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 12 Nov 2010 11:21:57 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino

Re: [Qemu-devel] [PATCH] Makefile: Fix check dependency breakage

2010-11-12 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: Commit b152aa84d52882bb1846485a89baf13aa07c86bc broke the unit-tests build, fix it. Got bitten by that, and the patch fixes it for me.

[Qemu-devel] Re: [PATCH 4/8] pci: Replace used bitmap with capability byte map

2010-11-12 Thread Alex Williamson
On Fri, 2010-11-12 at 11:02 +0200, Michael S. Tsirkin wrote: On Thu, Nov 11, 2010 at 11:07:15PM -0700, Alex Williamson wrote: On Fri, 2010-11-12 at 07:40 +0200, Michael S. Tsirkin wrote: On Thu, Nov 11, 2010 at 07:55:43PM -0700, Alex Williamson wrote: Capabilities are allocated in bytes,

[Qemu-devel] [PATCH 0/2] v7 Decouple block device removal from device removal

2010-11-12 Thread Ryan Harper
Once more dear friends, v7 This patch series decouples the detachment of a block device from the removal of the backing pci-device. Removal of a hotplugged pci device requires the guest to respond before qemu tears down the block device. In some cases, the guest may not respond leaving the guest

[Qemu-devel] [PATCH 1/2] Implement drive_del to decouple block removal from device removal

2010-11-12 Thread Ryan Harper
Currently device hotplug removal code is tied to device removal via ACPI. All pci devices that are removable via device_del() require the guest to respond to the request. In some cases the guest may not respond leaving the device still accessible to the guest. The management layer doesn't

Re: [Qemu-devel] [PATCH 1/3] qemu-char: Introduce Memory driver

2010-11-12 Thread Luiz Capitulino
On Fri, 12 Nov 2010 16:04:39 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 12 Nov 2010 15:16:33 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 12 Nov 2010 11:21:57

[Qemu-devel] Re: [PATCH v4 2/5] qed: Add QEMU Enhanced Disk image format

2010-11-12 Thread Kevin Wolf
Am 28.10.2010 13:01, schrieb Stefan Hajnoczi: This patch introduces the qed on-disk layout and implements image creation. Later patches add read/write and other functionality. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- Makefile.objs |1 + block/qed.c | 548

[Qemu-devel] [PATCH 2/2] Add qmp version of drive_del

2010-11-12 Thread Ryan Harper
Signed-off-by: Ryan Harper ry...@us.ibm.com --- qmp-commands.hx | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) diff --git a/qmp-commands.hx b/qmp-commands.hx index 793cf1c..1e0d4e9 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -338,6 +338,35 @@

[Qemu-devel] Re: [RFC PATCH 8/8] device-assignment: pass through and stub more PCI caps

2010-11-12 Thread Alex Williamson
On Fri, 2010-11-12 at 11:11 +0200, Michael S. Tsirkin wrote: On Thu, Nov 11, 2010 at 11:30:07PM -0700, Alex Williamson wrote: On Fri, 2010-11-12 at 07:36 +0200, Michael S. Tsirkin wrote: On Thu, Nov 11, 2010 at 07:56:46PM -0700, Alex Williamson wrote: Some drivers depend on finding

[Qemu-devel] Re: [PATCH 1/8] pci: pci_default_cap_write_config ignores wmask

2010-11-12 Thread Alex Williamson
On Fri, 2010-11-12 at 10:48 +0200, Michael S. Tsirkin wrote: On Thu, Nov 11, 2010 at 11:03:19PM -0700, Alex Williamson wrote: On Fri, 2010-11-12 at 07:22 +0200, Michael S. Tsirkin wrote: On Thu, Nov 11, 2010 at 07:55:01PM -0700, Alex Williamson wrote: Make use of wmask, just like the

Re: [Qemu-devel] [PATCH 1/3] qemu-char: Introduce Memory driver

2010-11-12 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 12 Nov 2010 11:16:54 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Thu, 11 Nov 2010 17:32:06 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino

[Qemu-devel] Re: [patch 0/3] block migration fixes

2010-11-12 Thread Marcelo Tosatti
On Thu, Nov 11, 2010 at 06:06:02PM +0900, Yoshiaki Tamura wrote: Marcelo Tosatti wrote: On Tue, Nov 09, 2010 at 03:02:12PM +0900, Yoshiaki Tamura wrote: Marcelo Tosatti wrote: Following patchset fixes block migration corruption issues. Hi Marcelo, Thanks for looking into this issue.

[Qemu-devel] Re: [RfC PATCH] spice: qmp windup: connection events info command.

2010-11-12 Thread Luiz Capitulino
On Thu, 11 Nov 2010 13:49:32 +0100 Gerd Hoffmann kra...@redhat.com wrote: Hi, Looking for comments especially from Luiz and Daniel (aka qmp and libvirt masters) ... This patch adds support for connection events to spice. The events are quite simliar to the vnc events. Unlike vnc

Re: [Qemu-devel] [PATCH 1/3] qemu-char: Introduce Memory driver

2010-11-12 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 12 Nov 2010 16:04:39 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 12 Nov 2010 15:16:33 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino

[Qemu-devel] Announce: Auto/Lazy-migration Patches RFC on linux-numa list

2010-11-12 Thread Lee Schermerhorn
At last weeks' LPC, there was some interest in my patches for Auto/Lazy Migration to improve locality and possibly performance of unpinned guest VMs on a NUMA platform. As a result of these conversations I have reposted the patches [4 series, ~40 patches] as RFCs to the linux-numa list. Links to

Re: [Qemu-devel] [PATCH 1/2] Implement drive_del to decouple block removal from device removal

2010-11-12 Thread Markus Armbruster
Ryan Harper ry...@us.ibm.com writes: Currently device hotplug removal code is tied to device removal via ACPI. All pci devices that are removable via device_del() require the guest to respond to the request. In some cases the guest may not respond leaving the device still accessible to the

Re: [Qemu-devel] [PATCH 1/3] qemu-char: Introduce Memory driver

2010-11-12 Thread Luiz Capitulino
On Fri, 12 Nov 2010 16:54:14 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 12 Nov 2010 11:16:54 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Thu, 11 Nov 2010 17:32:06

Re: [Qemu-devel] [PATCH 0/2] v7 Decouple block device removal from device removal

2010-11-12 Thread Markus Armbruster
Ryan Harper ry...@us.ibm.com writes: Once more dear friends, v7 This patch series decouples the detachment of a block device from the removal of the backing pci-device. Removal of a hotplugged pci device requires the guest to respond before qemu tears down the block device. In some cases,

Re: [Qemu-devel] Re: [PATCH v4 2/5] qed: Add QEMU Enhanced Disk image format

2010-11-12 Thread Stefan Hajnoczi
On Fri, Nov 12, 2010 at 3:43 PM, Kevin Wolf kw...@redhat.com wrote: Am 28.10.2010 13:01, schrieb Stefan Hajnoczi: +/** + * Check whether an image format is raw + * + * @fmt:    Backing file format, may be NULL + */ +static bool qed_fmt_is_raw(const char *fmt) +{ +    return fmt

[Qemu-devel] Re: [PATCH 1/2] Implement drive_del to decouple block removal from device removal

2010-11-12 Thread Kevin Wolf
Am 12.11.2010 16:38, schrieb Ryan Harper: Currently device hotplug removal code is tied to device removal via ACPI. All pci devices that are removable via device_del() require the guest to respond to the request. In some cases the guest may not respond leaving the device still accessible to

Re: [Qemu-devel] [PATCH 0/2] v7 Decouple block device removal from device removal

2010-11-12 Thread Kevin Wolf
Am 12.11.2010 17:28, schrieb Markus Armbruster: Ryan Harper ry...@us.ibm.com writes: Once more dear friends, v7 This patch series decouples the detachment of a block device from the removal of the backing pci-device. Removal of a hotplugged pci device requires the guest to respond before

[Qemu-devel] Re: [PATCH 1/2] Implement drive_del to decouple block removal from device removal

2010-11-12 Thread Ryan Harper
* Kevin Wolf kw...@redhat.com [2010-11-12 10:43]: Am 12.11.2010 16:38, schrieb Ryan Harper: Currently device hotplug removal code is tied to device removal via ACPI. All pci devices that are removable via device_del() require the guest to respond to the request. In some cases the guest

Re: [Qemu-devel] [PATCH 1/3] qemu-char: Introduce Memory driver

2010-11-12 Thread Luiz Capitulino
On Fri, 12 Nov 2010 17:06:16 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 12 Nov 2010 16:04:39 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 12 Nov 2010 15:16:33

Re: [Qemu-devel] Re: [PATCH v4 2/5] qed: Add QEMU Enhanced Disk image format

2010-11-12 Thread Kevin Wolf
Am 12.11.2010 17:34, schrieb Stefan Hajnoczi: On Fri, Nov 12, 2010 at 3:43 PM, Kevin Wolf kw...@redhat.com wrote: Am 28.10.2010 13:01, schrieb Stefan Hajnoczi: +/** + * Check whether an image format is raw + * + * @fmt:Backing file format, may be NULL + */ +static bool

Re: [Qemu-devel] Re: [Try2][PATCH] Initial implementation of a mpeg1 layer2 streaming audio driver.

2010-11-12 Thread François Revol
Le 12 nov. 2010 à 15:32, Anthony Liguori a écrit : I did try years ago, but at least the current wav driver really didn't like fifos back then. I recall trying for hours to get it pipe to ffmpeg or others without much luck. Also, this poses several problems about the control of the

[Qemu-devel] [PATCH 2/2] Add qmp version of drive_del

2010-11-12 Thread Ryan Harper
Signed-off-by: Ryan Harper ry...@us.ibm.com --- qmp-commands.hx | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) diff --git a/qmp-commands.hx b/qmp-commands.hx index 793cf1c..1e0d4e9 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -338,6 +338,35 @@

[Qemu-devel] [PATCH 0/2] v8 Decouple block device removal from device removal

2010-11-12 Thread Ryan Harper
details, details, v8 This patch series decouples the detachment of a block device from the removal of the backing pci-device. Removal of a hotplugged pci device requires the guest to respond before qemu tears down the block device. In some cases, the guest may not respond leaving the guest with

[Qemu-devel] [PATCH 1/2] Implement drive_del to decouple block removal from device removal

2010-11-12 Thread Ryan Harper
Currently device hotplug removal code is tied to device removal via ACPI. All pci devices that are removable via device_del() require the guest to respond to the request. In some cases the guest may not respond leaving the device still accessible to the guest. The management layer doesn't

Re: [Qemu-devel] Re: [PATCH v4 2/5] qed: Add QEMU Enhanced Disk image format

2010-11-12 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 12.11.2010 17:34, schrieb Stefan Hajnoczi: On Fri, Nov 12, 2010 at 3:43 PM, Kevin Wolf kw...@redhat.com wrote: Am 28.10.2010 13:01, schrieb Stefan Hajnoczi: +/** + * Check whether an image format is raw + * + * @fmt:Backing file format, may be

Re: [Qemu-devel] Re: [PATCH v4 2/5] qed: Add QEMU Enhanced Disk image format

2010-11-12 Thread Kevin Wolf
Am 12.11.2010 18:24, schrieb Markus Armbruster: Kevin Wolf kw...@redhat.com writes: Am 12.11.2010 17:34, schrieb Stefan Hajnoczi: On Fri, Nov 12, 2010 at 3:43 PM, Kevin Wolf kw...@redhat.com wrote: Am 28.10.2010 13:01, schrieb Stefan Hajnoczi: +/** + * Check whether an image format is raw

[Qemu-devel] Re: [PATCH v4 3/5] qed: Table, L2 cache, and cluster functions

2010-11-12 Thread Kevin Wolf
Am 28.10.2010 13:01, schrieb Stefan Hajnoczi: This patch adds code to look up data cluster offsets in the image via the L1/L2 tables. The L2 tables are writethrough cached in memory for performance (each read/write requires a lookup so it is essential to cache the tables). With cluster

[Qemu-devel] Re: [PATCH 0/2] v8 Decouple block device removal from device removal

2010-11-12 Thread Kevin Wolf
Am 12.11.2010 18:07, schrieb Ryan Harper: details, details, v8 This patch series decouples the detachment of a block device from the removal of the backing pci-device. Removal of a hotplugged pci device requires the guest to respond before qemu tears down the block device. In some cases,

Re: [Qemu-devel] Re: [PATCH v4 3/5] qed: Table, L2 cache, and cluster functions

2010-11-12 Thread Stefan Hajnoczi
On Fri, Nov 12, 2010 at 5:26 PM, Kevin Wolf kw...@redhat.com wrote: Am 28.10.2010 13:01, schrieb Stefan Hajnoczi: This patch adds code to look up data cluster offsets in the image via the L1/L2 tables.  The L2 tables are writethrough cached in memory for performance (each read/write requires a

Re: [Qemu-devel] [PATCH 0/2] v7 Decouple block device removal from device removal

2010-11-12 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: I have to admit that I didn't follow your discussion very closely any more after a few versions, so just to confirm: You came to the conclusion that we want to add drive_del to QMP and not only the human monitor, even though there is no drive_add in QMP?

[Qemu-devel] [PATCH v2 0/9] PCI capability and device assignment improvements

2010-11-12 Thread Alex Williamson
v2: - Fixed the function name in 1/8 per Michael's suggestion. - Removed capability specific config read/write registration - Added more checks to add_capability - Added capability lookup table to PCIDevice I've dropped the RFC patch to add more capabilities to device assignment while I do

[Qemu-devel] [PATCH v2 1/9] pci: pci_default_cap_write_config ignores wmask

2010-11-12 Thread Alex Williamson
Make use of wmask, just like the rest of config space. Signed-off-by: Alex Williamson alex.william...@redhat.com --- hw/pci.c | 22 ++ 1 files changed, 10 insertions(+), 12 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 92aaa85..4bc5882 100644 --- a/hw/pci.c +++

[Qemu-devel] [PATCH v2 3/9] device-assignment: Use PCI capabilities support

2010-11-12 Thread Alex Williamson
Convert to use common pci_add_capabilities() rather than creating our own mess. Signed-off-by: Alex Williamson alex.william...@redhat.com --- hw/device-assignment.c | 112 +++- 1 files changed, 63 insertions(+), 49 deletions(-) diff --git

[Qemu-devel] [PATCH v2 7/9] pci: Pass ID for capability read/write handlers

2010-11-12 Thread Alex Williamson
Any handlers that actually want to interact with specific capabilities are going to want to know the capability ID being accessed. With the capability map, this is readily available, so we can save handlers the trouble of figuring it out. Signed-off-by: Alex Williamson alex.william...@redhat.com

[Qemu-devel] [PATCH v2 4/9] pci: Replace used bitmap with capability byte map

2010-11-12 Thread Alex Williamson
Capabilities are allocated in bytes, so we can track both whether a byte is used and by what capability in the same structure. Remove pci_reserve_capability() as there are no users. Signed-off-by: Alex Williamson alex.william...@redhat.com --- hw/pci.c | 16 +--- hw/pci.h |6

[Qemu-devel] [PATCH v2 5/9] pci: Remove cap.length, cap.start, cap.supported

2010-11-12 Thread Alex Williamson
Capabilities aren't required to be contiguous, so cap.length never really made much sense. Likewise, cap.start is mostly meaningless too. Both of these are better served by the capability map. We can also get rid of cap.supported, since it's really now unused and redundant with flag in the

[Qemu-devel] [PATCH v2 6/9] device-assignment: Move PCI capabilities to match physical hardware

2010-11-12 Thread Alex Williamson
Now that common PCI code doesn't have a hangup on capabilities being contiguous, move assigned device capabilities to match their offset on physical hardware. This helps for drivers that assume a capability configuration and don't bother searching. We can also remove several calls to

[Qemu-devel] [PATCH v2 8/9] pci: Remove capability read/write config handlers

2010-11-12 Thread Alex Williamson
These are just as easy to handle out of the main config read/write handlers. Also expand cap_map to config_map so we can use it to track all of config space. Signed-off-by: Alex Williamson alex.william...@redhat.com --- hw/device-assignment.c | 22 +++- hw/pci.c |

[Qemu-devel] [PATCH v2 9/9] pci: Store capability offsets in PCIDevice

2010-11-12 Thread Alex Williamson
This not only makes pci_find_capability a directly lookup, but also allows us to better track added capabilities and avoids the proliferation of random additional capability offset markers. Signed-off-by: Alex Williamson alex.william...@redhat.com --- hw/msix.c | 15 +++ hw/pci.c

[Qemu-devel] [PATCH v2 2/9] pci: Remove pci_enable_capability_support()

2010-11-12 Thread Alex Williamson
This interface doesn't make much sense, adding a capability can take care of everything, just provide a means to register capability read/write handlers. Device assignment does it's own thing, so requires a couple ugly hacks that will be cleaned by subsequent patches. Signed-off-by: Alex

Re: [Qemu-devel] No Virtual Console

2010-11-12 Thread Mulyadi Santosa
On Fri, Nov 12, 2010 at 16:49, q...@rkmorris.us wrote: Yes - that's it! The SDL window. I can't get it to show up ... any ideas? make sure you have SDL package installed. Also, if you compile Qemu by your own, please install SDL-devel package before ./configure and make. -- regards, Mulyadi

[Qemu-devel] virtio-blk broken after system reset

2010-11-12 Thread Jan Kiszka
Hi, both after hard and guest-initiated reset, something is seriously broken with virtio block devices. If I reset my Linux guest while still in grub, the bios will simply fail to read from the disk after the reboot. If I reset after Linux touched the device, qemu terminates: Breakpoint 1,

Re: [Qemu-devel] [PATCH 4/8] ARM: Return correct result for float-to-integer conversion of NaN

2010-11-12 Thread Peter Maydell
On 11 November 2010 19:21, Nathan Froyd froy...@codesourcery.com wrote: On Thu, Nov 11, 2010 at 06:23:58PM +, Peter Maydell wrote: The ARM architecture mandates that converting a NaN value to integer gives zero. This isn't the behaviour of the SoftFloat library, so NaNs must be

[Qemu-devel] [Bug 674740] [NEW] qemu segfaults when security_model=none using virtio-9p-pci driver

2010-11-12 Thread Mike Ryan
Public bug reported: qemu version: 0.13 commit-id: 6ed912999d6ef636a5be5ccb266d7d3c0f0310b4 example invocation: $ qemu -virtfs local,path=/tmp,security_model=none,mount_tag=mmm r.img one of the following must be specified as thesecurity option: security_model=passthrough

[Qemu-devel] [Bug 674740] Re: qemu segfaults when security_model=none using virtio-9p-pci driver

2010-11-12 Thread Mike Ryan
** Patch added: patch to fix the bug https://bugs.launchpad.net/bugs/674740/+attachment/1731775/+files/0001-return-an-error-code-if-the-virtio-9p-pci-driver-can.patch -- qemu segfaults when security_model=none using virtio-9p-pci driver https://bugs.launchpad.net/bugs/674740 You received

[Qemu-devel] [Bug 674740] Re: qemu segfaults when security_model=none using virtio-9p-pci driver

2010-11-12 Thread Mike Ryan
Add the space in 'thesecurity'. ** Patch added: 0002-include-a-missing-space-in-and-error-message.patch https://bugs.launchpad.net/qemu/+bug/674740/+attachment/1731776/+files/0002-include-a-missing-space-in-and-error-message.patch -- qemu segfaults when security_model=none using

[Qemu-devel] [Bug 595438] Re: KVM segmentation fault, using SCSI+writeback and linux 2.4 guest

2010-11-12 Thread Bug Watch Updater
** Changed in: qemu-kvm (Debian) Status: Confirmed = Fix Released -- KVM segmentation fault, using SCSI+writeback and linux 2.4 guest https://bugs.launchpad.net/bugs/595438 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status

[Qemu-devel] [Bug 510612] Re: sound broken in qemu 0.12.x

2010-11-12 Thread Bug Watch Updater
** Changed in: qemu-kvm (Debian) Status: Fix Committed = Fix Released -- sound broken in qemu 0.12.x https://bugs.launchpad.net/bugs/510612 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU: New Status in “qemu”

Re: [Qemu-devel] virtio-blk broken after system reset

2010-11-12 Thread Stefan Hajnoczi
On Fri, Nov 12, 2010 at 10:02 PM, Jan Kiszka jan.kis...@web.de wrote: Hi, both after hard and guest-initiated reset, something is seriously broken with virtio block devices. If I reset my Linux guest while still in grub, the bios will simply fail to read from the disk after the reboot. If I

  1   2   >