[Qemu-devel] [V6 PATCH 3/4] virtio-net: notify guest to annouce itself

2012-03-28 Thread Jason Wang
It's hard to track all mac addresses and their usage (vlan, bondings, ipv6) in qemu to send proper gratuitous packet. The better choice is to let guest to send them. So, this patch introduces a new rw config status bit of virtio-net, VIRTIO_NET_S_ANNOUNCE which is used to notify guest to announce

[Qemu-devel] [V6 PATCH 4/4] virtio-net: compat guest announce support.

2012-03-28 Thread Jason Wang
Disable guest announce for compat machine types. Signed-off-by: Jason Wang jasow...@redhat.com --- hw/pc_piix.c | 35 +++ 1 files changed, 35 insertions(+), 0 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index 6c5c40f..780b607 100644 --- a/hw/pc_piix.c

[Qemu-devel] [V6 PATCH 2/4] net: model specific announcing support

2012-03-28 Thread Jason Wang
This patch introduces a function pointer in NetClientInfo which is called during self announcement. With this, each kind of card can announce the link with a specific way. The old method is still kept for cards that have not implemented this or old guest. The first user would be virtio-net.

Re: [Qemu-devel] [RFC 1/9] hostdev: introduce the infrastructure for host device model

2012-03-28 Thread Paolo Bonzini
Il 27/03/2012 23:21, Zhi Yong Wu ha scritto: Yes, that's correct. Everything that uses PROP_PTR needs to become a But i didn't see that that stuff which uses PROP_PTR become a link in current QEMU code. Yes, that's why I wrote needs to become. In order to use links, you need two things: *

Re: [Qemu-devel] [RFC][PATCH 0/2] uq/master: Basic MSI support for in-kernel irqchip mode

2012-03-28 Thread Jan Kiszka
On 2012-03-22 00:17, Jan Kiszka wrote: Some half a year ago when I posted my first attempt to refactor MSI for KVM support, we came to the conclusion that it might suffice to do transparent dynamic routing for user-space injected MSI messages. These two patches now implement such an approach

Re: [Qemu-devel] [V6 PATCH 1/4] net: announce self after vm start

2012-03-28 Thread Paolo Bonzini
Il 28/03/2012 07:40, Jason Wang ha scritto: qemu_announce_self() were moved to vm_start(). This is because we may want to let guest to send the gratuitous packets. A global variable need_announce were introduced to record the pending announcement, and vm_start() would send gratuitous packet

Re: [Qemu-devel] [V6 PATCH 2/4] net: model specific announcing support

2012-03-28 Thread Paolo Bonzini
Il 28/03/2012 07:40, Jason Wang ha scritto: This patch introduces a function pointer in NetClientInfo which is called during self announcement. With this, each kind of card can announce the link with a specific way. The old method is still kept for cards that have not implemented this or old

Re: [Qemu-devel] [RFC 1/9] hostdev: introduce the infrastructure for host device model

2012-03-28 Thread Zhi Yong Wu
By the way, why have we not add one QOM cookbook to docs? It is very useful for us newbiew to learn. On Wed, Mar 28, 2012 at 2:41 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 27/03/2012 23:21, Zhi Yong Wu ha scritto: Yes, that's correct.  Everything that uses PROP_PTR needs to become a But

[Qemu-devel] [PATCH trivial] trace-events: don't use dtrace reserved words in and next

2012-03-28 Thread Alon Levy
--- trace-events |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/trace-events b/trace-events index 70f059d..0924666 100644 --- a/trace-events +++ b/trace-events @@ -313,7 +313,7 @@ usb_host_set_interface(int bus, int addr, int interface, int alt) dev %d:%d, in

[Qemu-devel] [Bug 966471] Re: qemu-i386-user fails on powerpc host (bash: fork: Invalid argument)

2012-03-28 Thread Peter Maydell
*** This bug is a duplicate of bug 739785 *** https://bugs.launchpad.net/bugs/739785 This looks to me like the same issue as bug 739785 (where it was reported on ARM and MIPS hosts). Basically user mode i386 guests have a number of problems relating to threading support. ** This bug has been

Re: [Qemu-devel] [RFC 1/9] hostdev: introduce the infrastructure for host device model

2012-03-28 Thread Paolo Bonzini
Il 28/03/2012 09:53, Zhi Yong Wu ha scritto: By the way, why have we not add one QOM cookbook to docs? It is very useful for us newbiew to learn. Yes, that would be useful. It takes time to write docs unfortunately. :( Paolo

Re: [Qemu-devel] [RFC 1/9] hostdev: introduce the infrastructure for host device model

2012-03-28 Thread Zhi Yong Wu
On Wed, Mar 28, 2012 at 4:05 PM, 陳韋任 che...@iis.sinica.edu.tw wrote: Il 28/03/2012 09:53, Zhi Yong Wu ha scritto: By the way, why have we not add one QOM cookbook to docs? It is very useful for us newbiew to learn.  You can write what you learn during this work. This should be a good

Re: [Qemu-devel] [PATCH] pci: Factor out bounds checking on config space accesses

2012-03-28 Thread Michael S. Tsirkin
On Wed, Mar 28, 2012 at 12:11:52PM +1100, David Gibson wrote: Michael, Any chance of an ack or nack on this one? On Mon, Mar 19, 2012 at 03:58:11PM +1100, David Gibson wrote: There are several paths into the code to emulate PCI config space accesses: one for MMIO to a plain old PCI

Re: [Qemu-devel] [PATCH] tracetool.py: always pass --binary, --target-arch, --target-type

2012-03-28 Thread Alon Levy
On Tue, Mar 27, 2012 at 08:01:54PM +0200, Lluís Vilanova wrote: Alon Levy writes: Signed-off-by: Alon Levy al...@redhat.com --- Makefile.objs | 25 ++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/Makefile.objs b/Makefile.objs index

Re: [Qemu-devel] [RFC 1/9] hostdev: introduce the infrastructure for host device model

2012-03-28 Thread 陳韋任
Il 28/03/2012 09:53, Zhi Yong Wu ha scritto: By the way, why have we not add one QOM cookbook to docs? It is very useful for us newbiew to learn. You can write what you learn during this work. This should be a good start! :) Regards, chenwj -- Wei-Ren Chen (陳韋任) Computer Systems Lab,

Re: [Qemu-devel] [RFC 1/9] hostdev: introduce the infrastructure for host device model

2012-03-28 Thread 陳韋任
On Wed, Mar 28, 2012 at 04:25:54PM +0800, Zhi Yong Wu wrote: On Wed, Mar 28, 2012 at 4:05 PM, 陳韋任 che...@iis.sinica.edu.tw wrote: Il 28/03/2012 09:53, Zhi Yong Wu ha scritto: By the way, why have we not add one QOM cookbook to docs? It is very useful for us newbiew to learn.  You can

Re: [Qemu-devel] [RFC][PATCH 0/2] uq/master: Basic MSI support for in-kernel irqchip mode

2012-03-28 Thread Michael S. Tsirkin
On Wed, Mar 28, 2012 at 09:13:22AM +0200, Jan Kiszka wrote: On 2012-03-22 00:17, Jan Kiszka wrote: Some half a year ago when I posted my first attempt to refactor MSI for KVM support, we came to the conclusion that it might suffice to do transparent dynamic routing for user-space injected

Re: [Qemu-devel] [RFC][PATCH 0/2] uq/master: Basic MSI support for in-kernel irqchip mode

2012-03-28 Thread Jan Kiszka
On 2012-03-28 11:45, Michael S. Tsirkin wrote: On Wed, Mar 28, 2012 at 09:13:22AM +0200, Jan Kiszka wrote: On 2012-03-22 00:17, Jan Kiszka wrote: Some half a year ago when I posted my first attempt to refactor MSI for KVM support, we came to the conclusion that it might suffice to do

Re: [Qemu-devel] [libvirt] Modern CPU models cannot be used with libvirt

2012-03-28 Thread Avi Kivity
On 03/26/2012 09:03 PM, Anthony Liguori wrote: I think what we want to move toward is a -no-machine option which allows a user to explicitly build a machine from scratch. That is: qemu -no-machine -device i440fx,id=host -device isa-serial,chr=chr0 ... I'd call it -M bare-1.1, so that it

Re: [Qemu-devel] [libvirt] Modern CPU models cannot be used with libvirt

2012-03-28 Thread Avi Kivity
On 03/26/2012 09:00 PM, Anthony Liguori wrote: Yes, that's one reason. But maybe a user wants to have a whole different set of machine types and doesn't care to have the ones we provide. Why prevent a user from doing this? How are we preventing a user from doing it? In what way is

Re: [Qemu-devel] [PATCH] tracetool.py: always pass --binary, --target-arch, --target-type

2012-03-28 Thread Lluís Vilanova
Alon Levy writes: [...] I don't see the reason for such a change, as in the current bash code it's not used except when generating files in the 'stap' format. Have you tried building with trace backend dtrace? without those changed it breaks because tracetool.py requires both target_arch

Re: [Qemu-devel] [PATCH 1/2] qemu-iotests: Fix call syntax for qemu-img

2012-03-28 Thread Stefan Hajnoczi
On Tue, Mar 27, 2012 at 9:56 PM, Stefan Weil s...@weilnetz.de wrote: Am 14.03.2012 21:48, schrieb Stefan Weil: Am 14.03.2012 20:08, schrieb Eric Blake: On 03/14/2012 12:57 PM, Stefan Weil wrote: qemu-img requires first options, then file name, then size. GNU getopt also allows options at

Re: [Qemu-devel] [RFC][PATCH 0/2] uq/master: Basic MSI support for in-kernel irqchip mode

2012-03-28 Thread Michael S. Tsirkin
On Wed, Mar 28, 2012 at 11:50:27AM +0200, Jan Kiszka wrote: On 2012-03-28 11:45, Michael S. Tsirkin wrote: On Wed, Mar 28, 2012 at 09:13:22AM +0200, Jan Kiszka wrote: On 2012-03-22 00:17, Jan Kiszka wrote: Some half a year ago when I posted my first attempt to refactor MSI for KVM

Re: [Qemu-devel] [RFC][PATCH 0/2] uq/master: Basic MSI support for in-kernel irqchip mode

2012-03-28 Thread Jan Kiszka
On 2012-03-28 12:47, Michael S. Tsirkin wrote: On Wed, Mar 28, 2012 at 11:50:27AM +0200, Jan Kiszka wrote: On 2012-03-28 11:45, Michael S. Tsirkin wrote: On Wed, Mar 28, 2012 at 09:13:22AM +0200, Jan Kiszka wrote: On 2012-03-22 00:17, Jan Kiszka wrote: Some half a year ago when I posted my

Re: [Qemu-devel] [RFC][PATCH 1/2] kvm: Introduce basic MSI support in-kernel irqchips

2012-03-28 Thread Avi Kivity
On 03/22/2012 01:17 AM, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com This patch basically adds kvm_irqchip_send_msi, a service for sending arbitrary MSI messages to KVM's in-kernel irqchip models. As the current KVI API requires us to establish a static route from a s/KVI/KVM/

Re: [Qemu-devel] [RFC][PATCH 0/2] uq/master: Basic MSI support for in-kernel irqchip mode

2012-03-28 Thread Michael S. Tsirkin
On Wed, Mar 28, 2012 at 01:07:42PM +0200, Jan Kiszka wrote: On 2012-03-28 12:47, Michael S. Tsirkin wrote: On Wed, Mar 28, 2012 at 11:50:27AM +0200, Jan Kiszka wrote: On 2012-03-28 11:45, Michael S. Tsirkin wrote: On Wed, Mar 28, 2012 at 09:13:22AM +0200, Jan Kiszka wrote: On 2012-03-22

Re: [Qemu-devel] [RFC][PATCH 1/2] kvm: Introduce basic MSI support in-kernel irqchips

2012-03-28 Thread Jan Kiszka
On 2012-03-28 13:09, Avi Kivity wrote: On 03/22/2012 01:17 AM, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com This patch basically adds kvm_irqchip_send_msi, a service for sending arbitrary MSI messages to KVM's in-kernel irqchip models. As the current KVI API requires us to

Re: [Qemu-devel] [RFC][PATCH 0/2] uq/master: Basic MSI support for in-kernel irqchip mode

2012-03-28 Thread Jan Kiszka
On 2012-03-28 13:31, Michael S. Tsirkin wrote: Also, how would this support irqfd in the future? Will we have to rip it all out and replace with per-device tracking that we have today? Irqfd and kvm device assignment will require additional interfaces (of the kvm core in QEMU) via which you

[Qemu-devel] [PATCH V10 1/8] pci_ids: Add INTEL_82599_SFP_VF id.

2012-03-28 Thread Anthony PERARD
Signed-off-by: Anthony PERARD anthony.per...@citrix.com Acked-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- hw/pci_ids.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/pci_ids.h b/hw/pci_ids.h index e8235a7..649e6b3 100644 --- a/hw/pci_ids.h +++

[Qemu-devel] [PATCH V10 7/8] Introduce apic-msidef.h

2012-03-28 Thread Anthony PERARD
This patch move the msi definition from apic.c to apic-msidef.h. So it can be used also by other .c files. Signed-off-by: Anthony PERARD anthony.per...@citrix.com Acked-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- hw/apic-msidef.h | 30 ++ hw/apic.c

[Qemu-devel] [PATCH V10 4/8] pci.c: Add opaque argument to pci_for_each_device.

2012-03-28 Thread Anthony PERARD
Signed-off-by: Anthony PERARD anthony.per...@citrix.com Acked-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- hw/pci.c | 11 +++ hw/pci.h |4 +++- hw/xen_platform.c |8 3 files changed, 14 insertions(+), 9 deletions(-) diff --git

[Qemu-devel] [PATCH V10 6/8] Introduce Xen PCI Passthrough, PCI config space helpers (2/3)

2012-03-28 Thread Anthony PERARD
From: Allen Kay allen.m@intel.com A more complete history can be found here: git://xenbits.xensource.com/qemu-xen-unstable.git Signed-off-by: Allen Kay allen.m@intel.com Signed-off-by: Guy Zana g...@neocleus.com Signed-off-by: Anthony PERARD anthony.per...@citrix.com Acked-by: Stefano

Re: [Qemu-devel] [RFC][PATCH 1/2] kvm: Introduce basic MSI support in-kernel irqchips

2012-03-28 Thread Avi Kivity
On 03/28/2012 01:33 PM, Jan Kiszka wrote: On 2012-03-28 13:09, Avi Kivity wrote: On 03/22/2012 01:17 AM, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com This patch basically adds kvm_irqchip_send_msi, a service for sending arbitrary MSI messages to KVM's in-kernel irqchip

Re: [Qemu-devel] [RFC][PATCH 1/2] kvm: Introduce basic MSI support in-kernel irqchips

2012-03-28 Thread Jan Kiszka
On 2012-03-28 13:44, Avi Kivity wrote: On 03/28/2012 01:33 PM, Jan Kiszka wrote: On 2012-03-28 13:09, Avi Kivity wrote: On 03/22/2012 01:17 AM, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com This patch basically adds kvm_irqchip_send_msi, a service for sending arbitrary MSI

[Qemu-devel] [PATCH V10 0/8] Xen PCI Passthrough

2012-03-28 Thread Anthony PERARD
Hi all, This patch series introduces the PCI passthrough for Xen. Please review patches number 1, 2, 3, 4 and 7. First, we have XenHostPCIDevice that help to access one PCI device of the host. Then, the PCI passthrough device himself. Cut in 3 parts (or file), there is one to take care of

Re: [Qemu-devel] [RFC][PATCH 1/2] kvm: Introduce basic MSI support in-kernel irqchips

2012-03-28 Thread Michael S. Tsirkin
On Wed, Mar 28, 2012 at 01:09:25PM +0200, Avi Kivity wrote: On 03/22/2012 01:17 AM, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com This patch basically adds kvm_irqchip_send_msi, a service for sending arbitrary MSI messages to KVM's in-kernel irqchip models. As the current

[Qemu-devel] [PATCH V10 8/8] Introduce Xen PCI Passthrough, MSI (3/3)

2012-03-28 Thread Anthony PERARD
From: Jiang Yunhong yunhong.ji...@intel.com A more complete history can be found here: git://xenbits.xensource.com/qemu-xen-unstable.git Signed-off-by: Jiang Yunhong yunhong.ji...@intel.com Signed-off-by: Shan Haitao haitao.s...@intel.com Signed-off-by: Anthony PERARD anthony.per...@citrix.com

[Qemu-devel] [PATCH V10 2/8] configure: Introduce --enable-xen-pci-passthrough.

2012-03-28 Thread Anthony PERARD
Signed-off-by: Anthony PERARD anthony.per...@citrix.com Acked-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- configure | 25 + 1 files changed, 25 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 14ef738..cb7bc75 100755 --- a/configure

[Qemu-devel] [PATCH V10 5/8] Introduce Xen PCI Passthrough, qdevice (1/3)

2012-03-28 Thread Anthony PERARD
From: Allen Kay allen.m@intel.com A more complete history can be found here: git://xenbits.xensource.com/qemu-xen-unstable.git Signed-off-by: Allen Kay allen.m@intel.com Signed-off-by: Guy Zana g...@neocleus.com Signed-off-by: Anthony PERARD anthony.per...@citrix.com Acked-by: Stefano

[Qemu-devel] [PATCH V10 3/8] Introduce XenHostPCIDevice to access a pci device on the host.

2012-03-28 Thread Anthony PERARD
Signed-off-by: Anthony PERARD anthony.per...@citrix.com --- Makefile.target |3 + hw/xen-host-pci-device.c | 354 ++ hw/xen-host-pci-device.h | 78 ++ 3 files changed, 435 insertions(+), 0 deletions(-) create mode 100644

Re: [Qemu-devel] [RFC][PATCH 1/2] kvm: Introduce basic MSI support in-kernel irqchips

2012-03-28 Thread Avi Kivity
On 03/28/2012 01:54 PM, Jan Kiszka wrote: interface transparent. We create those routes on demand and keep them in a hash table. Succeeding messages can then search for an existing route in the table first and reuse it whenever possible. If we should run out of limited GSIs, we simply

Re: [Qemu-devel] Bug report for kvm-kmod-3.3!

2012-03-28 Thread Katrina Austin
Hi Jan, Now I wanna to locate the instruction in the guest OS that causes this problem. However, I dont know how to make it as the guest OS has not yet started up. I would be much appreicated if you can provide some suggestions. Katrina On Fri, Mar 23, 2012 at 8:13 PM, Jan Kiszka

Re: [Qemu-devel] [RFC][PATCH 1/2] kvm: Introduce basic MSI support in-kernel irqchips

2012-03-28 Thread Jan Kiszka
On 2012-03-28 14:32, Avi Kivity wrote: On 03/28/2012 01:54 PM, Jan Kiszka wrote: interface transparent. We create those routes on demand and keep them in a hash table. Succeeding messages can then search for an existing route in the table first and reuse it whenever possible. If we should

Re: [Qemu-devel] Bug report for kvm-kmod-3.3!

2012-03-28 Thread Jan Kiszka
On 2012-03-28 14:44, Katrina Austin wrote: Hi Jan, Now I wanna to locate the instruction in the guest OS that causes this problem. However, I dont know how to make it as the guest OS has not yet started up. I would be much appreicated if you can provide some suggestions. Not sure if we

[Qemu-devel] [PATCH stable-0.15 01/36] ccid: Fix buffer overrun in handling of VSC_ATR message

2012-03-28 Thread Andreas Färber
From: Markus Armbruster arm...@redhat.com ATR size exceeding the limit is diagnosed, but then we merrily use it anyway, overrunning card-atr[]. The message is read from a character device. Obvious security implications unless the other end of the character device is trusted. Spotted by

[Qemu-devel] [PATCH stable-0.15 26/36] qcow: Fix bdrv_write_compressed error handling

2012-03-28 Thread Andreas Färber
From: Kevin Wolf kw...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com (cherry picked from commit 64ebe71aa0e498d24e8c02b133192142fce3a0d0) Signed-off-by: Bruce Rogers brog...@suse.com [AF: backported] Signed-off-by: Andreas Färber

[Qemu-devel] [PATCH stable-0.15 31/36] cpu-common: Have a ram_addr_t of uint64 with Xen.

2012-03-28 Thread Andreas Färber
From: Anthony PERARD anthony.per...@citrix.com In Xen case, memory can be bigger than the host memory. that mean a 32bits host (and QEMU) should be able to handle a RAM address of 64bits. Signed-off-by: Anthony PERARD anthony.per...@citrix.com Signed-off-by: Alexander Graf ag...@suse.de (cherry

[Qemu-devel] [PATCH stable-0.15 24/36] console: Fix rendering of VGA underline

2012-03-28 Thread Andreas Färber
From: Markus Armbruster arm...@redhat.com vga_putcharxy()'s underline code sets font_data to 0x instead of 0xff. vga_putcharxy() then reads dmask16[0x 4] and dmask4[0x 6]. In practice, these out-of-bounds subscripts only put a few crap bits into the display surface. For 32 bit

Re: [Qemu-devel] [PATCH trivial] trace-events: don't use dtrace reserved words in and next

2012-03-28 Thread Stefan Hajnoczi
On Wed, Mar 28, 2012 at 8:55 AM, Alon Levy al...@redhat.com wrote: ---  trace-events |    4 ++--  1 file changed, 2 insertions(+), 2 deletions(-) We're always going to struggle with new trace events that add reserved keywords. Fixing up trace-events is going to be an ongoing task so I'd like

[Qemu-devel] [PATCH stable-0.15 09/36] block: Fix bdrv_open use after free

2012-03-28 Thread Andreas Färber
From: Kevin Wolf kw...@redhat.com tmp_filename was used outside the block it was defined in, i.e. after it went out of scope. Move its declaration to the top level. Signed-off-by: Kevin Wolf kw...@redhat.com (cherry picked from commit 2b5728164fcf5211bbae8d3c2fc6df62dd6b2295) Signed-off-by:

[Qemu-devel] [PATCH stable-0.15 23/36] block: set bs-read_only before .bdrv_open()

2012-03-28 Thread Andreas Färber
From: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Several block drivers set bs-read_only in .bdrv_open() but block.c:bdrv_open_common() clobbers its value. Additionally, QED uses bdrv_is_read_only() in .bdrv_open() to decide whether to perform consistency checks. The correct ordering is to

Re: [Qemu-devel] [PATCH trivial] trace-events: don't use dtrace reserved words in and next

2012-03-28 Thread Alon Levy
On Wed, Mar 28, 2012 at 01:55:49PM +0100, Stefan Hajnoczi wrote: On Wed, Mar 28, 2012 at 8:55 AM, Alon Levy al...@redhat.com wrote: ---  trace-events |    4 ++--  1 file changed, 2 insertions(+), 2 deletions(-) We're always going to struggle with new trace events that add reserved

[Qemu-devel] [PATCH stable-0.15 11/36] acl: Fix use after free in qemu_acl_reset()

2012-03-28 Thread Andreas Färber
From: Markus Armbruster arm...@redhat.com Reproducer: $ MALLOC_PERTURB_=234 qemu-system-x86_64 -vnc :0,acl,sasl [...] QEMU 0.15.50 monitor - type 'help' for more information (qemu) acl_add vnc.username fred allow acl: added rule at position 1 (qemu) acl_reset vnc.username

[Qemu-devel] [PATCH stable-0.15 17/36] vns/tls: don't use depricated gnutls functions

2012-03-28 Thread Andreas Färber
From: Gerd Hoffmann kra...@redhat.com Avoid using deprecated gnutls functions with recent gnutls versions. Fixes build failure on Fedora 16. Keep the old way for compatibility with old installations such as RHEL-5 (gnutls 1.4.x). Based on a patch from Raghavendra D Prabhu

[Qemu-devel] [PATCH stable-0.15 21/36] Teach block/vdi about discarded (no longer allocated) blocks

2012-03-28 Thread Andreas Färber
From: Eric Sunshine sunsh...@sunshineco.com An entry in the VDI block map will hold an offset to the actual block if the block is allocated, or one of two specially-interpreted values if not allocated. Using VirtualBox terminology, value VDI_IMAGE_BLOCK_FREE (0x) represents a

Re: [Qemu-devel] [PATCH trivial] trace-events: don't use dtrace reserved words in and next

2012-03-28 Thread Alon Levy
On Wed, Mar 28, 2012 at 03:16:34PM +0200, Alon Levy wrote: On Wed, Mar 28, 2012 at 01:55:49PM +0100, Stefan Hajnoczi wrote: On Wed, Mar 28, 2012 at 8:55 AM, Alon Levy al...@redhat.com wrote: ---  trace-events |    4 ++--  1 file changed, 2 insertions(+), 2 deletions(-) We're

Re: [Qemu-devel] [PATCH trivial] trace-events: don't use dtrace reserved words in and next

2012-03-28 Thread Stefan Hajnoczi
On Wed, Mar 28, 2012 at 2:33 PM, Alon Levy al...@redhat.com wrote: On Wed, Mar 28, 2012 at 03:16:34PM +0200, Alon Levy wrote: On Wed, Mar 28, 2012 at 01:55:49PM +0100, Stefan Hajnoczi wrote: On Wed, Mar 28, 2012 at 8:55 AM, Alon Levy al...@redhat.com wrote: ---  trace-events |    4 ++--

[Qemu-devel] [PATCH stable-0.15 15/36] ac97: don't override the pci subsystem id

2012-03-28 Thread Andreas Färber
From: Gerd Hoffmann kra...@redhat.com This patch removes the code lines which set the subsystem id for the emulated ac97 card to 8086:. Due to the device id being zero the subsystem id isn't vaild anyway. With the patch applied the sound card gets the default qemu subsystem id (1af4:1100)

Re: [Qemu-devel] [PATCH v6 2/2] target-arm: Minimalistic CPU QOM'ification

2012-03-28 Thread Peter Maydell
On 26 March 2012 18:28, Andreas Färber afaer...@suse.de wrote: +static void arm_cpu_reset(CPUState *c) +{ +    ARMCPU *cpu = ARM_CPU(c); +    ARMCPUClass *class = ARM_CPU_GET_CLASS(cpu); + +    class-parent_reset(c); I thought we were avoiding 'class' in favour of 'klass'? +static const

[Qemu-devel] [PATCH stable-0.15 36/36] qemu_vmalloc: align properly for transparent hugepages and KVM

2012-03-28 Thread Andreas Färber
From: Avi Kivity a...@redhat.com To make good use of transparent hugepages, KVM requires that guest-physical and host-virtual addresses share the low 21 bits (as opposed to just the low 12 bits normally required). Adjust qemu_vmalloc() to honor that requirement. Ignore it for small regions to

[Qemu-devel] [PATCH v4 1/7] test makefile overhaul

2012-03-28 Thread Paolo Bonzini
This introduces new test reporting infrastructure based on gtester and gtester-report. Also, all existing tests are moved to tests/, and tests/Makefile is reorganized to factor out the commonalities in the rules. Signed-off-by: Anthony Liguori aligu...@linux.vnet.ibm.com Signed-off-by: Paolo

[Qemu-devel] [PATCH v4 0/7] new test infrastructure + qtest

2012-03-28 Thread Paolo Bonzini
This is a rebase of qtest. I split the gtester infrastructure into its own patch, and reorganized the tests by moving everything into tests/. Also, libqtest now has bindings for the clock management commands, and I am using them in rtc-test. Finally, the accept is moved from qemu to libqtest;

[Qemu-devel] [PATCH stable-0.15 27/36] block: reinitialize across bdrv_close()/bdrv_open()

2012-03-28 Thread Andreas Färber
From: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Several BlockDriverState fields are not being reinitialized across bdrv_close()/bdrv_open(). Make sure they are reset to their default values. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Signed-off-by: Kevin Wolf kw...@redhat.com

[Qemu-devel] [PATCH v4 7/7] qtest: add rtc-test test-case

2012-03-28 Thread Paolo Bonzini
From: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- tests/Makefile |5 + tests/rtc-test.c | 263 ++ 2 files changed, 268 insertions(+), 0

Re: [Qemu-devel] [PATCH v6 2/2] target-arm: Minimalistic CPU QOM'ification

2012-03-28 Thread Max Filippov
+static void arm_cpu_reset(CPUState *c) +{ +    ARMCPU *cpu = ARM_CPU(c); +    ARMCPUClass *class = ARM_CPU_GET_CLASS(cpu); + +    class-parent_reset(c); I thought we were avoiding 'class' in favour of 'klass'? I have suggested it once and I can only say it again, please, call it

Re: [Qemu-devel] [PATCH v6 2/2] target-arm: Minimalistic CPU QOM'ification

2012-03-28 Thread Andreas Färber
Am 28.03.2012 15:40, schrieb Peter Maydell: On 26 March 2012 18:28, Andreas Färber afaer...@suse.de wrote: +static void arm_cpu_reset(CPUState *c) +{ +ARMCPU *cpu = ARM_CPU(c); +ARMCPUClass *class = ARM_CPU_GET_CLASS(cpu); + +class-parent_reset(c); I thought we were

[Qemu-devel] [PATCH stable-0.15 22/36] vmdk: Improve error handling

2012-03-28 Thread Andreas Färber
From: Kevin Wolf kw...@redhat.com Return the right error values in some more places. Signed-off-by: Kevin Wolf kw...@redhat.com (cherry picked from commit 99f1835d9bc744f98370254600530e66f32e6d81) Signed-off-by: Bruce Rogers brog...@suse.com Signed-off-by: Andreas Färber afaer...@suse.de ---

Re: [Qemu-devel] [PATCH v6 2/2] target-arm: Minimalistic CPU QOM'ification

2012-03-28 Thread Andreas Färber
Am 28.03.2012 15:46, schrieb Max Filippov: +static void arm_cpu_reset(CPUState *c) +{ +ARMCPU *cpu = ARM_CPU(c); +ARMCPUClass *class = ARM_CPU_GET_CLASS(cpu); + +class-parent_reset(c); I thought we were avoiding 'class' in favour of 'klass'? I have suggested it once and I

Re: [Qemu-devel] [PATCH] allow to load android binary

2012-03-28 Thread Cédric VINCENT
matthieu castet castet.matthieu at free.fr writes: Android binary start with a weird elf program header : the first one is of size 0 pointing to NULL addr. Ignore LOAD program where MemSiz is 0. ... Attachment (0001-allow-to-load-android-binary.patch): text/x-diff, 2172 bytes This old

Re: [Qemu-devel] [PATCH v6 2/2] target-arm: Minimalistic CPU QOM'ification

2012-03-28 Thread Max Filippov
+static void arm_cpu_reset(CPUState *c) +{ +    ARMCPU *cpu = ARM_CPU(c); +    ARMCPUClass *class = ARM_CPU_GET_CLASS(cpu); + +    class-parent_reset(c); I thought we were avoiding 'class' in favour of 'klass'? I have suggested it once and I can only say it again, please, call it

[Qemu-devel] [PATCH stable-0.15 16/36] vvfat: Fix potential buffer overflow

2012-03-28 Thread Andreas Färber
From: Kevin Wolf kw...@redhat.com path2[PATH_MAX] can be used for the null termination, so make the array big enough to allow this. Signed-off-by: Kevin Wolf kw...@redhat.com (cherry picked from commit 0d460d6f414e02805cbc348404db03b2b7907360) Signed-off-by: Bruce Rogers brog...@suse.com

Re: [Qemu-devel] [PATCH 4/4] qdev: put all devices under /machine

2012-03-28 Thread Andreas Färber
Am 27.03.2012 23:11, schrieb Anthony Liguori: On 03/27/2012 11:38 AM, Paolo Bonzini wrote: Avoid cluttering too much the QOM root. Signed-off-by: Paolo Bonzinipbonz...@redhat.com Reviewed-by: Anthony Liguori aligu...@us.ibm.com Not terribly convinced, but no better suggestion. Could you

[Qemu-devel] [PATCH stable-0.15 29/36] vmdk: Fix possible segfaults

2012-03-28 Thread Andreas Färber
From: Kevin Wolf kw...@redhat.com Data we read from the disk isn't necessarily null terminated and may not contain the string we're looking for. The code needs to be a bit more careful here. Signed-off-by: Kevin Wolf kw...@redhat.com (cherry picked from commit

[Qemu-devel] [PATCH stable-0.15 10/36] ide: Fix off-by-one error in array index check

2012-03-28 Thread Andreas Färber
From: Kevin Wolf kw...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com (cherry picked from commit fb60105d4942a26f571b1be92a8b9e7528d0c4d8) Signed-off-by: Bruce Rogers brog...@suse.com Signed-off-by: Andreas Färber afaer...@suse.de ---

Re: [Qemu-devel] [PATCH v6 2/2] target-arm: Minimalistic CPU QOM'ification

2012-03-28 Thread Andreas Färber
Am 28.03.2012 16:00, schrieb Max Filippov: +static void arm_cpu_reset(CPUState *c) +{ +ARMCPU *cpu = ARM_CPU(c); +ARMCPUClass *class = ARM_CPU_GET_CLASS(cpu); + +class-parent_reset(c); I thought we were avoiding 'class' in favour of 'klass'? I have suggested it once and I can

[Qemu-devel] [PATCH v4 5/7] qtest: add C version of test infrastructure

2012-03-28 Thread Paolo Bonzini
From: Anthony Liguori aligu...@us.ibm.com This also includes a qtest wrapper script to make it easier to launch qtest tests directly. Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- osdep.h |2 + qemu-common.h|1 -

[Qemu-devel] [PATCH stable-0.15 12/36] migration: flush migration data to disk.

2012-03-28 Thread Andreas Färber
From: Gerd Hoffmann kra...@redhat.com This patch increases robustness when migrating to a file with two little changes: (1) Before closing the migration file handle checks if it happens to be a regular file and if so it issues a fsync. This way the data is flushed to disk before qemu

Re: [Qemu-devel] [PATCH] allow to load android binary

2012-03-28 Thread Peter Maydell
2012/3/28 Cédric VINCENT cedric.vinc...@st.com: matthieu castet castet.matthieu at free.fr writes: Android binary start with a weird elf program header : the first one is of size 0 pointing to NULL addr. Ignore LOAD program where MemSiz is 0. This old patch (not mine) is required to run

[Qemu-devel] [PATCH stable-0.15 00/36] Preparing 0.15.2

2012-03-28 Thread Andreas Färber
Hello Anthony and Justin, As announced last year, SUSE is shipping a patched qemu-kvm 0.15.1 with our recently released SLES 11 SP2. We are therefore very interested in cutting 0.15.2 releases for QEMU and later on qemu-kvm. This series contains only bugfix cherry-picks from qemu.git master,

[Qemu-devel] [PATCH stable-0.15 32/36] Error check find_ram_offset

2012-03-28 Thread Andreas Färber
From: Alex Williamson alex.william...@redhat.com Spotted via code review, we initialize offset to 0 to avoid a compiler warning, but in the unlikely case that offset is never set to something else, we should abort instead of return a value that will almost certainly cause problems.

[Qemu-devel] [PATCH v4 4/7] qtest: add clock management

2012-03-28 Thread Paolo Bonzini
This patch combines qtest and -icount together to turn the vm_clock into a source that can be fully managed by the client. To this end new commands clock_step and clock_set are added. Hooking them with libqtest is left as an exercise to the reader. Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH v6 2/2] target-arm: Minimalistic CPU QOM'ification

2012-03-28 Thread Peter Maydell
On 26 March 2012 18:28, Andreas Färber afaer...@suse.de wrote: +static void arm_cpu_reset(CPUState *c) +{ +    ARMCPU *cpu = ARM_CPU(c); +    ARMCPUClass *class = ARM_CPU_GET_CLASS(cpu); + +    class-parent_reset(c); + +    /* TODO Drop this in favor of cpu_arm_reset() calling cpu_reset()

[Qemu-devel] [PATCH 1/2] tracetool: dtrace: handle in and next reserved words

2012-03-28 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- scripts/tracetool |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/tracetool b/scripts/tracetool index 65bd0a1..e7cebf3 100755 --- a/scripts/tracetool +++ b/scripts/tracetool @@ -494,9 +494,9 @@ EOF i=1

[Qemu-devel] [PATCH 2/2] tracetool: dtrace: warn on reserved word usage

2012-03-28 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- scripts/tracetool |1 + 1 file changed, 1 insertion(+) diff --git a/scripts/tracetool b/scripts/tracetool index e7cebf3..d011bb7 100755 --- a/scripts/tracetool +++ b/scripts/tracetool @@ -496,6 +496,7 @@ EOF do # 'limit', 'in' and

[Qemu-devel] [PATCH v4 2/7] qtest: add test framework

2012-03-28 Thread Paolo Bonzini
From: Anthony Liguori aligu...@us.ibm.com The idea behind qtest is pretty simple. Instead of executing a CPU via TCG or KVM, rely on an external process to send events to the device model that the CPU would normally generate. qtest presents itself as an accelerator. In addition, a new option

[Qemu-devel] [PATCH stable-0.15 14/36] hw/lan9118.c: Add missing 'break' to fix buffer overrun

2012-03-28 Thread Andreas Färber
From: Peter Maydell peter.mayd...@linaro.org Add a missing 'break' statement to fix a buffer overrun when executing the EEPROM write-all command. Spotted by Coverity (see bug 887883). Signed-off-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com

Re: [Qemu-devel] [PATCH v6 2/2] target-arm: Minimalistic CPU QOM'ification

2012-03-28 Thread Peter Maydell
On 28 March 2012 14:46, Andreas Färber afaer...@suse.de wrote: Am 28.03.2012 15:40, schrieb Peter Maydell: On 26 March 2012 18:28, Andreas Färber afaer...@suse.de wrote: +static void arm_cpu_reset(CPUState *c) +{ +    ARMCPU *cpu = ARM_CPU(c); +    ARMCPUClass *class =

[Qemu-devel] [PATCH stable-0.15 08/36] vmdk: vmdk_read_cid returns garbage if p_name is NULL

2012-03-28 Thread Andreas Färber
From: Pavel Borzenkov pavel.borzen...@gmail.com Spotted by Clang Analyzer Signed-off-by: Pavel Borzenkov pavel.borzen...@gmail.com Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com (cherry picked from commit 8379e46d1fd681b8aa4714382e2cdab05e5d0575) Signed-off-by: Bruce Rogers

[Qemu-devel] [PATCH v2 4/4] qdev: put all devices under /machine

2012-03-28 Thread Paolo Bonzini
Avoid cluttering too much the QOM root. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- v1-v2: add qdev_get_machine() and use it. hw/piix_pci.c |2 +- hw/ppc_prep.c |2 +- hw/qdev-monitor.c |4 ++-- hw/qdev.c | 13 - hw/qdev.h |

[Qemu-devel] [PATCH stable-0.15 20/36] hda: do not mix output and input stream states, RHBZ #740493

2012-03-28 Thread Andreas Färber
From: Marc-André Lureau marcandre.lur...@gmail.com Windows 7 may use the same stream number for input and output. Current code will confuse streams. Changes since v1: - keep running_compat[] for migration version 1 - add running_real[] for migration version 2 Signed-off-by: Marc-Andr? Lureau

[Qemu-devel] [PATCH stable-0.15 03/36] e1000: use MII status register for link up/down

2012-03-28 Thread Andreas Färber
From: Bjørn Mork bj...@mork.no Some guests will use the standard MII status register to verify link state. They will not notice link changes unless this register is updated. Verified with Linux 3.0 and Windows XP guests. Without this patch, ethtool will report speed and duplex as unknown when

Re: [Qemu-devel] [SeaBIOS] [PATCH 1/4] Add basic linked list operations

2012-03-28 Thread Gerd Hoffmann
On 03/28/12 06:28, Alexey Korolev wrote: This linked list implementation is partially based on kernel code. So it should be quite stable How about just copying the file? I've used the linux kernel list implementation elsewhere too and it worked just fine with only minor tweaks (remove some

[Qemu-devel] [PATCH stable-0.15 33/36] pc: add pc-0.15

2012-03-28 Thread Andreas Färber
From: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Anthony Liguori aligu...@us.ibm.com (cherry picked from commit ce01a508e8053350544c88ba68a3f90c44b6bb93) [BR: bnc#741460] Signed-off-by: Bruce Rogers brog...@suse.com [AF: backported] Signed-off-by: Andreas Färber afaer...@suse.de ---

[Qemu-devel] [PATCH stable-0.15 18/36] block/curl: Implement a flush function on the fd handlers

2012-03-28 Thread Andreas Färber
From: Nick Thomas n...@bytemark.co.uk Signed-off-by: Nick Thomas n...@bytemark.co.uk Signed-off-by: Kevin Wolf kw...@redhat.com (cherry picked from commit c84dcdc1d6583ebe5841907c99d95deb8c40a6e0) Signed-off-by: Bruce Rogers brog...@suse.com Signed-off-by: Andreas Färber afaer...@suse.de ---

[Qemu-devel] [PATCH stable-0.15 34/36] pc: fix event_idx compatibility for virtio devices

2012-03-28 Thread Andreas Färber
From: Anthony Liguori aligu...@us.ibm.com event_idx was introduced in 0.15 and must be disabled for all virtio-pci devices (including virtio-balloon-pci). Signed-off-by: Anthony Liguori aligu...@us.ibm.com (cherry picked from commit ea830ebb74461c5ad6d199857fb000d2e0284c69) [BR: bnc#741460]

[Qemu-devel] [PATCH stable-0.15 13/36] Fix X86 CPU topology in KVM mode

2012-03-28 Thread Andreas Färber
From: Bharata B Rao bharata@gmail.com apic id returned to guest kernel in ebx for cpuid(function=1) depends on CPUX86State-cpuid_apic_id which gets populated after the cpuid information is cached in the host kernel. This results in broken CPU topology in guest. Fix this by setting

[Qemu-devel] [PATCH v4 3/7] qtest: IRQ interception infrastructure

2012-03-28 Thread Paolo Bonzini
Since /i440fx/piix3 is being removed from the composition tree, the IO-APIC is placed under /i440fx. This is wrong and should be changed as soon as the /i440fx/piix3 path is put back. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Anthony Liguori aligu...@us.ibm.com ---

[Qemu-devel] [PATCH stable-0.15 05/36] e1000: bounds packet size against buffer size

2012-03-28 Thread Andreas Färber
From: Anthony Liguori aligu...@us.ibm.com Otherwise we can write beyond the buffer and corrupt memory. This is tracked as CVE-2012-0029. Signed-off-by: Anthony Liguori aligu...@us.ibm.com (cherry picked from commit 65f82df0d7a71ce1b10cd4c5ab0d176ac840) Signed-off-by: Bruce Rogers

[Qemu-devel] [PATCH] ARM: Permit any ARMv6K CPU to read the MVFR0 and MVFR1 VFP registers.

2012-03-28 Thread Andrew Towers
From: Andrew Towers atow...@gmail.com Replaces the ARM_FEATURE_VFP3 check when reading MVFR0/1 with a check for ARM_FEATURE_V6K. Rationale: MVFR0/1 were introduced in the ARM1136 at the same time as ARMv6K, and a survey of TRMs indicates support in later models. According to reference

Re: [Qemu-devel] [Bug 954099] Re: Assertion failed arp_table.c line 41 on raspberry pi fedora image boot up

2012-03-28 Thread Joe Deller
Hi Peter, many thanks for the update, I'll give it another shot with later binaries and a more accurate CPU :-) Thanks again, Joe Date: Fri, 16 Mar 2012 15:51:24 + From: peter.mayd...@linaro.org To: joedel...@live.co.uk Subject: [Bug 954099] Re: Assertion failed arp_table.c line 41 on

  1   2   >