Re: [Qemu-devel] [PATCH] target-i386: Disable CPUID_EXT_MONITOR when KVM is enabled

2013-05-25 Thread Paolo Bonzini
Il 25/05/2013 03:21, Bandan Das ha scritto: There is one user-visible effect: -cpu ...,enforce will stop failing because of missing KVM support for CPUID_EXT_MONITOR. But that's exactly the point: there's no point in having CPU model definitions that would never work as-is with neither TCG or

Re: [Qemu-devel] Win32 QEMU binaries built from MinGW fail (access violation)

2013-05-25 Thread Stefan Weil
Am 25.05.2013 03:56, schrieb Dan: I've been trying to build QEMU source directly with MinGW. The compile/link works but there are tons of warnings (mostly Wformat). Once I try to run the binaries in Windows though, I quickly hit access violations once the HD image is mounted. I've tested on

Re: [Qemu-devel] [PATCH 17/30] memory: add address_space_translate

2013-05-25 Thread Jan Kiszka
On 2013-05-21 12:57, Paolo Bonzini wrote: Using phys_page_find to translate an AddressSpace to a MemoryRegionSection is unwieldy. It requires to pass the page index rather than the address, and later memory_region_section_addr has to be called. Replace memory_region_section_addr with a

Re: [Qemu-devel] use O_DIRECT to open disk images for IDE failed under xen-4.1.2 and qemu upstream

2013-05-25 Thread Gonglei (Arei)
-Original Message- From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] Sent: Friday, May 24, 2013 5:08 PM To: Gonglei (Arei) Cc: Stefano Stabellini; xen-de...@lists.xen.org; qemu-devel@nongnu.org; Hanweidong; Huangweidong (Hardware); Luonengjun; Wangzhenguo;

Re: [Qemu-devel] use O_DIRECT to open disk images for IDE failed under xen-4.1.2 and qemu upstream

2013-05-25 Thread Gonglei (Arei)
-Original Message- From: Stefan Hajnoczi [mailto:stefa...@gmail.com] Sent: Friday, May 24, 2013 8:20 PM To: Gonglei (Arei) Cc: Stefano Stabellini; Hanweidong; Luonengjun; qemu-devel@nongnu.org; Wangzhenguo; xen-de...@lists.xen.org; Huangweidong (Hardware) Subject: Re: [Qemu-devel]

Re: [Qemu-devel] [PATCH 17/30] memory: add address_space_translate

2013-05-25 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 25/05/2013 08:40, Jan Kiszka ha scritto: On 2013-05-21 12:57, Paolo Bonzini wrote: Using phys_page_find to translate an AddressSpace to a MemoryRegionSection is unwieldy. It requires to pass the page index rather than the address, and later

Re: [Qemu-devel] Win32 QEMU binaries built from MinGW fail (access violation)

2013-05-25 Thread Dan
Great Idea... never occurred to me that gdb would actually work in MinGW So I tried that, specifically adding --enable-debug --disable-pie (ref1) and now the failure went away, but it is DOG slow! I will try the following this weekend and report back: 1) Try another MinGW-w32 build without

Re: [Qemu-devel] [Qemu-stable] [PATCH for 1.5] ui/gtk.c: Fix *BSD build of Gtk+ UI

2013-05-25 Thread Michael Tokarev
24.05.2013 22:47, Brad Smith wrote: +++ b/include/qemu-common.h #elif defined CONFIG_BSD +# include termios.h Kinda late nit picking about it now. It's not. And it's not nitpicking really, we're carrying a ton of unnecessary #includes which slows down compilation significantly. The whole

Re: [Qemu-devel] [libvirt] [PATCH] qapi-schema.json: Reformat TargetType enum to one-per-line

2013-05-25 Thread Peter Maydell
On 24 May 2013 22:38, Eric Blake ebl...@redhat.com wrote: I think knowing the architecture (such as x86 vs. pseries ppc) is used by libvirt to know what default devices the board supports (for example, whether usb is present by default). ...but this is a per-board question, since (for

[Qemu-devel] [PATCH (trivial)] don't run pkg-config for features explicitly disabled

2013-05-25 Thread Michael Tokarev
We test pkg-config for curses and curl even if those are explicitly disabled. Move these tests inside `if $feature != no' sections. Signed-off-by: Michael Tokarev m...@tls.msk.ru --- configure | 21 + 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/configure

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Remove unnecessary break statements

2013-05-25 Thread Michael Tokarev
24.05.2013 14:19, Stefan Weil wrote: Fix these warnings from cppcheck: Thanks, applied to the trivial patches tree. /mjt

Re: [Qemu-devel] [PATCH 15/30] memory: add address_space_valid

2013-05-25 Thread Peter Maydell
On 25 May 2013 04:44, David Gibson da...@gibson.dropbear.id.au wrote: On Fri, May 24, 2013 at 11:52:17AM +0100, Peter Maydell wrote: So when *is* it a good idea to use this API? In real hardware you don't usually get a tell me whether this access would succeed if I did it bus operation -- you

Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/4] debugcon: fix some bugs when DEBUG_DEBUGCON

2013-05-25 Thread Michael Tokarev
24.05.2013 06:47, liguang wrote: when enable DEBUG_DEBUGCON, there are some message printing bugs, so fix them. this patch-set based on previous 3 patches, http://comments.gmane.org/gmane.comp.emulators.qemu/212550 http://comments.gmane.org/gmane.comp.emulators.qemu/212551

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: remove confusing file manipulation

2013-05-25 Thread Michael Tokarev
22.05.2013 17:21, Ed Maste wrote: The configure script had some code to manipulate config-host.ld~ (i.e., a common backup filename), comparing it with the newly-generated file. I believe the sense of the comparison was backwards. Since it seemed to serve little purpose anyway, remove it to

Re: [Qemu-devel] [PATCH 17/30] memory: add address_space_translate

2013-05-25 Thread Jan Kiszka
On 2013-05-25 09:47, Paolo Bonzini wrote: Il 25/05/2013 08:40, Jan Kiszka ha scritto: On 2013-05-21 12:57, Paolo Bonzini wrote: Using phys_page_find to translate an AddressSpace to a MemoryRegionSection is unwieldy. It requires to pass the page index rather than the address, and later

Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/4] debugcon: fix some bugs when DEBUG_DEBUGCON

2013-05-25 Thread Andreas Färber
Am 25.05.2013 11:28, schrieb Michael Tokarev: 24.05.2013 06:47, liguang wrote: when enable DEBUG_DEBUGCON, there are some message printing bugs, so fix them. this patch-set based on previous 3 patches, http://comments.gmane.org/gmane.comp.emulators.qemu/212550

Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/4] debugcon: fix some bugs when DEBUG_DEBUGCON

2013-05-25 Thread Michael Tokarev
25.05.2013 14:35, Andreas Färber wrote: Am 25.05.2013 11:28, schrieb Michael Tokarev: [] debugcon: use fprintf(stderr...) instead of printf The subjects and commit messages are a bit inaccurate, and as Andreas says, these may have been merged together, but the inaccuracy is small (and

Re: [Qemu-devel] [Qemu-stable] qmp commands get rejected

2013-05-25 Thread Stefan Priebe
Am 25.05.2013 00:32, schrieb mdroth: On Sat, May 25, 2013 at 12:12:22AM +0200, Stefan Priebe wrote: Am 25.05.2013 00:09, schrieb mdroth: I would try to create a small example script. I use qmp-shell and other little scripts very often. Am this be due to the fact that I don't wait for the

Re: [Qemu-devel] [PATCH (trivial)] don't run pkg-config for features explicitly disabled

2013-05-25 Thread Andreas Färber
Am 25.05.2013 11:19, schrieb Michael Tokarev: We test pkg-config for curses and curl even if those are explicitly disabled. Move these tests inside `if $feature != no' sections. Signed-off-by: Michael Tokarev m...@tls.msk.ru Reviewed-by: Andreas Färber afaer...@suse.de Andreas -- SUSE

Re: [Qemu-devel] [PATCH 2/2] vfio: hugepage support for vfio_iommu_type1

2013-05-25 Thread Konrad Rzeszutek Wilk
+ * Turns out AMD IOMMU has a page table bug where it won't map large pages + * to a region that previously mapped smaller pages. This should be fixed + * soon, so this is just a temporary workaround to break mappings down into + * PAGE_SIZE. Better to map smaller pages than nothing. + */

Re: [Qemu-devel] [PATCH 17/30] memory: add address_space_translate

2013-05-25 Thread Paolo Bonzini
Il 25/05/2013 12:19, Jan Kiszka ha scritto: addr -= section-offset_within_address_space; -len = MIN(section-size - addr, len); ^ This is the size of a section minus an offset in the section. +diff = int128_sub(section-mr-size,

Re: [Qemu-devel] [PATCH 0/2] vfio: type1 iommu hugepage support

2013-05-25 Thread Konrad Rzeszutek Wilk
On Fri, May 24, 2013 at 11:24:26AM -0600, Alex Williamson wrote: This series let's the vfio type1 iommu backend take advantage of iommu large page support. See patch 2/2 for the details. This has been tested on both amd_iommu and intel_iommu, but only my AMD system has large page support.

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: try pkg-config ncurses first

2013-05-25 Thread Ed Maste
On 25 May 2013 00:25, Michael Tokarev m...@tls.msk.ru wrote: 25.05.2013 00:07, Ed Maste wrote: When probing for ncurses, try pkg-config first rather than after explicit -lncurses and -lcurses. This fixes static linking in the case that ncurses has additional dependencies, such as -ltinfo (as

Re: [Qemu-devel] [PATCH 17/30] memory: add address_space_translate

2013-05-25 Thread Jan Kiszka
On 2013-05-25 13:20, Paolo Bonzini wrote: Il 25/05/2013 12:19, Jan Kiszka ha scritto: addr -= section-offset_within_address_space; -len = MIN(section-size - addr, len); ^ This is the size of a section minus an offset in the section.

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: try pkg-config ncurses first

2013-05-25 Thread Andreas Färber
Am 25.05.2013 06:25, schrieb Michael Tokarev: 25.05.2013 00:07, Ed Maste wrote: When probing for ncurses, try pkg-config first rather than after explicit -lncurses and -lcurses. This fixes static linking in the case that ncurses has additional dependencies, such as -ltinfo (as on FreeBSD).

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: try pkg-config ncurses first

2013-05-25 Thread Michael Tokarev
25.05.2013 15:38, Andreas Färber wrote: Am 25.05.2013 06:25, schrieb Michael Tokarev: [] Here, it is interesting to note that pkg-config does not actually do the right thing in this case. Because practically, it should have one extra flag, something like --static-libs (or --libs --static),

Re: [Qemu-devel] [PATCH V3 4/4] block: dump snapshot and image info to specified output

2013-05-25 Thread Eric Blake
On 05/24/2013 09:09 PM, Wenchao Xia wrote: bdrv_snapshot_dump() and bdrv_image_info_dump() do not dump to a buffer now, some internal buffers are still used for format control, which have no chance to be truncated. As a result, these two functions have no more issue of truncation, and they can

Re: [Qemu-devel] [PATCH V3 2/4] block: move snapshot code in block.c to block/snapshot.c

2013-05-25 Thread Eric Blake
On 05/24/2013 09:09 PM, Wenchao Xia wrote: All snapshot related code, except bdrv_snapshot_dump() and bdrv_is_snapshot(), is moved to block/snapshot.c. bdrv_snapshot_dump() will be moved to another file later. bdrv_is_snapshot() is not related with internal snapshot. It also fixes small code

Re: [Qemu-devel] [libvirt] [PATCH] qapi-schema.json: Reformat TargetType enum to one-per-line

2013-05-25 Thread Andreas Färber
Am 25.05.2013 11:18, schrieb Peter Maydell: On 24 May 2013 22:38, Eric Blake ebl...@redhat.com wrote: I think knowing the architecture (such as x86 vs. pseries ppc) is used by libvirt to know what default devices the board supports (for example, whether usb is present by default). ...but

Re: [Qemu-devel] [PATCH 0/4] Require libfdt for arm/microblaze/ppc softmmu targets

2013-05-25 Thread Edgar E. Iglesias
On Fri, May 24, 2013 at 04:26:53PM +0100, Peter Maydell wrote: This patchset makes libfdt mandatory for building the ARM, MicroBlaze and PPC softmmu targets. These architectures need libfdt for at least some of their board models to be usefully functional, so now that we have an in-tree

Re: [Qemu-devel] [PATCH V13 0/6] enhancement for qmp/hmp interfaces of block info

2013-05-25 Thread Eric Blake
On 05/24/2013 10:24 PM, Wenchao Xia wrote: The cover letter doesn't get committed into git; but if you do respin, it might be worth cleaning up some of the grammar. I know English is not your native language, and you're doing a fine job of coping as it is, but this might help you improve your

Re: [Qemu-devel] [PATCH V13 2/6] block: add image info query function bdrv_query_image_info()

2013-05-25 Thread Eric Blake
On 05/24/2013 10:24 PM, Wenchao Xia wrote: This patch adds function bdrv_query_image_info(), which will retrieve image info in qmp object format. The implementation is based on the code moved from qemu-img.c, but uses block layer function to get snapshot info. Signed-off-by: Wenchao Xia

[Qemu-devel] 2 errors of vnet and snapshot.

2013-05-25 Thread yue-kvm
hi,all i encounterd 2 errors . qemu 1.5(source code build), libvirt libvirt-0.10.2-18.el6_4.2.x86_64. 1. in guest, i can ping out, but get no answers. even throught i ping HOST ip. May 25 20:50:59 ovirtdev NetworkManager[2370]: warn /sys/devices/virtual/net/vnet0: couldn't determine device

Re: [Qemu-devel] [PATCH 2/2] vfio: hugepage support for vfio_iommu_type1

2013-05-25 Thread Alex Williamson
On Sat, 2013-05-25 at 07:20 -0400, Konrad Rzeszutek Wilk wrote: + * Turns out AMD IOMMU has a page table bug where it won't map large pages + * to a region that previously mapped smaller pages. This should be fixed + * soon, so this is just a temporary workaround to break mappings down into

Re: [Qemu-devel] [PATCH 0/2] vfio: type1 iommu hugepage support

2013-05-25 Thread Alex Williamson
On Sat, 2013-05-25 at 07:21 -0400, Konrad Rzeszutek Wilk wrote: On Fri, May 24, 2013 at 11:24:26AM -0600, Alex Williamson wrote: This series let's the vfio type1 iommu backend take advantage of iommu large page support. See patch 2/2 for the details. This has been tested on both amd_iommu

Re: [Qemu-devel] 2 errors of vnet and snapshot.

2013-05-25 Thread Eric Blake
On 05/25/2013 07:15 AM, yue-kvm wrote: hi,all i encounterd 2 errors . qemu 1.5(source code build), libvirt libvirt-0.10.2-18.el6_4.2.x86_64. Are you using RHEL or CentOS? If it is RHEL, then I suggest you ask Red Hat for support. 1. in guest, i can ping out, but get no answers. even

Re: [Qemu-devel] [PATCH V13 3/6] qmp: add recursive member in ImageInfo

2013-05-25 Thread Eric Blake
On 05/24/2013 10:24 PM, Wenchao Xia wrote: New member *backing-image is added to reflect the backing chain status. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- block/qapi.c | 16 +++- qapi-schema.json |5 - 2 files changed, 19 insertions(+), 2

Re: [Qemu-devel] 'qemu-nbd' explicit flush

2013-05-25 Thread Mark Trumpold
On 5/24/13 1:05 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, May 23, 2013 at 09:58:31PM +, Mark Trumpold wrote: I have a working configuration using the signal approach suggested by Stefan. 'qemu-nbd.c' is patched as follows: do { main_loop_wait(false); +

Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files

2013-05-25 Thread Blue Swirl
On Wed, May 22, 2013 at 11:35 AM, Michael S. Tsirkin m...@redhat.com wrote: On Wed, May 22, 2013 at 01:12:15PM +0200, Paolo Bonzini wrote: Il 22/05/2013 13:09, Michael S. Tsirkin ha scritto: Usually I do the same---I just do slightly more thorough testing for configure patches. I've no

Re: [Qemu-devel] Potential to accelerate QEMU for specific architectures

2013-05-25 Thread Blue Swirl
On Fri, May 24, 2013 at 7:24 PM, Lior Vernia liorv...@gmail.com wrote: Hello, I am running x86 applications on an ARM device using QEMU, and found it too slow for my needs. This is to be expected, of course, this is not a complaint. However, I was wondering whether this could be helped by

Re: [Qemu-devel] Potential to accelerate QEMU for specific architectures

2013-05-25 Thread Andreas Färber
Hi, Am 24.05.2013 21:24, schrieb Lior Vernia: I am running x86 applications on an ARM device using QEMU, and found it too slow for my needs. Before we start going into technical details, what are you trying to achieve on a high level and how did you try to do it? Are you using

Re: [Qemu-devel] [PATCH] Remove OSS support for OpenBSD

2013-05-25 Thread Andreas Färber
Am 25.05.2013 01:01, schrieb Brad Smith: Remove the OSS support for OpenBSD. The OSS API has not been usable for quite some time. Signed-off-by: Brad Smith b...@comstyle.com Reviewed-by: Andreas Färber afaer...@suse.de CC'ing qemu-trivial. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr.

[Qemu-devel] [Bug 1184089] [NEW] [Feature request] loadvm snapshot as read-only

2013-05-25 Thread Michael Coppola
Public bug reported: There are many ways to take and manage snapshots in QEMU, but one main feature that's missing is the ability to 'loadvm' a LIVE snapshot and have all future changes redirected to a temporary file. This would effectively be combining the -loadvm and -snapshot switches and

Re: [Qemu-devel] Potential to accelerate QEMU for specific architectures

2013-05-25 Thread Paolo Bonzini
Il 25/05/2013 21:06, Andreas Färber ha scritto: Hi, Am 24.05.2013 21:24, schrieb Lior Vernia: I am running x86 applications on an ARM device using QEMU, and found it too slow for my needs. Before we start going into technical details, what are you trying to achieve on a high level and

Re: [Qemu-devel] [PATCH] i386/translate: ignore 0x67 (PREFIX_ADR) on TARGET_X86_64 CODE64()

2013-05-25 Thread Richard Henderson
On 2013-05-24 14:37, Laszlo Ersek wrote: @@ -4813,7 +4813,11 @@ static target_ulong disas_insn(CPUX86State *env, DisasContext *s, /* 0x66 is ignored if rex.w is set */ dflag = 2; } -if (!(prefixes PREFIX_ADR)) { +if (prefixes PREFIX_ADR) {

[Qemu-devel] [PATCH] monitor: work around delayed CHR_EVENT_OPENED events

2013-05-25 Thread Michael Roth
In the past, CHR_EVENT_OPENED events were emitted via a pre-expired QEMUTimer. Due to timers being processing at the tail end of each main loop iteration, this generally meant that such events would be emitted within the same main loop iteration, prior any client data being read by tcp/unix socket

Re: [Qemu-devel] [Qemu-stable] qmp commands get rejected

2013-05-25 Thread mdroth
On Sat, May 25, 2013 at 01:09:50PM +0200, Stefan Priebe wrote: Am 25.05.2013 00:32, schrieb mdroth: On Sat, May 25, 2013 at 12:12:22AM +0200, Stefan Priebe wrote: Am 25.05.2013 00:09, schrieb mdroth: I would try to create a small example script. I use qmp-shell and other little scripts very

Re: [Qemu-devel] Potential to accelerate QEMU for specific architectures

2013-05-25 Thread Lior Vernia
Hello, On Sat, May 25, 2013 at 10:06 PM, Andreas Färber afaer...@suse.de wrote: Hi, Am 24.05.2013 21:24, schrieb Lior Vernia: I am running x86 applications on an ARM device using QEMU, and found it too slow for my needs. Before we start going into technical details, what are you trying to