Re: [Qemu-devel] [PATCH V2 0/3] Introduce COLO-compare

2016-03-31 Thread Zhang Chen
On 03/30/2016 08:05 PM, Dr. David Alan Gilbert wrote: * Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: COLO-compare is a part of COLO project. It is used to compare the network package to help COLO decide whether to do checkpoint. Hi Zhang Chen, I've put comments on the individual

Re: [Qemu-devel] [PATCH V2 3/3] colo-compare: introduce packet comparison thread

2016-03-31 Thread Zhang Chen
On 03/30/2016 07:41 PM, Dr. David Alan Gilbert wrote: * Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: if packets are same, we send primary packet and drop secondary packet, otherwise notify COLO do checkpoint. Signed-off-by: Zhang Chen Signed-off-by: Li

Re: [Qemu-devel] [PATCH] target-ppc: Multiple/String Word alignment exception

2016-03-31 Thread Alexander Graf
On 31.03.16 01:29, David Gibson wrote: > On Wed, 30 Mar 2016 19:13:00 +0200 > Laurent Vivier wrote: > >> If the processor is in little-endian mode, an alignment interrupt must >> occur for the following instructions: lmw, stmw, lswi, lswx, stswi or stswx. >> >> This is what

Re: [Qemu-devel] [PATCH] target-ppc: Multiple/String Word alignment exception

2016-03-31 Thread Laurent Vivier
On 31/03/2016 08:54, Alexander Graf wrote: > > > On 31.03.16 01:29, David Gibson wrote: >> On Wed, 30 Mar 2016 19:13:00 +0200 >> Laurent Vivier wrote: >> >>> If the processor is in little-endian mode, an alignment interrupt must >>> occur for the following instructions:

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] spapr: compute interrupt vector address from LPCR

2016-03-31 Thread Mark Cave-Ayland
On 31/03/16 05:55, David Gibson wrote: > On Wed, Mar 30, 2016 at 05:38:34PM +0200, Cédric Le Goater wrote: >> This address is changed by the linux kernel using the H_SET_MODE hcall >> and needs to be restored when migrating a spapr VM running in >> TCG. This can be done using the AIL bits from

Re: [Qemu-devel] [PATCH] target-ppc: Multiple/String Word alignment exception

2016-03-31 Thread Laurent Vivier
On 31/03/2016 09:15, Alexander Graf wrote: > > > On 31.03.16 09:06, Laurent Vivier wrote: >> >> >> On 31/03/2016 08:54, Alexander Graf wrote: >>> >>> >>> On 31.03.16 01:29, David Gibson wrote: On Wed, 30 Mar 2016 19:13:00 +0200 Laurent Vivier wrote: > If

Re: [Qemu-devel] [patch v5 11/12] vfio: device may stuck in D3 when doing aer recovery

2016-03-31 Thread Chen Fan
On 03/25/2016 10:22 AM, Alex Williamson wrote: On Fri, 25 Mar 2016 09:38:09 +0800 Chen Fan wrote: On 03/25/2016 06:54 AM, Alex Williamson wrote: On Wed, 23 Mar 2016 18:12:06 +0800 Cao jin wrote: From: Chen Fan

Re: [Qemu-devel] [PATCH] target-ppc: Multiple/String Word alignment exception

2016-03-31 Thread Alexander Graf
On 31.03.16 09:06, Laurent Vivier wrote: > > > On 31/03/2016 08:54, Alexander Graf wrote: >> >> >> On 31.03.16 01:29, David Gibson wrote: >>> On Wed, 30 Mar 2016 19:13:00 +0200 >>> Laurent Vivier wrote: >>> If the processor is in little-endian mode, an alignment

Re: [Qemu-devel] [patch v5 07/12] pci: add a pci_function_is_valid callback to check function if valid

2016-03-31 Thread Chen Fan
On 03/27/2016 08:19 PM, Michael S. Tsirkin wrote: On Thu, Mar 24, 2016 at 04:54:33PM -0600, Alex Williamson wrote: On Wed, 23 Mar 2016 18:12:02 +0800 Cao jin wrote: From: Chen Fan PCI hotplug requires that function 0 is added last to

Re: [Qemu-devel] [PATCH 0/4] Fix QEMU crash on vhost-user socket disconnect.

2016-03-31 Thread Ilya Maximets
On 30.03.2016 20:01, Michael S. Tsirkin wrote: > On Wed, Mar 30, 2016 at 06:14:05PM +0300, Ilya Maximets wrote: >> Currently QEMU always crashes in following scenario (assume that >> vhost-user application is Open vSwitch with 'dpdkvhostuser' port): > > In fact, wouldn't the right thing to do be

Re: [Qemu-devel] [PATCH V2 1/3] colo-compare: introduce colo compare initlization

2016-03-31 Thread Zhang Chen
On 03/31/2016 09:41 AM, Zhang Chen wrote: On 03/30/2016 05:25 PM, Dr. David Alan Gilbert wrote: * Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: packet come from primary char indev will be send to outdev - packet come from secondary char dev will be drop Please put in the description

Re: [Qemu-devel] [PATCH 1/1] virtio: fix ioeventfd assignment race

2016-03-31 Thread tu bo
Hi Cornelia: On 03/31/2016 10:43 AM, tu bo wrote: Hi Cornelia: I saw qemu crash for this patch on qemu master yesterday. However, scsi disks of my lpar is not available because of s38 firmware update. I'll double check the test when it's ready. thx I still can see crash like below, (gdb)

Re: [Qemu-devel] [PATCH 0/9] some QOM'ify work under hw/arm

2016-03-31 Thread Peter Maydell
On 31 March 2016 at 02:48, xiaoqiang zhao wrote: > > 在 2016年03月16日 20:00, Peter Maydell 写道: >> >> On 16 March 2016 at 11:31, Peter Maydell wrote: >>> >>> A general note -- since these aren't bug fixes and we're in soft >>> freeze now, I don't think

Re: [Qemu-devel] [PATCH 3/9] virtio-blk: fix disabled mode

2016-03-31 Thread tu bo
Hi Paolo: On 03/30/2016 08:48 PM, Paolo Bonzini wrote: The missing check on dataplane_disabled caused a segmentation fault in notify_guest_bh, because s->guest_notifier was NULL. Signed-off-by: Paolo Bonzini --- hw/block/dataplane/virtio-blk.c | 7 +++

[Qemu-devel] [RFC PATCH v2.1 01/12] exec: Remove cpu from cpus list during cpu_exec_exit()

2016-03-31 Thread Bharata B Rao
CPUState *cpu gets added to the cpus list during cpu_exec_init(). It should be removed from cpu_exec_exit(). cpu_exec_exit() is called from generic CPU::instance_finalize and some archs like PowerPC call it from CPU unrealizefn. So ensure that we dequeue the cpu only once. Now -1 value for

[Qemu-devel] [RFC PATCH v2.1 06/12] cpu: Abstract CPU core type

2016-03-31 Thread Bharata B Rao
Add an abstract CPU core type that could be used by machines that want to define and hotplug CPUs in core granularity. Signed-off-by: Bharata B Rao Signed-off-by: Igor Mammedov [Integer core property] Reviewed-by: David Gibson

Re: [Qemu-devel] [PATCHv2 1/5] slirp: Allow disabling IPv4 or IPv6

2016-03-31 Thread Thomas Huth
On 31.03.2016 00:58, Samuel Thibault wrote: > Add ipv4 and ipv6 boolean options, so the user can setup IPv4-only and > IPv6-only network environments. > > Signed-off-by: Samuel Thibault > > --- > > Changes since previous versions: > > - fix coding style > -

Re: [Qemu-devel] [PATCHv2 3/5] slirp: Add dns6 resolution

2016-03-31 Thread Thomas Huth
On 31.03.2016 00:58, Samuel Thibault wrote: > This makes get_dns_addr address family-agnostic, thus allowing to add the > IPv6 case. > > Signed-off-by: Samuel Thibault > > --- > Changes since v1: > - code layout > - cope with inet_ntop returning NULL > - move

Re: [Qemu-devel] [RFC v2 4/6] hw/misc: sdm virtio device

2016-03-31 Thread Stefan Hajnoczi
On Fri, Mar 18, 2016 at 10:13:03AM +0100, Baptiste Reynal wrote: > This is the virtio implementation for an SDM device. > > Parameters are: > comm=[sdm_communication_id] specifies the communication channel > master=[true/false] - configure the SDM device as master or slave >

Re: [Qemu-devel] [PATCH] target-ppc: Multiple/String Word alignment exception

2016-03-31 Thread Thomas Huth
On 31.03.2016 11:03, Alexander Graf wrote: > On 03/31/2016 10:50 AM, Thomas Huth wrote: >> On 31.03.2016 09:15, Alexander Graf wrote: >>> On 31.03.16 09:06, Laurent Vivier wrote: On 31/03/2016 08:54, Alexander Graf wrote: > On 31.03.16 01:29, David Gibson wrote: >> On Wed, 30 Mar 2016

Re: [Qemu-devel] [PATCH 0/4] Fix QEMU crash on vhost-user socket disconnect.

2016-03-31 Thread Michael S. Tsirkin
On Thu, Mar 31, 2016 at 09:02:01AM +0300, Ilya Maximets wrote: > On 30.03.2016 20:01, Michael S. Tsirkin wrote: > > On Wed, Mar 30, 2016 at 06:14:05PM +0300, Ilya Maximets wrote: > >> Currently QEMU always crashes in following scenario (assume that > >> vhost-user application is Open vSwitch with

Re: [Qemu-devel] qemu-img convert corruption (raw to raw)

2016-03-31 Thread Stefan Hajnoczi
On Wed, Mar 23, 2016 at 09:20:06AM +0100, Dominik Csapak wrote: > I have a strange issue with qemu-img convert which corrupts my images, and > found nothing relevant online. > Maybe someone here can help me. Please post your QEMU command-line (ps aux | grep qemu while the guest is running).

Re: [Qemu-devel] [PATCH] trace-events: Fix typos (found by codespell)

2016-03-31 Thread Stefan Hajnoczi
On Wed, Mar 23, 2016 at 03:38:20PM +0100, Stefan Weil wrote: > Signed-off-by: Stefan Weil > --- > trace-events | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Thanks, applied to my tracing tree: https://github.com/stefanha/qemu/commits/tracing Stefan

Re: [Qemu-devel] [PATCH v2] spapr: compute interrupt vector address from LPCR

2016-03-31 Thread Cédric Le Goater
>>> Index: qemu-dgibson-for-2.6.git/hw/ppc/spapr_hcall.c >>> === >>> --- qemu-dgibson-for-2.6.git.orig/hw/ppc/spapr_hcall.c >>> +++ qemu-dgibson-for-2.6.git/hw/ppc/spapr_hcall.c >>> @@ -835,17 +835,8 @@ static target_ulong

Re: [Qemu-devel] [PATCH v2] spapr: compute interrupt vector address from LPCR

2016-03-31 Thread Cédric Le Goater
On 03/31/2016 06:55 AM, David Gibson wrote: > On Wed, Mar 30, 2016 at 05:38:34PM +0200, Cédric Le Goater wrote: >> This address is changed by the linux kernel using the H_SET_MODE hcall >> and needs to be restored when migrating a spapr VM running in >> TCG. This can be done using the AIL bits

Re: [Qemu-devel] [PATCH v2] spapr: compute interrupt vector address from LPCR

2016-03-31 Thread Cédric Le Goater
On 03/30/2016 07:12 PM, Greg Kurz wrote: > On Wed, 30 Mar 2016 17:38:34 +0200 > Cédric Le Goater wrote: > >> This address is changed by the linux kernel using the H_SET_MODE hcall >> and needs to be restored when migrating a spapr VM running in >> TCG. This can be done using the

Re: [Qemu-devel] [PATCH 3/9] virtio-blk: fix disabled mode

2016-03-31 Thread Paolo Bonzini
On 31/03/2016 10:32, tu bo wrote: >> >> diff --git a/include/hw/virtio/virtio-blk.h >> b/include/hw/virtio/virtio-blk.h >> index 5cb66cd..073c632 100644 >> --- a/include/hw/virtio/virtio-blk.h >> +++ b/include/hw/virtio/virtio-blk.h >> @@ -53,6 +53,7 @@ typedef struct VirtIOBlock { >>

[Qemu-devel] [RFC PATCH v2.1 00/12] Core based CPU hotplug for PowerPC sPAPR

2016-03-31 Thread Bharata B Rao
Hi, This is v2.1 of "Core based CPU hotplug for PowerPC sPAPR". v2 was posted here: https://lists.gnu.org/archive/html/qemu-ppc/2016-03/msg00201.html I am making this v2.1 instead of v3 as this introduces a change in device_add semantics and if we don't want to continue this, I will go back to

[Qemu-devel] [RFC PATCH v2.1 08/12] spapr: Add CPU type specific core devices

2016-03-31 Thread Bharata B Rao
Introduce core devices for each CPU type supported by sPAPR. These core devices are derived from the base spapr-cpu-core device type. TODO: - Add core types for other remaining CPU types - Handle CPU model alias correctly Signed-off-by: Bharata B Rao ---

[Qemu-devel] [RFC PATCH v2.1 07/12] spapr: Abstract CPU core device

2016-03-31 Thread Bharata B Rao
Add sPAPR specific abastract CPU core device that is based on generic CPU core device. This will serve as base type for all PowerPC CPU specific core devices. Signed-off-by: Bharata B Rao --- hw/ppc/Makefile.objs| 1 + hw/ppc/spapr_cpu_core.c |

[Qemu-devel] [RFC PATCH v2.1 11/12] xics, xics_kvm: Handle CPU unplug correctly

2016-03-31 Thread Bharata B Rao
XICS is setup for each CPU during initialization. Provide a routine to undo the same when CPU is unplugged. While here, move ss->cs management into xics from xics_kvm since there is nothing KVM specific in it. Also ensure xics reset doesn't set irq for CPUs that are already unplugged. This allows

[Qemu-devel] [RFC PATCH v2.1 05/12] qdev: hotplug: Introduce HotplugHandler.pre_plug() callback

2016-03-31 Thread Bharata B Rao
From: Igor Mammedov pre_plug callback is to be called before device.realize() is executed. This would allow to check/set device's properties from HotplugHandler. Signed-off-by: Igor Mammedov Signed-off-by: Bharata B Rao ---

[Qemu-devel] [Bug 1562653] Re: Ubuntu 15.10: QEMU VM hang if memory >= 1T

2016-03-31 Thread changlimin
After I changed PHYS_ADDR_MASK, qemu vm can start when memory >=1024G , but kvm vm still hang. -# define PHYS_ADDR_MASK 0xffLL +# define PHYS_ADDR_MASK 0xfffLL -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH] target-ppc: Multiple/String Word alignment exception

2016-03-31 Thread Thomas Huth
On 31.03.2016 09:15, Alexander Graf wrote: > > On 31.03.16 09:06, Laurent Vivier wrote: >> >> On 31/03/2016 08:54, Alexander Graf wrote: >>> >>> On 31.03.16 01:29, David Gibson wrote: On Wed, 30 Mar 2016 19:13:00 +0200 Laurent Vivier wrote: > If the

[Qemu-devel] [PULL 2/5] slirp: Split get_dns_addr

2016-03-31 Thread Samuel Thibault
Separate get_dns_addr into get_dns_addr_cached and get_dns_addr_resolv_conf to make conversion to IPv6 easier. Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- slirp/slirp.c | 53 ++--- 1

[Qemu-devel] [PULL 5/5] slirp: Add RDNSS advertisement

2016-03-31 Thread Samuel Thibault
This adds the RDNSS option to IPv6 router advertisements, so that the guest can autoconfigure the DNS server address. Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- slirp/ip6_icmp.c | 19 --- slirp/ip6_icmp.h | 12

Re: [Qemu-devel] Why is SeaBIOS used with -kernel?

2016-03-31 Thread Stefan Hajnoczi
On Sat, Mar 19, 2016 at 08:31:24PM +, Richard W.M. Jones wrote: > Is there something I'm missing, or for Linux + -kernel could we use a > much simpler BIOS? The data that Marc Mari collected when comparing qboot with an optimized SeaBIOS/QEMU showed that there's no need for a separate

Re: [Qemu-devel] [PATCHv2 3/5] slirp: Add dns6 resolution

2016-03-31 Thread Samuel Thibault
Hello, Thanks for the reviews! Samuel

Re: [Qemu-devel] [Qemu-Devel] [PATCH] Changed malloc to g_malloc, free to g_free in linux-user/qemu.h

2016-03-31 Thread Stefan Hajnoczi
On Wed, Mar 30, 2016 at 09:58:41PM +0530, haris iqbal wrote: > On Wed, Mar 30, 2016 at 7:39 PM, Stefan Hajnoczi wrote: > > On Thu, Mar 24, 2016 at 12:02:03AM +0530, Md Haris Iqbal wrote: > >> Signed-off-by: Md Haris Iqbal > >> --- > >> linux-user/qemu.h

Re: [Qemu-devel] [PATCH V2 0/3] Introduce COLO-compare

2016-03-31 Thread Dr. David Alan Gilbert
* Li Zhijian (lizhij...@cn.fujitsu.com) wrote: > > > On 03/30/2016 08:05 PM, Dr. David Alan Gilbert wrote: > >* Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: > >>COLO-compare is a part of COLO project. It is used > >>to compare the network package to help COLO decide > >>whether to do

[Qemu-devel] [RFC PATCH v2.1 04/12] cpu: Add a sync version of cpu_remove()

2016-03-31 Thread Bharata B Rao
This sync API will be used by the CPU hotplug code to wait for the CPU to completely get removed before flagging the failure to the device_add command. Sync version of this call is needed to correctly recover from CPU realization failures when ->plug() handler fails. Signed-off-by: Bharata B Rao

[Qemu-devel] [RFC PATCH v2.1 03/12] cpu: Reclaim vCPU objects

2016-03-31 Thread Bharata B Rao
From: Gu Zheng In order to deal well with the kvm vcpus (which can not be removed without any protection), we do not close KVM vcpu fd, just record and mark it as stopped into a list, so that we can reuse it for the appending cpu hot-add request if possible. It is also

Re: [Qemu-devel] [PATCH V2 3/3] colo-compare: introduce packet comparison thread

2016-03-31 Thread Dr. David Alan Gilbert
* Li Zhijian (lizhij...@cn.fujitsu.com) wrote: > > > On 03/30/2016 07:41 PM, Dr. David Alan Gilbert wrote: > [...] > > >>>@@ -433,7 +532,9 @@ static void compare_pri_chr_in(void *opaque, const > >>>uint8_t *buf, int size) > >>> if (ret == 1) { > >>> if (packet_enqueue(s,

[Qemu-devel] [PULL] Fix ipv6 options according to documentation

2016-03-31 Thread Samuel Thibault
The options names were fixed in the qapi layer, but not in the command-line options. Signed-off-by: Samuel Thibault Reviewed-by: Eric Blake --- net/net.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

[Qemu-devel] [PULL] Fix ipv6 options according to documentation

2016-03-31 Thread Samuel Thibault
The following changes since commit 9370a3bbc478f623dd21d783560629ea2064625b: Update version for v2.6.0-rc0 release (2016-03-30 19:25:40 +0100) are available in the git repository at: http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault for you to fetch changes up to

[Qemu-devel] [PULL 0/5] ipv4-only and ipv6-only support

2016-03-31 Thread Samuel Thibault
Update version for v2.6.0-rc0 release (2016-03-30 19:25:40 +0100) are available in the git repository at: http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault-2 for you to fetch changes up to c99751f2a711e9eecf60901520c6d4197bdaf9b4: slirp: Add RDNSS advertisement

Re: [Qemu-devel] [PATCH V2 1/3] colo-compare: introduce colo compare initlization

2016-03-31 Thread Dr. David Alan Gilbert
* Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: > > > On 03/30/2016 05:25 PM, Dr. David Alan Gilbert wrote: > >* Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: > >>packet come from primary char indev will be send to > >>outdev - packet come from secondary char dev will be drop > >Please

Re: [Qemu-devel] [PATCH v3] Add param Error ** for msi_init()

2016-03-31 Thread Cao jin
On 03/30/2016 05:00 PM, Marcel Apfelbaum wrote: On 03/30/2016 07:10 AM, Cao jin wrote: Hi, Yes, I should add more hint message. I don`t quite understand about: /have a "warning only" error type so the reporting party can decide to issue a warning or to fail/ Do you mean still using

Re: [Qemu-devel] [PATCH 0/9] some QOM'ify work under hw/arm

2016-03-31 Thread xiaoqiang zhao
> 在 2016年3月31日,16:05,Peter Maydell 写道: > >> On 31 March 2016 at 02:48, xiaoqiang zhao wrote: >> >>> 在 2016年03月16日 20:00, Peter Maydell 写道: >>> On 16 March 2016 at 11:31, Peter Maydell wrote: A general

[Qemu-devel] [RFC PATCH v2.1 12/12] spapr: CPU hot unplug support

2016-03-31 Thread Bharata B Rao
Remove the CPU core device by removing the underlying CPU thread devices. Hot removal of CPU for sPAPR guests is achieved by sending the hot unplug notification to the guest. Release the vCPU object after CPU hot unplug so that vCPU fd can be parked and reused. Signed-off-by: Bharata B Rao

[Qemu-devel] [RFC PATCH v2.1 09/12] spapr: convert boot CPUs into CPU core devices

2016-03-31 Thread Bharata B Rao
Introduce sPAPRMachineClass.dr_cpu_enabled to indicate support for CPU core hotplug. Initialize boot time CPUs as core deivces and prevent topologies that result in partially filled cores. Both of these are done only if CPU core hotplug is supported. Note: An unrelated change in the call to

[Qemu-devel] [RFC PATCH v2.1 02/12] exec: Do vmstate unregistration from cpu_exec_exit()

2016-03-31 Thread Bharata B Rao
cpu_exec_init() does vmstate_register for the CPU device. This needs to be undone from cpu_exec_exit(). This change is needed to support CPU hot removal. Signed-off-by: Bharata B Rao Reviewed-by: Thomas Huth Reviewed-by: David Gibson

Re: [Qemu-devel] [PATCH V2 2/3] colo-compare: track connection and enqueue packet

2016-03-31 Thread Dr. David Alan Gilbert
* Li Zhijian (lizhij...@cn.fujitsu.com) wrote: > > > On 03/30/2016 06:36 PM, Dr. David Alan Gilbert wrote: > >* Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: ... > >>+static inline void colo_flush_connection(void *opaque, void *user_data) > >>+{ > > > >Is this used? > Yes, it isn't used

[Qemu-devel] [RFC PATCH v2.1 10/12] spapr: CPU hotplug support

2016-03-31 Thread Bharata B Rao
Set up device tree entries for the hotplugged CPU core and use the exising RTAS event logging infrastructure to send CPU hotplug notification to the guest. Signed-off-by: Bharata B Rao --- hw/ppc/spapr.c | 58 ++

Re: [Qemu-devel] [PATCH] target-ppc: Multiple/String Word alignment exception

2016-03-31 Thread Alexander Graf
On 03/31/2016 10:50 AM, Thomas Huth wrote: On 31.03.2016 09:15, Alexander Graf wrote: On 31.03.16 09:06, Laurent Vivier wrote: On 31/03/2016 08:54, Alexander Graf wrote: On 31.03.16 01:29, David Gibson wrote: On Wed, 30 Mar 2016 19:13:00 +0200 Laurent Vivier wrote: If

Re: [Qemu-devel] [PATCH 1/1] backend: multi-client-socket

2016-03-31 Thread Stefan Hajnoczi
On Fri, Mar 18, 2016 at 10:12:46AM +0100, Baptiste Reynal wrote: > This patch introduces a new socket for QEMU, called multi-client-socket. This > socket allows multiple QEMU instances to communicate by sharing messages > and file descriptors. > > A socket can be instantiated with the following

Re: [Qemu-devel] [RFC v2 0/6] QEMU shared-memory backend

2016-03-31 Thread Stefan Hajnoczi
On Fri, Mar 18, 2016 at 10:13:52AM +0100, Baptiste Reynal wrote: > A new memory backend, the shared memory backend, based on > the file memory backend. > > This new backend allows a master QEMU instance to share a part of > his main memory whith a slave QEMU instance. It is then possible to load

[Qemu-devel] [PULL 1/5] slirp: Allow disabling IPv4 or IPv6

2016-03-31 Thread Samuel Thibault
Add ipv4 and ipv6 boolean options, so the user can setup IPv4-only and IPv6-only network environments. Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- net/slirp.c | 36 ++-- qapi-schema.json | 8

[Qemu-devel] [PULL 4/5] slirp: Support link-local DNS addresses

2016-03-31 Thread Samuel Thibault
They look like fe80::%eth0 Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- slirp/libslirp.h | 2 +- slirp/slirp.c| 26 ++ slirp/socket.c | 2 +- 3 files changed, 24 insertions(+), 6 deletions(-) diff

[Qemu-devel] [PULL 3/5] slirp: Add dns6 resolution

2016-03-31 Thread Samuel Thibault
This makes get_dns_addr address family-agnostic, thus allowing to add the IPv6 case. Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- slirp/ip6.h | 9 +++ slirp/libslirp.h | 1 + slirp/slirp.c| 79

Re: [Qemu-devel] [PULL 0/5] ipv4-only and ipv6-only support

2016-03-31 Thread Samuel Thibault
Peter Maydell, on Thu 31 Mar 2016 12:30:24 +0100, wrote: > On 31 March 2016 at 10:20, Samuel Thibault > wrote: > > http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault-2 > > > > for you to fetch changes up to c99751f2a711e9eecf60901520c6d4197bdaf9b4:

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-31 Thread Alberto Garcia
On Wed 30 Mar 2016 05:07:15 PM CEST, Max Reitz wrote: >> I also have another (not directly related) question: why not simply >> use the node name when removing children? I understood that the idea >> was that it's possible to have the same node attached twice to the >> same Quorum, but can you

[Qemu-devel] [PATCH for-2.7] hw/net/spapr_llan: Delay flushing of the RX queue while adding new RX buffers

2016-03-31 Thread Thomas Huth
Currently, the spapr-vlan device is trying to flush the RX queue after each RX buffer that has been added by the guest via the H_ADD_LOGICAL_LAN_BUFFER hypercall. In case the receive buffer pool was empty before, we only pass single packets to the guest this way. This can cause very bad

Re: [Qemu-devel] [PATCH] ipack: Update e-mail address

2016-03-31 Thread Alberto Garcia
ping 2 ... On Tue 23 Feb 2016 09:44:25 AM CET, Alberto Garcia wrote: > I'm not really using the old one anymore. > > Signed-off-by: Alberto Garcia > --- > hw/char/ipoctal232.c | 2 +- > hw/ipack/ipack.c | 2 +- > hw/ipack/tpci200.c | 2 +- >

Re: [Qemu-devel] [PULL 0/5] ipv4-only and ipv6-only support

2016-03-31 Thread Vasiliy Tolstov
2016-03-31 14:44 GMT+03:00 Samuel Thibault : > The first commit, at least, would very probably be welcome: now that > ipv6 will be enabled by default, this may disturb some people for > whatever reason, so they may want to have a way to disable it. > > Also, some people

Re: [Qemu-devel] [PATCH 2/2] target-mips: Implement IEEE 754-2008 functionality for R6 and MSA instructions

2016-03-31 Thread Aleksandar Markovic
Hi, Richard, what would you think about this approach: Functionality of . and .. instructions is dependent on flags ABS2008 and NAN2008 in FCR31. There are MIPS architectures (for example mips32r5) that allow implementations with different

Re: [Qemu-devel] [PULL 0/5] ipv4-only and ipv6-only support

2016-03-31 Thread Samuel Thibault
Vasiliy Tolstov, on Thu 31 Mar 2016 14:49:35 +0300, wrote: > Yes, i'm using older version of this patch and without working ipv6 on > host my vm tries to access network via ipv6 (prefered) and not able to > connect. I'm surprised that the vm tries to access the network via ipv6 by default. Which

Re: [Qemu-devel] [PULL 0/5] ipv4-only and ipv6-only support

2016-03-31 Thread Vasiliy Tolstov
2016-03-31 14:57 GMT+03:00 Samuel Thibault : > I'm surprised that the vm tries to access the network via ipv6 by > default. Which OS is this? With the default fec0:: prefix, ipv4 > should be preferred. Latest versions of the patch (which was commited) > also make qemu

Re: [Qemu-devel] [PULL 0/5] ipv4-only and ipv6-only support

2016-03-31 Thread Vasiliy Tolstov
2016-03-31 15:03 GMT+03:00 Vasiliy Tolstov : > > This is debian. I'm use old patch for qemu-2.1.0. May be my problem that my host system have ipv6 address but i'm not able to connect to remote servers via ipv6. -- Vasiliy Tolstov, e-mail: v.tols...@selfip.ru

Re: [Qemu-devel] [PULL 0/5] ipv4-only and ipv6-only support

2016-03-31 Thread Samuel Thibault
Vasiliy Tolstov, on Thu 31 Mar 2016 15:03:31 +0300, wrote: > 2016-03-31 14:57 GMT+03:00 Samuel Thibault : > > I'm surprised that the vm tries to access the network via ipv6 by > > default. Which OS is this? With the default fec0:: prefix, ipv4 > > should be preferred.

Re: [Qemu-devel] [PULL 0/5] ipv4-only and ipv6-only support

2016-03-31 Thread Samuel Thibault
Vasiliy Tolstov, on Thu 31 Mar 2016 15:04:02 +0300, wrote: > 2016-03-31 15:03 GMT+03:00 Vasiliy Tolstov : > > This is debian. I'm use old patch for qemu-2.1.0. > > > May be my problem that my host system have ipv6 address but i'm not > able to connect to remote servers via

Re: [Qemu-devel] [PULL 0/5] ipv4-only and ipv6-only support

2016-03-31 Thread Vasiliy Tolstov
2016-03-31 15:14 GMT+03:00 Samuel Thibault : > But your host system does not have a default ipv6 route, right? In > that case, qemu gets an error, and with the latest version of the patch > reports it to the guest via icmpv6, which then promptly fallbacks to > ipv4.

[Qemu-devel] [PATCH 1/3] nbd: Treat flags vs. command type as separate fields

2016-03-31 Thread Eric Blake
Current upstream NBD documents that requests have a 16-bit flags, followed by a 16-bit type integer; although older versions mentioned only a 32-bit field with masking to find flags. Since the protocol is in network order (big-endian over the wire), the ABI is unchanged; but dealing with the

[Qemu-devel] [PATCH 3/3] nbd: Reject unknown request flags

2016-03-31 Thread Eric Blake
The NBD protocol says that clients should not send a command flag that has not been negotiated (whether by the client requesting an option during a handshake, or because we advertise support for the flag in response to NBD_OPT_EXPORT_NAME), and that servers should reject invalid flags with EINVAL.

Re: [Qemu-devel] [PATCH] slirp: Fix migration from older versions of QEMU to the current one

2016-03-31 Thread Samuel Thibault
Thomas Huth, on Thu 31 Mar 2016 16:48:41 +0200, wrote: > While adding the IPv6 support, the commit eae303ff23f51259eddc8856c71453d8 > ("slirp: Make Socket structure IPv6 compatible") changed the format of > the migration stream, without taking into account that we might still > receive an old

Re: [Qemu-devel] [PATCH v4 12/13] docker: Add EXTRA_CONFIGURE_OPTS

2016-03-31 Thread Alex Bennée
Fam Zheng writes: > Whatever passed in this variable will be appended to all > configure commands. Reviewed-by: Alex Bennée > > Signed-off-by: Fam Zheng > --- > tests/docker/Makefile.include | 3 +++ > tests/docker/common.rc

Re: [Qemu-devel] [Bug?] Windows 7's time drift obviously while RTC rate switching frequently between high and low timer rate

2016-03-31 Thread Hailiang Zhang
ping... It seems that we can eliminate the drift by the following patch. (I tested it for two hours, and there is no drift, before, the timer in Windows 7 drifts about 2 seconds per minute.) I'm not sure if it is the right way to solve the problem. Any comments are welcomed. Thanks. From

Re: [Qemu-devel] [Qemu-stable] [PATCH] target-i386: do not read/write MSR_TSC_AUX from KVM if CPUID bit is not set

2016-03-31 Thread Paolo Bonzini
On 31/03/2016 15:12, Peter Lieven wrote: >> >>> KVM does not let you read or write this MSR if the corresponding CPUID >>> bit is not set. This in turn causes MSRs that come after MSR_TSC_AUX >>> to be ignored by KVM_SET_MRSS. > > Is it possible that this causes a freeze when migrating vom

Re: [Qemu-devel] [PATCH v4 07/13] docker: Add full test

2016-03-31 Thread Alex Bennée
Fam Zheng writes: > This builds all available targets. I'm not sure what this adds over the quick test that couldn't be achieved with the configure defaulting to an empty target list. I'm easy either way but I'm thinking test-quick and test-full could be merged into

Re: [Qemu-devel] [PATCH v4 08/13] docker: Add clang test

2016-03-31 Thread Alex Bennée
Fam Zheng writes: > The (currently partially commented out) configure options are suggested > by John Snow . > > Reviewed-by: Alex Bennée > Signed-off-by: Fam Zheng > --- > tests/docker/test-clang | 25

Re: [Qemu-devel] tcg: reworking tb_invalidated_flag

2016-03-31 Thread Alex Bennée
Sergey Fedorov writes: > On 30/03/16 21:13, Paolo Bonzini wrote: >> >> On 30/03/2016 19:08, Sergey Fedorov wrote: >>> The second approach is to make 'tb_invalidated_flag' per-CPU. This >>> would be conceptually similar to what we have, but would give us thread >>> safety.

Re: [Qemu-devel] tcg: reworking tb_invalidated_flag

2016-03-31 Thread Paolo Bonzini
On 31/03/2016 15:14, Sergey Fedorov wrote: > On 30/03/16 21:13, Paolo Bonzini wrote: >> >> On 30/03/2016 19:08, Sergey Fedorov wrote: >>> The second approach is to make 'tb_invalidated_flag' per-CPU. This >>> would be conceptually similar to what we have, but would give us thread >>> safety.

Re: [Qemu-devel] [PATCH v2 2/5] .travis.yml: enable OSX builds

2016-03-31 Thread Alex Bennée
Alex Bennée writes: > Travis has support for OSX builds. Making the setup work cleanly > involves a little hacking about with the .travis.yml file but rather > than make it too messy I've pushed all the "brew" install stuff into a > support script called

[Qemu-devel] [PATCH for-2.6] spapr_drc: enable immediate detach for unsignalled devices

2016-03-31 Thread Michael Roth
Currently spapr doesn't support "aborting" hotplug of PCI devices by allowing device_del to immediately remove the device if we haven't signalled the presence of the device to the guest. In the past this wasn't an issue, since we always immediately signalled device attach and simply relied on

[Qemu-devel] [PATCH 0/3] NBD: flag handling cleanup

2016-03-31 Thread Eric Blake
I'm currently helping with work on adding extensions to the upstream NBD protocol to allow more efficient handling of sparse files, and wanted to get my feet wet in the qemu NBD code (both client and server), to actually implement those proposals to see how well they work. In the process, I found

[Qemu-devel] [PATCH 2/3] nbd: Fix poor debug message

2016-03-31 Thread Eric Blake
The client sends messages to the server, not itself. Signed-off-by: Eric Blake --- nbd/client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nbd/client.c b/nbd/client.c index 5af9f26..d95ad7a 100644 --- a/nbd/client.c +++ b/nbd/client.c @@ -635,7 +635,7

Re: [Qemu-devel] [PATCH v2 1/3] tcg: code_bitmap is not used by user-mode emulation

2016-03-31 Thread Alex Bennée
Sergey Fedorov writes: > From: Paolo Bonzini > > Signed-off-by: Paolo Bonzini > [Sergey Fedorov: eliminate the field entirely in user-mode] > Signed-off-by: Sergey Fedorov Reviewed-by: Alex

Re: [Qemu-devel] [PATCH v2 1/1] NBD proto: add WRITE_ZEROES extension

2016-03-31 Thread Paolo Bonzini
On 31/03/2016 15:53, Alex Bligh wrote: >> > +If the flag `NBD_CMD_FLAG_MAY_TRIM` was set by the client in the >> > command >> > +flags field, the server MAY use trimming to zero out the area, but it >> > +MUST ensure that the data reads back as zero. >> > + > Can you give an example

Re: [Qemu-devel] tcg: reworking tb_invalidated_flag

2016-03-31 Thread Sergey Fedorov
On 31/03/16 16:37, Alex Bennée wrote: > Sergey Fedorov writes: >> Looks like no matter which approach we use, it's ultimately necessary to >> ensure all CPUs have exited from translated code before the translation >> buffer may be safely flushed. > One approach would be to

Re: [Qemu-devel] [PULL 0/4] Tracing patches

2016-03-31 Thread Peter Maydell
On 31 March 2016 at 13:35, Stefan Hajnoczi wrote: > The following changes since commit 9370a3bbc478f623dd21d783560629ea2064625b: > > Update version for v2.6.0-rc0 release (2016-03-30 19:25:40 +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] Why is SeaBIOS used with -kernel?

2016-03-31 Thread Kevin O'Connor
On Thu, Mar 31, 2016 at 11:17:30PM +0100, Richard W.M. Jones wrote: > On Thu, Mar 31, 2016 at 12:22:23PM -0400, Kevin O'Connor wrote: > > On Thu, Mar 31, 2016 at 10:21:25AM +0100, Stefan Hajnoczi wrote: > > > On Sat, Mar 19, 2016 at 08:31:24PM +, Richard W.M. Jones wrote: > > > > Is there

Re: [Qemu-devel] tcg: reworking tb_invalidated_flag

2016-03-31 Thread Richard Henderson
On 03/31/2016 05:42 AM, Sergey Fedorov wrote: > On 31/03/16 13:48, Alex Bennée wrote: >> I know we are system focused at the moment but does linux-user ever >> flush groups of TBs, say when mappings change? Or does this trigger a >> whole tb_flush? > > Yes, e.g. target_mmap() calls

Re: [Qemu-devel] [PATCH 2/2] target-mips: Implement IEEE 754-2008 functionality for R6 and MSA instructions

2016-03-31 Thread Richard Henderson
On 03/31/2016 04:55 AM, Aleksandar Markovic wrote: > Hi, Richard, what would you think about this approach: > > Functionality of . and .. > instructions is dependent on flags ABS2008 and NAN2008 in FCR31. There are > MIPS architectures (for

Re: [Qemu-devel] [FreeBSD] Host build i386 failing to build aarch64 targets

2016-03-31 Thread Sean Bruno
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 This seems to at least allow things to compile, qemu-system seems to be able to boot images on i386, but I may have missed something: diff --git a/cpus.c b/cpus.c index 23cf7aa..11f8bab 100644 - --- a/cpus.c +++ b/cpus.c @@ -338,15 +338,8 @@ static

Re: [Qemu-devel] [PATCH v1] net: fix missing include of qapi/error.h in netmap.c

2016-03-31 Thread Eric Blake
On 03/31/2016 07:08 AM, Daniel P. Berrange wrote: > The netmap.c file fails to build on FreeBSD with > > net/netmap.c:95:9: warning: implicit declaration of function > 'error_setg_errno' is invalid in C99 [-Wimplicit-function-declaration] > error_setg_errno(errp, errno, "Failed to nm_open()

Re: [Qemu-devel] [Qemu-stable] [PATCH] target-i386: do not read/write MSR_TSC_AUX from KVM if CPUID bit is not set

2016-03-31 Thread Paolo Bonzini
On 31/03/2016 17:38, Peter Lieven wrote: > > >> Am 31.03.2016 um 15:23 schrieb Paolo Bonzini : >> >> >> >>> On 31/03/2016 15:12, Peter Lieven wrote: > > KVM does not let you read or write this MSR if the corresponding CPUID > bit is not set. This in turn

Re: [Qemu-devel] [PATCH] target-i386: assert that KVM_GET/SET_MSRS can set all requested MSRs

2016-03-31 Thread Eduardo Habkost
On Thu, Mar 31, 2016 at 03:01:29PM +0200, Laszlo Ersek wrote: > On 03/30/16 22:59, Paolo Bonzini wrote: > > This would have caught the bug in the previous patch. > > Should this patch share a series with > ? Otherwise > they could be

Re: [Qemu-devel] [PULL 0/5] ipv4-only and ipv6-only support

2016-03-31 Thread Peter Maydell
On 31 March 2016 at 13:51, Samuel Thibault wrote: > Peter Maydell, on Thu 31 Mar 2016 13:47:28 +0100, wrote: >> On 31 March 2016 at 10:20, Samuel Thibault >> wrote: >> > Update version for v2.6.0-rc0 release (2016-03-30 19:25:40 +0100) >>

[Qemu-devel] [PATCH 1/2] char: fix broken EAGAIN retry on OS-X due to errno clobbering

2016-03-31 Thread Daniel P. Berrange
Some of the chardev I/O paths really want to write the complete data buffer even though the channel is in non-blocking mode. To achieve this they look for EAGAIN and g_usleep() for 100ms. Unfortunately the code is set to check errno == EAGAIN a second time, after the g_usleep() call has completed.

Re: [Qemu-devel] tcg: reworking tb_invalidated_flag

2016-03-31 Thread Sergey Fedorov
On 31/03/16 16:40, Paolo Bonzini wrote: > > On 31/03/2016 15:14, Sergey Fedorov wrote: >> On 30/03/16 21:13, Paolo Bonzini wrote: >>> On 30/03/2016 19:08, Sergey Fedorov wrote: The second approach is to make 'tb_invalidated_flag' per-CPU. This would be conceptually similar to what we

  1   2   3   >