Re: [Qemu-devel] [PATCH v2 for-2.7 4/8] block: Drop blk_new_with_bs()

Am 06.04.2016 um 19:57 hat Max Reitz geschrieben: > Its only caller is blk_new_open(), so we can just inline it there. > > Signed-off-by: Max Reitz Maybe mention that this isn't pure code motion, but that you switch to a bdrv_open() call with a NULL BDS. Either way:

Re: [Qemu-devel] [PATCH v2 for-2.7 7/8] block: Assert !bs->refcnt in bdrv_close()

Am 06.04.2016 um 19:57 hat Max Reitz geschrieben: > The only caller of bdrv_close() left is bdrv_delete(). We may as well > assert that, in a way (there are some things in bdrv_close() that make > more sense under that assumption, such as the call to > bdrv_release_all_dirty_bitmaps() which in

[Qemu-devel] [PATCH v6 6/6] bios: Add tests for the IPMI ACPI and SMBIOS entries

From: Corey Minyard Signed-off-by: Corey Minyard --- tests/acpi-test-data/pc/DSDT.ipmikcs | Bin 0 -> 5683 bytes tests/acpi-test-data/q35/DSDT.ipmibt | Bin 0 -> 8456 bytes tests/bios-tables-test.c | 58 ---

Re: [Qemu-devel] [PATCH] Improve documentation for TLS

On 04/07/2016 05:35 AM, Alex Bligh wrote: > * Call out TLS into a separate section > > * Add details of the TLS protocol itself > > * Emphasise that actual TLS session initiation (i.e. the TLS handshake) can > be initiated from either side (as required by the TLS standard I believe > and as

Re: [Qemu-devel] [PULL 0/4] slirp: deliver received TCP RSTs to the guest

On 7 April 2016 at 12:04, Samuel Thibault wrote: > The following changes since commit 7acbff99c6c285b3070bf0e768d56f511e2bf346: > > Update version for v2.6.0-rc1 release (2016-04-05 21:53:18 +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH v2 for-2.7 1/8] block: Drop useless bdrv_new() call

On Wed 06 Apr 2016 07:57:07 PM CEST, Max Reitz wrote: > bdrv_append_temp_snapshot() uses bdrv_new() to create an empty BDS > before invoking bdrv_open() on that BDS. This is probably a relict from > when it used to do some modifications on that empty BDS, but now that is > unnecessary, so we can

Re: [Qemu-devel] [PATCH v2 for-2.7 5/8] block: Drop bdrv_new_root()

Am 06.04.2016 um 19:57 hat Max Reitz geschrieben: > By now it has become just a wrapper around bdrv_new() and it has only a > single user. Use bdrv_new() there instead and drop this function. > > Signed-off-by: Max Reitz > Reviewed-by: Alberto Garcia The

[Qemu-devel] [PATCH v2] net: stellaris_enet: check packet length against receive buffer

From: Prasad J Pandit When receiving packets over Stellaris ethernet controller, it uses receive buffer of size 2048 bytes. In case the controller accepts large(MTU) packets, it could lead to memory corruption. Add check to avoid it. Reported by: Oleksandr Bazhaniuk

Re: [Qemu-devel] [PATCH] xen: piix reuse pci generic class init function

On 04/06/2016 11:48 PM, Michael S. Tsirkin wrote: > On Wed, Apr 06, 2016 at 04:56:12PM -0700, Stefano Stabellini wrote: >> On Sun, 3 Apr 2016, Michael S. Tsirkin wrote: >>> piix3_ide_xen_class_init is identical to piix3_ide_class_init >>> except it's buggy as it does not set exit and does not

[Qemu-devel] [PATCH v6 5/6] acpi: Add IPMI table entries

From: Corey Minyard Use the new ACPI table construction tools to create an ACPI entry for IPMI. This adds a function called from build_dsdt to add an DSDT entry for IPMI if IPMI is compiled in and has registered firmware. It also adds a dummy function if IPMI is not

Re: [Qemu-devel] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

On 07/04/2016 17:35, Pavel Borzenkov wrote: > > On 05/04/2016 06:05, Kevin Wolf wrote: > > > The options I can think of is adding a request field "max number of > > > descriptors" or a flag "only single descriptor" (with the assumption > > > that clients always want one or unlimited), but maybe

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

On Tue, 15 Mar 2016 00:02:48 +0800 Jevon Qiao wrote: > Ceph as a promising unified distributed storage system is widely used in the > world of OpenStack. OpenStack users deploying Ceph for block (Cinder) and > object (S3/Swift) are unsurprisingly looking at Manila and CephFS

Re: [Qemu-devel] [PATCH] Improve documentation for TLS

Eric, (this crossed with v2) On 7 Apr 2016, at 16:35, Eric Blake wrote: > On 04/07/2016 06:36 AM, Alex Bligh wrote: >> >> On 7 Apr 2016, at 13:13, Alex Bligh wrote: >> >>> I guess it's worth documenting >>> this, though I thought it was obvious. >> >>

Re: [Qemu-devel] [PATCH] Improve documentation for TLS

On 7 Apr 2016, at 15:31, Eric Blake wrote: >> +### TLS versions Certificates, authentication and authorisation > > s/versions/versions,/ ? ok >> + >> +NBD implementations supporting TLS MUST support TLS version >> +1.2, and MAY support other (earlier or later) versions of

Re: [Qemu-devel] [RFC] [tcg] Idea on refactoring target code generation loop (gen_intermediate_code)

On 07/04/2016 16:49, Peter Maydell wrote: > > QOM to C++ classes > I suspect if you looked at this you'd find that the QOM semantics > for various things don't map onto C++ (ie that we have more runtime > flexibility than C++ does). True, but you don't have to use it. :) If your code is

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.6] crypto: Avoid memory leak on failure

Max Reitz writes: > On 01.04.2016 17:57, Eric Blake wrote: >> Commit 7836857 introduced a memory leak due to invalid use of >> Error vs. visit_type_end(). If visiting the intermediate >> members fails, we clear the error and unconditionally use >> visit_end_struct() on the

[Qemu-devel] [PATCHv2] Improve documentation for TLS

* Call out TLS into a separate section * Add details of the TLS protocol itself * Emphasise that actual TLS session initiation (i.e. the TLS handshake) can be initiated from either side (as required by the TLS standard I believe and as actually works in practice) * Clarify what is a

[Qemu-devel] [RFC 0/4] target-ppc: handle KVM timebase migration

This RFC series follows on from discussions in the "Migrating decrementer" thread relating to handling migration of the timebase and decrementer registers for both TCG and KVM. The aim is to provide a consistent virtual clock when migrating PPC machines TCG-TCG (already handled) and KVM-KVM with

[Qemu-devel] [PATCH v2] fw_cfg: RFQDN rules, documentation

This requires that all -fw_cfg command line users use names of the form opt/RFQDN/: such names are compatible with QEMU 2.4 and 2.5 as well as future QEMU versions. As ability to insert fw_cfg entries in QEMU root is useful for firmware development, add a special prefix: unsupported/root/ that

Re: [Qemu-devel] [PATCH] net: mipsnet: check packet length against buffer

P J P writes: > From: Prasad J Pandit > > When receiving packets over MIPSnet network device, it uses > receive buffer of size 1514 bytes. In case the controller > accepts large(MTU) packets, it could lead to memory corruption. > Add check to avoid

Re: [Qemu-devel] [RFC v2 1/9] virtio: fix stray tab character

Stefan Hajnoczi writes: > The patches fixes a single occurrence of a tab character that resulted "The patch fixes" or "Fix", or drop the sentence. > in mis-aligned indentation. Really? It comes out aligned in my editor. > Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [RFC 3/4] target-ppc: synchronise tb_offset with KVM host on machine start

Recalculate the tb_offset between the guest and host, applying it to all CPUs when (re)starting the virtual machine. This has the effect of providing a near-seamless virtual timebase for KVM guests that support KVM_REG_PPC_TB_OFFSET. Signed-off-by: Mark Cave-Ayland

Re: [Qemu-devel] Documentation about qemu config file

Valerio Pachera writes: > Hi, I'm interested about the option -writeconfig/-readconfig. > I'm looking for some documentation about the format of the file, the > syntax of all possible options and if there's a library that helps to > read and write this file from external

Re: [Qemu-devel] [PATCH] Improve documentation for TLS

On 04/07/2016 06:36 AM, Alex Bligh wrote: > > On 7 Apr 2016, at 13:13, Alex Bligh wrote: > >> I guess it's worth documenting >> this, though I thought it was obvious. > > The next version will have this section: > > ### Downgrade attacks > > A danger inherent in any scheme

Re: [Qemu-devel] [RFC] [tcg] Idea on refactoring target code generation loop (gen_intermediate_code)

On 3 April 2016 at 14:05, Lluís Vilanova wrote: > QOM to C++ classes I suspect if you looked at this you'd find that the QOM semantics for various things don't map onto C++ (ie that we have more runtime flexibility than C++ does). This is just vaguely remembered from

Re: [Qemu-devel] [PULL 48/48] iotests: Test qemu-img convert -S 0 behavior

On 29/03/2016 17:08, Kevin Wolf wrote: > From: Max Reitz > > Passing -S 0 to qemu-img convert should result in all source data being > copied to the output, even if that source data is known to be 0. The > output image should therefore have exactly the same size on disk as

[Qemu-devel] [PATCH for-2.6] vpc: fix return value check for blk_pwrite

bdrv_pwrite_sync used to return zero or negative error, while blk_pwrite returns the number of written bytes when successful. This caused VPC image creation to fail spectacularly: it wrote the first 512 bytes, and then exited immediately because of the non-zero answer from blk_pwrite. But the

[Qemu-devel] [RFC 1/4] target-ppc: introduce PPCMachineClass and PPCMachineState

Introduce PPCMachineClass in anticipation of making it the superclass for all PPC machines. Signed-off-by: Mark Cave-Ayland --- hw/ppc/ppc.c| 16 include/hw/ppc/ppc.h| 16 include/qemu/typedefs.h |2 ++ 3

[Qemu-devel] [RFC 2/4] target-ppc: derive all PPC machine classes to have PPCMachineClass as their superclass

Using a new DEFINE_PPC_MACHINE macro, make sure that all PPC machines now derive from the new PPCMachineClass. Signed-off-by: Mark Cave-Ayland --- hw/ppc/e500plat.c |7 +-- hw/ppc/mac_newworld.c | 17 +++-- hw/ppc/mac_oldworld.c |

[Qemu-devel] [RFC 4/4] target-ppc: hack to remove existing timebase migration code for testing

Signed-off-by: Mark Cave-Ayland --- hw/ppc/ppc.c | 45 +++-- 1 file changed, 7 insertions(+), 38 deletions(-) diff --git a/hw/ppc/ppc.c b/hw/ppc/ppc.c index 39e15b1..053e600 100644 --- a/hw/ppc/ppc.c +++ b/hw/ppc/ppc.c @@

Re: [Qemu-devel] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

On Tue, Apr 05, 2016 at 03:43:08PM +0200, Paolo Bonzini wrote: > > > On 05/04/2016 06:05, Kevin Wolf wrote: > > The options I can think of is adding a request field "max number of > > descriptors" or a flag "only single descriptor" (with the assumption > > that clients always want one or

Re: [Qemu-devel] [Qemu-ppc] [PULL 1/3] ppc: Rework POWER7 & POWER8 exception model

On 04/07/2016 12:45 PM, Laurent Vivier wrote: > > > On 07/04/2016 12:27, Cédric Le Goater wrote: >> Hello Laurent, >> >> On 04/07/2016 11:13 AM, Laurent Vivier wrote: >>> >>> >>> On 05/04/2016 04:17, David Gibson wrote: From: Cédric Le Goater From: Benjamin

[Qemu-devel] [PATCH 01/11] tci: Fix build regression

From: Stefan Weil Commit d38ea87ac54af64ef611de434d07c12dc0399216 cleaned the include statements which resulted in a wrong order of assert.h and the definition of NDEBUG in tci.c. Normally NDEBUG modifies the definition of the assert macro, but here this definition comes too

Re: [Qemu-devel] [PATCH] Improve documentation for TLS

On Thu, Apr 07, 2016 at 12:35:59PM +0100, Alex Bligh wrote: > * Call out TLS into a separate section > > * Add details of the TLS protocol itself > > * Emphasise that actual TLS session initiation (i.e. the TLS handshake) can > be initiated from either side (as required by the TLS standard I

Re: [Qemu-devel] [PATCH 1/2] net: stellaris_enet: check packet length against receive buffer

+-- On Thu, 7 Apr 2016, Peter Maydell wrote --+ | > n -= 31; | > s->np++; | | We should do this check before we increase s->np, because | if we're going to bail out then we won't be putting this | packet into the RX FIFO. Ah, right. | The datasheet for this chip says that we

Re: [Qemu-devel] [PATCH v2 for-2.7 6/8] block: Make bdrv_open() return a BDS

Am 06.04.2016 um 19:57 hat Max Reitz geschrieben: > There are no callers to bdrv_open() or bdrv_open_inherit() left that > pass a pointer to a non-NULL BDS pointer as the first argument of these > functions, so we can finally drop that parameter and just make them > return the new BDS. > >

Re: [Qemu-devel] [v2 0/2] add avx2 instruction optimization

* Michael S. Tsirkin (m...@redhat.com) wrote: > On Thu, Apr 07, 2016 at 12:09:52PM +0100, Dr. David Alan Gilbert wrote: > > * Eric Blake (ebl...@redhat.com) wrote: > > > On 11/12/2015 12:56 PM, Dr. David Alan Gilbert wrote: > > > > > > >> One thing I still can't understand, why the unit test in

Re: [Qemu-devel] [v2 0/2] add avx2 instruction optimization

On 07/04/2016 14:54, Michael S. Tsirkin wrote: > > char check_zero(char *p, int len) > { > char res = 0; > int i; > > for (i = 0; i < len; i++) { > res = res | p[i]; > } > > return res; > } > > > If you compile this function with --tree-vectorize and

Re: [Qemu-devel] [PATCH v6 0/6] Sort the fw_cfg file list, add IPMI BIOS table entries

On Thu, Apr 07, 2016 at 09:12:57AM -0500, miny...@acm.org wrote: > This patch set includes the fw_config file list sorting, which seems > to have kind of stalled. v5 is in my tree but I'll replace it with v6. > Changes from v5: > > Added a check to rom_[re]set_order_override() functions to see

Re: [Qemu-devel] [RFC] [tcg] Idea on refactoring target code generation loop (gen_intermediate_code)

Lluís Vilanova writes: > Markus Armbruster writes: > >> Peter Maydell writes: >> [...] >>> if we move away from C I'd rather >>> it to be a language that's nicer than C rather than one that's >>> uglier and larger and still retains all of C's

Re: [Qemu-devel] [PATCH v2 for-2.7 1/8] block: Drop useless bdrv_new() call

Am 06.04.2016 um 19:57 hat Max Reitz geschrieben: > bdrv_append_temp_snapshot() uses bdrv_new() to create an empty BDS > before invoking bdrv_open() on that BDS. This is probably a relict from > when it used to do some modifications on that empty BDS, but now that is > unnecessary, so we can just

Re: [Qemu-devel] [v2 0/2] add avx2 instruction optimization

On Thu, Apr 07, 2016 at 12:09:52PM +0100, Dr. David Alan Gilbert wrote: > * Eric Blake (ebl...@redhat.com) wrote: > > On 11/12/2015 12:56 PM, Dr. David Alan Gilbert wrote: > > > > >> One thing I still can't understand, why the unit test in host > > >> environment shows > > >> 'memcmp()' have

[Qemu-devel] [PATCH v6 3/6] smbios: Move table build tools into an include file.

From: Corey Minyard This will let things in other files (like IPMI) build SMBIOS tables. Signed-off-by: Corey Minyard --- hw/smbios/smbios.c | 70 --- hw/smbios/smbios_build.h | 77

[Qemu-devel] [PATCH v6 0/6] Sort the fw_cfg file list, add IPMI BIOS table entries

This patch set includes the fw_config file list sorting, which seems to have kind of stalled. Changes from v5: Added a check to rom_[re]set_order_override() functions to see if fw_cfg is set. This could cause a crash in certain circumstances. Regenerated the BIOS test tables for other changes.

Re: [Qemu-devel] [PATCH] Improve documentation for TLS

Daniel, On 7 Apr 2016, at 12:51, Daniel P. Berrange wrote: > IMHO, we should not permit what you call OPTIONALTLS or SELECTIVETLS, > because these open possibilities for a MITM to perform downgrade > attacks, where the MITM runs TLS to the real server, but runs no-TLS > to

Re: [Qemu-devel] [PATCH 0/4] Fix QEMU crash on vhost-user socket disconnect.

On Thu, Apr 07, 2016 at 11:09:48AM +, Ilya Maximets wrote: > > --- Original Message --- > > Sender : Michael S. Tsirkin > > Date : Apr 07, 2016 10:01 (GMT+03:00) > > Title : Re: Re: [PATCH 0/4] Fix QEMU crash on vhost-user socket disconnect. > > > > On Wed, Apr 06,

[Qemu-devel] [PATCH] pc-bios/s390-ccw: Use correct strip when cross-compiling

From: Sergey Fedorov Signed-off-by: Sergey Fedorov Signed-off-by: Sergey Fedorov --- pc-bios/s390-ccw/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pc-bios/s390-ccw/Makefile

Re: [Qemu-devel] [PATCH v2 for-2.7 8/8] block: Drop bdrv_parent_cb_...() from bdrv_close()

Am 06.04.2016 um 19:57 hat Max Reitz geschrieben: > bdrv_close() now asserts that the BDS's refcount is 0, therefore it > cannot have any parents and the bdrv_parent_cb_change_media() call is a > no-op. > > Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [PATCH] Improve documentation for TLS

On Thu, Apr 07, 2016 at 01:13:10PM +0100, Alex Bligh wrote: > Daniel, > > On 7 Apr 2016, at 12:51, Daniel P. Berrange wrote: > > > IMHO, we should not permit what you call OPTIONALTLS or SELECTIVETLS, > > because these open possibilities for a MITM to perform downgrade > >

[Qemu-devel] [PATCH] nbd: do not hang nbd_wr_syncv if outside a coroutine and no available data

Until commit 1c778ef7 ("nbd: convert to using I/O channels for actual socket I/O", 2016-02-16), nbd_wr_sync returned -EAGAIN this scenario. nbd_reply_ready required these semantics because it has two conflicting requirements: 1) if a reply can be received on the socket, nbd_reply_ready needs to

Re: [Qemu-devel] [RFC PATCH v2 2/3] utils: Add cpuinfo helper to fetch /proc/cpuinfo

On 7 April 2016 at 11:56, Vijay Kilari wrote: > On Thu, Apr 7, 2016 at 3:41 PM, Peter Maydell > wrote: >> On 7 April 2016 at 10:58, wrote: >>> From: Vijaya Kumar K >>> >>> utils

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.6 2/2] block/gluster: prevent data loss after i/o error

+Raghavendra G who implemented this option in write-behind, to this upstream patch review discussion Pranith On 04/06/2016 06:50 PM, Kevin Wolf wrote: Am 06.04.2016 um 15:10 hat Jeff Cody geschrieben: On Wed, Apr 06, 2016 at 01:51:59PM +0200, Kevin Wolf wrote: Am 06.04.2016 um 13:41 hat

Re: [Qemu-devel] [PATCH v2] net: stellaris_enet: check packet length against receive buffer

On 7 April 2016 at 13:35, P J P wrote: > From: Prasad J Pandit > > When receiving packets over Stellaris ethernet controller, it > uses receive buffer of size 2048 bytes. In case the controller > accepts large(MTU) packets, it could lead to memory

Re: [Qemu-devel] [PATCH] Improve documentation for TLS

Daniel, >> Could you describe how a downgrade attack might occur? It's >> always open to the client to refuse to access an export (or >> the server as a whole) unless TLS is negotiated, as I make >> clear here (see last phrase). > > Right, so that's OK if the client is implementing FORCEDTLS.

Re: [Qemu-devel] [PATCH] Improve documentation for TLS

On 04/07/2016 05:51 AM, Daniel P. Berrange wrote: >> + >> +There are four modes of operation for a server. The >> +server MUST support one of these modes. >> + >> +* The server operates entirely without TLS ('NOTLS'); OR >> + >> +* The server makes TLS available (for all exports) and >> + it is

[Qemu-devel] [PATCH] Improve documentation for TLS

* Call out TLS into a separate section * Add details of the TLS protocol itself * Emphasise that actual TLS session initiation (i.e. the TLS handshake) can be initiated from either side (as required by the TLS standard I believe and as actually works in practice) * Clarify what is a

[Qemu-devel] Implementing 9p for Windows host

Good day, I'm using qemu on a Windows host. One thing I stumbled over was missing 9p support. I thought it was because of missing (x)attr, but Stefan Weil told me that 9p is supported only under Linux hosts. I searched a bit and got following questions: * are my following results right:

Re: [Qemu-devel] [PATCH v2 for-2.7 3/8] tests: Drop BDS from test-throttle.c

Am 06.04.2016 um 19:57 hat Max Reitz geschrieben: > Now that throttling has been moved to the BlockBackend level, we do not > need to create a BDS along with the BB in the I/O throttling test. > > Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [PATCH] Improve documentation for TLS

On 7 Apr 2016, at 13:13, Alex Bligh wrote: > I guess it's worth documenting > this, though I thought it was obvious. The next version will have this section: ### Downgrade attacks A danger inherent in any scheme relying on the negotiation of whether TLS should be employed

Re: [Qemu-devel] [PATCH] nbd: do not hang nbd_wr_syncv if outside a coroutine and no available data

On Thu, Apr 07, 2016 at 01:44:55PM +0200, Paolo Bonzini wrote: > Until commit 1c778ef7 ("nbd: convert to using I/O channels for actual > socket I/O", 2016-02-16), nbd_wr_sync returned -EAGAIN this scenario. > nbd_reply_ready required these semantics because it has two conflicting > requirements: >

Re: [Qemu-devel] [PATCH 1/2] qga: fix fd leak with guest-exec i/o channels

On 4/7/2016 2:53 AM, Michael Roth wrote: Quoting Denis V. Lunev (2016-04-06 00:43:30) From: Yuriy Pudgorodskiy Signed-off-by: Yuriy Pudgorodskiy Signed-off-by: Denis V. Lunev CC: Michael Roth ---

[Qemu-devel] [PATCH v6 1/6] Sort the fw_cfg file list

From: Gerd Hoffmann Entries are inserted in filename order instead of being appended to the end in case sorting is enabled. This will avoid any future issues of moving the file creation around, it doesn't matter what order they are created now, the will always be in filename

[Qemu-devel] [PATCH v6 2/6] pc: Postpone SMBIOS table installation to post machine init

From: Corey Minyard This is the same place that the ACPI SSDT table gets added, so that devices can add themselves to the SMBIOS table. Signed-off-by: Corey Minyard --- hw/i386/pc.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-)

[Qemu-devel] [PATCH v6 4/6] ipmi: Add SMBIOS table entry

From: Corey Minyard Add an IPMI table entry to the SMBIOS. Signed-off-by: Corey Minyard Acked-by: Michael S. Tsirkin --- default-configs/i386-softmmu.mak | 1 + default-configs/x86_64-softmmu.mak | 1 + hw/smbios/Makefile.objs

Re: [Qemu-devel] [PATCH 1/2] qga: fix fd leak with guest-exec i/o channels

Quoting Yuriy Pudgorodskiy (2016-04-07 06:22:13) > On 4/7/2016 2:53 AM, Michael Roth wrote: > > Quoting Denis V. Lunev (2016-04-06 00:43:30) > >> From: Yuriy Pudgorodskiy > >> > >> Signed-off-by: Yuriy Pudgorodskiy > >> Signed-off-by: Denis V. Lunev

Re: [Qemu-devel] [PATCH for 2.6 0/2] qga: guest exec bugfixes

Quoting Denis V. Lunev (2016-04-06 00:43:29) > Signed-off-by: Yuriy Pudgorodskiy > Signed-off-by: Denis V. Lunev > CC: Michael Roth > Thanks, applied to qga tree: https://github.com/mdroth/qemu/commits/qga Can confirm it

Re: [Qemu-devel] Questions about nbd with QIOChannel

On 07/04/2016 13:04, Changlong Xie wrote: > Hi all > > Recently during test COLO, i found sometimes the client goes to hung on > Primary side. First i thought it maybe a COLO revelant issue, but after > ton of tests i doubt that this maybe a NBD issue (athough i'm not sure). > So i'd like to

Re: [Qemu-devel] [PATCH v2 for-2.7 2/8] block: Let bdrv_open_inherit() return the snapshot

Am 06.04.2016 um 19:57 hat Max Reitz geschrieben: > If bdrv_open_inherit() creates a snapshot BDS and *pbs is NULL, that > snapshot BDS should be returned instead of the BDS under it. > > To this end, bdrv_append_temp_snapshot() now returns the snapshot BDS > instead of just appending it on top

[Qemu-devel] [PATCH v2 02/13] compiler.h: add QEMU_ALIGNED() to enforce struct alignment

Signed-off-by: Emilio G. Cota --- include/qemu/compiler.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h index 8f1cc7b..1978ddc 100644 --- a/include/qemu/compiler.h +++ b/include/qemu/compiler.h @@ -41,6 +41,8 @@ # define

[Qemu-devel] [PATCH v2 08/13] qemu-thread: optimize spin_lock for uncontended locks

This way we can acquire the lock with xchg+test, instead of test+xchg+test. Most spinlocks should be uncontended so this should result in a ne performance gain. Before: 4ad957: eb 09 jmp4ad962 4ad959: 0f 1f 80 00 00 00 00nopl 0x0(%rax)

Re: [Qemu-devel] [PATCHv3] Improve documentation for TLS

On 04/07/2016 12:32 PM, Alex Bligh wrote: > * Call out TLS into a separate section > > * Add details of the TLS protocol itself > > * Emphasise that actual TLS session initiation (i.e. the TLS handshake) can > be initiated from either side (as required by the TLS standard I believe > and as

Re: [Qemu-devel] [PULL 01/15] ps2kbd: default to scancode_set 2, as with KBD_CMD_RESET

On 7 April 2016 at 17:50, Paolo Bonzini wrote: > From: Hervé Poussineau > > This line has been added in commit ef74679a810fe6858f625b9d52b68cc3fc61eb3d > with > other initializations. However, scancode set 0 doesn't exist (only 1, 2, 3). > This works

[Qemu-devel] [PATCH v2 07/13] qemu-thread: call cpu_relax() while spinning

Signed-off-by: Emilio G. Cota --- include/qemu/thread.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/qemu/thread.h b/include/qemu/thread.h index 1aa843b..599965e 100644 --- a/include/qemu/thread.h +++ b/include/qemu/thread.h @@ -2,6 +2,7 @@

Re: [Qemu-devel] [PULL 09/15] nbd: Don't kill server when client requests unknown option

On 04/07/2016 10:50 AM, Paolo Bonzini wrote: > From: Eric Blake > > nbd-server.c currently fails to handle unsupported options properly. > If during option haggling the client sends an unknown request, the > server kills the connection instead of letting the client try to >

[Qemu-devel] [PATCH for-2.7 1/1] block/gluster: add support for selecting debug logging level

This adds commandline support for the logging level of the gluster protocol driver, output to stdout. The option is 'debug', e.g.: -drive filename=gluster://192.168.15.180/gv2/test.qcow2,debug=9 Debug levels are 0-9, with 9 being the most verbose, and 0 representing no debugging output. The

Re: [Qemu-devel] [PATCH 01/11] tci: Fix build regression

Am 07.04.2016 um 21:16 schrieb Stefan Weil: > Am 07.04.2016 um 20:15 schrieb Richard Henderson: >> On 04/07/2016 08:53 AM, Sergey Fedorov wrote: >>> +/* Enable TCI assertions only when debugging TCG (and without NDEBUG >>> defined). >>> + * Without assertions, the interpreter runs much faster. */

[Qemu-devel] [PATCHv5] Improve documentation for TLS

* Call out TLS into a separate section * Add details of the TLS protocol itself * Emphasise that actual TLS session initiation (i.e. the TLS handshake) can be initiated from either side (as required by the TLS standard I believe and as actually works in practice) * Clarify what is a

Re: [Qemu-devel] [PATCH] tb: consistently use uint32_t for tb->flags

On 04/07/2016 10:19 AM, Emilio G. Cota wrote: We are inconsistent with the type of tb->flags: usage varies loosely between int and uint64_t. Settle to uint32_t everywhere, which is superior to both: at least one target (aarch64) uses the most significant bit in the u32, and uint64_t is wasteful.

[Qemu-devel] [PATCH v2 03/13] seqlock: remove optional mutex

This option is unused; besides, it bloats the struct when not needed. Let's just let writers define their own locks elsewhere. Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota --- cpus.c | 2 +- include/qemu/seqlock.h | 10

Re: [Qemu-devel] [PATCH for-2.6] nbd: Don't kill server on client that doesn't request TLS

On 7 Apr 2016, at 21:29, Eric Blake wrote: > Upstream NBD is documenting that servers MAY choose to operate > in a conditional mode, where it is up to the client whether to > use TLS. For qemu's case, we want to always be in FORCEDTLS > mode, because of the risk of

Re: [Qemu-devel] [PATCHv3] Improve documentation for TLS

Eric, > Qemu's initial implementation of TLS in the client is binary (you either > want TLS or plaintext; there's no way to connect to a server and then > decide whether to upgrade to TLS - a plaintext client will never use TLS > of an OPTIONALTLS server). In TLS mode, the client always sends >

Re: [Qemu-devel] [PATCH] tb: consistently use uint32_t for tb->flags

On Thu, Apr 07, 2016 at 13:19:22 -0400, Emilio G. Cota wrote: > We are inconsistent with the type of tb->flags: usage varies loosely > between int and uint64_t. Settle to uint32_t everywhere, which is > superior to both: at least one target (aarch64) uses the most significant > bit in the u32, and

[Qemu-devel] [PATCH v2 00/10] tb hash improvements

See v1 for context: https://lists.gnu.org/archive/html/qemu-devel/2016-04/msg00587.html All patches in v2 are checkpatch-clean, except 05 (checkpatch should be ignored for this one) and 06, which I took unmodified (later patches fix those warnings while doing other things, anyway). Note that

[Qemu-devel] [PULL v2 00/15] Misc changes for QEMU 2.6.0-rc2

The following changes since commit 7acbff99c6c285b3070bf0e768d56f511e2bf346: Update version for v2.6.0-rc1 release (2016-04-05 21:53:18 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to

Re: [Qemu-devel] [PATCHv4] Improve documentation for TLS

On 7 Apr 2016, at 21:35, Eric Blake wrote: > grammar tweak: > s/ and either /, / sigh. fixed. Remembered to add your Reviewed-by: tag too. -- Alex Bligh signature.asc Description: Message signed with OpenPGP using GPGMail

Re: [Qemu-devel] [PATCH] tb: consistently use uint32_t for tb->flags

On Thu, Apr 07, 2016 at 01:19:22PM -0400, Emilio G. Cota wrote: > We are inconsistent with the type of tb->flags: usage varies loosely > between int and uint64_t. Settle to uint32_t everywhere, which is > superior to both: at least one target (aarch64) uses the most significant > bit in the u32,

[Qemu-devel] [PULL for-2.6] target-xtensa fix

Hi Peter, please pull the following fix for target-xtensa. The following changes since commit a648c137383d84bc4f95696e5293978d9541a26e: Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20160309-1' into staging (2016-03-10 02:51:14 +) are available in the git repository at:

[Qemu-devel] [PATCH 0/2] target-mips: Initiate IEEE 754-2008 support for Mips

From: Aleksandar Markovic V2 - Relevant CPU initialization code changes revisited for all platforms. - In connection with .. and . Mips instructions handling, decision on whether pre-nan2008 or

[Qemu-devel] [PATCH 1/2] softfloat: Implement run-time-configurable meaning of signaling NaN bit

From: Aleksandar Markovic This patch modifies SoftFloat library so that it can be configured at run-time in relation to the meaning of signaling NaN bit, while, at the same time, strictly preserving its behavior on all existing platforms. Background: In

[Qemu-devel] [PATCH v4 2/8] block: make bdrv_start_throttled_reqs return void

The return value is unused and I am not sure why it would be useful. Reviewed-by: Fam Zheng Signed-off-by: Paolo Bonzini --- block/io.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/block/io.c b/block/io.c index

[Qemu-devel] [PATCH v4 4/8] block: extract bdrv_drain_poll/bdrv_co_yield_to_drain from bdrv_drain/bdrv_co_drain

Do not call bdrv_drain_recurse twice in bdrv_co_drain. A small tweak to the logic in Fam's patch, which is harmless since no one implements bdrv_drain anyway. But better get it right. Signed-off-by: Paolo Bonzini --- v4: new block/io.c | 35

[Qemu-devel] [PULL 15/15] target-i386: check for PKU even for non-writable pages

Xiao Guangrong ran kvm-unit-tests on an actual machine with PKU and found that it fails: test pte.p pte.user pde.p pde.user pde.a pde.pse pkru.wd pkey=1 user write efer.nx cr4.pke: FAIL: error code 27 expected 7 Dump mapping: address: 0x1234 --L4: 2ebe007 --L3: 2ebf007 --L2:

[Qemu-devel] [PULL 05/15] nbd: Avoid bitrot in TRACE() usage

From: Eric Blake The compiler is smart enough to optimize out 'if (0)', but won't type-check our printfs if they are hidden behind #if. Signed-off-by: Eric Blake Message-Id: <1459913704-19949-3-git-send-email-ebl...@redhat.com> Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH 04/11] tcg/ppc: Make direct jump patching thread-safe

From: Sergey Fedorov Ensure direct jump patching in PPC is atomic by: * limiting translation buffer size in 32-bit mode to be addressable by Branch I-form instruction; * using atomic_read()/atomic_set() for code patching. Signed-off-by: Sergey Fedorov

Re: [Qemu-devel] [PATCH for-2.6 2/2] block/gluster: prevent data loss after i/o error

On Wed, Apr 06, 2016 at 01:02:16PM +0200, Kevin Wolf wrote: > [ Adding some CCs ] > > Am 06.04.2016 um 05:29 hat Jeff Cody geschrieben: > > Upon receiving an I/O error after an fsync, by default gluster will > > dump its cache. However, QEMU will retry the fsync, which is especially > > useful

[Qemu-devel] [PATCH v4 6/8] block: plug whole tree at once, introduce bdrv_io_unplugged_begin/end

Extract the handling of io_plug "depth" from linux-aio.c and let the main bdrv_drain loop do nothing but wait on I/O. Like the two newly introduced functions, bdrv_io_plug and bdrv_io_unplug now operate on all children. The visit order is now symmetrical between plug and unplug, making it

Re: [Qemu-devel] [PATCH v2 0/2] Convert pxb initfn to Error

On Thu, Apr 07, 2016 at 06:39:10PM +0200, Markus Armbruster wrote: > Marcel Apfelbaum writes: > > > On 03/23/2016 01:56 PM, Markus Armbruster wrote: > >> Wei Jiangang writes: > >> > >>> v1 -> v2: > >>> > >>> - Extract a separate bugfix patch > >>> -

[Qemu-devel] [PULL 10/15] nbd: do not hang nbd_wr_syncv if outside a coroutine and no available data

Until commit 1c778ef7 ("nbd: convert to using I/O channels for actual socket I/O", 2016-02-16), nbd_wr_sync returned -EAGAIN this scenario. nbd_reply_ready required these semantics because it has two conflicting requirements: 1) if a reply can be received on the socket, nbd_reply_ready needs to

[Qemu-devel] [PULL 09/15] nbd: Don't kill server when client requests unknown option

From: Eric Blake nbd-server.c currently fails to handle unsupported options properly. If during option haggling the client sends an unknown request, the server kills the connection instead of letting the client try to fall back to something older. This is precisely what

[Qemu-devel] [PATCH 03/11] tci: Make direct jump patching thread-safe

From: Sergey Fedorov Ensure direct jump patching in TCI is atomic by: * naturally aligning a location of direct jump address; * using atomic_read()/atomic_set() to load/store the address. Signed-off-by: Sergey Fedorov Signed-off-by: Sergey Fedorov

  1   2   3   >