[PULL 11/16] virtiofsd: Add attr_flags to fuse_entry_param

2020-10-26 Thread Dr. David Alan Gilbert (git)
From: Max Reitz fuse_entry_param is converted to fuse_attr on the line (by fill_entry()), so it should have a member that mirrors fuse_attr.flags. fill_entry() should then copy this fuse_entry_param.attr_flags to fuse_attr.flags. Signed-off-by: Max Reitz Message-Id:

Re: [PATCH 13/15] sh4: remove bios_name

2020-10-26 Thread Philippe Mathieu-Daudé
On 10/26/20 3:30 PM, Paolo Bonzini wrote: Cc: Yoshinori Sato Signed-off-by: Paolo Bonzini --- hw/sh4/shix.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 12/15] s390: remove bios_name

2020-10-26 Thread Thomas Huth
On 26/10/2020 15.30, Paolo Bonzini wrote: > Cc: Thomas Huth > Signed-off-by: Paolo Bonzini > --- > hw/s390x/ipl.c | 8 ++-- > hw/s390x/s390-virtio-ccw.c | 3 ++- > 2 files changed, 4 insertions(+), 7 deletions(-) > > diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c > index

Re: [PATCH v6 0/6] RISC-V Pointer Masking implementation

2020-10-26 Thread Richard Henderson
On 10/23/20 5:25 PM, Alistair Francis wrote: > On Thu, Oct 22, 2020 at 1:04 AM Alexey Baturo wrote: >> >> Hi, >> >> Added missing sign-off on the first patch. >> >> Thanks >> >> Alexey Baturo (5): >> [RISCV_PM] Add J-extension into RISC-V >> [RISCV_PM] Support CSRs required for RISC-V PM

[PULL 16/32] vfio: Make vfio-pci device migration capable

2020-10-26 Thread Alex Williamson
From: Kirti Wankhede If the device is not a failover primary device, call vfio_migration_probe() and vfio_migration_finalize() to enable migration support for those devices that support it respectively to tear it down again. Removed migration blocker from VFIO PCI device specific structure and

[PULL 00/32] VFIO updates 2020-10-26 (for QEMU 5.2 soft-freeze)

2020-10-26 Thread Alex Williamson
The following changes since commit a5fac424c76d6401ecde4ecb7d846e656d0d6e89: Merge remote-tracking branch 'remotes/stefanha-gitlab/tags/block-pull-request' into staging (2020-10-26 10:33:59 +) are available in the Git repository at: git://github.com/awilliam/qemu-vfio.git

[PULL 06/32] vfio: Add migration state change notifier

2020-10-26 Thread Alex Williamson
From: Kirti Wankhede Added migration state change notifier to get notification on migration state change. These states are translated to VFIO device state and conveyed to vendor driver. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia Reviewed-by: Dr. David Alan Gilbert Reviewed-by:

[PATCH 1/2] acpi/crs: Prevent bad ranges for host bridges

2020-10-26 Thread Ben Widawsky
Prevent _CRS resources being quietly chopped off and instead throw an assertion. _CRS is used by host bridges to declare regions of io and/or memory that they consume. On some (all?) platforms the host bridge doesn't have PCI header space and so they need some way to convey the information.

[PULL 08/32] vfio: Add save state functions to SaveVMHandlers

2020-10-26 Thread Alex Williamson
From: Kirti Wankhede Added .save_live_pending, .save_live_iterate and .save_live_complete_precopy functions. These functions handles pre-copy and stop-and-copy phase. In _SAVING|_RUNNING device state or pre-copy phase: - read pending_bytes. If pending_bytes > 0, go through below steps. - read

[PULL 30/32] s390x/pci: get zPCI function info from host

2020-10-26 Thread Alex Williamson
From: Matthew Rosato We use the capability chains of the VFIO_DEVICE_GET_INFO ioctl to retrieve the CLP information that the kernel exports. To be compatible with previous kernel versions we fall back on previous predefined values, same as the emulation values, when the ioctl is found to not

[PATCH v2 01/11] [DO-NOT-MERGE] docs: replace single backtick (`) with double-backtick (``)

2020-10-26 Thread John Snow
The single backtick in ReST is the "default role". Currently, Sphinx's default role is called "content". Sphinx suggests you can use the "Any" role instead to turn any single-backtick enclosed item into a cross-reference. Before we do that, though, we'll need to turn all existing usages of the

[PULL 14/32] vfio: Dirty page tracking when vIOMMU is enabled

2020-10-26 Thread Alex Williamson
From: Kirti Wankhede When vIOMMU is enabled, register MAP notifier from log_sync when all devices in container are in stop and copy phase of migration. Call replay and get dirty pages from notifier callback. Suggested-by: Alex Williamson Signed-off-by: Kirti Wankhede Reviewed-by: Yan Zhao

[PATCH v2 05/11] qapi/introspect.py: add preliminary type hint annotations

2020-10-26 Thread John Snow
The typing of _make_tree and friends is a bit involved, but it can be done with some stubbed out types and a bit of elbow grease. The forthcoming patches attempt to make some simplifications, but having the type hints in advance may aid in review of subsequent patches. Some notes on the abstract

[PULL 11/32] vfio: Get migration capability flags for container

2020-10-26 Thread Alex Williamson
From: Kirti Wankhede Added helper functions to get IOMMU info capability chain. Added function to get migration capability information from that capability chain for IOMMU container. Similar change was proposed earlier: https://lists.gnu.org/archive/html/qemu-devel/2018-05/msg03759.html

[PATCH v2 03/11] [DO-NOT-MERGE] docs: enable sphinx-autodoc for scripts/qapi

2020-10-26 Thread John Snow
This is just POC to prove that the docstrings, where they are written, are correct to some minimum standard. It is included here for reviewing/testing convenience. Signed-off-by: John Snow --- docs/conf.py | 3 ++- docs/devel/index.rst | 1 +

[PATCH 1/1] acpi: Implement ACPI ERST support for guests

2020-10-26 Thread Eric DeVolder
This changeset introduces support for the ACPI Error Record Serialization Table, ERST. ERST is defined in [1], and the error records are defined according to [2]. This changeset generates the ACPI ERST table, which OSPM follows to program the associated ERST device. The ERST device occupies 8KiB

Re: [PULL 00/17] Build system changes and misc fixes for QEMU 5.2 soft freeze

2020-10-26 Thread Yonggang Luo
On Tue, Oct 27, 2020 at 4:58 AM Paolo Bonzini wrote: > > > > Il lun 26 ott 2020, 19:59 罗勇刚(Yonggang Luo) ha scritto: >> >> This pull request confused me, the windows msys2 build time slow down from 40min to more than one hour. > > > Probably just the cache being rebuilt. Cirrus CI times seem to

Re: [PATCH] riscv: Add semihosting support [v8]

2020-10-26 Thread Keith Packard
Richard Henderson writes: > This is no different to EXCP_DEBUG, really, which is also internal to qemu but > user-visible in the same way. Just adjust the logging in > riscv_cpu_do_interrupt. I think that's already handled by the early return in riscv_cpu_do_interrupt after handling the

[PATCH 2/4] semihosting: Change common-semi API to be architecture-independent

2020-10-26 Thread Keith Packard via
The public API is now defined in hw/semihosting/common-semi.h. do_common_semihosting takes CPUState * instead of CPUARMState *. All internal functions have been renamed common_semi_ instead of arm_semi_ or arm_. Aside from the API change, there are no functional changes in this patch.

[PATCH v2 07/16] qapi/expr.py: Add casts in a few select cases

2020-10-26 Thread John Snow
Casts are instructions to the type checker only, they aren't "safe" and should probably be avoided in general. In this case, when we perform type checking on a nested structure, the type of each field does not "stick". We don't need to assert that something is a str if we've already checked that

[PATCH v2 11/16] qapi/expr.py: enable pylint checks

2020-10-26 Thread John Snow
Signed-off-by: John Snow Tested-by: Eduardo Habkost Reviewed-by: Eduardo Habkost Reviewed-by: Cleber Rosa Tested-by: Cleber Rosa --- scripts/qapi/pylintrc | 1 - 1 file changed, 1 deletion(-) diff --git a/scripts/qapi/pylintrc b/scripts/qapi/pylintrc index b9e077a1642d..fb0386d529ac 100644

Re: [PATCH 1/2] hw/core/ptimer: Support ptimer being disabled by timer callback

2020-10-26 Thread Philippe Mathieu-Daudé
On 10/15/20 5:18 PM, Peter Maydell wrote: In ptimer_reload(), we call the callback function provided by the timer device that is using the ptimer. This callback might disable the ptimer. The code mostly handles this correctly, except that we'll still print the warning about "Timer with delta

[PULL 4/7] hw/arm/aspeed: Add the 3 front LEDs drived by the PCA9552 #1

2020-10-26 Thread Philippe Mathieu-Daudé
The Witherspoon has 3 LEDs connected to a PCA9552. Add them. The names and reset values are taken from: https://github.com/open-power/witherspoon-xml/blob/master/witherspoon.xml Example booting obmc-phosphor-image: $ qemu-system-arm -M witherspoon-bmc -trace led_change_intensity

[PULL 6/8] linux-user: remove _sysctl

2020-10-26 Thread Laurent Vivier
It has been removed from linux since 61a47c1ad3a4 ("sysctl: Remove the sysctl system call") It's a good news because it was not really supported by qemu. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson Message-Id: <20200930003033.554124-5-laur...@vivier.eu> Signed-off-by:

Re: [PATCH V2 04/14] rx/: fix some comment spelling errors

2020-10-26 Thread Philippe Mathieu-Daudé
On 10/9/20 8:44 AM, zhaolichang wrote: I found that there are many spelling errors in the comments of qemu/target/rx. I used spellcheck to check the spelling errors and found some errors in the folder. Signed-off-by: zhaolichang Reviewed-by: David Edmondson Reviewed-by: Philippe

Re: [PULL 0/5] SD/MMC patches for 2020-10-26

2020-10-26 Thread Peter Maydell
t; > are available in the Git repository at: > > https://gitlab.com/philmd/qemu.git tags/sd-next-20201026 > > for you to fetch changes up to 89c6700fe7eed9195f10055751edbc6d5e7ab940: > > hw/sd/sdcard: Zero out function selection fields before being p

runaway avocado

2020-10-26 Thread Peter Maydell
So, I somehow ended up with this process still running on my local machine after a (probably failed) 'make check-acceptance': petmay01 13710 99.7 3.7 2313448 1235780 pts/16 Sl 16:10 378:00 ./qemu-system-aarch64 -display none -vga none -chardev

[PULL 5/8] target/sh4: Update coding style to make checkpatch.pl happy

2020-10-26 Thread Philippe Mathieu-Daudé
Avoid checkpatch.pl warnings in the next commit. Signed-off-by: Philippe Mathieu-Daudé --- target/sh4/op_helper.c | 8 +--- target/sh4/translate.c | 8 +--- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/target/sh4/op_helper.c b/target/sh4/op_helper.c index

[PULL 2/8] hw/timer/sh_timer: Coding style clean-up

2020-10-26 Thread Philippe Mathieu-Daudé
From: Thomas Huth Replace TAB characters with spaces, put code after case-statement on separate lines and add some curly braces in related lines to keep checkpatch.pl happy. Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id:

[PULL 7/8] target/rx: Fix some comment spelling errors

2020-10-26 Thread Philippe Mathieu-Daudé
From: Lichang Zhao There are many spelling errors in the comments of target/rx. Use spellcheck to check the spelling errors, then fix them. Signed-off-by: zhaolichang Reviewed-by: David Edmondson Reviewed-by: Philippe Mathieu-Daude Message-Id: <20201009064449.2336-5-zhaolich...@huawei.com>

[PULL 14/16] virtiofsd: Announce sub-mount points

2020-10-26 Thread Dr. David Alan Gilbert (git)
From: Max Reitz Whenever we encounter a directory with an st_dev that differs from that of its parent, we set the FUSE_ATTR_SUBMOUNT flag so the guest can create a submount for it. Make this behavior optional, so submounts are only announced to the guest with the announce_submounts option.

[PULL 13/16] virtiofsd: Store every lo_inode's parent_dev

2020-10-26 Thread Dr. David Alan Gilbert (git)
From: Max Reitz We want to detect mount points in the shared tree. We report them to the guest by setting the FUSE_ATTR_SUBMOUNT flag in fuse_attr.flags, but because the FUSE client will create a submount for every directory that has this flag set, we must do this only for the actual mount

[PULL 06/16] tools/virtiofsd: xattr name mappings: Map server xattr names

2020-10-26 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Map xattr names coming from the server, i.e. the host filesystem; currently this is only from listxattr. Signed-off-by: Dr. David Alan Gilbert Message-Id: <20201023165812.36028-4-dgilb...@redhat.com> Reviewed-by: Stefan Hajnoczi Signed-off-by: Dr. David Alan

[PATCH v2] rx: move BIOS load from MCU to board

2020-10-26 Thread Paolo Bonzini
The ROM loader state is global and not part of the MCU, and the BIOS is in machine->firmware. So just like the kernel case, load it in the board. Due to the ordering between CPU reset and ROM reset, the ROM has to be registered before the CPU is realized, otherwise the reset vector is loaded

[PULL 0/4] Acceptance testing patches for 2020-10-26

2020-10-26 Thread Philippe Mathieu-Daudé
The following changes since commit a46e72710566eea0f90f9c673a0f02da0064acce: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20201026' into stag= ing (2020-10-26 14:50:03 +) are available in the Git repository at: https://gitlab.com/philmd/qemu.git tags/acceptance-testing

Re: [PULL 00/17] Build system changes and misc fixes for QEMU 5.2 soft freeze

2020-10-26 Thread Yonggang Luo
This pull request confused me, the windows msys2 build time slow down from 40min to more than one hour. On Tue, Oct 27, 2020 at 1:54 AM Peter Maydell wrote: > > On Mon, 26 Oct 2020 at 14:04, Paolo Bonzini wrote: > > > > The following changes since commit

[PATCH RESEND 2/4] tcg: implement mirror mapped JIT for Linux

2020-10-26 Thread Joelle van Dyne
When configured with --enable-debug-tcg on Linux, we enable JIT mirror map which separates the JIT allocation into a RX-only address and a RW-only address. The backing is a memfd_create() object. This allows us to catch bugs where we unintentionally write to the JIT region. However, the main use

[PATCH RESEND 0/4] Mirror map JIT memory for TCG

2020-10-26 Thread Joelle van Dyne
To aid in debugging TCG, we enable a "mirror map" feature that, when enabled, will use memfd_create() to create two mappings of the same memory for RW and RX. The feature is only built when targeting system emulation on Linux and configured with --enable-debug-tcg. It can be disabled with the

Re: [PATCH 2/30] io: Fix Lesser GPL version number

2020-10-26 Thread Laurent Vivier
Le 19/10/2020 à 12:41, Daniel P. Berrangé a écrit : > On Wed, Oct 14, 2020 at 01:40:33PM +, Chetan Pant wrote: >> There is no "version 2" of the "Lesser" General Public License. >> It is either "GPL version 2.0" or "Lesser GPL version 2.1". >> This patch replaces all occurrences of "Lesser GPL

Re: [PATCH] cpus: Drop declaration of cpu_remove()

2020-10-26 Thread Laurent Vivier
Le 14/10/2020 à 15:40, Greg Kurz a écrit : > cpu_remove() got superseded by cpu_remove_sync() in commit dbadee4ff4a0, > but its prototype wasn't removed. We could possibly keep the shorter > cpu_remove() naming but it seems better to highligth that this blocks > until the CPU thread is joined. >

[PULL 20/32] s390x/pci: Move header files to include/hw/s390x

2020-10-26 Thread Alex Williamson
From: Matthew Rosato Seems a more appropriate location for them. Signed-off-by: Matthew Rosato Reviewed-by: Cornelia Huck Signed-off-by: Alex Williamson --- MAINTAINERS |1 hw/s390x/s390-pci-bus.c |4 hw/s390x/s390-pci-bus.h | 372

[PULL 29/32] vfio: Add routine for finding VFIO_DEVICE_GET_INFO capabilities

2020-10-26 Thread Alex Williamson
From: Matthew Rosato Now that VFIO_DEVICE_GET_INFO supports capability chains, add a helper function to find specific capabilities in the chain. Signed-off-by: Matthew Rosato Reviewed-by: Cornelia Huck Signed-off-by: Alex Williamson --- hw/vfio/common.c | 10 ++

[PULL 03/32] vfio: Add save and load functions for VFIO PCI devices

2020-10-26 Thread Alex Williamson
From: Kirti Wankhede Added functions to save and restore PCI device specific data, specifically config space of PCI device. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia Signed-off-by: Alex Williamson --- hw/vfio/pci.c | 51 +

[PULL 22/32] vfio: Find DMA available capability

2020-10-26 Thread Alex Williamson
From: Matthew Rosato The underlying host may be limiting the number of outstanding DMA requests for type 1 IOMMU. Add helper functions to check for the DMA available capability and retrieve the current number of DMA mappings allowed. Signed-off-by: Matthew Rosato Reviewed-by: Cornelia Huck

How about using a bot to guard the pull request can be apply? like rust compiler does.

2020-10-26 Thread Yonggang Luo
Peter can @bots try to apply pull request, if pull request apply and all ci tests passed, then the bot automatically merge the pull request and push to the mirrors. We even doesn't need gitlab or other things, only need the bot to monitor the instruction from Peter. -- 此致 礼 罗勇刚 Yours

[PULL 32/32] vfio: fix incorrect print type

2020-10-26 Thread Alex Williamson
From: Zhengui li The type of input variable is unsigned int while the printer type is int. So fix incorrect print type. Signed-off-by: Zhengui li Signed-off-by: Alex Williamson --- hw/vfio/common.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/vfio/common.c

Re: [PATCH v2 17/19] util/vfio-helpers: Introduce qemu_vfio_pci_msix_set_irq()

2020-10-26 Thread Auger Eric
Hi Philippe, On 10/26/20 11:55 AM, Philippe Mathieu-Daudé wrote: > Introduce qemu_vfio_pci_msix_set_irq() to set the event > notifier of a specific MSIX IRQ. All other registered IRQs > are left unmodified. > > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by:

Re: [PATCH 0/2] armv7m_systick: Rewrite to use ptimers

2020-10-26 Thread Peter Maydell
Ping for review ? thanks -- PMM On Thu, 15 Oct 2020 at 16:18, Peter Maydell wrote: > > This patch series rewrites our implementation of the armv7m systick > timer to use ptimers. > > The armv7m systick timer is a 24-bit decrementing, wrap-on-zero, > clear-on-write counter. Our current

Re: [PATCH] riscv: Add semihosting support [v8]

2020-10-26 Thread Keith Packard
Richard Henderson writes: > On 10/23/20 2:49 PM, Keith Packard via wrote: >> static bool trans_ebreak(DisasContext *ctx, arg_ebreak *a) >> { >> -generate_exception(ctx, RISCV_EXCP_BREAKPOINT); >> +uint32_t pre= opcode_at(>base, ctx->base.pc_next - 4); >> +uint32_t ebreak =

[PATCH v2 08/16] qapi/expr.py: add type hint annotations

2020-10-26 Thread John Snow
Annotations do not change runtime behavior. This commit *only* adds annotations. Signed-off-by: John Snow Reviewed-by: Eduardo Habkost Reviewed-by: Cleber Rosa --- scripts/qapi/expr.py | 71 --- scripts/qapi/mypy.ini | 5 --- 2 files changed, 46

[PATCH v2 03/16] qapi/expr.py: constrain incoming expression types

2020-10-26 Thread John Snow
mypy does not know the types of values stored in Dicts that masquerade as objects. Help the type checker out by constraining the type. Signed-off-by: John Snow Reviewed-by: Eduardo Habkost Reviewed-by: Cleber Rosa --- scripts/qapi/expr.py | 25 ++--- 1 file changed, 22

Re: [PATCH 1/1] include/elf.h: Add EM_RX.

2020-10-26 Thread Philippe Mathieu-Daudé
On 8/14/20 3:14 PM, Yoshinori Sato wrote: RX's ELF machine not defined elf.h. Added it. Signed-off-by: Yoshinori Sato --- include/elf.h | 2 ++ 1 file changed, 2 insertions(+) Thanks, applied to renesas-next.

[PATCH RESEND 1/4] tcg: add const hints for code pointers

2020-10-26 Thread Joelle van Dyne
We will introduce mirror mapping for JIT segment with separate RX and RW access. Adding 'const' hints will make it easier to identify read-only accesses and allow us to easier catch bugs at compile time in the future. Signed-off-by: Joelle van Dyne --- include/tcg/tcg.h| 8

Re: [PATCH 07/15] m68k: remove bios_name

2020-10-26 Thread Laurent Vivier
Le 26/10/2020 à 15:30, Paolo Bonzini a écrit : > Cc: Laurent Vivier > Signed-off-by: Paolo Bonzini > --- > hw/m68k/mcf5208.c | 10 +- > hw/m68k/next-cube.c | 4 +--- > hw/m68k/q800.c | 4 +--- > 3 files changed, 7 insertions(+), 11 deletions(-) > > diff --git

[PULL 12/32] vfio: Add function to start and stop dirty pages tracking

2020-10-26 Thread Alex Williamson
From: Kirti Wankhede Call VFIO_IOMMU_DIRTY_PAGES ioctl to start and stop dirty pages tracking for VFIO devices. Signed-off-by: Kirti Wankhede Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Alex Williamson --- hw/vfio/migration.c | 36 1 file

Re: [PATCH] scripts/qmp: delete 'qmp' script

2020-10-26 Thread Laurent Vivier
Le 20/10/2020 à 07:44, Thomas Huth a écrit : > On 19/10/2020 23.04, John Snow wrote: >> This script has not seen a patch that was specifically for this script >> since it was moved to this location in 2013, and I doubt it is used. It >> uses "man qmp" for its help message, which does not exist. It

Re: [PATCH 1/30] cryptodev: Fix Lesser GPL version number

2020-10-26 Thread Laurent Vivier
Le 19/10/2020 à 16:49, Thomas Huth a écrit : > On 14/10/2020 15.37, Chetan Pant wrote: >> There is no "version 2" of the "Lesser" General Public License. >> It is either "GPL version 2.0" or "Lesser GPL version 2.1". >> This patch replaces all occurrences of "Lesser GPL version 2" with >> "Lesser

[PULL 26/32] s390x/pci: use a PCI Group structure

2020-10-26 Thread Alex Williamson
From: Pierre Morel We use a S390PCIGroup structure to hold the information related to a zPCI Function group. This allows us to be ready to support multiple groups and to retrieve the group information from the host. Signed-off-by: Pierre Morel Signed-off-by: Matthew Rosato Reviewed-by:

[PULL 13/32] vfio: Add vfio_listener_log_sync to mark dirty pages

2020-10-26 Thread Alex Williamson
From: Kirti Wankhede vfio_listener_log_sync gets list of dirty pages from container using VFIO_IOMMU_GET_DIRTY_BITMAP ioctl and mark those pages dirty when all devices are stopped and saving state. Return early for the RAM block section of mapped MMIO region. Signed-off-by: Kirti Wankhede

[PULL 24/32] s390x/pci: Honor DMA limits set by vfio

2020-10-26 Thread Alex Williamson
From: Matthew Rosato When an s390 guest is using lazy unmapping, it can result in a very large number of oustanding DMA requests, far beyond the default limit configured for vfio. Let's track DMA usage similar to vfio in the host, and trigger the guest to flush their DMA mappings before vfio

[PATCH v2 04/11] qapi/introspect.py: add assertions and casts

2020-10-26 Thread John Snow
This is necessary to keep mypy passing in the next patch when we add preliminary type hints. It will be removed shortly. Signed-off-by: John Snow --- scripts/qapi/introspect.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/qapi/introspect.py

[PATCH v2 10/11] qapi/introspect.py: improve readability of _tree_to_qlit

2020-10-26 Thread John Snow
Subjective, but I find getting rid of the comprehensions helps. Also, divide the sections into scalar and non-scalar sections, and remove old-style string formatting. Signed-off-by: John Snow --- scripts/qapi/introspect.py | 37 + 1 file changed, 21

Re: [PATCH v2 16/19] util/vfio-helpers: Introduce qemu_vfio_pci_msix_init_irqs()

2020-10-26 Thread Auger Eric
Hi Philippe, On 10/26/20 11:55 AM, Philippe Mathieu-Daudé wrote: > qemu_vfio_pci_init_irq() allows us to initialize any type of IRQ, > but only one. Introduce qemu_vfio_pci_msix_init_irqs() which is > specific to MSIX IRQ type, and allow us to use multiple IRQs > (thus passing multiple eventfd

[PATCH v2 05/16] qapi/expr.py: move string check upwards in check_type

2020-10-26 Thread John Snow
It's a simple case, shimmy the early return upwards. Signed-off-by: John Snow Reviewed-by: Eduardo Habkost Reviewed-by: Cleber Rosa --- scripts/qapi/expr.py | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/qapi/expr.py b/scripts/qapi/expr.py index

[PATCH v2 00/16] qapi: static typing conversion, pt3

2020-10-26 Thread John Snow
based-on: <20201026194251.11075-1-js...@redhat.com> [PATCH v2 00/11] qapi: static typing conversion, pt2 Hi, this series adds static type hints to the QAPI module. This is part three, and it focuses on expr.py. Part 3: https://gitlab.com/jsnow/qemu/-/tree/python-qapi-cleanup-pt3

[PATCH v2 01/16] qapi/expr.py: Remove 'info' argument from nested check_if_str

2020-10-26 Thread John Snow
The function can just use the argument from the scope above. Otherwise, we get shadowed argument errors because the parameter name clashes with the name of a variable already in-scope. Signed-off-by: John Snow Reviewed-by: Eduardo Habkost Reviewed-by: Cleber Rosa --- scripts/qapi/expr.py | 6

[PATCH v2 04/16] qapi/expr.py: Add assertion for union type 'check_dict'

2020-10-26 Thread John Snow
mypy isn't fond of allowing you to check for bool membership in a collection of str elements. Guard this lookup for precisely when we were given a name. Signed-off-by: John Snow Reviewed-by: Eduardo Habkost Reviewed-by: Cleber Rosa --- scripts/qapi/expr.py | 4 +++- 1 file changed, 3

[PATCH v2 12/16] qapi/expr.py: Add docstrings

2020-10-26 Thread John Snow
Signed-off-by: John Snow Reviewed-by: Cleber Rosa --- scripts/qapi/expr.py | 167 ++- 1 file changed, 164 insertions(+), 3 deletions(-) diff --git a/scripts/qapi/expr.py b/scripts/qapi/expr.py index 99c5c2ff99b0..8ad82ca98864 100644 ---

[PATCH v2 10/16] qapi/expr.py: Remove single-letter variable

2020-10-26 Thread John Snow
Signed-off-by: John Snow Reviewed-by: Eduardo Habkost Reviewed-by: Cleber Rosa --- scripts/qapi/expr.py | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/scripts/qapi/expr.py b/scripts/qapi/expr.py index 4d4ee3daa002..99c5c2ff99b0 100644 ---

[PULL 7/8] linux-user: correct errno returned from accept4() syscall

2020-10-26 Thread Laurent Vivier
From: Matus Kysel accept4() returned wrong errno, that did not match current linux Signed-off-by: Matus Kysel Reviewed-by: Laurent Vivier Message-Id: <20200930151616.3588165-1-mky...@tachyum.com> Signed-off-by: Laurent Vivier --- linux-user/syscall.c | 6 +++--- 1 file changed, 3

[PULL 8/8] target/xtensa: enable all coprocessors for linux-user

2020-10-26 Thread Laurent Vivier
From: Max Filippov Linux userspace always sees coprocessors as enabled. CPENABLE register and coprocessor exceptions are used internally by the kernel to manage lazy coprocessor context switch. None of it is needed for linux-user. Always enable all coprocessors for user emulation.

[PULL 0/7] LED API patches for 2020-10-26

2020-10-26 Thread Philippe Mathieu-Daudé
-20201026 for you to fetch changes up to 06972067c48fc21a47445b5d706368f1129f216f: hw/arm/tosa: Replace fprintf() calls by LED devices (2020-10-26 13:44:58 +0= 100) API to model LED. CI jobs results: . https://cirrus-ci.com/build

Re: [PATCH v6 0/7] hw/misc: Add LED device

2020-10-26 Thread Philippe Mathieu-Daudé
On 10/16/20 5:29 PM, Philippe Mathieu-Daudé wrote: On 9/19/20 2:30 PM, Philippe Mathieu-Daudé wrote: On 9/12/20 3:40 PM, Philippe Mathieu-Daudé wrote: Hello, These patches are part of the GSoC unselected 'QEMU visualizer' project. This series introduce a LED device that can be easily

[PULL 15/16] tests/acceptance/boot_linux: Accept SSH pubkey

2020-10-26 Thread Dr. David Alan Gilbert (git)
From: Max Reitz Let download_cloudinit() take an optional pubkey, which subclasses of BootLinux can pass through setUp(). Signed-off-by: Max Reitz Message-Id: <20200909184028.262297-8-mre...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: WIllian Rampazzo Reviewed-by: Stefan

Re: [PATCH v2 2/9] configure: cross-compiling without cross_prefix

2020-10-26 Thread Thomas Huth
On 26/10/2020 17.15, Paolo Bonzini wrote: > On 26/10/20 16:33, Joelle van Dyne wrote: >> Just to be clear, you're in favor of removing the >> --enable-cross-compile option? I can do that if others agree but I'm >> not sure what the downside of adding this extra option is? > > For me the downside

[PULL 4/4] docs/devel/testing.rst: Update outdated Avocado URLs

2020-10-26 Thread Philippe Mathieu-Daudé
Avocado documentation referred returns 404 error. Update the broken links. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cleber Rosa Message-Id: <20201010080741.2932406-1-phi...@redhat.com> --- docs/devel/testing.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v2] rx: move BIOS load from MCU to board

2020-10-26 Thread Philippe Mathieu-Daudé
On 10/26/20 8:05 PM, Paolo Bonzini wrote: The ROM loader state is global and not part of the MCU, and the BIOS is in machine->firmware. So just like the kernel case, load it in the board. Due to the ordering between CPU reset and ROM reset, the ROM has to be registered before the CPU is

[PULL 17/32] qapi: Add VFIO devices migration stats in Migration stats

2020-10-26 Thread Alex Williamson
From: Kirti Wankhede Added amount of bytes transferred to the VM at destination by all VFIO devices Signed-off-by: Kirti Wankhede Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Alex Williamson --- hw/vfio/common.c | 19 +++ hw/vfio/migration.c |

[PATCH v2 08/11] qapi/introspect.py: replace 'extra' dict with 'comment' argument

2020-10-26 Thread John Snow
This is only used to pass in a dictionary with a comment already set, so skip the runaround and just accept the comment. Signed-off-by: John Snow --- scripts/qapi/introspect.py | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/scripts/qapi/introspect.py

[PULL 15/32] vfio: Add ioctl to get dirty pages bitmap during dma unmap

2020-10-26 Thread Alex Williamson
From: Kirti Wankhede With vIOMMU, IO virtual address range can get unmapped while in pre-copy phase of migration. In that case, unmap ioctl should return pages pinned in that range and QEMU should find its correcponding guest physical addresses and report those dirty. Suggested-by: Alex

[PULL 25/32] s390x/pci: create a header dedicated to PCI CLP

2020-10-26 Thread Alex Williamson
From: Pierre Morel To have a clean separation between s390-pci-bus.h and s390-pci-inst.h headers we export the PCI CLP instructions in a dedicated header. Signed-off-by: Pierre Morel Signed-off-by: Matthew Rosato Reviewed-by: Cornelia Huck Signed-off-by: Alex Williamson ---

Re: [PATCH 0/2] armv7m_systick: Rewrite to use ptimers

2020-10-26 Thread Yonggang Luo
On Tue, Oct 27, 2020 at 4:44 AM Peter Maydell wrote: > > Ping for review ? > Maybe nobody can review this, anyway, is that possible add a test case for this? I found https://github.com/oxidecomputer/qemu-systick-bug are simple enough. > thanks > -- PMM > > On Thu, 15 Oct 2020 at 16:18, Peter

Re: [PATCH 0/1] acpi: Implement ACPI ERST support for guests

2020-10-26 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1603743573-9870-1-git-send-email-eric.devol...@oracle.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1603743573-9870-1-git-send-email-eric.devol...@oracle.com Subject: [PATCH

[PATCH 3/4] semihosting: Change internal common-semi interfaces to use CPUState *

2020-10-26 Thread Keith Packard via
This makes all of the internal interfaces architecture-independent and renames the internal functions to use the 'common_semi' prefix instead of 'arm' or 'arm_semi'. To do this, some new architecture-specific internal helper functions were created: static inline target_ulong

[PULL 4/8] linux-user: update mips/syscall-args-o32.c.inc to Linux 5.9-rc7

2020-10-26 Thread Laurent Vivier
Updated running scripts/update-mips-syscall-args.sh Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20200930003033.554124-3-laur...@vivier.eu> Signed-off-by: Laurent Vivier --- linux-user/mips/syscall-args-o32.c.inc | 4 1

[PULL 5/8] linux-user: update syscall.tbl to Linux 5.9-rc7

2020-10-26 Thread Laurent Vivier
Updated running scripts/update-syscalltbl.sh Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson Message-Id: <20200930003033.554124-4-laur...@vivier.eu> Signed-off-by: Laurent Vivier --- linux-user/alpha/syscall.tbl | 4 +- linux-user/arm/syscall.tbl| 4 +-

[PULL 5/7] hw/misc/mps2-fpgaio: Use the LED device

2020-10-26 Thread Philippe Mathieu-Daudé
Per the 'ARM MPS2 and MPS2+ FPGA Prototyping Boards Technical Reference Manual' (100112_0200_07_en): 2.1 Overview of the MPS2 and MPS2+ hardware The MPS2 and MPS2+ FPGA Prototyping Boards contain the following components and interfaces: * User switches and user LEDs:

[PULL 04/16] tools/virtiofsd: xattr name mappings: Add option

2020-10-26 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add an option to define mappings of xattr names so that the client and server filesystems see different views. This can be used to have different SELinux mappings as seen by the guest, to run the virtiofsd with less privileges (e.g. in a case where it can't set

[PULL 00/16] virtiofs queue

2020-10-26 Thread Dr. David Alan Gilbert (git)
.com/dagrh/qemu.git tags/pull-virtiofs-20201026 for you to fetch changes up to c93a656f7b6585d9b6f8639d1fbb74dd944be239: tests/acceptance: Add virtiofs_submounts.py (2020-10-26 18:35:32 +) virtiofsd pull 2020-10-26 Misono S

[PULL 09/16] linux/fuse.h: Pull in from Linux

2020-10-26 Thread Dr. David Alan Gilbert (git)
From: Max Reitz Update the linux/fuse.h standard header from the kernel development tree that implements FUSE submounts. This adds the fuse_attr.flags field, the FUSE_ATTR_FLAGS INIT flag, and the FUSE_ATTR_SUBMOUNT flag for fuse_attr.flags. Signed-off-by: Max Reitz Message-Id:

[PULL 3/4] tests/acceptance: Allow running Orange Pi test using cached artifacts

2020-10-26 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé Unfortunately the Armbian 19.11.3 image has been removed from the dl.armbian.com file server. Developers having the artifact cached can still run the test. Allow them to, until we find a proper solution to share binaries with the whole community. This avoids (when

[PATCH RESEND 3/4] tcg: use mirror map JIT in code generation

2020-10-26 Thread Joelle van Dyne
In TCG code generation, there are places where we need to mutate code in JIT memory. In the case of a mirror mapped implementation, we need to get the RW pointer to perform any writes. To ensure cache coherency, we flush the data cache in the RW mapping and then invalidate the instruction cache

[PULL 09/32] vfio: Add load state functions to SaveVMHandlers

2020-10-26 Thread Alex Williamson
From: Kirti Wankhede Sequence during _RESUMING device state: While data for this device is available, repeat below steps: a. read data_offset from where user application should write data. b. write data of data_size to migration region from data_offset. c. write data_size which indicates vendor

[PULL 28/32] s390x/pci: use a PCI Function structure

2020-10-26 Thread Alex Williamson
From: Pierre Morel We use a ClpRspQueryPci structure to hold the information related to a zPCI Function. This allows us to be ready to support different zPCI functions and to retrieve the zPCI function information from the host. Signed-off-by: Pierre Morel Signed-off-by: Matthew Rosato

[PULL 07/32] vfio: Register SaveVMHandlers for VFIO device

2020-10-26 Thread Alex Williamson
From: Kirti Wankhede Define flags to be used as delimiter in migration stream for VFIO devices. Added .save_setup and .save_cleanup functions. Map & unmap migration region from these functions at source during saving or pre-copy phase. Set VFIO device state depending on VM's state. During live

[PULL 27/32] s390x/pci: clean up s390 PCI groups

2020-10-26 Thread Alex Williamson
From: Matthew Rosato Add a step to remove all stashed PCI groups to avoid stale data between machine resets. Signed-off-by: Matthew Rosato Reviewed-by: Cornelia Huck Signed-off-by: Alex Williamson --- hw/s390x/s390-pci-bus.c | 12 1 file changed, 12 insertions(+) diff --git

Re: [PATCH 1/4] qdev: Fix two typos

2020-10-26 Thread Laurent Vivier
Le 24/10/2020 à 07:34, Thomas Huth a écrit : > On 19/10/2020 18.36, Maxim Levitsky wrote: >> Signed-off-by: Maxim Levitsky >> --- >> include/hw/qdev-core.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h >> index

[PULL 23/32] s390x/pci: Add routine to get the vfio dma available count

2020-10-26 Thread Alex Williamson
From: Matthew Rosato Create new files for separating out vfio-specific work for s390 pci. Add the first such routine, which issues VFIO_IOMMU_GET_INFO ioctl to collect the current dma available count. Signed-off-by: Matthew Rosato Reviewed-by: Cornelia Huck Signed-off-by: Alex Williamson ---

[PATCH v2 07/11] qapi/introspect.py: Unify return type of _make_tree()

2020-10-26 Thread John Snow
Returning two different types conditionally can be complicated to type. Let's always return a tuple for consistency. Prohibit the use of annotations with dict-values in this circumstance. It can be implemented later if and when the need for it arises. Signed-off-by: John Snow ---

Re: [PATCH v2 12/19] util/vfio-helpers: Let qemu_vfio_do_mapping() propagate Error

2020-10-26 Thread Auger Eric
Hi Philippe, On 10/26/20 11:54 AM, Philippe Mathieu-Daudé wrote: > Pass qemu_vfio_do_mapping() an Error* argument so it can propagate > any error to callers. Replace error_report() which only report > to the monitor by the more generic error_setg_errno(). > > Reviewed-by: Fam Zheng >

  1   2   3   4   5   6   7   >