Re: [PATCH 05/15] sphinx/qapidoc: Drop code to generate doc for simple union tag

2024-02-07 Thread Daniel P . Berrangé
On Mon, Feb 05, 2024 at 08:46:59AM +0100, Markus Armbruster wrote: > QAPISchemaGenRSTVisitor._nodes_for_members() has a special case to > auto-generate documentation for a union tag member of implicit (enum) > type that lacks documentation. > > This was useful for simple unions, where the tag

Re: [PATCH 07/13] hw/misc/mps2-scc: Make changes needed for AN536 FPGA image

2024-02-07 Thread Philippe Mathieu-Daudé
On 6/2/24 14:29, Peter Maydell wrote: The MPS2 SCC device is broadly the same for all FPGA images, but has minor differences in the behaviour of the CFG registers depending on the image. In many cases we don't really care about the functionality controlled by these registers and a

Re: [PATCH 08/13] hw/arm/mps3r: Initial skeleton for mps3-an536 board

2024-02-07 Thread Philippe Mathieu-Daudé
On 6/2/24 14:29, Peter Maydell wrote: The AN536 is another FPGA image for the MPS3 development board. Unlike the existing FPGA images we already model, this board uses a Cortex-R family CPU, and it does not use any equivalent to the M-profile "Subsystem for Embedded" SoC-equivalent that we model

Re: [PATCH trivial] qemu-nbd: mention --tls-hostname option in qemu-nbd --help

2024-02-07 Thread Daniel P . Berrangé
On Wed, Feb 07, 2024 at 10:32:31AM +0300, Michael Tokarev wrote: > This option was not documented. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1240 > Signed-off-by: Michael Tokarev > --- > qemu-nbd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/qemu-nbd.c

Re: Re: [PATCH] vdpa-dev: Fix initialisation order to restore VDUSE compatibility

2024-02-07 Thread Cindy Lu
Jason Wang 于2024年2月7日周三 11:17写道: > > On Tue, Feb 6, 2024 at 4:31 PM Stefano Garzarella wrote: > > > > On Tue, Feb 06, 2024 at 10:47:40AM +0800, Jason Wang wrote: > > >On Mon, Feb 5, 2024 at 6:51 PM Stefano Garzarella > > >wrote: > > >> > > >> On Fri, Feb 02, 2024 at 02:25:21PM +0100, Kevin

Re: [PATCH 02/15] docs/devel/qapi-code-gen: Tweak doc comment whitespace

2024-02-07 Thread Daniel P . Berrangé
On Mon, Feb 05, 2024 at 08:46:56AM +0100, Markus Armbruster wrote: > Missed in commit a937b6aa739 (qapi: Reformat doc comments to conform > to current conventions). > > Signed-off-by: Markus Armbruster > --- > docs/devel/qapi-code-gen.rst | 5 +++-- > 1 file changed, 3 insertions(+), 2

Re: [PATCH 03/15] qapi/block-core: Fix BlockLatencyHistogramInfo doc markup

2024-02-07 Thread Daniel P . Berrangé
On Mon, Feb 05, 2024 at 08:46:57AM +0100, Markus Armbruster wrote: > The description of @bins ends with a literal block: > > # @bins: list of io request counts corresponding to histogram > # intervals, one more element than @boundaries has. For the > # example above, @bins

Re: [PATCH 04/15] qapi: Indent tagged doc comment sections properly

2024-02-07 Thread Daniel P . Berrangé
On Mon, Feb 05, 2024 at 08:46:58AM +0100, Markus Armbruster wrote: > docs/devel/qapi-code-gen demands that the "second and subsequent lines > of sections other than "Example"/"Examples" should be indented". > Commit a937b6aa739q (qapi: Reformat doc comments to conform to current > conventions)

Re: [PATCH v2 1/4] hw/ppc/ppc4xx_pci: Remove unused "hw/ppc/ppc.h" header

2024-02-07 Thread Thomas Huth
On 07/02/2024 10.12, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: BALATON Zoltan Message-Id: <20231011132427.65001-2-phi...@linaro.org> --- hw/ppc/ppc440_pcix.c | 1 - hw/ppc/ppc4xx_pci.c | 1 - 2 files changed, 2 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 06/15] qapi: Require member documentation (with loophole)

2024-02-07 Thread Daniel P . Berrangé
On Mon, Feb 05, 2024 at 08:47:00AM +0100, Markus Armbruster wrote: > The QAPI generator forces you to document your stuff. Except for > command arguments, event data, and members of enum and object types: > these the generator silently "documents" as "Not documented". > > We can't require proper

Re: Re: Re: [PATCH] vdpa-dev: Fix initialisation order to restore VDUSE compatibility

2024-02-07 Thread Stefano Garzarella
On Wed, Feb 07, 2024 at 11:17:34AM +0800, Jason Wang wrote: On Tue, Feb 6, 2024 at 4:31 PM Stefano Garzarella wrote: On Tue, Feb 06, 2024 at 10:47:40AM +0800, Jason Wang wrote: >On Mon, Feb 5, 2024 at 6:51 PM Stefano Garzarella wrote: >> >> On Fri, Feb 02, 2024 at 02:25:21PM +0100, Kevin

[PATCH] vhost-vdpa: check vhost_vdpa_set_vring_ready() return value

2024-02-07 Thread Stefano Garzarella
vhost_vdpa_set_vring_ready() could already fail, but if Linux's patch [1] will be merged, it may fail with more chance if userspace does not activate virtqueues before DRIVER_OK when VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK is not negotiated. So better check its return value anyway. [1]

Re: [PATCH] vdpa-dev: Fix initialisation order to restore VDUSE compatibility

2024-02-07 Thread Kevin Wolf
Am 06.02.2024 um 17:44 hat Eugenio Perez Martin geschrieben: > On Mon, Feb 5, 2024 at 2:49 PM Kevin Wolf wrote: > > > > Am 05.02.2024 um 13:22 hat Eugenio Perez Martin geschrieben: > > > On Fri, Feb 2, 2024 at 2:25 PM Kevin Wolf wrote: > > > > > > > > VDUSE requires that virtqueues are first

RE: Regarding to the recent Intel IAA/DSA/QAT support on migration

2024-02-07 Thread Liu, Yuan1
Thank you very much for your reminder and the rapid updates to the multifd function. I will incorporate your suggestions into the next version (IAA Accelerated Live Migration solution). Regarding the QAT and DSA optimization, my colleagues and I have already started reviewing and testing them,

[PATCH v2 2/4] hw/ppc/ppc4xx_pci: Extract PCI host definitions to hw/pci-host/ppc4xx.h

2024-02-07 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: BALATON Zoltan Message-Id: <20231011132427.65001-3-phi...@linaro.org> --- MAINTAINERS | 1 + include/hw/pci-host/ppc4xx.h | 17 + include/hw/ppc/ppc4xx.h | 5 - hw/ppc/ppc440_bamboo.c | 1 +

[PATCH v2 3/4] hw/ppc/ppc4xx_pci: Move ppc4xx_pci.c to hw/pci-host/

2024-02-07 Thread Philippe Mathieu-Daudé
ppc4xx_pci.c is moved from the target specific ppc_ss[] meson source set to pci_ss[] which is common to all targets: the object is built once. Declare PPC4XX_PCI selector in pci-host/Kconfig. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + hw/{ppc =>

[PATCH v2] target/riscv: Update $ra with current $pc in trans_cm_jalt()

2024-02-07 Thread Jason Chien
The original implementation sets $pc to the address read from the jump vector table first and links $ra with the address of the next instruction after the updated $pc. After jumping to the updated $pc and executing the next ret instruction, the program jumps to $ra, which is in the same function

Re: [PATCH 07/15] qga/qapi-schema: Clean up documentation of guest-set-memory-blocks

2024-02-07 Thread Daniel P . Berrangé
On Mon, Feb 05, 2024 at 08:47:01AM +0100, Markus Armbruster wrote: > The command's doc comment describes the argument, but it's not marked > up as such. Easy enough to fix. > > Signed-off-by: Markus Armbruster > --- > qga/qapi-schema.json | 19 ++- > 1 file changed, 10

Re: [PATCH 08/15] qga/qapi-schema: Clean up documentation of guest-set-vcpus

2024-02-07 Thread Daniel P . Berrangé
On Mon, Feb 05, 2024 at 08:47:02AM +0100, Markus Armbruster wrote: > The command's doc comment describes the argument, but it's not marked > up as such. Easy enough to fix. > > Signed-off-by: Markus Armbruster > --- > qga/qapi-schema.json | 20 ++-- > 1 file changed, 10

Re: [PATCH 11/15] qapi/dump: Clean up documentation of DumpGuestMemoryCapability

2024-02-07 Thread Daniel P . Berrangé
On Mon, Feb 05, 2024 at 08:47:05AM +0100, Markus Armbruster wrote: > The type's doc comment describes its member, but it's not marked up as > such. Easy enough to fix. > > Signed-off-by: Markus Armbruster > --- > qapi/dump.json | 2 +- > qapi/pragma.json | 1 - > 2 files changed, 1

Re: [PATCH 12/15] qapi: Plug trivial documentation holes around former simple unions

2024-02-07 Thread Daniel P . Berrangé
On Mon, Feb 05, 2024 at 08:47:06AM +0100, Markus Armbruster wrote: > The conversion of simple to flat unions left the @data members > undocumented. Add documentation where it's trivial. Copy verbatim > from the wrapped type's description where possible. > > Leftovers: String (to be taken care

Re: [PATCH 06/13] hw/misc/mps2-scc: Factor out which-board conditionals

2024-02-07 Thread Philippe Mathieu-Daudé
On 6/2/24 14:29, Peter Maydell wrote: The MPS SCC device has a lot of different flavours for the various different MPS FPGA images, which look mostly similar but have differences in how particular registers are handled. Currently we deal with this with a lot of open-coded checks on

Re: [PATCH v2 2/4] hw/ppc/ppc4xx_pci: Extract PCI host definitions to hw/pci-host/ppc4xx.h

2024-02-07 Thread Thomas Huth
On 07/02/2024 10.12, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: BALATON Zoltan Message-Id: <20231011132427.65001-3-phi...@linaro.org> --- MAINTAINERS | 1 + include/hw/pci-host/ppc4xx.h | 17 + include/hw/ppc/ppc4xx.h

Re: [PATCH 15/15] qapi: Add missing union tag documentation

2024-02-07 Thread Daniel P . Berrangé
On Mon, Feb 05, 2024 at 08:47:09AM +0100, Markus Armbruster wrote: > Low-hanging fruit, and except for StatsFilter, the only members of > these unions lacking documentation. > > Signed-off-by: Markus Armbruster > --- > qapi/block-core.json | 12 > qapi/block-export.json | 2 ++ >

Re: Re: [PATCH 2/6] migration/multifd: Add zero pages and zero bytes counter to migration status interface.

2024-02-07 Thread Jiri Denemark
On Wed, Feb 07, 2024 at 12:37:15 +0800, Peter Xu wrote: > On Wed, Feb 07, 2024 at 12:13:10PM +0800, Peter Xu wrote: > > On Tue, Feb 06, 2024 at 11:19:04PM +, Hao Xiang wrote: > > > This change extends the MigrationStatus interface to track zero pages > > > and zero bytes counter. > > > > > >

Re: [PATCH 14/15] qapi: Move @String out of common.json to discourage reuse

2024-02-07 Thread Daniel P . Berrangé
On Mon, Feb 05, 2024 at 08:47:08AM +0100, Markus Armbruster wrote: > Use of String is problematic, because it results in awkward interface > documentation. The previous commit cleaned up one instance. > > Move String out of common.json next to its remaining users in net.json > to discourage

Re: Re: Re: [PATCH] vdpa-dev: Fix initialisation order to restore VDUSE compatibility

2024-02-07 Thread Stefano Garzarella
On Wed, Feb 07, 2024 at 04:05:29PM +0800, Cindy Lu wrote: Jason Wang 于2024年2月7日周三 11:17写道: On Tue, Feb 6, 2024 at 4:31 PM Stefano Garzarella wrote: > > On Tue, Feb 06, 2024 at 10:47:40AM +0800, Jason Wang wrote: > >On Mon, Feb 5, 2024 at 6:51 PM Stefano Garzarella wrote: > >> > >> On Fri,

Regarding to the recent Intel IAA/DSA/QAT support on migration

2024-02-07 Thread Peter Xu
Copy qemu-devel. On Wed, Feb 07, 2024 at 04:07:40PM +0800, Peter Xu wrote: > Hi, > > I'm sending this email just to leave a generic comment to the recent > migration efforts to enable these new Intel technologies. > > The relevant patchsets (latest version so far) we're discussing are: > >

Re: [PATCH 13/15] qapi: Improve documentation of file descriptor socket addresses

2024-02-07 Thread Daniel P . Berrangé
On Mon, Feb 05, 2024 at 08:47:07AM +0100, Markus Armbruster wrote: > SocketAddress branch @fd is documented in enum SocketAddressType, > unlike the other branches. That's because the branch's type is String > from common.json. > > Use a local copy of String, so we can put the documentation in

[PATCH v6 2/3] Add RISC-V IOPMP support

2024-02-07 Thread Ethan Chen via
Support specification Version 1.0.0-draft4 rapid-k model. The specification url: https://github.com/riscv-non-isa/iopmp-spec/blob/main/riscv_iopmp_specification.pdf The memory transaction from source devices connected to IOPMP will be checked by IOPMP rule. The method of connecting the source

Re: [PATCH 0/2] block: Allow concurrent BB context changes

2024-02-07 Thread Hanna Czenczek
On 06.02.24 17:53, Stefan Hajnoczi wrote: On Fri, Feb 02, 2024 at 03:47:53PM +0100, Hanna Czenczek wrote: Hi, Without the AioContext lock, a BB's context may kind of change at any time (unless it has a root node, and I/O requests are pending). That also means that its own context

[PATCH v6 0/3] Support RISC-V IOPMP

2024-02-07 Thread Ethan Chen via
This series implements IOPMP specification v1.0.0-draft4 rapid-k model and add IOPMP device to RISC-V virt machine. Patch 1 add config STREAM make other device can reuse /hw/core/stream.c, IOPMP implementation will use it. Patch 2 implement IOPMP deivce. Patch 3 add IOPMP device to RISC-V virt

[PATCH v6 1/3] hw/core: Add config stream

2024-02-07 Thread Ethan Chen via
Make other device can use /hw/core/stream.c by select this config. Reviewed-by: Alistair Francis Signed-off-by: Ethan Chen --- hw/Kconfig | 1 + hw/core/Kconfig | 3 +++ hw/core/meson.build | 2 +- 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/Kconfig

[PATCH v6 3/3] hw/riscv/virt: Add IOPMP support

2024-02-07 Thread Ethan Chen via
If a source device is connected to the IOPMP device, its memory transaction will be checked by the IOPMP rule. When using RISC-V virt machine option "iopmp=on", the generic PCIe host bridge connects to IOPMP. The PCI devices on the bridge will connect to IOPMP with default source id(SID) from PCI

Re: [PATCH 01/15] docs/devel/qapi-code-gen: Normalize version refs x.y.0 to just x.y

2024-02-07 Thread Daniel P . Berrangé
On Mon, Feb 05, 2024 at 08:46:55AM +0100, Markus Armbruster wrote: > Missed in commit 9bc6e893b72 (qapi: Normalize version references x.y.0 > to just x.y). > > Signed-off-by: Markus Armbruster > --- > docs/devel/qapi-code-gen.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH v2 1/4] hw/ppc/ppc4xx_pci: Remove unused "hw/ppc/ppc.h" header

2024-02-07 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: BALATON Zoltan Message-Id: <20231011132427.65001-2-phi...@linaro.org> --- hw/ppc/ppc440_pcix.c | 1 - hw/ppc/ppc4xx_pci.c | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/ppc/ppc440_pcix.c b/hw/ppc/ppc440_pcix.c index

[PATCH v2 0/4] hw/pci-host: Build ppc4xx_pci.c/ppc440_pcix.c once

2024-02-07 Thread Philippe Mathieu-Daudé
v2: - Squashed 2 patches (Zoltan) v1: - Move ppc4xx_pci.c/ppc440_pcix.c from hw/ppc/ to hw/pci-host/ - Build them once for all targets If it is convenient for PPC maintainers I can queue this via my misc-hw tree. Thanks, Phil. Philippe Mathieu-Daudé (4): hw/ppc/ppc4xx_pci: Remove unused

[PATCH v2 4/4] hw/ppc/ppc440_pcix: Move ppc440_pcix.c to hw/pci-host/

2024-02-07 Thread Philippe Mathieu-Daudé
ppc440_pcix.c is moved from the target specific ppc_ss[] meson source set to pci_ss[] which is common to all targets: the object is built once. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS| 2 +- hw/{ppc => pci-host}/ppc440_pcix.c | 0 hw/pci-host/Kconfig

Re: [PATCH v2 3/4] hw/ppc/ppc4xx_pci: Move ppc4xx_pci.c to hw/pci-host/

2024-02-07 Thread Thomas Huth
On 07/02/2024 10.12, Philippe Mathieu-Daudé wrote: ppc4xx_pci.c is moved from the target specific ppc_ss[] meson source set to pci_ss[] which is common to all targets: the object is built once. Declare PPC4XX_PCI selector in pci-host/Kconfig. Signed-off-by: Philippe Mathieu-Daudé ---

Re: [PATCH 09/15] qga/qapi-schema: Plug trivial documentation holes

2024-02-07 Thread Daniel P . Berrangé
On Mon, Feb 05, 2024 at 08:47:03AM +0100, Markus Armbruster wrote: > Add missing return member documentation of guest-get-disks, > guest-get-devices, guest-get-diskstats, and guest-get-cpustats. > > The NVMe SMART information returned by guest-getdisks remains > undocumented. Add a TODO there. >

Re: [PATCH 10/15] qapi/yank: Clean up documentaion of yank

2024-02-07 Thread Daniel P . Berrangé
On Mon, Feb 05, 2024 at 08:47:04AM +0100, Markus Armbruster wrote: > The command's doc comment describes the argument, but it's not marked > up as such. Easy enough to fix. > > Signed-off-by: Markus Armbruster > --- > qapi/pragma.json | 3 +-- > qapi/yank.json | 2 +- > 2 files changed, 2

Re: [PATCH v2 4/4] hw/ppc/ppc440_pcix: Move ppc440_pcix.c to hw/pci-host/

2024-02-07 Thread Thomas Huth
On 07/02/2024 10.12, Philippe Mathieu-Daudé wrote: ppc440_pcix.c is moved from the target specific ppc_ss[] meson source set to pci_ss[] which is common to all targets: the object is built once. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS| 2 +- hw/{ppc =>

Re: [PATCH v4 0/3] Fix MCE handling on AMD hosts

2024-02-07 Thread Joao Martins
On 12/09/2023 22:18, John Allen wrote: > In the event that a guest process attempts to access memory that has > been poisoned in response to a deferred uncorrected MCE, an AMD system > will currently generate a SIGBUS error which will result in the entire > guest being shutdown. Ideally, we only

[PATCH v4 3/3] tests/qtest: Add STM32L4x5 GPIO QTest testcase

2024-02-07 Thread Inès Varhol
The testcase contains : - `test_idr_reset_value()` : Checks the reset values of MODER, OTYPER, PUPDR, ODR and IDR. - `test_gpio_output_mode()` : Checks that writing a bit in register ODR results in the corresponding pin rising or lowering, if this pin is configured in output mode. -

[PATCH v4 0/3] Add device STM32L4x5 GPIO

2024-02-07 Thread Inès Varhol
This patch adds a new device STM32L4x5 GPIO device and is part of a series implementing the STM32L4x5 with a few peripherals. Changes from v3 : - replacing occurences of '16' with the correct macro `GPIO_NUM_PINS` - updating copyright year - rebasing on latest version of STM32L4x5 RCC Changes

[PATCH v4 1/3] hw/gpio: Implement STM32L4x5 GPIO

2024-02-07 Thread Inès Varhol
Features supported : - the 8 STM32L4x5 GPIOs are initialized with their reset values (except IDR, see below) - input mode : setting a pin in input mode "externally" (using input irqs) results in an out irq (transmitted to SYSCFG) - output mode : setting a bit in ODR sets the corresponding

[PATCH 00/14] migration: Improve error reporting

2024-02-07 Thread Cédric Le Goater
Hello, The motivation behind these changes is to improve error reporting to the upper management layer (libvirt) with a more detailed error, this to let it decide, depending on the reported error, whether to try migration again later. It would be useful in cases where migration fails due to lack

[RFC PATCH 14/14] migration: Fix return-path thread exit

2024-02-07 Thread Cédric Le Goater
In case of error, close_return_path_on_source() can perform a shutdown to exit the return-path thread. However, in migrate_fd_cleanup(), 'to_dst_file' is closed before calling close_return_path_on_source() and the shutdown fails, leaving the source and destination waiting for an event to occur.

[PATCH 03/14] memory: Add Error** argument to .log_global*() handlers

2024-02-07 Thread Cédric Le Goater
Modify memory_global_dirty_log_start() and memory_global_dirty_log_stop() to also take an Error** parameter and report the error in the callers. Aside from error reporting, there should be no functional changes. Cc: Stefano Stabellini Cc: Anthony Perard Cc: Paul Durrant Cc: Michael S. Tsirkin

[PATCH 09/14] vfio: Add Error** argument to .vfio_save_config() handler

2024-02-07 Thread Cédric Le Goater
Use vmstate_save_state_with_err() to improve error reporting in the callers. Signed-off-by: Cédric Le Goater --- include/hw/vfio/vfio-common.h | 2 +- hw/vfio/migration.c | 18 -- hw/vfio/pci.c | 5 +++-- 3 files changed, 16 insertions(+), 9

[PATCH 10/14] vfio: Also trace event failures in vfio_save_complete_precopy()

2024-02-07 Thread Cédric Le Goater
vfio_save_complete_precopy() currently returns before doing the trace event. Change that. Signed-off-by: Cédric Le Goater --- hw/vfio/migration.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c index

[PATCH 02/14] migration: Add Error** argument to .load_setup() handler

2024-02-07 Thread Cédric Le Goater
This will be useful to report errors at a higher level, mostly in VFIO today. Signed-off-by: Cédric Le Goater --- include/migration/register.h | 2 +- hw/vfio/migration.c | 2 +- migration/ram.c | 2 +- migration/savevm.c | 10 ++ 4 files changed, 9

Re: [PATCH v2 0/5] virtio-blk: iothread-vq-mapping cleanups

2024-02-07 Thread Kevin Wolf
Am 06.02.2024 um 20:06 hat Stefan Hajnoczi geschrieben: > v2: > - Add comment in Patch 3 explaining why bounds check assertion [Manos] > - Remove redundant nested if in Patch 1 [Hanna] > > Hanna reviewed the iothread-vq-mapping patches after they were applied to > qemu.git. This series consists

[PATCH 1/2] RISC-V: Add support for Ztso

2024-02-07 Thread Christoph Müllner
From: Palmer Dabbelt The Ztso extension is already ratified, this adds it as a CPU property and adds various fences throughout the port in order to allow TSO targets to function on weaker hosts. We need no fences for AMOs as they're already SC, the places we need barriers are described. These

[PATCH 0/2] RISC-V: Add Ztso extension

2024-02-07 Thread Christoph Müllner
The first patch of this series picks up an earlier v2 Ztso patch from Palmer, which can be found here: https://patchwork.kernel.org/project/qemu-devel/patch/20220917072635.11616-1-pal...@rivosinc.com/ This patch did not apply cleanly but the necessary changes were trivial. There was a request

Re: [PATCH v2 4/4] hw/ppc/ppc440_pcix: Move ppc440_pcix.c to hw/pci-host/

2024-02-07 Thread BALATON Zoltan
On Wed, 7 Feb 2024, Philippe Mathieu-Daudé wrote: ppc440_pcix.c is moved from the target specific ppc_ss[] meson source set to pci_ss[] which is common to all targets: the object is built once. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS| 2 +- hw/{ppc =>

Re: [PATCH v2 6/8] isa: extract FDC37M81X to a separate file

2024-02-07 Thread BALATON Zoltan
On Wed, 7 Feb 2024, Paolo Bonzini wrote: isa-superio.c currently defines a SuperIO chip that is not used by any other user of the faile. Extract the chip to a separate file. Typo: faile -> file? Regards, BALATON Zoltan Signed-off-by: Paolo Bonzini --- hw/isa/fdc37m81x-superio.c | 32

Re: [PATCH v3 0/6] migration/multifd: Fix channel creation vs. cleanup races

2024-02-07 Thread Fabiano Rosas
Peter Xu writes: > On Tue, Feb 06, 2024 at 06:51:12PM -0300, Fabiano Rosas wrote: >> Based-on: 20240202102857.110210-1-pet...@redhat.com >> [PATCH v2 00/23] migration/multifd: Refactor ->send_prepare() and cleanups >> https://lore.kernel.org/r/20240202102857.110210-1-pet...@redhat.com >> >> Hi,

[PATCH v2 8/8] mips: do not list individual devices from configs/

2024-02-07 Thread Paolo Bonzini
Add new "select" and "imply" directives if needed. The resulting config-devices.mak files are the same as before. Signed-off-by: Paolo Bonzini --- configs/devices/mips-softmmu/common.mak | 28 +++- configs/devices/mips64el-softmmu/default.mak | 3 ---

[PATCH v2 7/8] mips: allow compiling out CONFIG_MIPS_ITU

2024-02-07 Thread Paolo Bonzini
itc_reconfigure() is referenced from TCG, provide a stub if needed. This makes it possible to build a QEMU binary that only includes boards without a CPS device (only Malta and Boston create one). Signed-off-by: Paolo Bonzini --- hw/mips/mips_itu-stub.c | 26 ++

[PATCH v2 0/8] mips: do not list individual devices from configs/

2024-02-07 Thread Paolo Bonzini
Back when Kconfig was introduced, the individual dependencies for MIPS boards were never added to hw/mips/Kconfig. Do it now. To simplify the task, include a couple cleanups to the SuperIO chip configuration symbols, as well as a change that makes USB device creation available even when building

[PATCH v2 5/8] isa: specify instance_size in isa_superio_type_info

2024-02-07 Thread Paolo Bonzini
Right now all subclasses of TYPE_ISA_SUPERIO have to specify an instance_size, because the ISASuperIODevice struct adds fields to ISADevice but the type does not include the increased instance size. Failure to do so results in an access past the bounds of struct ISADevice as soon as

[PATCH v2 1/8] usb: inline device creation functions

2024-02-07 Thread Paolo Bonzini
Allow boards to use the device creation functions even if USB itself is not available; of course the functions will fail inexorably, but this can be okay if the calls are conditional on the existence of some USB host controller device. This is for example the case for hw/mips/loongson3_virt.c.

[PATCH v2 2/8] isa: clean up Kconfig selections for ISA_SUPERIO

2024-02-07 Thread Paolo Bonzini
All users of ISA_SUPERIO include a floppy disk controller, serial port and parallel port via the automatic creation mechanism of isa-superio.c. Select the symbol and remove it from the dependents. Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- hw/isa/Kconfig | 13

Re: [PATCH v2 2/4] hw/ppc/ppc4xx_pci: Extract PCI host definitions to hw/pci-host/ppc4xx.h

2024-02-07 Thread BALATON Zoltan
On Wed, 7 Feb 2024, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: BALATON Zoltan Message-Id: <20231011132427.65001-3-phi...@linaro.org> --- MAINTAINERS | 1 + include/hw/pci-host/ppc4xx.h | 17 + include/hw/ppc/ppc4xx.h |

Re: [PATCH v4 11/21] parallels: Add dirty bitmaps saving

2024-02-07 Thread Alexander Ivanov
On 1/18/24 14:27, Denis V. Lunev wrote: On 12/28/23 11:12, Alexander Ivanov wrote: Now dirty bitmaps can be loaded but there is no their saving. Add code for dirty bitmap storage. Signed-off-by: Alexander Ivanov ---   block/parallels-ext.c | 168 ++  

Re: [PATCH] iotests: give tempdir an identifying name

2024-02-07 Thread Kevin Wolf
Am 05.02.2024 um 16:51 hat Daniel P. Berrangé geschrieben: > If something goes wrong causing the iotests not to cleanup their > temporary directory, it is useful if the dir had an identifying > name to show what is to blame. > > Signed-off-by: Daniel P. Berrangé Thanks, applied to the block

[PATCH 11/14] vfio: Extend vfio_set_migration_error() with Error* argument

2024-02-07 Thread Cédric Le Goater
vfio_set_migration_error() sets the 'return' error on the migration stream if a migration is in progress. To improve error reporting, add a new Error* argument to also set the Error object on the migration stream. Signed-off-by: Cédric Le Goater --- hw/vfio/common.c | 50

[PATCH 05/14] vfio: Add Error** argument to .set_dirty_page_tracking() handler

2024-02-07 Thread Cédric Le Goater
We will use the Error object to improve error reporting in the .log_global*() handlers of VFIO. Signed-off-by: Cédric Le Goater --- include/hw/vfio/vfio-container-base.h | 4 ++-- hw/vfio/common.c | 4 ++-- hw/vfio/container-base.c | 4 ++-- hw/vfio/container.c

[PATCH 07/14] vfio: Add Error** argument to vfio_devices_dma_logging_stop()

2024-02-07 Thread Cédric Le Goater
This improves error reporting in the log_global_stop() VFIO handler. Signed-off-by: Cédric Le Goater --- hw/vfio/common.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index

[PATCH 04/14] migration: Modify ram_init_bitmaps() to report dirty tracking errors

2024-02-07 Thread Cédric Le Goater
The .save_setup() handler has now an Error** argument that we can use to propagate errors reported by the .log_global_start() handler. Do that for the RAM. qemu_savevm_state_setup() will store the error under the migration stream for later detection in the migration sequence. Signed-off-by:

[PATCH 08/14] vfio: Use new Error** argument in vfio_save_setup()

2024-02-07 Thread Cédric Le Goater
Add an Error** argument to vfio_migration_set_state() and adjust callers, including vfio_save_setup(). The error will be propagated up to qemu_savevm_state_setup() where the save_setup() handler is executed. Signed-off-by: Cédric Le Goater --- hw/vfio/migration.c | 62

[PATCH 01/14] migration: Add Error** argument to .save_setup() handler

2024-02-07 Thread Cédric Le Goater
The purpose is to record a potential error in the migration stream if qemu_savevm_state_setup() fails. Most of the current .save_setup() handlers can be modified to use the Error argument instead of managing their own and calling locally error_report(). The following patches will introduce such

[PATCH 06/14] vfio: Add Error** argument to vfio_devices_dma_logging_start()

2024-02-07 Thread Cédric Le Goater
This allows to update the Error argument of the VFIO log_global_start() handler. Errors detected when device level logging is started will be propagated up to qemu_savevm_state_setup() when the ram save_setup() handler is executed. The vfio_set_migration_error() call becomes redudant. Remove it.

[PATCH 13/14] migration: Use migrate_has_error() in close_return_path_on_source()

2024-02-07 Thread Cédric Le Goater
close_return_path_on_source() retrieves the migration error from the the QEMUFile '->to_dst_file' to know if a shutdown is required. This shutdown is required to exit the return-path thread. However, in migrate_fd_cleanup(), '->to_dst_file' is cleaned up before calling

[PATCH 12/14] migration: Report error when shutdown fails

2024-02-07 Thread Cédric Le Goater
This will help detect issues regarding I/O channels usage. Signed-off-by: Cédric Le Goater --- migration/qemu-file.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/migration/qemu-file.c b/migration/qemu-file.c index

Re: [PATCH v3 3/6] util/bufferiszero: remove AVX512 variant

2024-02-07 Thread Joao Martins
On 07/02/2024 06:29, Alexander Monakov wrote: > On Tue, 6 Feb 2024, Elena Ufimtseva wrote: >> Hello Alexander >> >> On Tue, Feb 6, 2024 at 12:50 PM Alexander Monakov >> wrote: >> >>> Thanks to early checks in the inline buffer_is_zero wrapper, the SIMD >>> routines are invoked much more rarely in

[PATCH v2 6/8] isa: extract FDC37M81X to a separate file

2024-02-07 Thread Paolo Bonzini
isa-superio.c currently defines a SuperIO chip that is not used by any other user of the faile. Extract the chip to a separate file. Signed-off-by: Paolo Bonzini --- hw/isa/fdc37m81x-superio.c | 32 hw/isa/isa-superio.c | 18 --

[PATCH v2 4/8] isa: fix ISA_SUPERIO dependencies

2024-02-07 Thread Paolo Bonzini
ISA_SUPERIO does not provide an ISA bus, so it should not select the symbol: instead it requires one. Among its users, VT82C686 is the only one that is a PCI-ISA bridge and does not already select ISA_BUS. Signed-off-by: Paolo Bonzini --- hw/isa/Kconfig | 3 ++- 1 file changed, 2

[PATCH v2 3/8] hw/mips/Kconfig: Remove ISA dependencies from MIPSsim board

2024-02-07 Thread Paolo Bonzini
From: Bernhard Beschow The board doesn't seem to have an ISA bus at all. Signed-off-by: Bernhard Beschow Message-ID: <20230109204124.102592-3-shen...@gmail.com> Signed-off-by: Paolo Bonzini --- hw/mips/mipssim.c | 1 - hw/mips/Kconfig | 3 +-- 2 files changed, 1 insertion(+), 3

Re: [PATCH v1 00/15] libvhost-user: support more memslots and cleanup memslot handling code

2024-02-07 Thread Stefano Garzarella
On Fri, Feb 02, 2024 at 10:53:17PM +0100, David Hildenbrand wrote: This series adds support for more memslots (509) to libvhost-user, to make it fully compatible with virtio-mem that uses up to 256 memslots accross all memory devices in "dynamic-memslot" mode (more details in patch #3). One

[PATCH v4 2/3] hw/arm: Connect STM32L4x5 GPIO to STM32L4x5 SoC

2024-02-07 Thread Inès Varhol
Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol --- include/hw/arm/stm32l4x5_soc.h | 2 + hw/arm/stm32l4x5_soc.c | 78 -- hw/arm/Kconfig | 3 +- 3 files changed, 68 insertions(+), 15 deletions(-) diff --git

Re: [PATCH] iotests: fix leak of tmpdir in dry-run mode

2024-02-07 Thread Kevin Wolf
Am 05.02.2024 um 16:40 hat Daniel P. Berrangé geschrieben: > Creating an instance of the 'TestEnv' class will create a temporary > directory. This dir is only deleted, however, in the __exit__ handler > invoked by a context manager. > > In dry-run mode, we don't use the TestEnv via a context

Re: [PATCH v2 0/3] Hexagon (target/hexagon) Only pass env to generated helper when needed

2024-02-07 Thread Anton Johansson via
On 06/02/24, Taylor Simpson wrote: > Currently, we pass env to every generated helper. When the semantics of > the instruction only depend on the arguments, this is unnecessary and > adds extra overhead to the helper call. > > Changes in v2 > - Separate patches to pass P0 and SP

Re: [PATCH v3 00/17] TCG Plugin inline operation enhancement

2024-02-07 Thread Alex Bennée
Pierrick Bouvier writes: > This series adds a new thread-safe API to declare inline operation > inside plugins. As well, it removes the existing non thread-safe API, > and migrates all existing plugins to use it. I've cherry-picked 3 and 4 into plugins/next so I can re-base the registers work.

Re: [PATCH v3 00/17] TCG Plugin inline operation enhancement

2024-02-07 Thread Alex Bennée
Alex Bennée writes: > Pierrick Bouvier writes: > >> This series adds a new thread-safe API to declare inline operation >> inside plugins. As well, it removes the existing non thread-safe API, >> and migrates all existing plugins to use it. > > I've cherry-picked 3 and 4 into plugins/next so I

[PATCH v2 00/14] maintainer updates for 9.0 pre-PR (docker, plugin tests, deprecation, elf, semihosting, gdbstub)

2024-02-07 Thread Alex Bennée
A fairly random collection of fixes in this tree. I've still got a report of openbsd rebuilding which is confusing me (something triggers it but calling again works as expected). v2 - added Ilya's vm-build and gdbstub patches Everything is reviewed now so baring objections I intend to post the

[PATCH v2 13/14] gdbstub: Implement catching syscalls

2024-02-07 Thread Alex Bennée
From: Ilya Leoshkevich GDB supports stopping on syscall entry and exit using the "catch syscall" command. It relies on 3 packets, which are currently not supported by QEMU: * qSupported:QCatchSyscalls+ [1] * QCatchSyscalls: [2] * T05syscall_entry: and T05syscall_return: [3] Implement

[PATCH v2 04/14] Revert "hw/elf_ops: Ignore loadable segments with zero size"

2024-02-07 Thread Alex Bennée
This regressed qemu-system-xtensa: TESTtest_load_store on xtensa qemu-system-xtensa: Some ROM regions are overlapping These ROM regions might have been loaded by direct user request or by default. They could be BIOS/firmware images, a guest kernel, initrd or some other file loaded

[PATCH v2 14/14] tests/tcg: Add the syscall catchpoint gdbstub test

2024-02-07 Thread Alex Bennée
From: Ilya Leoshkevich Check that adding/removing syscall catchpoints works. Reviewed-by: Alex Bennée Signed-off-by: Ilya Leoshkevich Message-Id: <20240202152506.279476-6-...@linux.ibm.com> Signed-off-by: Alex Bennée --- tests/tcg/multiarch/catch-syscalls.c | 51 ++

[PATCH v2 03/14] configure: run plugin TCG tests again

2024-02-07 Thread Alex Bennée
From: Paolo Bonzini Commit 39fb3cfc28b ("configure: clean up plugin option handling", 2023-10-18) dropped the CONFIG_PLUGIN line from tests/tcg/config-host.mak, due to confusion caused by the shadowing of $config_host_mak. However, TCG tests were still expecting it. Oops. Put it back, in the

[PATCH v2 08/14] meson: Link with libinotify on FreeBSD

2024-02-07 Thread Alex Bennée
From: Ilya Leoshkevich make vm-build-freebsd fails with: ld: error: undefined symbol: inotify_init1 >>> referenced by filemonitor-inotify.c:183 (../src/util/filemonitor-inotify.c:183) >>> util_filemonitor-inotify.c.o:(qemu_file_monitor_new) in archive libqemuutil.a

[PATCH v2 06/14] tests/vm/freebsd: Reload the sshd configuration

2024-02-07 Thread Alex Bennée
From: Ilya Leoshkevich After console_sshd_config(), the SSH server needs to be nudged to pick up the new configs. The scripts for the other BSD flavors already do this with a reboot, but a simple reload is sufficient. Reviewed-by: Thomas Huth Signed-off-by: Ilya Leoshkevich Message-Id:

[PATCH v2 01/14] tests/docker: Add sqlite3 module to openSUSE Leap container

2024-02-07 Thread Alex Bennée
From: Fabiano Rosas Avocado needs sqlite3: Failed to load plugin from module "avocado.plugins.journal": ImportError("Module 'sqlite3' is not installed. Use: sudo zypper install python311 to install it") >From 'zypper info python311': "This package supplies rich command line features

[PATCH v2 09/14] kconfig: use "select" to enable semihosting

2024-02-07 Thread Alex Bennée
From: Paolo Bonzini Just like all other dependencies, these can be expressed in Kconfig files rather than in the default configurations. Signed-off-by: Paolo Bonzini Acked-by: Alistair Francis Reviewed-by: Thomas Huth Message-Id: <20240201122835.1712347-6-alex.ben...@linaro.org> Message-Id:

[PATCH v2 07/14] test-util-filemonitor: Adapt to the FreeBSD inotify rename semantics

2024-02-07 Thread Alex Bennée
From: Ilya Leoshkevich Unlike on Linux, on FreeBSD renaming a file when the destination already exists results in an IN_DELETE event for that existing file: $ FILEMONITOR_DEBUG=1 build/tests/unit/test-util-filemonitor Rename /tmp/test-util-filemonitor-K13LI2/fish/one.txt ->

[PATCH v2 11/14] gdbstub: Allow specifying a reason in stop packets

2024-02-07 Thread Alex Bennée
From: Ilya Leoshkevich The upcoming syscall catchpoint support needs to send stop packets with an associated reason to GDB. Add an extra parameter to gdb_handlesig() for that, and rename it to gdb_handlesig_reason(). Provide a compatibility wrapper with an old name. Signed-off-by: Ilya

[PATCH v2 12/14] gdbstub: Add syscall entry/return hooks

2024-02-07 Thread Alex Bennée
From: Ilya Leoshkevich The upcoming syscall catchpoint support needs to get control on syscall entry and return. Provide the necessary hooks for that, which are no-ops for now. Signed-off-by: Ilya Leoshkevich Message-Id: <20240202152506.279476-4-...@linux.ibm.com> Signed-off-by: Alex Bennée

Re: [PATCH v3 0/4] make vm-build-freebsd fixes

2024-02-07 Thread Alex Bennée
Ilya Leoshkevich writes: > v2: https://lists.gnu.org/archive/html/qemu-devel/2024-02/msg00890.html > v2 -> v3: Structure the meson check similar to have_asan_fiber; > Reduce the context size a little (Philippe). > > v1:

Re: [PATCH] hw/intc: Handle the error of IOAPICCommonClass.realize()

2024-02-07 Thread Zhao Liu
Hi Markus, On Wed, Feb 07, 2024 at 07:51:52AM +0100, Markus Armbruster wrote: > Date: Wed, 07 Feb 2024 07:51:52 +0100 > From: Markus Armbruster > Subject: Re: [PATCH] hw/intc: Handle the error of > IOAPICCommonClass.realize() > > Zhao Liu writes: > > > Hi Philippe, > > > > On Wed, Jan 31,

  1   2   3   >