Re: [PATCH v6 00/23] migration: File based migration with multifd and mapped-ram

2024-03-01 Thread Peter Xu
On Thu, Feb 29, 2024 at 12:29:54PM -0300, Fabiano Rosas wrote: > Based-on: 74aa0fb297 (migration: options incompatible with cpr) # > peterx/migration-next > > Hi, > > In this v6: > > - Minor fixes to 17/23 and 19/23 Thanks both for confirming, queued now. -- Peter Xu

[PATCH] migration/multifd: Document two places for mapped-ram

2024-03-01 Thread peterx
From: Peter Xu Add two documentations for mapped-ram migration on two spots that may not be extremely clear. Signed-off-by: Peter Xu --- Based-on: <20240229153017.2221-1-faro...@suse.de> --- migration/multifd.c | 12 migration/ram.c | 8 +++- 2 files changed, 19

[PULL 1/6] libqos/virtio.c: init all elems in qvring_indirect_desc_setup()

2024-03-01 Thread Thomas Huth
From: Daniel Henrique Barboza The loop isn't setting the values for the last element. Every other element is being initialized with addr = 0, flags = VRING_DESC_F_NEXT and next = i + 1. The last elem is never touched. This became a problem when enabling a RISC-V 'virt' libqos machine in the

[PULL 2/6] libqos/virtio.c: fix 'avail_event' offset in qvring_init()

2024-03-01 Thread Thomas Huth
From: Daniel Henrique Barboza In qvring_init() we're writing vq->used->avail_event at "vq->used + 2 + array_size". The struct pointed by vq->used is, from virtio_ring.h Linux header): * // A ring of used descriptor heads with free-running index. * __virtio16 used_flags; *

[PULL 6/6] chardev/char-socket: Fix TLS io channels sending too much data to the backend

2024-03-01 Thread Thomas Huth
Commit ffda5db65a ("io/channel-tls: fix handling of bigger read buffers") changed the behavior of the TLS io channels to schedule a second reading attempt if there is still incoming data pending. This caused a regression with backends like the sclpconsole that check in their read function that the

[PULL 0/6] Misc fixes (libqos vring, Kconfig, TLS io channels, ...)

2024-03-01 Thread Thomas Huth
Hi Peter! The following changes since commit c0c6a0e3528b88aaad0b9d333e295707a195587b: Merge tag 'migration-next-pull-request' of https://gitlab.com/peterx/qemu into staging (2024-02-28 17:27:10 +) are available in the Git repository at: https://gitlab.com/thuth/qemu.git

[PULL 5/6] tests/unit/test-util-sockets: Remove temporary file after test

2024-03-01 Thread Thomas Huth
test-util-sockets leaves the temporary socket files around in the temporary files folder. Let's better remove them at the end of the testing. Fixes: 4d3a329af5 ("tests/util-sockets: add abstract unix socket cases") Message-ID: <20240226082728.249753-1-th...@redhat.com> Reviewed-by: Marc-André

[PULL 3/6] hw/intc/Kconfig: Fix GIC settings when using "--without-default-devices"

2024-03-01 Thread Thomas Huth
When using "--without-default-devices", the ARM_GICV3_TCG and ARM_GIC_KVM settings currently get disabled, though the arm virt machine is only of very limited use in that case. This also causes the migration-test to fail in such builds. Let's make sure that we always keep the GIC switches enabled

[PULL 4/6] hw/usb/bus.c: PCAP adding 0xA in Windows version

2024-03-01 Thread Thomas Huth
From: Benjamin David Lunt Since Windows text files use CRLFs for all \n, the Windows version of QEMU inserts a CR in the PCAP stream when a LF is encountered when using USB PCAP files. This is due to the fact that the PCAP file is opened as TEXT instead of BINARY. To show an example, when using

Re: [PATCH v6 00/23] migration: File based migration with multifd and mapped-ram

2024-03-01 Thread Daniel P . Berrangé
On Fri, Mar 01, 2024 at 09:50:32AM +0800, Peter Xu wrote: > On Thu, Feb 29, 2024 at 12:29:54PM -0300, Fabiano Rosas wrote: > > Based-on: 74aa0fb297 (migration: options incompatible with cpr) # > > peterx/migration-next > > > > Hi, > > > > In this v6: > > > > - Minor fixes to 17/23 and 19/23 >

Re: [PATCH v2 1/3] qtest: migration: Enhance qtest migration functions to support 'channels' argument

2024-03-01 Thread Het Gala
On 29/02/24 6:47 am, Fabiano Rosas wrote: Het Gala writes: On 27/02/24 1:04 am, Het Gala wrote: On 26/02/24 6:31 pm, Fabiano Rosas wrote: Het Gala writes: On 24/02/24 1:42 am, Fabiano Rosas wrote: this was the same first approach that I attempted. It won't work because The final

Re: [PATCH v5 06/12] tests/plugin/mem: migrate to new per_vcpu API

2024-03-01 Thread Pierrick Bouvier
On 2/29/24 5:46 PM, Alex Bennée wrote: Pierrick Bouvier writes: On 2/29/24 11:08 AM, Alex Bennée wrote: Pierrick Bouvier writes: On 2/29/24 2:08 AM, Alex Bennée wrote: Luc Michel writes: Hi Pierrick, My bad. Other plugins enable only inline when both are supplied, so I missed

Re: [PATCH v5 08/12] tests/plugin/bb: migrate to new per_vcpu API

2024-03-01 Thread Pierrick Bouvier
On 2/29/24 6:21 PM, Alex Bennée wrote: Pierrick Bouvier writes: Signed-off-by: Pierrick Bouvier I did notice there is a discrepancy between what libisns and libb report. The libb looks like an overcount so I wonder if there are some instructions we are not picking up but I can't see where

Re: [PATCH 8/8] tests/unit/test-smp-parse.c: Test smp_props.has_clusters

2024-03-01 Thread Thomas Huth
On 18/01/2024 15.48, Zhao Liu wrote: From: Zhao Liu The smp_props.has_clusters in MachineClass is not a user configured field, and it indicates if user specifies "clusters" in -smp. After -smp parsing, other module could aware if the cluster level is configured by user. This is used when the

Re: [PATCH] hw/us/bus.c PCAP adding 0xA in Windows version

2024-03-01 Thread Thomas Huth
On 25/02/2024 20.49, benl...@fysnet.net wrote: Since Windows text files use CRLFs for all \n, the Windows version of QEMU inserts a CR in the PCAP stream when a LF is encountered when using USB PCAP files. This is due to the fact that the PCAP file is opened as TEXT instead of BINARY. To show

[PATCH v5 01/17] hw/loongarch: Move boot fucntions to boot.c

2024-03-01 Thread Song Gao
Move some boot functions to boot.c and struct loongarch_boot_info into struct LoongArchMachineState. Signed-off-by: Song Gao --- include/hw/loongarch/boot.h | 21 ++ include/hw/loongarch/virt.h | 2 + hw/loongarch/boot.c | 125

[PATCH v5 15/17] hw/loongarch: fdt remove unused irqchip node

2024-03-01 Thread Song Gao
Signed-off-by: Song Gao --- hw/loongarch/virt.c | 31 +-- 1 file changed, 1 insertion(+), 30 deletions(-) diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c index ea73a80628..e2185d7bb4 100644 --- a/hw/loongarch/virt.c +++ b/hw/loongarch/virt.c @@ -410,34 +410,6

[PATCH v1 1/1] memory tier: acpi/hmat: create CPUless memory tiers after obtaining HMAT info

2024-03-01 Thread Ho-Ren (Jack) Chuang
* Introduce `mt_init_with_hmat()` We defer memory tier initialization for those CPUless NUMA nodes until acquiring HMAT info. `mt_init_with_hmat()` is introduced to post-create CPUless memory tiers after obtaining HMAT info. It iterates through each CPUless memory node, creating memory tiers if

[PATCH v1 0/1] Improved Memory Tier Creation for CPUless NUMA Nodes

2024-03-01 Thread Ho-Ren (Jack) Chuang
The memory tiering component in the kernel is functionally useless for CPUless memory/non-DRAM devices like CXL1.1 type3 memory because the nodes are lumped together in the DRAM tier. https://lore.kernel.org/linux-mm/ph0pr08mb7955e9f08ccb64f23963b5c3a8...@ph0pr08mb7955.namprd08.prod.outlook.com/T/

[PATCH v5 07/17] hw/loongarch: Init efi_initrd table

2024-03-01 Thread Song Gao
Signed-off-by: Song Gao --- include/hw/loongarch/boot.h | 9 + hw/loongarch/boot.c | 23 +-- 2 files changed, 30 insertions(+), 2 deletions(-) diff --git a/include/hw/loongarch/boot.h b/include/hw/loongarch/boot.h index 7ad25080c5..ce47056608 100644 ---

[PATCH v5 00/17] Add boot LoongArch elf kernel with FDT

2024-03-01 Thread Song Gao
Hi, All We already support boot efi kernel with bios, but not support boot elf kernel. This series adds boot elf kernel with FDT. 'LoongArch supports ACPI and FDT. The information that needs to be passed to the kernel includes the memmap, the initrd, the command line, optionally the ACPI/FDT

[PATCH v5 16/17] hw/loongarch: Add cells missing from uart node

2024-03-01 Thread Song Gao
uart node need interrupts and interrupt-parent cells. Signed-off-by: Song Gao --- hw/loongarch/virt.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c index e2185d7bb4..5d92b2f1aa 100644 --- a/hw/loongarch/virt.c +++

[PATCH v5 04/17] hw/loongarch: Add init_cmdline

2024-03-01 Thread Song Gao
Add init_cmline and set boot_info->a0, a1 Signed-off-by: Song Gao --- include/hw/loongarch/virt.h | 2 ++ target/loongarch/cpu.h | 2 ++ hw/loongarch/boot.c | 19 +++ 3 files changed, 23 insertions(+) diff --git a/include/hw/loongarch/virt.h

[PATCH v5 06/17] hw/loongarch: Init efi_boot_memmap table

2024-03-01 Thread Song Gao
Signed-off-by: Song Gao --- include/hw/loongarch/boot.h | 27 + include/hw/loongarch/virt.h | 10 ++ hw/loongarch/boot.c | 39 + hw/loongarch/virt.c | 11 ++- 4 files changed, 78 insertions(+), 9

[PATCH v5 03/17] hw/loongarch: Add slave cpu boot_code

2024-03-01 Thread Song Gao
Signed-off-by: Song Gao --- hw/loongarch/boot.c | 70 - 1 file changed, 69 insertions(+), 1 deletion(-) diff --git a/hw/loongarch/boot.c b/hw/loongarch/boot.c index 3075c276d4..2f398260af 100644 --- a/hw/loongarch/boot.c +++ b/hw/loongarch/boot.c @@

[PATCH v5 09/17] hw/loongarch: Fix fdt memory node wrong 'reg'

2024-03-01 Thread Song Gao
The right fdt memory node like [1], not [2] [1] memory@0 { device_type = "memory"; reg = <0x00 0x00 0x00 0x1000>; }; [2] memory@0 { device_type = "memory"; reg = <0x02 0x00 0x02 0x1000>; };

[PATCH v5 17/17] hw/loongarch: Add cells missing from rtc node

2024-03-01 Thread Song Gao
rtc node need interrupts and interrupt-parent cells. Signed-off-by: Song Gao --- hw/loongarch/virt.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c index 5d92b2f1aa..6810f78ebd 100644 --- a/hw/loongarch/virt.c +++

Re: [PATCH v7 2/2] hw/acpi: Implement the SRAT GI affinity structure

2024-03-01 Thread Ankit Agrawal
>> >> One more thing.  Right now we can't use Generic Initiators as >> HMAT initiators.  That also wants fixing given that's their >> normal usecase rather than what you are using them for so it >> should 'work'. > > Something along the lines of this will do the job. Thanks! Will incorporate the

Re: [PATCH 06/19] smbios: get rid of smbios_legacy global

2024-03-01 Thread Ani Sinha
> On 29-Feb-2024, at 19:59, Igor Mammedov wrote: > > On Thu, 29 Feb 2024 16:23:21 +0530 > Ani Sinha wrote: > >>> On 27-Feb-2024, at 21:17, Igor Mammedov wrote: >>> >>> clean up smbios_set_defaults() which is reused by legacy >>> and non legacy machines from being aware of 'legacy' notion

Re: [PATCH v7 1/2] qom: new object to associate device to numa node

2024-03-01 Thread Ankit Agrawal
>> As for your suggestion of using acpi-dev as the arg to take both >> pci-dev and acpi-dev.. Would that mean sending a pure pci device >> (not the corner case you mentioned) through the acpi-dev argument >> as well? Not sure if that would appropriate. > > Ah, looking up my description is

[PATCH v5 02/17] hw/loongarch: Add load initrd

2024-03-01 Thread Song Gao
we load initrd ramdisk after kernel_high address Signed-off-by: Song Gao --- hw/loongarch/boot.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/hw/loongarch/boot.c b/hw/loongarch/boot.c index 0f2bc15fdf..3075c276d4 100644 ---

[PATCH v5 08/17] hw/loongarch: Init efi_fdt table

2024-03-01 Thread Song Gao
Signed-off-by: Song Gao --- include/hw/loongarch/boot.h | 4 hw/loongarch/boot.c | 11 +++ 2 files changed, 15 insertions(+) diff --git a/include/hw/loongarch/boot.h b/include/hw/loongarch/boot.h index ce47056608..bbe8c8dd5d 100644 --- a/include/hw/loongarch/boot.h +++

[PATCH v5 10/17] hw/loongarch: fdt adds cpu interrupt controller node

2024-03-01 Thread Song Gao
fdt adds cpu interrupt controller node, we use 'loongson,cpu-interrupt-controller'. See: https://github.com/torvalds/linux/blob/v6.7/drivers/irqchip/irq-loongarch-cpu.c https://lore.kernel.org/r/20221114113824.1880-2-liupei...@loongson.cn Signed-off-by: Song Gao --- hw/loongarch/virt.c | 20

[PATCH v5 11/17] hw/loongarch: fdt adds Extend I/O Interrupt Controller

2024-03-01 Thread Song Gao
fdt adds Extend I/O Interrupt Controller, we use 'loongson,ls2k2000-eiointc'. See: https://github.com/torvalds/linux/blob/v6.7/drivers/irqchip/irq-loongson-eiointc.c https://lore.kernel.org/r/764e02d924094580ac0f1d15535f4b98308705c6.1683279769.git.zhoubin...@loongson.cn Signed-off-by: Song Gao

[PATCH v5 12/17] hw/loongarch: fdt adds pch_pic Controller

2024-03-01 Thread Song Gao
fdt adds pch pic controller, we use 'loongson,pch-pic-1.0' See: https://github.com/torvalds/linux/blob/v6.7/drivers/irqchip/irq-loongson-pch-pic.c https://lore.kernel.org/r/20200528152757.1028711-4-jiaxun.y...@flygoat.com Signed-off-by: Song Gao --- include/hw/pci-host/ls7a.h | 1 +

[PATCH v5 13/17] hw/loongarch: fdt adds pch_msi Controller

2024-03-01 Thread Song Gao
fdt adds pch msi controller, we use 'loongson,pch-msi-1.0'. See: https://github.com/torvalds/linux/blob/v6.7/drivers/irqchip/irq-loongson-pch-msi.c https://lore.kernel.org/r/20200528152757.1028711-6-jiaxun.y...@flygoat.com Signed-off-by: Song Gao --- include/hw/pci-host/ls7a.h | 1 +

Re: [PATCH 7/8] tests/unit/test-smp-parse.c: Test the full 7-levels topology hierarchy

2024-03-01 Thread Thomas Huth
On 18/01/2024 15.48, Zhao Liu wrote: From: Zhao Liu Currently, -smp supports up to 7-levels topology hierarchy: -drawers/books/sockets/dies/clusters/cores/threads. Though no machine supports all these 7 levels yet, these 7 levels have the strict containment relationship and together form

Re: [PATCH v5 00/17] Add boot LoongArch elf kernel with FDT

2024-03-01 Thread gaosong
Hi, If there are no new comments, I'll add this series to the loongarch-next branch next week. Thanks. Song Gao 在 2024/3/1 下午5:38, Song Gao 写道: Hi, All We already support boot efi kernel with bios, but not support boot elf kernel. This series adds boot elf kernel with FDT. 'LoongArch

[PATCH v5 14/17] hw/loongarch: fdt adds pcie irq_map node

2024-03-01 Thread Song Gao
Signed-off-by: Song Gao --- hw/loongarch/virt.c | 73 ++--- 1 file changed, 69 insertions(+), 4 deletions(-) diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c index e1fe1ea97f..ea73a80628 100644 --- a/hw/loongarch/virt.c +++ b/hw/loongarch/virt.c @@

Re: [PATCH v6 06/12] tests/plugin/mem: migrate to new per_vcpu API

2024-03-01 Thread Pierrick Bouvier
On 2/29/24 10:08 PM, Alex Bennée wrote: Pierrick Bouvier writes: Reviewed-by: Luc Michel Signed-off-by: Pierrick Bouvier --- tests/plugin/mem.c | 46 +++--- 1 file changed, 31 insertions(+), 15 deletions(-) diff --git a/tests/plugin/mem.c

[PATCH v5 05/17] hw/loongarch: Init efi_system_table

2024-03-01 Thread Song Gao
Add init_systab and set boot_info->a2 Signed-off-by: Song Gao --- include/hw/loongarch/boot.h | 48 + hw/loongarch/boot.c | 22 + 2 files changed, 70 insertions(+) diff --git a/include/hw/loongarch/boot.h b/include/hw/loongarch/boot.h

[PATCH] replay: Improve error messages about configuration conflicts

2024-03-01 Thread Markus Armbruster
Improve Record/replay feature is not supported for '-rtc base=localtime' Record/replay feature is not supported for 'smp' Record/replay feature is not supported for '-snapshot' to Record/replay is not supported with -rtc base=localtime Record/replay is not supported with multiple

Re: [PATCH v5 08/12] tests/plugin/bb: migrate to new per_vcpu API

2024-03-01 Thread Alex Bennée
Pierrick Bouvier writes: > On 2/29/24 6:21 PM, Alex Bennée wrote: >> Pierrick Bouvier writes: >> >>> Signed-off-by: Pierrick Bouvier >> I did notice there is a discrepancy between what libisns and libb >> report. The libb looks like an overcount so I wonder if there are some >> instructions

Re: [PATCH v5 08/12] tests/plugin/bb: migrate to new per_vcpu API

2024-03-01 Thread Pierrick Bouvier
On 3/1/24 2:26 PM, Alex Bennée wrote: Pierrick Bouvier writes: On 2/29/24 6:21 PM, Alex Bennée wrote: Pierrick Bouvier writes: Signed-off-by: Pierrick Bouvier I did notice there is a discrepancy between what libisns and libb report. The libb looks like an overcount so I wonder if there

Re: [PATCH v3 2/3] tools: build qemu-vmsr-helper

2024-03-01 Thread Anthony Harivel
Hi Paolo, > > > +static void compute_default_paths(void) > > > +{ > > > +socket_path = g_build_filename("/run", "qemu-vmsr-helper.sock", > > > NULL); > > > +pidfile = g_build_filename("/run", "qemu-vmsr-helper.pid", NULL); > > > +} > > > > We shouldn't be hardcoding /run, we need to

Re: [QEMU][PATCH v3 1/7] softmmu: physmem: Split ram_block_add()

2024-03-01 Thread Alex Bennée
Vikram Garhwal writes: > Extract ram block list update to a new function ram_block_add_list(). This is > done to support grant mappings which adds a memory region for granted memory > and > updates the ram_block list. > > Signed-off-by: Juergen Gross > Signed-off-by: Vikram Garhwal >

Re: [PATCH v5 09/12] contrib/plugins/hotblocks: migrate to new per_vcpu API

2024-03-01 Thread Luc Michel
On 14:33 Thu 29 Feb , Alex Bennée wrote: > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > Luc Michel writes: > > > On 15:09 Tue 27 Feb , Pierrick Bouvier wrote: > >> On 2/27/24 2:54 PM, Luc

Re: [PATCH v2 0/5] Add device DM163 (led driver, matrix colors shield & display)

2024-03-01 Thread Peter Maydell
On Wed, 28 Feb 2024 at 12:06, Thomas Huth wrote: > > On 28/02/2024 12.31, Inès Varhol wrote: > > TLDR: how can I provide a test or an example? > > > > I've tested the display by running custom executables and > > comparing to the result on the real board, but I don't > > know how to test it using

Re: [PATCH V4 10/14] migration: stop vm for cpr

2024-03-01 Thread Cédric Le Goater
On 3/1/24 02:28, Peter Xu wrote: On Thu, Feb 29, 2024 at 10:21:14AM -0500, Steven Sistare wrote: On 2/25/2024 9:08 PM, Peter Xu wrote: On Thu, Feb 22, 2024 at 09:28:36AM -0800, Steve Sistare wrote: When migration for cpr is initiated, stop the vm and set state RUN_STATE_FINISH_MIGRATE before

Re: [PATCH v2 0/5] Add device DM163 (led driver, matrix colors shield & display)

2024-03-01 Thread Thomas Huth
On 01/03/2024 11.21, Peter Maydell wrote: On Wed, 28 Feb 2024 at 12:06, Thomas Huth wrote: On 28/02/2024 12.31, Inès Varhol wrote: TLDR: how can I provide a test or an example? I've tested the display by running custom executables and comparing to the result on the real board, but I don't

Re: [PATCH v7 0/3] string list functions

2024-03-01 Thread Markus Armbruster
Steven Sistare writes: > All the changes look good - steve Thanks! I can stick this into my next PR, ETA early next week.

Re: [PATCH] migration/multifd: Document two places for mapped-ram

2024-03-01 Thread Fabiano Rosas
pet...@redhat.com writes: > From: Peter Xu > > Add two documentations for mapped-ram migration on two spots that may not > be extremely clear. > > Signed-off-by: Peter Xu Reviewed-by: Fabiano Rosas

[PATCH 1/1] kvm: add support for guest physical bits

2024-03-01 Thread Gerd Hoffmann
query kvm for supported guest physical address bits using KVM_CAP_VM_GPA_BITS. Expose the value to the guest via cpuid (leaf 0x8008, eax, bits 16-23). Signed-off-by: Gerd Hoffmann --- target/i386/cpu.h | 1 + target/i386/cpu.c | 1 + target/i386/kvm/kvm.c | 8 3 files

[PATCH 0/1] kvm: add support for guest physical bits

2024-03-01 Thread Gerd Hoffmann
The matching kernel bits are here: https://lore.kernel.org/kvm/20240301101410.356007-1-kra...@redhat.com/T/ Gerd Hoffmann (1): kvm: add support for guest physical bits target/i386/cpu.h | 1 + target/i386/cpu.c | 1 + target/i386/kvm/kvm.c | 8 3 files changed, 10

Re: [PULL 26/29] contrib/plugins: extend execlog to track register changes

2024-03-01 Thread Alex Bennée
Zhao Liu writes: > Hi Alex, > > I hit the following warnings (with "./configure --enable-werror"): > > /qemu/contrib/plugins/execlog.c: In function ‘registers_init’: > /qemu/contrib/plugins/execlog.c:330:17: warning: ‘g_pattern_match_string’ is > deprecated: Use 'g_pattern_spec_match_string'

Re: [PATCH v2 1/3] qtest: migration: Enhance qtest migration functions to support 'channels' argument

2024-03-01 Thread Het Gala
On 01/03/24 2:19 pm, Het Gala wrote: On 29/02/24 6:47 am, Fabiano Rosas wrote: Het Gala writes: On 27/02/24 1:04 am, Het Gala wrote: On 26/02/24 6:31 pm, Fabiano Rosas wrote: Het Gala  writes: On 24/02/24 1:42 am, Fabiano Rosas wrote: this was the same first approach that I

Re: [PATCH v2] hw/nvme/ns: Add NVMe NGUID property

2024-03-01 Thread Klaus Jensen
On Feb 22 17:50, Nabih Estefan wrote: > From: Roque Arcudia Hernandez > > This patch adds a way to specify an NGUID for a given NVMe Namespace using a > string of hexadecimal digits with an optional '-' separator to group bytes. > For > instance: > > -device

Re: [PULL v2 1/1] loongarch: Change the UEFI loading mode to loongarch

2024-03-01 Thread Philippe Mathieu-Daudé
On 29/2/24 12:38, Song Gao wrote: From: Xianglai Li The UEFI loading mode in loongarch is very different from that in other architectures:loongarch's UEFI code is in rom, while other architectures' UEFI code is in flash. loongarch UEFI can be loaded as follows: -machine

Re: [PATCH v2 3/5] linux-user: Add strace for shmat

2024-03-01 Thread Philippe Mathieu-Daudé
On 28/2/24 21:25, Richard Henderson wrote: Signed-off-by: Richard Henderson --- linux-user/strace.c| 23 +++ linux-user/strace.list | 2 +- 2 files changed, 24 insertions(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 1/3] qtest: migration: Enhance qtest migration functions to support 'channels' argument

2024-03-01 Thread Fabiano Rosas
Het Gala writes: > On 01/03/24 2:19 pm, Het Gala wrote: >> >> On 29/02/24 6:47 am, Fabiano Rosas wrote: >>> Het Gala writes: >>> On 27/02/24 1:04 am, Het Gala wrote: > > On 26/02/24 6:31 pm, Fabiano Rosas wrote: >> Het Gala  writes: >> >>> On 24/02/24 1:42 am, Fabiano

[RFC 8/8] virtio: Add VIRTIO_F_NOTIFICATION_DATA property definition

2024-03-01 Thread Jonah Palmer
Extend the virtio device property definitions to include the VIRTIO_F_NOTIFICATION_DATA feature. The default state of this feature is disabled, allowing it to be explicitly enabled where it's supported. Signed-off-by: Jonah Palmer --- include/hw/virtio/virtio.h | 4 +++- 1 file changed, 3

[RFC 5/8] virtio-ccw: Handle extra notification data

2024-03-01 Thread Jonah Palmer
Add support to virtio-ccw devices for handling the extra data sent from the driver to the device when the VIRTIO_F_NOTIFICATION_DATA transport feature has been negotiated. The extra data that's passed to the virtio-ccw device when this feature is enabled varies depending on the device's virtqueue

[RFC 1/8] virtio/virtio-pci: Handle extra notification data

2024-03-01 Thread Jonah Palmer
Add support to virtio-pci devices for handling the extra data sent from the driver to the device when the VIRTIO_F_NOTIFICATION_DATA transport feature has been negotiated. The extra data that's passed to the virtio-pci device when this feature is enabled varies depending on the device's virtqueue

Re: [PATCH 00/19] Workaround Windows failing to find 64bit SMBIOS entry point with SeaBIOS

2024-03-01 Thread Fiona Ebner
Am 29.02.24 um 14:18 schrieb Fiona Ebner: > Am 27.02.24 um 16:47 schrieb Igor Mammedov: >> Windows (10) bootloader when running on top of SeaBIOS, fails to find >> >> SMBIOSv3 entry point. Tracing it shows that it looks for v2 anchor markers >> >> only and not v3. Tricking it

Re: [QEMU][PATCH v3 2/7] xen: add pseudo RAM region for grant mappings

2024-03-01 Thread Alex Bennée
Vikram Garhwal writes: > From: Juergen Gross > > Add a memory region which can be used to automatically map granted > memory. It is starting at 0x8000ULL in order to be able to > distinguish it from normal RAM. Is the Xen memory map for HVM guests documented anywhere? I couldn't

Re: [PATCH v1 0/5] hw/ppc: SPI model

2024-03-01 Thread Chalapathi V
Hello, I would greatly appreciate the review comments/suggestions on PATCH V1. Thank You and Regards, Chalapathi On 07-02-2024 21:38, Chalapathi V wrote: Hello, In this series of patchset, SPI controller and responder models for Power10 processor are modelled. Serial peripheral interface

Re: [PATCH 3/9] backends/confidential-guest-support: Add functions to support IGVM

2024-03-01 Thread Daniel P . Berrangé
On Tue, Feb 27, 2024 at 02:50:09PM +, Roy Hopkins wrote: > In preparation for supporting the processing of IGVM files to configure > guests, this adds a set of functions to ConfidentialGuestSupport > allowing configuration of secure virtual machines that can be > implemented for each supported

Re: [PATCH 6/9] i386/pc: Skip initialization of system FW when using IGVM

2024-03-01 Thread Daniel P . Berrangé
On Tue, Feb 27, 2024 at 02:50:12PM +, Roy Hopkins wrote: > When using an IGVM file the configuration of the system firmware is > defined by IGVM directives contained in the file. Therefore the default > system firmware should not be initialized when an IGVM file has been > provided. > > This

[PATCH v2 1/6] vhost-user-blk: simplify and fix vhost_user_blk_handle_config_change

2024-03-01 Thread Vladimir Sementsov-Ogievskiy
Let's not care about what was changed and update the whole config, reasons: 1. config->geometry should be updated together with capacity, so we fix a bug. 2. Vhost-user protocol doesn't say anything about config change limitation. Silent ignore of changes doesn't seem to be correct. 3.

[PATCH v2 2/6] qdev-monitor: fix error message in find_device_state()

2024-03-01 Thread Vladimir Sementsov-Ogievskiy
This "hotpluggable" here is misleading. Actually we check is object a device or not. Let's drop the word. SUggested-by: Markus Armbruster Signed-off-by: Vladimir Sementsov-Ogievskiy --- system/qdev-monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v3 02/12] util/log: make qemu_set_dfilter_ranges() take a GList

2024-03-01 Thread Sven Schnelle
In preparation of making qemu_set_dfilter_ranges() available to other users, move the code to a new function range_list_from_string() which takes an additional GList argument. Signed-off-by: Sven Schnelle --- util/log.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-)

[PATCH v3 06/12] util/range: split up range_list_from_string()

2024-03-01 Thread Sven Schnelle
Makes the code a bit easier to read and maintain. Signed-off-by: Sven Schnelle --- util/range.c | 119 ++- 1 file changed, 70 insertions(+), 49 deletions(-) diff --git a/util/range.c b/util/range.c index db535de9a7..8c463995e7 100644 ---

[PATCH v3 11/12] plugins/execlog: use range list api

2024-03-01 Thread Sven Schnelle
Instead of doing its own implementation, use the new range list API to parse and match address lists. Signed-off-by: Sven Schnelle --- contrib/plugins/execlog.c | 27 +-- 1 file changed, 9 insertions(+), 18 deletions(-) diff --git a/contrib/plugins/execlog.c

Re: QNX VM hang on Qemu

2024-03-01 Thread Faiq Ali Sayed
Hi Clément, So the output of the command | $ qemu-system-aarch64 -M xlnx-zcu102 -m 4G -no-reboot -nographic -kernel qnx.img is $ pulseaudio: set_sink_input_volume() failed $ pulseaudio: Reason: Invalid argument $ pulseaudio: set_sink_input_mute() failed $ pulseaudio: Reason: Invalid argument I

Re: [PATCH] migration/multifd: Document two places for mapped-ram

2024-03-01 Thread Prasad Pandit
Hello Petr, On Fri, 1 Mar 2024 at 14:46, wrote: > + * An explicitly close() on the channel here is normally not explicitly -> explicit > + * required, but can be helpful for "file:" iochannels, where it > + * will include an fdatasync() to make sure the data is flushed

[PATCH v3 10/12] plugins: add range list API

2024-03-01 Thread Sven Schnelle
Export range_list_from_string(), range_contains() and range_list_free() to allow plugins to parse filter ranges and match them to avoid reimplementing this functionality. Signed-off-by: Sven Schnelle --- include/qemu/qemu-plugin.h | 41 plugins/api.c

[PATCH v3 03/12] util/range: move range_list_from_string() to range.c

2024-03-01 Thread Sven Schnelle
Signed-off-by: Sven Schnelle --- include/qemu/range.h | 7 util/log.c | 74 -- util/range.c | 76 3 files changed, 83 insertions(+), 74 deletions(-) diff --git a/include/qemu/range.h

[PATCH] hmp: Add option to info qtree to omit details

2024-03-01 Thread BALATON Zoltan
The output of info qtree monitor command is very long. Add an option to print a brief overview omitting all the details. Signed-off-by: BALATON Zoltan --- hmp-commands-info.hx | 6 +++--- system/qdev-monitor.c | 24 +--- 2 files changed, 16 insertions(+), 14 deletions(-)

[PATCH 4/8] target/arm: Don't allow RES0 CNTHCTL_EL2 bits to be written

2024-03-01 Thread Peter Maydell
Don't allow the guest to write CNTHCTL_EL2 bits which don't exist. This is not strictly architecturally required, but it is how we've tended to implement registers more recently. In particular, bits [19:18] are only present with FEAT_RME, and bits [17:12] will only be present with FEAT_ECV.

[PATCH 3/8] target/arm: use FIELD macro for CNTHCTL bit definitions

2024-03-01 Thread Peter Maydell
We prefer the FIELD macro over ad-hoc #defines for register bits; switch CNTHCTL to that style before we add any more bits. Signed-off-by: Peter Maydell --- target/arm/internals.h | 19 +-- target/arm/helper.c| 9 - 2 files changed, 21 insertions(+), 7 deletions(-)

[PATCH] Make some structure static

2024-03-01 Thread Frediano Ziglio
Not used outside C module. Signed-off-by: Frediano Ziglio --- hw/vfio/pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index 4fa387f043..a1522a011a 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -2558,7 +2558,7 @@ static bool

[PATCH] Fix typo in comment (uin32_t -> uint32_t)

2024-03-01 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- hw/vfio/pci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/vfio/pci.h b/hw/vfio/pci.h index 6e64a2654e..4bb7d7d257 100644 --- a/hw/vfio/pci.h +++ b/hw/vfio/pci.h @@ -181,7 +181,7 @@ struct VFIOPCIDevice { Notifier

[PATCH 1/4] hw/i386/pc: Remove pc_compat_1_4..1.7[] left over declarations

2024-03-01 Thread Philippe Mathieu-Daudé
These definitions were removed in commit ea985d235b ("pc_piix: remove pc-i440fx-1.4 up to pc-i440fx-1.7"). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 12 1 file changed, 12 deletions(-) diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index

[PATCH 3/4] hw/i386/pc: Remove 'host_type' argument from pc_init1()

2024-03-01 Thread Philippe Mathieu-Daudé
All callers use host_type=TYPE_I440FX_PCI_HOST_BRIDGE. Directly use this definition within pc_init1(). Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc_piix.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index

[PATCH 0/4] hw/i386/pc: Trivial cleanups

2024-03-01 Thread Philippe Mathieu-Daudé
Trivial cleanups, mostly around the 'isapc' machine. Philippe Mathieu-Daudé (4): hw/i386/pc: Remove pc_compat_1_4..1.7[] left over declarations hw/i386/pc: Use generated NotifyVmexitOption_str() hw/i386/pc: Remove 'host_type' argument from pc_init1() hw/i386/pc: Have pc_init_isa() pass a

[PATCH 2/4] hw/i386/pc: Use generated NotifyVmexitOption_str()

2024-03-01 Thread Philippe Mathieu-Daudé
NotifyVmexitOption_str() is QAPI-generated in "qapi/qapi-types-run-state.h", which "sysemu/runstate.h" already includes. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc_piix.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index

[PATCH 4/4] hw/i386/pc: Have pc_init_isa() pass a NULL pci_type argument

2024-03-01 Thread Philippe Mathieu-Daudé
The "isapc" machine only provides an ISA bus, not a PCI one, and doesn't instanciate any i440FX south bridge. Its machine class defines PCMachineClass::pci_enabled = false, and pc_init1() only uses the pci_type argument when pci_enabled is true. Since for this machine the argument is not used,

Re: [Stable-7.2.10 v1 00/47] Patch Round-up for stable 7.2.10, freeze on 2024-03-02

2024-03-01 Thread Michael Tokarev
01.03.2024 22:04, Cole Robinson wrote: Patch freeze is 2024-03-02, and the release is planned for 2024-03-04: ... Response might be too late, But here's the patches we are still carrying in Fedora 38 7.2.X and the explanations Nah, we've whole day left before the freeze. * abe2c4bdb6

Re: [RFC PATCH v5 12/22] target/arm: Handle NMI in arm_cpu_do_interrupt_aarch64()

2024-03-01 Thread Richard Henderson
On 2/29/24 17:42, Jinjie Ruan wrote: On 2024/3/1 7:09, Richard Henderson wrote: On 2/29/24 03:10, Jinjie Ruan via wrote: According to Arm GIC section 4.6.3 Interrupt superpriority, the interrupt with superpriority is always IRQ, never FIQ, so the NMI exception trap entry behave like IRQ.

Re: Intention to work on GSoC project

2024-03-01 Thread Sahil
Hi, On Friday, March 1, 2024 1:10:49 PM IST you wrote: > [...] > You can add the recently published > "virtio-live-migration-technical-deep-dive" :) [1]. > > [1] > https://developers.redhat.com/articles/2024/02/21/virtio-live-migration-technical-deep-dive Thank you. This resource will help me

Re: [PATCH v1 0/5] hw/ppc: SPI model

2024-03-01 Thread Chalapathi V
On 01-03-2024 22:06, Cédric Le Goater wrote: Chalapathi, On 3/1/24 17:17, Chalapathi V wrote: Hello, I would greatly appreciate the review comments/suggestions on PATCH V1. Thank You and Regards, I didn't forget but I lacked the time in this release cycle. Sorry about that. I have one

[PATCH 2/8] target/arm: Timer _EL02 registers UNDEF for E2H == 0

2024-03-01 Thread Peter Maydell
The timer _EL02 registers should UNDEF for invalid accesses from EL2 or EL3 when HCR_EL2.E2H == 0, not take a cp access trap. We were delivering the exception to EL2 with the wrong syndrome. Signed-off-by: Peter Maydell --- target/arm/helper.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 1/8] target/arm: Move some register related defines to internals.h

2024-03-01 Thread Peter Maydell
cpu.h has a lot of #defines relating to CPU register fields. Most of these aren't actually used outside target/arm code, so there's no point in cluttering up the cpu.h file with them. Move some easy ones to internals.h. Signed-off-by: Peter Maydell --- I want to add some more CNTHCTL_* values,

Re: [PATCH 1/8] target/arm: Move some register related defines to internals.h

2024-03-01 Thread Philippe Mathieu-Daudé
On 1/3/24 19:32, Peter Maydell wrote: cpu.h has a lot of #defines relating to CPU register fields. Most of these aren't actually used outside target/arm code, so there's no point in cluttering up the cpu.h file with them. Move some easy ones to internals.h. Signed-off-by: Peter Maydell --- I

Re: [PATCH v2 0/3] target/arm: Allow compilation without CONFIG_ARM_V7M

2024-03-01 Thread Thomas Huth
On 29/01/2024 09.18, Thomas Huth wrote: We've got a switch to disable v7m code since a long time - but it currently cannot be disabled since linking then fails due to missing functions. But thanks to the clean-ups that have been done during the past years, it's not that difficult anymore to

Re: [RFC 1/8] virtio/virtio-pci: Handle extra notification data

2024-03-01 Thread Eugenio Perez Martin
On Fri, Mar 1, 2024 at 2:44 PM Jonah Palmer wrote: > > Add support to virtio-pci devices for handling the extra data sent > from the driver to the device when the VIRTIO_F_NOTIFICATION_DATA > transport feature has been negotiated. > > The extra data that's passed to the virtio-pci device when

[PATCH v2 5/7] qga/commands-posix: execute_fsfreeze_hook: use ga_run_command helper

2024-03-01 Thread Andrey Drobyshev
There's no need to check for the existence of the hook executable, as the exec() call will do that for us. Signed-off-by: Andrey Drobyshev --- qga/commands-posix.c | 35 +++ 1 file changed, 3 insertions(+), 32 deletions(-) diff --git a/qga/commands-posix.c

[PATCH v2 1/7] qga: guest-get-fsinfo: add optional 'total-bytes-root' field

2024-03-01 Thread Andrey Drobyshev
Since the commit 25b5ff1a86 ("qga: add mountpoint usage info to GuestFilesystemInfo") we have 2 values reported in guest-get-fsinfo: used = (f_blocks - f_bfree), total = (f_blocks - f_bfree + f_bavail) as returned by statvfs(3). While on Windows guests that's all we can get with

[PATCH v2 6/7] qga/commands-posix: use ga_run_command helper when suspending via sysfs

2024-03-01 Thread Andrey Drobyshev
We replace the direct call to open() with a "sh -c 'echo ...'" call, so that it becomes an executable command. Signed-off-by: Andrey Drobyshev --- qga/commands-posix.c | 36 1 file changed, 4 insertions(+), 32 deletions(-) diff --git a/qga/commands-posix.c

[PATCH v2 7/7] qga/commands-posix: qmp_guest_set_user_password: use ga_run_command helper

2024-03-01 Thread Andrey Drobyshev
There's no need to check for the existence of the "chpasswd", "pw" executables, as the exec() call will do that for us. Signed-off-by: Andrey Drobyshev --- qga/commands-posix.c | 96 ++-- 1 file changed, 13 insertions(+), 83 deletions(-) diff --git

  1   2   3   4   >