[PATCH v10 6/7] vfio-user: Message-based DMA support

2024-05-07 Thread Mattias Nissler
Wire up support for DMA for the case where the vfio-user client does not provide mmap()-able file descriptors, but DMA requests must be performed via the VFIO-user protocol. This installs an indirect memory region, which already works for pci_dma_{read,write}, and pci_dma_map works thanks to the

[PULL 6/9] target/sh4: Update DisasContextBase.insn_start

2024-05-07 Thread Richard Henderson
Match the extra inserts of INDEX_op_insn_start, fixing the db->num_insns != 1 assert in translator_loop. Fixes: dcd092a0636 ("accel/tcg: Improve can_do_io management") Signed-off-by: Richard Henderson --- target/sh4/translate.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v10 7/7] vfio-user: Fix config space access byte order

2024-05-07 Thread Mattias Nissler
PCI config space is little-endian, so on a big-endian host we need to perform byte swaps for values as they are passed to and received from the generic PCI config space access machinery. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi Reviewed-by: Jagannathan Raman

Re: [PATCH v10 01/10] virtio-gpu: Unrealize GL device

2024-05-07 Thread Marc-André Lureau
Hi On Sun, May 5, 2024 at 12:29 AM Dmitry Osipenko wrote: > > Even though GL GPU doesn't support hotplugging today, free virgl > resources when GL device is unrealized. For consistency. > > Signed-off-by: Dmitry Osipenko > --- > hw/display/virtio-gpu-gl.c | 11 +++ >

Re: [PATCH v10 02/10] virtio-gpu: Use pkgconfig version to decide which virgl features are available

2024-05-07 Thread Marc-André Lureau
Hi On Sun, May 5, 2024 at 12:29 AM Dmitry Osipenko wrote: > > New virglrerenderer features were stabilized with release of v1.0.0. > Presence of symbols in virglrenderer.h doesn't guarantee ABI compatibility > with pre-release development versions of libvirglerender. Use virglrenderer > version

Re: [RFC PATCH 0/1] pci: allocate a PCI ID for RISC-V IOMMU

2024-05-07 Thread Peter Maydell
On Fri, 3 May 2024 at 13:43, Daniel Henrique Barboza wrote: > > Hi, > > In this RFC I want to check with Gerd and others if it's ok to add a PCI > id for the RISC-V IOMMU device. It's currently under review in [1]. The > idea is to fold this patch into the RISC-V IOMMU series if we're all ok >

Re: [PATCH v2 26/28] target/ppc/mmu_common.c: Move BookE MMU functions together

2024-05-07 Thread BALATON Zoltan
On Tue, 7 May 2024, Nicholas Piggin wrote: What do you think about adding mmu-book3e.c instead? Now I remember that besides possible performance loss because of loss of automatic inline if not all functions are static the other reason was that these functions use mmu_ctx_t that I don't want

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-07 Thread Peter Xu
On Tue, May 07, 2024 at 01:50:43AM +, Gonglei (Arei) wrote: > Hello, > > > -Original Message- > > From: Peter Xu [mailto:pet...@redhat.com] > > Sent: Monday, May 6, 2024 11:18 PM > > To: Gonglei (Arei) > > Cc: Daniel P. Berrangé ; Markus Armbruster > > ; Michael Galaxy ; Yu Zhang > >

[PULL 5/9] accel/tcg: Introduce CF_BP_PAGE

2024-05-07 Thread Richard Henderson
Record the fact that we've found a breakpoint on the page in which a TranslationBlock is running. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- include/exec/translation-block.h | 1 + accel/tcg/cpu-exec.c | 2 +- 2 files changed, 2 insertions(+), 1

[PATCH v10 4/7] softmmu: Support concurrent bounce buffers

2024-05-07 Thread Mattias Nissler
When DMA memory can't be directly accessed, as is the case when running the device model in a separate process without shareable DMA file descriptors, bounce buffering is used. It is not uncommon for device models to request mapping of several DMA regions at the same time. Examples include: *

Re: [PATCH v2 08/10] i386/sev: Implement ConfidentialGuestSupport functions for SEV

2024-05-07 Thread Roy Hopkins
On Tue, 2024-04-16 at 15:30 +0100, Daniel P. Berrangé wrote: > On Wed, Apr 03, 2024 at 12:11:39PM +0100, Roy Hopkins wrote: > > The ConfidentialGuestSupport object defines a number of virtual > > functions that are called during processing of IGVM directives to query > > or configure initial guest

[PULL 9/9] gitlab: Streamline ubuntu-22.04-s390x

2024-05-07 Thread Richard Henderson
We have one job to build user binaries and one job for system. Disable tools and docs in the user job, and disable building the user binaries in the system job. Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson ---

[PATCH v10 5/7] Update subprojects/libvfio-user

2024-05-07 Thread Mattias Nissler
Brings in assorted bug fixes. The following are of particular interest with respect to message-based DMA support: * bb308a2 "Fix address calculation for message-based DMA" Corrects a bug in DMA address calculation. * 1569a37 "Pass server->client command over a separate socket pair" Adds

Re: [PULL v2 03/16] block/block-backend: add block layer APIs resembling Linux ZonedBlockDevice ioctls

2024-05-07 Thread Stefan Hajnoczi
On Fri, May 03, 2024 at 01:33:51PM +0100, Peter Maydell wrote: > On Mon, 15 May 2023 at 17:07, Stefan Hajnoczi wrote: > > > > From: Sam Li > > > > Add zoned device option to host_device BlockDriver. It will be presented > > only > > for zoned host block devices. By adding zone management

Re: [PATCH v10 02/10] virtio-gpu: Use pkgconfig version to decide which virgl features are available

2024-05-07 Thread Marc-André Lureau
Hi On Tue, May 7, 2024 at 7:18 PM Marc-André Lureau wrote: > > Hi > > On Sun, May 5, 2024 at 12:29 AM Dmitry Osipenko > wrote: > > > > New virglrerenderer features were stabilized with release of v1.0.0. > > Presence of symbols in virglrenderer.h doesn't guarantee ABI compatibility > > with

Re: [RFC PATCH 0/1] pci: allocate a PCI ID for RISC-V IOMMU

2024-05-07 Thread Frank Chang
Hi Daniel, Daniel Henrique Barboza 於 2024年5月3日 週五 下午8:43寫道: > > Hi, > > In this RFC I want to check with Gerd and others if it's ok to add a PCI > id for the RISC-V IOMMU device. It's currently under review in [1]. The Is the link [1] missing? Regards, Frank Chang > idea is to fold this patch

Re: [PATCH] sh4: select correct components for no-board build

2024-05-07 Thread Alex Bennée
Paolo Bonzini writes: > Signed-off-by: Paolo Bonzini Acked-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v6 0/9] TCG plugins new inline operations

2024-05-07 Thread Alex Bennée
Pierrick Bouvier writes: > This series implement two new operations for plugins: > - Store inline allows to write a specific value to a scoreboard. > - Conditional callback executes a callback only when a given condition is > true. > The condition is evaluated inline. > > It's possible to mix

Re: [RFC PATCH v3 3/5] KVM: x86: Add notifications for Heki policy configuration and violation

2024-05-07 Thread Sean Christopherson
On Tue, May 07, 2024, Mickaël Salaün wrote: > > Actually, potential bad/crazy idea. Why does the _host_ need to define > > policy? > > Linux already knows what assets it wants to (un)protect and when. What's > > missing > > is a way for the guest kernel to effectively deprivilege and

Re: [PATCH 1/3] system/physmem: Replace qemu_mutex_lock() calls with QEMU_LOCK_GUARD

2024-05-07 Thread Richard Henderson
On 5/7/24 05:30, Philippe Mathieu-Daudé wrote: Simplify cpu_[un]register_map_client() and cpu_notify_map_clients() by replacing the pair of qemu_mutex_lock/qemu_mutex_unlock calls by the WITH_QEMU_LOCK_GUARD() macro. Signed-off-by: Philippe Mathieu-Daudé --- system/physmem.c | 9 +++-- 1

Re: [PATCH v2 27/28] target/ppc: Remove id_tlbs flag from CPU env

2024-05-07 Thread BALATON Zoltan
On Tue, 7 May 2024, Nicholas Piggin wrote: On Thu May 2, 2024 at 9:43 AM AEST, BALATON Zoltan wrote: This flag for split instruction/data TLBs is only set for 6xx soft TLB MMU model and not used otherwise so no need to have a separate flag for that. Signed-off-by: BALATON Zoltan ---

Re: [PATCH RFC 00/26] Multifd  device state transfer support with VFIO consumer

2024-05-07 Thread Peter Xu
On Tue, May 07, 2024 at 11:41:05AM +0300, Avihai Horon wrote: > Yes, I was working on parallel VFIO migration, but in a different approach > (not over multifd) which I'm not sure is relevant to this series. > I've been skimming over your discussions but haven't had the time to go over > Maciej's

Re: [PATCH v4 15/17] xen: mapcache: Remove assumption of RAMBlock with 0 offset

2024-05-07 Thread Edgar E. Iglesias
On Thu, May 2, 2024 at 10:02 PM Stefano Stabellini wrote: > > On Thu, 2 May 2024, Edgar E. Iglesias wrote: > > On Thu, May 2, 2024 at 8:53 PM Stefano Stabellini > > wrote: > > > > > > +Xenia > > > > > > On Thu, 2 May 2024, Edgar E. Iglesias wrote: > > > > On Wed, May 1, 2024 at 11:24 PM Stefano

[PATCH] qemu-io: add cvtnum() error handling for zone commands

2024-05-07 Thread Stefan Hajnoczi
cvtnum() parses positive int64_t values and returns a negative errno on failure. Print errors and return early when cvtnum() fails. While we're at it, also reject nr_zones values greater or equal to 2^32 since they cannot be represented. Reported-by: Peter Maydell Cc: Sam Li Signed-off-by:

[PATCH v10 0/7] Support message-based DMA in vfio-user server

2024-05-07 Thread Mattias Nissler
This series adds basic support for message-based DMA in qemu's vfio-user server. This is useful for cases where the client does not provide file descriptors for accessing system memory via memory mappings. My motivating use case is to hook up device models as PCIe endpoints to a hardware design.

Re: [PATCH v9 2/5] softmmu: Support concurrent bounce buffers

2024-05-07 Thread Philippe Mathieu-Daudé
On 7/5/24 16:04, Mattias Nissler wrote: On Tue, May 7, 2024 at 2:57 PM Philippe Mathieu-Daudé wrote: On 7/5/24 11:42, Mattias Nissler wrote: When DMA memory can't be directly accessed, as is the case when running the device model in a separate process without shareable DMA file descriptors,

Re: [PATCH] ui/gtk: Explicitly set the default size of new window when untabifying

2024-05-07 Thread Marc-André Lureau
Hi On Wed, May 1, 2024 at 7:47 AM wrote: > > From: Dongwon Kim > > When untabifying, the default size of the new window was inadvertently > set to the size smaller than quarter of the primary window size due > to lack of explicit configuration. This commit addresses the issue by > ensuring that

Re: [PATCH v2 20/28] target/ppc/mmu_common.c: Make get_physical_address_wtlb() static

2024-05-07 Thread BALATON Zoltan
On Tue, 7 May 2024, Nicholas Piggin wrote: On Thu May 2, 2024 at 9:43 AM AEST, BALATON Zoltan wrote: This function is not used from any other files so make it static and fix the maybe used uninitialised warnings this has uncovered. Signed-off-by: BALATON Zoltan --- target/ppc/internal.h |

Re: [PATCH] target/loongarch/kvm: Fix VM recovery from disk failures

2024-05-07 Thread Peter Xu
On Tue, May 07, 2024 at 04:12:34PM +0800, gaosong wrote: > Just remove CONIFG_KVM  would be OK? You're the loongarch maintainer so I'd say your call. :) If you're not yet sure, IMHO we should go with the simplest, which is the original oneliner patch. Thanks, -- Peter Xu

Re: [PATCH v2] mem/cxl_type3: support 3, 6, 12 and 16 interleave ways

2024-05-07 Thread Jonathan Cameron via
On Tue, 7 May 2024 00:22:00 + "Xingtao Yao (Fujitsu)" wrote: > > -Original Message- > > From: Jonathan Cameron > > Sent: Tuesday, April 30, 2024 10:43 PM > > To: Yao, Xingtao/姚 幸涛 > > Cc: fan...@samsung.com; qemu-devel@nongnu.org > > Subject: Re: [PATCH v2] mem/cxl_type3: support

RE: [PATCH] ui/gtk: Explicitly set the default size of new window when untabifying

2024-05-07 Thread Kim, Dongwon
Hi Marc-André, > -Original Message- > From: Marc-André Lureau > Sent: Tuesday, May 7, 2024 8:10 AM > To: Kim, Dongwon > Cc: qemu-devel@nongnu.org; kra...@redhat.com > Subject: Re: [PATCH] ui/gtk: Explicitly set the default size of new window > when > untabifying > > Hi > > On Wed,

Re: [PATCH v6 0/9] TCG plugins new inline operations

2024-05-07 Thread Pierrick Bouvier
On 5/7/24 09:07, Alex Bennée wrote: Pierrick Bouvier writes: This series implement two new operations for plugins: - Store inline allows to write a specific value to a scoreboard. - Conditional callback executes a callback only when a given condition is true. The condition is evaluated

[PULL 1/9] tcg: Add write_aofs to GVecGen3i

2024-05-07 Thread Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- include/tcg/tcg-op-gvec-common.h | 2 ++ tcg/tcg-op-gvec.c| 30 ++ 2 files changed, 24 insertions(+), 8 deletions(-) diff --git a/include/tcg/tcg-op-gvec-common.h

[PULL 2/9] tcg/i386: Simplify immediate 8-bit logical vector shifts

2024-05-07 Thread Richard Henderson
The x86 isa does not have this operation, so we need an expansion. Use the same algorithm that we use for expanding this vector operation with integers: perform the shift with a wider type and then mask the bits that must be zero. This reduces the instruction count from 5 to 2. Signed-off-by:

[PULL 4/9] tcg/optimize: Optimize setcond with zmask

2024-05-07 Thread Richard Henderson
If we can show that high bits of an input are zero, then we may optimize away some comparisons. Signed-off-by: Richard Henderson --- tcg/optimize.c | 110 + 1 file changed, 110 insertions(+) diff --git a/tcg/optimize.c b/tcg/optimize.c index

[PULL 8/9] gitlab: Drop --static from s390x linux-user build

2024-05-07 Thread Richard Henderson
The host does not have the correct libraries installed for static pie, which causes host/guest address space interference for some tests. There's no real gain from linking statically, so drop it. Reviewed-by: Thomas Huth Signed-off-by: Richard Henderson ---

Re: [PATCH v2 06/10] i386/pc_sysfw: Ensure sysfw flash configuration does not conflict with IGVM

2024-05-07 Thread Roy Hopkins
On Thu, 2024-04-04 at 18:06 +0530, Ani Sinha wrote: > > > > On 3 Apr 2024, at 16:41, Roy Hopkins wrote: > > > > When using an IGVM file the configuration of the system firmware is > > defined by IGVM directives contained in the file. In this case the user > > should not configure any pflash

[PATCH] loongarch64: move memory map to boot.c

2024-05-07 Thread Paolo Bonzini
Ensure that it can be used even if virt.c is not included in the build, as is the case for --without-default-devices. Signed-off-by: Paolo Bonzini --- include/hw/loongarch/boot.h | 10 ++ include/hw/loongarch/virt.h | 10 -- hw/loongarch/boot.c | 3 +++

Re: [PATCH v2 15/15] hw/misc: EDU: add ATS/PRI capability

2024-05-07 Thread Frank Chang
Hi Daniel, Daniel Henrique Barboza 於 2024年3月8日 週五 上午12:05寫道: > > From: Tomasz Jeznach > > Mimic ATS interface with IOMMU translate request with IOMMU_NONE. If > mapping exists, translation service will return current permission > flags, otherwise will report no permissions. > > Implement and

Re: [RFC PATCH 0/1] pci: allocate a PCI ID for RISC-V IOMMU

2024-05-07 Thread Gerd Hoffmann
On Tue, May 07, 2024 at 11:37:05PM GMT, Frank Chang wrote: > Hi Daniel, > > Daniel Henrique Barboza 於 2024年5月3日 週五 下午8:43寫道: > > > > Hi, > > > > In this RFC I want to check with Gerd and others if it's ok to add a PCI > > id for the RISC-V IOMMU device. It's currently under review in [1]. The >

Re: [PATCH] target/loongarch/kvm: Fix VM recovery from disk failures

2024-05-07 Thread Peter Maydell
On Tue, 7 May 2024 at 16:47, Peter Xu wrote: > > On Tue, May 07, 2024 at 04:12:34PM +0800, gaosong wrote: > > Just remove CONIFG_KVM would be OK? > > You're the loongarch maintainer so I'd say your call. :) > > If you're not yet sure, IMHO we should go with the simplest, which is the > original

Re: [PATCH] misc: Use QEMU header path relative to include/ directory

2024-05-07 Thread Richard Henderson
On 5/7/24 07:27, Philippe Mathieu-Daudé wrote: QEMU headers are relative to the include/ directory, not to the project root directory. Remove "include/". See also: https://www.qemu.org/docs/master/devel/style.html#include-directives Signed-off-by: Philippe Mathieu-Daudé ---

Re: [PATCH] loongarch64: move memory map to boot.c

2024-05-07 Thread Richard Henderson
On 5/7/24 07:51, Paolo Bonzini wrote: Ensure that it can be used even if virt.c is not included in the build, as is the case for --without-default-devices. Signed-off-by: Paolo Bonzini --- include/hw/loongarch/boot.h | 10 ++ include/hw/loongarch/virt.h | 10 --

Re: [PATCH v2 04/33] accel/tcg: Reorg translator_ld*

2024-05-07 Thread Richard Henderson
On 5/6/24 15:47, Philippe Mathieu-Daudé wrote: On 25/4/24 01:31, Richard Henderson wrote: Reorg translator_access into translator_ld, with a more memcpy-ish interface.  If both pages are in ram, do not go through the caller's slow path. Assert that the access is within the two pages that we

Re: [PATCH 1/4] hw/misc: Create STM32L4x5 SYSCFG clock

2024-05-07 Thread Inès Varhol
- Le 7 Mai 24, à 11:50, peter maydell peter.mayd...@linaro.org a écrit : > On Sun, 5 May 2024 at 15:06, Inès Varhol wrote: >> >> Signed-off-by: Inès Varhol > > In general you should try to avoid commits with no commit message. > Sometimes there really isn't anything to say beyond what

[PATCH] misc: Use QEMU header path relative to include/ directory

2024-05-07 Thread Philippe Mathieu-Daudé
QEMU headers are relative to the include/ directory, not to the project root directory. Remove "include/". See also: https://www.qemu.org/docs/master/devel/style.html#include-directives Signed-off-by: Philippe Mathieu-Daudé --- hw/audio/virtio-snd.c | 2 +- hw/rtc/ls7a_rtc.c | 2 +-

[PATCH v10 3/7] system/physmem: Per-AddressSpace bounce buffering

2024-05-07 Thread Mattias Nissler
Instead of using a single global bounce buffer, give each AddressSpace its own bounce buffer. The MapClient callback mechanism moves to AddressSpace accordingly. This is in preparation for generalizing bounce buffer handling further to allow multiple bounce buffers, with a total allocation limit

[PATCH v10 2/7] system/physmem: Propagate AddressSpace to MapClient helpers

2024-05-07 Thread Mattias Nissler
Propagate AddressSpace handler to following helpers: - register_map_client() - unregister_map_client() - notify_map_clients[_locked]() Rename them using 'address_space_' prefix instead of 'cpu_'. The AddressSpace argument will be used in the next commit. Reviewed-by: Peter Xu Tested-by:

[PULL 3/9] tcg/i386: Optimize setcond of TST{EQ,NE} with 0xffffffff

2024-05-07 Thread Richard Henderson
This may be treated as a 32-bit EQ/NE comparison against 0, which is in turn treated as a LTU/GEU comparison against 1. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c.inc | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-)

[PULL 0/9] tcg + misc patch queue

2024-05-07 Thread Richard Henderson
The following changes since commit d4c453f64824bbeec56c7e72aa83019a7db70d9e: Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2024-05-06 08:34:34 -0700) are available in the Git repository at: https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20240507 for you

Re: [PATCH] misc: Use QEMU header path relative to include/ directory

2024-05-07 Thread Peter Maydell
On Tue, 7 May 2024 at 15:28, Philippe Mathieu-Daudé wrote: > > QEMU headers are relative to the include/ directory, > not to the project root directory. Remove "include/". > > See also: > https://www.qemu.org/docs/master/devel/style.html#include-directives > > Signed-off-by: Philippe

[PATCH v10 1/7] system/physmem: Replace qemu_mutex_lock() calls with QEMU_LOCK_GUARD

2024-05-07 Thread Mattias Nissler
From: Philippe Mathieu-Daudé From: Philippe Mathieu-Daudé Simplify cpu_[un]register_map_client() and cpu_notify_map_clients() by replacing the pair of qemu_mutex_lock/qemu_mutex_unlock calls by the WITH_QEMU_LOCK_GUARD() macro. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Mattias

[PULL 7/9] gitlab: Drop --disable-libssh from ubuntu-22.04-s390x.yml

2024-05-07 Thread Richard Henderson
This was a workaround for ubuntu 20.04. Suggested-by: Thomas Huth Signed-off-by: Richard Henderson --- .gitlab-ci.d/custom-runners/ubuntu-22.04-s390x.yml | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.gitlab-ci.d/custom-runners/ubuntu-22.04-s390x.yml

Re: [PATCH 1/4] migration: add "exists" info to load-state-field trace

2024-05-07 Thread Peter Xu
On Tue, May 07, 2024 at 03:19:17PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau Reviewed-by: Peter Xu -- Peter Xu

Re: [PATCH 2/3] vfio/migration: Emit VFIO device migration state change QAPI event

2024-05-07 Thread Avihai Horon
On 07/05/2024 18:51, Peter Xu wrote: External email: Use caution opening links or attachments On Tue, May 07, 2024 at 10:47:13AM +0300, Avihai Horon wrote: While at it, another trivial comment is maybe it's nice to have a helper to both update the vfio migration state, plus emitting events

[PATCH] gitlab: Update msys2-64bit runner tags

2024-05-07 Thread Richard Henderson
Gitlab has deprecated and removed support for windows-1809 and shared-windows. Update to saas-windows-medium-amd64 per https://about.gitlab.com/blog/2024/01/22/windows-2022-support-for-gitlab-saas-runners/ Signed-off-by: Richard Henderson --- .gitlab-ci.d/windows.yml | 4 +--- 1 file changed,

Re: [PATCH v2 04/10] backends/igvm: Implement parsing and processing of IGVM files

2024-05-07 Thread Roy Hopkins
On Tue, 2024-04-16 at 15:05 +0100, Daniel P. Berrangé wrote: > On Wed, Apr 03, 2024 at 12:11:35PM +0100, Roy Hopkins wrote: > > This commit adds an implementation of an IGVM loader which parses the > > file specified as a pararameter to ConfidentialGuestSupport and provides > > a function that

Re: [PATCH] target/sh4: Update DisasContextBase.insn_start

2024-05-07 Thread Philippe Mathieu-Daudé
On 6/5/24 21:55, Richard Henderson wrote: Match the extra inserts of INDEX_op_insn_start, Maybe insert here: (see commit e03291cd9a "Emit insn_start for each insn in gUSA region") fixing the db->num_insns != 1 assert in translator_loop. Fixes: dcd092a0636 ("accel/tcg: Improve can_do_io

[PATCH] sh4: select correct components for no-board build

2024-05-07 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- .gitlab-ci.d/buildtest.yml | 5 +++-- hw/sh4/meson.build | 2 +- target/sh4/Kconfig | 2 ++ 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index bab61945643..13afd0df1f0

Re: [PATCH v2] ui/gtk: Draw guest frame at refresh cycle

2024-05-07 Thread Marc-André Lureau
On Sat, Apr 27, 2024 at 2:56 AM wrote: > > From: Dongwon Kim > > Draw routine needs to be manually invoked in the next refresh > if there is a scanout blob from the guest. This is to prevent > a situation where there is a scheduled draw event but it won't > happen bacause the window is currently

Re: [RFC PATCH 1/1] pci-ids.rst: add Red Hat pci-id for generic IOMMU device

2024-05-07 Thread Frank Chang
Hi Daniel, It's glad to see that we have the dedicate PCIe device ID for RISC-V IOMMU. Reviewed-by: Frank Chang Daniel Henrique Barboza 於 2024年5月3日 週五 下午8:44寫道: > > Reserve an id to be used by the RISC-V IOMMU PCI device. > > Cc: Gerd Hoffmann > Signed-off-by: Daniel Henrique Barboza > ---

Re: [PATCH 2/3] vfio/migration: Emit VFIO device migration state change QAPI event

2024-05-07 Thread Peter Xu
On Tue, May 07, 2024 at 10:47:13AM +0300, Avihai Horon wrote: > > While at it, another trivial comment is maybe it's nice to have a helper to > > both update the vfio migration state, plus emitting events when necessary. > > I think vfio_migration_set_state() does exactly that, no? Ah yes, looks

Re: [PULL 0/9] tcg + misc patch queue

2024-05-07 Thread Richard Henderson
/qemu.git tags/pull-tcg-20240507 for you to fetch changes up to f578b66e8c70ddea71d44db6e2c7abbcd757d684: gitlab: Streamline ubuntu-22.04-s390x (2024-05-06 23:40:36 -0700) tcg: Add write_aofs to GVecGen3i tcg/i386: Simplify

Re: [PATCH RFC 00/26] Multifd  device state transfer support with VFIO consumer

2024-05-07 Thread Avihai Horon
On 07/05/2024 19:13, Peter Xu wrote: External email: Use caution opening links or attachments On Tue, May 07, 2024 at 11:41:05AM +0300, Avihai Horon wrote: Yes, I was working on parallel VFIO migration, but in a different approach (not over multifd) which I'm not sure is relevant to this

Re: [PATCH] hw/virtio: Fix obtain the buffer id from the last descriptor

2024-05-07 Thread Jason Wang
On Mon, Apr 22, 2024 at 9:41 AM Wafer wrote: > > The virtio-1.3 specification > writes: > 2.8.6 Next Flag: Descriptor Chaining > Buffer ID is included in the last descriptor in the list. > > If the feature (_F_INDIRECT_DESC)

Re: How unsubscribe

2024-05-07 Thread Thomas Huth
On 08/05/2024 00.20, Jean-Christophe wrote: Hello, How unsubscribe ? Go to https://lists.nongnu.org/mailman/listinfo/qemu-devel and look at the bottom. HTH, Thomas

[PATCH] scripts/simpletrace: Mark output with unstable timestamp as WARN

2024-05-07 Thread Zhao Liu
In some trace log, there're unstable timestamp breaking temporal ordering of trace records. For example: kvm_run_exit -0.015 pid=3289596 cpu_index=0x0 reason=0x6 kvm_vm_ioctl -0.020 pid=3289596 type=0xc008ae67 arg=0x7ffeefb5aa60 kvm_vm_ioctl -0.021 pid=3289596 type=0xc008ae67

Re: [PATCH v10 1/7] system/physmem: Replace qemu_mutex_lock() calls with QEMU_LOCK_GUARD

2024-05-07 Thread Peter Xu
On Tue, May 07, 2024 at 07:34:25AM -0700, Mattias Nissler wrote: > From: Philippe Mathieu-Daudé > > From: Philippe Mathieu-Daudé > > Simplify cpu_[un]register_map_client() and cpu_notify_map_clients() > by replacing the pair of qemu_mutex_lock/qemu_mutex_unlock calls by > the

Re: [PATCH v10 4/7] softmmu: Support concurrent bounce buffers

2024-05-07 Thread Peter Xu
On Tue, May 07, 2024 at 07:34:28AM -0700, Mattias Nissler wrote: > When DMA memory can't be directly accessed, as is the case when > running the device model in a separate process without shareable DMA > file descriptors, bounce buffering is used. > > It is not uncommon for device models to

Re: [PATCH v2 3/4] hw/nvme: Support SR-IOV VFs more than 127

2024-05-07 Thread Minwoo Im
On 24-05-01 14:46:39, Klaus Jensen wrote: > On Apr 1 04:30, Minwoo Im wrote: > > From: Minwoo Im > > > > The number of virtual functions(VFs) supported in SR-IOV is 64k as per > > spec. To test a large number of MSI-X vectors mapping to CPU matrix in > > the QEMU system, we need much more than

RE: [PATCH 3/4] target/hexagon: idef-parser fix leak of init_list

2024-05-07 Thread ltaylorsimpson
> -Original Message- > From: 'Anton Johansson' > Sent: Tuesday, May 7, 2024 4:47 AM > To: ltaylorsimp...@gmail.com > Cc: qemu-devel@nongnu.org; a...@rev.ng; bc...@quicinc.com > Subject: Re: [PATCH 3/4] target/hexagon: idef-parser fix leak of init_list > > On 06/05/24,

Re: [PATCH V1 08/26] migration: vmstate_info_void_ptr

2024-05-07 Thread Fabiano Rosas
Steve Sistare writes: > Define VMSTATE_VOID_PTR so the value of a pointer (but not its target) > can be saved in the migration stream. This will be needed for CPR. > > Signed-off-by: Steve Sistare Reviewed-by: Fabiano Rosas

Re: [PATCH] qemu-io: add cvtnum() error handling for zone commands

2024-05-07 Thread Sam Li
Stefan Hajnoczi 于2024年5月7日周二 20:06写道: > > cvtnum() parses positive int64_t values and returns a negative errno on > failure. Print errors and return early when cvtnum() fails. > > While we're at it, also reject nr_zones values greater or equal to 2^32 > since they cannot be represented. > >

Re: [PULL 00/26] target/i386 changes for 2024-05-07

2024-05-07 Thread Richard Henderson
On 5/7/24 03:55, Paolo Bonzini wrote: The following changes since commit e116b92d01c2cd75957a9f8ad1d4932292867b81: Merge tag 'qemu-sparc-20240506' ofhttps://github.com/mcayland/qemu into staging (2024-05-06 10:19:56 -0700) are available in the Git repository at:

[PATCH 2/4] hw/gpio: Handle clock migration in STM32L4x5 gpios

2024-05-07 Thread Inès Varhol
STM32L4x5 GPIO wasn't migrating its clock. Signed-off-by: Inès Varhol --- hw/gpio/stm32l4x5_gpio.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/gpio/stm32l4x5_gpio.c b/hw/gpio/stm32l4x5_gpio.c index 71bf5fddb2..30d8d6cba4 100644 --- a/hw/gpio/stm32l4x5_gpio.c +++

[PATCH 1/4] hw/misc: Create STM32L4x5 SYSCFG clock

2024-05-07 Thread Inès Varhol
This commit creates a clock in STM32L4x5 SYSCFG and wires it up to the corresponding clock from STM32L4x5 RCC. A read-only QOM property allowing to read the clock frequency is added (it will be used in a QTest). Signed-off-by: Inès Varhol --- Hello, Several people noticed that replicating the

[PATCH 0/4] Check clock connection between STM32L4x5 RCC and peripherals

2024-05-07 Thread Inès Varhol
Among implemented STM32L4x5 devices, USART, GPIO and SYSCFG have a clock source, but none has a corresponding test in QEMU. This patch makes sure that all 3 devices create a clock, have a QOM property to access the clock frequency, and adds QTests checking that clock enable in RCC has the

[PATCH 4/4] tests/qtest: Check STM32L4x5 clock connections

2024-05-07 Thread Inès Varhol
For USART, GPIO and SYSCFG devices, check that clock frequency before and after enabling the peripheral clock in RCC is correct. Signed-off-by: Inès Varhol --- tests/qtest/stm32l4x5.h | 40 + tests/qtest/stm32l4x5_gpio-test.c | 23 +

[PATCH 3/4] hw/char: Add QOM property for STM32L4x5 USART clock frequency

2024-05-07 Thread Inès Varhol
This QOM property will be used to check the clock frequency from QTests. Signed-off-by: Inès Varhol --- hw/char/stm32l4x5_usart.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/hw/char/stm32l4x5_usart.c b/hw/char/stm32l4x5_usart.c index

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-07 Thread Cord Amfmgm
On Wed, Apr 24, 2024 at 3:43 PM Cord Amfmgm wrote: > On Thu, Apr 18, 2024 at 10:43 AM Michael Tokarev wrote: > >> 06.02.2024 10:13, Cord Amfmgm wrote: >> > This changes the ohci validation to not assert if invalid >> > data is fed to the ohci controller. The poc suggested in >> >

Re: [PATCH 4/4] virtio-gpu: add x-vmstate-version

2024-05-07 Thread Fabiano Rosas
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Machine <= 8.2 use v1. > > Signed-off-by: Marc-André Lureau Reviewed-by: Fabiano Rosas

How unsubscribe

2024-05-07 Thread Jean-Christophe
Hello,How unsubscribe ?Dear 

[PATCH v13 3/6] ui/console: Use qemu_dmabuf_get_..() helpers instead

2024-05-07 Thread dongwon . kim
From: Dongwon Kim This commit updates all instances where fields within the QemuDmaBuf struct are directly accessed, replacing them with calls to these new helper functions. v6: fix typos in helper names in ui/spice-display.c v7: removed prefix, "dpy_gl_" from all helpers v8: Introduction of

[PATCH v13 5/6] ui/console: Use qemu_dmabuf_new() and free() helpers instead

2024-05-07 Thread dongwon . kim
From: Dongwon Kim This commit introduces utility functions for the creation and deallocation of QemuDmaBuf instances. Additionally, it updates all relevant sections of the codebase to utilize these new utility functions. v7: remove prefix, "dpy_gl_" from all helpers qemu_dmabuf_free()

[PATCH v13 2/6] ui/console: new dmabuf.h and dmabuf.c for QemuDmaBuf struct and helpers

2024-05-07 Thread dongwon . kim
From: Dongwon Kim New header and source files are added for containing QemuDmaBuf struct definition and newly introduced helpers for creating/freeing the struct and accessing its data. v10: Change the license type for both dmabuf.h and dmabuf.c from MIT to GPL to be in line with QEMU's

[PATCH v13 4/6] ui/console: Use qemu_dmabuf_set_..() helpers instead

2024-05-07 Thread dongwon . kim
From: Dongwon Kim This commit updates all occurrences where these fields were set directly have been updated to utilize helper functions. v7: removed prefix, "dpy_gl_" from all helpers v8: Introduction of helpers was removed as those were already added by the previous commit Suggested-by:

[PATCH v13 1/6] ui/gtk: Check if fence_fd is equal to or greater than 0

2024-05-07 Thread dongwon . kim
From: Dongwon Kim 'fence_fd' needs to be validated always before being referenced And the passing condition should include '== 0' as 0 is a valid value for the file descriptor. Suggested-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Cc: Philippe Mathieu-Daudé Cc: Daniel P. Berrangé

[PATCH v13 0/6] ui/console: Private QemuDmaBuf struct

2024-05-07 Thread dongwon . kim
From: Your Name This series introduces privacy enhancements to the QemuDmaBuf struct and its contained data to bolster security. it accomplishes this by introducing of helper functions for allocating, deallocating, and accessing individual fields within the struct and replacing all direct

[PATCH v13 6/6] ui/console: move QemuDmaBuf struct def to dmabuf.c

2024-05-07 Thread dongwon . kim
From: Dongwon Kim To complete privatizing process of QemuDmaBuf, QemuDmaBuf struct def is moved to dmabuf.c Suggested-by: Marc-André Lureau Reviewed-by: Marc-André Lureau Cc: Philippe Mathieu-Daudé Cc: Daniel P. Berrangé Cc: Vivek Kasireddy Signed-off-by: Dongwon Kim ---

Re: [PATCH 3/4] virtio-gpu: use a VMState variant for the scanout field

2024-05-07 Thread Peter Xu
On Tue, May 07, 2024 at 03:19:19PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Depending on the version, use v1 or v2 of the scanout VM state. > > Signed-off-by: Marc-André Lureau > --- > hw/display/virtio-gpu.c | 22 +- > 1 file changed, 17

Re: [PATCH v10 0/7] Support message-based DMA in vfio-user server

2024-05-07 Thread Peter Xu
On Tue, May 07, 2024 at 07:34:24AM -0700, Mattias Nissler wrote: > This series adds basic support for message-based DMA in qemu's vfio-user > server. This is useful for cases where the client does not provide file > descriptors for accessing system memory via memory mappings. My motivating use >

Re: [PATCH 0/4] Fix "virtio-gpu: fix scanout migration post-load"

2024-05-07 Thread Fabiano Rosas
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Hi, > > The aforementioned patch breaks virtio-gpu device migrations for versions > pre-9.0/9.0, both forwards and backwards. Versioning of `VMS_STRUCT` is more > complex than it may initially appear, as evidenced in the

Re: [PATCH 1/1] vhost-vsock: add VIRTIO_F_RING_PACKED to feaure_bits

2024-05-07 Thread Halil Pasic
On Mon, 29 Apr 2024 13:33:34 +0200 Halil Pasic wrote: > Not having VIRTIO_F_RING_PACKED in feature_bits[] is a problem when the > vhost-vsock device does not offer the feature bit VIRTIO_F_RING_PACKED > but the in QEMU device is configured to try to use the packed layout > (the virtio property

Re: [PATCH V1 07/26] migration: VMStateId

2024-05-07 Thread Fabiano Rosas
Steve Sistare writes: > Define a type for the 256 byte id string to guarantee the same length is > used and enforced everywhere. > > Signed-off-by: Steve Sistare Reviewed-by: Fabiano Rosas

Re: [PATCH V1 05/26] migration: precreate vmstate

2024-05-07 Thread Fabiano Rosas
Steve Sistare writes: > Provide the VMStateDescription precreate field to mark objects that must > be loaded on the incoming side before devices have been created, because > they provide properties that will be needed at creation time. They will > be saved to and loaded from their own QEMUFile,

Re: [PATCH 0/4] Fix "virtio-gpu: fix scanout migration post-load"

2024-05-07 Thread Peter Xu
On Tue, May 07, 2024 at 05:46:36PM -0300, Fabiano Rosas wrote: > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > Hi, > > > > The aforementioned patch breaks virtio-gpu device migrations for versions > > pre-9.0/9.0, both forwards and backwards. Versioning of

Re: [PATCH] hw/loongarch/virt: Fix memory leak

2024-05-07 Thread Philippe Mathieu-Daudé
On 7/5/24 04:22, Song Gao wrote: The char pointer 'ramName' point to a block of memory, but never free it. Use 'g_autofree' to automatically free it. Resolves: Coverity CID 1544773 Fixes: 0cf1478d6 ("hw/loongarch: Add numa support") Signed-off-by: Song Gao --- hw/loongarch/virt.c | 3 +--

RE: [PATCH v2 03/11] vfio: Make VFIOIOMMUClass::attach_device() and its wrapper return bool

2024-05-07 Thread Duan, Zhenzhong
>-Original Message- >From: Cédric Le Goater >Subject: Re: [PATCH v2 03/11] vfio: Make VFIOIOMMUClass::attach_device() >and its wrapper return bool > >On 5/7/24 08:42, Zhenzhong Duan wrote: >> Make VFIOIOMMUClass::attach_device() and its wrapper function >> vfio_attach_device() return

Re: [PATCH 3/4] hw/xtensa: require libfdt

2024-05-07 Thread Philippe Mathieu-Daudé
On 7/5/24 09:19, Paolo Bonzini wrote: All other boards require libfdt if it can be used (including for example i386/x86_64), so change the "imply" to "select" and always allow -dtb in qemu-system-xtensa. Signed-off-by: Paolo Bonzini --- hw/xtensa/xtfpga.c | 9 - hw/xtensa/Kconfig |

Re: [PATCH 2/3] vfio/migration: Emit VFIO device migration state change QAPI event

2024-05-07 Thread Avihai Horon
On 06/05/2024 18:07, Peter Xu wrote: External email: Use caution opening links or attachments On Mon, May 06, 2024 at 11:38:00AM -0300, Fabiano Rosas wrote: Markus Armbruster writes: Peter, Fabiano, I'd like to hear your opinion on the issue discussed below. Avihai Horon writes: On

  1   2   3   4   >