Re: [Qemu-devel] [RFC PATCH 03/15] input: define event types using qapi

2013-12-03 Thread Gerd Hoffmann
On Mo, 2013-12-02 at 12:12 -0700, Eric Blake wrote: On 11/28/2013 07:29 AM, Gerd Hoffmann wrote: Define input event types, using qapi. So we get nicely autogenerated types for our input events. And when it comes to qmp support some day things will be alot easier. Types are modeled

Re: [Qemu-devel] [PATCHv2 00/14] Spice block device, ready-to-go patches

2013-12-03 Thread Gerd Hoffmann
Hi, Thanks, applied Patches 1 and 14 to my block tree: https://github.com/stefanha/qemu/commits/block Leaving the rest to Gerd and Paolo. Added 2-13 to the spice patch queue. cheers, Gerd

Re: [Qemu-devel] [PATCH v4 3/6] qemu-iotests: Add _default_cache_mode and _supported_cache_modes

2013-12-03 Thread Fam Zheng
On 2013年12月03日 14:05, Wenchao Xia wrote: Why forbid mode = writeback? These test cases used to run with only possibly writethrough, or none. And they don't work with writeback, at least in my case. So I didn't add other modes here. Fam

[Qemu-devel] [PATCH 2/5] hw/timer: add allwinner a10 timer

2013-12-03 Thread liguang
Signed-off-by: liguang lig.f...@cn.fujitsu.com --- default-configs/arm-softmmu.mak |2 + hw/timer/Makefile.objs |2 + hw/timer/allwinner-a10_pit.c | 253 ++ include/hw/timer/allwinner-a10_pit.h | 57 4 files changed,

[Qemu-devel] [PATCH 4/5] hw/arm: add allwinner a10 SoC support

2013-12-03 Thread liguang
Signed-off-by: liguang lig.f...@cn.fujitsu.com --- hw/arm/Makefile.objs |2 +- hw/arm/allwinner-a10.c | 39 +++ include/hw/arm/allwinner-a10.h | 27 +++ 3 files changed, 67 insertions(+), 1 deletions(-) create

[Qemu-devel] [PATCH 3/5] hw/intc: add allwinner A10 interrupt controller

2013-12-03 Thread liguang
Signed-off-by: liguang lig.f...@cn.fujitsu.com --- hw/intc/Makefile.objs |1 + hw/intc/allwinner-a10_pic.c | 218 +++ include/hw/intc/allwinner-a10_pic.h | 40 +++ 3 files changed, 259 insertions(+), 0 deletions(-) create mode

Re: [Qemu-devel] [PATCH v4 3/6] qemu-iotests: Add _default_cache_mode and _supported_cache_modes

2013-12-03 Thread Stefan Hajnoczi
On Tue, Dec 03, 2013 at 02:05:32PM +0800, Wenchao Xia wrote: This patch override only when default is specified, I am +1 with it. I think we had discuss before, just want a double check, stefan, do you agree with this? Yes, I'm happy with this. I just want to avoid test cases with custom code

Re: [Qemu-devel] [PATCH v4 3/6] qemu-iotests: Add _default_cache_mode and _supported_cache_modes

2013-12-03 Thread Kevin Wolf
Am 03.12.2013 um 09:21 hat Fam Zheng geschrieben: On 2013年12月03日 14:05, Wenchao Xia wrote: Why forbid mode = writeback? These test cases used to run with only possibly writethrough, or none. And they don't work with writeback, at least in my case. So I didn't add other modes

Re: [Qemu-devel] [PATCH 2/5] machine: introduce get_fw_dev_path() callback

2013-12-03 Thread Alexey Kardashevskiy
On 12/03/2013 08:11 PM, Markus Armbruster wrote: Alexey Kardashevskiy a...@ozlabs.ru writes: On 11/26/2013 03:55 PM, Alexey Kardashevskiy wrote: Hi! btw there is a problem with this patch - it does not compile for linux-user as there is no current-machine global variable defined in vl.c

Re: [Qemu-devel] [RFC PATCH v1 2/5] hw: Remove assert_no_error usages

2013-12-03 Thread Markus Armbruster
Peter Crosthwaite peter.crosthwa...@xilinx.com writes: Replace assert_no_error() usages with the error_abort system. error_abort is passed into API calls to signal to the Error sub-system that any errors are fatal. Removes need for caller assertions. Signed-off-by: Peter Crosthwaite

Re: [Qemu-devel] [PATCH 2/5] machine: introduce get_fw_dev_path() callback

2013-12-03 Thread Paolo Bonzini
Il 25/11/2013 08:27, Alexey Kardashevskiy ha scritto: QEMU supports firmware names for all devices in the QEMU tree but sometime the exact format differs from what sPAPR platform uses. This introduces a callback to let a machine fix device tree path names. Signed-off-by: Alexey

Re: [Qemu-devel] [RFC PATCH v1 4/5] qemu-option: Remove qemu_opts_create_nofail

2013-12-03 Thread Markus Armbruster
Peter Crosthwaite peter.crosthwa...@xilinx.com writes: This is a boiler-plate _nofail variant of qemu_opts_create. Remove and use error_abort in call sites. A null argument needs to be added for the id field in affected callsites due to inconsistency between the normal and no_fail variants.

Re: [Qemu-devel] [RFC PATCH v1 0/5] Add error_abort and associated cleanups

2013-12-03 Thread Markus Armbruster
Peter Crosthwaite peter.crosthwa...@xilinx.com writes: Following our discussion RE self asserting API calls, here is a spin of my proposal. This series obsoletes the need for _nofail variants for Error ** accepting APIs. Is also greately reduces the verbosity of calls sites that are currently

[Qemu-devel] [Bug 1256826] Re: INT instruction bug in WindowsXP

2013-12-03 Thread Jackend
** Description changed: This bug is in -no-kvm mode. In windowsXP at IDT entry 28 is Task gate when application use INT 2 or INT 8 it will cause blue screen in XP. - I found it should cause #GP not generate hw interrupt. + I found it should cause #GP but not generate hw interrupt.

Re: [Qemu-devel] [PATCH v4 0/6] Add cache mode option to qemu-iotests, and change default mode to writeback

2013-12-03 Thread Kevin Wolf
Am 26.11.2013 um 02:43 hat Fam Zheng geschrieben: This series adds cache mode option in the iotests framework. Test cases are updated to make use of cache mode and mask supported modes. v4: Address Stefan's comments: Add _default_cache_mode. Split last two cases in 048 to 074.

Re: [Qemu-devel] [PATCH 2/5] machine: introduce get_fw_dev_path() callback

2013-12-03 Thread Paolo Bonzini
Il 03/12/2013 10:32, Alexey Kardashevskiy ha scritto: Absolutely not. It's merely not portable to machines with object file formats and linkers stuck in the 80s. However, we routinely twist ourselves into knots for portability (observation, not endorsement), and at least one previous

Re: [Qemu-devel] [RFC PATCH v1 2/5] hw: Remove assert_no_error usages

2013-12-03 Thread Peter Crosthwaite
On Tue, Dec 3, 2013 at 7:35 PM, Markus Armbruster arm...@redhat.com wrote: Peter Crosthwaite peter.crosthwa...@xilinx.com writes: Replace assert_no_error() usages with the error_abort system. error_abort is passed into API calls to signal to the Error sub-system that any errors are fatal.

Re: [Qemu-devel] [PATCH] arm: Raspberry Pi support

2013-12-03 Thread Jan Petrouš
Sorry guys for html, I didn't know that my company's mail has such default formatting :( I was on bussiness trip for few days so replaying only now. And as Greg said, it looks like we have another progress on raspi machine so I will check that and return back soon, hopefully ;) /Jan

[Qemu-devel] [BUG] ahci -device ide-hd|ide-cd select a bus already in use

2013-12-03 Thread Fabio Fantoni
I started to test/implement q35 cipset on xen hvm domUs. I found that ide disks and cdrom don't works with q35 using old qemu parameters without -device, this is not a blocking problem. I tried with new qemu parameters and ahci and the disk works. When I tried to add more that one ahci

Re: [Qemu-devel] [RFC PATCH v1 4/5] qemu-option: Remove qemu_opts_create_nofail

2013-12-03 Thread Peter Crosthwaite
On Tue, Dec 3, 2013 at 7:42 PM, Markus Armbruster arm...@redhat.com wrote: Peter Crosthwaite peter.crosthwa...@xilinx.com writes: This is a boiler-plate _nofail variant of qemu_opts_create. Remove and use error_abort in call sites. A null argument needs to be added for the id field in

Re: [Qemu-devel] [PATCH v4 3/6] qemu-iotests: Add _default_cache_mode and _supported_cache_modes

2013-12-03 Thread Fam Zheng
On 2013年12月03日 17:28, Kevin Wolf wrote: Am 03.12.2013 um 09:21 hat Fam Zheng geschrieben: On 2013年12月03日 14:05, Wenchao Xia wrote: Why forbid mode = writeback? These test cases used to run with only possibly writethrough, or none. And they don't work with writeback, at least in my

Re: [Qemu-devel] [BUG] ahci -device ide-hd|ide-cd select a bus already in use

2013-12-03 Thread Markus Armbruster
Fabio Fantoni fabio.fant...@m2r.biz writes: I started to test/implement q35 cipset on xen hvm domUs. I found that ide disks and cdrom don't works with q35 using old qemu parameters without -device, this is not a blocking problem. I tried with new qemu parameters and ahci and the disk works.

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vl: remove (max_cpus 255) check from smp_parse

2013-12-03 Thread Igor Mammedov
On Mon, 02 Dec 2013 23:09:55 +0100 Andreas Färber afaer...@suse.de wrote: Am 02.12.2013 18:06, schrieb Michael Tokarev: 25.11.2013 07:39, Alexey Kardashevskiy wrote: Since modern POWER7/POWER8 chips can have more that 256 CPU threads (2000 actually), remove this check from smp_parse.

Re: [Qemu-devel] [RFC PATCH v1 4/5] qemu-option: Remove qemu_opts_create_nofail

2013-12-03 Thread Markus Armbruster
Peter Crosthwaite peter.crosthwa...@xilinx.com writes: On Tue, Dec 3, 2013 at 7:42 PM, Markus Armbruster arm...@redhat.com wrote: Peter Crosthwaite peter.crosthwa...@xilinx.com writes: [...] @@ -3376,8 +3377,9 @@ int main(int argc, char **argv, char **envp) }

Re: [Qemu-devel] [BUG] ahci -device ide-hd|ide-cd select a bus already in use

2013-12-03 Thread Fabio Fantoni
Il 03/12/2013 11:32, Markus Armbruster ha scritto: Fabio Fantoni fabio.fant...@m2r.biz writes: I started to test/implement q35 cipset on xen hvm domUs. I found that ide disks and cdrom don't works with q35 using old qemu parameters without -device, this is not a blocking problem. I tried with

Re: [Qemu-devel] [PATCH V6 4/6] qemu-img: add -l for snapshot in convert

2013-12-03 Thread Stefan Hajnoczi
On Fri, Nov 22, 2013 at 12:27:10PM +0800, Wenchao Xia wrote: diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx index da1d965..9a8153b 100644 --- a/qemu-img-cmds.hx +++ b/qemu-img-cmds.hx @@ -34,7 +34,7 @@ STEXI ETEXI DEF(convert, img_convert, -convert [-c] [-p] [-q] [-n] [-f fmt]

Re: [Qemu-devel] [PATCH v4] cpu: add suboptions support

2013-12-03 Thread Igor Mammedov
On Tue, 3 Dec 2013 14:42:48 +1100 Alexey Kardashevskiy a...@ozlabs.ru wrote: This adds suboptions support for -cpu. This keeps @cpu_model in order not to break the existing architectures/machines. Cc: Andreas Färber afaer...@suse.de Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru ---

Re: [Qemu-devel] [PATCH 06/17] migration-local: add send_pipefd()

2013-12-03 Thread Lei Li
On 12/02/2013 05:33 PM, Daniel P. Berrange wrote: On Mon, Dec 02, 2013 at 05:19:06PM +0800, Lei Li wrote: This patch adds send_pipefd() to pass the pipe file descriptor to destination process. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- migration-local.c | 46

Re: [Qemu-devel] [PATCH 06/17] migration-local: add send_pipefd()

2013-12-03 Thread Daniel P. Berrange
On Tue, Dec 03, 2013 at 07:19:40PM +0800, Lei Li wrote: On 12/02/2013 05:33 PM, Daniel P. Berrange wrote: On Mon, Dec 02, 2013 at 05:19:06PM +0800, Lei Li wrote: This patch adds send_pipefd() to pass the pipe file descriptor to destination process. Signed-off-by: Lei Li

Re: [Qemu-devel] [PATCH 2/5] hw/timer: add allwinner a10 timer

2013-12-03 Thread Peter Crosthwaite
On Tue, Dec 3, 2013 at 7:11 PM, liguang lig.f...@cn.fujitsu.com wrote: Signed-off-by: liguang lig.f...@cn.fujitsu.com --- default-configs/arm-softmmu.mak |2 + hw/timer/Makefile.objs |2 + hw/timer/allwinner-a10_pit.c | 253

Re: [Qemu-devel] [PATCH 4/5] hw/arm: add allwinner a10 SoC support

2013-12-03 Thread Peter Crosthwaite
On Tue, Dec 3, 2013 at 7:11 PM, liguang lig.f...@cn.fujitsu.com wrote: Signed-off-by: liguang lig.f...@cn.fujitsu.com --- hw/arm/Makefile.objs |2 +- hw/arm/allwinner-a10.c | 39 +++ include/hw/arm/allwinner-a10.h | 27

Re: [Qemu-devel] [PATCH 4/5] hw/arm: add allwinner a10 SoC support

2013-12-03 Thread Peter Crosthwaite
On Tue, Dec 3, 2013 at 7:11 PM, liguang lig.f...@cn.fujitsu.com wrote: Signed-off-by: liguang lig.f...@cn.fujitsu.com --- hw/arm/Makefile.objs |2 +- hw/arm/allwinner-a10.c | 39 +++ include/hw/arm/allwinner-a10.h | 27

Re: [Qemu-devel] [RFC PATCH v1 0/5] Add error_abort and associated cleanups

2013-12-03 Thread Igor Mammedov
On Tue, 03 Dec 2013 10:44:57 +0100 Markus Armbruster arm...@redhat.com wrote: Peter Crosthwaite peter.crosthwa...@xilinx.com writes: Following our discussion RE self asserting API calls, here is a spin of my proposal. This series obsoletes the need for _nofail variants for Error **

Re: [Qemu-devel] [PATCH 06/17] migration-local: add send_pipefd()

2013-12-03 Thread Paolo Bonzini
Il 03/12/2013 12:19, Lei Li ha scritto: On 12/02/2013 05:33 PM, Daniel P. Berrange wrote: On Mon, Dec 02, 2013 at 05:19:06PM +0800, Lei Li wrote: This patch adds send_pipefd() to pass the pipe file descriptor to destination process. Signed-off-by: Lei Li li...@linux.vnet.ibm.com ---

Re: [Qemu-devel] [RFC PATCH v1 0/5] Add error_abort and associated cleanups

2013-12-03 Thread Paolo Bonzini
Il 03/12/2013 10:44, Markus Armbruster ha scritto: There are some _nofail functions left, but none of them can use error_abort. If anything assigns to error_abort, we're probably screwed. No bright idea how to prevent that at compile-time. Isn't it always used by address? Paolo

Re: [Qemu-devel] [PATCH 0/17 v5] Localhost migration with side channel for ram

2013-12-03 Thread Paolo Bonzini
Il 02/12/2013 10:19, Lei Li ha scritto: This patch series tries to introduce a mechanism using side channel pipe for RAM via SCM_RIGHTS with unix domain socket protocol migration. This side channel is used for the page flipping by vmsplice, which is the internal mechanism for localhost

Re: [Qemu-devel] [PATCH 5/5] hw/arm: add cubieboard support

2013-12-03 Thread Peter Crosthwaite
On Tue, Dec 3, 2013 at 7:11 PM, liguang lig.f...@cn.fujitsu.com wrote: Signed-off-by: liguang lig.f...@cn.fujitsu.com --- hw/arm/Makefile.objs |2 +- hw/arm/cubieboard.c | 33 + 2 files changed, 34 insertions(+), 1 deletions(-) create mode 100644

[Qemu-devel] [PATCH] vl: add missing transition debug-finish_migrate

2013-12-03 Thread Paolo Bonzini
This fixes an abort if you invoke the migrate command while the guest is being debugged. Cc: qemu-sta...@nongnu.org Cc: lcapitul...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- vl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/vl.c b/vl.c index 8d5d874..31e3411 100644

Re: [Qemu-devel] [RFC PATCH v1 0/5] Add error_abort and associated cleanups

2013-12-03 Thread Peter Crosthwaite
On Tue, Dec 3, 2013 at 9:57 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 03/12/2013 10:44, Markus Armbruster ha scritto: There are some _nofail functions left, but none of them can use error_abort. If anything assigns to error_abort, we're probably screwed. No bright idea how to prevent

Re: [Qemu-devel] [RFC PATCH 03/21] target-arm: adjust TTBCR for TrustZone feature

2013-12-03 Thread Peter Crosthwaite
On Tue, Dec 3, 2013 at 6:48 PM, Sergey Fedorov s.fedo...@samsung.com wrote: TTBCR has additional fields PD0 and PD1 when using Short-descriptor translation table format on a CPU with TrustZone feature support. Signed-off-by: Sergey Fedorov s.fedo...@samsung.com --- target-arm/helper.c |

Re: [Qemu-devel] [RFC PATCH 04/21] target-arm: preserve RAO/WI bits of ARMv7 SCTLR

2013-12-03 Thread Peter Crosthwaite
On Tue, Dec 3, 2013 at 6:48 PM, Sergey Fedorov s.fedo...@samsung.com wrote: From: Svetlana Fedoseeva s.fedose...@samsung.com Signed-off-by: Svetlana Fedoseeva s.fedose...@samsung.com Signed-off-by: Sergey Fedorov s.fedo...@samsung.com --- target-arm/helper.c |4 1 file changed, 4

Re: [Qemu-devel] [RFC PATCH 05/21] target-arm: add CPU Monitor mode

2013-12-03 Thread Peter Crosthwaite
On Tue, Dec 3, 2013 at 6:48 PM, Sergey Fedorov s.fedo...@samsung.com wrote: From: Svetlana Fedoseeva s.fedose...@samsung.com Define CPU monitor mode. Adjust core registers banking. Adjust CPU VM state info. Provide CPU mode name for monitor mode. Signed-off-by: Svetlana Fedoseeva

Re: [Qemu-devel] [RFC PATCH 08/21] target-arm: adjust arm_current_pl() for TrustZone

2013-12-03 Thread Peter Crosthwaite
On Tue, Dec 3, 2013 at 6:48 PM, Sergey Fedorov s.fedo...@samsung.com wrote: Make arm_current_pl() to return PL3 in secure privileged mode. Signed-off-by: Sergey Fedorov s.fedo...@samsung.com --- target-arm/cpu.h |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [RFC PATCH 05/21] target-arm: add CPU Monitor mode

2013-12-03 Thread Peter Maydell
On 3 December 2013 12:20, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: On Tue, Dec 3, 2013 at 6:48 PM, Sergey Fedorov s.fedo...@samsung.com wrote: From: Svetlana Fedoseeva s.fedose...@samsung.com Define CPU monitor mode. Adjust core registers banking. Adjust CPU VM state info.

[Qemu-devel] [PULL 01/01] seccomp: add kill() to the syscall whitelist

2013-12-03 Thread Eduardo Otubo
From: Paul Moore pmo...@redhat.com The kill() syscall is triggered with the following command: # qemu -sandbox on -monitor stdio \ -device intel-hda -device hda-duplex -vnc :0 The resulting syslog/audit message: # ausearch -m SECCOMP time-Wed Nov 20 09:52:08 2013 type=SECCOMP

[Qemu-devel] [PULL 00/01] seccomp: add missing system call to whitelist

2013-12-03 Thread Eduardo Otubo
Anthony, The following changes since commit 7dc65c02fe3fb8f3146ce0b9ff5fec5945329f0e: Open 2.0 development tree (2013-11-27 14:02:45 -0800) are available in the git repository at: git://github.com/otubo/qemu.git seccomp Paul Moore (1): seccomp: add kill() to the syscall whitelist

Re: [Qemu-devel] [RFC PATCH v1 0/5] Add error_abort and associated cleanups

2013-12-03 Thread Eric Blake
On 12/03/2013 02:44 AM, Markus Armbruster wrote: Peter Crosthwaite peter.crosthwa...@xilinx.com writes: Following our discussion RE self asserting API calls, here is a spin of my proposal. This series obsoletes the need for _nofail variants for Error ** accepting APIs. Is also greately

Re: [Qemu-devel] [PATCH arm-devs v3 1/9] qom/object: Make uintXX added properties writable

2013-12-03 Thread Andreas Färber
Am 03.12.2013 07:59, schrieb Peter Crosthwaite: Currently the uintXX property adders make a read only property. This is not useful for devices that want to create board (or container) configurable dynamic device properties. Fix by trivially adding property setters to

Re: [Qemu-devel] [Bug 1257099] [NEW] QEMU fails to build on CentOS 5.10 with relocation R_X86_64_PC32 error

2013-12-03 Thread Stefano Stabellini
CC'ing Paolo and xen-devel. The original thread is here: http://marc.info/?l=xen-develm=135718999710640 On Mon, 2 Dec 2013, Don Slutz wrote: Public bug reported: lt LINK libcacard.la /usr/bin/ld: libcacard/.libs/vcard.o: relocation R_X86_64_PC32 against `vcard_buffer_response_delete'

[Qemu-devel] [RFC V3 0/7] Giving names to BlockDriverState graph nodes

2013-12-03 Thread Benoît Canet
This partial series start to add some node-name manipulation from QMP. In particular it allow to take snapshots of quorum files. I post it in a partial state to spread the reviewing load. Best regards Benoît Benoît Canet (7): block: Add bs-node_name to hold the name of a bs node of the bs

Re: [Qemu-devel] [PATCH arm-devs v3 1/9] qom/object: Make uintXX added properties writable

2013-12-03 Thread Andreas Färber
Am 03.12.2013 07:59, schrieb Peter Crosthwaite: Currently the uintXX property adders make a read only property. This is not useful for devices that want to create board (or container) configurable dynamic device properties. Fix by trivially adding property setters to

[Qemu-devel] [RFC V3 6/7] block: Create authorizations mechanism for external snapshots.

2013-12-03 Thread Benoît Canet
--- block.c | 64 +-- block/blkverify.c | 2 +- include/block/block.h | 16 +--- include/block/block_int.h | 9 --- 4 files changed, 75 insertions(+), 16 deletions(-) diff --git a/block.c b/block.c index

[Qemu-devel] [RFC V3 1/7] block: Add bs-node_name to hold the name of a bs node of the bs graph.

2013-12-03 Thread Benoît Canet
Add the minimum of code to prepare the followings patches. Signed-off-by: Benoit Canet ben...@irqsave.net --- block.c | 72 ++- block/blkverify.c | 2 +- block/iscsi.c | 2 +- block/vmdk.c | 2 +-

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vl: remove (max_cpus 255) check from smp_parse

2013-12-03 Thread Andreas Färber
Am 03.12.2013 00:03, schrieb Alexey Kardashevskiy: On 12/03/2013 09:09 AM, Andreas Färber wrote: Am 02.12.2013 18:06, schrieb Michael Tokarev: 25.11.2013 07:39, Alexey Kardashevskiy wrote: Since modern POWER7/POWER8 chips can have more that 256 CPU threads (2000 actually), remove this check

Re: [Qemu-devel] [PATCH 2/5] machine: introduce get_fw_dev_path() callback

2013-12-03 Thread Andreas Färber
Am 03.12.2013 04:52, schrieb Alexey Kardashevskiy: On 11/26/2013 03:55 PM, Alexey Kardashevskiy wrote: Hi! btw there is a problem with this patch - it does not compile for linux-user as there is no current-machine global variable defined in vl.c which is not compiled for linux-user. How to

Re: [Qemu-devel] [PATCH 2/5] machine: introduce get_fw_dev_path() callback

2013-12-03 Thread Andreas Färber
Am 03.12.2013 10:37, schrieb Paolo Bonzini: Il 25/11/2013 08:27, Alexey Kardashevskiy ha scritto: QEMU supports firmware names for all devices in the QEMU tree but sometime the exact format differs from what sPAPR platform uses. This introduces a callback to let a machine fix device tree path

[Qemu-devel] [PATCH v3] block: Close backing file early in bdrv_img_create

2013-12-03 Thread Max Reitz
Leaving the backing file open although it is not needed anymore can cause problems if it is opened through a block driver which allows exclusive access only and if the create function of the block driver used for the top image (the one being created) tries to close and reopen the image file (which

Re: [Qemu-devel] [PATCH 2/5] machine: introduce get_fw_dev_path() callback

2013-12-03 Thread Paolo Bonzini
Il 03/12/2013 14:44, Andreas Färber ha scritto: You can check if (current_machine current_machine-get_fw_dev_path), and move current_machine from vl.c to hw/qdev/core.c. Please don't encourage moving random stuff into core device code. If needed, we can easily add a machine.c, but

Re: [Qemu-devel] [PATCH 06/17] migration-local: add send_pipefd()

2013-12-03 Thread Lei Li
On 12/03/2013 07:35 PM, Daniel P. Berrange wrote: On Tue, Dec 03, 2013 at 07:19:40PM +0800, Lei Li wrote: On 12/02/2013 05:33 PM, Daniel P. Berrange wrote: On Mon, Dec 02, 2013 at 05:19:06PM +0800, Lei Li wrote: This patch adds send_pipefd() to pass the pipe file descriptor to destination

Re: [Qemu-devel] [PATCH 06/17] migration-local: add send_pipefd()

2013-12-03 Thread Lei Li
On 12/03/2013 07:52 PM, Paolo Bonzini wrote: Il 03/12/2013 12:19, Lei Li ha scritto: On 12/02/2013 05:33 PM, Daniel P. Berrange wrote: On Mon, Dec 02, 2013 at 05:19:06PM +0800, Lei Li wrote: This patch adds send_pipefd() to pass the pipe file descriptor to destination process. Signed-off-by:

Re: [Qemu-devel] [PATCH v3 00/19] block scsi: write_zeroes support through the whole stack

2013-12-03 Thread Stefan Hajnoczi
On Fri, Nov 22, 2013 at 01:39:42PM +0100, Paolo Bonzini wrote: This series fixes the implementation of WRITE SAME in the SCSI emulation layer. On top of this, it ensures that zero writes from the guest can be offloaded to the host device or filesystem if that's supported. This is a relatively

Re: [Qemu-devel] [PATCH v5 5/6] qemu-iotests: Clean up spaces in usage output

2013-12-03 Thread Benoît Canet
Le Tuesday 03 Dec 2013 à 16:25:26 (+0800), Fam Zheng a écrit : Whitespace changes to align columns. Signed-off-by: Fam Zheng f...@redhat.com --- tests/qemu-iotests/common | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/tests/qemu-iotests/common

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vl: remove (max_cpus 255) check from smp_parse

2013-12-03 Thread Eduardo Habkost
On Tue, Dec 03, 2013 at 11:44:19AM +0100, Igor Mammedov wrote: On Mon, 02 Dec 2013 23:09:55 +0100 Andreas Färber afaer...@suse.de wrote: Am 02.12.2013 18:06, schrieb Michael Tokarev: 25.11.2013 07:39, Alexey Kardashevskiy wrote: Since modern POWER7/POWER8 chips can have more that 256

Re: [Qemu-devel] [PATCH 2/5] machine: introduce get_fw_dev_path() callback

2013-12-03 Thread Andreas Färber
Am 03.12.2013 15:00, schrieb Paolo Bonzini: Il 03/12/2013 14:44, Andreas Färber ha scritto: You can check if (current_machine current_machine-get_fw_dev_path), and move current_machine from vl.c to hw/qdev/core.c. Please don't encourage moving random stuff into core device code. If

Re: [Qemu-devel] [RFC] hw/net: add DEC Tulip NIC emulation

2013-12-03 Thread Stefan Hajnoczi
On Fri, Nov 22, 2013 at 06:47:49PM +0400, Dmitry Smagin wrote: From: Antony Pavlov antonynpav...@gmail.com This patch adds emulation of DEC/Intel Tulip 21143 with some external chips: * Intel LXT971A 10/100 Mbps PHY MII Tranceiver; * Microchip 93LC46B 1K Microwire Compatible Serial

Re: [Qemu-devel] [PATCH 5/5] hw/arm: add cubieboard support

2013-12-03 Thread Andreas Färber
Am 03.12.2013 13:01, schrieb Peter Crosthwaite: On Tue, Dec 3, 2013 at 7:11 PM, liguang lig.f...@cn.fujitsu.com wrote: Signed-off-by: liguang lig.f...@cn.fujitsu.com --- hw/arm/Makefile.objs |2 +- hw/arm/cubieboard.c | 33 + 2 files changed, 34

Re: [Qemu-devel] [Bug 1257099] [NEW] QEMU fails to build on CentOS 5.10 with relocation R_X86_64_PC32 error

2013-12-03 Thread Paolo Bonzini
Il 03/12/2013 14:25, Stefano Stabellini ha scritto: CC'ing Paolo and xen-devel. The original thread is here: http://marc.info/?l=xen-develm=135718999710640 On Mon, 2 Dec 2013, Don Slutz wrote: Public bug reported: lt LINK libcacard.la /usr/bin/ld: libcacard/.libs/vcard.o:

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vl: remove (max_cpus 255) check from smp_parse

2013-12-03 Thread Eduardo Habkost
On Tue, Dec 03, 2013 at 02:30:48PM +0100, Andreas Färber wrote: Am 03.12.2013 00:03, schrieb Alexey Kardashevskiy: On 12/03/2013 09:09 AM, Andreas Färber wrote: Am 02.12.2013 18:06, schrieb Michael Tokarev: 25.11.2013 07:39, Alexey Kardashevskiy wrote: Since modern POWER7/POWER8 chips can

Re: [Qemu-devel] Linux multiqueue block layer thoughts

2013-12-03 Thread Stefan Hajnoczi
On Wed, Nov 27, 2013 at 07:15:13PM -0700, Jens Axboe wrote: On Wed, Nov 27 2013, Stefan Hajnoczi wrote: At the end of all this we'd arrive at the following architecture: 1. Guest virtio device has multiple queues (1 per node or vcpu). 2. QEMU has multiple dataplane/QContext threads that

Re: [Qemu-devel] [PATCH 2/5] machine: introduce get_fw_dev_path() callback

2013-12-03 Thread Paolo Bonzini
Il 03/12/2013 15:35, Andreas Färber ha scritto: Am 03.12.2013 15:00, schrieb Paolo Bonzini: Il 03/12/2013 14:44, Andreas Färber ha scritto: You can check if (current_machine current_machine-get_fw_dev_path), and move current_machine from vl.c to hw/qdev/core.c. Please don't encourage

Re: [Qemu-devel] [PATCH v3 08/19] block drivers: add discard/write_zeroes properties to bdrv_get_info implementation

2013-12-03 Thread Kevin Wolf
Am 22.11.2013 um 13:39 hat Paolo Bonzini geschrieben: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block/qcow2.c | 2 ++ block/qed.c | 2 ++ block/vdi.c | 1 + block/vhdx.c | 3 +++ block/vpc.c | 1 + 5 files changed, 9 insertions(+) diff --git a/block/qcow2.c

Re: [Qemu-devel] [PATCH v5 2/6] qemu-iotests: Honour cache mode in iotests.py

2013-12-03 Thread Kevin Wolf
Am 03.12.2013 um 15:27 hat Benoît Canet geschrieben: Le Tuesday 03 Dec 2013 à 16:25:23 (+0800), Fam Zheng a écrit : This will allow overriding cache mode from the -c mode option. Signed-off-by: Fam Zheng f...@redhat.com --- tests/qemu-iotests/iotests.py | 3 ++- 1 file changed, 2

Re: [Qemu-devel] [PATCH v3] block: Close backing file early in bdrv_img_create

2013-12-03 Thread Kevin Wolf
Am 03.12.2013 um 14:57 hat Max Reitz geschrieben: Leaving the backing file open although it is not needed anymore can cause problems if it is opened through a block driver which allows exclusive access only and if the create function of the block driver used for the top image (the one being

Re: [Qemu-devel] [PATCH v3 08/19] block drivers: add discard/write_zeroes properties to bdrv_get_info implementation

2013-12-03 Thread Paolo Bonzini
Il 03/12/2013 16:09, Kevin Wolf ha scritto: BDRVQcowState *s = bs-opaque; +bdi-unallocated_blocks_are_zero = true; +bdi-can_write_zeroes_with_unmap = (s-qcow_version = 3); bdi-cluster_size = s-cluster_size; bdi-vm_state_offset = qcow2_vm_state_offset(s);

Re: [Qemu-devel] virtio virt-queue and virt-ring

2013-12-03 Thread Stefan Hajnoczi
On Sun, Dec 01, 2013 at 05:12:52AM +, Yaodong Yang wrote: Inside file ./hw/virtio/virtio.c, The following structs are defined. I understood that for each virtual disk, there is a corresponding queue and this queue is implemented by a ring. My questions is what is the meaning of each

Re: [Qemu-devel] [PATCH qom v1 1/1] qom/object.c: Split out object and class caches.

2013-12-03 Thread Paolo Bonzini
Il 28/11/2013 05:27, Peter Crosthwaite ha scritto: The object-cast and class-cast caches cannot be shared because class caching is conditional on the target type not being an interface and object caching is unconditional. Leads to a bug when a class cast to an interface follows an object cast

[Qemu-devel] [PATCH 2/2] qom: detect bad reentrance during object_class_foreach

2013-12-03 Thread Paolo Bonzini
From: Hervé Poussineau hpous...@reactos.org We should not modify the type hash table while it is being iterated on. Assert that it does not happen. Signed-off-by: Hervé Poussineau hpous...@reactos.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qom/object.c | 4 1 file changed, 4

[Qemu-devel] [PATCH 0/2] qom: fix registration of QOM interfaces

2013-12-03 Thread Paolo Bonzini
object_class_foreach can initialize new types, and also register new types corresponding to the implementations of interfaces. Those will change the type internal hashtable which is currently enumerated, and GHashTable does not permit this. Fix this by not registering those internal types in the

[Qemu-devel] [PATCH 1/2] qom: do not register interface types in the type table

2013-12-03 Thread Paolo Bonzini
There should be no need to look them up nor enumerate the interface types, whose classes are really just vtables. Just create the types and add them to the interface list of the parent type. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qom/object.c | 13 ++--- 1 file changed, 10

[Qemu-devel] [V3 PATCH 00/14] target-ppc: VSX Stage 4

2013-12-03 Thread Tom Musta
This is the fourth and final series of patches that add emulation support to QEMU for the PowerPC Vector Scalar Extension (VSX). This series adds the instructions that were newly introduced with Power ISA V2.07. This includes 3 scalar load instructions, 2 scalar store instructions, 7 standard

[Qemu-devel] [V3 PATCH 01/14] target-ppc: VSX Stage 4: Add VSX 2.07 Flag

2013-12-03 Thread Tom Musta
This patch adds a flag to identify those VSX instructions that are new to Power ISA V2.07. The flag is added to the Power 8 processor initialization so that the P8 models understand how to decode and emulate instructions in this category. Signed-off-by: Tom Musta tommu...@gmail.com ---

[Qemu-devel] [V3 PATCH 11/14] target-ppc: VSX Stage 4: add xsrsqrtesp

2013-12-03 Thread Tom Musta
This patch adds the VSX Scalar Reciprocal Square Root Estimate Single Precision (xsrsqrtesp) instruction. The existing VSX_RSQRTE() macro is modified to support rounding of the intermediate double-precision result to single precision. V2: Updated conversion to single precision range.

[Qemu-devel] [V3 PATCH 10/14] target-ppc: VSX Stage 4: Add xssqrtsp

2013-12-03 Thread Tom Musta
This patch adds the VSX Scalar Square Root Single Precision (xssqrtsp) instruction. The existing VSX_SQRT() macro is modified to support rounding of the intermediate double-precision result to single-precision. V2: Updated conversion to single precision range. Signed-off-by: Tom Musta

[Qemu-devel] [V3 PATCH 04/14] target-ppc: VSX Stage 4: Refactor stxsdx

2013-12-03 Thread Tom Musta
This patch refactors the stxsdx instruction. Reusable code is extracted into a macro which will be used in subsequent patches in this series. Signed-off-by: Tom Musta tommu...@gmail.com --- target-ppc/translate.c | 27 +++ 1 files changed, 15 insertions(+), 12

[Qemu-devel] [V3 PATCH 05/14] target-ppc: VSX Stage 4: Add stxsiwx and stxsspx

2013-12-03 Thread Tom Musta
This patch adds two store scalar instructions: - Store VSX Scalar as Integer Word Indexed (stxsiwx) - Store VSX Scalar Single-Precision Indexed (stxsspx) Signed-off-by: Tom Musta tommu...@gmail.com --- target-ppc/translate.c |4 1 files changed, 4 insertions(+), 0 deletions(-)

[Qemu-devel] [V3 PATCH 06/14] target-ppc: VSX Stage 4: Add xsaddsp and xssubsp

2013-12-03 Thread Tom Musta
This patch adds the VSX Scalar Add Single-Precision (xsaddsp) and VSX Scalar Subtract Single-Precision (xssubsp) instructions. The existing VSX_ADD_SUB macro is modified to support the rounding of the (intermediate) result to single-precision. V2: updated conversion of result to single

[Qemu-devel] [V3 PATCH 13/14] target-ppc: VSX Stage 4: Add xscvsxdsp and xscvuxdsp

2013-12-03 Thread Tom Musta
This patch adds the VSX Scalar Convert Unsigned Integer Doubleword to Floating Point Format and Round to Single Precision (xscvuxdsp) and VSX Scalar Convert Signed Integer Douglbeword to Floating Point Format and Round to Single Precision (xscvsxdsp) instructions. The existing integer to floating

[Qemu-devel] [V3 PATCH 09/14] target-ppc: VSX Stage 4: Add xsresp

2013-12-03 Thread Tom Musta
This patch adds the VSX Scalar Reciprocal Estimate Single Precision (xsresp) instruction. The existing VSX_RE macro is modified to support rounding of the intermediate double precision result to single precision. V2: Updated conversion to single precision range. Signed-off-by: Tom Musta

[Qemu-devel] [V3 PATCH 12/14] target-ppc: VSX Stage 4: Add Scalar SP Fused Multiply-Adds

2013-12-03 Thread Tom Musta
This patch adds the Single Precision VSX Scalar Fused Multiply-Add instructions: xsmaddasp, xsmaddmsp, xssubasp, xssubmsp, xsnmaddasp, xsnmaddmsp, xsnmsubasp, xsnmsubmsp. The existing VSX_MADD() macro is modified to support rounding of the intermediate double precision result to single precision.

[Qemu-devel] [V3 PATCH 14/14] target-ppc: VSX Stage 4: Add xxleqv, xxlnand and xxlorc

2013-12-03 Thread Tom Musta
This patchs adds the VSX Logical instructions that are new with ISA V2.07: - VSX Logical Equivalence (xxleqv) - VSX Logical NAND (xxlnand) - VSX Logical ORC (xxlorc) Signed-off-by: Tom Musta tommu...@gmail.com --- target-ppc/translate.c |6 ++ 1 files changed, 6 insertions(+), 0

Re: [Qemu-devel] [PATCH 1/7] Declare and Enable VSX

2013-12-03 Thread Tom Musta
On 10/22/2013 6:05 AM, Anton Blanchard wrote: From: Tom Musta tommu...@gmail.com This patch adds the flag POWERPC_FLAG_VSX to the list of defined flags and also adds this flag to the list of supported features of the Power7 and Power8 CPUs. Additionally, the VSX instructions are added to

Re: [Qemu-devel] [PATCH V3 00/13] Stage 2 VSX Support

2013-12-03 Thread Tom Musta
On 11/1/2013 8:21 AM, Tom Musta wrote: NOTE: this is a resubmission of this patch series. Alex discovered some corruption in the patches from my previous submission. This patch series continues adding support for the PowerPC Vector Scalar Extension (VSX). Patches are relative to the

[Qemu-devel] [V3 PATCH 02/14] target-ppc: VSX Stage 4: Refactor lxsdx

2013-12-03 Thread Tom Musta
This patch refactors the lxsdx generator. Resuable code is isolated into a macro. The macro will be used in subsequent patches in this series to implement other scalar load instructions. Signed-off-by: Tom Musta tommu...@gmail.com --- target-ppc/translate.c | 31

Re: [Qemu-devel] [PATCH V3 00/19] PowerPC VSX Stage 3

2013-12-03 Thread Tom Musta
On 11/1/2013 8:35 AM, Tom Musta wrote: NOTE: this is a resubmission of the previous (V2) patch series. There was corruption in some of the patches. The logical content is identical to V2. This is the third series of patches to add PowerPC VSX emulation support to QEMU. This series adds

[Qemu-devel] [V3 PATCH 03/14] target-ppc: VSX Stage 4: Add lxsiwax, lxsiwzx and lxsspx

2013-12-03 Thread Tom Musta
This patch adds the scalar load instructions introduced in ISA V2.07: - Load VSX Scalar as Integer Word Algebraic Indexd (lxsiwax) - Load VSX Scalar as Integer Word and Zero Indexed (lxsiwzx) - Load VSX Scalar Single-Precision Indexed (lxsspx) Signed-off-by: Tom Musta tommu...@gmail.com

[Qemu-devel] [PATCH 06/23] hpet: fix buffer overrun on invalid state load

2013-12-03 Thread Michael S. Tsirkin
CVE-2013-4527 hw/timer/hpet.c buffer overrun hpet is a VARRAY with a uint8 size but static array of 32 To fix, make sure num_timers is valid using post_load hook. Reported-by: Anthony Liguori anth...@codemonkey.ws Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/timer/hpet.c | 18

[Qemu-devel] [PATCH 01/23] virtio-net: fix buffer overflow on invalid state load

2013-12-03 Thread Michael S. Tsirkin
CVE-2013-4148 QEMU 1.0 integer conversion in virtio_net_load()@hw/net/virtio-net.c Deals with loading a corrupted savevm image. n-mac_table.in_use = qemu_get_be32(f); in_use is int so it can get negative when assigned 32bit unsigned value. /* MAC_TABLE_ENTRIES may be

[Qemu-devel] [PATCH 03/23] virtio-net: out-of-bounds buffer write on invalid state load

2013-12-03 Thread Michael S. Tsirkin
CVE-2013-4150 QEMU 1.5.0 out-of-bounds buffer write in virtio_net_load()@hw/net/virtio-net.c This code is in hw/net/virtio-net.c: if (n-max_queues 1) { if (n-max_queues != qemu_get_be16(f)) { error_report(virtio-net: different max_queues ); return -1;

[Qemu-devel] [PATCH 09/23] target-arm/machine.c: fix buffer overflow on invalid state load

2013-12-03 Thread Michael S. Tsirkin
CVE-2013-4531 cpreg_vmstate_indexes is a VARRAY_INT32. A negative value for cpreg_vmstate_array_len will cause a buffer overflow. Reported-by: Anthony Liguori anth...@codemonkey.ws Signed-off-by: Michael S. Tsirkin m...@redhat.com --- target-arm/machine.c | 4 1 file changed, 4

[Qemu-devel] [PATCH 10/23] stellaris_enet: avoid buffer overrun on incoming migration

2013-12-03 Thread Michael S. Tsirkin
From: Michael Roth mdr...@linux.vnet.ibm.com CVE-2013-4532 s-next_packet is read from wire as an index into s-rx[]. If s-next_packet exceeds the length of s-rx[], the buffer can be subsequently overrun with arbitrary data from the wire. Fix this by introducing a constant that defines the length

  1   2   3   >