Re: [Qemu-devel] [PULL 10/42] qtest: Fix the bug about disable vnc causes make check fail

2014-01-26 Thread Kewei Yu
2014/1/26 Andreas Färber afaer...@suse.de Am 18.01.2014 12:54, schrieb Kewei Yu: 2014/1/17 Andreas Färber afaer...@suse.de mailto:afaer...@suse.de Am 15.01.2014 11:22, schrieb Kevin Wolf: From: Kewei Yu kewe...@gmail.com mailto:kewe...@gmail.com When we disable

Re: [Qemu-devel] [PATCH 0/2] acpi: Fix PCI hole handling on SRAT table

2014-01-26 Thread Michael S. Tsirkin
On Thu, Jan 09, 2014 at 05:12:41PM -0200, Eduardo Habkost wrote: The original SeaBIOS code used the RamSize variable, that was used by SeaBIOS for the size of RAM below 4GB, not for all RAM. When copied to QEMU, the code was changed to use the full RAM size, and this broke the build_srat()

Re: [Qemu-devel] [PULL 00/29] acpi, pci, pc, virtio fixes and enhancements

2014-01-26 Thread Michael S. Tsirkin
On Mon, Jan 20, 2014 at 04:09:16PM +0200, Michael S. Tsirkin wrote: The following changes since commit 1cf892ca2689c84960b4ce4d2723b6bee453711c: SPARC: Fix LEON3 power down instruction (2014-01-15 15:37:33 +1000) are available in the git repository at:

Re: [Qemu-devel] [PATCH 3/4] hw:acpi:pcihp: assume root PCI bus if bus has no ACPI_PCIHP_PROP_BSEL property

2014-01-26 Thread Michael S. Tsirkin
On Tue, Jan 21, 2014 at 03:40:05PM +0100, Igor Mammedov wrote: when running with machine types older than 1.7 (i.e. without ACPI builtin tables), PCI bus won't have ACPI_PCIHP_PROP_BSEL property set. Taking in account that acpi hotplug handler in 1.7 and older machines is called only for root

[Qemu-devel] [Bug 1263318] Re: Cannot add a USB 2.0 device under QEMU when running eudev

2014-01-26 Thread Francesco Turco
The bug has been fixed. It had nothing to do with QEMU. The problem was that eudev didn't ship a file with rules for USB devices. See https://bugs.gentoo.org/show_bug.cgi?id=499236 for detais. Sorry for the noise. ** Bug watch added: Gentoo Bugzilla #499236

[Qemu-devel] [PATCH] pcihp: reduce number of device check events

2014-01-26 Thread Michael S. Tsirkin
PIIX created a made-up value for the UP register since it was read by guest 32 times for each interrupt. There's no reason to do this for the new PCIHP: register is only read once for each interrupt, so clean up code by making read act as an interrupt acknowledgement: the new UP register clear on

Re: [Qemu-devel] [PATCH 4/4] hw:piix4:acpi: reuse pcihp code for legacy PCI hotplug

2014-01-26 Thread Michael S. Tsirkin
On Tue, Jan 21, 2014 at 03:40:06PM +0100, Igor Mammedov wrote: reduces acpi PCI hotplug code duplication by 150LOC, and makes pcihp less dependend on piix specific code. Signed-off-by: Igor Mammedov imamm...@redhat.com Actually pcihp was made separate intentionally so we can cleanup the

[Qemu-devel] [PATCH] MAINTAINERS: add self as virtio co-maintainer

2014-01-26 Thread Michael S. Tsirkin
This will help make sure I get Cc'd on patches. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index fb53242..adc5973 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -610,6 +610,7 @@ F: hw/*/*vhost*

[Qemu-devel] Possible bug in pci slot management, migration abort after hotplug/unplug pci devices

2014-01-26 Thread Gonglei (Arei)
Hi, I find a critical problem about pci devices migration when we configure a pci device not assign the devfn. Qemu will auto assign the devfn in function do_pci_register_device. At the migration src end, When we hotplug two pci devices, such as virtio-net. Qemu will assign devfn 4 (assumed

[Qemu-devel] [PATCH] hw/ppc: Remove unused defines

2014-01-26 Thread Stefan Weil
Signed-off-by: Stefan Weil s...@weilnetz.de --- hw/ppc/ppc4xx_devs.c |2 -- 1 file changed, 2 deletions(-) diff --git a/hw/ppc/ppc4xx_devs.c b/hw/ppc/ppc4xx_devs.c index 239aada..9160ee7 100644 --- a/hw/ppc/ppc4xx_devs.c +++ b/hw/ppc/ppc4xx_devs.c @@ -27,8 +27,6 @@ #include qemu/log.h

[Qemu-devel] [PULL v2 00/35] acpi, pci, pc, virtio fixes and enhancements

2014-01-26 Thread Michael S. Tsirkin
Hi Anthony, I forgot to Cc you on the previous version of this pull request. So here's v2 - it also includes some more changes that got merged since then. I also used this opportunity for smash in a compat bugfix. Please ignore the previous pull request. The following changes since commit

[Qemu-devel] [PULL v2 03/35] ACPI: Fix AppleSMC _STA size

2014-01-26 Thread Michael S. Tsirkin
From: Gabriel L. Somlo gso...@gmail.com Minimize the storage used for AppleSMC's _STA (8bit), relying on ASL to implicitly convert it to the officially specified 32bit value. Signed-off-by: Gabriel Somlo so...@cmu.edu Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/i386/acpi-build.c

[Qemu-devel] [PULL v2 06/35] configure: added acpi unit-test files

2014-01-26 Thread Michael S. Tsirkin
From: Marcel Apfelbaum marce...@redhat.com Ensure configure will set-up links for the files if the build is created in other directory. Signed-off-by: Marcel Apfelbaum marce...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- configure | 4 1 file changed, 4 insertions(+)

[Qemu-devel] [PULL v2 01/35] Python-lang gdb script to extract x86_64 guest vmcore from qemu coredump

2014-01-26 Thread Michael S. Tsirkin
From: Laszlo Ersek ler...@redhat.com When qemu dies unexpectedly, for example in response to an explicit abort() call, or (more importantly) when an external signal is delivered to it that results in a coredump, sometimes it is useful to extract the guest vmcore from the qemu process' memory

[Qemu-devel] [PULL v2 02/35] Add DSDT node for AppleSMC

2014-01-26 Thread Michael S. Tsirkin
From: Gabriel L. Somlo gso...@gmail.com AppleSMC (-device isa-applesmc) is required to boot OS X guests. OS X expects a SMC node to be present in the ACPI DSDT. This patch adds a SMC node to the DSDT, and dynamically patches the return value of SMC._STA to either 0x0B if the chip is present, or

[Qemu-devel] [PULL v2 10/35] acpi unit-test: added script to rebuild the expected aml files

2014-01-26 Thread Michael S. Tsirkin
From: Marcel Apfelbaum marce...@redhat.com Acpi unit-test will fail every time the acpi tables change. This script rebuild the expected aml files, so the test will pass. It also validates the modifications. Signed-off-by: Marcel Apfelbaum marce...@redhat.com Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PULL v2 11/35] acpi unit-test: hook to rebuild expected aml files

2014-01-26 Thread Michael S. Tsirkin
From: Marcel Apfelbaum marce...@redhat.com When running the test with TEST_ACPI_REBUILD_AML=y environment variable, the test will rebuild and validate the expected aml files. Signed-off-by: Marcel Apfelbaum marce...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

[Qemu-devel] [PULL v2 13/35] acpi unit-test: renamed ssdt_tables to tables

2014-01-26 Thread Michael S. Tsirkin
From: Marcel Apfelbaum marce...@redhat.com Just a refactoring, ssdt_tables name was confusing as it included other tables as well. Signed-off-by: Marcel Apfelbaum marce...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

[Qemu-devel] [PULL v2 08/35] configure: add CONFIG_IASL to config-host.h

2014-01-26 Thread Michael S. Tsirkin
From: Marcel Apfelbaum marce...@redhat.com Acpi unit-tests will extract iasl executable from CONFIG_IASL define. Signed-off-by: Marcel Apfelbaum marce...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- scripts/create_config | 4 1 file changed, 4 insertions(+) diff --git

[Qemu-devel] [PULL v2 29/35] acpi-test: update expected AML since recent changes

2014-01-26 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin m...@redhat.com --- tests/acpi-test-data/pc/DSDT | Bin 4407 - 4582 bytes tests/acpi-test-data/pc/SSDT | Bin 2104 - 2200 bytes tests/acpi-test-data/q35/DSDT | Bin 7344 - 7438 bytes tests/acpi-test-data/q35/SSDT | Bin 2104 - 475 bytes 4 files changed, 0

[Qemu-devel] [PULL v2 14/35] acpi unit-test: resolved iasl crash

2014-01-26 Thread Michael S. Tsirkin
From: Marcel Apfelbaum marce...@redhat.com It seems that iasl has an issue when disassembles some ACPI tables using the command line: iasl -e DSDT -e SSDT -d HPET Modified the iasl command line to iasl -d HPET until the problem is solved. The command line remained the same for DSDT and SSDT

[Qemu-devel] [PULL v2 32/35] acpi: Fix PCI hole handling on build_srat()

2014-01-26 Thread Michael S. Tsirkin
From: Eduardo Habkost ehabk...@redhat.com The original SeaBIOS code used the RamSize variable, that was used by SeaBIOS for the size of RAM below 4GB, not for all RAM. When copied to QEMU, the code was changed to use the full RAM size, and this broke the build_srat() code that handles the PCI

[Qemu-devel] [PULL v2 21/35] acpi: factor out common cpu hotplug code for PIIX4/Q35

2014-01-26 Thread Michael S. Tsirkin
From: Igor Mammedov imamm...@redhat.com .. so it could be used for adding CPU hotplug to Q35 machine Add an additional header with that will be shared between C and ASL code: include/hw/acpi/cpu_hotplug_defs.h Signed-off-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [PULL v2 09/35] acpi unit-test: extract iasl executable from configuration

2014-01-26 Thread Michael S. Tsirkin
From: Marcel Apfelbaum marce...@redhat.com The test checked if iasl is installed by running iasl and checking the error output. It is better to use the iasl executable as appears in configuration. Signed-off-by: Marcel Apfelbaum marce...@redhat.com Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PULL v2 19/35] piix4: add acpi pci hotplug support

2014-01-26 Thread Michael S. Tsirkin
Add support for acpi pci hotplug using the new infrastructure. PIIX4 legacy interface is maintained as is for machine types 1.7 and older. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/i386/pc.h | 5 hw/acpi/piix4.c | 75

[Qemu-devel] [PULL v2 22/35] acpi: ich9: add CPU hotplug handling to Q35 machine

2014-01-26 Thread Michael S. Tsirkin
From: Igor Mammedov imamm...@redhat.com .. use IO port 0cd8-0xcf7 range for CPU present bitmap Signed-off-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/acpi/cpu_hotplug_defs.h | 1 +

[Qemu-devel] [PULL v2 15/35] acpi unit-test: do not fail on asl mismatch

2014-01-26 Thread Michael S. Tsirkin
From: Marcel Apfelbaum marce...@redhat.com The asl comparison will break every time the ACPI tables are updated. This may break the git bisect. Instead of failing print a warning on stderr including the retained asl files, so they can be compared offline. Signed-off-by: Marcel Apfelbaum

[Qemu-devel] [PULL v2 17/35] pci: add pci_for_each_bus_depth_first

2014-01-26 Thread Michael S. Tsirkin
Useful for ACPI hotplug. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/pci/pci.h | 14 ++ hw/pci/pci.c | 28 2 files changed, 42 insertions(+) diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index 754b82d..5252346

[Qemu-devel] [PULL v2 20/35] acpi-build: enable hotplug for PCI bridges

2014-01-26 Thread Michael S. Tsirkin
This enables support for device hotplug behind pci bridges. Bridge devices themselves need to be pre-configured on qemu command line. Design: - at machine init time, assign bsel property to bridges with hotplug support - dynamically (At ACPI table read) generate ACPI code to handle

[Qemu-devel] [PULL v2 23/35] pc: set PRST base in DSDT depending on chipset

2014-01-26 Thread Michael S. Tsirkin
From: Igor Mammedov imamm...@redhat.com Signed-off-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/i386/acpi-dsdt-cpu-hotplug.dsl | 2 +- hw/i386/acpi-dsdt.dsl | 1 +

[Qemu-devel] [PULL v2 18/35] pcihp: generalization of piix4 acpi

2014-01-26 Thread Michael S. Tsirkin
Add ACPI based PCI hotplug library with bridge hotplug support. Design - each bus gets assigned bsel property. - ACPI code writes this number to a new BNUM register, then uses existing UP/DOWN registers to probe slot status; to eject, write number to BNUM register, then

[Qemu-devel] [PULL v2 28/35] pc: ACPI: update acpi-dsdt.hex.generated q35-acpi-dsdt.hex.generated

2014-01-26 Thread Michael S. Tsirkin
From: Igor Mammedov imamm...@redhat.com Signed-off-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/i386/acpi-dsdt.hex.generated | 217 +---

[Qemu-devel] [PULL v2 24/35] pc: PIIX DSDT: exclude CPU/PCI hotplug GPE0 IO range from PCI bus resources

2014-01-26 Thread Michael S. Tsirkin
From: Igor Mammedov imamm...@redhat.com .. so that they might not be used by PCI devices. Note: Resort to concatenating templates with preprocessor help, because 1.0b spec isn't supporting ConcatenateResTemplate, as result Windows XP fails to execute PCI0._CRS method if ConcatenateResTemplate()

[Qemu-devel] [PULL v2 27/35] pc: ACPI: unify source of CPU hotplug IO base/len

2014-01-26 Thread Michael S. Tsirkin
From: Igor Mammedov imamm...@redhat.com use C headers defines as source of IO base/len for respective values in ASL code. Signed-off-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

[Qemu-devel] [PULL v2 30/35] hw/pci: fix error flow in pci multifunction init

2014-01-26 Thread Michael S. Tsirkin
From: Marcel Apfelbaum marce...@redhat.com Scenario: - There is a non multifunction pci device A on 00:0X.0. - Hot-plug another multifunction pci device B at 00:0X.1. - The operation will fail of course. - Try to hot-plug the B device 2-3 more times, qemu will crash. Reason: The error

[Qemu-devel] [PULL v2 31/35] pc: Save size of RAM below 4GB

2014-01-26 Thread Michael S. Tsirkin
From: Eduardo Habkost ehabk...@redhat.com The ram_below_4g value will be useful in other places, such as the ACPI table code, and other code that currently requires passing below_4g_mem_size around in function arguments. Signed-off-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Michael S.

[Qemu-devel] [PULL v2 25/35] pc: Q35 DSDT: exclude CPU hotplug IO range from PCI bus resources

2014-01-26 Thread Michael S. Tsirkin
From: Igor Mammedov imamm...@redhat.com ... for range defined at hw/acpi/ich9.c:ICH9_PROC_BASE Signed-off-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/i386/acpi-dsdt-pci-crs.dsl | 7 ---

[Qemu-devel] [PULL v2 35/35] MAINTAINERS: add self as virtio co-maintainer

2014-01-26 Thread Michael S. Tsirkin
This will help make sure I get Cc'd on patches. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index fb53242..adc5973 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -610,6 +610,7 @@ F: hw/*/*vhost*

[Qemu-devel] [PULL v2 33/35] q35: gigabyte alignment for ram

2014-01-26 Thread Michael S. Tsirkin
From: Gerd Hoffmann kra...@redhat.com Map 2G (q35) of memory below 4G, so the RAM pieces are nicely aligned to gigabyte borders. Keep old memory layout for (a) old machine types and (b) in case all memory fits below 4G and thus we don't have to split RAM into pieces in the first place. The

[Qemu-devel] [PULL v2 34/35] q35: document gigabyte_align

2014-01-26 Thread Michael S. Tsirkin
Document the logic behind the below/above 4G split. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/i386/pc_q35.c | 13 + 1 file changed, 13 insertions(+) diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c index 7104645..a7f6260 100644 --- a/hw/i386/pc_q35.c +++

[Qemu-devel] [PULL v2 26/35] pc: ACPI: expose PRST IO range via _CRS

2014-01-26 Thread Michael S. Tsirkin
From: Igor Mammedov imamm...@redhat.com .. so OSPM could notice resource conflict if there is any. Signed-off-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/i386/acpi-dsdt-cpu-hotplug.dsl | 14

[Qemu-devel] [PATCH] seccomp: add timerfd_create and timerfd_settime to the whitelist

2014-01-26 Thread Felix Geyer
libusb calls timerfd_create() and timerfd_settime() when it's built with timerfd support. Command to reproduce: qemu -sandbox on -monitor stdio -device piix3-usb-uhci,id=usb -device usb-host,hostbus=1,hostaddr=3,id=hostdev0 Log messages: audit(1390730418.924:135): auid=4294967295 uid=121

[Qemu-devel] [PULL v2 04/35] virtio: Fix return value for dummy function vhost_net_virtqueue_pending

2014-01-26 Thread Michael S. Tsirkin
From: Stefan Weil s...@weilnetz.de cgcc complains that -ENOSYS is not a good value for 'bool'. A dummy virtio will never have pending queue entries, so let us return false. Signed-off-by: Stefan Weil s...@weilnetz.de Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/net/vhost_net.c | 2

[Qemu-devel] [PULL v2 07/35] acpi unit-test: compare DSDT and SSDT tables against expected values

2014-01-26 Thread Michael S. Tsirkin
From: Marcel Apfelbaum marce...@redhat.com This test will run only if iasl is installed on the host machine. The test plan: 1. Dumps the ACPI tables as AML on the disk. 2. Runs iasl to disassembly the tables into ASL files. 3. Runs iasl to disassembly the offline AML files into ASL files. 4.

[Qemu-devel] [PULL v2 05/35] acpi unit-test: add test files

2014-01-26 Thread Michael S. Tsirkin
From: Marcel Apfelbaum marce...@redhat.com Added unit-test's expected aml files to be compared with the actual ACPI tables. Signed-off-by: Marcel Apfelbaum marce...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- tests/acpi-test-data/pc/APIC | Bin 0 - 120 bytes

[Qemu-devel] [Bug 1263318] Re: Cannot add a USB 2.0 device under QEMU when running eudev

2014-01-26 Thread Serge Hallyn
** Changed in: qemu Status: New = Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1263318 Title: Cannot add a USB 2.0 device under QEMU when running eudev Status in QEMU: Invalid

[Qemu-devel] [PULL v2 12/35] tests: fix acpi to work on bigendian host

2014-01-26 Thread Michael S. Tsirkin
From: Alexey Kardashevskiy a...@ozlabs.ru Double endianness convertion make this test failing on POWERPC machine running in big-endian. This fixes the test to success on big-endian host. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

[Qemu-devel] [PULL v2 16/35] pc: make: fix dependencies: rebuild when included file is changed

2014-01-26 Thread Michael S. Tsirkin
From: Igor Mammedov imamm...@redhat.com some *.dsl files include another *.dsl files but there weren't any dependicies and when included file changed target table wasn't rebuild. Fix this by using the same auto dependency generation as for C files. Signed-off-by: Igor Mammedov

Re: [Qemu-devel] [PATCH v3] Fix QEMU build on OpenBSD on x86 archs

2014-01-26 Thread Paolo Bonzini
Il 26/01/2014 02:37, Brad Smith ha scritto: Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Is there some sort of process I am missing to have build fixes commited so that QEMU actually builds? Right now we have problems getting patches committed at all. This patch and the other NetBSD

[Qemu-devel] [PATCH 00/10] block: Integrate bdrv_file_open() into bdrv_open()

2014-01-26 Thread Max Reitz
bdrv_file_open() is now nearly a subset of bdrv_open(), except for the fact that bdrv_file_open() is for protocols and bdrv_open() for block drivers. It is possible to use bdrv_file_open() with a block driver, but in that case that block driver must be explicitly specified. Due to these great

[Qemu-devel] [PATCH 05/10] block: Reuse reference handling from bdrv_open()

2014-01-26 Thread Max Reitz
Remove the reference parameter and the related handling code from bdrv_file_open(), since it exists in bdrv_open() now as well. Signed-off-by: Max Reitz mre...@redhat.com --- block.c | 33 +++-- 1 file changed, 7 insertions(+), 26 deletions(-) diff --git a/block.c

[Qemu-devel] [PATCH 02/10] block: Add reference parameter to bdrv_open()

2014-01-26 Thread Max Reitz
Allow bdrv_open() to handle references to existing block devices just as bdrv_file_open() is already capable of. Signed-off-by: Max Reitz mre...@redhat.com --- block.c | 41 ++--- block/qcow2.c | 4 ++-- block/vmdk.c | 3 ++-

[Qemu-devel] [PATCH 07/10] block: Reuse fail path from bdrv_open()

2014-01-26 Thread Max Reitz
The fail paths of bdrv_file_open() and bdrv_open() naturally exhibit similarities, thus it is possible to reuse the one from bdrv_open() and shorten the one in bdrv_file_open() accordingly. Signed-off-by: Max Reitz mre...@redhat.com --- block.c | 17 +++-- 1 file changed, 7

[Qemu-devel] [PATCH 04/10] block: Reuse NULL options check from bdrv_open()

2014-01-26 Thread Max Reitz
Remove the check whether options is NULL form bdrv_file_open() and rely on the one in bdrv_open() instead. Signed-off-by: Max Reitz mre...@redhat.com --- block.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/block.c b/block.c index 0fb7892..c7219cb 100644

[Qemu-devel] [PATCH 10/10] block: Remove bdrv_open_image()'s force_raw option

2014-01-26 Thread Max Reitz
This option is now unnecessary since specifying BDRV_O_PROTOCOL as flag will do exactly the same. Signed-off-by: Max Reitz mre...@redhat.com --- block.c | 30 +- block/blkdebug.c | 2 +- block/blkverify.c | 4 ++-- include/block/block.h | 2

[Qemu-devel] [PATCH 08/10] block: Reuse bs-options setting from bdrv_open()

2014-01-26 Thread Max Reitz
Setting bs-options in bdrv_file_open() is not necessary if it is already done in bdrv_open(). Signed-off-by: Max Reitz mre...@redhat.com --- block.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/block.c b/block.c index 0f2cd3f..f847c4b 100644 --- a/block.c +++

[Qemu-devel] [PATCH 09/10] block: Reuse success path from bdrv_open()

2014-01-26 Thread Max Reitz
The fail and success paths of bdrv_file_open() may be further shortened by reusing code already existent in bdrv_open(). This includes bdrv_file_open() not taking the reference to options which allows the removal of QDECREF(options) in that function. Signed-off-by: Max Reitz mre...@redhat.com ---

[Qemu-devel] [PATCH 20/21] target-arm: A64: Add 2-reg-misc REV* instructions

2014-01-26 Thread Peter Maydell
From: Alex Bennée alex.ben...@linaro.org Add the byte-reverse operations REV64, REV32 and REV16 from the two-reg-misc group. Signed-off-by: Alex Bennée alex.ben...@linaro.org Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/translate-a64.c | 42

[Qemu-devel] [PATCH 19/21] target-arm: A64: Add narrowing 2-reg-misc instructions

2014-01-26 Thread Peter Maydell
Add the narrowing integer instructions in the 2-reg-misc class. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/translate-a64.c | 85 -- 1 file changed, 83 insertions(+), 2 deletions(-) diff --git a/target-arm/translate-a64.c

[Qemu-devel] [PATCH 17/21] target-arm: A64: Implement 2-register misc compares, ABS, NEG

2014-01-26 Thread Peter Maydell
Implement the simple 2-register-misc operations we can share with the scalar-two-register-misc code. (SUQADD, USQADD, SQABS, SQNEG also fall into this category, but aren't implemented in the scalar-2-register case yet either.) Signed-off-by: Peter Maydell peter.mayd...@linaro.org ---

[Qemu-devel] [PATCH 06/10] block: Remove bdrv_new() from bdrv_file_open()

2014-01-26 Thread Max Reitz
Change bdrv_file_open() to take a simple pointer to an already existing BDS instead of an indirect one. The BDS will be created in bdrv_open() if necessary. Signed-off-by: Max Reitz mre...@redhat.com --- block.c | 29 ++--- 1 file changed, 18 insertions(+), 11

[Qemu-devel] [PATCH 21/21] target-arm: A64: Add FNEG and FABS to the SIMD 2-reg-misc group

2014-01-26 Thread Peter Maydell
Add the SIMD FNEG and FABS instructions in the SIMD 2-reg-misc group. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/translate-a64.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/target-arm/translate-a64.c

[Qemu-devel] [PATCH 18/21] target-arm: A64: Implement 2-reg-misc CNT, NOT and RBIT

2014-01-26 Thread Peter Maydell
Implement the 2-reg-misc CNT, NOT and RBIT instructions. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/helper.h| 1 + target-arm/neon_helper.c | 12 target-arm/translate-a64.c | 34 -- 3 files changed, 41

[Qemu-devel] [PATCH 09/21] target-arm: A64: Implement SIMD 3-reg-same shift and saturate insns

2014-01-26 Thread Peter Maydell
Implement the SIMD 3-reg-same instructions SQADD, UQADD, SQSUB, UQSUB, SSHL, USHL, SQSHl, UQSHL, SRSHL, URSHL, SQRSHL, UQRSHL; these are all simple calls to existing Neon helpers. We also enable SSHL, USHL, SRSHL and URSHL for the 3-reg-same-scalar category (but not the others because they can

[Qemu-devel] [PATCH 00/21] A64: Add Neon instructions, second and third sets

2014-01-26 Thread Peter Maydell
This patch series is kind of in two parts. The first 8 patches are the Neon second set that's already been pretty much reviewed; I'm resending them just because there were a few minor nits that came up in the last round which have been fixed: * patch 6 added the missing SQDMULH/SQRDMULH

[Qemu-devel] [PATCH 13/21] target-arm: A64: Implement scalar pairwise ops

2014-01-26 Thread Peter Maydell
Implement the instructions in the scalar pairwise group (C3.6.8). Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/translate-a64.c | 114 - 1 file changed, 113 insertions(+), 1 deletion(-) diff --git a/target-arm/translate-a64.c

[Qemu-devel] [PATCH 02/21] target-arm: A64: Add SIMD three-different ABDL instructions

2014-01-26 Thread Peter Maydell
Implement the absolute-difference instructions in the SIMD three-different group: SABAL, SABAL2, UABAL, UABAL2, SABDL, SABDL2, UABDL, UABDL2. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Richard Henderson r...@twiddle.net --- target-arm/translate-a64.c | 35

[Qemu-devel] [PATCH 05/21] target-arm: A64: Add logic ops from SIMD 3 same group

2014-01-26 Thread Peter Maydell
Add support for the logical operations (ORR, AND, BIC, ORN, EOR, BSL, BIT and BIF) from the SIMD 3 register same group (C3.6.16). Signed-off-by: Alex Bennée alex.ben...@linaro.org Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Richard Henderson r...@twiddle.net ---

[Qemu-devel] [PATCH 10/21] target-arm: A64: Implement remaining non-pairwise int SIMD 3-reg-same insns

2014-01-26 Thread Peter Maydell
Implement the SIMD 3-reg-same instructions where the size == 3 case is reserved: SHADD, UHADD, SRHADD, URHADD, SHSUB, UHSUB, SMAX, UMAX, SMIN, UMIN, SABD, UABD, SABA, UABA, MLA, MLS, MUL, PMUL, SQRDMULH, SQDMULH. (None of these have scalar-3-same versions.) This completes the non-pairwise integer

[Qemu-devel] [PATCH 01/21] target-arm: A64: Add SIMD three-different multiply accumulate insns

2014-01-26 Thread Peter Maydell
Add support for the multiply-accumulate instructions from the SIMD three-different instructions group (C3.6.15): * skeleton decode of unallocated encodings and split of the group into its three sub-parts * framework for handling the 64x64-128 widening subpart * implementation of the

[Qemu-devel] [PATCH 07/21] target-arm: A64: Add simple SIMD 3-same floating point ops

2014-01-26 Thread Peter Maydell
Implement a simple subset of the SIMD 3-same floating point operations. This includes a common helper function used for both scalar and vector ops; FABD is the only currently implemented shared op. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Richard Henderson

[Qemu-devel] [PATCH 15/21] target-arm: A64: Add SIMD simple 64 bit insns from scalar 2-reg misc

2014-01-26 Thread Peter Maydell
Implement the simple 64 bit integer operations from the SIMD scalar 2-register misc group (C3.6.12): the comparisons against zero, plus ABS and NEG. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/translate-a64.c | 87 +- 1 file

[Qemu-devel] [PATCH 11/21] target-arm: A64: Implement pairwise integer ops from 3-reg-same SIMD

2014-01-26 Thread Peter Maydell
Implement the pairwise integer operations in the 3-reg-same SIMD group: ADDP, SMAXP, SMINP, UMAXP and UMINP. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/translate-a64.c | 145 - 1 file changed, 144 insertions(+), 1 deletion(-)

[Qemu-devel] [PATCH 06/21] target-arm: A64: Add integer ops from SIMD 3-same group

2014-01-26 Thread Peter Maydell
Add some of the integer operations in the SIMD 3-same group: specifically, the comparisons, addition and subtraction. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Richard Henderson r...@twiddle.net --- target-arm/translate-a64.c | 165

Re: [Qemu-devel] [PATCH 00/21] A64: Add Neon instructions, second and third sets

2014-01-26 Thread Peter Maydell
On 26 January 2014 19:24, Peter Maydell peter.mayd...@linaro.org wrote: This patch series is kind of in two parts. The first 8 patches are the Neon second set that's already been pretty much reviewed; I'm resending them just because there were a few minor nits that came up in the last round

[Qemu-devel] [PATCH 04/21] target-arm: A64: Add top level decode for SIMD 3-same group

2014-01-26 Thread Peter Maydell
Add top level decode for the A64 SIMD three regs same group (C3.6.16), splitting it into the pairwise, logical, float and integer subgroups. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Richard Henderson r...@twiddle.net --- target-arm/translate-a64.c | 45

[Qemu-devel] [PATCH 08/21] target-arm: A64: Add SIMD shift by immediate

2014-01-26 Thread Peter Maydell
From: Alex Bennée alex.ben...@linaro.org This implements a subset of the AdvSIMD shift operations (namely all the none saturating or narrowing ones). The actual shift generation code itself is common for both the scalar and vector cases but wrapped with either vector element iteration or the fp

[Qemu-devel] [PATCH 12/21] tcg: Add TCGV_UNUSED_PTR, TCGV_IS_UNUSED_PTR, TCGV_EQUAL_PTR

2014-01-26 Thread Peter Maydell
We have macros for marking TCGv values as unused, checking if they are unused and comparing them to each other. However these only exist for TCGv_i32 and TCGv_i64; add them for TCGv_ptr as well. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- tcg/tcg.h | 3 +++ 1 file changed, 3

[Qemu-devel] [PATCH 03/21] target-arm: A64: Add SIMD scalar 3 same add, sub and compare ops

2014-01-26 Thread Peter Maydell
Implement the add, sub and compare ops from the SIMD scalar three same group. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Richard Henderson r...@twiddle.net --- target-arm/translate-a64.c | 131 - 1 file changed, 130

[Qemu-devel] [PATCH 14/21] target-arm: A64: Implement remaining integer scalar-3-same insns

2014-01-26 Thread Peter Maydell
Implement the remaining integer instructions in the scalar-three-reg-same group: SQADD, UQADD, SQSUB, UQSUB, SQSHL, UQSHL, SQRSHL, UQRSHL, SQDMULH, SQRDMULH. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/translate-a64.c | 106 +

[Qemu-devel] [PATCH 03/10] block: Make bdrv_file_open() static

2014-01-26 Thread Max Reitz
Add the bdrv_open() option BDRV_O_PROTOCOL which results in passing the call to bdrv_file_open(). Additionally, make bdrv_file_open() static and therefore bdrv_open() the only way to call it. Consequently, all existing calls to bdrv_file_open() have to be adjusted to use bdrv_open() with the

[Qemu-devel] [PATCH 01/10] block: Change BDS parameter of bdrv_open() to **

2014-01-26 Thread Max Reitz
Make bdrv_open() take a pointer to a BDS pointer, similarly to bdrv_file_open(). If a pointer to a NULL pointer is given, bdrv_open() will create a new BDS with an empty name; if the BDS pointer is not NULL, that existing BDS will be reused (in the same way as bdrv_open() already did).

[Qemu-devel] [PATCH 16/21] target-arm: A64: Add skeleton decode for SIMD 2-reg misc group

2014-01-26 Thread Peter Maydell
Add a skeleton decode for the SIMD 2-reg misc group. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/translate-a64.c | 110 - 1 file changed, 109 insertions(+), 1 deletion(-) diff --git a/target-arm/translate-a64.c

Re: [Qemu-devel] [PULL] Update OpenBIOS images to r1246

2014-01-26 Thread Mark Cave-Ayland
On 12/01/14 15:25, Mark Cave-Ayland wrote: Hi Anthony, Please pull the latest OpenBIOS binary images. In particular, these images fix the following two bugs in SPARC32: - Booting with OBP instead of OpenBIOS - Booting from hard disk instead of CDROM

Re: [Qemu-devel] [PATCH v3 2/2] hw/arm/allwinner-a10: initialize EMAC

2014-01-26 Thread Beniamino Galvani
On Sun, Jan 26, 2014 at 12:42:59AM +0100, Andreas Färber wrote: Am 20.01.2014 00:25, schrieb Beniamino Galvani: Signed-off-by: Beniamino Galvani b.galv...@gmail.com --- hw/arm/allwinner-a10.c | 16 hw/arm/cubieboard.c|7 +++

Re: [Qemu-devel] [PATCH v3] Fix QEMU build on OpenBSD on x86 archs

2014-01-26 Thread Brad Smith
On 26/01/14 1:06 PM, Paolo Bonzini wrote: Il 26/01/2014 02:37, Brad Smith ha scritto: Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Is there some sort of process I am missing to have build fixes commited so that QEMU actually builds? Right now we have problems getting patches

[Qemu-devel] [PATCH v4 2/3] hw/net: add support for Allwinner EMAC Fast Ethernet controller

2014-01-26 Thread Beniamino Galvani
This patch adds support for the Fast Ethernet MAC found on Allwinner SoCs, together with a basic emulation of Realtek RTL8201CP PHY. Since there is no public documentation of the Allwinner controller, the implementation is based on Linux kernel driver. Signed-off-by: Beniamino Galvani

[Qemu-devel] [PATCH v4 0/3] hw/arm: add ethernet support to Allwinner A10

2014-01-26 Thread Beniamino Galvani
This patch series adds support for the EMAC Fast Ethernet controller found on Allwinner SoCs to the Allwinner A10. Changelog: v4: Address comments from Peter Crosthwaite and Andreas Färber: * Add functions for multiple bytes push/pop to Fifo8 * Get rid of custom fifo implementation and

[Qemu-devel] [PATCH v4 1/3] util/fifo8: implement push/pop of multiple bytes

2014-01-26 Thread Beniamino Galvani
In some circumstances it is useful to be able to push the entire content of a memory buffer to the fifo or to pop multiple bytes with a single operation. The functions fifo8_has_space() and fifo8_push_all() added by this patch allow to perform the first kind of operation efficiently. The

[Qemu-devel] [PATCH v4 3/3] hw/arm/allwinner-a10: initialize EMAC

2014-01-26 Thread Beniamino Galvani
Signed-off-by: Beniamino Galvani b.galv...@gmail.com --- hw/arm/allwinner-a10.c | 16 hw/arm/cubieboard.c| 11 +-- include/hw/arm/allwinner-a10.h |3 +++ 3 files changed, 28 insertions(+), 2 deletions(-) diff --git a/hw/arm/allwinner-a10.c

[Qemu-devel] [Bug 1272796] Re: Windows 98 First Edition emulation problems

2014-01-26 Thread Riccardo Bassani
Even with Windows 98 SE (English and Italian) still not working. Got some ideas? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1272796 Title: Windows 98 First Edition emulation problems Status in

Re: [Qemu-devel] [PATCH v3] Fix QEMU build on OpenBSD on x86 archs

2014-01-26 Thread Anthony Liguori
On Sun, Jan 26, 2014 at 1:40 PM, Brad Smith b...@comstyle.com wrote: On 26/01/14 1:06 PM, Paolo Bonzini wrote: Il 26/01/2014 02:37, Brad Smith ha scritto: Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Is there some sort of process I am missing to have build fixes commited so that

[Qemu-devel] Additional QEMU committer

2014-01-26 Thread Anthony Liguori
Hi, Things have been moving a bit more slowly upstream than the should recently. I'm happy to announce though that Peter Maydell has agreed to take on the responsibility of being a committer and will now be able to apply pull requests and push patches. I will continue to apply pull requests and

Re: [Qemu-devel] [PATCH v3] Fix QEMU build on OpenBSD on x86 archs

2014-01-26 Thread Brad Smith
On 26/01/14 5:12 PM, Anthony Liguori wrote: On Sun, Jan 26, 2014 at 1:40 PM, Brad Smith b...@comstyle.com wrote: On 26/01/14 1:06 PM, Paolo Bonzini wrote: Il 26/01/2014 02:37, Brad Smith ha scritto: Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Is there some sort of process I am

Re: [Qemu-devel] [PATCH 01/10] block: Change BDS parameter of bdrv_open() to **

2014-01-26 Thread Benoît Canet
Le Sunday 26 Jan 2014 à 20:02:34 (+0100), Max Reitz a écrit : Make bdrv_open() take a pointer to a BDS pointer, similarly to bdrv_file_open(). If a pointer to a NULL pointer is given, bdrv_open() will create a new BDS with an empty name; if the BDS pointer is not NULL, that existing BDS will

[Qemu-devel] [Qemu/Virtio-scsi]The feature of 'raw device mapping' cannot isolate the LUN to the owning virtual machine

2014-01-26 Thread Qixiaozhen
Hi,all A instance was created by virsh command in the CentOS 6.4. The LUN in the Storage Array Network(SAN) was attached to the instance with the following xml. disk type='block' device='lun' driver name='qemu' type='raw' cache='none'/ source

Re: [Qemu-devel] [PATCH 03/10] block: Make bdrv_file_open() static

2014-01-26 Thread Benoît Canet
Le Sunday 26 Jan 2014 à 20:02:36 (+0100), Max Reitz a écrit : Add the bdrv_open() option BDRV_O_PROTOCOL which results in passing the call to bdrv_file_open(). Additionally, make bdrv_file_open() static and therefore bdrv_open() the only way to call it. Consequently, all existing calls to

Re: [Qemu-devel] [PATCH 04/10] block: Reuse NULL options check from bdrv_open()

2014-01-26 Thread Benoît Canet
Le Sunday 26 Jan 2014 à 20:02:37 (+0100), Max Reitz a écrit : Remove the check whether options is NULL form bdrv_file_open() and rely s/form/for/g ? on the one in bdrv_open() instead. Signed-off-by: Max Reitz mre...@redhat.com --- block.c | 15 +-- 1 file changed, 5

Re: [Qemu-devel] [PATCH 05/10] block: Reuse reference handling from bdrv_open()

2014-01-26 Thread Benoît Canet
Le Sunday 26 Jan 2014 à 20:02:38 (+0100), Max Reitz a écrit : Remove the reference parameter and the related handling code from bdrv_file_open(), since it exists in bdrv_open() now as well. Signed-off-by: Max Reitz mre...@redhat.com --- block.c | 33 +++-- 1

Re: [Qemu-devel] [PATCH 06/10] block: Remove bdrv_new() from bdrv_file_open()

2014-01-26 Thread Benoît Canet
Le Sunday 26 Jan 2014 à 20:02:39 (+0100), Max Reitz a écrit : Change bdrv_file_open() to take a simple pointer to an already existing BDS instead of an indirect one. The BDS will be created in bdrv_open() if necessary. Signed-off-by: Max Reitz mre...@redhat.com --- block.c | 29

  1   2   >