Re: [PATCH v5 58/60] target/riscv: vector register gather instruction

2020-03-14 Thread Richard Henderson
On 3/12/20 7:58 AM, LIU Zhiwei wrote: > +static bool vrgather_vx_check(DisasContext *s, arg_rmrr *a) > +{ > +return (vext_check_isa_ill(s, RVV) && > +vext_check_overlap_mask(s, a->rd, a->vm, true) && > +vext_check_reg(s, a->rd, false) && > +vext_check_reg(s,

Re: [PATCH 2/8] hw/ide: Get rid of piix4_init function

2020-03-14 Thread Michael S. Tsirkin
On Fri, Mar 13, 2020 at 10:14:34PM +0100, BALATON Zoltan wrote: > This removes pci_piix4_ide_init() function similar to clean up done to > other ide devices. > > Signed-off-by: BALATON Zoltan > --- > hw/ide/piix.c| 12 +--- > hw/isa/piix4.c | 5 - > include/hw/ide.h | 1 - >

Re: [PATCH v5 54/60] target/riscv: integer extract instruction

2020-03-14 Thread Richard Henderson
On 3/14/20 10:15 PM, LIU Zhiwei wrote: > > > On 2020/3/15 10:53, Richard Henderson wrote: >> On 3/12/20 7:58 AM, LIU Zhiwei wrote: >>> +static bool trans_vext_x_v(DisasContext *s, arg_r *a) >>> +{ >>> +    if (vext_check_isa_ill(s, RVV)) { >>> +    TCGv_ptr src2; >>> +    TCGv dest,

Re: [PATCH v5 57/60] target/riscv: vector slide instructions

2020-03-14 Thread Richard Henderson
On 3/12/20 7:58 AM, LIU Zhiwei wrote: > +#define GEN_VEXT_VSLIDEUP_VX(NAME, ETYPE, H, CLEAR_FN)\ > +void HELPER(NAME)(void *vd, void *v0, target_ulong s1, void *vs2, \ > +CPURISCVState *env, uint32_t desc)\ > +{

Re: [PATCH v5 54/60] target/riscv: integer extract instruction

2020-03-14 Thread LIU Zhiwei
On 2020/3/15 10:53, Richard Henderson wrote: On 3/12/20 7:58 AM, LIU Zhiwei wrote: +static bool trans_vext_x_v(DisasContext *s, arg_r *a) +{ +if (vext_check_isa_ill(s, RVV)) { +TCGv_ptr src2; +TCGv dest, src1; +gen_helper_vext_x_v fns[4] = { +

Re: [PATCH v5 56/60] target/riscv: floating-point scalar move instructions

2020-03-14 Thread Richard Henderson
On 3/12/20 7:58 AM, LIU Zhiwei wrote: > Signed-off-by: LIU Zhiwei > --- > target/riscv/helper.h | 9 + > target/riscv/insn32.decode | 2 ++ > target/riscv/insn_trans/trans_rvv.inc.c | 47 + > target/riscv/vector_helper.c|

Re: [PATCH v5 55/60] target/riscv: integer scalar move instruction

2020-03-14 Thread Richard Henderson
On 3/12/20 7:58 AM, LIU Zhiwei wrote: > Signed-off-by: LIU Zhiwei > --- > target/riscv/helper.h | 5 + > target/riscv/insn32.decode | 1 + > target/riscv/insn_trans/trans_rvv.inc.c | 26 + > target/riscv/vector_helper.c| 15

Re: [PATCH v5 54/60] target/riscv: integer extract instruction

2020-03-14 Thread Richard Henderson
On 3/12/20 7:58 AM, LIU Zhiwei wrote: > +static bool trans_vext_x_v(DisasContext *s, arg_r *a) > +{ > +if (vext_check_isa_ill(s, RVV)) { > +TCGv_ptr src2; > +TCGv dest, src1; > +gen_helper_vext_x_v fns[4] = { > +gen_helper_vext_x_v_b, gen_helper_vext_x_v_h,

Re: [PATCH v5 53/60] target/riscv: vector element index instruction

2020-03-14 Thread Richard Henderson
On 3/12/20 7:58 AM, LIU Zhiwei wrote: > Signed-off-by: LIU Zhiwei > --- > target/riscv/helper.h | 5 + > target/riscv/insn32.decode | 2 ++ > target/riscv/insn_trans/trans_rvv.inc.c | 21 > target/riscv/vector_helper.c| 26

Re: [PATCH v5 52/60] target/riscv: vector iota instruction

2020-03-14 Thread Richard Henderson
On 3/12/20 7:58 AM, LIU Zhiwei wrote: > Signed-off-by: LIU Zhiwei > --- > target/riscv/helper.h | 5 > target/riscv/insn32.decode | 1 + > target/riscv/insn_trans/trans_rvv.inc.c | 22 ++ > target/riscv/vector_helper.c| 31

Re: [PATCH v5 50/60] target/riscv: vmfirst find-first-set mask bit

2020-03-14 Thread Richard Henderson
On 3/12/20 7:58 AM, LIU Zhiwei wrote: > +/* vmfirst find-first-set mask bit*/ > +target_ulong HELPER(vmfirst_m)(void *v0, void *vs2, CPURISCVState *env, > +uint32_t desc) > +{ > +uint32_t mlen = vext_mlen(desc); > +uint32_t vm = vext_vm(desc); > +uint32_t vl = env->vl; > +

Re: [PATCH v5 49/60] target/riscv: vector mask population count vmpopc

2020-03-14 Thread Richard Henderson
On 3/12/20 7:58 AM, LIU Zhiwei wrote: > +target_ulong HELPER(vmpopc_m)(void *v0, void *vs2, CPURISCVState *env, > +uint32_t desc) > +{ > +target_ulong cnt = 0; > +uint32_t mlen = vext_mlen(desc); > +uint32_t vm = vext_vm(desc); > +uint32_t vl = env->vl; > +int i; > + >

Re: [PATCH v5 24/60] target/riscv: vector single-width averaging add and subtract

2020-03-14 Thread Richard Henderson
On 3/14/20 4:12 PM, LIU Zhiwei wrote: > I am not sure whether I get it. In my opinion, the code should be modified > like > > static inline int8_t aadd8_rnu(CPURISCVState *env, int8_t a, int8_t b) > { >     int16_t res = (int16_t)a + (int16_t)b; >     uint8_t round = res & 0x1; >     res   =

Re: [PATCH v3 15/16] hw/i386/vmport: Add support for CMD_GETHZ

2020-03-14 Thread Liran Alon
On 14/03/2020 23:52, Michael S. Tsirkin wrote: On Sat, Mar 14, 2020 at 12:44:55AM +0200, Liran Alon wrote: On 13/03/2020 22:07, Philippe Mathieu-Daudé wrote: On 3/12/20 5:54 PM, Liran Alon wrote: diff --git a/include/hw/i386/vmport.h b/include/hw/i386/vmport.h index

Re: [PATCH 2/8] hw/ide: Get rid of piix4_init function

2020-03-14 Thread BALATON Zoltan
On Sat, 14 Mar 2020, Philippe Mathieu-Daudé wrote: On 3/13/20 10:14 PM, BALATON Zoltan wrote: This removes pci_piix4_ide_init() function similar to clean up done to other ide devices. Signed-off-by: BALATON Zoltan --- hw/ide/piix.c| 12 +--- hw/isa/piix4.c | 5 -

Re: [PATCH v5 47/60] target/riscv: vector widening floating-point reduction instructions

2020-03-14 Thread Richard Henderson
On 3/12/20 7:58 AM, LIU Zhiwei wrote: > Signed-off-by: LIU Zhiwei > --- > target/riscv/helper.h | 3 ++ > target/riscv/insn32.decode | 2 + > target/riscv/insn_trans/trans_rvv.inc.c | 3 ++ > target/riscv/vector_helper.c| 50 +

Re: [PATCH v5 46/60] target/riscv: vector single-width floating-point reduction instructions

2020-03-14 Thread Richard Henderson
On 3/12/20 7:58 AM, LIU Zhiwei wrote: > Signed-off-by: LIU Zhiwei > --- > target/riscv/helper.h | 10 +++ > target/riscv/insn32.decode | 4 +++ > target/riscv/insn_trans/trans_rvv.inc.c | 5 > target/riscv/vector_helper.c| 39

Re: [PATCH v5 45/60] target/riscv: vector wideing integer reduction instructions

2020-03-14 Thread Richard Henderson
On 3/12/20 7:58 AM, LIU Zhiwei wrote: > Signed-off-by: LIU Zhiwei > --- > target/riscv/helper.h | 7 +++ > target/riscv/insn32.decode | 2 ++ > target/riscv/insn_trans/trans_rvv.inc.c | 4 > target/riscv/vector_helper.c| 11 +++ > 4

Re: [PATCH v5 44/60] target/riscv: vector single-width integer reduction instructions

2020-03-14 Thread Richard Henderson
On 3/12/20 7:58 AM, LIU Zhiwei wrote: > Signed-off-by: LIU Zhiwei > --- > target/riscv/helper.h | 33 +++ > target/riscv/insn32.decode | 8 +++ > target/riscv/insn_trans/trans_rvv.inc.c | 17 ++ > target/riscv/vector_helper.c| 76

Re: [PATCH v5 24/60] target/riscv: vector single-width averaging add and subtract

2020-03-14 Thread LIU Zhiwei
On 2020/3/14 16:25, Richard Henderson wrote: On 3/14/20 1:14 AM, Richard Henderson wrote: I think you should have 4 versions of aadd8, for each of the rounding modes, +RVVCALL(OPIVV2_ENV, vaadd_vv_b, OP_SSS_B, H1, H1, H1, aadd8) then use this, or something like it, to define 4 functions

Re: [PATCH v5 43/60] target/riscv: narrowing floating-point/integer type-convert instructions

2020-03-14 Thread Richard Henderson
On 3/12/20 7:58 AM, LIU Zhiwei wrote: > +static uint32_t vfncvtffv32(uint64_t a, float_status *s) > +{ > +return float64_to_float32(a, s); > +} > +RVVCALL(OPFVV1, vfncvt_f_f_v_h, NOP_UU_H, H2, H4, vfncvtffv16) > +RVVCALL(OPFVV1, vfncvt_f_f_v_w, NOP_UU_W, H4, H8, vfncvtffv32) >

Re: [PATCH v5 42/60] target/riscv: widening floating-point/integer type-convert instructions

2020-03-14 Thread Richard Henderson
On 3/12/20 7:58 AM, LIU Zhiwei wrote: > +/* > + * vfwcvt.f.f.v vd, vs2, vm # > + * Convert single-width float to double-width float. > + */ > +static uint32_t vfwcvtffv16(uint16_t a, float_status *s) > +{ > +return float16_to_float32(a, true, s); > +} > +static uint64_t vfwcvtffv32(uint32_t a,

Re: [PATCH v5 41/60] target/riscv: vector floating-point/integer type-convert instructions

2020-03-14 Thread Richard Henderson
On 3/12/20 7:58 AM, LIU Zhiwei wrote: > Signed-off-by: LIU Zhiwei > --- > target/riscv/helper.h | 13 ++ > target/riscv/insn32.decode | 4 +++ > target/riscv/insn_trans/trans_rvv.inc.c | 6 + > target/riscv/vector_helper.c| 33

Re: [PATCH v5 40/60] target/riscv: vector floating-point merge instructions

2020-03-14 Thread Richard Henderson
On 3/12/20 7:58 AM, LIU Zhiwei wrote: > + > +/* Vector Floating-Point Merge Instruction */ > +static bool opfvf_vfmerge_check(DisasContext *s, arg_rmrr *a) > +{ > +return (vext_check_isa_ill(s, RVV) && > +vext_check_overlap_mask(s, a->rd, a->vm, false) && > +

Re: [PATCH 4/8] hw/arm/fsl-imx31: Wire up watchdog

2020-03-14 Thread Guenter Roeck
On 3/14/20 2:50 PM, Philippe Mathieu-Daudé wrote: [ ...] > Missing Kconfig hunk: > > -- >8 -- > diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig > index 4cf8fa4967..8af023abde 100644 > --- a/hw/arm/Kconfig > +++ b/hw/arm/Kconfig > @@ -366,6 +366,7 @@ config FSL_IMX31 > select SERIAL >

Re: [PATCH 1/8] hw: Move i.MX watchdog driver to hw/watchdog

2020-03-14 Thread Guenter Roeck
Hi Philippe, On 3/14/20 2:46 PM, Philippe Mathieu-Daudé wrote: [ ... ] > Corrected hunk: > > -- >8 -- > diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig > index e5a876c8d1..c662d5f1e0 100644 > --- a/hw/arm/Kconfig > +++ b/hw/arm/Kconfig > @@ -373,6 +373,7 @@ config FSL_IMX6 > select IMX >

Re: [PATCH 3/8] hw/arm/fsl-imx25: Wire up watchdog

2020-03-14 Thread Guenter Roeck
On 3/14/20 2:48 PM, Philippe Mathieu-Daudé wrote: [ ... ] > Here you also need: > > -- >8 -- > diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig > index c662d5f1e0..4cf8fa4967 100644 > --- a/hw/arm/Kconfig > +++ b/hw/arm/Kconfig > @@ -358,6 +358,7 @@ config FSL_IMX25 > select IMX > select

Re: [PATCH v5 39/60] target/riscv: vector floating-point classify instructions

2020-03-14 Thread Richard Henderson
On 3/14/20 2:15 AM, LIU Zhiwei wrote: >>> +static uint64_t fclass_d(uint64_t frs1, float_status *s) >>> +{ >>> +    float64 f = frs1; >>> +    bool sign = float64_is_neg(f); >>> + >>> +    if (float64_is_infinity(f)) { >>> +    return sign ? 1 << 0 : 1 << 7; >>> +    } else if

Re: [PATCH 5/8] hw/ide/pci.c: Coding style update to fix checkpatch errors

2020-03-14 Thread Philippe Mathieu-Daudé
On 3/13/20 10:14 PM, BALATON Zoltan wrote: Spaces are required around a + operator and if statements should have braces even for single line. Also make it simpler by reversing the condition instead of breaking the loop. Signed-off-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daudé ---

Re: [PATCH 3/8] hw/ide: Remove now unneded #include "hw/pci/pci.h" from hw/ide.h

2020-03-14 Thread Philippe Mathieu-Daudé
On 3/13/20 10:14 PM, BALATON Zoltan wrote: After previous patches we don't need hw/pci/pci.h any more in hw/ide.h. Some files depended on implicit inclusion by this header which are also fixed up here. Signed-off-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daudé ---

Re: [PATCH 2/8] hw/ide: Get rid of piix4_init function

2020-03-14 Thread Philippe Mathieu-Daudé
On 3/13/20 10:14 PM, BALATON Zoltan wrote: This removes pci_piix4_ide_init() function similar to clean up done to other ide devices. Signed-off-by: BALATON Zoltan --- hw/ide/piix.c| 12 +--- hw/isa/piix4.c | 5 - include/hw/ide.h | 1 - 3 files changed, 5

Re: [PATCH 1/8] hw/ide: Get rid of piix3_init functions

2020-03-14 Thread Philippe Mathieu-Daudé
On 3/13/20 10:14 PM, BALATON Zoltan wrote: This removes pci_piix3_ide_init() and pci_piix3_xen_ide_init() functions similar to clean up done to other ide devices. Signed-off-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daudé --- hw/i386/pc_piix.c | 10 +- hw/ide/pci.c

Re: [PATCH v3 15/16] hw/i386/vmport: Add support for CMD_GETHZ

2020-03-14 Thread Michael S. Tsirkin
On Sat, Mar 14, 2020 at 12:44:55AM +0200, Liran Alon wrote: > > On 13/03/2020 22:07, Philippe Mathieu-Daudé wrote: > > On 3/12/20 5:54 PM, Liran Alon wrote: > > > > > > diff --git a/include/hw/i386/vmport.h b/include/hw/i386/vmport.h > > > index 34cc050b1ffa..aee809521aa0 100644 > > > ---

Re: [PATCH] qemu-common.h: Update copyright string to include 2020

2020-03-14 Thread Programmingkid
> On Mar 14, 2020, at 5:33 PM, Philippe Mathieu-Daudé wrote: > > Extend the copyright range to include the current year. > > Reported-by: John Arbuckle > Signed-off-by: Philippe Mathieu-Daudé > --- > include/qemu-common.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [PATCH 4/8] hw/arm/fsl-imx31: Wire up watchdog

2020-03-14 Thread Philippe Mathieu-Daudé
On 3/14/20 6:27 PM, Guenter Roeck wrote: With this patch, the watchdog on i.MX31 emulations is fully operational. Signed-off-by: Guenter Roeck --- hw/arm/fsl-imx31.c | 6 ++ include/hw/arm/fsl-imx31.h | 4 2 files changed, 10 insertions(+) diff --git a/hw/arm/fsl-imx31.c

Re: [PATCH 3/8] hw/arm/fsl-imx25: Wire up watchdog

2020-03-14 Thread Philippe Mathieu-Daudé
On 3/14/20 6:27 PM, Guenter Roeck wrote: With this commit, the watchdog on imx25-pdk is fully operational, including pretimeout support. Signed-off-by: Guenter Roeck --- hw/arm/fsl-imx25.c | 10 ++ include/hw/arm/fsl-imx25.h | 5 + 2 files changed, 15 insertions(+)

Re: [PATCH 1/8] hw: Move i.MX watchdog driver to hw/watchdog

2020-03-14 Thread Philippe Mathieu-Daudé
On 3/14/20 10:43 PM, Philippe Mathieu-Daudé wrote: Hi Guenter, On 3/14/20 6:27 PM, Guenter Roeck wrote: In preparation for a full implementation, move i.MX watchdog driver from hw/misc to hw/watchdog. While at it, add the watchdog files to MAINTAINERS. Signed-off-by: Guenter Roeck ---  

Re: [PATCH 1/8] hw: Move i.MX watchdog driver to hw/watchdog

2020-03-14 Thread Philippe Mathieu-Daudé
Hi Guenter, On 3/14/20 6:27 PM, Guenter Roeck wrote: In preparation for a full implementation, move i.MX watchdog driver from hw/misc to hw/watchdog. While at it, add the watchdog files to MAINTAINERS. Signed-off-by: Guenter Roeck --- MAINTAINERS | 2

Re: [PATCH 4/4] usb-serial: Fix timeout closing the device

2020-03-14 Thread Samuel Thibault
Jason Andryuk, le jeu. 12 mars 2020 08:55:23 -0400, a ecrit: > Linux guests wait ~30 seconds when closing the emulated /dev/ttyUSB0. > During that time, the kernel driver is sending many control URBs > requesting GetModemStat (5). Real hardware returns a status with > FTDI_THRE (Transmitter

Re: [PATCH 3/4] usb-serial: Increase receive buffer to 496

2020-03-14 Thread Samuel Thibault
Jason Andryuk, le jeu. 12 mars 2020 08:55:22 -0400, a ecrit: > A FTDI USB adapter on an xHCI controller can send 512 byte USB packets. > These are 8 * ( 2 bytes header + 62 bytes data). A 384 byte receive > buffer is insufficient to fill a 512 byte packet, so bump the receive > size to 496 ( 512

[PATCH] qemu-common.h: Update copyright string to include 2020

2020-03-14 Thread Philippe Mathieu-Daudé
Extend the copyright range to include the current year. Reported-by: John Arbuckle Signed-off-by: Philippe Mathieu-Daudé --- include/qemu-common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qemu-common.h b/include/qemu-common.h index 082da59e85..d0142f29ac

Re: [PATCH v3 10/16] hw/i386/vmport: Add support for CMD_GETTIME

2020-03-14 Thread Michael S. Tsirkin
On Sat, Mar 14, 2020 at 10:05:20PM +0200, Liran Alon wrote: > Michael, you can also refer to this VMware time-keeping whitepaper: > https://www.vmware.com/pdf/vmware_timekeeping.pdf. > According to section "Initializing and Correcting Wall-Clock Time": > """ > VMware Tools can also optionally be

Re: [PATCH v3 10/16] hw/i386/vmport: Add support for CMD_GETTIME

2020-03-14 Thread Michael S. Tsirkin
On Sat, Mar 14, 2020 at 09:58:23PM +0200, Nikita Leshenko wrote: > I think that the reason that open-vm-tools doesn't move time backwards is to > help applications that treat wallclock time as if it's monotonic time and > break > if the date is moved backwards (which may happen more frequently in

Re: [PATCH v3 10/16] hw/i386/vmport: Add support for CMD_GETTIME

2020-03-14 Thread Nikita Leshenko
> On 14 Mar 2020, at 21:26, Michael S. Tsirkin wrote: > > On Sat, Mar 14, 2020 at 09:17:30PM +0200, Liran Alon wrote: >> >> On 14/03/2020 21:14, Michael S. Tsirkin wrote: >>> On Sat, Mar 14, 2020 at 09:04:30PM +0200, Liran Alon wrote: On 14/03/2020 20:18, Michael S. Tsirkin wrote: >

Re: [PATCH v3 10/16] hw/i386/vmport: Add support for CMD_GETTIME

2020-03-14 Thread Liran Alon
On 14/03/2020 21:58, Nikita Leshenko wrote: On 14 Mar 2020, at 21:26, Michael S. Tsirkin wrote: On Sat, Mar 14, 2020 at 09:17:30PM +0200, Liran Alon wrote: On 14/03/2020 21:14, Michael S. Tsirkin wrote: On Sat, Mar 14, 2020 at 09:04:30PM +0200, Liran Alon wrote: On 14/03/2020 20:18,

About dialog copyright date needs updating

2020-03-14 Thread Programmingkid
Hi Peter, in the About dialog for QEMU the copyright date shows as 2019. Can it be updated to 2020 please? Thank you.

Re: [PATCH v3 10/16] hw/i386/vmport: Add support for CMD_GETTIME

2020-03-14 Thread Michael S. Tsirkin
On Sat, Mar 14, 2020 at 09:17:30PM +0200, Liran Alon wrote: > > On 14/03/2020 21:14, Michael S. Tsirkin wrote: > > On Sat, Mar 14, 2020 at 09:04:30PM +0200, Liran Alon wrote: > > > On 14/03/2020 20:18, Michael S. Tsirkin wrote: > > > > On Fri, Mar 13, 2020 at 06:26:54PM +0200, Liran Alon wrote: >

Re: [PATCH v3 10/16] hw/i386/vmport: Add support for CMD_GETTIME

2020-03-14 Thread Liran Alon
On 14/03/2020 21:14, Michael S. Tsirkin wrote: On Sat, Mar 14, 2020 at 09:04:30PM +0200, Liran Alon wrote: On 14/03/2020 20:18, Michael S. Tsirkin wrote: On Fri, Mar 13, 2020 at 06:26:54PM +0200, Liran Alon wrote: On 13/03/2020 17:47, Michael S. Tsirkin wrote: On Fri, Mar 13, 2020 at

Re: [PATCH v3 10/16] hw/i386/vmport: Add support for CMD_GETTIME

2020-03-14 Thread Michael S. Tsirkin
On Sat, Mar 14, 2020 at 09:04:30PM +0200, Liran Alon wrote: > > On 14/03/2020 20:18, Michael S. Tsirkin wrote: > > On Fri, Mar 13, 2020 at 06:26:54PM +0200, Liran Alon wrote: > > > On 13/03/2020 17:47, Michael S. Tsirkin wrote: > > > > On Fri, Mar 13, 2020 at 05:25:20PM +0200, Liran Alon wrote: >

Re: [PATCH v3 07/16] hw/i386/vmport: Introduce vmport.h

2020-03-14 Thread Liran Alon
On 14/03/2020 20:25, Michael S. Tsirkin wrote: On Sat, Mar 14, 2020 at 09:31:31AM +0100, Philippe Mathieu-Daudé wrote: On 3/13/20 11:38 PM, Liran Alon wrote: On 13/03/2020 21:57, Philippe Mathieu-Daudé wrote: On 3/12/20 5:54 PM, Liran Alon wrote: No functional change. This is mere

Re: [PATCH v3 10/16] hw/i386/vmport: Add support for CMD_GETTIME

2020-03-14 Thread Liran Alon
On 14/03/2020 20:18, Michael S. Tsirkin wrote: On Fri, Mar 13, 2020 at 06:26:54PM +0200, Liran Alon wrote: On 13/03/2020 17:47, Michael S. Tsirkin wrote: On Fri, Mar 13, 2020 at 05:25:20PM +0200, Liran Alon wrote: @@ -168,6 +169,20 @@ static uint32_t vmport_cmd_ram_size(void *opaque,

Re: [PATCH v3 10/16] hw/i386/vmport: Add support for CMD_GETTIME

2020-03-14 Thread Liran Alon
On 14/03/2020 20:18, Michael S. Tsirkin wrote: On Fri, Mar 13, 2020 at 06:26:54PM +0200, Liran Alon wrote: On 13/03/2020 17:47, Michael S. Tsirkin wrote: On Fri, Mar 13, 2020 at 05:25:20PM +0200, Liran Alon wrote: @@ -168,6 +169,20 @@ static uint32_t vmport_cmd_ram_size(void *opaque,

Re: [PATCH v2 0/3]: acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-14 Thread Michael S. Tsirkin
On Fri, Mar 13, 2020 at 08:58:30AM -0700, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20200313145009.144820-1-liran.a...@oracle.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Subject: [PATCH v2

Re: [PATCH v3 07/16] hw/i386/vmport: Introduce vmport.h

2020-03-14 Thread Michael S. Tsirkin
On Sat, Mar 14, 2020 at 09:31:31AM +0100, Philippe Mathieu-Daudé wrote: > On 3/13/20 11:38 PM, Liran Alon wrote: > > On 13/03/2020 21:57, Philippe Mathieu-Daudé wrote: > > > On 3/12/20 5:54 PM, Liran Alon wrote: > > > > No functional change. This is mere refactoring. > > > > > > > > Suggested-by:

Re: [PATCH V2] vhost: correctly turn on VIRTIO_F_IOMMU_PLATFORM

2020-03-14 Thread Michael S. Tsirkin
On Fri, Mar 13, 2020 at 03:27:59PM -0500, Brijesh Singh wrote: > > On 3/13/20 7:44 AM, Halil Pasic wrote: > > [..] > >>> CCing Tom. @Tom does vhost-vsock work for you with SEV and current qemu? > >>> > >>> Also, one can specify iommu_platform=on on a device that ain't a part of > >>> a

Re: [PATCH v3 10/16] hw/i386/vmport: Add support for CMD_GETTIME

2020-03-14 Thread Michael S. Tsirkin
On Fri, Mar 13, 2020 at 06:26:54PM +0200, Liran Alon wrote: > > On 13/03/2020 17:47, Michael S. Tsirkin wrote: > > On Fri, Mar 13, 2020 at 05:25:20PM +0200, Liran Alon wrote: > > > > > @@ -168,6 +169,20 @@ static uint32_t vmport_cmd_ram_size(void > > > > > *opaque, uint32_t addr) > > > > >

Re: [PATCH] linux-user: Update TASK_UNMAPPED_BASE for aarch64

2020-03-14 Thread Laurent Vivier
Le 14/03/2020 à 18:01, Aleksandar Markovic a écrit : > On Sat, Mar 14, 2020 at 11:45 AM Laurent Vivier wrote: >> >> Le 14/03/2020 à 04:06, Aleksandar Markovic a écrit : >>> On Fri, Mar 13, 2020 at 1:28 AM Lirong Yuan wrote: This change updates TASK_UNMAPPED_BASE (the base address for

[PATCH 7/8] hw/arm/fsl-imx7: Instantiate various unimplemented devices

2020-03-14 Thread Guenter Roeck
Instantiating PWM, CAN, CAAM, and OCOTP devices is necessary to avoid crashes when booting mainline Linux. Signed-off-by: Guenter Roeck --- hw/arm/fsl-imx7.c | 24 include/hw/arm/fsl-imx7.h | 16 2 files changed, 40 insertions(+) diff --git

[PATCH 6/8] hw/arm/fsl-imx6ul: Connect watchdog interrupts

2020-03-14 Thread Guenter Roeck
With this commit, the watchdog on mcimx6ul-evk is fully operational, including pretimeout support. Signed-off-by: Guenter Roeck --- hw/arm/fsl-imx6ul.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/arm/fsl-imx6ul.c b/hw/arm/fsl-imx6ul.c index c405b68d1d..8d3b91dd85 100644

[PATCH 4/8] hw/arm/fsl-imx31: Wire up watchdog

2020-03-14 Thread Guenter Roeck
With this patch, the watchdog on i.MX31 emulations is fully operational. Signed-off-by: Guenter Roeck --- hw/arm/fsl-imx31.c | 6 ++ include/hw/arm/fsl-imx31.h | 4 2 files changed, 10 insertions(+) diff --git a/hw/arm/fsl-imx31.c b/hw/arm/fsl-imx31.c index

[PATCH 5/8] hw/arm/fsl-imx6: Connect watchdog interrupts

2020-03-14 Thread Guenter Roeck
With this patch applied, the watchdog in the sabrelite emulation is fully operational, including pretimeout support. Signed-off-by: Guenter Roeck --- hw/arm/fsl-imx6.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/arm/fsl-imx6.c b/hw/arm/fsl-imx6.c index ecc62855f2..b266d40881

[PATCH 8/8] hw/arm/fsl-imx7: Connect watchdog interrupts

2020-03-14 Thread Guenter Roeck
i.MX7 supports watchdog pretimeout interupts. With this commit, the watchdog in mcimx7d-sabre is fully operational, including pretimeout support. Signed-off-by: Guenter Roeck --- hw/arm/fsl-imx7.c | 11 +++ include/hw/arm/fsl-imx7.h | 5 + 2 files changed, 16 insertions(+)

[PATCH 3/8] hw/arm/fsl-imx25: Wire up watchdog

2020-03-14 Thread Guenter Roeck
With this commit, the watchdog on imx25-pdk is fully operational, including pretimeout support. Signed-off-by: Guenter Roeck --- hw/arm/fsl-imx25.c | 10 ++ include/hw/arm/fsl-imx25.h | 5 + 2 files changed, 15 insertions(+) diff --git a/hw/arm/fsl-imx25.c

[PATCH 0/8] hw/arm: Implement i.MX watchdog support

2020-03-14 Thread Guenter Roeck
The current i.MX watchdog implementation only supports resets. This patch series implements the full watchdog, including optional pretimeout support. Notable changes: - The existing i.MX watchdog emulation (which only emulates syste resets) is moved from hw/misc to hw/watchdog and renamed to

[PATCH 1/8] hw: Move i.MX watchdog driver to hw/watchdog

2020-03-14 Thread Guenter Roeck
In preparation for a full implementation, move i.MX watchdog driver from hw/misc to hw/watchdog. While at it, add the watchdog files to MAINTAINERS. Signed-off-by: Guenter Roeck --- MAINTAINERS | 2 ++ hw/misc/Makefile.objs |

[PATCH 2/8] hw/watchdog: Implement full i.MX watchdog support

2020-03-14 Thread Guenter Roeck
Implement full support for the watchdog in i.MX systems. Pretimeout support is optional because the watchdog hardware on i.MX31 does not support pretimeouts. Signed-off-by: Guenter Roeck --- hw/watchdog/Makefile.objs | 2 +- hw/watchdog/wdt_imx2.c | 196

Re: [PATCH] linux-user: Update TASK_UNMAPPED_BASE for aarch64

2020-03-14 Thread Aleksandar Markovic
On Sat, Mar 14, 2020 at 11:45 AM Laurent Vivier wrote: > > Le 14/03/2020 à 04:06, Aleksandar Markovic a écrit : > > On Fri, Mar 13, 2020 at 1:28 AM Lirong Yuan wrote: > >> > >> This change updates TASK_UNMAPPED_BASE (the base address for guest > >> programs) for aarch64. It is needed to allow

Re: [PATCH v1] mips/mips_malta: Allow more than 2G RAM

2020-03-14 Thread Aleksandar Markovic
On Sat, Mar 14, 2020 at 1:28 PM Jiaxun Yang wrote: > > > > 在 星期六, 2020-03-14 17:09:08 Philippe Mathieu-Daudé > 撰写 > > Hi Aleksandar, > > > > > >> > > >> This is annoying, because the CoreLV/CoreFPGA core cards only have 4 > > >> DIMM slots for PC-100 SDRAM, and the Memory

Re: [PATCH 2/5] tests/docker: make "buildah bud" output similar to "docker build"

2020-03-14 Thread Alex Bennée
Cleber Rosa writes: > Podman users will most often be using buildah to build containers. > Among the differences between "buildah bud|build-using-dockerfile" and > a traditional "docker build" is that buildah does not run a container > during build. > > To the best of my knowledge and

Re: [PATCH v4 2/3] mac_via: fix incorrect creation of mos6522 device in mac_via

2020-03-14 Thread Paolo Bonzini
On 14/03/20 14:19, Mark Cave-Ayland wrote: >> Observe that mac_via_init() has obvious side effects. In particular, it >> creates two devices that are then visible in "info qtree", and that's >> caught by device-introspect-test. >> >> I believe these things need to be done in .realize(). That is

Re: [PATCH] tools/virtiofsd: add support for --socket-group

2020-03-14 Thread Marc-André Lureau
Hi On Thu, Mar 12, 2020 at 11:49 AM Daniel P. Berrangé wrote: > > On Thu, Mar 12, 2020 at 10:41:42AM +, Alex Bennée wrote: > > If you like running QEMU as a normal user (very common for TCG runs) > > but you have to run virtiofsd as a root user you run into connection > > problems. Adding

Re: [PATCH] tools/virtiofsd: add support for --socket-group

2020-03-14 Thread Stefan Hajnoczi
On Thu, Mar 12, 2020 at 10:41:42AM +, Alex Bennée wrote: > If you like running QEMU as a normal user (very common for TCG runs) > but you have to run virtiofsd as a root user you run into connection > problems. Adding support for an optional --socket-group allows the > users to keep using the

Re: [PATCH v5 0/4] delay timer_new from init to realize to fix memleaks.

2020-03-14 Thread Mark Cave-Ayland
On 14/03/2020 08:47, Pan Nengyuan wrote: > This series delay timer_new from init into realize to avoid memleaks when we > call 'device_list_properties'. > And do timer_free only in s390x_cpu_finalize because it's hotplugable. > However, mos6522_realize is never called > at all due to the

Re: [PATCH v4 2/3] mac_via: fix incorrect creation of mos6522 device in mac_via

2020-03-14 Thread Mark Cave-Ayland
On 10/03/2020 09:07, Markus Armbruster wrote: > Widespread QOM usage anti-pattern ahead; cc: QOM maintainers. > > Peter Maydell writes: > >> On Mon, 9 Mar 2020 at 10:02, Pan Nengyuan wrote: >>> On 3/9/2020 5:21 PM, Peter Maydell wrote: Could you explain more? My thought is that we should

Re: [PATCH v1] mips/mips_malta: Allow more than 2G RAM

2020-03-14 Thread Jiaxun Yang
在 星期六, 2020-03-14 17:09:08 Philippe Mathieu-Daudé 撰写 > Hi Aleksandar, > > >> > >> This is annoying, because the CoreLV/CoreFPGA core cards only have 4 > >> DIMM slots for PC-100 SDRAM, and the Memory Controller of the GT–64120A > >> north bridge accept at most 256 MiB per

Re: [PATCH v2 0/4] linux-user: generate syscall_nr.h from linux unistd.h

2020-03-14 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200314113922.233353-1-laur...@vivier.eu/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash

Re: [PATCH v3 07/16] hw/i386/vmport: Introduce vmport.h

2020-03-14 Thread Liran Alon
On 14/03/2020 10:31, Philippe Mathieu-Daudé wrote: On 3/13/20 11:38 PM, Liran Alon wrote: On 13/03/2020 21:57, Philippe Mathieu-Daudé wrote: On 3/12/20 5:54 PM, Liran Alon wrote: No functional change. This is mere refactoring. Suggested-by: Michael S. Tsirkin Signed-off-by: Liran Alon

Re: [PATCH 0/8] Misc hw/ide legacy clean up

2020-03-14 Thread Paolo Bonzini
On 14/03/20 12:45, Mark Cave-Ayland wrote: > On 13/03/2020 21:14, BALATON Zoltan wrote: > >> These are some clean ups to remove more legacy init functions and >> lessen dependence on include/hw/ide.h with some simplifications in >> board code. There should be no functional change. >> >> BALATON

Re: [PATCH 0/8] Misc hw/ide legacy clean up

2020-03-14 Thread Mark Cave-Ayland
On 13/03/2020 21:14, BALATON Zoltan wrote: > These are some clean ups to remove more legacy init functions and > lessen dependence on include/hw/ide.h with some simplifications in > board code. There should be no functional change. > > BALATON Zoltan (8): > hw/ide: Get rid of piix3_init

[PATCH v2 4/4] linux-user, openrisc: sync syscall numbers with kernel v5.5

2020-03-14 Thread Laurent Vivier
Use helper script scripts/gensyscalls.sh to generate the file. Add TARGET_NR_or1k_atomic Remove useless comments and blank lines. Define diretly the __NR_XXX64 syscalls rather than using the intermediate __NR3264 definition. Remove wrong cut'n'paste (like "#ifdef __ARCH_WANT_SYNC_FILE_RANGE2")

[PATCH v2 0/4] linux-user: generate syscall_nr.h from linux unistd.h

2020-03-14 Thread Laurent Vivier
This series adds a script to generate syscall_nr.h for architectures that don't use syscall.tbl but asm-generic/unistd.h The script uses several cpp passes and filters result with a grep/sed/tr sequence. The result must be checked before being used, so it's why the script is not automatically

[PATCH v2 2/4] linux-user, aarch64: sync syscall numbers with kernel v5.5

2020-03-14 Thread Laurent Vivier
Use helper script scripts/gensyscalls.sh to generate the file. This change TARGET_NR_fstatat64 by TARGET_NR_newfstatat that is correct because definitions from linux are: arch/arm64/include/uapi/asm/unistd.h #define __ARCH_WANT_NEW_STAT include/uapi/asm-generic/unistd.h #if

[PATCH v2 3/4] linux-user, nios2: sync syscall numbers with kernel v5.5

2020-03-14 Thread Laurent Vivier
Use helper script scripts/gensyscalls.sh to generate the file. This adds TARGET_NR_llseek that was missing and remove syscalls 1024 to 1079. Add new syscalls from 288 (pkey_mprotect) to 434 (pidfd_open) Signed-off-by: Laurent Vivier Reviewed-by: Alistair Francis --- Notes: v2: add

[PATCH v2 1/4] scripts: add a script to generate syscall_nr.h

2020-03-14 Thread Laurent Vivier
This script is needed for targets based on asm-generic syscall numbers generation Signed-off-by: Laurent Vivier Reviewed-by: Alistair Francis Reviewed-by: Taylor Simpson --- Notes: v2: add comments suggested by Taylor scripts/gensyscalls.sh | 102

Re: [PATCH] softmmu/vl.c: Handle '-cpu help' and '-device help' before 'no default machine'

2020-03-14 Thread Markus Armbruster
Peter Maydell writes: > Currently if you try to ask for the list of CPUs for a target > architecture which does not specify a default machine type > you just get an error: > > $ qemu-system-arm -cpu help > qemu-system-arm: No machine specified, and there is no default > Use -machine help

Re: [PATCH v8 3/4] linux-user: Support futex_time64

2020-03-14 Thread Laurent Vivier
Le 14/03/2020 à 00:56, Alistair Francis a écrit : > Add support for host and target futex_time64. If futex_time64 exists on > the host we try that first before falling back to the standard futux > syscall. > > Signed-off-by: Alistair Francis > --- > linux-user/syscall.c | 144

Re: [PATCH v8 3/4] linux-user: Support futex_time64

2020-03-14 Thread Laurent Vivier
Le 14/03/2020 à 00:56, Alistair Francis a écrit : > Add support for host and target futex_time64. If futex_time64 exists on > the host we try that first before falling back to the standard futux > syscall. > > Signed-off-by: Alistair Francis > --- > linux-user/syscall.c | 144

Re: [PATCH 8/9] hw/core: Add qdev stub for user-mode

2020-03-14 Thread Paolo Bonzini
On 14/03/20 11:49, Philippe Mathieu-Daudé wrote: >>> >>> diff --git a/hw/core/Makefile.objs b/hw/core/Makefile.objs >>> index 6215e7c208..89bf247173 100644 >>> --- a/hw/core/Makefile.objs >>> +++ b/hw/core/Makefile.objs >>> @@ -8,6 +8,7 @@ common-obj-y += vmstate-if.o >>>   # irq.o needed for qdev

Re: [PATCH 8/9] hw/core: Add qdev stub for user-mode

2020-03-14 Thread Philippe Mathieu-Daudé
On 3/14/20 10:46 AM, Philippe Mathieu-Daudé wrote: On 3/13/20 7:46 PM, Philippe Mathieu-Daudé wrote: While user-mode does not use peripherals (devices), it uses a CPU which is a device. In the next commit we will reduce the QAPI generated code for user-mode. Since qdev.c calls

Re: [PATCH] linux-user: Update TASK_UNMAPPED_BASE for aarch64

2020-03-14 Thread Laurent Vivier
Le 14/03/2020 à 04:06, Aleksandar Markovic a écrit : > On Fri, Mar 13, 2020 at 1:28 AM Lirong Yuan wrote: >> >> This change updates TASK_UNMAPPED_BASE (the base address for guest programs) >> for aarch64. It is needed to allow qemu to work with Thread Sanitizer >> (TSan), which has specific

Re: [PATCH 6/8] hw/ide: Do ide_drive_get() within pci_ide_create_devs()

2020-03-14 Thread Paolo Bonzini
On 13/03/20 23:16, BALATON Zoltan wrote: >> >> +    pci_dev = pci_create_simple(pci_bus, -1, "cmd646-ide"); >> +    pci_ide_create_devs(pci_dev); > > Additionally, I think it may also make sense to move pci_ide_create_devs > call into the realize methods of these IDE controllers so boards do not

Re: [PATCH v2] exec/rom_reset: Free rom data during inmigrate skip

2020-03-14 Thread Paolo Bonzini
On 13/03/20 17:02, Peter Maydell wrote: > Reviewed-by: Peter Maydell Queued, thanks. Paolo

Re: [PATCH 8/9] hw/core: Add qdev stub for user-mode

2020-03-14 Thread Philippe Mathieu-Daudé
On 3/13/20 7:46 PM, Philippe Mathieu-Daudé wrote: While user-mode does not use peripherals (devices), it uses a CPU which is a device. In the next commit we will reduce the QAPI generated code for user-mode. Since qdev.c calls qapi_event_send_device_deleted(), let's add a stub for it.

Re: [PATCH v2 0/2] Fix MAP_SYNC support when host has older glibc version

2020-03-14 Thread Paolo Bonzini
On 12/03/20 00:23, Eduardo Habkost wrote: > Changes v1 -> v2: > * Use -isystem for $PWD/linux-headers too > Reported-by: "Michael S. Tsirkin" > > This is an alternative to the patch submitted at: > > From: Jingqi Liu > Subject: [PATCH] util: fix to get configuration macros in

Re: [PATCH 0/7] via-ide: fixes and improvements

2020-03-14 Thread Mark Cave-Ayland
On 13/03/2020 17:57, John Snow wrote: > On 3/13/20 4:24 AM, Mark Cave-Ayland wrote: >> Following on from the earlier thread "Implement "non 100% native mode" >> in via-ide", here is an updated patchset based upon the test cases >> sent to me off-list. >> >> The VIA IDE controller is similar to

Re: [PATCH v5 39/60] target/riscv: vector floating-point classify instructions

2020-03-14 Thread LIU Zhiwei
On 2020/3/14 17:10, Richard Henderson wrote: On 3/12/20 7:58 AM, LIU Zhiwei wrote: +/* Vector Floating-Point Classify Instruction */ +static uint16_t fclass_f16(uint16_t frs1, float_status *s) +{ +float16 f = frs1; +bool sign = float16_is_neg(f); + +if (float16_is_infinity(f)) {

Re: [PATCH v5 38/60] target/riscv: vector floating-point compare instructions

2020-03-14 Thread LIU Zhiwei
On 2020/3/14 17:08, Richard Henderson wrote: On 3/12/20 7:58 AM, LIU Zhiwei wrote: +static uint8_t float16_eq_quiet(uint16_t a, uint16_t b, float_status *s) +{ +int compare = float16_compare_quiet(a, b, s); +if (compare == float_relation_equal) { +return 1; +} else { +

Re: [PATCH v5 39/60] target/riscv: vector floating-point classify instructions

2020-03-14 Thread Richard Henderson
On 3/12/20 7:58 AM, LIU Zhiwei wrote: > +/* Vector Floating-Point Classify Instruction */ > +static uint16_t fclass_f16(uint16_t frs1, float_status *s) > +{ > +float16 f = frs1; > +bool sign = float16_is_neg(f); > + > +if (float16_is_infinity(f)) { > +return sign ? 1 << 0 : 1

Re: [PATCH v1] mips/mips_malta: Allow more than 2G RAM

2020-03-14 Thread Philippe Mathieu-Daudé
Hi Aleksandar, (+Aurelien for Debian) (+Peter regarding changing default) On 3/14/20 4:25 AM, Aleksandar Markovic wrote: On Thu, Mar 5, 2020 at 11:18 AM Philippe Mathieu-Daudé wrote: Please post new patches as v2, and do not post them as reply to v1. On 3/3/20 1:41 AM, Jiaxun Yang wrote:

Re: [PATCH v5 38/60] target/riscv: vector floating-point compare instructions

2020-03-14 Thread Richard Henderson
On 3/12/20 7:58 AM, LIU Zhiwei wrote: > +static uint8_t float16_eq_quiet(uint16_t a, uint16_t b, float_status *s) > +{ > +int compare = float16_compare_quiet(a, b, s); > +if (compare == float_relation_equal) { > +return 1; > +} else { > +return 0; > +} > +} You

  1   2   >