Re: [PATCH 0/5] qmp-shell modifications for non-interactive use

2022-02-21 Thread Damien Hedde
On 2/22/22 07:10, Markus Armbruster wrote: Damien Hedde writes: Hi, The main idea of this series is to be a bit more user-friendly when using qmp-shell in a non-interactive way: with an input redirection from a file containing a list of commands. I'm working on dynamic qapi config of a

Re: [PATCH 17/31] vdpa: adapt vhost_ops callbacks to svq

2022-02-21 Thread Eugenio Perez Martin
On Tue, Feb 22, 2022 at 4:16 AM Jason Wang wrote: > > On Tue, Feb 22, 2022 at 1:23 AM Eugenio Perez Martin > wrote: > > > > On Mon, Feb 21, 2022 at 8:15 AM Jason Wang wrote: > > > > > > > > > 在 2022/2/18 上午1:13, Eugenio Perez Martin 写道: > > > > On Tue, Feb 8, 2022 at 4:58 AM Jason Wang wrote:

Re: [PATCH 28/31] vdpa: Expose VHOST_F_LOG_ALL on SVQ

2022-02-21 Thread Jason Wang
在 2022/2/17 下午4:22, Eugenio Perez Martin 写道: On Thu, Feb 17, 2022 at 7:02 AM Jason Wang wrote: On Wed, Feb 16, 2022 at 11:54 PM Eugenio Perez Martin wrote: On Tue, Feb 8, 2022 at 9:25 AM Jason Wang wrote: 在 2022/2/1 下午7:45, Eugenio Perez Martin 写道: On Sun, Jan 30, 2022 at 7:50 AM Jason

Re: [PATCH v2 2/2] hw/acpi: add indication for i8042 in IA-PC boot flags of the FADT table

2022-02-21 Thread Ani Sinha
> > > > diff --git a/hw/i386/acpi-microvm.c b/hw/i386/acpi-microvm.c > > index 68ca7e7fc2..756c69b3b0 100644 > > --- a/hw/i386/acpi-microvm.c > > +++ b/hw/i386/acpi-microvm.c > > @@ -189,6 +189,11 @@ static void acpi_build_microvm(AcpiBuildTables *tables, > > .reset_val =

Re: [PATCH 18/31] vhost: Shadow virtqueue buffers forwarding

2022-02-21 Thread Jason Wang
在 2022/2/21 下午4:15, Eugenio Perez Martin 写道: On Mon, Feb 21, 2022 at 8:44 AM Jason Wang wrote: 在 2022/2/17 下午8:48, Eugenio Perez Martin 写道: On Tue, Feb 8, 2022 at 9:16 AM Jason Wang wrote: 在 2022/2/1 下午7:25, Eugenio Perez Martin 写道: On Sun, Jan 30, 2022 at 7:47 AM Jason Wang wrote: 在

[PATCH v3 0/2] hw/i386: OVMF table parsing fixes

2022-02-21 Thread Dov Murik
Fix missing bounds check when parsing the OVMF table. This already had two iterations as a single patch; I decided to split it to two patches. The first deals only with bounds checking, and the second is a non-functional change to clear the code according to reviewers' suggestions. v3: -

Re: [PATCH 09/31] vhost-vdpa: Take into account SVQ in vhost_vdpa_set_vring_call

2022-02-21 Thread Jason Wang
在 2022/2/21 下午4:01, Eugenio Perez Martin 写道: On Mon, Feb 21, 2022 at 8:39 AM Jason Wang wrote: 在 2022/2/18 下午8:35, Eugenio Perez Martin 写道: On Tue, Feb 8, 2022 at 4:23 AM Jason Wang wrote: 在 2022/1/31 下午11:34, Eugenio Perez Martin 写道: On Sat, Jan 29, 2022 at 9:06 AM Jason Wang wrote:

[PATCH v3 1/2] hw/i386: Improve bounds checking in OVMF table parsing

2022-02-21 Thread Dov Murik
When pc_system_parse_ovmf_flash() parses the optional GUIDed table in the end of the OVMF flash memory area, the table length field is checked for sizes that are too small, but doesn't error on sizes that are too big (bigger than the flash content itself). Add a check for maximal size of the OVMF

[PATCH v3 2/2] hw/i386: Replace magic number with field length calculation

2022-02-21 Thread Dov Murik
Replce the literal magic number 48 with length calculation (32 bytes at the end of the firmware after the table footer + 16 bytes of the OVMF table footer GUID). No functional change intended. Signed-off-by: Dov Murik --- hw/i386/pc_sysfw_ovmf.c | 9 ++--- 1 file changed, 6 insertions(+),

Re: [PATCH v2 2/2] hw/acpi: add indication for i8042 in IA-PC boot flags of the FADT table

2022-02-21 Thread Ani Sinha
> }; > +if (isa_check_device_existence("i8042")) { > +/* Indicates if i8042 is present or not */ > +fadt.iapc_boot_arch = (1 << 1); > +} > + > *data = fadt; > } > We do these things slightly differently. how about /* * second bit of 16 but IAPC_BOOT_ARCH

Re: [PATCH v2 2/2] hw/acpi: add indication for i8042 in IA-PC boot flags of the FADT table

2022-02-21 Thread Ani Sinha
On Mon, 21 Feb 2022, Liav Albani wrote: > This can allow the guest OS to determine more easily if i8042 controller > is present in the system or not, so it doesn't need to do probing of the > controller, but just initialize it immediately, before enumerating the > ACPI AML namespace. > >

Re: [PATCH v2] hw/i386: Improve bounds checking in OVMF table parsing

2022-02-21 Thread Dov Murik
Thanks Dave for reviewing. On 21/02/2022 21:44, Dr. David Alan Gilbert wrote: > * Dov Murik (dovmu...@linux.ibm.com) wrote: >> When pc_system_parse_ovmf_flash() parses the optional GUIDed table in >> the end of the OVMF flash memory area, the table length field is checked >> for sizes that are

Re: [PATCH 0/5] qmp-shell modifications for non-interactive use

2022-02-21 Thread Markus Armbruster
Damien Hedde writes: > Hi, > > The main idea of this series is to be a bit more user-friendly when > using qmp-shell in a non-interactive way: with an input redirection > from a file containing a list of commands. > > I'm working on dynamic qapi config of a qemu machine, this would > be very

Re: [PATCH 2/3] util/main-loop: Introduce the main loop into QOM

2022-02-21 Thread Markus Armbruster
Nicolas Saenz Julienne writes: > 'event-loop-backend' provides basic property handling for all > 'AioContext' based event loops. So let's define a new 'MainLoopClass' > that inherits from it. This will permit tweaking the main loop's > properties through qapi as well as through the command line

Re: [PATCH v8 5/5] multifd: Implement zero copy write in multifd migration (multifd-zero-copy)

2022-02-21 Thread Leonardo Bras Soares Passos
On Mon, Feb 21, 2022 at 4:41 PM Leonardo Bras Soares Passos wrote: > > Hello Juan, thanks for the feedback! > > On Fri, Feb 18, 2022 at 1:57 PM Juan Quintela wrote: > > > > Leonardo Bras wrote: > > > Implement zero copy send on nocomp_send_write(), by making use of > > > QIOChannel > > >

Re: [PATCH 17/31] vdpa: adapt vhost_ops callbacks to svq

2022-02-21 Thread Jason Wang
On Tue, Feb 22, 2022 at 1:23 AM Eugenio Perez Martin wrote: > > On Mon, Feb 21, 2022 at 8:15 AM Jason Wang wrote: > > > > > > 在 2022/2/18 上午1:13, Eugenio Perez Martin 写道: > > > On Tue, Feb 8, 2022 at 4:58 AM Jason Wang wrote: > > >> > > >> 在 2022/2/1 上午2:58, Eugenio Perez Martin 写道: > > >>> On

Re: [PATCH 15/20] migration: Allow migrate-recover to run multiple times

2022-02-21 Thread Peter Xu
On Mon, Feb 21, 2022 at 05:03:24PM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > Previously migration didn't have an easy way to cleanup the listening > > transport, migrate recovery only allows to execute once. That's done with a > > trick flag in

RE: [PATCH] multifd: ensure multifd threads are terminated before cleanup params

2022-02-21 Thread Wangxin (Alexander)
Ping. > > In multifd_save_cleanup(), we terminate all multifd threads and destroy > the 'p->mutex', while the mutex may still be held by multifd send thread, > this causes qemu to crash. > > It's because the multifd_send_thread maybe scheduled out after setting > 'p->running' to false. To

Re: [PATCH v4 12/12] KVM: Expose KVM_MEM_PRIVATE

2022-02-21 Thread Maciej S. Szmigiero
On 17.02.2022 14:45, Chao Peng wrote: On Tue, Jan 25, 2022 at 09:20:39PM +0100, Maciej S. Szmigiero wrote: On 18.01.2022 14:21, Chao Peng wrote: KVM_MEM_PRIVATE is not exposed by default but architecture code can turn on it by implementing kvm_arch_private_memory_supported(). Also private

Re: [PATCH 1/1] vdpa: Make ncs autofree

2022-02-21 Thread Laurent Vivier
Le 14/02/2022 à 20:34, Eugenio Pérez a écrit : Simplifying memory management. Signed-off-by: Eugenio Pérez --- net/vhost-vdpa.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index 4125d13118..4befba5cc7 100644 ---

[RFC PATCH] gitlab: upgrade the job definition for s390x to 20.04

2022-02-21 Thread Alex Bennée
The new s390x machine has more of everything including the OS. As 18.04 will soon be going we might as well get onto something moderately modern. Signed-off-by: Alex Bennée Cc: Christian Borntraeger Cc: Peter Maydell --- .gitlab-ci.d/custom-runners.yml | 2 +-

[PATCH v2 17/18] iotests: make qemu_img_log() check log level

2022-02-21 Thread John Snow
Improve qemu_img_log() to actually check if logging is turned on. If it isn't, revert to the behavior of qemu_img(). This is done so that there really is no way to avoid scrutinizing qemu-ing subprocess calls by accident. You're gonna have to work for it. Signed-off-by: John Snow ---

Re: [PATCH 0/2] Resolve some redundant property accessors

2022-02-21 Thread Bernhard Beschow
Am 21. Februar 2022 22:28:00 UTC schrieb "Philippe Mathieu-Daudé" : >On 17/2/22 23:53, Bernhard Beschow wrote: >> The QOM API already provides appropriate accessors, so reuse them. >> >> Testing done: >> >>:$ make check >>Ok: 569 >>Expected Fail: 0 >>Fail:

[PATCH v2 18/18] iotests: reimplement img_info_log in terms of qemu_img_log

2022-02-21 Thread John Snow
Now every last call to qemu_img is certifiably either checked or logged. Signed-off-by: John Snow --- tests/qemu-iotests/iotests.py | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index

Re: [PATCH v5 1/2] semihosting/arm-compat: replace heuristic for softmmu SYS_HEAPINFO

2022-02-21 Thread Alex Bennée
Peter Maydell writes: > On Mon, 21 Feb 2022 at 17:06, Alex Bennée wrote: >> >> >> Peter Maydell writes: >> >> > On Thu, 10 Feb 2022 at 11:30, Alex Bennée wrote: >> >> >> >> The previous numbers were a guess at best and rather arbitrary without >> >> taking into account anything that might

[PATCH v2 15/18] iotests: remove qemu_img_log('create', ...) calls

2022-02-21 Thread John Snow
qemu_img_log() calls into qemu_img_pipe(), which always removes output for 'create' commands on success anyway. Replace all of these calls to the simpler qemu_img_create(...) which doesn't log, but raises a detailed exception object on failure instead. Blank lines are removed from output files

[PATCH v2 14/18] iotests: move has_working_luks onto qemu_img()

2022-02-21 Thread John Snow
Admittedly a mostly lateral move; the diagnostics are slightly better on program crash. Signed-off-by: John Snow --- tests/qemu-iotests/iotests.py | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py

[PATCH v2 09/18] iotests: remove-bitmap-from-backing: use qemu_img_info()

2022-02-21 Thread John Snow
Remove two more usages of qemu_img_pipe(). Signed-off-by: John Snow --- tests/qemu-iotests/tests/remove-bitmap-from-backing | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/qemu-iotests/tests/remove-bitmap-from-backing

[PATCH v2 16/18] iotests: remove qemu_img_pipe()

2022-02-21 Thread John Snow
With the exceptional 'create' calls removed in the prior commit, change qemu_img_log() and img_info_log() to call qemu_img() directly instead. In keeping with the spirit of diff-based tests, allow these calls to qemu_img() to return an unchecked non-zero status code -- because any error we'd see

[PATCH v2 12/18] iotests: replace unchecked calls to qemu_img_pipe()

2022-02-21 Thread John Snow
qemu_img_pipe() discards the return code in favor of returning just the output. Some tests using this function don't save, log, or check the output either, though. Replace those calls to a checked version as appropriate. Tests affected are 194, 202, 203, 234, 262, and 303. Signed-off-by: John

[PATCH v2 10/18] iotests: add qemu_img_map() function

2022-02-21 Thread John Snow
By analogy with qemu_img_{measure, check, info}. Replace calls to qemu_img_pipe('map', '--output=json', ...) with the new function. Signed-off-by: John Snow --- tests/qemu-iotests/041 | 5 ++--- tests/qemu-iotests/211 | 6 +++---

[PATCH v2 11/18] iotests: change supports_quorum to use qemu_img

2022-02-21 Thread John Snow
Similar to other recent changes: use the qemu_img invocation that supports throwing loud, nasty exceptions when it fails for surprising reasons. (Why would "--help" ever fail? I don't know, but consistency is like a well-manicured bonsai.) Signed-off-by: John Snow ---

[PATCH v2 08/18] iotests: add qemu_img_info()

2022-02-21 Thread John Snow
Add qemu_img_info() by analogy with qemu_img_{measure,check}. Modify image_size() to use this function instead. Signed-off-by: John Snow --- tests/qemu-iotests/065| 5 ++--- tests/qemu-iotests/242| 5 ++--- tests/qemu-iotests/iotests.py | 12 3 files changed, 12

[PATCH v2 04/18] iotests: make qemu_img raise on non-zero rc by default

2022-02-21 Thread John Snow
re-write qemu_img() as a function that will by default raise a VerboseProcessException (extended from CalledProcessException) on non-zero return codes. This will produce a stack trace that will show the command line arguments and return code from the failed process run. Users that want something

[PATCH v2 03/18] iotests: Remove explicit checks for qemu_img() == 0

2022-02-21 Thread John Snow
qemu_img() returning zero ought to be the rule, not the exception. Remove all explicit checks against the condition in preparation for making non-zero returns an Exception. Signed-off-by: John Snow Reviewed-by: Eric Blake --- tests/qemu-iotests/163 | 9 +++--

[PATCH v2 07/18] iotests: use qemu_img_json() when applicable

2022-02-21 Thread John Snow
These functions should now give better crash information when something unexpected happens. Signed-off-by: John Snow --- tests/qemu-iotests/iotests.py | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index

[PATCH v2 01/18] python/utils: add enboxify() text decoration utility

2022-02-21 Thread John Snow
>>> print(enboxify(msg, width=72, name="commit message")) ┏━ commit message ━┓ ┃ enboxify() takes a chunk of text and wraps it in a text art box that ┃ ┃ adheres to a specified width. An optional title label may be given, ┃ ┃ and any of the

[PATCH v2 05/18] iotests: fortify compare_images() against crashes

2022-02-21 Thread John Snow
Make this helper function a little stricter about what it allows by default. If qemu_img returns some exit code that implies it didn't actually perform the comparison, treat that as an exceptional circumstance and force the caller to be aware of the peril. Signed-off-by: John Snow ---

[PATCH v2 06/18] iotests: add qemu_img_json()

2022-02-21 Thread John Snow
A little helper built on top of qemu_img() that tries to pull a valid JSON document out of the stdout stream. In the event that the return code is negative (the program crashed), or the code is greater than zero and did not produce valid JSON output, the VerboseProcessError raised by qemu_img is

[PATCH v2 02/18] iotests: add VerboseProcessError

2022-02-21 Thread John Snow
This adds an Exception that extends the Python built-in subprocess.CalledProcessError. When this exception is raised, it will still be caught when selecting for the stdlib variant. The difference is that the str() method of this Exception also adds the stdout/stderr logs. In effect, if this

[PATCH v2 00/18] iotests: add detailed tracebacks to qemu_img() failures

2022-02-21 Thread John Snow
This series does two things: (1) Adds more detailed information to terminal output when qemu-img crashes or returns with a non-zero exit code (2) Ensures that every last call to qemu-img made in the iotest test suite either returns a zero, *or* has its output logged. This is

[PATCH v2 13/18] iotests: remove external calls to qemu_img_pipe()

2022-02-21 Thread John Snow
Several cases here rely on the knowledge that qemu_img_pipe() suppresses *all* output on a successful case when the command being issued is 'create'. 065: This call's output is inspected, but it appears as if it's expected to succeed. Replace this call with the checked qemu_img() variant

Re: [PATCH 08/11] mos6522: add "info via" HMP command for debugging

2022-02-21 Thread Mark Cave-Ayland
On 21/02/2022 17:11, Daniel P. Berrangé wrote: On Sun, Feb 20, 2022 at 05:18:33PM +, Mark Cave-Ayland wrote: On 08/02/2022 13:10, Daniel P. Berrangé wrote: On Tue, Feb 08, 2022 at 01:06:59PM +, Mark Cave-Ayland wrote: On 08/02/2022 12:49, Daniel P. Berrangé wrote: I was under the

Re: [PATCH 0/2] Resolve some redundant property accessors

2022-02-21 Thread Philippe Mathieu-Daudé
On 17/2/22 23:53, Bernhard Beschow wrote: The QOM API already provides appropriate accessors, so reuse them. Testing done: :$ make check Ok: 569 Expected Fail: 0 Fail: 0 Unexpected Pass:0 Skipped:178 Timeout:0

Re: [PATCH 08/11] mos6522: add "info via" HMP command for debugging

2022-02-21 Thread Mark Cave-Ayland
On 21/02/2022 12:20, Philippe Mathieu-Daudé wrote: +Thomas On 20/2/22 18:18, Mark Cave-Ayland wrote: On 08/02/2022 13:10, Daniel P. Berrangé wrote: On Tue, Feb 08, 2022 at 01:06:59PM +, Mark Cave-Ayland wrote: On 08/02/2022 12:49, Daniel P. Berrangé wrote: I was under the impression

Re: [PATCH 2/2] hw/riscv/sifive_u: Resolve redundant property accessors

2022-02-21 Thread Philippe Mathieu-Daudé
On 17/2/22 23:53, Bernhard Beschow wrote: The QOM API already provides accessors for uint32 values, so reuse them. Signed-off-by: Bernhard Beschow --- hw/riscv/sifive_u.c | 24 1 file changed, 4 insertions(+), 20 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 1/2] hw/vfio/pci-quirks: Resolve redundant property getters

2022-02-21 Thread Philippe Mathieu-Daudé
On 17/2/22 23:53, Bernhard Beschow wrote: The QOM API already provides getters for uint64 and uint32 values, so reuse them. Signed-off-by: Bernhard Beschow --- hw/vfio/pci-quirks.c | 34 +- 1 file changed, 9 insertions(+), 25 deletions(-) Reviewed-by:

Re: [RFC PATCH v2 2/3] hw/intc: Support 32/64-bit mtimecmp and mtime accesses in RISC-V ACLINT

2022-02-21 Thread Alistair Francis
On Thu, Feb 10, 2022 at 4:22 PM wrote: > > From: Frank Chang > > RISC-V privilege spec defines that: > > * In RV32, memory-mapped writes to mtimecmp modify only one 32-bit part > of the register. > * For RV64, naturally aligned 64-bit memory accesses to the mtime and > mtimecmp registers are

Re: [RFC PATCH v2 3/3] hw/intc: Make RISC-V ACLINT mtime MMIO register writable

2022-02-21 Thread Alistair Francis
On Thu, Feb 10, 2022 at 4:22 PM wrote: > > From: Frank Chang > > RISC-V privilege spec defines that mtime is exposed as a memory-mapped > machine-mode read-write register. However, as QEMU uses host monotonic > timer as timer source, this makes mtime to be read-only in RISC-V > ACLINT. > > This

Re: [RFC PATCH v2 2/3] hw/intc: Support 32/64-bit mtimecmp and mtime accesses in RISC-V ACLINT

2022-02-21 Thread Alistair Francis
On Thu, Feb 10, 2022 at 4:22 PM wrote: > > From: Frank Chang > > RISC-V privilege spec defines that: > > * In RV32, memory-mapped writes to mtimecmp modify only one 32-bit part > of the register. > * For RV64, naturally aligned 64-bit memory accesses to the mtime and > mtimecmp registers are

Re: [RFC PATCH v2 1/3] hw/intc: Add .impl.[min|max]_access_size declaration in RISC-V ACLINT

2022-02-21 Thread Alistair Francis
On Thu, Feb 10, 2022 at 4:19 PM wrote: > > From: Frank Chang > > If device's MemoryRegion doesn't have .impl.[min|max]_access_size > declaration, the default access_size_min would be 1 byte and > access_size_max would be 4 bytes (see: softmmu/memory.c). > This will cause a 64-bit memory access

Re: [PATCH 2/2] hw/riscv/sifive_u: Resolve redundant property accessors

2022-02-21 Thread Alistair Francis
On Fri, Feb 18, 2022 at 8:54 AM Bernhard Beschow wrote: > > The QOM API already provides accessors for uint32 values, so reuse them. > > Signed-off-by: Bernhard Beschow Reviewed-by: Alistair Francis Alistair > --- > hw/riscv/sifive_u.c | 24 > 1 file changed, 4

Re: [PATCH v3 4/6] target/riscv: Add support for mconfigptr

2022-02-21 Thread Alistair Francis
On Sun, Feb 6, 2022 at 7:43 PM Atish Patra wrote: > > RISC-V privileged specification v1.12 introduced a mconfigptr > which will hold the physical address of a configuration data > structure. As Qemu doesn't have a configuration data structure, > is read as zero which is valid as per the priv

Re: [PATCH v3 3/6] target/riscv: Introduce privilege version field in the CSR ops.

2022-02-21 Thread Alistair Francis
On Sun, Feb 6, 2022 at 7:19 PM Atish Patra wrote: > > To allow/disallow the CSR access based on the privilege spec, a new field > in the csr_ops is introduced. It also adds the privileged specification > version (v1.12) for the CSRs introduced in the v1.12. This includes the > new ratified

Re: [PATCH v3 6/6] target/riscv: Enable privileged spec version 1.12

2022-02-21 Thread Alistair Francis
On Sun, Feb 6, 2022 at 7:51 PM Atish Patra wrote: > > Virt machine uses privileged specification version 1.12 now. > All other machine continue to use the default one defined for that > machine unless changed to 1.12 by the user explicitly. > > Signed-off-by: Atish Patra Reviewed-by: Alistair

Re: [PATCH v3 2/6] target/riscv: Add the privileged spec version 1.12.0

2022-02-21 Thread Alistair Francis
On Sun, Feb 6, 2022 at 7:37 PM Atish Patra wrote: > > Add the definition for ratified privileged specification version v1.12 > > Signed-off-by: Atish Patra Reviewed-by: Alistair Francis Alistair > --- > target/riscv/cpu.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH v3 1/6] target/riscv: Define simpler privileged spec version numbering

2022-02-21 Thread Alistair Francis
On Sun, Feb 6, 2022 at 7:26 PM Atish Patra wrote: > > Currently, the privileged specification version are defined in > a complex manner for no benefit. > > Simplify it by changing it to a simple enum based on. > > Suggested-by: Richard Henderson > Signed-off-by: Atish Patra Reviewed-by:

Re: [PATCH v3 0/3] linux-user/ppc: Deliver SIGTRAP on tw[i]/td[i]

2022-02-21 Thread Matheus K. Ferst
Ping. All patches reviewed and the series still applies to master with no conflicts. On 13/01/2022 14:04, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst In the review of 66c6b40aba1, Richard Henderson suggested[1] using "trap" instead of ".long 0x0" to generate the signal to test

Re: [PATCH v2 0/3] qapi: Move RTC_CHANGE back out of target schema

2022-02-21 Thread Eric Auger
Hi Peter, On 2/21/22 8:21 PM, Peter Maydell wrote: > This patchset moves RTC_CHANGE back to misc.json, effectively > reverting commit 183e4281a30962, which moved the RTC_CHANGE event to > the target schema. That change was an attempt to make the event > target-specific to improve introspection,

Re: [PATCH v2 2/2] hw/acpi: add indication for i8042 in IA-PC boot flags of the FADT table

2022-02-21 Thread Liav Albani
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index ebd47aa26f..5dc625b8d8 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -192,6 +192,11 @@ static void init_common_fadt_data(MachineState *ms, Object *o, .address = object_property_get_uint(o,

Re: [PATCH v8 5/5] multifd: Implement zero copy write in multifd migration (multifd-zero-copy)

2022-02-21 Thread Leonardo Bras Soares Passos
On Fri, Feb 18, 2022 at 2:36 PM Juan Quintela wrote: > > Leonardo Bras Soares Passos wrote: > > Hello Peter, thanks for reviewing! > > > > On Mon, Feb 7, 2022 at 11:22 PM Peter Xu wrote: > >> > >> On Tue, Feb 01, 2022 at 03:29:03AM -0300, Leonardo Bras wrote: > >> > -void

Re: [PATCH] block/curl.c: Check error return from curl_easy_setopt()

2022-02-21 Thread Peter Maydell
On Tue, 1 Feb 2022 at 11:25, Hanna Reitz wrote: > > On 28.01.22 17:55, Peter Maydell wrote: > > Coverity points out that we aren't checking the return value > > from curl_easy_setopt() for any of the calls to it we make > > in block/curl.c. > > > > Fixes: Coverity CID 1459336, 1459482, 1460331 >

Re: [PATCH v2] hw/i386: Improve bounds checking in OVMF table parsing

2022-02-21 Thread Dr. David Alan Gilbert
* Dov Murik (dovmu...@linux.ibm.com) wrote: > When pc_system_parse_ovmf_flash() parses the optional GUIDed table in > the end of the OVMF flash memory area, the table length field is checked > for sizes that are too small, but doesn't error on sizes that are too > big (bigger than the flash

Re: [PATCH v8 5/5] multifd: Implement zero copy write in multifd migration (multifd-zero-copy)

2022-02-21 Thread Leonardo Bras Soares Passos
Hello Juan, thanks for the feedback! On Fri, Feb 18, 2022 at 1:57 PM Juan Quintela wrote: > > Leonardo Bras wrote: > > Implement zero copy send on nocomp_send_write(), by making use of QIOChannel > > writev + flags & flush interface. > > > > Change multifd_send_sync_main() so flush_zero_copy()

Re: [PATCH v2 2/3] qapi: Document some missing details of RTC_CHANGE event

2022-02-21 Thread Philippe Mathieu-Daudé
On 21/2/22 20:21, Peter Maydell wrote: The RTC_CHANGE event's documentation is missing some details: * the offset argument is in units of seconds * it isn't guaranteed that the RTC will implement the event Signed-off-by: Peter Maydell --- v1->v2: add the "RTC might not implement this" note

Re: [PATCH v2 1/3] qapi: Move RTC_CHANGE back out of target schema

2022-02-21 Thread Philippe Mathieu-Daudé
On 21/2/22 20:21, Peter Maydell wrote: This commit effectively reverts commit 183e4281a30962, which moved the RTC_CHANGE event to the target schema. That change was an attempt to make the event target-specific to improve introspection, but the event isn't really target-specific: it's machine or

[PATCH v2 0/3] qapi: Move RTC_CHANGE back out of target schema

2022-02-21 Thread Peter Maydell
This patchset moves RTC_CHANGE back to misc.json, effectively reverting commit 183e4281a30962, which moved the RTC_CHANGE event to the target schema. That change was an attempt to make the event target-specific to improve introspection, but the event isn't really target-specific: it's machine or

Re: [PATCH v2 3/3] hw/rtc: Compile pl031 once-only

2022-02-21 Thread Philippe Mathieu-Daudé
On 21/2/22 20:21, Peter Maydell wrote: Now that the RTC_CHANGE event is no longer target-specific, we can move the pl031 back to a compile-once source file rather than a compile-per-target one. Signed-off-by: Peter Maydell --- hw/rtc/meson.build | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2 1/3] qapi: Move RTC_CHANGE back out of target schema

2022-02-21 Thread Peter Maydell
This commit effectively reverts commit 183e4281a30962, which moved the RTC_CHANGE event to the target schema. That change was an attempt to make the event target-specific to improve introspection, but the event isn't really target-specific: it's machine or device specific. Putting RTC_CHANGE in

[PATCH v2 3/3] hw/rtc: Compile pl031 once-only

2022-02-21 Thread Peter Maydell
Now that the RTC_CHANGE event is no longer target-specific, we can move the pl031 back to a compile-once source file rather than a compile-per-target one. Signed-off-by: Peter Maydell --- hw/rtc/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/rtc/meson.build

[PATCH v2 2/2] hw/acpi: add indication for i8042 in IA-PC boot flags of the FADT table

2022-02-21 Thread Liav Albani
This can allow the guest OS to determine more easily if i8042 controller is present in the system or not, so it doesn't need to do probing of the controller, but just initialize it immediately, before enumerating the ACPI AML namespace. Signed-off-by: Liav Albani --- hw/acpi/aml-build.c

[PATCH v2 2/3] qapi: Document some missing details of RTC_CHANGE event

2022-02-21 Thread Peter Maydell
The RTC_CHANGE event's documentation is missing some details: * the offset argument is in units of seconds * it isn't guaranteed that the RTC will implement the event Signed-off-by: Peter Maydell --- v1->v2: add the "RTC might not implement this" note --- qapi/misc.json | 6 -- 1 file

[PATCH v2 1/2] hw/isa: add function to check for existence of device by its type

2022-02-21 Thread Liav Albani
This function enumerates all attached ISA devices in the machine, and tries to compare a given device type name to the enumerated devices. For example, this can help other code to determine if a i8042 controller exists in the machine. Signed-off-by: Liav Albani --- hw/isa/isa-bus.c | 23

Re: [PULL 00/10] Misc next patches

2022-02-21 Thread Daniel P . Berrangé
On Fri, Feb 18, 2022 at 08:05:12PM +, Peter Maydell wrote: > On Thu, 17 Feb 2022 at 12:01, Daniel P. Berrangé wrote: > > > > The following changes since commit ad38520bdeb2b1e0b487db317f29119e94c1c88d: > > > > Merge remote-tracking branch > >

[PATCH v2 0/2] hw/acpi: add indication for i8042 in IA-PC boot flags of the FADT table

2022-02-21 Thread Liav Albani
This can allow the guest OS to determine more easily if i8042 controller is present in the system or not, so it doesn't need to do probing of the controller, but just initialize it immediately, before enumerating the ACPI AML namespace. To allow "flexible" indication, I don't hardcode the bit at

Re: [PATCH v2 2/2] hw/ide: add ich6 ide controller device emulation

2022-02-21 Thread Liav Albani
On 2/21/22 13:33, Gerd Hoffmann wrote: Hi, ICH6 and ICH7 IDE controllers are quite the same as far as I know. I could change it, but then one could argue that the name ich6-ide seems like "ich9-ide", so not sure if we can really go on this path. I think we don't actually have ich9-ide,

Re: [PATCH] analyze-migration.py: Fix instance_id signedness

2022-02-21 Thread Philippe Mathieu-Daudé
On 21/2/22 18:53, Fabiano Rosas wrote: The instance_id field is uint32_t in the migration code, however the script currently handles it as a signed integer: $ ./scripts/analyze-migration.py -f mig Traceback (most recent call last): File "./scripts/analyze-migration.py", line 605, in

Re: [PATCH 17/20] migration: Postcopy preemption preparation on channel creation

2022-02-21 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Create a new socket for postcopy to be prepared to send postcopy requested > pages via this specific channel, so as to not get blocked by precopy pages. > > A new thread is also created on dest qemu to receive data from this new > channel > based on the

Re: [PATCH 0/2] qapi: Move RTC_CHANGE back out of target schema

2022-02-21 Thread Peter Maydell
On Sat, 25 Sept 2021 at 08:44, Markus Armbruster wrote: > > Peter Maydell writes: > > > This patchset moves RTC_CHANGE back to misc.json, effectively > > reverting commit 183e4281a30962, which moved the RTC_CHANGE event to > > the target schema. That change was an attempt to make the event > >

[PATCH] analyze-migration.py: Fix instance_id signedness

2022-02-21 Thread Fabiano Rosas
The instance_id field is uint32_t in the migration code, however the script currently handles it as a signed integer: $ ./scripts/analyze-migration.py -f mig Traceback (most recent call last): File "./scripts/analyze-migration.py", line 605, in dump.read(dump_memory = args.memory)

Re: [PATCH 0/2] Adds designware i2c module and adds it to virt arm

2022-02-21 Thread Chris Rauer
Hi Phil, > What about using virtio-gpio & bitbang I2C? > > - virtio-gpio > https://lore.kernel.org/qemu-devel/20201127182917.2387-5-i...@metux.net/ > > - bitbang I2C already in: hw/i2c/bitbang_i2c.c Sorry for the delay. That looks like it might be doable with a bit more work creating the ACPI

Re: [PATCH] qapi, target/i386/sev: Add cpu0-id to query-sev-capabilities

2022-02-21 Thread Dov Murik
Thanks Daniel for reviewing. On 21/02/2022 18:24, Daniel P. Berrangé wrote: > On Mon, Feb 21, 2022 at 04:08:50PM +, Dov Murik wrote: >> Add a new field 'cpu0-id' to the response of query-sev-capabilities >> QMP command. The value of the field is the hex-encoded 64-byte unique >> ID of the

Re: [PATCH] qemu-options: fix incorrect description for '-drive index='

2022-02-21 Thread Laurent Vivier
Le 02/02/2022 à 15:34, Laurent Vivier a écrit : qemu-options.hx contains grammar that a native English-speaking person would never use. Replace "This option defines where is connected the drive" by "This option defines where the drive is connected". Fixes:

Re: [RFC PATCH 3/3] tests/tcg/ppc64le: Use vector types instead of __int128

2022-02-21 Thread Matheus K. Ferst
On 17/02/2022 09:46, Matheus K. Ferst wrote: On 17/02/2022 05:09, Cédric Le Goater wrote: On 2/8/22 21:31, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst LLVM/Clang doesn't like inline asm with __int128, use a vector type instead. Signed-off-by: Matheus Ferst --- Alternatively,

[PATCH v2] iotests: Write test output to TEST_DIR

2022-02-21 Thread Hanna Reitz
Drop the use of OUTPUT_DIR (test/qemu-iotests under the build directory), and instead write test output files (.out.bad, .notrun, and .casenotrun) to TEST_DIR. With this, the same test can be run concurrently without the separate instances interfering, because they will need separate TEST_DIRs

Re: [PATCH 2/2] iotests/303: Check for zstd support

2022-02-21 Thread Thomas Huth
On 21/02/2022 18.08, Hanna Reitz wrote: 303 runs two test cases, one of which requires zstd support. Unfortunately, given that this is not a unittest-style test, we cannot easily skip that single case, and instead can only skip the whole test. (Alternatively, we could split this test into a

Re: [PATCH v5 1/2] semihosting/arm-compat: replace heuristic for softmmu SYS_HEAPINFO

2022-02-21 Thread Peter Maydell
On Mon, 21 Feb 2022 at 17:06, Alex Bennée wrote: > > > Peter Maydell writes: > > > On Thu, 10 Feb 2022 at 11:30, Alex Bennée wrote: > >> > >> The previous numbers were a guess at best and rather arbitrary without > >> taking into account anything that might be loaded. Instead of using > >>

Re: [PULL v2 00/25] target-arm queue

2022-02-21 Thread Peter Maydell
r/tags/pull-ppc-20220218' into > staging (2022-02-20 15:05:41 +) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20220221-1 > > for you to fetch changes up to ca511604925eef8572e22e

Re: [PATCH 17/31] vdpa: adapt vhost_ops callbacks to svq

2022-02-21 Thread Eugenio Perez Martin
On Mon, Feb 21, 2022 at 8:15 AM Jason Wang wrote: > > > 在 2022/2/18 上午1:13, Eugenio Perez Martin 写道: > > On Tue, Feb 8, 2022 at 4:58 AM Jason Wang wrote: > >> > >> 在 2022/2/1 上午2:58, Eugenio Perez Martin 写道: > >>> On Sun, Jan 30, 2022 at 5:03 AM Jason Wang wrote: > 在 2022/1/22 上午4:27,

Re: [PATCH] target/avr: Correct AVRCPUClass docstring

2022-02-21 Thread Laurent Vivier
Le 22/01/2022 à 01:10, Philippe Mathieu-Daudé via a écrit : There is no 'vr' field in AVRCPUClass. Likely a copy/paste typo from CRISCPUClass ;) Signed-off-by: Philippe Mathieu-Daudé --- target/avr/cpu-qom.h | 1 - 1 file changed, 1 deletion(-) diff --git a/target/avr/cpu-qom.h

Re: [PATCH] hw/nvram: use at24 macro

2022-02-21 Thread Laurent Vivier
Le 25/01/2022 à 10:20, Paolo Bonzini a écrit : On 1/19/22 22:43, Patrick Venture wrote: Use the macro for going from I2CSlave to EEPROMState. Signed-off-by: Patrick Venture ---   hw/nvram/eeprom_at24c.c | 2 +-   1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 1/2] iotests/065: Check for zstd support

2022-02-21 Thread Thomas Huth
On 21/02/2022 18.08, Hanna Reitz wrote: Some test cases run in iotest 065 require zstd support. Skip them if qemu-img reports it not to be available. Reported-by: Thomas Huth Fixes: 12a936171d71f839dc907ff ("iotest 065: explicit compression type") Signed-off-by: Hanna Reitz ---

Re: [PATCH v2] target/rx: Remove unused ENV_OFFSET definition

2022-02-21 Thread Laurent Vivier
Le 03/02/2022 à 01:12, Philippe Mathieu-Daudé via a écrit : The last use of ENV_OFFSET was removed in 5e1401969b ("cpu: Move icount_decr to CPUNegativeOffsetState"); the commit of target/rx came in just afterward. Reviewed-by: Richard Henderson Reviewed-by: Yoshinori Sato Signed-off-by:

Re: [PATCH] configure: Disable capstone and slirp in the --without-default-features mode

2022-02-21 Thread Laurent Vivier
Le 21/02/2022 à 10:06, Thomas Huth a écrit : For the users, it looks a little bit weird that capstone and slirp are not disabled automatically if they run the configure script with the "--without-default-features" option, so let's do that now. Note: fdt is *not* changed accordingly since this

[PATCH 0/3] util/thread-pool: Expose minimun and maximum size

2022-02-21 Thread Nicolas Saenz Julienne
As discussed on the previous RFC[1] the thread-pool's dynamic thread management doesn't play well with real-time and latency sensitive systems. This series introduces a set of controls that'll permit achieving more deterministic behaviours, for example by fixing the pool's size. We first

[PATCH 1/3] util & iothread: Introduce event-loop abstract class

2022-02-21 Thread Nicolas Saenz Julienne
Introduce the 'event-loop-backend' abstract class, it'll hold the properties common to all event loops and provide the necessary hooks for their creation. Then have 'IOThread' inherit from it. The class is defined as user creatable and provides a hook for its children to attach themselves to the

[PATCH 3/3] util/event-loop: Introduce options to set the thread pool size

2022-02-21 Thread Nicolas Saenz Julienne
The thread pool regulates itself: when idle, it kills threads until empty, when in demand, it creates new threads until full. This behaviour doesn't play well with latency sensitive workloads where the price of creating a new thread is too high. For example, when paired with qemu's '-mlock', or

[PATCH 1/2] iotests/065: Check for zstd support

2022-02-21 Thread Hanna Reitz
Some test cases run in iotest 065 require zstd support. Skip them if qemu-img reports it not to be available. Reported-by: Thomas Huth Fixes: 12a936171d71f839dc907ff ("iotest 065: explicit compression type") Signed-off-by: Hanna Reitz --- tests/qemu-iotests/065 | 11 --- 1 file

[PATCH 2/2] iotests/303: Check for zstd support

2022-02-21 Thread Hanna Reitz
303 runs two test cases, one of which requires zstd support. Unfortunately, given that this is not a unittest-style test, we cannot easily skip that single case, and instead can only skip the whole test. (Alternatively, we could split this test into a zlib and a zstd part, but that seems

Re: [PATCH 15/20] migration: Allow migrate-recover to run multiple times

2022-02-21 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Previously migration didn't have an easy way to cleanup the listening > transport, migrate recovery only allows to execute once. That's done with a > trick flag in postcopy_recover_triggered. > > Now the facility is already there. > > Drop

  1   2   3   >