Re: [PATCH] target/sparc: resolve ASI_USERTXT correctly

2024-04-13 Thread M Bazz
Hi Richard, On Thu, Apr 11, 2024 at 10:16 PM Richard Henderson wrote: > > On 4/11/24 18:15, M Bazz wrote: > > diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c > > index e581bb42ac..4f87e44a93 100644 > > --- a/target/sparc/ldst_helper.c > > +++ b/target/sparc/ldst_helper.c > >

Re: Point where target instructions are read

2024-04-13 Thread Gautam Bhat
Ah I had my .tlb_fill callback set to an empty function with just returning true. I need to put the actual code there. Let me fill this function up and see what happens. -Gautam. On Thu, Apr 11, 2024 at 2:45 AM Gautam Bhat wrote: > > On Tue, Apr 9, 2024 at 2:23 PM Peter Maydell wrote: > > >

Questions about "QEMU gives wrong MPIDR value for Arm CPU types with MT=1" (gitlab issue #1608)

2024-04-13 Thread Dorjoy Chowdhury
Hi, Hope everyone is doing well. I was looking at "Bite Sized" tagged QEMU issues in gitlab to see if there is anything that makes sense for me as a first time contributor. I see this issue "QEMU gives wrong MPIDR value for Arm CPU types with MT=1" (gitlab URL:

Qemu for TC377

2024-04-13 Thread Sameer Kalliadan Poyil
Hello All, I see that Latest qemu supports for tricore TC277 and TC377 [image: image.png] But when I downloaded source code and checked for TC377 related file , I didn't find anything I want to run RTOS/bare metal code on TC377 . could you please let me know how to start qemu on TC377 ? Here is

Re: [PATCH v9 17/20] ebpf: Fix RSS error handling

2024-04-13 Thread Yuri Benditovich
On Wed, Apr 3, 2024 at 2:12 PM Akihiko Odaki wrote: > > calculate_rss_hash() was using hash value 0 to tell if it calculated > a hash, but the hash value may be 0 on a rare occasion. Have a > distinct bool value for correctness. This is interesting question whether in reality the hash value

Re: [PATCH v3 03/27] util/hexdump: Use a GString for qemu_hexdump_line

2024-04-13 Thread Stefan Hajnoczi
On Sat, 13 Apr 2024 at 05:46, Philippe Mathieu-Daudé wrote: > > On 12/4/24 20:59, Richard Henderson wrote: > > On 4/12/24 10:41, Philippe Mathieu-Daudé wrote: > >>> -void qemu_hexdump_line(char *line, const void *bufptr, size_t len) > >>> +GString *qemu_hexdump_line(GString *str, const void

Re: [PATCH v7 07/10] virtio-gpu: Handle resource blob commands

2024-04-13 Thread Akihiko Odaki
On 2024/04/11 19:19, Dmitry Osipenko wrote: From: Antonio Caggiano Support BLOB resources creation, mapping and unmapping by calling the new stable virglrenderer 0.10 interface. Only enabled when available and via the blob config. E.g. -device virtio-vga-gl,blob=true Signed-off-by: Antonio

[PATCH v4] target/riscv/kvm/kvm-cpu.c: kvm_riscv_handle_sbi() fail with vendor-specific SBI

2024-04-13 Thread Alexei Filippov
kvm_riscv_handle_sbi() may return not supported return code to not trigger qemu abort with vendor-specific sbi. Added SBI related return code's defines. Signed-off-by: Alexei Filippov Fixes: 4eb47125 ("target/riscv: Handle KVM_EXIT_RISCV_SBI exit") --- Changes since v3: -Clear

[PATCH 2/2] target/riscv: do not set mtval2 for non guest-page faults

2024-04-13 Thread Alexei Filippov
Previous patch fixed the PMP priority in raise_mmu_exception() but we're still setting mtval2 incorrectly. In riscv_cpu_tlb_fill(), after pmp check in 2 stage translation part, mtval2 will be set in case of successes 2 stage translation but failed pmp check. In this case we gonna set mtval2 via

[PATCH 1/2] target/riscv: prioritize pmp errors in raise_mmu_exception()

2024-04-13 Thread Alexei Filippov
From: Daniel Henrique Barboza raise_mmu_exception(), as is today, is prioritizing guest page faults by checking first if virt_enabled && !first_stage, and then considering the regular inst/load/store faults. There's no mention in the spec about guest page fault being a higher priority that PMP

Re: [PATCH v2] ppc440_pcix: Do not expose a bridge device on PCI bus

2024-04-13 Thread Philippe Mathieu-Daudé
On 11/4/24 21:24, BALATON Zoltan wrote: Real 460EX SoC apparently does not expose a bridge device and having it appear on PCI bus confuses an AmigaOS file system driver that uses this to detect which machine it is running on. Signed-off-by: BALATON Zoltan --- Here's another version that keeps

Re: [PATCH 0/3] vvfat: Fix bugs in writing and reading files -- PING

2024-04-13 Thread Amjad Alsharafi
Ping to the vvfat maintainers.

Re: [PATCH 2/2] hw: Add a Kconfig switch for the TYPE_CPU_CLUSTER device

2024-04-13 Thread Philippe Mathieu-Daudé
On 12/4/24 11:15, Thomas Huth wrote: On 12/04/2024 08.20, Thomas Huth wrote: The cpu-cluster device is only needed for some few arm and riscv machines. Let's avoid compiling and linking it if it is not really necessary. I expect clustering become the new default for heterogeneous machines,

Re: [PATCH 1/2] hw: Fix problem with the A*MPCORE switches in the Kconfig files

2024-04-13 Thread Philippe Mathieu-Daudé
On 12/4/24 13:32, Thomas Huth wrote: On 12/04/2024 13.10, Philippe Mathieu-Daudé wrote: On 12/4/24 08:20, Thomas Huth wrote: A9MPCORE, ARM11MPCORE and A15MPCORE are defined twice, once in hw/cpu/Kconfig and once in hw/arm/Kconfig. This is only possible by accident, since hw/cpu/Kconfig is

Re: [PATCH v3 03/27] util/hexdump: Use a GString for qemu_hexdump_line

2024-04-13 Thread Philippe Mathieu-Daudé
On 12/4/24 20:59, Richard Henderson wrote: On 4/12/24 10:41, Philippe Mathieu-Daudé wrote: -void qemu_hexdump_line(char *line, const void *bufptr, size_t len) +GString *qemu_hexdump_line(GString *str, const void *vbuf, size_t len)   { -    const char *buf = bufptr; -    int i, c; +    const

Re: [PATCH 0/6] disas/cris: Use GString instead of sprintf

2024-04-13 Thread Peter Maydell
On Sat, 13 Apr 2024 at 06:25, Richard Henderson wrote: > > More sprintf cleanup encouraged by the Apple deprecation. > Probably there's a more minimal patch. On the other hand, > there's certainly a larger cleanup possible. The CRIS architecture is deprecated, so all this code will be deleted