RE: [PATCH v2 05/10] vfio: Implement get_host_iommu_info() callback

2024-04-15 Thread Duan, Zhenzhong
>-Original Message- >From: Cédric Le Goater >Subject: Re: [PATCH v2 05/10] vfio: Implement get_host_iommu_info() >callback > >On 4/8/24 10:12, Zhenzhong Duan wrote: >> Utilize iova_ranges to calculate host IOMMU address width and >> package it in HIOD_LEGACY_INFO for vIOMMU usage. >> >>

Re: [PATCH v9 13/20] virtio-net: Return an error when vhost cannot enable RSS

2024-04-15 Thread Yuri Benditovich
On Tue, Apr 16, 2024 at 7:00 AM Jason Wang wrote: > > On Mon, Apr 15, 2024 at 10:05 PM Yuri Benditovich > wrote: > > > > On Wed, Apr 3, 2024 at 2:11 PM Akihiko Odaki > > wrote: > > > > > > vhost requires eBPF for RSS. When eBPF is not available, virtio-net > > > implicitly disables RSS even if

RE: [PATCH v2 03/10] backends/iommufd: Introduce abstract HIODIOMMUFD device

2024-04-15 Thread Duan, Zhenzhong
>-Original Message- >From: Cédric Le Goater >Subject: Re: [PATCH v2 03/10] backends/iommufd: Introduce abstract >HIODIOMMUFD device > >On 4/8/24 10:12, Zhenzhong Duan wrote: >> HIODIOMMUFD represents a host IOMMU device under iommufd backend. >> >> Currently it includes only public

[PATCH 3/7] accel/tcg: Return the TranslationBlock from cpu_unwind_state_data

2024-04-15 Thread Richard Henderson
Fix the i386 get_memio_eip function to use tb->cflags instead of cs->tcg_cflags. Signed-off-by: Richard Henderson --- include/exec/cpu-common.h | 9 + accel/tcg/translate-all.c | 9 + target/i386/helper.c | 6 -- 3 files changed, 14 insertions(+), 10 deletions(-) diff

[PATCH 6/7] target/i386: Introduce cpu_compute_eflags_ccop

2024-04-15 Thread Richard Henderson
This is a generalization of cpu_compute_eflags, with a dynamic value of cc_op, and is thus tcg specific. Signed-off-by: Richard Henderson --- target/i386/cpu.h | 2 ++ target/i386/tcg/cc_helper.c | 10 ++ 2 files changed, 12 insertions(+) diff --git a/target/i386/cpu.h

[PATCH 1/7] tcg: Introduce INDEX_op_plugin_pc

2024-04-15 Thread Richard Henderson
Add an opcode to find a code address within the current insn, for later use with unwinding. Generate the code generically using tcg_reg_alloc_do_movi. Signed-off-by: Richard Henderson --- include/tcg/tcg-op-common.h | 1 + include/tcg/tcg-opc.h | 1 + tcg/tcg-op.c| 5

[PATCH 2/7] accel/tcg: Set CPUState.plugin_ra before all plugin callbacks

2024-04-15 Thread Richard Henderson
Signed-off-by: Richard Henderson --- include/hw/core/cpu.h | 1 + accel/tcg/plugin-gen.c | 50 +- 2 files changed, 46 insertions(+), 5 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 10cd492aff..f4af37c13d 100644 ---

[PATCH 7/7] target/i386: Implement TCGCPUOps for plugin register reads

2024-04-15 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/i386/tcg/tcg-cpu.c | 72 ++- 1 file changed, 56 insertions(+), 16 deletions(-) diff --git a/target/i386/tcg/tcg-cpu.c b/target/i386/tcg/tcg-cpu.c index cca19cd40e..2370053df2 100644 --- a/target/i386/tcg/tcg-cpu.c

[PATCH 5/7] target/i386: Split out gdb-internal.h

2024-04-15 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/i386/gdb-internal.h | 65 ++ target/i386/gdbstub.c | 1 + 2 files changed, 66 insertions(+) create mode 100644 target/i386/gdb-internal.h diff --git a/target/i386/gdb-internal.h b/target/i386/gdb-internal.h

[PATCH 0/7] plugins: Use unwind info for special gdb registers

2024-04-15 Thread Richard Henderson
Based-on: 20240404230611.21231-1-richard.hender...@linaro.org ("[PATCH v2 00/21] Rewrite plugin code generation") This is an attempt to fix https://gitlab.com/qemu-project/qemu/-/issues/2208 ("PC is not updated for each instruction in TCG plugins") I have only updated target/i386 so far, but

[PATCH 4/7] plugins: Introduce TCGCPUOps callbacks for mid-tb register reads

2024-04-15 Thread Richard Henderson
Certain target registers are not updated continuously within the translation block. For normal exception handling we use unwind info to re-generate the correct value when required. Leverage that same info for reading those registers for plugins. All targets will need updating for these new

[PATCH 0/7] plugins: Use unwind info for special gdb registers

2024-04-15 Thread Richard Henderson
Based-on: 20240404230611.21231-1-richard.hender...@linaro.org ("[PATCH v2 00/21] Rewrite plugin code generation") This is an attempt to fix https://gitlab.com/qemu-project/qemu/-/issues/2208 ("PC is not updated for each instruction in TCG plugins") I have only updated target/i386 so far, but

Re: [PATCH v9 13/20] virtio-net: Return an error when vhost cannot enable RSS

2024-04-15 Thread Jason Wang
On Mon, Apr 15, 2024 at 10:05 PM Yuri Benditovich wrote: > > On Wed, Apr 3, 2024 at 2:11 PM Akihiko Odaki wrote: > > > > vhost requires eBPF for RSS. When eBPF is not available, virtio-net > > implicitly disables RSS even if the user explicitly requests it. Return > > an error instead of

RE: [PATCH v2 02/10] vfio: Introduce HIODLegacyVFIO device

2024-04-15 Thread Duan, Zhenzhong
Hi Cédric, >-Original Message- >From: Cédric Le Goater >Subject: Re: [PATCH v2 02/10] vfio: Introduce HIODLegacyVFIO device > >On 4/8/24 10:12, Zhenzhong Duan wrote: >> HIODLegacyVFIO represents a host IOMMU device under VFIO legacy >> container backend. >> >> It includes a link to

Re: [PATCH v8] virtio-pci: fix use of a released vector

2024-04-15 Thread Jason Wang
On Mon, Apr 15, 2024 at 6:41 PM Cindy Lu wrote: > > On Mon, Apr 15, 2024 at 5:34 PM Michael S. Tsirkin wrote: > > > > From: Cindy Lu > > > > During the booting process of the non-standard image, the behavior of the > > called function in qemu is as follows: > > > > 1. vhost_net_stop() was

Re: [PATCH 1/2] target/riscv: prioritize pmp errors in raise_mmu_exception()

2024-04-15 Thread Joseph Chan
Digging more in Priv-v1.12/riscv-privileged-20211203.pdf : Page 82, Section 4.3.2 Virtual Address Translation Process. The spec actually mentions an address translation algorithm. Step 2

Re: [PATCH for-9.0] ppc440_pcix: Do not expose a bridge device on PCI bus

2024-04-15 Thread Nicholas Piggin
On Wed Apr 10, 2024 at 9:03 PM AEST, BALATON Zoltan wrote: > On Wed, 10 Apr 2024, Nicholas Piggin wrote: > > On Wed Apr 10, 2024 at 9:55 AM AEST, BALATON Zoltan wrote: > >> Real 460EX SoC apparently does not expose a bridge device and having > >> it appear on PCI bus confuses an AmigaOS file

Re: [RFC v3 0/6] virtio,vhost: Add VIRTIO_F_IN_ORDER support

2024-04-15 Thread Lei Yang
QE tested this series with packed=on/off, in_order=true and vhost=off under regression tests, everything are works fine. Tested-by: Lei Yang On Mon, Apr 8, 2024 at 11:34 PM Jonah Palmer wrote: > > The goal of these patches is to add support to a variety of virtio and > vhost devices for the

[RFC 1/1] hw/nvme: add atomic write support

2024-04-15 Thread Alan Adamson
Forces writes to be atomic based on new atomic write parameters. New NVMe QEMU Parameters (See NVMe Specification for details): atomic.dn (default off) - Set the value of Disable Normal. atomic.awun=UINT16 (default: 0) atomic.awupf=UINT16 (default: 0)

[RFC 0/1] hw/nvme: add atomic write support

2024-04-15 Thread Alan Adamson
Since there is discussion in the Linux NVMe Driver community to add NVMe Atomic Write support, it would be desirable to test it with qemu nvme emulation. Initially, this RFC will focus on supporting NVMe controller atomic write parameters(AWUN, AWUPF, and ACWU) but will be extended to support

[PATCH v5 1/3] ui/console: Introduce dpy_gl_qemu_dmabuf_get_..() helpers

2024-04-15 Thread dongwon . kim
From: Dongwon Kim This commit introduces dpy_gl_qemu_dmabuf_get_... helpers to extract specific fields from the QemuDmaBuf struct. It also updates all instances where fields within the QemuDmaBuf struct are directly accessed, replacing them with calls to these new helper functions.

[PATCH v5 3/3] ui/console: Introduce dpy_gl_qemu_dmabuf_new() and free() helpers

2024-04-15 Thread dongwon . kim
From: Dongwon Kim This commit introduces utility functions for the creation and deallocation of QemuDmaBuf instances. Additionally, it updates all relevant sections of the codebase to utilize these new utility functions. Suggested-by: Marc-André Lureau Cc: Philippe Mathieu-Daudé Cc: Vivek

[PATCH v5 0/3] ui/console: Private QemuDmaBuf struct

2024-04-15 Thread dongwon . kim
From: Dongwon Kim This series introduces privacy enhancements to the QemuDmaBuf struct and its contained data to bolster security. it accomplishes this by introducing of helper functions for allocating, deallocating, and accessing individual fields within the struct and replacing all direct

[PATCH v5 2/3] ui/console: Introduce dpy_gl_qemu_dmabuf_set_..() helpers

2024-04-15 Thread dongwon . kim
From: Dongwon Kim To enhance security in accessing the QemuDmaBuf struct, new helper functions for setting specific fields within the struct were introduced. And all occurrences where these fields were previously set directly have been updated to utilize these helper functions. Suggested-by:

RE: [PATCH] vhost-user-gpu: fix import of DMABUF

2024-04-15 Thread Kim, Dongwon
Hi Marc-André, > -Original Message- > From: marcandre.lur...@redhat.com > Sent: Monday, April 15, 2024 4:16 AM > To: qemu-devel@nongnu.org > Cc: Kim, Dongwon ; dbas...@redhat.com; Marc- > André Lureau ; Michael S. Tsirkin > ; Gerd Hoffmann > Subject: [PATCH] vhost-user-gpu: fix import

Re: [PATCH v6 11/12] hw/cxl/cxl-mailbox-utils: Add superset extent release mailbox support

2024-04-15 Thread fan
On Fri, Apr 05, 2024 at 09:57:18AM +, Jørgen Hansen wrote: > On 3/25/24 20:02, nifan@gmail.com wrote: > > From: Fan Ni > > > > With the change, we extend the extent release mailbox command processing > > to allow more flexible release. As long as the DPA range of the extent to > >

Re: [PATCH v6 09/12] hw/cxl/events: Add qmp interfaces to add/release dynamic capacity extents

2024-04-15 Thread fan
>From ce75be83e915fbc4dd6e489f976665b81174002b Mon Sep 17 00:00:00 2001 From: Fan Ni Date: Tue, 20 Feb 2024 09:48:31 -0800 Subject: [PATCH 09/13] hw/cxl/events: Add qmp interfaces to add/release dynamic capacity extents To simulate FM functionalities for initiating Dynamic Capacity Add

Re: Questions about "QEMU gives wrong MPIDR value for Arm CPU types with MT=1" (gitlab issue #1608)

2024-04-15 Thread Dorjoy Chowdhury
On Mon, Apr 15, 2024 at 5:35 PM Peter Maydell wrote: > > On Sat, 13 Apr 2024 at 20:59, Dorjoy Chowdhury wrote: > > > > Hi, > > Hope everyone is doing well. I was looking at "Bite Sized" tagged QEMU > > issues in gitlab to see if there is anything that makes sense for me > > as a first time

Re: [PATCH 1/2] target/riscv: prioritize pmp errors in raise_mmu_exception()

2024-04-15 Thread Joseph Chan
FYI Priv-v1.12/riscv-privileged-20211203.pdf defines exception priorities on Page 40, Table 3.7 Page 130, Table 8.7 There is a sentence under Table 3.7: "When a virtual address is translated

Re: Intention to work on GSoC project

2024-04-15 Thread Sahil
Hi, Thank you for your reply. On Monday, April 15, 2024 2:27:36 PM IST Eugenio Perez Martin wrote: > [...] > > I have one question though. One of the options (use case 1 in [1]) > > > > given to the "qemu-kvm" command is: > > > -device virtio-net-pci,netdev=vhost-vdpa0,bus=pcie.0,addr=0x7\ > >

[PATCH] qemu-options: Deprecate "-runas" and introduce "-run-with user=..." instead

2024-04-15 Thread Thomas Huth
The old "-runas" option has the disadvantage that it is not visible in the QAPI schema, so it is not available via the normal introspection mechanisms. We've recently introduced the "-run-with" option for exactly this purpose, which is meant to handle the options that affect the runtime behavior.

Re: [PATCH v2] target/i386: Give IRQs a chance when resetting HF_INHIBIT_IRQ_MASK

2024-04-15 Thread Philippe Mathieu-Daudé
On 15/4/24 11:32, Paolo Bonzini wrote: On Mon, Apr 15, 2024 at 8:50 AM Ruihan Li wrote: When emulated with QEMU, interrupts will never come in the following loop. However, if the NOP instruction is uncommented, interrupts will fire as normal. loop: cli

Re: [PATCH v6 08/12] hw/cxl/cxl-mailbox-utils: Add mailbox commands to support add/release dynamic capacity response

2024-04-15 Thread fan
On Thu, Apr 04, 2024 at 01:32:23PM +, Jørgen Hansen wrote: > On 3/25/24 20:02, nifan@gmail.com wrote: > > From: Fan Ni > > > > Per CXL spec 3.1, two mailbox commands are implemented: > > Add Dynamic Capacity Response (Opcode 4802h) 8.2.9.9.9.3, and > > Release Dynamic Capacity (Opcode

Re: [PATCH v6 08/12] hw/cxl/cxl-mailbox-utils: Add mailbox commands to support add/release dynamic capacity response

2024-04-15 Thread fan
>From 4b9695299d3d4b22f83666f8ab79099ec9f9817f Mon Sep 17 00:00:00 2001 From: Fan Ni Date: Tue, 20 Feb 2024 09:48:30 -0800 Subject: [PATCH 08/13] hw/cxl/cxl-mailbox-utils: Add mailbox commands to support add/release dynamic capacity response Per CXL spec 3.1, two mailbox commands are

Re: [PATCH v6 10/12] hw/mem/cxl_type3: Add dpa range validation for accesses to DC regions

2024-04-15 Thread fan
On Fri, Apr 12, 2024 at 06:54:42PM -0400, Gregory Price wrote: > On Mon, Mar 25, 2024 at 12:02:28PM -0700, nifan@gmail.com wrote: > > From: Fan Ni > > > > All dpa ranges in the DC regions are invalid to access until an extent > > covering the range has been added. Add a bitmap for each

Re: [PATCH v8] arm/kvm: Enable support for KVM_ARM_VCPU_PMU_V3_FILTER

2024-04-15 Thread Daniel P . Berrangé
On Tue, Apr 02, 2024 at 03:01:50PM +0200, Kevin Wolf wrote: > Am 29.03.2024 um 04:45 hat Shaoqin Huang geschrieben: > > Hi Daniel, > > > > On 3/25/24 16:55, Daniel P. Berrangé wrote: > > > On Mon, Mar 25, 2024 at 01:35:58PM +0800, Shaoqin Huang wrote: > > > > Hi Daniel, > > > > > > > > Thanks

Re: [PATCH v9] arm/kvm: Enable support for KVM_ARM_VCPU_PMU_V3_FILTER

2024-04-15 Thread Daniel P . Berrangé
On Mon, Apr 08, 2024 at 10:49:40PM -0400, Shaoqin Huang wrote: > The KVM_ARM_VCPU_PMU_V3_FILTER provides the ability to let the VMM decide > which PMU events are provided to the guest. Add a new option > `kvm-pmu-filter` as -cpu sub-option to set the PMU Event Filtering. > Without the filter, all

Re: [PATCH v2 09/13] block/gluster: Use URI parsing code from glib

2024-04-15 Thread Daniel P . Berrangé
On Fri, Apr 12, 2024 at 09:40:11AM -0500, Eric Blake wrote: > On Fri, Apr 12, 2024 at 03:24:11PM +0200, Thomas Huth wrote: > > Since version 2.66, glib has useful URI parsing functions, too. > > Use those instead of the QEMU-internal ones to be finally able > > to get rid of the latter. > > > >

Re: [PATCH v2 09/13] block/gluster: Use URI parsing code from glib

2024-04-15 Thread Daniel P . Berrangé
On Fri, Apr 12, 2024 at 03:24:11PM +0200, Thomas Huth wrote: > Since version 2.66, glib has useful URI parsing functions, too. > Use those instead of the QEMU-internal ones to be finally able > to get rid of the latter. > > Signed-off-by: Thomas Huth > --- > block/gluster.c | 71

Re: [PATCH v2 08/13] Remove glib compatibility code that is not required anymore

2024-04-15 Thread Daniel P . Berrangé
On Fri, Apr 12, 2024 at 03:24:10PM +0200, Thomas Huth wrote: > Now that we bumped the minumum glib version to 2.66, we can drop > the old code. > > Suggested-by: Paolo Bonzini > Signed-off-by: Thomas Huth > --- > qga/commands-posix-ssh.c | 8 > util/error-report.c | 10

Re: [PATCH v2 07/13] Bump minimum glib version to v2.66

2024-04-15 Thread Daniel P . Berrangé
On Fri, Apr 12, 2024 at 03:24:09PM +0200, Thomas Huth wrote: > Now that we dropped support for CentOS 8 and Ubuntu 20.04, we can > look into bumping the glib version to a new minimum for further > clean-ups. According to repology.org, available versions are: > > CentOS Stream 9: 2.66.7 >

Re: [PATCH v2 06/13] ci: move external build environment setups to CentOS Stream 9

2024-04-15 Thread Daniel P . Berrangé
On Fri, Apr 12, 2024 at 03:24:08PM +0200, Thomas Huth wrote: > From: Paolo Bonzini > > RHEL 9 (and thus also the derivatives) are available since two years > now, so according to QEMU's support policy, we can drop the active > support for the previous major version 8 now. > > Thus upgrade our

Re: [PATCH v2 05/13] .travis.yml: Update the jobs to Ubuntu 22.04

2024-04-15 Thread Daniel P . Berrangé
On Fri, Apr 12, 2024 at 03:24:07PM +0200, Thomas Huth wrote: > According to our support policy, we'll soon drop our official support > for Ubuntu 20.04 ("Focal Fossa") in QEMU. Thus we should update the > Travis jobs now to a newer release (Ubuntu 22.04 - "Jammy Jellyfish") > for future testing.

Re: [PATCH v2 04/13] tests: Update our CI to use CentOS Stream 9 instead of 8

2024-04-15 Thread Daniel P . Berrangé
On Fri, Apr 12, 2024 at 03:24:06PM +0200, Thomas Huth wrote: > RHEL 9 (and thus also the derivatives) are available since two years > now, so according to QEMU's support policy, we can drop the active > support for the previous major version 8 now. > Thus upgrade our CentOS Stream container to

Re: [PATCH v2 03/13] tests/docker/dockerfiles: Run lcitool-refresh after the lcitool update

2024-04-15 Thread Daniel P . Berrangé
On Fri, Apr 12, 2024 at 03:24:05PM +0200, Thomas Huth wrote: > This update adds the removing of the EXTERNALLY-MANAGED marker files > that has been added to the lcitool recently. For those who don't know, python now commonly blocks the ability to run 'pip install' outside of a venv. This

Re: [PATCH v2 02/13] tests/lcitool/libvirt-ci: Update to the latest master branch

2024-04-15 Thread Daniel P . Berrangé
On Fri, Apr 12, 2024 at 03:24:04PM +0200, Thomas Huth wrote: > We need the latest fixes for the lcitool to be able to properly > update our CentOS docker file to CentOS Stream 9. > > Signed-off-by: Thomas Huth > --- > tests/lcitool/libvirt-ci | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH v2 0/2] Improvements for switches in hw/cpu/Kconfig

2024-04-15 Thread Richard Henderson
On 4/14/24 23:56, Thomas Huth wrote: Thomas Huth (2): hw: Fix problem with the A*MPCORE switches in the Kconfig files hw: Add a Kconfig switch for the TYPE_CPU_CLUSTER device Reviewed-by: Richard Henderson r~

Re: [PATCH] target/sparc: resolve ASI_USERTXT correctly

2024-04-15 Thread Richard Henderson
On 4/14/24 15:48, M Bazz wrote: I noticed that cpu_mmu_index() would have returned MMU_USER_IDX if the supervisor bit hadn't happened to be set (not sure if this execution path can occur for lda). No, it cannot. Note that this check is gone in your patch. Correct. Since 'lda' has already

Re: Add 'info pg' command to monitor

2024-04-15 Thread Peter Maydell
On Mon, 15 Apr 2024 at 17:09, Don Porter wrote: > I am a CS professor (and, newly, a second-time contributor). I have > been using qemu in my courses for over a decade, especially a course > that asks students to write major pieces of an OS kernel from starter > code. > > I have some patches,

Re: XIVE VFIO kernel resample failure in INTx mode under heavy load

2024-04-15 Thread Timothy Pearson
- Original Message - > From: "Cédric Le Goater" > To: "Alexey Kardashevskiy" , "Alex Williamson" > , "Timothy Pearson" > > Cc: "l...@suse.de:PowerPC" , "qemu-devel" > , "Frederic Barrat" > , "npiggin" , "David Gibson" > > Sent: Thursday, April 21, 2022 1:35:50 AM > Subject: Re:

[PATCH 1/2] monitor: Implement a generic x86 page table iterator

2024-04-15 Thread Don Porter
From: Austin Clements This iterator provides a way to traverse 32-bit, PAE, and 64-bit page tables by abstracting them as n-ary trees. A struct describes the full range of x86 page table layouts and the iterator builds on this to provide a "successor" function for efficiently traversing the

Add 'info pg' command to monitor

2024-04-15 Thread Don Porter
Hi all, I am a CS professor (and, newly, a second-time contributor). I have been using qemu in my courses for over a decade, especially a course that asks students to write major pieces of an OS kernel from starter code. I have some patches, originally from Austin Clements at MIT, that I have

[PATCH 2/2] monitor: Add an "info pg" command that prints the current page tables

2024-04-15 Thread Don Porter
From: Austin Clements The new "info pg" monitor command prints the current page table, including virtual address ranges, flag bits, and snippets of physical page numbers. Completely filled regions of the page table with compatible flags are "folded", with the result that the complete output for

Re: [PATCH v2 3/5] intel_iommu: Add a framework to do compatibility check with host IOMMU cap/ecap

2024-04-15 Thread Cédric Le Goater
On 4/8/24 10:44, Zhenzhong Duan wrote: From: Yi Liu If check fails, the host side device(either vfio or vdpa device) should not be passed to guest. Implementation details for different backends will be in following patches. Signed-off-by: Yi Liu Signed-off-by: Yi Sun Signed-off-by:

[PATCH] tests/avocado: update sunxi kernel from armbian to 6.6.16

2024-04-15 Thread Peter Maydell
The Linux kernel 5.10.16 binary for sunxi has been removed from apt.armbian.com. This means that the avocado tests for these machines will be skipped (status CANCEL) if the old binary isn't present in the avocado cache. Update to 6.6.16, in the same way we did in commit e384db41d8661 when we

Re: [PATCH v2 2/6] hw/ppc: SPI controller model - registers implementation

2024-04-15 Thread Cédric Le Goater
Hello Chalapathi The subject could be rephrased to : "ppc/pnv: Add SPI controller model". On 4/9/24 19:56, Chalapathi V wrote: SPI controller device model supports a connection to a single SPI responder. This provide access to SPI seeproms, TPM, flash device and an ADC controller. All SPI

[PULL 0/2] Misc HW patches for 2024-04-15

2024-04-15 Thread Philippe Mathieu-Daudé
The following changes since commit 824ebb92c39920a65b34a93d1bd462baf0d2d174: Merge tag 'pull-sp-20240412' of https://gitlab.com/rth7680/qemu into staging (2024-04-13 09:43:46 +0100) are available in the Git repository at: https://github.com/philmd/qemu.git tags/hw-misc-20240415 for you

[PULL 1/2] hw/isa/vt82c686: Keep track of PIRQ/PINT pins separately

2024-04-15 Thread Philippe Mathieu-Daudé
From: BALATON Zoltan Move calculation of mask after the switch which sets the function number for PIRQ/PINT pins to make sure the state of these pins are kept track of separately and IRQ is raised if any of them is active. Cc: qemu-sta...@nongnu.org Fixes: 7e01bd80c1 hw/isa/vt82c686: Bring back

[PULL 2/2] hw/pci-host/ppc440_pcix: Do not expose a bridge device on PCI bus

2024-04-15 Thread Philippe Mathieu-Daudé
From: BALATON Zoltan Real 460EX SoC apparently does not expose a bridge device and having it appear on PCI bus confuses an AmigaOS file system driver that uses this to detect which machine it is running on. Cc: qemu-sta...@nongnu.org Signed-off-by: BALATON Zoltan Reviewed-by: Philippe

Re: [PATCH] hw/isa/vt82c686: Keep track of PIRQ/PINT pins separately

2024-04-15 Thread Philippe Mathieu-Daudé
On 11/4/24 00:25, BALATON Zoltan wrote: Move calculation of mask after the switch which sets the function number for PIRQ/PINT pins to make sure the state of these pins are kept track of separately and IRQ is raised if any of them is active. Fixes: 7e01bd80c1 hw/isa/vt82c686: Bring back

Re: [PATCH] hw/misc/applesmc: Simplify DeviceReset handler

2024-04-15 Thread Philippe Mathieu-Daudé
On 10/4/24 20:08, Philippe Mathieu-Daudé wrote: Have applesmc_find_key() return a const pointer. Since the returned buffers are not modified in applesmc_io_data_write(), it is pointless to delete and re-add the keys in the DeviceReset handler. Add them once in DeviceRealize, and discard them in

Re: [PATCH v2 1/6] hw/ppc: remove SPI responder model

2024-04-15 Thread Cédric Le Goater
On 4/9/24 19:56, Chalapathi V wrote: -- Empty commit to align the patch numbers between PATCH v1 and PATCH v2. SPI responder model is removed as pnv spi controller and seeprom is implemented using QEMU SSI framework. Please drop this empty patch. Patch numbers do not need to be aligned between

Re: [PATCH v2] ppc440_pcix: Do not expose a bridge device on PCI bus

2024-04-15 Thread Philippe Mathieu-Daudé
On 14/4/24 15:00, BALATON Zoltan wrote: On Sat, 13 Apr 2024, Philippe Mathieu-Daudé wrote: On 11/4/24 21:24, BALATON Zoltan wrote: Real 460EX SoC apparently does not expose a bridge device and having it appear on PCI bus confuses an AmigaOS file system driver that uses this to detect which

[PATCH 6.8 008/172] virtio_net: Do not send RSS key if it is not supported

2024-04-15 Thread Greg Kroah-Hartman
6.8-stable review patch. If anyone has any objections, please let me know. -- From: Breno Leitao commit 059a49aa2e25c58f90b50151f109dd3c4cdb3a47 upstream. There is a bug when setting the RSS options in virtio_net that can break the whole machine, getting the kernel into an

Re: [PULL 0/1] virtio: bugfix

2024-04-15 Thread Peter Maydell
On Mon, 15 Apr 2024 at 11:52, Michael S. Tsirkin wrote: > > The following changes since commit e104a960c33b68fedf26dfb7b8e00abab8f2: > > qdev-monitor: fix error message in find_device_state() (2024-04-09 02:31:33 > -0400) > > are available in the Git repository at: > >

MAINTAINERS tweak [was: [PATCH for-9.1 0/9] Switch to glib URI parsing code]

2024-04-15 Thread Eric Blake
[Trying Peter Lieven's alternate address...] On Thu, Mar 28, 2024 at 03:05:57PM +0100, Thomas Huth wrote: > In the QEMU 9.1 development cycle, we can drop the support for > Ubuntu 20.04 and CentOS 8 since the following major versions of > these distributions are available since 2 years already.

Re: [PATCH v9 13/20] virtio-net: Return an error when vhost cannot enable RSS

2024-04-15 Thread Yuri Benditovich
On Wed, Apr 3, 2024 at 2:11 PM Akihiko Odaki wrote: > > vhost requires eBPF for RSS. When eBPF is not available, virtio-net > implicitly disables RSS even if the user explicitly requests it. Return > an error instead of implicitly disabling RSS if RSS is requested but not > available. > >

Re: [PATCH v4] target/riscv/kvm/kvm-cpu.c: kvm_riscv_handle_sbi() fail with vendor-specific SBI

2024-04-15 Thread Andrew Jones
On Sat, Apr 13, 2024 at 02:25:26PM +0300, Alexei Filippov wrote: > kvm_riscv_handle_sbi() may return not supported return code to not trigger > qemu abort with vendor-specific sbi. > > Added SBI related return code's defines. > > Signed-off-by: Alexei Filippov > Fixes: 4eb47125 ("target/riscv:

Re: [PATCH 02/12] hw/vfio/pci: Replace sprintf() by g_strdup_printf()

2024-04-15 Thread Cédric Le Goater
On 4/12/24 17:25, Alex Williamson wrote: On Wed, 10 Apr 2024 18:06:03 +0200 Philippe Mathieu-Daudé wrote: sprintf() is deprecated on Darwin since macOS 13.0 / XCode 14.1, resulting in painful developper experience. Use g_strdup_printf() instead. Isn't this code only compiled for Linux

Re: secure boot & direct kernel load (was: Re: [PATCH] x86/loader: only patch linux kernels)

2024-04-15 Thread Daniel P . Berrangé
On Mon, Apr 15, 2024 at 03:30:32PM +0200, Gerd Hoffmann wrote: > Hi, > > > > Options I see: > > > > > > (a) Stop using direct kernel boot, let virt-install & other tools > > > create vfat boot media with shim+kernel+initrd instead. > > > > > > (b) Enroll the distro signing keys in

Re: [PATCH v2 10/10] vfio: Pass HostIOMMUDevice to vIOMMU

2024-04-15 Thread Cédric Le Goater
On 4/8/24 10:12, Zhenzhong Duan wrote: With HostIOMMUDevice passed, vIOMMU can check compatibility with host IOMMU, call into IOMMUFD specific methods, etc. Originally-by: Yi Liu Signed-off-by: Nicolin Chen Signed-off-by: Yi Sun Signed-off-by: Zhenzhong Duan LGTM, waiting v3. Thanks,

Re: [PATCH v2 09/10] hw/pci: Introduce pci_device_set/unset_iommu_device()

2024-04-15 Thread Cédric Le Goater
On 4/8/24 10:12, Zhenzhong Duan wrote: From: Yi Liu This adds pci_device_set/unset_iommu_device() to set/unset HostIOMMUDevice for a given PCI device. Caller of set should fail if set operation fails. Extract out pci_device_get_iommu_bus_devfn() to facilitate I would separate this change in

Re: secure boot & direct kernel load (was: Re: [PATCH] x86/loader: only patch linux kernels)

2024-04-15 Thread Gerd Hoffmann
Hi, > > Options I see: > > > > (a) Stop using direct kernel boot, let virt-install & other tools > > create vfat boot media with shim+kernel+initrd instead. > > > > (b) Enroll the distro signing keys in the efi variable store, so > > booting the kernel without shim.efi works.

Re: [PATCH v2 08/10] vfio: Create host IOMMU device instance

2024-04-15 Thread Cédric Le Goater
On 4/8/24 10:12, Zhenzhong Duan wrote: Create host IOMMU device instance and initialize it based on backend. Signed-off-by: Zhenzhong Duan --- include/hw/vfio/vfio-common.h | 1 + hw/vfio/container.c | 5 + hw/vfio/iommufd.c | 8 3 files changed, 14

Re: [PATCH v2 07/10] backends/iommufd: Implement get_host_iommu_info() callback

2024-04-15 Thread Cédric Le Goater
On 4/8/24 10:12, Zhenzhong Duan wrote: It calls iommufd_backend_get_device_info() to get host IOMMU related information. Define a common structure HIOD_IOMMUFD_INFO to describe the info returned from kernel. Currently only vtd, but easy to add arm smmu when kernel supports. I think you can

Re: [PATCH v2 06/10] backends/iommufd: Introduce helper function iommufd_backend_get_device_info()

2024-04-15 Thread Cédric Le Goater
On 4/8/24 10:12, Zhenzhong Duan wrote: Introduce a helper function iommufd_backend_get_device_info() to get host IOMMU related information through iommufd uAPI. Signed-off-by: Yi Liu Signed-off-by: Yi Sun Signed-off-by: Zhenzhong Duan --- include/sysemu/iommufd.h | 4

Re: [PATCH v2 05/10] vfio: Implement get_host_iommu_info() callback

2024-04-15 Thread Cédric Le Goater
On 4/8/24 10:12, Zhenzhong Duan wrote: Utilize iova_ranges to calculate host IOMMU address width and package it in HIOD_LEGACY_INFO for vIOMMU usage. HIOD_LEGACY_INFO will be used by both VFIO and VDPA so declare it in host_iommu_device.h. Signed-off-by: Zhenzhong Duan ---

Re: [PATCH v2 03/10] backends/iommufd: Introduce abstract HIODIOMMUFD device

2024-04-15 Thread Cédric Le Goater
On 4/8/24 10:12, Zhenzhong Duan wrote: HIODIOMMUFD represents a host IOMMU device under iommufd backend. Currently it includes only public iommufd handle and device id. which could be used to get hw IOMMU information. When nested translation is supported in future, vIOMMU is going to have

Re: [PATCH 08/20] target/arm: Rename arm_cpu_mp_affinity

2024-04-15 Thread Peter Maydell
On Thu, 18 Jan 2024 at 20:07, Philippe Mathieu-Daudé wrote: > > From: Richard Henderson > > Rename to arm_build_mp_affinity. This frees up the name for > other usage, and emphasizes that the cpu object is not involved. > > Signed-off-by: Richard Henderson > Signed-off-by: Philippe

Re: [PATCH v2 02/10] vfio: Introduce HIODLegacyVFIO device

2024-04-15 Thread Cédric Le Goater
On 4/8/24 10:12, Zhenzhong Duan wrote: HIODLegacyVFIO represents a host IOMMU device under VFIO legacy container backend. It includes a link to VFIODevice. Suggested-by: Eric Auger Suggested-by: Cédric Le Goater Signed-off-by: Zhenzhong Duan --- include/hw/vfio/vfio-common.h | 11

RE: [PATCH v2 02/10] vfio: Introduce HIODLegacyVFIO device

2024-04-15 Thread Duan, Zhenzhong
>-Original Message- >From: Philippe Mathieu-Daudé >Subject: Re: [PATCH v2 02/10] vfio: Introduce HIODLegacyVFIO device > >On 15/4/24 12:10, Duan, Zhenzhong wrote: >> Hi Philippe, >> >>> -Original Message- >>> From: Philippe Mathieu-Daudé >>> Sent: Monday, April 15, 2024 5:20 PM

Re: secure boot & direct kernel load (was: Re: [PATCH] x86/loader: only patch linux kernels)

2024-04-15 Thread Daniel P . Berrangé
On Wed, Apr 10, 2024 at 12:35:13PM +0200, Gerd Hoffmann wrote: > On Wed, Apr 10, 2024 at 03:26:29AM -0400, Michael S. Tsirkin wrote: > > On Wed, Apr 10, 2024 at 09:21:26AM +0200, Gerd Hoffmann wrote: > > > If the binary loaded via -kernel is *not* a linux kernel (in which > > > case protocol ==

Re: Qemu for TC377

2024-04-15 Thread Bastian Koppelmann
Hi Sameer, On Sun, Apr 14, 2024 at 06:15:56PM +0200, Philippe Mathieu-Daudé wrote: > Hi Sameer, > > On 13/4/24 14:52, Sameer Kalliadan Poyil wrote: > > Hello All, > > I see that Latest qemu supports for tricore TC277 and TC377 > > image.png > > But when I downloaded source code and checked for

Re: Questions about "QEMU gives wrong MPIDR value for Arm CPU types with MT=1" (gitlab issue #1608)

2024-04-15 Thread Peter Maydell
On Sat, 13 Apr 2024 at 20:59, Dorjoy Chowdhury wrote: > > Hi, > Hope everyone is doing well. I was looking at "Bite Sized" tagged QEMU > issues in gitlab to see if there is anything that makes sense for me > as a first time contributor. I see this issue "QEMU gives wrong MPIDR > value for Arm CPU

Re: Hermetic virtio-vsock in QEMU

2024-04-15 Thread Daniel P . Berrangé
On Wed, Apr 03, 2024 at 02:30:33PM -0700, Roman Kiryanov wrote: > Hi Peter, Alex and QEMU, > > I work in Android Studio Emulator and we use virtio-vsock to emulate > devices (e.g. sensors) which live in the Emulator binary. We need to run on > Windows and in environments without

[PATCH] vhost-user-gpu: fix import of DMABUF

2024-04-15 Thread marcandre . lureau
From: Marc-André Lureau When using vhost-user-gpu with GL, qemu -display gtk doesn't show output and prints: qemu: eglCreateImageKHR failed Since commit 9ac06df8b ("virtio-gpu-udmabuf: correct naming of QemuDmaBuf size properties"), egl_dmabuf_import_texture() uses backing_{width,height} for

[PATCH] vl: fix "type is NULL" in -vga help

2024-04-15 Thread marcandre . lureau
From: Marc-André Lureau Don't pass NULL to module_object_class_by_name(). Signed-off-by: Marc-André Lureau --- system/vl.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/system/vl.c b/system/vl.c index c644222982..23e1cb016f 100644 --- a/system/vl.c +++

Re: [PATCH v2 02/10] vfio: Introduce HIODLegacyVFIO device

2024-04-15 Thread Philippe Mathieu-Daudé
On 15/4/24 12:10, Duan, Zhenzhong wrote: Hi Philippe, -Original Message- From: Philippe Mathieu-Daudé Sent: Monday, April 15, 2024 5:20 PM To: Duan, Zhenzhong ; qemu- de...@nongnu.org Cc: alex.william...@redhat.com; c...@redhat.com; eric.au...@redhat.com; pet...@redhat.com;

Re: [PATCH v2] target/i386: Give IRQs a chance when resetting HF_INHIBIT_IRQ_MASK

2024-04-15 Thread Ruihan Li
Hi Paolo, On Mon, Apr 15, 2024 at 11:32:51AM +0200, Paolo Bonzini wrote: > What do you think about writing this: > > > /* If several instructions disable interrupts, only the first does it. > > */ > > if (inhibit && !(s->flags & HF_INHIBIT_IRQ_MASK)) { > > gen_set_hflag(s,

[PULL 1/1] virtio-pci: fix use of a released vector

2024-04-15 Thread Michael S. Tsirkin
From: Cindy Lu During the booting process of the non-standard image, the behavior of the called function in qemu is as follows: 1. vhost_net_stop() was triggered by guest image. This will call the function virtio_pci_set_guest_notifiers() with assgin= false, virtio_pci_set_guest_notifiers()

[PULL 0/1] virtio: bugfix

2024-04-15 Thread Michael S. Tsirkin
The following changes since commit e104a960c33b68fedf26dfb7b8e00abab8f2: qdev-monitor: fix error message in find_device_state() (2024-04-09 02:31:33 -0400) are available in the Git repository at: https://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch

Re: Discrepancy between mmap call on DPDK/libvduse and rust vm-memory crate

2024-04-15 Thread Eugenio Perez Martin
On Sun, Apr 14, 2024 at 11:02 AM Michael S. Tsirkin wrote: > > On Fri, Apr 12, 2024 at 12:15:40PM +0200, Eugenio Perez Martin wrote: > > Hi! > > > > I'm building a bridge to expose vhost-user devices through VDUSE. The > > code is still immature but I'm able to forward packets using > >

Re: [PATCH v8] virtio-pci: fix use of a released vector

2024-04-15 Thread Cindy Lu
On Mon, Apr 15, 2024 at 5:34 PM Michael S. Tsirkin wrote: > > From: Cindy Lu > > During the booting process of the non-standard image, the behavior of the > called function in qemu is as follows: > > 1. vhost_net_stop() was triggered by guest image. This will call the function >

RE: [PATCH v2 02/10] vfio: Introduce HIODLegacyVFIO device

2024-04-15 Thread Duan, Zhenzhong
Hi Philippe, >-Original Message- >From: Philippe Mathieu-Daudé >Sent: Monday, April 15, 2024 5:20 PM >To: Duan, Zhenzhong ; qemu- >de...@nongnu.org >Cc: alex.william...@redhat.com; c...@redhat.com; eric.au...@redhat.com; >pet...@redhat.com; jasow...@redhat.com; m...@redhat.com;

Re: [PATCH v5 1/3] ui/console: Introduce dpy_gl_qemu_dmabuf_get_..() helpers

2024-04-15 Thread Marc-André Lureau
Hi On Fri, Apr 12, 2024 at 7:57 AM wrote: > > From: Dongwon Kim > For patchew to handle your series, you need a cover letter. See: https://www.qemu.org/docs/master/devel/submitting-a-patch.html > This commit introduces dpy_gl_qemu_dmabuf_get_... helpers to extract > specific fields from the

Re: [PATCH v2] hw/i386/acpi: Set PCAT_COMPAT bit only when pic is not disabled

2024-04-15 Thread Michael S. Tsirkin
On Mon, Apr 15, 2024 at 05:51:56AM -0400, Michael S. Tsirkin wrote: > On Mon, Apr 15, 2024 at 11:44:50AM +0200, Paolo Bonzini wrote: > > Queued, thanks. > > > > Paolo > > I actually had it queued too - it's not 9.0 material though. > If you queue it don't forget to tweak the commit log manually.

Re: [PATCH v7 07/10] virtio-gpu: Handle resource blob commands

2024-04-15 Thread Akihiko Odaki
On 2024/04/15 17:49, Dmitry Osipenko wrote: On 4/15/24 11:13, Akihiko Odaki wrote: On 2024/04/15 17:03, Dmitry Osipenko wrote: Hello, On 4/13/24 14:57, Akihiko Odaki wrote: ... +static void +virtio_gpu_virgl_unmap_resource_blob(VirtIOGPU *g, + struct

Re: [PATCH v4 1/5] hw/display : Add device DM163

2024-04-15 Thread Philippe Mathieu-Daudé
Hi Inès, On 14/4/24 15:05, Inès Varhol wrote: This device implements the IM120417002 colors shield v1.1 for Arduino (which relies on the DM163 8x3-channel led driving logic) and features a simple display of an 8x8 RGB matrix. The columns of the matrix are driven by the DM163 and the rows are

RE: [PATCH v2 01/10] backends: Introduce abstract HostIOMMUDevice

2024-04-15 Thread Duan, Zhenzhong
>-Original Message- >From: Philippe Mathieu-Daudé >Subject: Re: [PATCH v2 01/10] backends: Introduce abstract >HostIOMMUDevice > >Hi Zhenzhong, > >On 8/4/24 10:12, Zhenzhong Duan wrote: >> Introduce HostIOMMUDevice as an abstraction of host IOMMU device. >> >> get_host_iommu_info() is

RE: [PATCH v2 01/10] backends: Introduce abstract HostIOMMUDevice

2024-04-15 Thread Duan, Zhenzhong
>-Original Message- >From: Cédric Le Goater >Subject: Re: [PATCH v2 01/10] backends: Introduce abstract >HostIOMMUDevice > >On 4/8/24 10:12, Zhenzhong Duan wrote: >> Introduce HostIOMMUDevice as an abstraction of host IOMMU device. >> >> get_host_iommu_info() is used to get host IOMMU

  1   2   >