Re: [RFC QEMU PATCH v9 2/2] virtio-pci: implement No_Soft_Reset bit

2024-04-16 Thread Yan Vugenfirer
On Wed, Apr 17, 2024 at 6:13 AM Chen, Jiqian wrote: > > On 2024/4/16 23:45, Igor Mammedov wrote: > > On Tue, 16 Apr 2024 15:01:27 +0800 > > Jiqian Chen wrote: > > > >> In current code, when guest does S3, virtio-gpu are reset due to the > >> bit No_Soft_Reset is not set. After resetting, the

Re: Intention to work on GSoC project

2024-04-16 Thread Sahil
Hi, Thank you for your reply. On Tuesday, April 16, 2024 2:11:16 PM IST Eugenio Perez Martin wrote: > [...] > > After re-reading the linked articles, I think I have got some more > > clarity. One confusion was related to the difference between vdpa > > and vhost-vdpa. > > > > So far what I have

RE: [PATCH v2 02/10] vfio: Introduce HIODLegacyVFIO device

2024-04-16 Thread Duan, Zhenzhong
>-Original Message- >From: Cédric Le Goater >Subject: Re: [PATCH v2 02/10] vfio: Introduce HIODLegacyVFIO device > >Hello, > >On 4/16/24 05:41, Duan, Zhenzhong wrote: >> Hi Cédric, >> >>> -Original Message- >>> From: Cédric Le Goater >>> Subject: Re: [PATCH v2 02/10] vfio:

RE: [PATCH v2 3/5] intel_iommu: Add a framework to do compatibility check with host IOMMU cap/ecap

2024-04-16 Thread Duan, Zhenzhong
>-Original Message- >From: Cédric Le Goater >Subject: Re: [PATCH v2 3/5] intel_iommu: Add a framework to do >compatibility check with host IOMMU cap/ecap > >Hello, > >On 4/16/24 09:09, Duan, Zhenzhong wrote: >> Hi Cédric, >> >>> -Original Message- >>> From: Cédric Le Goater >>>

Re: [PATCH v9 13/20] virtio-net: Return an error when vhost cannot enable RSS

2024-04-16 Thread Jason Wang
On Tue, Apr 16, 2024 at 5:51 PM Yuri Benditovich wrote: > > On Tue, Apr 16, 2024 at 10:14 AM Jason Wang wrote: > > > > On Tue, Apr 16, 2024 at 1:43 PM Yuri Benditovich > > wrote: > > > > > > On Tue, Apr 16, 2024 at 7:00 AM Jason Wang wrote: > > > > > > > > On Mon, Apr 15, 2024 at 10:05 PM Yuri

[PATCH v6 2/3] ui/console: Introduce dpy_gl_qemu_dmabuf_set_..() helpers

2024-04-16 Thread dongwon . kim
From: Dongwon Kim To enhance security in accessing the QemuDmaBuf struct, new helper functions for setting specific fields within the struct were introduced. And all occurrences where these fields were previously set directly have been updated to utilize these helper functions. Suggested-by:

[PATCH v6 0/3] ui/console: Private QemuDmaBuf struct

2024-04-16 Thread dongwon . kim
From: Dongwon Kim This series introduces privacy enhancements to the QemuDmaBuf struct and its contained data to bolster security. it accomplishes this by introducing of helper functions for allocating, deallocating, and accessing individual fields within the struct and replacing all direct

[PATCH v6 3/3] ui/console: Introduce dpy_gl_qemu_dmabuf_new() and free() helpers

2024-04-16 Thread dongwon . kim
From: Dongwon Kim This commit introduces utility functions for the creation and deallocation of QemuDmaBuf instances. Additionally, it updates all relevant sections of the codebase to utilize these new utility functions. Suggested-by: Marc-André Lureau Cc: Philippe Mathieu-Daudé Cc: Vivek

[PATCH v6 1/3] ui/console: Introduce dpy_gl_qemu_dmabuf_get_..() helpers

2024-04-16 Thread dongwon . kim
From: Dongwon Kim This commit introduces dpy_gl_qemu_dmabuf_get_... helpers to extract specific fields from the QemuDmaBuf struct. It also updates all instances where fields within the QemuDmaBuf struct are directly accessed, replacing them with calls to these new helper functions. v6: fix

Re: [RFC QEMU PATCH v9 2/2] virtio-pci: implement No_Soft_Reset bit

2024-04-16 Thread Chen, Jiqian
On 2024/4/16 23:45, Igor Mammedov wrote: > On Tue, 16 Apr 2024 15:01:27 +0800 > Jiqian Chen wrote: > >> In current code, when guest does S3, virtio-gpu are reset due to the >> bit No_Soft_Reset is not set. After resetting, the display resources >> of virtio-gpu are destroyed, then the display

Re: [PATCH] migration/colo: Fix bdrv_graph_rdlock_main_loop: Assertion `!qemu_in_coroutine()' failed.

2024-04-16 Thread Zhijian Li (Fujitsu)
On 17/04/2024 10:44, Li Zhijian wrote: > bdrv_activate_all() should not be called from the coroutine context, move > it to the QEMU thread colo_process_incoming_thread() with the bql_lock > protected. > > The backtrace is as follows: > #4 0x561af7948362 in bdrv_graph_rdlock_main_loop ()

[PATCH v2] migration/colo: Fix bdrv_graph_rdlock_main_loop: Assertion `!qemu_in_coroutine()' failed.

2024-04-16 Thread Li Zhijian via
bdrv_activate_all() should not be called from the coroutine context, move it to the QEMU thread colo_process_incoming_thread() with the bql_lock protected. The backtrace is as follows: #4 0x561af7948362 in bdrv_graph_rdlock_main_loop () at ../block/graph-lock.c:260 #5 0x561af7907a68

Re: [PATCH v8] virtio-pci: fix use of a released vector

2024-04-16 Thread Cindy Lu
On Tue, Apr 16, 2024 at 11:21 AM Jason Wang wrote: > > On Mon, Apr 15, 2024 at 6:41 PM Cindy Lu wrote: > > > > On Mon, Apr 15, 2024 at 5:34 PM Michael S. Tsirkin wrote: > > > > > > From: Cindy Lu > > > > > > During the booting process of the non-standard image, the behavior of the > > > called

[PATCH] migration/colo: Fix bdrv_graph_rdlock_main_loop: Assertion `!qemu_in_coroutine()' failed.

2024-04-16 Thread Li Zhijian via
bdrv_activate_all() should not be called from the coroutine context, move it to the QEMU thread colo_process_incoming_thread() with the bql_lock protected. The backtrace is as follows: #4 0x561af7948362 in bdrv_graph_rdlock_main_loop () at ../block/graph-lock.c:260 #5 0x561af7907a68

Re: [PATCH for-9.1 v3 2/2] trans_privileged.c.inc: set (m|s)tval on ebreak breakpoint

2024-04-16 Thread Richard Henderson
On 4/16/24 16:04, Daniel Henrique Barboza wrote: Privileged spec section 4.1.9 mentions: "When a trap is taken into S-mode, stval is written with exception-specific information to assist software in handling the trap. (...) If stval is written with a nonzero value when a breakpoint,

Re: [PATCH 0/7] plugins: Use unwind info for special gdb registers

2024-04-16 Thread Richard Henderson
On 4/16/24 17:35, Pierrick Bouvier wrote: On 4/15/24 21:06, Richard Henderson wrote: Based-on: 20240404230611.21231-1-richard.hender...@linaro.org ("[PATCH v2 00/21] Rewrite plugin code generation") This is an attempt to fix https://gitlab.com/qemu-project/qemu/-/issues/2208 ("PC is not

Re: [PATCH for-9.0] ppc440_pcix: Do not expose a bridge device on PCI bus

2024-04-16 Thread Nicholas Piggin
On Tue Apr 16, 2024 at 7:43 PM AEST, BALATON Zoltan wrote: > On Tue, 16 Apr 2024, Nicholas Piggin wrote: > > On Wed Apr 10, 2024 at 9:03 PM AEST, BALATON Zoltan wrote: > >> On Wed, 10 Apr 2024, Nicholas Piggin wrote: > >>> On Wed Apr 10, 2024 at 9:55 AM AEST, BALATON Zoltan wrote: > Real

Re: [PATCH 0/7] plugins: Use unwind info for special gdb registers

2024-04-16 Thread Pierrick Bouvier
On 4/15/24 21:06, Richard Henderson wrote: Based-on: 20240404230611.21231-1-richard.hender...@linaro.org ("[PATCH v2 00/21] Rewrite plugin code generation") This is an attempt to fix https://gitlab.com/qemu-project/qemu/-/issues/2208 ("PC is not updated for each instruction in TCG plugins") I

Re: [PATCH for-9.0 v3 2/2] qtest/virtio-9p-test.c: remove g_test_slow() gate

2024-04-16 Thread Daniel Henrique Barboza
On 4/16/24 16:54, Michael Tokarev wrote: 27.03.2024 17:20, Daniel Henrique Barboza : Commit 558f5c42ef gated the local tests with g_test_slow() to skip them in 'make check'. The reported issue back then was this following CI problem:

[PATCH for-9.1 v3 0/2] target/riscv: set tval in breakpoints

2024-04-16 Thread Daniel Henrique Barboza
Hi, This new version has a change suggested by Richard in v2. No other changes made. Changes from v2: - patch 2: - use tcg_constant_tl() instead of loading a temp and doing a movi_tl() - v2 link: https://lore.kernel.org/qemu-riscv/20240416194132.1843699-1-dbarb...@ventanamicro.com/

[PATCH for-9.1 v3 2/2] trans_privileged.c.inc: set (m|s)tval on ebreak breakpoint

2024-04-16 Thread Daniel Henrique Barboza
Privileged spec section 4.1.9 mentions: "When a trap is taken into S-mode, stval is written with exception-specific information to assist software in handling the trap. (...) If stval is written with a nonzero value when a breakpoint, address-misaligned, access-fault, or page-fault exception

[PATCH for-9.1 v3 1/2] target/riscv/debug: set tval=pc in breakpoint exceptions

2024-04-16 Thread Daniel Henrique Barboza
We're not setting (s/m)tval when triggering breakpoints of type 2 (mcontrol) and 6 (mcontrol6). According to the debug spec section 5.7.12, "Match Control Type 6": "The Privileged Spec says that breakpoint exceptions that occur on instruction fetches, loads, or stores update the tval CSR with

[ANNOUNCE] QEMU 9.0.0-rc4 is now available

2024-04-16 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the fifth release candidate for the QEMU 9.0 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu.org/qemu-9.0.0-rc4.tar.xz

Re: [PATCH for-9.1 v2 2/2] trans_privileged.c.inc: set (m|s)tval on ebreak breakpoint

2024-04-16 Thread Richard Henderson
On 4/16/24 12:41, Daniel Henrique Barboza wrote: @@ -62,6 +62,10 @@ static bool trans_ebreak(DisasContext *ctx, arg_ebreak *a) if (pre == 0x01f01013 && ebreak == 0x00100073 && post == 0x40705013) { generate_exception(ctx, RISCV_EXCP_SEMIHOST); } else { +TCGv temp =

Re: [PATCH 4/7] qcow2: make subclusters discardable

2024-04-16 Thread Andrey Drobyshev
On 10/27/23 14:10, Jean-Louis Dupond wrote: > [...] > > I've checked all the code paths, and as far as I see it nowhere breaks > the discard_no_unref option. > It's important that we don't introduce new code paths that can make > holes in the qcow2 image when this option is enabled :) > > If you

Re: [PATCH v2 3/4] hw/i2c: Convert to spec v7 terminology (automatically)

2024-04-16 Thread Miles Glenn
Looks good. Thanks for taking care of that for us! -Glenn Reviewed-by: Glenn Miles On Tue, 2024-04-16 at 20:47 +0200, Philippe Mathieu-Daudé wrote: > One of the biggest change from I2C spec v6 -> v7 is: > > • Updated the terms "master/slave" to "controller/target" > > Since it follows the

Re: [PATCH for-9.0 v3 2/2] qtest/virtio-9p-test.c: remove g_test_slow() gate

2024-04-16 Thread Michael Tokarev
27.03.2024 17:20, Daniel Henrique Barboza : Commit 558f5c42ef gated the local tests with g_test_slow() to skip them in 'make check'. The reported issue back then was this following CI problem: https://lists.nongnu.org/archive/html/qemu-devel/2020-11/msg05510.html This problem ended up being

[PATCH for-9.1 v2 1/2] target/riscv/debug: set tval=pc in breakpoint exceptions

2024-04-16 Thread Daniel Henrique Barboza
We're not setting (s/m)tval when triggering breakpoints of type 2 (mcontrol) and 6 (mcontrol6). According to the debug spec section 5.7.12, "Match Control Type 6": "The Privileged Spec says that breakpoint exceptions that occur on instruction fetches, loads, or stores update the tval CSR with

[PATCH for-9.1 v2 2/2] trans_privileged.c.inc: set (m|s)tval on ebreak breakpoint

2024-04-16 Thread Daniel Henrique Barboza
Privileged spec section 4.1.9 mentions: "When a trap is taken into S-mode, stval is written with exception-specific information to assist software in handling the trap. (...) If stval is written with a nonzero value when a breakpoint, address-misaligned, access-fault, or page-fault exception

[PATCH for-9.1 v2 0/2] target/riscv: set (m|s)tval on

2024-04-16 Thread Daniel Henrique Barboza
Hi, This is a re-send of the patch sent as a 9.0 bugfix in [1], now reframed as a non-bug fix chabge, A new patch (2) was added to handle a similar scenario with ebreak and tval. Changes from v1: - patch 1: - rewrite commit msg to make it clear that this is a non-bug fix change - new

Re: [PATCH 8/8] target/ppc: Move logical fixed-point instructions to decodetree.

2024-04-16 Thread Richard Henderson
On 4/15/24 23:39, Chinmay Rath wrote: Moving the below instructions to decodetree specification : andi[s]., {ori, xori}[s]: D-form {and, andc, nand, or, orc, nor, xor, eqv}[.], exts{b, h, w}[.], cnt{l, t}z{w, d}[.], popcnt{b, w, d},

Re: [PATCH 7/8] target/ppc: Move cmp{rb, eqb}, tw[i], td[i], isel instructions to decodetree.

2024-04-16 Thread Richard Henderson
On 4/15/24 23:39, Chinmay Rath wrote: Moving the following instructions to decodetree specification : cmp{rb, eqb}, t{w, d} : X-form t{w, d}i: D-form isel: A-form The changes were verified by validating that the tcg ops generated by

[PATCH v4 10/22] hw/i386/pc: Remove PCMachineClass::smbios_uuid_encoded

2024-04-16 Thread Philippe Mathieu-Daudé
PCMachineClass::smbios_uuid_encoded was only used by the pc-i440fx-2.1 machine, which got removed. It is now always true, remove it. Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Zhao Liu --- include/hw/i386/pc.h | 1 - hw/i386/fw_cfg.c | 3 +-- hw/i386/pc.c

[PATCH v4 09/22] target/i386/kvm: Remove x86_cpu_change_kvm_default() and 'kvm-cpu.h'

2024-04-16 Thread Philippe Mathieu-Daudé
x86_cpu_change_kvm_default() was only used out of kvm-cpu.c by the pc-i440fx-2.1 machine, which got removed. Make it static, and remove its declaration. "kvm-cpu.h" is now empty, remove it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Zhao Liu ---

[PATCH v4 22/22] hw/i386/pc: Replace PCMachineClass::acpi_data_size by PC_ACPI_DATA_SIZE

2024-04-16 Thread Philippe Mathieu-Daudé
PCMachineClass::acpi_data_size was only used by the pc-i440fx-2.0 machine, which got removed. Since it is constant, replace the class field by a definition (local to hw/i386/pc.c, since not used elsewhere). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Zhao Liu

[PATCH v4 11/22] hw/smbios: Remove 'uuid_encoded' argument from smbios_set_defaults()

2024-04-16 Thread Philippe Mathieu-Daudé
'uuid_encoded' is always true, remove it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Zhao Liu --- include/hw/firmware/smbios.h | 3 +-- hw/arm/virt.c| 3 +-- hw/i386/fw_cfg.c | 2 +- hw/loongarch/virt.c | 2 +- hw/riscv/virt.c | 2 +-

[PATCH v4 06/22] hw/acpi/ich9: Remove 'memory-hotplug-support' property

2024-04-16 Thread Philippe Mathieu-Daudé
No external code sets the 'memory-hotplug-support' property, remove it. Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Zhao Liu --- hw/acpi/ich9.c | 18 -- 1 file changed, 18 deletions(-) diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index

[PATCH v4 08/22] hw/i386/pc: Remove deprecated pc-i440fx-2.1 machine

2024-04-16 Thread Philippe Mathieu-Daudé
The pc-i440fx-2.1 machine was deprecated for the 8.2 release (see commit c7437f0ddb "docs/about: Mark the old pc-i440fx-2.0 - 2.3 machine types as deprecated"), time to remove it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Zhao Liu ---

[PATCH v4 19/22] hw/i386/acpi: Remove AcpiBuildState::rsdp field

2024-04-16 Thread Philippe Mathieu-Daudé
AcpiBuildState::rsdp is always NULL, remove it, simplifying acpi_build_update(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Zhao Liu --- hw/i386/acpi-build.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/i386/acpi-build.c

[PATCH v4 21/22] target/i386: Remove X86CPU::kvm_no_smi_migration field

2024-04-16 Thread Philippe Mathieu-Daudé
X86CPU::kvm_no_smi_migration was only used by the pc-i440fx-2.3 machine, which got removed. Remove it and simplify kvm_put_vcpu_events(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Zhao Liu --- target/i386/cpu.h | 3 --- target/i386/cpu.c | 2 -- target/i386/kvm/kvm.c | 7

[PATCH v4 20/22] hw/i386/pc: Remove deprecated pc-i440fx-2.3 machine

2024-04-16 Thread Philippe Mathieu-Daudé
The pc-i440fx-2.3 machine was deprecated for the 8.2 release (see commit c7437f0ddb "docs/about: Mark the old pc-i440fx-2.0 - 2.3 machine types as deprecated"), time to remove it. Signed-off-by: Philippe Mathieu-Daudé --- docs/about/deprecated.rst | 4 ++--

[PATCH v4 07/22] hw/acpi/ich9: Remove dead code related to 'acpi_memory_hotplug'

2024-04-16 Thread Philippe Mathieu-Daudé
acpi_memory_hotplug::is_enabled is set to %true once via ich9_lpc_initfn() -> ich9_pm_add_properties(). No need to check it, so remove now dead code. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Zhao Liu --- hw/acpi/ich9.c | 28 ++-- 1 file changed, 6

[PATCH v4 17/22] hw/i386/pc: Remove PCMachineClass::resizable_acpi_blob

2024-04-16 Thread Philippe Mathieu-Daudé
PCMachineClass::resizable_acpi_blob was only used by the pc-i440fx-2.2 machine, which got removed. It is now always true. Remove it, simplifying acpi_build(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Zhao Liu --- include/hw/i386/pc.h | 3 --- hw/i386/acpi-build.c | 10 --

[PATCH v4 05/22] hw/i386/acpi: Remove PCMachineClass::legacy_acpi_table_size

2024-04-16 Thread Philippe Mathieu-Daudé
PCMachineClass::legacy_acpi_table_size was only used by the pc-i440fx-2.0 machine, which got removed. Remove it and simplify acpi_build(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Zhao Liu --- include/hw/i386/pc.h | 1 - hw/i386/acpi-build.c | 62

[PATCH v4 18/22] hw/i386/pc: Remove PCMachineClass::rsdp_in_ram

2024-04-16 Thread Philippe Mathieu-Daudé
PCMachineClass::rsdp_in_ram was only used by the pc-i440fx-2.2 machine, which got removed. It is now always true. Remove it, simplifying acpi_setup(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Zhao Liu --- include/hw/i386/pc.h | 1 - hw/i386/acpi-build.c |

[PATCH v4 14/22] hw/mem/pc-dimm: Remove legacy_align argument from pc_dimm_pre_plug()

2024-04-16 Thread Philippe Mathieu-Daudé
'legacy_align' is always NULL, remove it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: David Hildenbrand Reviewed-by: Zhao Liu --- include/hw/mem/pc-dimm.h | 3 +-- hw/arm/virt.c| 2 +- hw/i386/pc.c | 2 +- hw/loongarch/virt.c | 2

[PATCH v4 16/22] hw/i386/pc: Remove deprecated pc-i440fx-2.2 machine

2024-04-16 Thread Philippe Mathieu-Daudé
The pc-i440fx-2.2 machine was deprecated for the 8.2 release (see commit c7437f0ddb "docs/about: Mark the old pc-i440fx-2.0 - 2.3 machine types as deprecated"), time to remove it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Zhao Liu ---

[PATCH v4 01/22] hw/i386/pc: Deprecate 2.4 to 2.12 pc-i440fx machines

2024-04-16 Thread Philippe Mathieu-Daudé
Similarly to the commit c7437f0ddb "docs/about: Mark the old pc-i440fx-2.0 - 2.3 machine types as deprecated", deprecate the 2.4 to 2.12 machines. Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Zhao Liu --- docs/about/deprecated.rst | 4

[PATCH v4 15/22] hw/mem/memory-device: Remove legacy_align from memory_device_pre_plug()

2024-04-16 Thread Philippe Mathieu-Daudé
'legacy_align' is always NULL, remove it, simplifying memory_device_pre_plug(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: David Hildenbrand Reviewed-by: Zhao Liu --- include/hw/mem/memory-device.h | 2 +- hw/i386/pc.c | 3 +--

[PATCH v4 12/22] hw/smbios: Remove 'smbios_uuid_encoded', simplify smbios_encode_uuid()

2024-04-16 Thread Philippe Mathieu-Daudé
'smbios_encode_uuid' is always true, remove it, simplifying smbios_encode_uuid(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Zhao Liu --- hw/smbios/smbios.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c index

[PATCH v4 02/22] hw/i386/pc: Remove deprecated pc-i440fx-2.0 machine

2024-04-16 Thread Philippe Mathieu-Daudé
The pc-i440fx-2.0 machine was deprecated for the 8.2 release (see commit c7437f0ddb "docs/about: Mark the old pc-i440fx-2.0 - 2.3 machine types as deprecated"), time to remove it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Zhao Liu ---

[PATCH v4 13/22] hw/i386/pc: Remove PCMachineClass::enforce_aligned_dimm

2024-04-16 Thread Philippe Mathieu-Daudé
PCMachineClass::enforce_aligned_dimm was only used by the pc-i440fx-2.1 machine, which got removed. It is now always true. Remove it, simplifying pc_get_device_memory_range(). Update the comment in Avocado test_phybits_low_pse36(). Reviewed-by: Zhao Liu Signed-off-by: Philippe Mathieu-Daudé ---

[PATCH v4 03/22] hw/usb/hcd-xhci: Remove XHCI_FLAG_FORCE_PCIE_ENDCAP flag

2024-04-16 Thread Philippe Mathieu-Daudé
XHCI_FLAG_FORCE_PCIE_ENDCAP was only used by the pc-i440fx-2.0 machine, which got removed. Remove it and simplify usb_xhci_pci_realize(). Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Zhao Liu --- hw/usb/hcd-xhci.h | 1 - hw/usb/hcd-xhci-nec.c | 2 --

[PATCH v4 00/22] hw/i386: Remove deprecated pc-i440fx-2.0 -> 2.3 machines

2024-04-16 Thread Philippe Mathieu-Daudé
Series fully reviewed. Since v3: - Deprecate up to 2.12 (Thomas) Since v2: - Addressed Zhao review comments Since v1: - Addressed Zhao and Thomas review comments Kill legacy code, because we need to evolve. I ended there via dynamic machine -> ICH9 -> legacy ACPI... This should also help

[PATCH v4 04/22] hw/usb/hcd-xhci: Remove XHCI_FLAG_SS_FIRST flag

2024-04-16 Thread Philippe Mathieu-Daudé
XHCI_FLAG_SS_FIRST was only used by the pc-i440fx-2.0 machine, which got removed. Remove it and simplify various functions in hcd-xhci.c. Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Zhao Liu --- hw/usb/hcd-xhci.h | 3 +-- hw/usb/hcd-xhci-nec.c | 2 --

[PATCH v2 4/4] hw/i2c: Convert to spec v7 terminology (manually)

2024-04-16 Thread Philippe Mathieu-Daudé
See previous commit for rationale. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i2c/i2c.h | 52 ++-- hw/i2c/core.c| 2 +- 2 files changed, 27 insertions(+), 27 deletions(-) diff --git a/include/hw/i2c/i2c.h b/include/hw/i2c/i2c.h index

[PATCH v2 0/4] hw/i2c: Convert to spec v7 (inclusive) terminology

2024-04-16 Thread Philippe Mathieu-Daudé
Since v1: - Convert TYPE_I2C_TARGET definition (Paolo) Mechanical (mostly) conversion inspired by Wolfram [*] to use inclusive terminology, similarly to the other renames we did 3 years ago, shortly before the I2C spec v7 was published. This series convert core I2C. Following will convert the

[PATCH v2 3/4] hw/i2c: Convert to spec v7 terminology (automatically)

2024-04-16 Thread Philippe Mathieu-Daudé
One of the biggest change from I2C spec v6 -> v7 is: • Updated the terms "master/slave" to "controller/target" Since it follows the inclusive terminology from the "Conscious Language in your Open Source Projects" guidelines [*], replace the I2C terminology. Mechanical transformation running:

[PATCH v2 2/4] hw/i2c: Fix checkpatch line over 80 chars warnings

2024-04-16 Thread Philippe Mathieu-Daudé
We are going to modify these lines, fix their style in order to avoid checkpatch.pl warnings: WARNING: line over 80 characters Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i2c/i2c.h| 11 ++- include/hw/nvram/eeprom_at24c.h | 6 +- hw/arm/aspeed.c | 140

[PATCH v2 1/4] hw/i2c: Fix checkpatch block comment warnings

2024-04-16 Thread Philippe Mathieu-Daudé
We are going to modify these lines, fix their style in order to avoid checkpatch.pl warnings: WARNING: Block comments use a leading /* on a separate line WARNING: Block comments use * on subsequent lines WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Philippe

Re: [PATCH] virtio-pci: Fix the failure process in kvm_virtio_pci_vector_use_one()

2024-04-16 Thread Michael S. Tsirkin
On Tue, Apr 16, 2024 at 02:14:57PM +0100, Peter Maydell wrote: > On Tue, 16 Apr 2024 at 13:41, Cindy Lu wrote: > > > > On Tue, Apr 16, 2024 at 8:30 PM Peter Maydell > > wrote: > > > > > > On Tue, 16 Apr 2024 at 13:29, Cindy Lu wrote: > > > > > > > > In function kvm_virtio_pci_vector_use_one(),

Re: [PATCH 6/8] target/ppc: Move div/mod fixed-point insns (64 bits operands) to decodetree.

2024-04-16 Thread Richard Henderson
On 4/15/24 23:39, Chinmay Rath wrote: Moving the below instructions to decodetree specification : divd[u, e, eu][o][.]: XO-form mod{sd, ud} : X-form With this patch, all the fixed-point arithmetic instructions have been moved to decodetree. The changes were

Re: [PATCH 5/8] target/ppc: Move multiply fixed-point insns (64-bit operands) to decodetree.

2024-04-16 Thread Richard Henderson
On 4/15/24 23:39, Chinmay Rath wrote: +static bool trans_MADDHDU(DisasContext *ctx, arg_MADDHDU *a) ... +tcg_gen_movi_i64(t1, 0); Drop the movi. +tcg_gen_add2_i64(t1, cpu_gpr[a->vrt], lo, hi, cpu_gpr[a->rc], t1); Use tcg_constant_i64(0). With that, Reviewed-by: Richard Henderson

Re: [PATCH RFC] prevent overflow in xlnx_dpdma_desc_get_source_address()

2024-04-16 Thread Edgar E. Iglesias
+ To: Fred On Tue, 16 Apr 2024 at 19:56, Alexandra Diupina wrote: > Peter, thank you! I agree with you that > as mentioned in the documentation > https://docs.amd.com/r/en-US/ug1085-zynq-ultrascale-trm/ADDR_EXT-Field, > we should take 32 bits of the address from one field > (for example, case

Re: Qemu for TC377

2024-04-16 Thread Sameer Kalliadan Poyil
Hi Bastian, Thanks for the information. I thought that I can do some prototyping before the HW arrives. :) Yes I am interested for your bare metal program boot_to_main run it on TSIM. Is Infineon TSIM free? I searched it and I didn't find any download link. Could you please give a link for that

Re: [PATCH 4/8] target/ppc: Move neg, darn, mod{sw, uw} to decodetree.

2024-04-16 Thread Richard Henderson
On 4/15/24 23:39, Chinmay Rath wrote: Moving the below instructions to decodetree specification : neg[o][.] : XO-form mod{sw, uw}, darn : X-form The changes were verified by validating that the tcg ops generated by those instructions remain the same, which

Re: [Stable-8.2.3 00/87] Patch Round-up for stable 8.2.3, freeze on 2024-04-20

2024-04-16 Thread Michael Tokarev
16.04.2024 20:34, Cole Robinson wrote: We have a couple patches in f40 that are bug fixes, avoids a crash on invalid maxcpus for ppc64 guests. First is a prep patch. bug details in patch 2 commit 2df5c1f5b014126595a26c6797089d284a3b211c Author: Harsh Prateek Bora Date: Wed Jan 24 10:30:55

Re: [PATCH 3/8] target/ppc: Move divw[u, e, eu] instructions to decodetree.

2024-04-16 Thread Richard Henderson
On 4/15/24 23:39, Chinmay Rath wrote: Moving the following instructions to decodetree specification : divw[u, e, eu][o][.] : XO-form The changes were verified by validating that the tcg ops generated by those instructions remain the same, which were captured with the '-d in_asm,op'

Re: Add 'info pg' command to monitor

2024-04-16 Thread Don Porter
On 4/16/24 13:03, Peter Maydell wrote: On Tue, 16 Apr 2024 at 17:53, Don Porter wrote: There is still a lot I am learning about the code base, but it seems that qemu_get_guest_memory_mapping() does most of what one would need. It currently only returns the "leaves" of the page table tree in a

Re: [PATCH 2/8] target/ppc: Make divw[u] handler method decodetree compatible.

2024-04-16 Thread Richard Henderson
On 4/15/24 23:39, Chinmay Rath wrote: The handler methods for divw[u] instructions internally use Rc(ctx->opcode), for extraction of Rc field of instructions, which poses a problem if we move the above said instructions to decodetree, as the ctx->opcode field is not popluated in decodetree.

Re: [PATCH RFC] prevent overflow in xlnx_dpdma_desc_get_source_address()

2024-04-16 Thread Alexandra Diupina
Peter, thank you! I agree with you that as mentioned in the documentation https://docs.amd.com/r/en-US/ug1085-zynq-ultrascale-trm/ADDR_EXT-Field, we should take 32 bits of the address from one field (for example, case 1, SRC_ADDR2_EXT - in code it is desc->source_address2) and 16 bits (high or

Re: [PATCH 1/8] target/ppc: Move mul{li, lw, lwo, hw, hwu} instructions to decodetree.

2024-04-16 Thread Richard Henderson
On 4/15/24 23:39, Chinmay Rath wrote: Moving the following instructions to decodetree specification : mulli : D-form mul{lw, lwo, hw, hwu}[.]: XO-form The changes were verified by validating that the tcg ops generated by those instructions

Re: [Stable-8.2.3 00/87] Patch Round-up for stable 8.2.3, freeze on 2024-04-20

2024-04-16 Thread Cole Robinson
On 4/10/24 3:21 AM, Michael Tokarev wrote: > The following patches are queued for QEMU stable v8.2.3: > > https://gitlab.com/qemu-project/qemu/-/commits/staging-8.2 > > Patch freeze is 2024-04-20, and the release is planned for 2024-04-22: > > https://wiki.qemu.org/Planning/8.2 > > Please

Re: [PATCH v6 09/12] hw/cxl/events: Add qmp interfaces to add/release dynamic capacity extents

2024-04-16 Thread Gregory Price
On Tue, Apr 16, 2024 at 03:58:22PM +0100, Jonathan Cameron wrote: > On Mon, 15 Apr 2024 13:06:04 -0700 > fan wrote: > > > From ce75be83e915fbc4dd6e489f976665b81174002b Mon Sep 17 00:00:00 2001 > > From: Fan Ni > > Date: Tue, 20 Feb 2024 09:48:31 -0800 > > Subject: [PATCH 09/13] hw/cxl/events:

Re: [PATCH v6 10/12] hw/mem/cxl_type3: Add dpa range validation for accesses to DC regions

2024-04-16 Thread Gregory Price
On Tue, Apr 16, 2024 at 04:00:56PM +0100, Jonathan Cameron wrote: > On Mon, 15 Apr 2024 10:37:00 -0700 > fan wrote: > > > On Fri, Apr 12, 2024 at 06:54:42PM -0400, Gregory Price wrote: > > > On Mon, Mar 25, 2024 at 12:02:28PM -0700, nifan@gmail.com wrote: > > > > From: Fan Ni > > > > > >

Re: [PATCH v2 3/6] hw/ppc: SPI controller model - sequencer and shifter

2024-04-16 Thread Chalapathi V
On 16-04-2024 15:09, Cédric Le Goater wrote: Hello, Please rephrase the subject to something like:   "ppc/pnv: Extend SPI model ..." Using a verb is preferable. Sure. Will update. Thank You. On 4/9/24 19:56, Chalapathi V wrote: In this commit SPI shift engine and sequencer logic is

Re: Add 'info pg' command to monitor

2024-04-16 Thread Peter Maydell
On Tue, 16 Apr 2024 at 17:53, Don Porter wrote: > There is still a lot I am learning about the code base, but it seems > that qemu_get_guest_memory_mapping() does most of what one would need. > It currently only returns the "leaves" of the page table tree in a list. > > What if I extend this

Re: [PATCH v2 2/6] hw/ppc: SPI controller model - registers implementation

2024-04-16 Thread Chalapathi V
On 15-04-2024 20:44, Cédric Le Goater wrote: Hello Chalapathi The subject could be rephrased to : "ppc/pnv: Add SPI controller model". On 4/9/24 19:56, Chalapathi V wrote: SPI controller device model supports a connection to a single SPI responder. This provide access to SPI seeproms, TPM,

Re: Add 'info pg' command to monitor

2024-04-16 Thread Don Porter
On 4/15/24 12:37, Peter Maydell wrote: On Mon, 15 Apr 2024 at 17:09, Don Porter wrote: This patch set adds an 'info pg' command to the monitor, which prints a nicer view of the page tables. A project in my graduate OS course involves implementing x86 page table support, and my students have

Re: [PATCH v6 09/12] hw/cxl/events: Add qmp interfaces to add/release dynamic capacity extents

2024-04-16 Thread fan
On Tue, Apr 16, 2024 at 03:58:22PM +0100, Jonathan Cameron wrote: > On Mon, 15 Apr 2024 13:06:04 -0700 > fan wrote: > > > From ce75be83e915fbc4dd6e489f976665b81174002b Mon Sep 17 00:00:00 2001 > > From: Fan Ni > > Date: Tue, 20 Feb 2024 09:48:31 -0800 > > Subject: [PATCH 09/13] hw/cxl/events:

Re: [PATCH v3 15/16] test/avocado/machine_aspeed.py: Add AST2700 test case

2024-04-16 Thread Cédric Le Goater
On 4/16/24 11:19, Jamin Lin wrote: Add a test case to test Aspeed OpenBMC SDK v09.01 on AST2700 board. It loads u-boot-nodtb.bin, u-boot.dtb, tfa and optee-os images to dram first which base address is 0x4. Then, boot and launch 4 cpu cores. ``` qemu-system-aarch64 -machine ast2700-evb

Re: [PATCH v6 10/12] hw/mem/cxl_type3: Add dpa range validation for accesses to DC regions

2024-04-16 Thread fan
On Tue, Apr 16, 2024 at 04:00:56PM +0100, Jonathan Cameron wrote: > On Mon, 15 Apr 2024 10:37:00 -0700 > fan wrote: > > > On Fri, Apr 12, 2024 at 06:54:42PM -0400, Gregory Price wrote: > > > On Mon, Mar 25, 2024 at 12:02:28PM -0700, nifan@gmail.com wrote: > > > > From: Fan Ni > > > > > >

Re: [PATCH] Add zh_TW Traditional Chinese translation

2024-04-16 Thread Daniel P . Berrangé
On Wed, Apr 17, 2024 at 12:41:16AM +0800, Zhao Liu wrote: > Hi Peter, > > On Tue, Apr 16, 2024 at 02:27:45PM +0100, Peter Maydell wrote: > > Date: Tue, 16 Apr 2024 14:27:45 +0100 > > From: Peter Maydell > > Subject: Re: [PATCH] Add zh_TW Traditional Chinese translation > > > > On Tue, 16 Apr

Re: [PATCH v6 08/12] hw/cxl/cxl-mailbox-utils: Add mailbox commands to support add/release dynamic capacity response

2024-04-16 Thread fan
On Tue, Apr 16, 2024 at 10:02:53AM +, Jørgen Hansen wrote: > On 4/15/24 19:56, fan wrote: > > From 4b9695299d3d4b22f83666f8ab79099ec9f9817f Mon Sep 17 00:00:00 2001 > > From: Fan Ni > > Date: Tue, 20 Feb 2024 09:48:30 -0800 > > Subject: [PATCH 08/13] hw/cxl/cxl-mailbox-utils: Add mailbox

Re: [PATCH] Add zh_TW Traditional Chinese translation

2024-04-16 Thread Zhao Liu
Hi Peter, On Tue, Apr 16, 2024 at 02:27:45PM +0100, Peter Maydell wrote: > Date: Tue, 16 Apr 2024 14:27:45 +0100 > From: Peter Maydell > Subject: Re: [PATCH] Add zh_TW Traditional Chinese translation > > On Tue, 16 Apr 2024 at 14:00, Peter Dave Hello > wrote: > > > > From: Peter Dave Hello >

Re: [PATCH] Add zh_TW Traditional Chinese translation

2024-04-16 Thread Zhao Liu
On Tue, Apr 16, 2024 at 11:31:24AM +, Peter Dave Hello wrote: > Date: Tue, 16 Apr 2024 11:31:24 + > From: Peter Dave Hello > Subject: [PATCH] Add zh_TW Traditional Chinese translation > > From: Peter Dave Hello > Date: Tue, 16 Apr 2024 00:43:29 +0800 > Subject: [PATCH] Add a simple

Re: [QEMU][PATCH v3 5/7] memory: add MemoryRegion map and unmap callbacks

2024-04-16 Thread Peter Xu
On Tue, Apr 16, 2024 at 03:28:41PM +0200, Jürgen Groß wrote: > On 16.04.24 13:32, Edgar E. Iglesias wrote: > > On Wed, Apr 10, 2024 at 8:56 PM Peter Xu wrote: > > > > > > On Wed, Apr 10, 2024 at 06:44:38PM +0200, Edgar E. Iglesias wrote: > > > > On Tue, Feb 27, 2024 at 11:37 PM Vikram Garhwal >

Re: [PATCH v3 16/16] docs:aspeed: Add AST2700 Evaluation board

2024-04-16 Thread Cédric Le Goater
On 4/16/24 11:19, Jamin Lin wrote: Add AST2700 Evaluation board and its boot command. Signed-off-by: Troy Lee Signed-off-by: Jamin Lin Reviewed-by: Cédric Le Goater Thanks, C. --- docs/system/arm/aspeed.rst | 39 ++ 1 file changed, 35

Re: [PATCH v3 01/22] hw/i386/pc: Deprecate 2.4 to 2.7 pc-i440fx machines

2024-04-16 Thread Thomas Huth
On 16/04/2024 16.49, Philippe Mathieu-Daudé wrote: On 16/4/24 16:23, Thomas Huth wrote: On 16/04/2024 15.52, Philippe Mathieu-Daudé wrote: Similarly to the commit c7437f0ddb "docs/about: Mark the old pc-i440fx-2.0 - 2.3 machine types as deprecated", deprecate the 2.4 to 2.7 machines.

Re: [RFC QEMU PATCH v9 2/2] virtio-pci: implement No_Soft_Reset bit

2024-04-16 Thread Igor Mammedov
On Tue, 16 Apr 2024 15:01:27 +0800 Jiqian Chen wrote: > In current code, when guest does S3, virtio-gpu are reset due to the > bit No_Soft_Reset is not set. After resetting, the display resources > of virtio-gpu are destroyed, then the display can't come back and only > show blank after

Re: [PATCH v3 06/16] aspeed/smc: correct device description

2024-04-16 Thread Cédric Le Goater
On 4/16/24 11:18, Jamin Lin wrote: Signed-off-by: Troy Lee Signed-off-by: Jamin Lin Reviewed-by: Cédric Le Goater Thanks, C. --- hw/ssi/aspeed_smc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c index

Re: [PATCH v3 05/16] aspeed/sdmc: Add AST2700 support

2024-04-16 Thread Cédric Le Goater
On 4/16/24 11:18, Jamin Lin wrote: The SDRAM memory controller(DRAMC) controls the access to external DDR4 and DDR5 SDRAM and power up to DDR4 and DDR5 PHY. The DRAM memory controller of AST2700 is not backward compatible to previous chips such AST2600, AST2500 and AST2400. Max memory is now

Re: [PATCH v3 27/27] target/i386/kvm: Improve KVM_EXIT_NOTIFY warnings

2024-04-16 Thread Peter Maydell
On Fri, 12 Apr 2024 at 08:37, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/i386/kvm/kvm.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c > index e68cbe9293..1fc809b2f9 100644 >

Re: [PATCH v3 02/16] aspeed/sli: Add AST2700 support

2024-04-16 Thread Cédric Le Goater
Hello Jamin, On 4/16/24 11:18, Jamin Lin wrote: AST2700 SLI engine is designed to accelerate the throughput between cross-die connections. It have CPU_SLI at CPU die and IO_SLI at IO die. Introduce dummy AST2700 SLI and SLIIO models. Signed-off-by: Troy Lee Signed-off-by: Jamin Lin ---

Re: [PATCH v3 04/16] aspeed/sdmc: fix coding style

2024-04-16 Thread Cédric Le Goater
On 4/16/24 11:18, Jamin Lin wrote: Fix coding style issues from checkpatch.pl Test command: scripts/checkpatch.pl --no-tree -f hw/misc/aspeed_sdmc.c Signed-off-by: Troy Lee Signed-off-by: Jamin Lin Reviewed-by: Cédric Le Goater Thanks, C. --- hw/misc/aspeed_sdmc.c | 11 +++

Re: [PATCH v3 03/16] aspeed/sdmc: remove redundant macros

2024-04-16 Thread Cédric Le Goater
On 4/16/24 11:18, Jamin Lin wrote: These macros are no longer used for ASPEED SOCs, so removes them. Signed-off-by: Troy Lee Signed-off-by: Jamin Lin Reviewed-by: Cédric Le Goater Thanks, C. --- hw/misc/aspeed_sdmc.c | 15 --- 1 file changed, 15 deletions(-) diff

Re: [PATCH v3 27/27] target/i386/kvm: Improve KVM_EXIT_NOTIFY warnings

2024-04-16 Thread Zhao Liu
On Fri, Apr 12, 2024 at 12:33:46AM -0700, Richard Henderson wrote: > Date: Fri, 12 Apr 2024 00:33:46 -0700 > From: Richard Henderson > Subject: [PATCH v3 27/27] target/i386/kvm: Improve KVM_EXIT_NOTIFY warnings > X-Mailer: git-send-email 2.34.1 > > Signed-off-by: Richard Henderson > --- >

Re: [PATCH v9] arm/kvm: Enable support for KVM_ARM_VCPU_PMU_V3_FILTER

2024-04-16 Thread Cornelia Huck
On Wed, Apr 10 2024, Thomas Huth wrote: > On 09/04/2024 09.47, Shaoqin Huang wrote: >> Hi Thmoas, >> >> On 4/9/24 13:33, Thomas Huth wrote: +    assert_has_feature(qts, "host", "kvm-pmu-filter"); >>> >>> So you assert here that the feature is available ... >>>  

Re: [PATCH v3 20/22] hw/i386/pc: Remove deprecated pc-i440fx-2.3 machine

2024-04-16 Thread Zhao Liu
On Tue, Apr 16, 2024 at 03:52:49PM +0200, Philippe Mathieu-Daudé wrote: > Date: Tue, 16 Apr 2024 15:52:49 +0200 > From: Philippe Mathieu-Daudé > Subject: [PATCH v3 20/22] hw/i386/pc: Remove deprecated pc-i440fx-2.3 > machine > X-Mailer: git-send-email 2.41.0 > > The pc-i440fx-2.3 machine was

Re: [PATCH v3 5/6] target/arm: Do memory type alignment check when translation disabled

2024-04-16 Thread Jonathan Cameron via
On Fri, 1 Mar 2024 10:41:09 -1000 Richard Henderson wrote: > If translation is disabled, the default memory type is Device, which > requires alignment checking. This is more optimally done early via > the MemOp given to the TCG memory operation. > > Reviewed-by: Philippe Mathieu-Daudé >

  1   2   3   >