Re: [PATCH v4 1/2] ui/cocoa: capture all keys and combos when mouse is grabbed

which I didn't notice when I reviewed this patch before. [NSApplication sharedApplication] is casted to QemuCocoaAppController *, but its type is QemuApplication. Perhaps it should be: QemuCocoaAppController* controller = (QemuCocoaAppController *)[[NSApplication sharedApplication] delegate]; and the following [controller delegate] should be replaced with controller. Regards, Akihiko Odaki

[PATCH] coreaudio: Fix output stream format settings

is consistent with what QEMU expects, but that expectation is not in the code, which makes it harder to understand and will lead to breakage if the initial settings change. This change explicitly sets all of the output stream settings to solve these problems. Signed-off-by: Akihiko Odaki --- audio

[PATCH 0/1] input: Add lang1 and lang2 to QKeyCode

This patch adds two QKeyCodes. The corresponding path for ui/keycodemapdb titled "Add QEMU QKeyCode 'lang1' and 'lang2'" will shortly be submitted. This patch should be applied *before* applying the patch for ui/keycodemapdb, or it causes build failures. Akihiko Odaki (1): input:

[PATCH 1/1] input: Add lang1 and lang2 to QKeyCode

key" in the specification, the meaning depends on the variety of the keyboard, and it will be used as the representations of Kana and Eisu keys on Japanese Macs in qemu_input_map_osx_to_qcode, which is used by ui/gtk. Signed-off-by: Akihiko Odaki --- qapi/ui.json | 6 +- 1 file changed, 5 inse

[PATCH] ui/cocoa: Set UI information

Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 49 + 1 file changed, 49 insertions(+) diff --git a/ui/cocoa.m b/ui/cocoa.m index 995301502be..8b83f91723a 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -540,6 +540,43 @@ - (void) setContentDimensions

[ui/keycodemapdb PATCH 1/1] Add QEMU QKeyCode "lang1" and "lang2"

Signed-off-by: Akihiko Odaki --- data/keymaps.csv | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/data/keymaps.csv b/data/keymaps.csv index 6b1631e..1ffe3b0 100644 --- a/data/keymaps.csv +++ b/data/keymaps.csv @@ -192,8 +192,8 @@ KEY_PAUSE,119,,,0xe046,0xe077,0x62,72

[ui/keycodemapdb PATCH 0/1] Add QEMU QKeyCode "lang1" and "lang2"

This patch is corresponding to QEMU patch "input: Add lang1 and lang2 to QKeyCode". This should be applied *after* applying the patch for QEMU. Akihiko Odaki (1): Add QEMU QKeyCode "lang1" and "lang2" data/keymaps.csv | 4 ++-- 1 file changed, 2 insertions(

[PATCH] audio: Fix format specifications of debug logs

Signed-off-by: Akihiko Odaki --- audio/audio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/audio/audio.c b/audio/audio.c index 534278edfed..6eba208cdba 100644 --- a/audio/audio.c +++ b/audio/audio.c @@ -704,7 +704,7 @@ static size_t audio_pcm_sw_write(SWVoiceOut *sw

[PATCH] ui/cocoa: Add clipboard support

Signed-off-by: Akihiko Odaki --- include/ui/clipboard.h | 2 +- ui/clipboard.c | 2 +- ui/cocoa.m | 109 + 3 files changed, 111 insertions(+), 2 deletions(-) diff --git a/include/ui/clipboard.h b/include/ui/clipboard.h index

[PATCH v2] meson: Add gnutls as a dependency to libmigration

qemu-file-channel.c may depend on GnuTLS. Signed-off-by: Akihiko Odaki --- meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/meson.build b/meson.build index a2311eda6ec..29d854699ca 100644 --- a/meson.build +++ b/meson.build @@ -2090,6 +2090,7 @@ libio = static_library('io

Re: [PATCH v2] meson: Add gnutls as a dependency to libmigration

2021年6月18日(金) 2:39 Philippe Mathieu-Daudé : > > On 6/17/21 7:19 PM, Akihiko Odaki wrote: > > qemu-file-channel.c may depend on GnuTLS. > > > > Signed-off-by: Akihiko Odaki > > --- > > meson.build | 1 + > > 1 file changed, 1 insertion(+) > > >

[PATCH] meson: Add gnutls as a dependency to libmigration

qemu-file-channel.c may depend on GnuTLS. Signed-off-by: Akihiko Odaki --- meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index a2311eda6ec..b8812dff387 100644 --- a/meson.build +++ b/meson.build @@ -2090,6 +2090,7 @@ libio

[PATCH] virtio-gpu: Call Virgl only in the main thread

virtio_gpu_virgl_reset happens in the main thread, this change makes virtio_gpu_virgl_reset happen only in the main thread. Signed-off-by: Akihiko Odaki --- hw/display/virtio-gpu-gl.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/hw/display/virtio-gpu-gl.c b/hw

[PATCH v2] coreaudio: Lock only the buffer

, and the device configuration change will be protected with the implicit iothread mutex. Signed-off-by: Akihiko Odaki --- audio/coreaudio.c | 102 +++--- 1 file changed, 41 insertions(+), 61 deletions(-) diff --git a/audio/coreaudio.c b/audio/coreaudio.c

[PATCH] coreaudio: Lock only the buffer

, and the device configuration change will be protected with the implicit iothread mutex. Signed-off-by: Akihiko Odaki --- audio/coreaudio.c | 59 +++ 1 file changed, 13 insertions(+), 46 deletions(-) diff --git a/audio/coreaudio.c b/audio/coreaudio.c

[PATCH v2 1/1] input: Add lang1 and lang2 to QKeyCode

key" in the specification, the meaning depends on the variety of the keyboard, and it will be used as the representations of Kana and Eisu keys on Japanese Macs in qemu_input_map_osx_to_qcode, which is used by ui/gtk. Signed-off-by: Akihiko Odaki --- qapi/ui.json | 6 +- 1 file changed, 5 inse

[PATCH v2 0/1] input: Add lang1 and lang2 to QKeyCode

ilable "since 6.1". Akihiko Odaki (1): input: Add lang1 and lang2 to QKeyCode qapi/ui.json | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) -- 2.30.1 (Apple Git-130)

Re: [PATCH v4 2/2] ui/cocoa: add option to swap Option and Command

Reviewed-by: Akihiko Odaki I applied them to my personal tree: https://github.com/akihikodaki/qemu/tree/macos 2021年5月12日(水) 3:56 : > > From: Gustavo Noronha Silva > > On Mac OS X the Option key maps to Alt and Command to Super/Meta. This change > swaps them around so that Alt is

Re: [PATCH v3 1/2] ui/cocoa: capture all keys and combos when mouse is grabbed

be captured.\n"); +return self; +} + +CFRunLoopAddSource(runLoop, tapEventsSrc, kCFRunLoopDefaultMode); +CFRelease(tapEventsSrc); + return self; } These statements should be in "if (self)" block which they follow, or it may rely on "self" even if it failed to allocate and initialize "self". Regards, Akihiko Odaki

[PATCH] ui: update keycodemapdb submodule commit

and "lang2" 320f92c36a80bfafc5d57834592a7be5fd79f104 rust: fix cargo clippy e62d42f0fd76f7bb8bf78385a83c060e66ff52b0 tests: add rust test 3e25e1ca1772fc3f2039f739f8f920450dc68e50 gen: add --lang rust 9133a0b8022d1fb063a81cc2ba3b627c14ccdfd1 tests: fix argument order Signed-off-by: Akihiko Odaki --- ui/keycode

[PATCH v3] net/macos: implement vmnet-based netdev

t this patch requires macOS 10.15 as a minimum, as this is when bridging support was implemented in vmnet.framework. Rebased to commit 9aef0954195cc592e86846dbbe7f3c2c5603690a by Akihiko Odaki. Signed-off-by: Phillip Tennen Signed-off-by: Akihiko Odaki Message-Id: <20210315103209.20870-1-akih

Re: Picture missing in About dialog on cocoa ui

. Regards, Akihiko Odaki On Thu, Jul 8, 2021 at 2:00 AM Programmingkid wrote: > > Hello, now that the code to add the icon to QEMU has been restored for Mac > OS, I think it is time to revert patch > e31746ecf8dd2f25f687c94ac14016a3ba5debfc. This patch was made to fix the > missing ic

[PATCH] ui/cocoa: Use the standard about panel

This provides standard look and feel for the about panel and reduces code. Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 111 +++-- 1 file changed, 23 insertions(+), 88 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 9f72844b079

[PATCH] ui/cocoa: Do not perform unsafe cast of argv

Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 9f72844b079..68a6302184a 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -1888,12 +1888,12 @@ static void cocoa_clipboard_request(QemuClipboardInfo *info

[PATCH v2] ui/cocoa: Fix the type of main's argv

Signed-off-by: Akihiko Odaki Reviewed-by: Peter Maydell --- ui/cocoa.m | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 9f72844b079..68a6302184a 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -1888,12 +1888,12 @@ static void

[PATCH 2/4] datadir: Use bundle mechanism

bundle mechanism and softmmu/datadir.c provides some overlapped functionality. Use bundle mechanism in softmmu/datadir.c to remove the redundancy. Signed-off-by: Akihiko Odaki --- configure | 2 ++ meson.build | 2 +- softmmu/datadir.c | 35 --- 3

[PATCH 4/4] net: Use bundle mechanism

Signed-off-by: Akihiko Odaki --- configure | 1 + include/net/net.h | 2 +- meson.build | 1 + net/tap.c | 6 +- qemu-options.hx | 4 ++-- 5 files changed, 10 insertions(+), 4 deletions(-) diff --git a/configure b/configure index a9f746849ec..aa8e096faaa 100755

[PATCH 1/4] cutils: Introduce bundle mechanism

Developers often run QEMU without installing. The bundle mechanism allows to look up files which should be present in installation even in such a situation. Signed-off-by: Akihiko Odaki --- include/qemu/cutils.h | 19 +++ util/cutils.c | 33

[PATCH 3/4] ui/icons: Use bundle mechanism

Signed-off-by: Akihiko Odaki --- configure | 10 ++ meson.build | 3 +-- ui/cocoa.m | 20 +++- ui/gtk.c| 8 +--- ui/sdl2.c | 18 +++--- 5 files changed, 38 insertions(+), 21 deletions(-) diff --git a/configure b/configure index cff5a8ac280

[PATCH] ui/cocoa: Update the state if absolute gets disabled

ui/cocoa used to update the internal state corresponding to qemu_input_is_absolute only when it becomes true. Use qemu_add_mouse_mode_change_notifier to get notified also when it becomes false. Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 31 ++- 1 file changed, 18

Re: [PATCH v2] ui/cocoa: Use NSWindow's ability to resize

2021年6月28日(月) 17:57 BALATON Zoltan : > > On Mon, 28 Jun 2021, Akihiko Odaki wrote: > > This change brings two new features: > > - The window will be resizable if "Zoom To Fit" is eanbled > > - The window can be made full screen by clicking full screen bu

Re: [PATCH v6 3/7] qemu-nbd: Use qcrypto_tls_creds_check_endpoint()

Tested-by: Akihiko Odaki 2021年6月29日(火) 1:09 Philippe Mathieu-Daudé : > > Avoid accessing QCryptoTLSCreds internals by using > the qcrypto_tls_creds_check_endpoint() helper. > > Signed-off-by: Philippe Mathieu-Daudé > --- > qemu-nbd.c | 19 +++ > 1 fi

[PATCH] coreaudio: Commit the result of init in the end

now whether the output device is initialized after calling init_out_device. Signed-off-by: Akihiko Odaki --- audio/coreaudio.c | 47 +-- 1 file changed, 25 insertions(+), 22 deletions(-) diff --git a/audio/coreaudio.c b/audio/coreaudio.c index d8a21d3e

Re: [PATCH v2] ui/cocoa: Use NSWindow's ability to resize

2021年6月29日(火) 6:19 BALATON Zoltan : > > On Mon, 28 Jun 2021, Akihiko Odaki wrote: > > 2021年6月28日(月) 17:57 BALATON Zoltan : > >> > >> On Mon, 28 Jun 2021, Akihiko Odaki wrote: > >>> This change brings two new features: > >>> - Th

[PATCH] meson: Use input/output for entitlements target

input/output parameters respect dependencies. Signed-off-by: Akihiko Odaki --- meson.build| 30 +- scripts/entitlement.sh | 10 +- 2 files changed, 22 insertions(+), 18 deletions(-) diff --git a/meson.build b/meson.build index 7e12de01bec

[PATCH] block/file-posix: Use O_RDWR for locking on macOS

qemu_lock_fd_test always returns 0 when fd is not open for writing and exclusive is true on macOS 11.3.1. Signed-off-by: Akihiko Odaki --- block/file-posix.c | 17 + 1 file changed, 17 insertions(+) diff --git a/block/file-posix.c b/block/file-posix.c index b3fbb9bd63a

[PATCH v5 3/3] block/io: Merge discard request alignments

Signed-off-by: Akihiko Odaki --- block/io.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/io.c b/block/io.c index 323854d0633..db19ae2bd9c 100644 --- a/block/io.c +++ b/block/io.c @@ -125,6 +125,8 @@ void bdrv_parent_drained_begin_single(BdrvChild *c, bool poll) static void

[PATCH v5 2/3] block: Add backend_defaults property

utilize backend information more aggressively. By default, it is auto, which uses backend information for block sizes and ignores the others, which is consistent with the older versions. Signed-off-by: Akihiko Odaki --- hw/block/block.c | 42

[PATCH v5 1/3] block/file-posix: Optimize for macOS

Signed-off-by: Akihiko Odaki --- block/file-posix.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/block/file-posix.c b/block/file-posix.c index b3fbb9bd63a..80da1f59a60 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -44,6 +44,7 @@ #if defined

Re: [PATCH 3/4] ui/icons: Use bundle mechanism

oes for pc-bios, but I can improve it for icons and pc-bios by moving the responsibility to meson if it makes sense. Regards, Akihiko Odaki On Fri, Jul 9, 2021 at 3:52 AM Programmingkid wrote: > > > > On Jul 8, 2021, at 1:25 PM, Akihiko Odaki wrote: > > >

Re: Picture missing in About dialog on cocoa ui

PATCH 1/4] cutils: Introduce bundle mechanism" for a general fix of the problem when loading a "bundled" file. Regards, Akihiko Odaki On Fri, Jul 9, 2021 at 2:51 AM Peter Maydell wrote: > > On Thu, 8 Jul 2021 at 17:28, Programmingk

Re: Picture missing in About dialog on cocoa ui

On Sat, Jul 10, 2021 at 11:43 AM Programmingkid wrote: > > > > > On Jul 8, 2021, at 8:15 PM, Akihiko Odaki wrote: > > > > I tried [NSApp applicationIconImage] but had no luck. I suspect it is > > because Rez is for Carbon development and deprecated while NSApp

Re: [PATCH v6 3/7] qemu-nbd: Use qcrypto_tls_creds_check_endpoint()

I tested only with qemu-nbd. Other files were compiled successfully but I have not tested them. On Tue, Jun 29, 2021 at 4:01 PM Philippe Mathieu-Daudé wrote: > > On 6/29/21 4:52 AM, Akihiko Odaki wrote: > > Tested-by: Akihiko Odaki > > Thanks! Does this apply to this single pa

[PATCH v3] ui/cocoa: Use NSWindow's ability to resize

This change brings two new features: - The window will be resizable if "Zoom To Fit" is eanbled - The window can be made full screen by clicking full screen button provided by the platform. (The left-top green button.) Signed-off-by: Akihiko Odaki --- ui/coc

Re: [PATCH v5 0/6] crypto: Make QCryptoTLSCreds* structures private

Hi, qemu-nbd.c still refers to members of QCryptoTLSCreds* and can't be compiled. Regards, Akihiko Odaki On 2021/06/17 21:18, Philippe Mathieu-Daudé wrote: Missing review: 5 & 6 Follow Daniel suggestion to simplify qcrypto TLS implementations, aiming to solve the OSX build failure. S

[PATCH] ui/cocoa: Use NSWindow's ability to resize

This change brings two new features: - The window will be resizable if "Zoom To Fit" is eanbled - The window can be made full screen by clicking full screen button provided by the platform. (The left-top green button.) Signed-off-by: Akihiko Odaki --- ui/coc

[PATCH v2] ui/cocoa: Use NSWindow's ability to resize

This change brings two new features: - The window will be resizable if "Zoom To Fit" is eanbled - The window can be made full screen by clicking full screen button provided by the platform. (The left-top green button.) Signed-off-by: Akihiko Odaki --- ui/coc

[v5 2/3] block: Add backend_defaults property

utilize backend information more aggressively. By default, it is auto, which uses backend information for block sizes and ignores the others, which is consistent with the older versions. Signed-off-by: Akihiko Odaki --- hw/block/block.c | 42

[v5 1/3] block/file-posix: Optimize for macOS

Signed-off-by: Akihiko Odaki --- block/file-posix.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/block/file-posix.c b/block/file-posix.c index 05079b40cae..89e8ed9f801 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -44,6 +44,7 @@ #if defined

[v4 3/3] block/io: Merge discard request alignments

Signed-off-by: Akihiko Odaki --- block/io.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/io.c b/block/io.c index ca2dca30070..aad74bd6714 100644 --- a/block/io.c +++ b/block/io.c @@ -124,6 +124,8 @@ void bdrv_parent_drained_begin_single(BdrvChild *c, bool poll) static void

[v4 2/3] block: Add backend_defaults property

utilize backend information more aggressively. By default, it is auto, which uses backend information for block sizes and ignores the others, which is consistent with the older versions. Signed-off-by: Akihiko Odaki --- hw/block/block.c | 42

[v4 1/3] block/file-posix: Optimize for macOS

Signed-off-by: Akihiko Odaki --- block/file-posix.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/block/file-posix.c b/block/file-posix.c index 05079b40cae..8f25e194fcd 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -44,6 +44,7 @@ #if defined

[v5 3/3] block/io: Merge discard request alignments

Signed-off-by: Akihiko Odaki --- block/io.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/io.c b/block/io.c index ca2dca30070..aad74bd6714 100644 --- a/block/io.c +++ b/block/io.c @@ -124,6 +124,8 @@ void bdrv_parent_drained_begin_single(BdrvChild *c, bool poll) static void

[PATCH v2] ui/cocoa: Comment about modifier key input quirks

Based-on: <20210310042348.21931-1-akihiko.od...@gmail.com> Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 38 +- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 035f96aab04..35fdc92a51f 100644 --- a/ui/cocoa.m

[PATCH v2] ui/cocoa: Comment about modifier key input quirks

Based-on: <20210310042348.21931-1-akihiko.od...@gmail.com> Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 32 +++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 035f96aab04..3d292269c11 100644 --- a/ui/cocoa.m ++

[PATCH v2 2/3] coreaudio: Extract device operations

This change prepare to support dynamic device changes, which requires to perform device initialization/deinitialization multiple times. Signed-off-by: Akihiko Odaki --- audio/coreaudio.c | 137 +++--- 1 file changed, 80 insertions(+), 57 deletions

[PATCH v2 1/3] coreaudio: Drop support for macOS older than 10.6

Mac OS X 10.6 was released in 2009. Signed-off-by: Akihiko Odaki --- audio/coreaudio.c | 103 -- 1 file changed, 103 deletions(-) diff --git a/audio/coreaudio.c b/audio/coreaudio.c index b7c02e0e516..c5f0b615d64 100644 --- a/audio/coreaudio.c +++ b

Re: [PATCH v4] configure: Improve OpenGL dependency detections

2021年3月11日(木) 21:44 Gerd Hoffmann : > > On Tue, Feb 23, 2021 at 03:03:07PM +0900, Akihiko Odaki wrote: > > This has the following visible changes: > > > > - GBM is required only for OpenGL dma-buf. > > - X11 is explicitly required by gtk-egl. > > - EGL is n

[PATCH] ui/cocoa: Comment about modifier key input quirks

Based-on: <20210310042348.21931-1-akihiko.od...@gmail.com> Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 32 +++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 035f96aab04..b0649c0c50a 100644 --- a/ui/cocoa.m ++

[PATCH v2 3/3] coreaudio: Handle output device change

An output device change can occur when plugging or unplugging an earphone. Signed-off-by: Akihiko Odaki --- audio/coreaudio.c | 206 -- 1 file changed, 164 insertions(+), 42 deletions(-) diff --git a/audio/coreaudio.c b/audio/coreaudio.c index

Re: [PATCH] edid: add support for DisplayID extension (5k resolution)

edid_checksum(dta); > +edid_checksum(dta, 127); > } > +if (did) { > +edid_checksum(did, 127); > +} > + > } This function didn't have an empty line at its end. Please remove it. Regards, Akihiko Odaki

Re: [PATCH] ui/cocoa: Do not raise keys before QEMU resigns active

2021年3月14日(日) 21:55 BALATON Zoltan : > > On Sun, 14 Mar 2021, Akihiko Odaki wrote: > > ui/cocoa used to raise all keys before it resigns active to prevent a > > stuck key problem caused by key up events it does not see while it is > > inactive. The problem is solv

Re: [PATCH v2] edid: add support for DisplayID extension (5k resolution)

t; +} > + } > + > /* === finish up === */ > > edid_fill_modes(edid, xtra3, dta, info->maxx, info->maxy); > -edid_checksum(edid); > +edid_checksum(edid, 127); > if (dta) { > -edid_checksum(dta); > +edid_checksum(dta, 127); > +} > +if (did) { > +edid_checksum(did, 127); > } > } > > diff --git a/hw/display/vga-pci.c b/hw/display/vga-pci.c > index 48d29630ab7..62fb5c38c1f 100644 > --- a/hw/display/vga-pci.c > +++ b/hw/display/vga-pci.c > @@ -49,7 +49,7 @@ struct PCIVGAState { > qemu_edid_info edid_info; > MemoryRegion mmio; > MemoryRegion mrs[4]; > -uint8_t edid[256]; > +uint8_t edid[384]; > }; > > #define TYPE_PCI_VGA "pci-vga" > diff --git a/qemu-edid.c b/qemu-edid.c > index 1cd6a951723..028f2d181a1 100644 > --- a/qemu-edid.c > +++ b/qemu-edid.c > @@ -41,7 +41,7 @@ static void usage(FILE *out) > int main(int argc, char *argv[]) > { > FILE *outfile = NULL; > -uint8_t blob[256]; > +uint8_t blob[384]; > uint32_t dpi = 100; > int rc; > > -- > 2.24.3 (Apple Git-128) > It looks good to me. Reviewed-by: Akihiko Odaki

Re: [PATCH] ui/cocoa: Do not raise keys before QEMU resigns active

2021年3月15日(月) 16:32 Gerd Hoffmann : > > On Sun, Mar 14, 2021 at 04:01:47PM +0900, Akihiko Odaki wrote: > > ui/cocoa used to raise all keys before it resigns active to prevent a > > stuck key problem caused by key up events it does not see while it is > > inactive. The probl

[PATCH] net/macos: implement vmnet-based netdev

t this patch requires macOS 10.15 as a minimum, as this is when bridging support was implemented in vmnet.framework. Rebased to commit 3f8d1885e48e4d72eab0688f604de62e0aea7a38 by Akihiko Odaki. Signed-off-by: Phillip Tennen Signed-off-by: Akihiko Odaki --- meson.build | 3 + net/client

[PATCH 2/2] ui/cocoa: Do not rely on the first argument

The first argument of the executable was used to get its path, but it is not reliable because the executer can specify any arbitrary string. Use the interfaces provided by QEMU and the platform to get those paths. Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 29 +++-- 1

Re: [PATCH v2] block/file-posix: Optimize for macOS

2021年3月9日(火) 19:26 Daniel P. Berrangé : > > On Tue, Mar 09, 2021 at 10:37:18AM +0100, Kevin Wolf wrote: > > Am 09.03.2021 um 05:52 hat Akihiko Odaki geschrieben: > > > 2021年3月9日(火) 0:37 Akihiko Odaki : > > > > > > > > 2021年3月9日(火) 0:17 Stefan Hajn

[PATCH 1/2] ui/cocoa: Show QEMU icon in the about window

Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 0ef5fdf3b7a..d8eacea6d22 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -39,6 +39,7 @@ #include "qapi/qapi-commands-misc.h" #inclu

[PATCH v3] ui/cocoa: Clear modifiers whenever possible

to Konstantin Nazarov for testing and finding a bug in this change: https://gist.github.com/akihikodaki/87df4149e7ca87f18dc56807ec5a1bc5#gistcomment-3659419 Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 148 +++-- 1 file changed, 76 insertions(+), 72

[PATCH v3 1/2] block/file-posix: Optimize for macOS

rity and 0 to other members for the default values. Thanks to Konstantin Nazarov for detailed analysis of a flaw in an old version of this change: https://gist.github.com/akihikodaki/87df4149e7ca87f18dc56807ec5a1bc5#gistcomment-3654667 Signed-off-by: Akihiko Odaki --- block/file-posix

[PATCH v3 2/2] block: Add backend_defaults property

a physical device backend. Signed-off-by: Akihiko Odaki --- block/file-posix.c | 2 ++ block/nvme.c | 1 + hw/block/block.c | 27 ++- include/block/block.h| 1 + include/hw/block/block.h | 3 +++ 5 files changed, 29 insertions(+), 5 deletions

Re: [PATCH 2/2] ui/cocoa: Do not rely on the first argument

> Having a fallback would still be nice, even if it is just the fixed > string "qemu". Starting a fresh build without installing it first is > common while developing. > > take care, > Gerd > It shows "QEMU emulator version %s" just below. Also, it can show the name even in a build tree without installing so it should be ok. Regards, Akihiko Odaki

Re: [PATCH v2 2/2] virtio-gpu: Respect UI refresh rate for EDID

y, I'd also like to hear opinions from Xen developers. > > Otherwise looks good to me overall. Splitting the ui/gtk update to a > separate patch is probably a good idea. > I'll do so when submitting the next version. Regards, Akihiko Odaki

[PATCH] ui/cocoa: Do not raise keys before QEMU resigns active

the case that key *down* events are missed while it is inactive. Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 20 1 file changed, 20 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index a7848ae0a30..ac8989947f5 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -326,7 +326,6

[PATCH v2] net/macos: implement vmnet-based netdev

t this patch requires macOS 10.15 as a minimum, as this is when bridging support was implemented in vmnet.framework. Rebased to commit 571d413b5da6bc6f1c2aaca8484717642255ddb0 by Akihiko Odaki. Signed-off-by: Phillip Tennen Signed-off-by: Akihiko Odaki --- meson.build | 3 + net/client

Re: [PATCH 2/2] ui/cocoa: Do not rely on the first argument

2021年3月9日(火) 22:10 BALATON Zoltan : > > On Tue, 9 Mar 2021, Akihiko Odaki wrote: > > The first argument of the executable was used to get its path, but it is > > not reliable because the executer can specify any arbitrary string. Use the > > interfaces provided by QEMU

[PATCH v2] ui/cocoa: Clear modifiers whenever possible

://gist.github.com/akihikodaki/87df4149e7ca87f18dc56807ec5a1bc5#gistcomment-3659419 Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 148 + 1 file changed, 92 insertions(+), 56 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index f27beb30e6e

Re: [PATCH] hvf: Sign the code after installation

2021年2月25日(木) 22:48 Paolo Bonzini : > > On 25/02/21 01:06, Akihiko Odaki wrote: > > Before this change, the code signed during the build was installed > > directly. > > > > However, the signature gets invalidated because meson modifies the code > > to fix

Re: [PATCH] virtio-gpu: Respect graphics update interval for EDID

w size change has. I don't think it is problematic because it should be rare to move the window across physical displays, but I can implement one if you don't agree or know other cases the refresh rate frequently changes. Regards, Akihiko Odaki

Re: [PATCH 2/2] coreaudio: Handle output device change

; Now "playback" type logs are recorded by both of coreaudio_init_out and handle_voice_change. handle_voice_change is a function required only for device change. Regards, Akihiko Odaki

[PATCH v2 1/2] edid: Make refresh rate configurable

Signed-off-by: Akihiko Odaki --- hw/display/edid-generate.c | 9 + include/hw/display/edid.h | 12 +++- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/hw/display/edid-generate.c b/hw/display/edid-generate.c index 1665b7cbb29..b0ce583d436 100644 --- a/hw/display

[PATCH v2 2/2] virtio-gpu: Respect UI refresh rate for EDID

nts frequent changes of the display mode. Signed-off-by: Akihiko Odaki --- hw/display/virtio-gpu-base.c | 1 + hw/display/virtio-gpu.c| 1 + hw/display/xenfb.c | 14 --- include/hw/virtio/virtio-gpu.h | 1 + include/ui/console.h | 2 +- include/ui/gtk.h

Re: [PATCH] ui/gtk: fix NULL pointer dereference

2021年3月8日(月) 4:57 Christian Schoenebeck : > > DisplaySurface pointer passed to gd_switch() can be NULL, so check this > before trying to dereference it. > > Fixes: c821a58ee7 ("ui/console: Pass placeholder surface to display") > Reported-by: Coverity (CID 1448421) > Signed-off-by: Christian

Re: [PATCH] ui/gtk: fix NULL pointer dereference

rity defects report. I'd appreciate the details if you provide one. I suspect I made a mistake somewhere else ui/gtk.c in c821a58ee7 ("ui/console: Pass placeholder surface to display"). Thanks, Akihiko Odaki

Re: [PATCH] ui/gtk: fix NULL pointer dereference

ch intended nonnull designs, as it immediately emits > compiler errors. > > Best regards, > Christian Schoenebeck > > GCC has nonnull attribute and clang accepts it too. However, it specifies argument indices, which is harder to understand and to maintain. __attribute__((nonnull(2))) void f(void *k, void *l); Regards, Akihiko Odaki

Re: [PATCH] ui/gtk: fix NULL pointer dereference

ed to be removed > (2) or surface can be NULL, and we should check here too > > Coverity can't tell us which of the two possibilities is right, of course. > > thanks > -- PMM c821a58ee7 ("ui/console: Pass placeholder surface to display") intended to eliminate the possibility that surface is NULL, so (1) is the case. I am preparing a patch to remove NULL checks. Thanks, Akihiko Odaki

Re: [PATCH] ui/gtk: fix NULL pointer dereference

t; > Redundancy is one reason. It is also intended to prevent people writing ui/console code from assuming displays accept NULL as surface. In reality, some other displays dereferenced surfaces without checking NULL even before this change. The code checking if the surface is NULL is confusing when reading the source code. In runtime, pointer dereferences following the conditional should assert the pointer is not NULL and prevent code which produces NULL from getting in. Regards, Akihiko Odaki

[PATCH] ui/gtk: Remove NULL checks in gd_switch

for humans. This change removes those NULL checks. Reported-by: Coverity (CID 1448421) Signed-off-by: Akihiko Odaki --- ui/gtk.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 3edaf041def..eb1c9658e24 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -54

Re: [PATCH v2] block/file-posix: Optimize for macOS

implementing bdrv_probe_blocksizes. As far as I know, the values they report are already used by default, which is contrary to the default not being "host". Regards, Akihiko Odaki

Re: [PATCH] ui/gtk: fix NULL pointer dereference

blindly added to functions that already exist. We may also be able to enable -fisolate-erroneous-paths-attribute, which turns code paths with NULL pointer passing to such functions into traps, if we explicitly state that it has runtime effects. Regards, Akihiko Odaki

Re: [PATCH v2] block/file-posix: Optimize for macOS

2021年3月9日(火) 0:37 Akihiko Odaki : > > 2021年3月9日(火) 0:17 Stefan Hajnoczi : > > > > The live migration compatibility issue is still present. Migrating to > > another host might not work if the block limits are different. > > > > Here is an idea for solving

[PATCH 2/2] coreaudio: Handle output device change

An output device change can occur when plugging or unplugging an earphone. Signed-off-by: Akihiko Odaki --- audio/coreaudio.c | 327 +- 1 file changed, 236 insertions(+), 91 deletions(-) diff --git a/audio/coreaudio.c b/audio/coreaudio.c index

[PATCH 1/2] coreaudio: Drop support for macOS older than 10.6

Mac OS X 10.6 was released in 2009. Signed-off-by: Akihiko Odaki --- audio/coreaudio.c | 103 -- 1 file changed, 103 deletions(-) diff --git a/audio/coreaudio.c b/audio/coreaudio.c index b7c02e0e516..c5f0b615d64 100644 --- a/audio/coreaudio.c +++ b

Re: [PATCH] virtio-gpu: Respect graphics update interval for EDID

2021年2月24日(水) 20:17 Gerd Hoffmann : > > On Tue, Feb 23, 2021 at 01:50:51PM +0900, Akihiko Odaki wrote: > > 2021年2月22日(月) 19:57 Gerd Hoffmann : > > > > > > On Sun, Feb 21, 2021 at 10:34:14PM +0900, Akihiko Odaki wrote: > > > > This change int

[PATCH] hvf: Sign the code after installation

as an executable (although it is somehow able to perform the modification described above). With this change, the unsigned code will be installed and modified by meson first, and a script signs it later. Signed-off-by: Akihiko Odaki --- meson.build | 11

[PATCH v4] virtio-blk: Respect discard granularity

types to avoid migration issues. Signed-off-by: Akihiko Odaki --- hw/block/virtio-blk.c | 8 +++- hw/core/machine.c | 4 +++- include/hw/virtio/virtio-blk.h | 1 + 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c

[PATCH v3 2/3] ui/console: Pass placeholder surface to displays

wn to each display listeners. sdl destroys the window for a secondary console if its surface is a placeholder. The other displays simply shows the placeholder. Signed-off-by: Akihiko Odaki --- ui/console.c | 45 +++-- ui/gtk.c | 4 ui

[PATCH v3 1/3] ui/console: Add placeholder flag to message surface

to qemu_create_placeholder_surface, and adds "placeholder" flag; the display can check the flag to decide to do anything special like hiding the window. Signed-off-by: Akihiko Odaki --- hw/display/vhost-user-gpu.c | 4 ++-- hw/display/virtio-gpu.c | 6 +++--- include/ui/console.h| 10 -- ui

Re: [PATCH] block/file-posix: Optimize for macOS

2021年2月25日(木) 2:31 Kevin Wolf : > > Am 24.02.2021 um 17:27 hat Stefan Hajnoczi geschrieben: > > On Fri, Feb 19, 2021 at 05:51:48PM +0900, Akihiko Odaki wrote: > > > This commit introduces "punch hole" operation and optimizes transfer > > > block size for m

[PATCH v3 3/3] virtio-gpu: Do not distinguish the primary console

In the past, virtio-gpu set NULL as the surface for the secondary consoles to hide its window. The distinction is now handled in ui/console and the display backends and virtio-gpu does no longer have to do that. Signed-off-by: Akihiko Odaki --- hw/display/vhost-user-gpu.c | 2 +- hw/display

  1   2   3   4   5   6   7   8   9   10   >