[Qemu-devel] [RFC qom-cpu 17/41] cpu: Move tlb_flush_{addr, mask} fields from CPU_COMMON_TLB to CPUState

2013-09-04 Thread Andreas Färber
Change their type to vaddr but keep comparing target_ulongs for now. Signed-off-by: Andreas Färber afaer...@suse.de --- cputlb.c| 27 ++- include/exec/cpu-defs.h | 2 -- include/qom/cpu.h | 3 +++ 3 files changed, 17 insertions(+), 15 deletions

[Qemu-devel] [RFC qom-cpu 19/41] cpu-exec: Change cpu_loop_exit() argument to CPUState

2013-09-04 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de --- cpu-exec.c| 14 ++ exec.c| 2 +- include/exec/exec-all.h | 2 +- target-alpha/helper.c | 4 ++-- target-alpha/mem_helper.c | 4 ++-- target-arm/op_helper.c| 6

[Qemu-devel] [RFC qom-cpu 22/41] translate-all: Change tb_check_watchpoint() argument to CPUState

2013-09-04 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de --- exec.c | 2 +- translate-all.c | 4 ++-- translate-all.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/exec.c b/exec.c index 06fb881..0a81967 100644 --- a/exec.c +++ b/exec.c @@ -1480,7 +1480,7 @@ static void

[Qemu-devel] [RFC qom-cpu 21/41] translate-all: Change cpu_restore_state_from_tb() argument to CPUState

2013-09-04 Thread Andreas Färber
And normalize the argument order. Signed-off-by: Andreas Färber afaer...@suse.de --- translate-all.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/translate-all.c b/translate-all.c index 5673420..0dd6a60 100644 --- a/translate-all.c +++ b/translate-all.c

[Qemu-devel] [RFC qom-cpu 18/41] exec: Change tlb_fill() argument to CPUState

2013-09-04 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de --- include/exec/exec-all.h | 2 +- include/exec/softmmu_template.h | 4 ++-- target-alpha/mem_helper.c | 8 +--- target-arm/op_helper.c | 12 +++- target-cris/op_helper.c | 7 --- target-i386

[Qemu-devel] [RFC qom-cpu 28/41] exec: Change cpu_breakpoint_{insert, remove{, _by_ref, _all}} argument

2013-09-04 Thread Andreas Färber
Use CPUState. Allows to clean up CPUArchState in gdbstub. Signed-off-by: Andreas Färber afaer...@suse.de --- exec.c | 20 gdbstub.c | 20 include/exec/cpu-all.h | 15 --- include/qom/cpu.h | 15

[Qemu-devel] [RFC qom-cpu 26/41] target-ppc: Use PowerPCCPU in PowerPCCPUClass::handle_mmu_fault hook

2013-09-04 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de --- target-ppc/cpu-qom.h| 8 +--- target-ppc/mmu-hash32.c | 5 +++-- target-ppc/mmu-hash32.h | 2 +- target-ppc/mmu-hash64.c | 5 +++-- target-ppc/mmu-hash64.h | 2 +- target-ppc/mmu_helper.c | 2 +- 6 files changed, 14 insertions(+), 10

[Qemu-devel] [RFC qom-cpu 37/41] target-microblaze: Replace DisasContext::env field with MicroBlazeCPU

2013-09-04 Thread Andreas Färber
This cleans up some mb_env_get_cpu() needed for cpu_abort(). Signed-off-by: Andreas Färber afaer...@suse.de --- target-microblaze/translate.c | 84 +-- 1 file changed, 40 insertions(+), 44 deletions(-) diff --git a/target-microblaze/translate.c b/target

[Qemu-devel] [RFC qom-cpu 24/41] translate-all: Change tb_gen_code() argument to CPUState

2013-09-04 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de --- cpu-exec.c | 4 ++-- exec.c | 2 +- hw/i386/kvmvapic.c | 2 +- include/exec/exec-all.h | 2 +- translate-all.c | 9 + 5 files changed, 10 insertions(+), 9 deletions(-) diff --git a/cpu-exec.c b

[Qemu-devel] [RFC qom-cpu 27/41] exec: Change cpu_watchpoint_{insert, remove{, _by_ref, _all}} argument

2013-09-04 Thread Andreas Färber
Use CPUState. This lets us drop a few local env usages. Signed-off-by: Andreas Färber afaer...@suse.de --- exec.c| 34 +- gdbstub.c | 17 + include/exec/cpu-all.h| 6 -- include/qom/cpu.h | 7

[Qemu-devel] [RFC qom-cpu 31/41] exec: Change memory_region_section_get_iotlb() argument to CPUState

2013-09-04 Thread Andreas Färber
It no longer needs CPUArchState since moving watchpoints to CPUState. Signed-off-by: Andreas Färber afaer...@suse.de --- cputlb.c | 3 ++- exec.c| 3 +-- include/exec/cputlb.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/cputlb.c b/cputlb.c

[Qemu-devel] [RFC qom-cpu 33/41] cputlb: Change tlb_set_page() argument to CPUState

2013-09-04 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de --- cputlb.c | 4 ++-- include/exec/exec-all.h| 2 +- target-alpha/helper.c | 2 +- target-arm/helper.c| 2 +- target-cris/helper.c | 2 +- target-i386/helper.c | 2 +- target-lm32/helper.c | 6

[Qemu-devel] [RFC qom-cpu 32/41] cputlb: Change tlb_set_page() argument to CPUState

2013-09-04 Thread Andreas Färber
It no longer needs CPUArchState since moving tlb_flush_* to CPUState. Signed-off-by: Andreas Färber afaer...@suse.de --- cputlb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/cputlb.c b/cputlb.c index e5b6145..ddcd2cd 100644 --- a/cputlb.c +++ b/cputlb.c @@ -212,10

[Qemu-devel] [RFC qom-cpu 41/41] user-exec: Change exception_action() argument to CPUState

2013-09-04 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de --- user-exec.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/user-exec.c b/user-exec.c index 3b795c1..bc58056 100644 --- a/user-exec.c +++ b/user-exec.c @@ -38,11 +38,12 @@ //#define DEBUG_SIGNAL -static void

[Qemu-devel] [RFC qom-cpu 36/41] target-lm32: Replace DisasContext::env field with LM32CPU

2013-09-04 Thread Andreas Färber
This cleans up some lm32_env_get_cpu() introduced for cpu_abort(). Signed-off-by: Andreas Färber afaer...@suse.de --- target-lm32/translate.c | 60 - 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/target-lm32/translate.c b/target

[Qemu-devel] [RFC qom-cpu 38/41] target-lm32: Move features field from CPULM32State to LM32CPU

2013-09-04 Thread Andreas Färber
This simplifies the code after conversion to DisasContext::cpu. Signed-off-by: Andreas Färber afaer...@suse.de --- target-lm32/cpu-qom.h | 3 +++ target-lm32/cpu.h | 2 -- target-lm32/helper.c| 2 +- target-lm32/translate.c | 16 4 files changed, 12 insertions

[Qemu-devel] [RFC qom-cpu 40/41] cputlb: Change tlb_flush() argument to CPUState

2013-09-04 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de --- cputlb.c | 6 +++--- exec.c | 4 +--- hw/sh4/sh7750.c| 2 +- include/exec/exec-all.h| 4 ++-- target-alpha/cpu.c | 2 +- target-alpha

[Qemu-devel] [RFC qom-cpu 39/41] cputlb: Change tlb_flush_page() argument to CPUState

2013-09-04 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de --- cputlb.c | 4 +-- exec.c | 7 ++ include/exec/exec-all.h | 4 +-- target-alpha/sys_helper.c| 2 +- target-arm/helper.c | 8 -- target-cris/mmu.c| 3 ++- target

[Qemu-devel] [RFC qom-cpu 20/41] translate-all: Change cpu_restore_state() argument to CPUState

2013-09-04 Thread Andreas Färber
This lets us drop some local variables in tlb_fill() functions. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/i386/kvmvapic.c| 2 +- include/exec/exec-all.h | 2 +- target-alpha/helper.c | 2 +- target-alpha/mem_helper.c | 7 ++- target-arm

[Qemu-devel] [RFC qom-cpu 25/41] translate-all: Change tb_flush_jmp_cache() argument to CPUState

2013-09-04 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de --- cputlb.c | 2 +- include/exec/cputlb.h | 2 +- translate-all.c | 3 +-- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/cputlb.c b/cputlb.c index e02663c..3721bfc 100644 --- a/cputlb.c +++ b/cputlb.c @@ -120,7

[Qemu-devel] [RFC qom-cpu 29/41] cpu-exec: Change cpu_resume_from_signal() argument to CPUState

2013-09-04 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de --- cpu-exec.c | 4 +--- exec.c | 3 +-- hw/i386/kvmvapic.c | 3 +-- include/exec/exec-all.h | 2 +- target-i386/helper.c| 2 +- target-xtensa/helper.c | 2 +- translate-all.c | 12

[Qemu-devel] [RFC qom-cpu 12/41] cpu: Move cpu_copy() into linux-user

2013-09-04 Thread Andreas Färber
It is only used there and is deemed very fragile if not incorrect in its current memcpy() form. Moving it into linux-user will allow to move parts into target_cpu.h headers and only copy what the ABI mandates. Signed-off-by: Andreas Färber afaer...@suse.de --- exec.c| 32

[Qemu-devel] [RFC qom-cpu 30/41] cputlb: Change tlb_update_dirty() argument to CPUState

2013-09-04 Thread Andreas Färber
This allows to drop env in tb_invalidate_phys_page_range(). Note that the argument is unused. Signed-off-by: Andreas Färber afaer...@suse.de --- cputlb.c | 2 +- include/exec/cputlb.h | 2 +- translate-all.c | 12 ++-- 3 files changed, 4 insertions(+), 12 deletions

[Qemu-devel] [RFC qom-cpu 23/41] translate-all: Change cpu_io_recompile() argument to CPUState

2013-09-04 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de --- include/exec/exec-all.h | 2 +- include/exec/softmmu_template.h | 4 ++-- translate-all.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h index

[Qemu-devel] [RFC qom-cpu 35/41] target-cris: Replace DisasContext::env field with CRISCPU

2013-09-04 Thread Andreas Färber
This cleans up repeated cris_env_get_cpu() for cpu_abort(). Signed-off-by: Andreas Färber afaer...@suse.de --- target-cris/translate.c | 16 target-cris/translate_v10.c | 16 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/target-cris

Re: [Qemu-devel] [RFC qom-cpu 03/41] cpu: Turn cpu_get_tb_cpu_state() into a CPUClass hook

2013-09-04 Thread Andreas Färber
Am 04.09.2013 12:26, schrieb Paolo Bonzini: Il 04/09/2013 11:04, Andreas Färber ha scritto: static inline TranslationBlock *tb_find_fast(CPUArchState *env) { +CPUState *cpu = ENV_GET_CPU(env); +CPUClass *cc = CPU_GET_CLASS(cpu); TranslationBlock *tb; -target_ulong cs_base

Re: [Qemu-devel] [PATCH 0/8] [PATCH RFC v3] s390 cpu hotplug

2013-09-04 Thread Andreas Färber
Hello, Am 01.08.2013 16:12, schrieb Jason J. Herne: From: Jason J. Herne jjhe...@us.ibm.com Latest code for cpu Hotplug on S390 architecture. This one is vastly simpler than v2 as we have decided to avoid the command line specification of -device s390-cpu. The last version can be

Re: [Qemu-devel] [RFC qom-cpu 02/41] cpu: Turn cpu_mmu_index() into a CPUClass hook

2013-09-04 Thread Andreas Färber
Am 04.09.2013 14:42, schrieb Jia Liu: On Wed, Sep 4, 2013 at 5:04 PM, Andreas Färber afaer...@suse.de wrote: Default to 0. Signed-off-by: Andreas Färber afaer...@suse.de Paolo has indicated that patches 2 and 3 shouldn't be applied since they touch on TCG hot paths, replacing an inline

Re: [Qemu-devel] [PATCH 0/8] [PATCH RFC v3] s390 cpu hotplug

2013-09-04 Thread Andreas Färber
Am 04.09.2013 14:56, schrieb Luiz Capitulino: On Wed, 04 Sep 2013 14:45:44 +0200 Andreas Färber afaer...@suse.de wrote: For the HMP patch I am waiting on feedback from Igor once he returns from his vacation and, if there are no objections, would like to see that patch go through Luiz' queue

Re: [Qemu-devel] public key not found?

2013-09-04 Thread Andreas Färber
Am 04.09.2013 15:11, schrieb Anthony Liguori: On Wed, Sep 4, 2013 at 6:47 AM, Michael S. Tsirkin m...@redhat.com wrote: I noticed recent merges of the pci tree have this text: # gpg: Signature made Sun 01 Sep 2013 03:15:36 AM CDT using RSA key # ID D28D5469 # gpg: Can't check

Re: [Qemu-devel] [PATCH 0/8] [PATCH RFC v3] s390 cpu hotplug

2013-09-05 Thread Andreas Färber
Am 05.09.2013 12:40, schrieb Christian Borntraeger: On 04/09/13 14:45, Andreas Färber wrote: Hello, Am 01.08.2013 16:12, schrieb Jason J. Herne: From: Jason J. Herne jjhe...@us.ibm.com Latest code for cpu Hotplug on S390 architecture. This one is vastly simpler than v2 as we have

Re: [Qemu-devel] [PATCH 1/8] [PATCH RFC v3] s390-qemu: cpu hotplug - Define New SCLP Codes

2013-09-05 Thread Andreas Färber
Am 01.08.2013 16:12, schrieb Jason J. Herne: From: Jason J. Herne jjhe...@us.ibm.com Define new SCLP codes to improve code readability. Signed-off-by: Jason J. Herne jjhe...@us.ibm.com s390-qemu: is really bad. For one, all QEMU patches are somehow about QEMU, so that's redundant. For

Re: [Qemu-devel] [PATCH 2/8] [PATCH RFC v3] s390-qemu: cpu hotplug - SCLP CPU Info

2013-09-05 Thread Andreas Färber
Am 01.08.2013 16:12, schrieb Jason J. Herne: From: Jason J. Herne jjhe...@us.ibm.com Implement the CPU data in SCLP Read SCP Info. And implement Read CPU Info SCLP command. This data will be used by the guest to get information about hot plugged cpus. Signed-off-by: Jason J. Herne

Re: [Qemu-devel] [PATCH 3/8] [PATCH RFC v3] s390-qemu: cpu hotplug - SCLP Event integration

2013-09-05 Thread Andreas Färber
Am 01.08.2013 16:12, schrieb Jason J. Herne: From: Jason J. Herne jjhe...@us.ibm.com Add an sclp event for cpu was hot plugged. This allows Qemu to deliver an SCLP interrupt to the guest stating that the requested cpu hotplug was completed. Signed-off-by: Jason J. Herne

Re: [Qemu-devel] [PATCH 4/8] [PATCH RFC v3] s390-qemu: cpu hotplug - Storage key global access

2013-09-05 Thread Andreas Färber
Am 01.08.2013 16:12, schrieb Jason J. Herne: From: Jason J. Herne jjhe...@us.ibm.com Introduces global access to storage key data so we can set it for each cpu in the S390 cpu initialization routine. Signed-off-by: Jason J. Herne jjhe...@us.ibm.com --- hw/s390x/s390-virtio-ccw.c |5

Re: [Qemu-devel] [PATCH 5/8] [PATCH RFC v3] s390-qemu: cpu hotplug - ipi_states enhancements

2013-09-05 Thread Andreas Färber
Am 01.08.2013 16:12, schrieb Jason J. Herne: From: Jason J. Herne jjhe...@us.ibm.com Modify s390_cpu_addr2state to allow fetching state information for cpu addresses above smp_cpus. Hotplug requires this capability. Also add s390_cpu_set_state function to allow modification of ipi_state

Re: [Qemu-devel] [PATCH 6/8] [PATCH RFC v3] s390-qemu: cpu hotplug - s390 cpu init improvements for hotplug

2013-09-05 Thread Andreas Färber
Am 01.08.2013 16:12, schrieb Jason J. Herne: From: Jason J. Herne jjhe...@us.ibm.com s390_new_cpu is created to encapsulate the creation of a new QOM S390CPU object given a cpuid and a model string. All actual cpu initialization code is moved from boot time specific functions

Re: [Qemu-devel] [PATCH 7/8] [PATCH RFC v3] s390-qemu: cpu hotplug - Implement hot_add_cpu hook

2013-09-05 Thread Andreas Färber
Am 01.08.2013 16:12, schrieb Jason J. Herne: From: Jason J. Herne jjhe...@us.ibm.com Implement hot_add_cpu for S390 to allow hot plugging of cpus. Signed-off-by: Jason J. Herne jjhe...@us.ibm.com --- hw/s390x/s390-virtio-ccw.c |3 +++ target-s390x/cpu.c | 32

Re: [Qemu-devel] [PATCH 0/8] [PATCH RFC v3] s390 cpu hotplug

2013-09-05 Thread Andreas Färber
Am 05.09.2013 14:54, schrieb Alexander Graf: On 01.08.2013, at 16:12, Jason J. Herne wrote: From: Jason J. Herne jjhe...@us.ibm.com Latest code for cpu Hotplug on S390 architecture. This one is vastly simpler than v2 as we have decided to avoid the command line specification of

Re: [Qemu-devel] [PATCH v6] powerpc: add PVR mask support

2013-09-05 Thread Andreas Färber
. Also, new CPU versions of already supported CPU won't break the existing code. This adds PVR value/mask support for KVM, i.e. for -cpu host option. As CPU family class name for POWER7 is POWER7-family, there is no need to touch aliases. Cc: Andreas Färber afaer...@suse.de Signed-off

Re: [Qemu-devel] [PATCH 0/8] [PATCH RFC v3] s390 cpu hotplug

2013-09-05 Thread Andreas Färber
Am 05.09.2013 15:10, schrieb Alexander Graf: On 05.09.2013, at 15:05, Andreas Färber wrote: Am 05.09.2013 14:54, schrieb Alexander Graf: Very simple and clean patch set. I don't think it deserves the RFC tag. Negative, see my review. If you want to fix up and queue patches 1-2 that's fine

Re: [Qemu-devel] [RFC PATCH] spapr: support time base offset migration

2013-09-05 Thread Andreas Färber
Am 05.09.2013 15:39, schrieb Alexander Graf: On 05.09.2013, at 15:36, Benjamin Herrenschmidt wrote: On Thu, 2013-09-05 at 14:37 +0200, Alexander Graf wrote: Hrm, I think I'm starting to understand what this is about. So what we want is - timebase in guest - timebase frequency in

Re: [Qemu-devel] [PATCH] Change email address

2013-09-05 Thread Andreas Färber
Am 05.09.2013 14:30, schrieb Peter Maydell: On 19 August 2013 14:51, Anthony Liguori anth...@codemonkey.ws wrote: My IBM email address will be unaccessible after August 23rd, 2013. Signed-off-by: Anthony Liguori anth...@codemonkey.ws --- a/.mailmap +++ b/.mailmap @@ -2,7 +2,7 @@ # into

Re: [Qemu-devel] [PATCH] target-arm: Implement qmp query-cpu-definitions

2013-09-05 Thread Andreas Färber
. The latter two parts don't work with the old qdev and SysBusDevice APIs. That said, patch itself looks correct, Reviewed-by: Andreas Färber afaer...@suse.de Regards, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer

Re: [Qemu-devel] [RFC v4 1/5] hw/arm: add very initial support for Canon DIGIC SoC

2013-09-05 Thread Andreas Färber
Am 05.09.2013 09:52, schrieb Antony Pavlov: DIGIC is Canon Inc.'s name for a family of SoC for digital cameras and camcorders. There is no publicly available specification for DIGIC chips. All information about DIGIC chip internals is based on reverse engineering efforts made by CHDK

Re: [Qemu-devel] [PATCH] pl110: Clarify comment about PL110 ID on VersatilePB

2013-09-05 Thread Andreas Färber
Am 05.09.2013 18:43, schrieb Peter Maydell: Clarify a comment about the ID register value presented by the PL110 variant present on the VersatilePB board (based on testing what the actual hardware does), to indicate that this is not an error in our emulation, and to remove an #if-0.

Re: [Qemu-devel] [RFC v4 1/5] hw/arm: add very initial support for Canon DIGIC SoC

2013-09-05 Thread Andreas Färber
Am 05.09.2013 23:23, schrieb Antony Pavlov: On Thu, 05 Sep 2013 20:08:34 +0200 Andreas Färber afaer...@suse.de wrote: Am 05.09.2013 09:52, schrieb Antony Pavlov: diff --git a/hw/arm/digic.c b/hw/arm/digic.c new file mode 100644 index 000..95a9fcd --- /dev/null +++ b/hw/arm/digic.c

Re: [Qemu-devel] [RFC qom-cpu v2 2/8] x86: add x86_cpu_unrealizefn() for cpu apic remove

2013-09-10 Thread Andreas Färber
Am 10.09.2013 11:43, schrieb Chen Fan: Implement x86_cpu_unrealizefn() for corresponding x86_cpu_realizefn(), which is mostly used to clear the apic related information at here. Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com --- hw/cpu/icc_bus.c| 11 +++

Re: [Qemu-devel] [RFC qom-cpu v2 1/8] apic: remove apic_no from apic_init_common()

2013-09-10 Thread Andreas Färber
Am 10.09.2013 14:09, schrieb Igor Mammedov: On Tue, 10 Sep 2013 17:43:41 +0800 Chen Fan chen.fan.f...@cn.fujitsu.com wrote: the 'apic_no' is increased by one when initialize/create a vCPU each time, which causes APICCommonState s-idx always is increased. but if we want to re-add a vCPU

Re: [Qemu-devel] [PATCH 2/6] qdev: unref qdev when device_add fails

2013-09-10 Thread Andreas Färber
Am 10.09.2013 18:49, schrieb Paolo Bonzini: Il 10/09/2013 18:21, Stefan Hajnoczi ha scritto: qdev_device_add() leaks the created qdev upon failure. I suspect this problem crept in because qdev_free() unparents the qdev but does not drop a reference - confusing name. Right, the name a

Re: [Qemu-devel] [PATCH] qdev: rename qdev_free() to qdev_unparent()

2013-09-11 Thread Andreas Färber
Am 11.09.2013 09:45, schrieb Stefan Hajnoczi: The qdev_free() function name is misleading since all the function does is unlink the device from its parent. The device is not necessarily freed. The device will be freed when its QObject refcount reaches zero. It is usual for the parent

Re: [Qemu-devel] [PATCH] target-i386: set model=6 on qemu64 qemu32 CPU models

2013-09-11 Thread Andreas Färber
Am 11.09.2013 10:22, schrieb Igor Mammedov: On Tue, 10 Sep 2013 17:48:59 -0300 Eduardo Habkost ehabk...@redhat.com wrote: There's no Intel CPU with family=6,model=2, and Linux and Windows guests disable SEP when seeing that combination due to Pentium Pro erratum #82. In addition to just

Re: [Qemu-devel] [RFC 0/4] ARM aarch64 disas output libvixl support

2013-09-11 Thread Andreas Färber
Hi Claudio, Am 11.09.2013 14:54, schrieb Claudio Fontana: This is the aarch64 libvixl support patchset in the current state. It provides (limited) support for disassembly output on aarch64. Only host disassembly is enabled, since target for aarch64 is not in yet. An external objdump

[Qemu-devel] [PATCH v4 17/24] arm11mpcore: Create container MemoryRegion in instance_init

2013-09-11 Thread Andreas Färber
This allows to map the region directly after object initialization. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/cpu/arm11mpcore.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/hw/cpu/arm11mpcore.c b/hw/cpu/arm11mpcore.c index 8719634..5f80e7b

[Qemu-devel] [PATCH v4 04/24] a9scu: QOM cleanups

2013-09-11 Thread Andreas Färber
From: Andreas Färber andreas.faer...@web.de Rename A9SCUState::busdev field to parent_obj and turn realizefn into an instance_init function to allow early MMIO mapping. Reviewed-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Andreas Färber andreas.faer...@web.de --- hw/misc

[Qemu-devel] [PATCH v4 00/24] arm: ARM11MPCore+A9MPCore+A15MPCore QOM'ification

2013-09-11 Thread Andreas Färber
From: Andreas Färber andreas.faer...@web.de Hello Peter, This series fully QOM'ifies A9MPCore so that it can be embedded for Tegra2. It goes on to do the same for A15MPCore, which had previously been taken as template for Cortex-A57 by John Rigby, and since v3 ARM11MPCore. Separate headers

[Qemu-devel] [PATCH v4 15/24] arm11mpcore: Fix typo in MemoryRegion name

2013-09-11 Thread Andreas Färber
mpcode - mpcore Signed-off-by: Andreas Färber afaer...@suse.de --- hw/cpu/arm11mpcore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/cpu/arm11mpcore.c b/hw/cpu/arm11mpcore.c index a786c62..27cd32b 100644 --- a/hw/cpu/arm11mpcore.c +++ b/hw/cpu/arm11mpcore.c @@ -93,7

[Qemu-devel] [PATCH v4 13/24] a15mpcore: Prepare for QOM embedding

2013-09-11 Thread Andreas Färber
From: Andreas Färber andreas.faer...@web.de Signed-off-by: Andreas Färber andreas.faer...@web.de --- hw/cpu/a15mpcore.c | 21 + include/hw/cpu/a15mpcore.h | 44 2 files changed, 45 insertions(+), 20 deletions(-) create

[Qemu-devel] [PATCH v4 06/24] arm_mptimer: Convert to QOM realize

2013-09-11 Thread Andreas Färber
From: Andreas Färber andreas.faer...@web.de Split the SysBusDevice initfn into instance_init and realizefn. Signed-off-by: Andreas Färber andreas.faer...@web.de --- hw/timer/arm_mptimer.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/hw/timer

[Qemu-devel] [PATCH v4 07/24] a9mpcore: Embed ARMMPTimerState

2013-09-11 Thread Andreas Färber
From: Andreas Färber andreas.faer...@web.de Prepares for QOM realize. Signed-off-by: Andreas Färber andreas.faer...@web.de --- hw/cpu/a9mpcore.c | 29 ++- hw/timer/arm_mptimer.c | 35 --- include/hw/timer/arm_mptimer.h | 54

[Qemu-devel] [PATCH v4 16/24] arm11mpcore: Drop unused fields

2013-09-11 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de --- hw/cpu/arm11mpcore.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/cpu/arm11mpcore.c b/hw/cpu/arm11mpcore.c index 27cd32b..8719634 100644 --- a/hw/cpu/arm11mpcore.c +++ b/hw/cpu/arm11mpcore.c @@ -20,8 +20,6 @@ typedef struct

[Qemu-devel] [PATCH v4 21/24] realview_gic: Prepare for QOM embedding

2013-09-11 Thread Andreas Färber
Move state struct, type constant and cast macro to a new header. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/intc/realview_gic.c | 15 +-- include/hw/intc/realview_gic.h | 28 2 files changed, 29 insertions(+), 14 deletions(-) create

[Qemu-devel] [PATCH v4 19/24] arm11mpcore: Convert ARM11MPCorePriveState to QOM realize

2013-09-11 Thread Andreas Färber
Embed child devices and replace SysBus initfn with realizefn. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/cpu/arm11mpcore.c | 84 ++-- 1 file changed, 56 insertions(+), 28 deletions(-) diff --git a/hw/cpu/arm11mpcore.c b/hw/cpu

[Qemu-devel] [PATCH v4 23/24] arm11mpcore: Prepare for QOM embedding

2013-09-11 Thread Andreas Färber
Move state struct, type constant and cast macro to a new header. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/cpu/arm11mpcore.c | 27 +-- include/hw/cpu/arm11mpcore.h | 35 +++ 2 files changed, 36 insertions(+), 26

[Qemu-devel] [PATCH v4 20/24] realview_gic: Convert to QOM realize

2013-09-11 Thread Andreas Färber
Embed GICState and replace SysBus initfn with realizefn. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/intc/realview_gic.c | 51 ++ 1 file changed, 35 insertions(+), 16 deletions(-) diff --git a/hw/intc/realview_gic.c b/hw/intc

[Qemu-devel] [PATCH v4 09/24] a9mpcore: Prepare for QOM embedding

2013-09-11 Thread Andreas Färber
From: Andreas Färber andreas.faer...@web.de Signed-off-by: Andreas Färber andreas.faer...@web.de --- hw/cpu/a9mpcore.c | 24 +--- include/hw/cpu/a9mpcore.h | 37 + 2 files changed, 38 insertions(+), 23 deletions(-) create mode

[Qemu-devel] [PATCH v4 22/24] arm11mpcore: Convert mpcore_rirq_state to QOM realize

2013-09-11 Thread Andreas Färber
Embed ARM11MPCorePriveState and RealViewGICState and replace SysBus initfn with realizefn. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/cpu/arm11mpcore.c | 58 +++- 1 file changed, 44 insertions(+), 14 deletions(-) diff --git a/hw/cpu

[Qemu-devel] [PATCH v4 05/24] a9mpcore: Embed A9SCUState

2013-09-11 Thread Andreas Färber
From: Andreas Färber andreas.faer...@web.de Prepares for QOM realize. Signed-off-by: Andreas Färber andreas.faer...@web.de --- hw/cpu/a9mpcore.c | 16 ++-- hw/misc/a9scu.c | 18 +- include/hw/misc/a9scu.h | 31 +++ 3 files

[Qemu-devel] [PATCH v4 24/24] arm11mpcore: Split off RealView MPCore

2013-09-11 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de --- hw/cpu/Makefile.objs | 1 + hw/cpu/arm11mpcore.c | 121 - hw/cpu/realview_mpcore.c | 139 +++ 3 files changed, 140 insertions(+), 121 deletions

[Qemu-devel] [PATCH v4 03/24] a9mpcore: Embed GICState

2013-09-11 Thread Andreas Färber
From: Andreas Färber andreas.faer...@web.de Prepares for conversion to QOM realize. Signed-off-by: Andreas Färber andreas.faer...@web.de --- hw/cpu/a9mpcore.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/hw/cpu/a9mpcore.c b/hw/cpu/a9mpcore.c

[Qemu-devel] [PATCH v4 02/24] arm_gic: Extract headers hw/intc/arm_gic{, _common}.h

2013-09-11 Thread Andreas Färber
Rename NCPU to GIC_NCPU and move GICState away from gic_internal.h. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/intc/arm_gic_common.c | 18 hw/intc/gic_internal.h | 80 +- include/hw/intc/arm_gic.h| 42

[Qemu-devel] [PATCH v4 08/24] a9mpcore: Convert to QOM realize

2013-09-11 Thread Andreas Färber
From: Andreas Färber andreas.faer...@web.de Signed-off-by: Andreas Färber andreas.faer...@web.de --- hw/cpu/a9mpcore.c | 36 ++-- 1 file changed, 26 insertions(+), 10 deletions(-) diff --git a/hw/cpu/a9mpcore.c b/hw/cpu/a9mpcore.c index db3907e..a162ff0 100644

[Qemu-devel] [PATCH v4 14/24] a9scu: Build only once

2013-09-11 Thread Andreas Färber
It does not have a target or ARMCPU dependency. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/misc/Makefile.objs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/Makefile.objs b/hw/misc/Makefile.objs index 2578e29..5636299 100644 --- a/hw/misc/Makefile.objs

[Qemu-devel] [PATCH v4 18/24] arm11mpcore: Split off SCU device

2013-09-11 Thread Andreas Färber
Inspired by a9scu. Signed-off-by: Andreas Färber afaer...@suse.de --- default-configs/arm-softmmu.mak | 1 + hw/cpu/arm11mpcore.c| 65 ++ hw/misc/Makefile.objs | 1 + hw/misc/arm11scu.c | 100

[Qemu-devel] [PATCH v4 12/24] a15mpcore: Convert to QOM realize

2013-09-11 Thread Andreas Färber
From: Andreas Färber andreas.faer...@web.de Turn SysBusDevice initfn into a QOM realizefn. Signed-off-by: Andreas Färber andreas.faer...@web.de --- hw/cpu/a15mpcore.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/hw/cpu/a15mpcore.c b/hw/cpu

[Qemu-devel] [PATCH v4 11/24] a15mpcore: Embed GICState

2013-09-11 Thread Andreas Färber
From: Andreas Färber andreas.faer...@web.de This covers both emulated and KVM GIC. Prepares for QOM realize. Signed-off-by: Andreas Färber andreas.faer...@web.de --- hw/cpu/a15mpcore.c | 39 --- 1 file changed, 24 insertions(+), 15 deletions(-) diff --git

[Qemu-devel] [PATCH v4 01/24] a9mpcore: Split off instance_init

2013-09-11 Thread Andreas Färber
From: Andreas Färber andreas.faer...@web.de Prepares for QOM realize. Signed-off-by: Andreas Färber andreas.faer...@web.de --- hw/cpu/a9mpcore.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/hw/cpu/a9mpcore.c b/hw/cpu/a9mpcore.c index 3e675e3..acbdab5 100644

[Qemu-devel] [PATCH v4 10/24] a15mpcore: Split off instance_init

2013-09-11 Thread Andreas Färber
From: Andreas Färber andreas.faer...@web.de Prepares for QOM realize. Signed-off-by: Andreas Färber andreas.faer...@web.de --- hw/cpu/a15mpcore.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/hw/cpu/a15mpcore.c b/hw/cpu/a15mpcore.c index 9abba67..af29c35

Re: [Qemu-devel] [PATCH] target-i386: set model=6 on qemu64 qemu32 CPU models

2013-09-11 Thread Andreas Färber
Am 11.09.2013 10:37, schrieb Igor Mammedov: On Wed, 11 Sep 2013 10:25:58 +0200 Andreas Färber afaer...@suse.de wrote: Am 11.09.2013 10:22, schrieb Igor Mammedov: On Tue, 10 Sep 2013 17:48:59 -0300 Eduardo Habkost ehabk...@redhat.com wrote: There's no Intel CPU with family=6,model=2

Re: [Qemu-devel] [PATCH] pc: add 1.7 machine types for piix,q35

2013-09-12 Thread Andreas Färber
Am 12.09.2013 08:24, schrieb Michael S. Tsirkin: piix 1.7 is the default. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/i386/pc_piix.c | 19 +-- hw/i386/pc_q35.c | 17 - 2 files changed, 33 insertions(+), 3 deletions(-) Looks like you forget to

Re: [Qemu-devel] [PATCH 15/16] qdev-monitor: Clean up qdev_device_add() variable naming

2013-09-12 Thread Andreas Färber
Am 30.08.2013 19:19, schrieb Andreas Färber: Am 26.08.2013 09:52, schrieb Wenchao Xia: 于 2013-8-24 8:00, Andreas Färber 写道: Avoid confusion between object and object class. between object class and device class? No the issue is that by convention we usually use Object *obj

Re: [Qemu-devel] [PATCH] ui/Makefile.objs: delete unnecessary cocoa.o dependency

2013-09-12 Thread Andreas Färber
for modules can be applied, either via a cocoa maintainer queue or via -trivial or just as a first patch on the front of Fam's patches if they would otherwise be being held up by this. Sure, I'll apply to my tree and rebase if it's merged. If it works, fine with me: Reviewed-by: Andreas Färber

Re: [Qemu-devel] MSI-X doesn't work when running Windows as guest

2013-09-13 Thread Andreas Färber
Am 13.09.2013 14:31, schrieb Michael S. Tsirkin: On Fri, Sep 13, 2013 at 03:22:01PM +0300, Michael S. Tsirkin wrote: On Fri, Sep 13, 2013 at 01:14:43AM -0300, Eduardo Habkost wrote: On Fri, Sep 13, 2013 at 12:03:40AM +0300, Michael S. Tsirkin wrote: On Thu, Sep 12, 2013 at 04:45:01PM -0300,

Re: [Qemu-devel] [PATCH 21/47] hw/char/Kconfig: Add Kconfig file

2013-09-13 Thread Andreas Färber
Am 27.08.2013 00:40, schrieb Paolo Bonzini: Il 26/08/2013 19:15, Andreas Färber ha scritto: PCI devices are generally configurable, so you need to add prompts to them. IndustryPack is really misplaced in hw/char/ and I believe I posted patches to remedy that and let one actually find it in our

Re: [Qemu-devel] [RFC v5 1/5] hw/arm: add very initial support for Canon DIGIC SoC

2013-09-13 Thread Andreas Färber
+ include/hw/arm/digic.h | 35 ++ 4 files changed, 102 insertions(+) create mode 100644 hw/arm/digic.c create mode 100644 include/hw/arm/digic.h Perfect, Reviewed-by: Andreas Färber afaer...@suse.de Thanks for your patience, Andreas -- SUSE

Re: [Qemu-devel] [PATCH v4 24/24] arm11mpcore: Split off RealView MPCore

2013-09-13 Thread Andreas Färber
Am 13.09.2013 17:33, schrieb Peter Maydell: On 11 September 2013 15:37, Andreas Färber afaer...@suse.de wrote: Signed-off-by: Andreas Färber afaer...@suse.de --- hw/cpu/Makefile.objs | 1 + hw/cpu/arm11mpcore.c | 121 - hw/cpu

Re: [Qemu-devel] [PATCH 0/8] [PATCH RFC v3] s390 cpu hotplug

2013-09-13 Thread Andreas Färber
Am 13.09.2013 17:01, schrieb Jason J. Herne: On 09/05/2013 10:06 AM, Andreas Färber wrote: Am 05.09.2013 15:10, schrieb Alexander Graf: On 05.09.2013, at 15:05, Andreas Färber wrote: Am 05.09.2013 14:54, schrieb Alexander Graf: Very simple and clean patch set. I don't think it deserves

Re: [Qemu-devel] [PATCH] qom: helper macro for adding read-only properties

2013-09-16 Thread Andreas Färber
Am 15.09.2013 19:23, schrieb Michael S. Tsirkin: Add a helper macro for adding read-only properties, that works in the common case where the value is a constant. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- I'm using this patch in my acpi work - any objections to applying it on

Re: [Qemu-devel] [RFC 4/4] disas: implement host disassembly output for aarch64

2013-09-16 Thread Andreas Färber
Am 11.09.2013 15:08, schrieb Claudio Fontana: use C++ libvixl to implement output, for now only enabled for the host output disasm, since we don't have the aarch64 target yet. Signed-off-by: Claudio Fontana claudio.font...@linaro.org --- configure | 6 + disas.c

Re: [Qemu-devel] [RFC qom-cpu v3 00/10] i386: add cpu hot remove support

2013-09-16 Thread Andreas Färber
Hi, Am 16.09.2013 04:40, schrieb Chen Fan: Via implementing ACPI standard methods _EJ0 in bios, after Guest OS hot remove one vCPU, it is able to send a signal to QEMU, then QEMU could notify the assigned vCPU of exiting. meanwhile, and intruduce the QOM command 'cpu-del' to remove vCPU

Re: [Qemu-devel] [PATCH] qom: helper macro for adding read-only properties

2013-09-16 Thread Andreas Färber
Am 16.09.2013 14:33, schrieb Michael S. Tsirkin: On Mon, Sep 16, 2013 at 08:32:13AM +0200, Andreas Färber wrote: Am 15.09.2013 19:23, schrieb Michael S. Tsirkin: Add a helper macro for adding read-only properties, that works in the common case where the value is a constant. Signed-off

Re: [Qemu-devel] [PATCH 7/8] [PATCH RFC v3] s390-qemu: cpu hotplug - Implement hot_add_cpu hook

2013-09-16 Thread Andreas Färber
Am 13.09.2013 17:29, schrieb Jason J. Herne: On 09/05/2013 08:38 AM, Andreas Färber wrote: Am 01.08.2013 16:12, schrieb Jason J. Herne: From: Jason J. Herne jjhe...@us.ibm.com Implement hot_add_cpu for S390 to allow hot plugging of cpus. Signed-off-by: Jason J. Herne jjhe...@us.ibm.com

Re: [Qemu-devel] in_asm substitute for accel=kvm:tcg

2013-09-17 Thread Andreas Färber
Hi, Am 17.09.2013 13:37, schrieb Andriy Gapon: It seems that when qemu is run with accel=kvm:tcg then -d in_asm does not produce anything. At least, with the qemu and kvm that I have access to. Are you saying that with accel=kvm:tcg when falling back to TCG, -d in_asm does not work? For

Re: [Qemu-devel] [PATCH] qdev: fix crash when device_add is called with abstract driver

2013-09-17 Thread Andreas Färber
Am 17.09.2013 15:32, schrieb Igor Mammedov: user is able to crash running QEMU when following monitor command is called: device_add intel-hda-generic crash is caused by assertion in object_initialize_with_type() when type is abstract. Checking if type is abstract before instance is

Re: [Qemu-devel] [PATCH v2 1/1] integrator: fix Linux boot failure by emulating dbg

2013-09-18 Thread Andreas Färber
Am 18.09.2013 16:31, schrieb alex.ben...@linaro.org: From: Alex Bennée a...@bennee.com Commit 9b8c69243 broke the ability to boot the kernel as the value returned by unassigned_mem_read returned non-zero and left the kernel looping forever waiting for it to change (see integrator_led_set in

Re: [Qemu-devel] [PATCH v4 00/24] arm: ARM11MPCore+A9MPCore+A15MPCore QOM'ification

2013-09-18 Thread Andreas Färber
Am 13.09.2013 17:38, schrieb Peter Maydell: On 11 September 2013 15:37, Andreas Färber afaer...@suse.de wrote: From: Andreas Färber andreas.faer...@web.de Hello Peter, This series fully QOM'ifies A9MPCore so that it can be embedded for Tegra2. It goes on to do the same for A15MPCore, which

Re: [Qemu-devel] [PATCH 2/2] qemu-kvm: paravirt: add feature kvm_pv_unhalt

2013-09-18 Thread Andreas Färber
itself is Reviewed-by: Andreas Färber afaer...@suse.de Regards, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] QEMU SD card emulation problem

2013-09-18 Thread Andreas Färber
Hi, Am 17.09.2013 14:13, schrieb Taimoor Mirza: I have been trying to use SD card emulation of QEMU by providing host directory to QEMU to treat it as SD card. For this I am using option -sd fat:16:rw:/home/taimoor/temp/sdcard. This works fine for me and I can see list of files in guest

Re: [Qemu-devel] [RFC] Enabling x2apic on most (all?) x86 CPU models

2013-09-19 Thread Andreas Färber
Hi, Am 18.09.2013 22:39, schrieb Eduardo Habkost: Hi, I would like to get your opinion on this: Currently we have x2apic enabled only on SandyBridge and Haswell CPU models because we try to keep the CPU models closer to real CPUs. However, x2apic improves performance by reducing the

[Qemu-devel] block/stream.c -Werror build failure

2013-09-19 Thread Andreas Färber
Hello, As reported yesterday on IRC, since the last round of pulls I am getting the following warning-treated-as-error: CCblock/stream.o /home/andreas/QEMU/qemu/block/stream.c: In function ‘stream_run’: /home/andreas/QEMU/qemu/block/stream.c:111:14: error: ‘copy’ may be used uninitialized

<    1   2   3   4   5   6   7   8   9   10   >