Re: [Qemu-devel] [qemu-s390x] [PATCH v4 3/3] s390x/sclp: extend SCLP event masks to 64 bits

On 03/05/2018 04:27 PM, Cornelia Huck wrote: > On Fri, 2 Mar 2018 10:44:46 +0100 > Christian Borntraeger <borntrae...@de.ibm.com> wrote: > >> On 02/23/2018 06:42 PM, Claudio Imbrenda wrote: >>> Extend the SCLP event masks to 64 bits. >>> >>&g

Re: [Qemu-devel] [PATCH v2] s390x/sclpconsole: Remove dead code - delete error handlers

<nia.ala...@gmail.com> I would like to have 2 patches to make the subject non-misleading. patch1: sclp/event patch2: virtio-ccw With that Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com> > --- > hw/char/sclpconsole-lm.c | 6 -- > hw/char/sclpcon

Re: [Qemu-devel] [PATCH v2] pc-bios/s390-ccw: Move string arrays from bootmap header to .c file

bootmap.c file instead where they are used. > > Signed-off-by: Thomas Huth <th...@redhat.com> Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com> > --- > v2: > - Removed duplicated vol_desc_magic (copy-n-paste error) > > pc-bios/s390-ccw/bootmap.c | 20

Re: [Qemu-devel] [PATCH v1 1/1] iotests: bypass s390x for case 200

Nack. This will be fixed by s390/ipl: only print boot menu error if -boot menu=on was specified On 03/06/2018 08:54 AM, QingFeng Hao wrote: > In s390x, the case 200 failed as: > === Starting QEMU VM === > > +QEMU_PROG: boot menu is not supported for this device type. > {"return": {}} > >

Re: [Qemu-devel] [BUG] I/O thread segfault for QEMU on s390x

into ptregs but we have already zeroed out r0. This patch moves the clearing of r0 after sysc_do_svc, which should fix the critical section cleanup. Adding Martin and Heiko. Will spin a patch. On 03/05/2018 07:54 PM, Christian Borntraeger wrote: > > > On 03/05/2018 07:45 PM, Farhan

Re: [Qemu-devel] [BUG] I/O thread segfault for QEMU on s390x

On 03/05/2018 07:45 PM, Farhan Ali wrote: > > > On 03/05/2018 06:03 AM, Stefan Hajnoczi wrote: >> Please include the following gdb output: >> >>    (gdb) disas swapcontext >>    (gdb) i r >> >> That way it's possible to see which instruction faulted and which >> registers were being accessed.

Re: [Qemu-devel] [PATCH 1/1] s390/kvm: implement clearing part of IPL clear

On 03/05/2018 01:54 PM, Cornelia Huck wrote: > On Wed, 28 Feb 2018 19:53:20 + > Christian Borntraeger <borntrae...@de.ibm.com> wrote: > >> When a guests reboots with diagnose 308 subcode 3 it requests the memory >> to be cleared. We did not do it so far.

Re: [Qemu-devel] [Bug 1753437] [NEW] qemu/pc-bios/s390-ccw/libc.c:82: bad test ?

Adding qemu-s390x. On 03/05/2018 11:31 AM, dcb wrote: > Public bug reported: > > qemu/pc-bios/s390-ccw/libc.c:82]: (style) Unsigned variable 'num_idx' > can't be negative so it is unnecessary to test it. > > Source code is > > > while (num_idx >= 0) { > > but > > size_t num_idx = 1;

Re: [Qemu-devel] [PATCH] hw/s390x: Add the possibility to specify the netboot image on the command line

On 03/05/2018 11:23 AM, Cornelia Huck wrote: > On Tue, 27 Feb 2018 12:32:34 +0100 > Thomas Huth wrote: > >> The file name of the netboot binary is currently hard-coded to >> "s390-netboot.img", without a possibility for the user to select >> an alternative firmware image

Re: [Qemu-devel] [PATCH] s390x/sclpconsole: Remove dead code - make _error functions void

On 03/04/2018 02:45 PM, Nia Alarie wrote: > These functions always return 0. By changing their return type to > void, some dead code can be removed. the event facility part looks ok, but I am asking myself if we should go a step further. Do we need the exit callback at all? We can certainly keep

Re: [Qemu-devel] [qemu-s390x] [PATCH v4 3/3] s390x/sclp: extend SCLP event masks to 64 bits

On 02/23/2018 06:42 PM, Claudio Imbrenda wrote: > Extend the SCLP event masks to 64 bits. > > Notice that using any of the new bits results in a state that cannot be > migrated to an older version. > > Signed-off-by: Claudio Imbrenda > --- >

Re: [Qemu-devel] [qemu-s390x] [PATCH v4 2/3] s390x/sclp: clean up sclp masks

> Certainly a sane cleanup, especially the use if the SCLP_EVMASK. Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com> > --- > hw/char/sclpconsole-lm.c | 4 ++-- > hw/char/sclpconsole.c | 4 ++-- > hw/s390x/event-facility.c | 20 +++

Re: [Qemu-devel] [qemu-s390x] [PATCH v4 1/3] s390x/sclp: proper support of larger send and receive masks

achine models the old broken behaviour is selected > (allowing only masks of size exactly 4), in order to be able to migrate > toward older versions. > > Fixes: 67915de9f0383ccf4a ("s390x/event-facility: variable-length event > masks") > Signed-off-by: Claudio Imbren

Re: [Qemu-devel] [PATCH v2] s390/ipl: only print boot menu error if -boot menu=on was specified

et.ibm.com> This also Fixes qemu iotest 200. Acked-by: Christian Borntraeger <borntrae...@de.ibm.com> > --- > hw/s390x/ipl.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c > index 798e99a..d7fb33f 10

Re: [Qemu-devel] [PATCH 1/1] s390/kvm: implement clearing part of IPL clear

On 03/01/2018 01:35 PM, Christian Borntraeger wrote: > > > On 03/01/2018 01:28 PM, Dr. David Alan Gilbert wrote: >> * Christian Borntraeger (borntrae...@de.ibm.com) wrote: >>> >>> >>> On 03/01/2018 12:45 PM, Dr. David Alan Gilbert wrote: >>&g

Re: [Qemu-devel] [PATCH 1/1] s390/kvm: implement clearing part of IPL clear

On 03/01/2018 01:28 PM, Dr. David Alan Gilbert wrote: > * Christian Borntraeger (borntrae...@de.ibm.com) wrote: >> >> >> On 03/01/2018 12:45 PM, Dr. David Alan Gilbert wrote: >>> * Christian Borntraeger (borntrae...@de.ibm.com) wrote: >>>> >>>&g

Re: [Qemu-devel] [PATCH 1/1] s390/kvm: implement clearing part of IPL clear

On 03/01/2018 12:45 PM, Dr. David Alan Gilbert wrote: > * Christian Borntraeger (borntrae...@de.ibm.com) wrote: >> >> >> On 03/01/2018 10:24 AM, Dr. David Alan Gilbert wrote: >>> * Thomas Huth (th...@redhat.com) wrote: >>>> On 28.02.2018 20:53, Christ

Re: [Qemu-devel] [PATCH 1/1] s390/kvm: implement clearing part of IPL clear

On 03/01/2018 10:24 AM, Dr. David Alan Gilbert wrote: > * Thomas Huth (th...@redhat.com) wrote: >> On 28.02.2018 20:53, Christian Borntraeger wrote: >>> When a guests reboots with diagnose 308 subcode 3 it requests the memory >>> to be cleared. We did not do it so far.

Re: [Qemu-devel] [PATCH 1/1] s390/kvm: implement clearing part of IPL clear

On 03/01/2018 04:58 AM, Thomas Huth wrote: > On 28.02.2018 20:53, Christian Borntraeger wrote: >> When a guests reboots with diagnose 308 subcode 3 it requests the memory >> to be cleared. We did not do it so far. This does not only violate the >> architecture, it also miss

[Qemu-devel] [PATCH 1/1] s390/kvm: implement clearing part of IPL clear

ram_block_discard_range we can cover both cases. Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- target/s390x/kvm.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c index 8f3a422288..2e145ad5c3 100644 --- a/target/s390x/kvm.c

Re: [Qemu-devel] [PATCH v4 3/3] s390x/sclp: extend SCLP event masks to 64 bits

h On 02/26/2018 05:57 PM, Cornelia Huck wrote: > On Fri, 23 Feb 2018 18:42:58 +0100 > Claudio Imbrenda wrote: > >> Extend the SCLP event masks to 64 bits. >> >> Notice that using any of the new bits results in a state that cannot be >> migrated to an older version.

Re: [Qemu-devel] [qemu-s390x] [PATCH] vfio-ccw: license text should indicate GPL v2 or later

et.ibm.com> > Cc: Xiao Feng Ren <renxi...@linux.vnet.ibm.com> > Cc: Pierre Morel <pmo...@linux.vnet.ibm.com> > Signed-off-by: Cornelia Huck <coh...@redhat.com> Acked-by: Christian Borntraeger <borntrae...@de.ibm.com> > --- > hw/vfio/ccw.c | 4 ++-- > 1

Re: [Qemu-devel] [PATCH v3] numa: we don't implement NUMA for s390x

; qemu-system-s390x: -numa node,nodeid=0,cpus=0-1: NUMA is not supported by >this machine-type > > While at it, make s390_cpu_index_to_props() look like on other > architectures. > > Signed-off-by: David Hildenbrand <da...@redhat.com> Reviewed-by: Chris

Re: [Qemu-devel] [PATCH v1] numa: s390x has no NUMA

On 02/26/2018 11:35 AM, Cornelia Huck wrote: > On Mon, 26 Feb 2018 11:28:26 +0100 > David Hildenbrand wrote: > >> On 26.02.2018 11:19, Cornelia Huck wrote: >>> On Fri, 23 Feb 2018 18:36:57 +0100 >>> David Hildenbrand wrote: >>> Right now it is

Re: [Qemu-devel] [PATCH v1] numa: s390x has no NUMA

On 02/23/2018 06:36 PM, David Hildenbrand wrote: > Right now it is possible to crash QEMU for s390x by providing e.g. > -numa node,nodeid=0,cpus=0-1 > > Problem is, that numa.c uses mc->cpu_index_to_instance_props as an > indicator whether NUMA is supported by a machine type. We don't >

Re: [Qemu-devel] [qemu-s390x] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

On 02/23/2018 03:57 PM, Collin L. Walling wrote: > On 02/23/2018 05:11 AM, Christian Borntraeger wrote: >> >> On 02/23/2018 11:07 AM, Thomas Huth wrote: >>> On 22.02.2018 20:40, Collin L. Walling wrote: >>>> On 02/22/2018 11:45 AM, Collin L. Walling wrote: >

Re: [Qemu-devel] [PATCH v3 3/3] s390x/sclp: extend SCLP event masks to 64 bits

On 02/23/2018 01:51 PM, Claudio Imbrenda wrote: > > +static bool vmstate_event_facility_mask64_needed(void *opaque) > +{ > +SCLPEventFacility *ef = opaque; > + > +return (ef->receive_mask & 0x) != 0; > +} > + > +static int vmstate_event_facility_mask64_pre_load(void *opaque) >

Re: [Qemu-devel] [PATCH v3 2/3] s390x/sclp: clean up sclp masks

ibm.com> Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com>

Re: [Qemu-devel] [PATCH v3 1/3] s390x/sclp: proper support of larger send and receive masks

On 02/23/2018 01:51 PM, Claudio Imbrenda wrote: > Until 67915de9f0383ccf4a ("s390x/event-facility: variable-length event masks") > we only supported sclp event masks with a size of exactly 4 bytes, even > though the architecture allows the guests to set up sclp event masks > from 1 to 1021 bytes

Re: [Qemu-devel] [qemu-s390x] [PATCH] s390x: remove s390_get_memslot_count

On 02/23/2018 11:19 AM, Cornelia Huck wrote: > Not needed anymore after removal of the memory hotplug code. > > Signed-off-by: Cornelia Huck <coh...@redhat.com> Acked-by: Christian Borntraeger <borntrae...@de.ibm.com> > --- > include/hw/s390x/sclp.h | 1 - >

Re: [Qemu-devel] [qemu-s390x] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

On 02/23/2018 11:07 AM, Thomas Huth wrote: > On 22.02.2018 20:40, Collin L. Walling wrote: >> On 02/22/2018 11:45 AM, Collin L. Walling wrote: >>> On 02/22/2018 10:44 AM, Christian Borntraeger wrote: >>>> >>>> On 02/22/2018 04:40 PM, Collin L. Walling w

Re: [Qemu-devel] [qemu-s390x] [PATCH] s390x/sclp: remove duplicate MAX_AVAIL_SLOTS define

On 02/23/2018 10:54 AM, Cornelia Huck wrote: > It's already defined in cpu.h (to the same value) and not used in > the sclp code. > > Signed-off-by: Cornelia Huck > --- > include/hw/s390x/sclp.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git

Re: [Qemu-devel] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

Hmmm, on my ubuntu 16.04 guest, I get the boot menu with no timeout even if I do not specify loadparm or boot menu: qemu-kvm -drive file=/var/lib/libvirt/qemu/image.zhyp140,if=none,id=d1 -device virtio-blk-ccw,drive=d1,bootindex=1 LOADPARM=[] Using virtio-blk. Using SCSI scheme.

Re: [Qemu-devel] [qemu-s390x] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

On 02/22/2018 04:40 PM, Collin L. Walling wrote: > On 02/22/2018 07:23 AM, Viktor Mihajlovski wrote: >> On 22.02.2018 12:51, Christian Borntraeger wrote: >>> Series >>> Acked-by: Christian Borntraeger <borntrae...@de.ibm.com> > > Thanks!!! > >>

Re: [Qemu-devel] [PATCH v2 1/1] 390x/cpumodel: document S390FeatDef.bit not applicable

90_FEAT_TYPE_MISC so, that one does not have to specify neither bit nor > type (as the later is implied). > > Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> Acked-by: Christian Borntraeger <borntrae...@de.ibm.com> > --- > > v1 -> v2 > * Specialized featu

Re: [Qemu-devel] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

Series Acked-by: Christian Borntraeger <borntrae...@de.ibm.com> menu on scsi and dasd bootmaps tested successfully. There is one thing that we might want to fix (can be an addon patch since this is a non-customer scenario (no libvirt)). If you start QEMU manually without a boo

Re: [Qemu-devel] [PATCH RFCv2] s390x/sclp: remove memory hotplug support

om> wrote: >>> >>>> On 20.02.2018 13:05, Christian Borntraeger wrote: >>>>> >>>>> >>>>> On 02/19/2018 06:42 PM, David Hildenbrand wrote: >>>>>> From an architecture point of view, nothing

Re: [Qemu-devel] [qemu-s390x] [PATCH 1/1] 390x/cpumodel: document S390FeatDef.bit not applicable

On 02/20/2018 04:55 PM, David Hildenbrand wrote: > On 20.02.2018 16:53, Cornelia Huck wrote: >> On Tue, 20 Feb 2018 16:07:13 +0100 >> Halil Pasic wrote: >> >>> The 'bit' field of the 'S390FeatDef' structure is not applicable to all >>> it's instances. Currently a this

Re: [Qemu-devel] [PATCH RFCv2] s390x/sclp: remove memory hotplug support

s not working, this change cannot really break > migration as guests without slots and maxmem don't see the SCLP > features. Also, the ram size calcualtion does not change. > > Signed-off-by: David Hildenbrand <da...@redhat.com>

Re: [Qemu-devel] [PATCH RFCv2] s390x/sclp: remove memory hotplug support

On 02/20/2018 12:18 PM, Christian Borntraeger wrote: > Given that we have trouble modeling this properly I somewhat like the idea. > We should have never folded this into the common code memory hotplug > infrastructure as it is different. Instead we really should have provided >

Re: [Qemu-devel] [PATCH RFCv2] s390x/sclp: remove memory hotplug support

Given that we have trouble modeling this properly I somewhat like the idea. We should have never folded this into the common code memory hotplug infrastructure as it is different. Instead we really should have provided a different interface and we should have build it with migration support. If

Re: [Qemu-devel] [PATCH v7 11/12] s390-ccw: set cp_receive mask only when needed and consume pending service irqs

On 02/16/2018 11:07 PM, Collin L. Walling wrote: > It is possible while waiting for multiple types of external > interrupts that we might have pending irqs remaining between > irq consumption and irq-type disabling. Those interrupts > could potentially propagate to the guest after IPL completes

Re: [Qemu-devel] [PATCH v7 11/12] s390-ccw: set cp_receive mask only when needed and consume pending service irqs

On 02/19/2018 03:15 PM, Christian Borntraeger wrote: > > > On 02/16/2018 11:07 PM, Collin L. Walling wrote: >> It is possible while waiting for multiple types of external >> interrupts that we might have pending irqs remaining between >> irq consumption and irq-type

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 05/12] s390-ccw: move auxiliary IPL data to separate location

On 02/14/2018 03:51 PM, Collin L. Walling wrote: > On 02/06/2018 05:13 AM, Viktor Mihajlovski wrote: >> On 06.02.2018 10:23, Thomas Huth wrote: >>> On 05.02.2018 21:57, Collin L. Walling wrote: >>> [...] diff --git a/pc-bios/s390-ccw/main.c b/pc-bios/s390-ccw/main.c index

Re: [Qemu-devel] [PATCHv2 1/3] qmp: expose s390-specific CPU info

"cpu-state": "stopped", "CPU": 1, > "qom_path": "/machine/unattached/device[1]", > "halted": true, "thread_id": 63116} >] > > Signed-off-by: Viktor Mihajlovski <mihaj...@linux.vnet.ibm.com> > Acked-by: Eric Blake <ebl...@redhat.com> Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com>

Re: [Qemu-devel] [qemu-web PATCH] Add a blog post documenting Spectre/Meltdown options for QEMU 2.11.1

hat.com> >> Cc: Paolo Bonzini <pbonz...@redhat.com> >> Cc: Peter Maydell <peter.mayd...@linaro.org> >> Cc: Suraj Jitindar Singh <sjitindarsi...@gmail.com> >> Cc: David Gibson <da...@gibson.dropbear.id.au> >> Cc: Christian Borntraeger <borntr

Re: [Qemu-devel] [PATCH] iotests: Use virtio-blk in 155

On 02/12/2018 01:47 PM, Max Reitz wrote: > Only a few select machine types support floppy drives and there is > actually nothing preventing us from using virtio here, so let's do it. > > Reported-by: Christian Borntraeger <borntrae...@de.ibm.com> > Signed-off-by: Max Rei

Re: [Qemu-devel] [PULL 06/29] iotests: Make BD-{remove, insert}-medium use @id

Adding Max and Alberto, I think the issue is that on s390 you cannot add a floppy On 02/12/2018 12:16 PM, Christian Borntraeger wrote: > > On 01/23/2018 03:01 PM, Kevin Wolf wrote: >> From: Max Reitz <mre...@redhat.com> >> >> In some cases, these commands st

Re: [Qemu-devel] [PULL 06/29] iotests: Make BD-{remove, insert}-medium use @id

On 01/23/2018 03:01 PM, Kevin Wolf wrote: > From: Max Reitz > > In some cases, these commands still use the deprecated @device > parameter. Fix that so we can later drop that parameter from their > interface. > > Signed-off-by: Max Reitz > Message-id:

[Qemu-devel] [PATCH v8] s390x/cpu: expose the guest crash information

ause", "info": { "core": 0, "psw-addr": 1102832, "reason": "disabled-wait", "psw-mask": 562956395872256, "type": "s390" } } }

Re: [Qemu-devel] [PATCH v7] s390x/cpu: expose the guest crash information

On 02/08/2018 03:20 PM, Eric Blake wrote: > On 02/08/2018 03:57 AM, Christian Borntraeger wrote: >> This patch is the s390 implementation of guest crash information, >> similar to commit d187e08dc4 ("i386/cpu: add crash-information QOM >> property") and the

Re: [Qemu-devel] [qemu-s390x] [PATCH v7] s390x/cpu: expose the guest crash information

On 02/08/2018 03:20 PM, Eric Blake wrote: > On 02/08/2018 03:57 AM, Christian Borntraeger wrote: >> This patch is the s390 implementation of guest crash information, >> similar to commit d187e08dc4 ("i386/cpu: add crash-information QOM >> property") and the

Re: [Qemu-devel] [PATCH] s390x/sclp: fix event mask handling --> stable 2.11.1?

On 02/02/2018 11:35 AM, Cornelia Huck wrote: > On Fri, 2 Feb 2018 11:33:01 +0100 > Cornelia Huck <coh...@redhat.com> wrote: > >> On Fri, 2 Feb 2018 10:43:18 +0100 >> Christian Borntraeger <borntrae...@de.ibm.com> wrote: >> >>> On 02/02/2018 10:4

Re: [Qemu-devel] [PATCH] S390: Expose s390-specific CPU info

On 02/08/2018 11:16 AM, Cornelia Huck wrote: > On Thu, 8 Feb 2018 10:48:08 +0100 > Viktor Mihajlovski wrote: > > [added some cc:s] > >> Presently s390x is the only architecture not exposing specific >> CPU information via QMP query-cpus. Upstream discussion has

[Qemu-devel] [PATCH v7] s390x/cpu: expose the guest crash information

ause", "info": { "core": 0, "psw-addr": 1102832, "reason": "disabled-wait", "psw-mask": 562956395872256, "type": "s390" } } }

Re: [Qemu-devel] [PATCH v6] s390x/cpu: expose the guest crash information

On 02/07/2018 01:38 PM, Christian Borntraeger wrote: > --- a/vl.c > +++ b/vl.c > @@ -1738,7 +1738,7 @@ void qemu_system_reset(ShutdownCause reason) > > void qemu_system_guest_panicked(GuestPanicInformation *info) > { > -qemu_log_mask(LOG_GUEST_ER

Re: [Qemu-devel] [qemu-s390x] [PATCH 2/3] MAINTAINERS: reorganize s390-ccw bios maintainership

On 02/07/2018 04:55 PM, Cornelia Huck wrote: > Split it out from the s390-ccw-virtio machine, add Thomas as a > maintainer in addition to Christian. > > Signed-off-by: Cornelia Huck <coh...@redhat.com> Acked-by: Christian Borntraeger <borntrae...@de.ibm.com> Thanks

Re: [Qemu-devel] [qemu-s390x] [PATCH 1/3] MAINTAINERS: add myself as overall s390x maintainer

On 02/07/2018 04:55 PM, Cornelia Huck wrote: > All your mainframes are belong to me. > > Signed-off-by: Cornelia Huck <coh...@redhat.com> Acked-by: Christian Borntraeger <borntrae...@de.ibm.com> > --- > MAINTAINERS | 23 +++ > 1 file chang

Re: [Qemu-devel] [PATCH v6] s390x/cpu: expose the guest crash information

On 02/07/2018 05:58 PM, Cornelia Huck wrote: > >> +## >> +# @S390CrashReason: >> +# >> +# Reason why the CPU is in a crashed state. >> +# >> +# @unknown: no crash reason was set >> +# >> +# @disabledwait: the CPU has entered a disabled wait state >> +# >> +# @extintloop: timer interrupt with

Re: [Qemu-devel] [qemu-s390x] [PATCH v6] s390x/cpu: expose the guest crash information

On 02/07/2018 02:29 PM, Christian Borntraeger wrote: > > > On 02/07/2018 02:21 PM, David Hildenbrand wrote: >> On 07.02.2018 13:38, Christian Borntraeger wrote: >>> This patch is the s390 implementation of guest crash information, >>> similar to commit

Re: [Qemu-devel] [PATCH v6] s390x/cpu: expose the guest crash information

On 02/07/2018 02:21 PM, David Hildenbrand wrote: > On 07.02.2018 13:38, Christian Borntraeger wrote: >> This patch is the s390 implementation of guest crash information, >> similar to commit d187e08dc4 ("i386/cpu: add crash-information QOM >> property") and the

Re: [Qemu-devel] [PATCH v6] s390x/cpu: expose the guest crash information

On 02/07/2018 02:07 PM, no-re...@patchew.org wrote: > CC s390x-linux-user/target/s390x/cpu.o > /var/tmp/patchew-tester-tmp-ctncjhw8/src/target/s390x/cpu.c: In function > ‘s390_cpu_get_crash_info’: > /var/tmp/patchew-tester-tmp-ctncjhw8/src/target/s390x/cpu.c:251:39: error: >

[Qemu-devel] [PATCH v6] s390x/cpu: expose the guest crash information

pause", "info": { "core": 0, "psw-addr": 1102832, "reason": "disabledwait", "psw-mask": 562956395872256, "type": "s390" } } }

Re: [Qemu-devel] [PATCH v5 1/1] s390x/cpu: expose the guest crash information

On 02/06/2018 04:31 PM, Eric Blake wrote: > On 02/06/2018 01:46 AM, Christian Borntraeger wrote: >> This patch is the s390 implementation of guest crash information, >> similar to commit d187e08dc4 ("i386/cpu: add crash-information QOM >> property") and the

Re: [Qemu-devel] [PATCH v2] s390x/cpumodel: model PTFF subfunctions for Multiple-epoch facility

om> wrote: >>> >>>> On 05.02.2018 12:22, Christian Borntraeger wrote: >>>>> Looks sane on a z14. >>>>> Tested-by: Christian Borntraeger <borntrae...@de.ibm.com> >>>>> >>>>> >>>>> On 0

Re: [Qemu-devel] [qemu-s390x] [PATCH v2] s390x/cpumodel: model PTFF subfunctions for Multiple-epoch facility

ith Multiple-epoch facility. > > Let's properly add these, along with a new feature group. > > Signed-off-by: David Hildenbrand <da...@redhat.com> Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com> > --- > > v1 -> v2: > - s/MEPOCH/MULTIPLE_EP

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 1/1] s390x/cpu: expose the guest crash information

On 02/06/2018 01:49 PM, Cornelia Huck wrote: > On Tue, 6 Feb 2018 07:46:22 + > Christian Borntraeger <borntrae...@de.ibm.com> wrote: > >> This patch is the s390 implementation of guest crash information, >> similar to commit d187e08dc4 ("i386/cpu: add c

Re: [Qemu-devel] [PATCH v5 05/12] s390-ccw: move auxiliary IPL data to separate location

On 02/05/2018 09:57 PM, Collin L. Walling wrote: > The s390-ccw firmware needs some information in support of the > boot process which is not available on the native machine. > Examples are the netboot firmware load address and now the > boot menu parameters. > > While storing that data in unused

[Qemu-devel] [PATCH v5 1/1] s390x/cpu: expose the guest crash information

uot;: { "psw-addr": 1105350, "reason": "disabled wait", "psw-mask": 562956395872256, "type": "s390" } } } 3. log; Run qemu with the parameters: -D -d guest_errors,

Re: [Qemu-devel] [PATCH v4] s390x/cpu: expose the guest crash information

On 02/05/2018 03:12 PM, Christian Borntraeger wrote: [...] > diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h > index a1123ad621..71414cc324 100644 > --- a/target/s390x/cpu.h > +++ b/target/s390x/cpu.h > @@ -77,6 +77,14 @@ typedef struct MchkQueue { > uint16_t ty

[Qemu-devel] [PATCH v4] s390x/cpu: expose the guest crash information

uot;: { "psw-addr": 1105350, "reason": "disabled wait", "psw-mask": 562956395872256, "type": "s390" } } } 3. log; Run qemu with the parameters: -D -d guest_errors,

Re: [Qemu-devel] [PATCH v3 1/1] s390x/cpu: expose the guest crash information

On 02/05/2018 01:04 PM, Cornelia Huck wrote: > You're doing the crash_reason -> reason mapping here and also below. > Maybe introduce a helper for it? > [] >> diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c >> index 8736001156..c6a23262a8 100644 >> --- a/target/s390x/kvm.c >> +++

Re: [Qemu-devel] [PATCH v2] s390x/cpumodel: model PTFF subfunctions for Multiple-epoch facility

Looks sane on a z14. Tested-by: Christian Borntraeger <borntrae...@de.ibm.com> On 02/05/2018 11:29 AM, David Hildenbrand wrote: > --- a/target/s390x/kvm.c > +++ b/target/s390x/kvm.c > @@ -2221,6 +2221,14 @@ void kvm_s390_get_host_cpu_model(S390CPUModel *model, > Error **errp)

Re: [Qemu-devel] [PATCH] s390x/cpumodel: model PTFF subfunctions for Multiple-epoch facility

On 02/05/2018 10:34 AM, David Hildenbrand wrote: > On 05.02.2018 10:09, David Hildenbrand wrote: >> For now, the kernel does not properly indicate configured CPU subfunctions >> to the guest, but simply uses the host values (as support in KVM is still >> missing). That's why we missed to model

Re: [Qemu-devel] [PATCH] s390x/sclp: fix event mask handling

On 02/02/2018 10:42 AM, Christian Borntraeger wrote: > commit 67915de9f038 ("s390x/event-facility: variable-length event > masks") switches the sclp receive/send mask. This broke the sclp switched > lm console. > > Signed-off-by: Christian Borntraeger <bor

Re: [Qemu-devel] [PATCH v3 1/1] s390x/cpu: expose the guest crash information

', 'base': {'type': 'GuestPanicInformationType'}, 'discriminator': 'type', 'data': { 'hyper-v': 'GuestPanicInformationHyperV', 's390': 'GuestPanicInformationS390' } } seems to fix it. On 02/02/2018 03:51 PM, Eric Blake wrote: > On 02/02/2018 08:37 AM, Christian Borntraeger wr

[Qemu-devel] [PATCH v3 1/1] s390x/cpu: expose the guest crash information

uot;: { "psw-addr": 1105350, "reason": "disabled wait", "psw-mask": 562956395872256, "type": "s390" } } } 3. log; Run qemu with the parameters: -D -d guest_errors,

[Qemu-devel] [PATCH v3 0/1] respin of s390 crash information

this patch). Some fixup will be necessary. Christian Borntraeger (1): s390x/cpu: expose the guest crash information qapi/run-state.json | 29 -- target/s390x/cpu.c| 57 +++ target/s390x/cpu.h| 10 + target

Re: [Qemu-devel] [PATCH] s390x/sclp: fix event mask handling

On 02/02/2018 10:42 AM, Christian Borntraeger wrote: > commit 67915de9f038 ("s390x/event-facility: variable-length event > masks") switches the sclp receive/send mask. This broke the sclp > lm console. > > Signed-off-by: Christian Borntraeger <borntrae...

[Qemu-devel] [PATCH] s390x/sclp: fix event mask handling

commit 67915de9f038 ("s390x/event-facility: variable-length event masks") switches the sclp receive/send mask. This broke the sclp lm console. Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> Fixes: commit 67915de9f038 ("s390x/event-facility: variable-le

Re: [Qemu-devel] [PATCH v2 1/1] Fix configure for s390 qemu on alpine and other busybox environments

On 01/31/2018 01:51 PM, Peter Maydell wrote: > On 31 January 2018 at 12:14, Christian Borntraeger > <borntrae...@de.ibm.com> wrote: >> On 01/30/2018 04:41 PM, Eric Blake wrote: >>> On 01/30/2018 07:38 AM, Christian Borntraeger wrote: >>>> +++ b/configure

Re: [Qemu-devel] [PATCH v2 1/1] Fix configure for s390 qemu on alpine and other busybox environments

On 01/30/2018 04:41 PM, Eric Blake wrote: > On 01/30/2018 07:38 AM, Christian Borntraeger wrote: >> From: Alice Frosi <al...@linux.vnet.ibm.com> >> >> In alpine docker image the qemu-system-s390x build is broken and >> it throws this error: >> qemu-system-s

[Qemu-devel] [PATCH v2 0/1] Fix binary build of qemu-system-s390x on alpine

Peter, Paolo, sending this to you as you have the most commits on configure. If you are ok with it, we can also carry that via the s390 tree. Alice Frosi (1): Fix configure for s390 qemu on alpine and other busybox environments configure | 4 ++-- 1 file changed, 2 insertions(+), 2

[Qemu-devel] [PATCH v2 1/1] Fix configure for s390 qemu on alpine and other busybox environments

t.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> [some changes to patch description, add -a option to strings] --- v1->v2: - Fix email address of Alice - Fix patch prefix configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/config

Re: [Qemu-devel] [PATCH v2 17/18] s390x/kvm: cache the kvm flic in a central function

On 01/17/2018 06:40 PM, David Hildenbrand wrote: > This avoids tons of conversions when handling interrupts. > > Signed-off-by: David Hildenbrand <da...@redhat.com> Acked-by: Christian Borntraeger <borntrae...@de.ibm.com> > --- > hw/intc/s390_flic_kvm.c | 21

Re: [Qemu-devel] [PULL 0/8] x86 queue, 2018-01-17

On 01/23/2018 09:40 AM, Christian Ehrhardt wrote: > On Thu, Jan 18, 2018 at 2:51 PM, Peter Maydell > wrote: >> On 18 January 2018 at 02:01, Eduardo Habkost wrote: >>> The following changes since commit 8e5dc9ba49743b46d955ec7dacb04e42ae7ada7c:

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 1/3] header sync

ian Borntraeger wrote: >> replace with proper header sync >> >> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> >> --- >> linux-headers/asm-s390/kvm.h | 9 - >> linux-headers/linux/kvm.h| 5 +++-- >> 2 files changed, 7 insertions(+),

Re: [Qemu-devel] [qemu-s390x] [PATCH 12/12] Fix configure for s390 qemu on alpine

And the from email address is also wrong. (spurious x after .com) On 01/19/2018 05:53 PM, Christian Borntraeger wrote: > ignore the 12/12, it is just one patch > > On 01/19/2018 05:42 PM, Christian Borntraeger wrote: >> From: Alice Frosi <al...@linux.vnet.ibm.comx> &

Re: [Qemu-devel] [PATCH 12/12] Fix configure for s390 qemu on alpine

ignore the 12/12, it is just one patch On 01/19/2018 05:42 PM, Christian Borntraeger wrote: > From: Alice Frosi <al...@linux.vnet.ibm.comx> > > In alpine docker image the qemu-system-s390x build is broken and > it throws this error: > qemu-system-s390x: Initializati

[Qemu-devel] [PATCH 12/12] Fix configure for s390 qemu on alpine

si <al...@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> [some changes to patch description, add -a option to strings] --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 6d8c996..383b14e 100755 --- a/configu

Re: [Qemu-devel] [PATCH v2 1/1] s390x: fix storage attributes migration for non-small guests

d-off-by: Claudio Imbrenda <imbre...@linux.vnet.ibm.com> > Fixes: 903fd80b03243476 ("s390x/migration: Storage attributes device") Cc: stable ? Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com> > --- > hw/s390x/s390-stattrib-kvm.c | 4 ++-- > 1 file changed, 2 insertions(

Re: [Qemu-devel] [PATCH v3 0/3] s390x/kvm: implement new hardware/firmware features

On 01/18/2018 12:53 PM, Cornelia Huck wrote: > On Thu, 18 Jan 2018 09:56:25 +0100 > Christian Borntraeger <borntrae...@de.ibm.com> wrote: > >> We want to provide more hw features to guests, namely the new bpb >> control as well as other transparent facilities

Re: [Qemu-devel] [PATCH v3 2/3] s390x/kvm: Handle bpb feature

On 01/18/2018 01:01 PM, Halil Pasic wrote: > > > On 01/18/2018 09:56 AM, Christian Borntraeger wrote: >> We need to handle the bpb control on reset and migration. Normally >> stfle.82 is transparent (and the normal guest part works without >> hypervisor activity

[Qemu-devel] [PATCH v3 2/3] s390x/kvm: Handle bpb feature

We need to handle the bpb control on reset and migration. Normally stfle.82 is transparent (and the normal guest part works without hypervisor activity). To prevent any issues we require full host kernel support for this feature. Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.

[Qemu-devel] [PATCH v3 0/3] s390x/kvm: implement new hardware/firmware features

;v3: - use bool for bpbc - sort cpu facilities v1->v2: - style and comment fixes - drop transparent facility patch - add patch to introduce facility 81 Christian Borntraeger (3): header sync s390x/kvm: Handle bpb feature s390x/kvm: provide stfle.81 linux-headers/as

[Qemu-devel] [PATCH v3 3/3] s390x/kvm: provide stfle.81

stfle.81 (ppa15) is a transparent facility that can be passed to the guest without the need to implement hypervisor support. As this feature can be provided by firmware we add it to all full models. Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- target/s390x/cpu_feat

[Qemu-devel] [PATCH v3 1/3] header sync

replace with proper header sync Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- linux-headers/asm-s390/kvm.h | 9 - linux-headers/linux/kvm.h| 5 +++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/linux-headers/asm-s390/kvm.h b/linux-heade

Re: [Qemu-devel] [PATCH v2 3/3] s390x/kvm: provide stfle.81

On 01/17/2018 10:13 PM, David Hildenbrand wrote: > On 17.01.2018 20:37, Christian Borntraeger wrote: >> stfle.81 (ppa15) is a transparent facility that can be passed to the >> guest without the need to implement hypervisor support. As this feature >> can be provided by firm

Re: [Qemu-devel] [PATCH v2 1/3] header sync

It is just a header sync and mimics the kernel. The previous header sync added the the commit that added the SPDX tag and this header sync added the commit that removed the now redundant licence text. On 01/17/2018 08:46 PM, Eric Blake wrote: > On 01/17/2018 01:37 PM, Christian Borntraeger wr

[Qemu-devel] [PATCH v2 2/3] s390x/kvm: Handle bpb feature

We need to handle the bpb control on reset and migration. Normally stfle.82 is transparent (and the normal guest part works without hypervisor activity). To prevent any issues we require full host kernel support for this feature. Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.

<    4   5   6   7   8   9   10   11   12   13   >