Re: [Qemu-devel] Re: [PATCH 07/17] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

2010-01-20 Thread Daniel P. Berrange
On Wed, Jan 20, 2010 at 08:19:26AM +0200, Kirill A. Shutemov wrote: On Wed, Jan 20, 2010 at 1:56 AM, Juan Quintela quint...@redhat.com wrote: From: Kirill A. Shutemov kir...@shutemov.name CC    block/vvfat.o cc1: warnings being treated as errors block/vvfat.c: In function

Re: [Qemu-devel] [PATCH] Add definitions for current cpu models..

2010-01-20 Thread Daniel P. Berrange
On Wed, Jan 20, 2010 at 03:09:53PM -0500, john cooper wrote: Anthony Liguori wrote: On 01/19/2010 02:03 PM, Chris Wright wrote: * Anthony Liguori (anth...@codemonkey.ws) wrote: I'm very much against having -cpu Nehalem. The whole point of this is to make things easier for a user and

Re: [Qemu-devel] [PATCH 0/4] Introduce global config (v3)

2010-01-25 Thread Daniel P. Berrange
On Sun, Jan 24, 2010 at 04:10:35PM +0100, Paolo Bonzini wrote: On 01/24/2010 04:04 PM, Avi Kivity wrote: On 01/24/2010 04:22 PM, Anthony Liguori wrote: This series introduces global config files stored in /etc/qemu. There is both a common config (qemu.conf) and a per-target config

Re: [Qemu-devel] Re: [PATCH] win32: use PRId64 instead of %lld

2010-01-25 Thread Daniel P. Berrange
On Mon, Jan 25, 2010 at 07:47:56PM +0200, Michael S. Tsirkin wrote: On Mon, Jan 25, 2010 at 06:32:06PM +0100, Stefan Weil wrote: Michael S. Tsirkin schrieb: On Sun, Jan 24, 2010 at 09:23:41PM +, Herve Poussineau wrote: Replace %lld occurrences by PRId64. This is wrong. long

Re: [Qemu-devel] Re: [PATCH] win32: use PRId64 instead of %lld

2010-01-26 Thread Daniel P. Berrange
On Tue, Jan 26, 2010 at 06:58:32AM -0600, Anthony Liguori wrote: On 01/26/2010 06:46 AM, Michael S. Tsirkin wrote: Yes, I agree we are comnpliant. But I also think we should be strict and reject non-JSON input just so that clients do not come to depend on it. If we can make JSON better

[Qemu-devel] Re: KVM call agenda for Jan 26

2010-01-26 Thread Daniel P. Berrange
On Tue, Jan 26, 2010 at 03:24:50PM +0200, Avi Kivity wrote: On 01/26/2010 03:18 PM, Alexander Graf wrote: The main question is where does it belong? a) built into qemu b) built as separate tool, but shipped with qemu c) completely separate I'm personally leaning towards a. That way we

Re: [Qemu-devel] [RFC 00/11]: QMP feature negotiation support

2010-01-26 Thread Daniel P. Berrange
On Tue, Jan 26, 2010 at 12:57:54PM +, Jamie Lokier wrote: Luiz Capitulino wrote: capability_enable [ foo, bar ] Now, only one command is not terrible difficult, but we would have to accept an array of objects, like: [ { name: foo, enabled: true }, { name: bar, enabled: true } ]

Re: [Qemu-devel] Converting existing name=value,... arguments to QMP

2010-02-04 Thread Daniel P. Berrange
On Thu, Feb 04, 2010 at 06:43:22PM +0100, Markus Armbruster wrote: The human monitor uses positional arguments. This is fine; nobody wants to type info item=network instead of info network. QMP uses named arguments. Also fine. Internally, we use named arguments: we pass them as QDict to

[Qemu-devel] Re: Two QMP events issues

2010-02-08 Thread Daniel P. Berrange
On Mon, Feb 08, 2010 at 11:41:45AM -0200, Luiz Capitulino wrote: Hi there, I have two not so related QMP events issues two discuss, but I will talk about them in the same email to avoid starting two threads. The first problem is wrt the STOP event. Right now it's only emitted if

Re: [Qemu-devel] Re: Two QMP events issues

2010-02-08 Thread Daniel P. Berrange
On Mon, Feb 08, 2010 at 08:49:20AM -0600, Anthony Liguori wrote: On 02/08/2010 08:12 AM, Daniel P. Berrange wrote: For further backgrou, the key end goal here is that in a QMP client, upon receipt of the 'RESET' event, we need to reliably immediately determine why it occurred. eg

Re: [Qemu-devel] [PATCH] Fix hanging user monitor when using balloon command

2010-02-16 Thread Daniel P. Berrange
On Fri, Feb 12, 2010 at 02:55:56PM -0600, Adam Litke wrote: Arghh... Adding missing S-O-B Hi Anthony. I wonder if there was a problem when importing my async command handler patchset. Since the 'balloon' command completes immediately, it must call the completion callback before returning.

Re: [Qemu-devel] [PATCH] bdrv_flush error handling

2008-02-20 Thread Daniel P. Berrange
On Wed, Feb 20, 2008 at 03:53:46PM +, Ian Jackson wrote: Content-Description: message body text bdrv_flush is declared to return void, but this is wrong because it means that the implementations have nowhere to report their errors. Indeed, the implementations generally ignore errors.

Re: [Qemu-devel] [PATCH] bdrv_flush error handling

2008-02-20 Thread Daniel P. Berrange
On Wed, Feb 20, 2008 at 04:31:56PM +, Jamie Lokier wrote: Ian Jackson wrote: Paul Brook writes (Re: [Qemu-devel] [PATCH] bdrv_flush error handling): Disk full is a fundamentally unfriendly situation to be in. There is no good answer. Reporting errors back to the host has its own

Re: [Qemu-devel] [PATCH] bdrv_flush error handling

2008-02-21 Thread Daniel P. Berrange
On Thu, Feb 21, 2008 at 12:19:22PM -0500, Ben Taylor wrote: Daniel P. Berrange [EMAIL PROTECTED] wrote: On Wed, Feb 20, 2008 at 03:53:46PM +, Ian Jackson wrote: Content-Description: message body text bdrv_flush is declared to return void, but this is wrong because it means

Re: [Qemu-devel] [PATCH] bdrv_flush error handling

2008-02-21 Thread Daniel P. Berrange
On Thu, Feb 21, 2008 at 11:28:23AM -0600, [EMAIL PROTECTED] wrote: On Thu, Feb 21, 2008 at 05:24:10PM +, Daniel P. Berrange wrote: On Thu, Feb 21, 2008 at 12:19:22PM -0500, Ben Taylor wrote: Also, in block-raw-posix.c, raw_pwrite et al seem to return -1 on error (the return value

Re: [Qemu-devel] Re: qemu unchecked block read/write vulnerability

2008-02-26 Thread Daniel P. Berrange
On Tue, Feb 19, 2008 at 04:39:07PM +, Ian Jackson wrote: Content-Description: message body text I was doing some merging of qemu and I noticed that the block driver backends don't check the guest's read/write attempts against the nominal size of the block device. I haven't checked all of

Re: [Qemu-devel] Re: qemu unchecked block read/write vulnerability

2008-02-26 Thread Daniel P. Berrange
On Tue, Feb 26, 2008 at 07:46:51PM +, Daniel P. Berrange wrote: On Tue, Feb 19, 2008 at 04:39:07PM +, Ian Jackson wrote: Content-Description: message body text I was doing some merging of qemu and I noticed that the block driver backends don't check the guest's read/write attempts

Re: [kvm-devel] [Qemu-devel] [PATCH] use a thread id variable

2008-03-09 Thread Daniel P. Berrange
On Sun, Mar 09, 2008 at 11:26:43AM +0200, Gilad Ben-Yossef wrote: Glauber Costa wrote: This patch introduces a thread_id variable to CPUState. It's duty will be to hold the process, or more generally, thread id of the current executing cpu env-nb_watchpoints = 0; +#ifdef __WIN32

Re: [Qemu-devel] [PATCH 7/9] qdev: Use QError for not found error

2009-10-19 Thread Daniel P. Berrange
On Wed, Oct 14, 2009 at 12:34:21AM +0200, Markus Armbruster wrote: Luiz Capitulino lcapitul...@redhat.com writes: Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- hw/qdev.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c

Re: [Qemu-devel] Re: [PATCH 6/9] QError: Add qdev not found error

2009-10-19 Thread Daniel P. Berrange
On Fri, Oct 16, 2009 at 10:05:44AM -0300, Luiz Capitulino wrote: On Fri, 16 Oct 2009 10:06:10 +0200 Paolo Bonzini pbonz...@redhat.com wrote: On 10/16/2009 12:44 AM, Hollis Blanchard wrote: How about this (basically what Paolo suggested): { error: { code: 12, desc:

Re: [Qemu-devel] [PATCH 7/9] qdev: Use QError for not found error

2009-10-19 Thread Daniel P. Berrange
On Mon, Oct 19, 2009 at 12:40:08PM +0200, Gerd Hoffmann wrote: I think just returning error codes to the client is far too little information. I don't think we need the fully normalized structure that Luiz originally proposed with bus/dev addresses split out, but we certainly need to include a

Re: [Qemu-devel] Re: [PATCH 6/9] QError: Add qdev not found error

2009-10-19 Thread Daniel P. Berrange
On Mon, Oct 19, 2009 at 10:28:17AM -0200, Luiz Capitulino wrote: On Mon, 19 Oct 2009 11:25:19 +0100 Daniel P. Berrange berra...@redhat.com wrote: On Fri, Oct 16, 2009 at 10:05:44AM -0300, Luiz Capitulino wrote: On Fri, 16 Oct 2009 10:06:10 +0200 Paolo Bonzini pbonz...@redhat.com wrote

Re: [Qemu-devel] [PATCH 7/9] qdev: Use QError for not found error

2009-10-19 Thread Daniel P. Berrange
On Mon, Oct 19, 2009 at 09:00:33AM -0500, Anthony Liguori wrote: Daniel P. Berrange wrote: hink just returning error codes to the client is far too little information. I don't think we need the fully normalized structure that Luiz originally proposed with bus/dev addresses split out, but we

Re: [Qemu-devel] [PATCH] new SDL keyboard shortcuts to start and stop VM

2009-10-20 Thread Daniel P. Berrange
On Tue, Oct 20, 2009 at 10:16:09AM +0700, Mulyadi Santosa wrote: Hi Anthony... On Tue, Oct 20, 2009 at 5:20 AM, Anthony Liguori anth...@codemonkey.ws wrote: Mulyadi Santosa wrote: IMO, it would be faster if we provide keyboard shortcuts that will stop and resume VM execution right

Re: [Qemu-devel] [PATCH] new SDL keyboard shortcuts to start and stop VM

2009-10-20 Thread Daniel P. Berrange
On Tue, Oct 20, 2009 at 12:40:08PM +0200, Kevin Wolf wrote: Am 20.10.2009 00:20, schrieb Anthony Liguori: Mulyadi Santosa wrote: IMO, it would be faster if we provide keyboard shortcuts that will stop and resume VM execution right from SDL guest interface, rather than switching to console

Re: [Qemu-devel] [PATCH 02/11] Add support for qfloat

2009-10-23 Thread Daniel P. Berrange
On Fri, Oct 23, 2009 at 08:25:49PM +0100, Jamie Lokier wrote: Anthony Liguori wrote: It really doesn't matter in the context of LGPL so I don't mind if we do 2.1 only. Is LGPL 2.1 compatible with LGPL 3 or GPL 3? It would be a shame if it's compatible enough to use in libvirt but

Re: [Qemu-devel] [PATCH 07/10] Introduce QError

2009-11-18 Thread Daniel P. Berrange
On Tue, Nov 17, 2009 at 05:43:54PM -0200, Luiz Capitulino wrote: QError is a high-level data type which represents an exception in QEMU, it stores the following error information: - class Error class name (eg. ServiceUnavailable) - descriptionA detailed error description, which

Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting

2009-11-23 Thread Daniel P. Berrange
On Mon, Nov 23, 2009 at 04:10:48PM +0100, Gerd Hoffmann wrote: On 11/23/09 14:26, Paul Brook wrote: I thinking more that this should be done by the character backend itself. For example, the graphical consoles should probably be putting this as part of the window title Doesn't work

Re: [Qemu-devel] [PATCH 17/17] VNC: Convert do_info_vnc() to QObject

2009-11-24 Thread Daniel P. Berrange
On Mon, Nov 23, 2009 at 06:06:23PM -0200, Luiz Capitulino wrote: Return a QDict with server information. Connected clients are returned as a QList of QDicts. The new functions (vnc_qdict_remote_addr(), vnc_qdict_local_addr() and put_addr_qdict()) are used to insert 'host' and 'service'

Re: [Qemu-devel] [PATCH v1 00/20] QEMU Monitor Protocol

2009-12-01 Thread Daniel P. Berrange
On Thu, Nov 26, 2009 at 10:58:50PM -0200, Luiz Capitulino wrote: Hi, This series has a number of improvements over v0 and is a serious candidate for inclusion. Something I'd like to make clear is that QMP is still unstable: some commands output are being fixed and most of the error

Re: [Qemu-devel] [PATCH] Disk image shared and exclusive locks.

2009-12-07 Thread Daniel P. Berrange
On Fri, Dec 04, 2009 at 11:15:12AM -0600, Anthony Liguori wrote: Richard W.M. Jones wrote: [from the commit message ...] Allow qemu to acquire shared and exclusive locks on disk images. This is done by extending the -drive option with an additional, optional parameter: -drive

Re: [Qemu-devel] [PATCH] Disk image shared and exclusive locks.

2009-12-07 Thread Daniel P. Berrange
On Mon, Dec 07, 2009 at 10:31:28AM +, Jamie Lokier wrote: Anthony Liguori wrote: I'm not sure whether it's best to enable it by default because, as I said earlier, I'm not comfortable with the lack of correctness wrt advisory vs. mandatory locking. In my experience, disk images are

Re: [Qemu-devel] [PATCH] Disk image shared and exclusive locks.

2009-12-07 Thread Daniel P. Berrange
On Mon, Dec 07, 2009 at 11:19:54AM +, Jamie Lokier wrote: Daniel P. Berrange wrote: Sometimes shared access to a raw image (partitioned or whole disk filesystem) is ok, and sometimes it is not ok. Only the user knows the difference, because only the user knows if the guests

Re: [Qemu-devel] [PATCH] Disk image shared and exclusive locks.

2009-12-07 Thread Daniel P. Berrange
On Mon, Dec 07, 2009 at 11:31:47AM +, Richard W.M. Jones wrote: On Mon, Dec 07, 2009 at 11:30:14AM +, Daniel P. Berrange wrote: On Mon, Dec 07, 2009 at 11:19:54AM +, Jamie Lokier wrote: No, the question is whether it makes sense to provide a 'shared' option on the command

Re: [Qemu-devel] [PATCH] Disk image shared and exclusive locks.

2009-12-07 Thread Daniel P. Berrange
On Mon, Dec 07, 2009 at 11:28:34AM +, Jamie Lokier wrote: Kevin Wolf wrote: Am 07.12.2009 11:31, schrieb Jamie Lokier: So the distinction read/write makes more sense. Can anyone think of a situation where a shared lock on an image opened for writing is useful? I think there are

Re: [Qemu-devel] [PATCH] Disk image shared and exclusive locks.

2009-12-07 Thread Daniel P. Berrange
On Mon, Dec 07, 2009 at 07:43:53AM -0600, Anthony Liguori wrote: Daniel P. Berrange wrote: That doesn't work in the case of setting up a clustered filesystem shared between guests. That requires that the disk be opened writable, but with a shared (F_RDLOCK) lock. If you'd like data

Re: [Qemu-devel] [PATCH] Disk image shared and exclusive locks.

2009-12-07 Thread Daniel P. Berrange
On Mon, Dec 07, 2009 at 08:15:51AM -0600, Anthony Liguori wrote: Daniel P. Berrange wrote: Better to stick with on/off. That gives much easier to understand semantics. The 3rd invocation is not changing the backing file, so it is not causing data corruption on the master file. Sure

Re: [Qemu-devel] [ANNOUNCE][Call-For-Testing] Release 0.12.0-rc1 of QEMU

2009-12-07 Thread Daniel P. Berrange
On Sun, Dec 06, 2009 at 04:43:03PM -0600, Anthony Liguori wrote: It can be downloaded from Savannah at: http://download.savannah.gnu.org/releases/qemu/qemu-0.12.0-rc1.tar.gz Please send testing feedback (positive or negative) to qemu-devel and file bugs against the release candidate at:

Re: [Qemu-devel] [ANNOUNCE][Call-For-Testing] Release 0.12.0-rc1 of QEMU

2009-12-07 Thread Daniel P. Berrange
On Mon, Dec 07, 2009 at 01:43:01PM -0600, Anthony Liguori wrote: Daniel P. Berrange wrote: On Sun, Dec 06, 2009 at 04:43:03PM -0600, Anthony Liguori wrote: It can be downloaded from Savannah at: http://download.savannah.gnu.org/releases/qemu/qemu-0.12.0-rc1.tar.gz Please send testing

[Qemu-devel] [PATCH] Fix backcompat for hotplug of SCSI controllers

2009-12-07 Thread Daniel P. Berrange
and it breaks compatability with existing QEMU usage, so remove the check for presence of a drive. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- hw/pci-hotplug.c |6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/hw/pci-hotplug.c b/hw/pci-hotplug.c index 081d6d1

Re: [Qemu-devel] [ANNOUNCE][Call-For-Testing] Release 0.12.0-rc1 of QEMU

2009-12-08 Thread Daniel P. Berrange
On Tue, Dec 08, 2009 at 11:40:54AM +0100, Gerd Hoffmann wrote: On 12/07/09 19:34, Daniel P. Berrange wrote: On Sun, Dec 06, 2009 at 04:43:03PM -0600, Anthony Liguori wrote: It can be downloaded from Savannah at: http://download.savannah.gnu.org/releases/qemu/qemu-0.12.0-rc1.tar.gz

Re: [Qemu-devel] Re: [FOR 0.12 PATCH 18/18] QMP: add human-readable description to error response

2009-12-08 Thread Daniel P. Berrange
On Tue, Dec 08, 2009 at 10:11:48AM -0200, Luiz Capitulino wrote: On Mon, 7 Dec 2009 21:37:16 +0100 Markus Armbruster arm...@redhat.com wrote: -{ error: { class: json-string, data: json-value }, id: json-value } +{ error: { class: json-string, data: json-value, desc: json-string }, +

Re: [Qemu-devel] Re: [FOR 0.12 PATCH v3 10/21] default devices: add global cmd line option.

2009-12-08 Thread Daniel P. Berrange
On Tue, Dec 08, 2009 at 11:11:29AM -0500, Paolo Bonzini wrote: Add global command line option to disable default devices. Should -readconfig imply this? Hmm, not sure. Why do you think this would be useful? Here is my thinking: if you used -writeconfig, your machine description

Re: [Qemu-devel] [ANNOUNCE][Call-For-Testing] Release 0.12.0-rc1 of QEMU

2009-12-09 Thread Daniel P. Berrange
On Tue, Dec 08, 2009 at 02:07:29PM +0100, Gerd Hoffmann wrote: On 12/08/09 13:52, Gerd Hoffmann wrote: The latter. The guest does not see it, but it at least does not abort. It is the 'does not abort' behaviour I'm interested in - quite OK with this returning an error to the monitor client

Re: [Qemu-devel] [ANNOUNCE][Call-For-Testing] Release 0.12.0-rc1 of QEMU

2009-12-09 Thread Daniel P. Berrange
On Sun, Dec 06, 2009 at 04:43:03PM -0600, Anthony Liguori wrote: The QEMU team is pleased to announce the availability of the 0.12.0-rc1 release. This is the first release candidate for the 0.12.0 release. This release is not intended for production use. Testing release candidates is a

Re: [Qemu-devel] [PATCH 19/19] VNC: Convert do_info_vnc() to QObject

2009-12-10 Thread Daniel P. Berrange
On Thu, Dec 10, 2009 at 09:56:06AM -0200, Luiz Capitulino wrote: On Thu, 10 Dec 2009 11:34:37 +0100 Markus Armbruster arm...@redhat.com wrote: +/** + * do_info_vnc(): Show VNC server information + * + * Return a QDict with server information. Connected clients are returned + *

Re: [Qemu-devel] [ANNOUNCE][Call-For-Testing] Release 0.12.0-rc1 of QEMU

2009-12-10 Thread Daniel P. Berrange
On Thu, Dec 10, 2009 at 10:22:24AM +0100, Gerd Hoffmann wrote: On 12/09/09 17:56, Daniel P. Berrange wrote: There's a small bug in SCSI drive hotplug where QEMU is not assigning unique block device names when you leave the name unspecified $ /home/berrange/usr/qemu-0.12/bin/qemu -vnc :1

Re: [Qemu-devel] [PATCH] QMP: Introduce WATCHDOG event

2010-02-26 Thread Daniel P. Berrange
On Thu, Feb 25, 2010 at 12:13:04PM -0300, Luiz Capitulino wrote: It's emitted whenever the watchdog device's timer expires. The action taken is provided in the 'data' member. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- QMP/qmp-events.txt | 19 +++

Re: [Qemu-devel] wake-on-lan IPMI implementation; real power-off and -no-shutdown

2010-03-15 Thread Daniel P. Berrange
On Mon, Mar 15, 2010 at 04:01:27PM +0100, Fran?ois Revol wrote: Hello, while working on a demonstrator for a green-IT project, to show scheduled machine shutdown and powering depending on various conditions, I wondered if I could use QEMU with wake-on-lan transparently, but it seems it's not

[Qemu-devel] Re: KVM call agenda for Mar 16

2010-03-16 Thread Daniel P. Berrange
On Tue, Mar 16, 2010 at 10:18:03AM +0100, Juan Quintela wrote: Chris Wright chr...@redhat.com wrote: Please send in any agenda items you are interested in covering. Migration: - flexible migration: I hope to sent an RFC patch on time for the call. idea is to use subsections. -

[Qemu-devel] Re: KVM call agenda for Mar 16

2010-03-16 Thread Daniel P. Berrange
On Tue, Mar 16, 2010 at 09:29:44AM +, Daniel P. Berrange wrote: On Tue, Mar 16, 2010 at 10:18:03AM +0100, Juan Quintela wrote: Chris Wright chr...@redhat.com wrote: Please send in any agenda items you are interested in covering. Migration: - flexible migration: I hope to sent

[Qemu-devel] Re: KVM call agenda for Mar 16

2010-03-16 Thread Daniel P. Berrange
On Tue, Mar 16, 2010 at 12:38:02PM +0200, Avi Kivity wrote: On 03/16/2010 12:31 PM, Daniel P. Berrange wrote: Polling loops are an indication that something is wrong. Except when people suggest they are the right answer, qcow high watermark ;-P I liked Anthony's suggestion

[Qemu-devel] Re: KVM call agenda for Mar 16

2010-03-16 Thread Daniel P. Berrange
On Tue, Mar 16, 2010 at 11:43:48AM +0200, Avi Kivity wrote: On 03/16/2010 11:29 AM, Daniel P. Berrange wrote: On Tue, Mar 16, 2010 at 10:18:03AM +0100, Juan Quintela wrote: Chris Wrightchr...@redhat.com wrote: Please send in any agenda items you are interested in covering

Re: [Qemu-devel] wake-on-lan IPMI implementation; real power-off and -no-shutdown

2010-03-16 Thread Daniel P. Berrange
On Tue, Mar 16, 2010 at 05:28:51PM +, Jamie Lokier wrote: The semantics of -no-shutdown are awful. I'd personally prefer to see the option deprecated and a new set of options introduced with clearer semantics. Currently, -no-shutdown does too many things. It affects reboot

[Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-22 Thread Daniel P. Berrange
On Mon, Mar 22, 2010 at 02:25:00PM -0500, Anthony Liguori wrote: Hi, I've mentioned this to a few folks already but I wanted to start a proper thread. We're struggling in qemu with usability and one area that concerns me is the disparity in features that are supported by qemu vs what's

Re: [Qemu-devel] Supporting hypervisor specific APIs in libvirt

2010-03-22 Thread Daniel P. Berrange
On Mon, Mar 22, 2010 at 02:25:00PM -0500, Anthony Liguori wrote: Hi, I've mentioned this to a few folks already but I wanted to start a proper thread. We're struggling in qemu with usability and one area that concerns me is the disparity in features that are supported by qemu vs what's

[Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-23 Thread Daniel P. Berrange
On Mon, Mar 22, 2010 at 04:49:21PM -0500, Anthony Liguori wrote: On 03/22/2010 03:10 PM, Daniel P. Berrange wrote: This isn't necessarily libvirt's problem if it's mission is to provide a common hypervisor API that covers the most commonly used features. That is more or less our current

Re: [Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-23 Thread Daniel P. Berrange
On Tue, Mar 23, 2010 at 11:06:20AM -0500, Anthony Liguori wrote: On 03/23/2010 10:57 AM, Paul Brook wrote: I think there is a serious divergence of approach there, instanciating API stating 'we are gonna deprecate them sooner or later' tell the application developper 'my time is more important

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-23 Thread Daniel P. Berrange
On Tue, Mar 23, 2010 at 08:00:21PM +0200, Avi Kivity wrote: On 03/23/2010 06:06 PM, Anthony Liguori wrote: I thought the monitor protocol *was* our API. If not, why not? It is. But our API is missing key components like guest enumeration. So the fundamental topic here is, do we introduce

[Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-24 Thread Daniel P. Berrange
On Mon, Mar 22, 2010 at 04:49:21PM -0500, Anthony Liguori wrote: On 03/22/2010 03:10 PM, Daniel P. Berrange wrote: This isn't necessarily libvirt's problem if it's mission is to provide a common hypervisor API that covers the most commonly used features. That is more or less our current

Re: [Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-24 Thread Daniel P. Berrange
On Wed, Mar 24, 2010 at 07:17:26AM +0200, Avi Kivity wrote: On 03/23/2010 08:00 PM, Avi Kivity wrote: On 03/23/2010 06:06 PM, Anthony Liguori wrote: I thought the monitor protocol *was* our API. If not, why not? It is. But our API is missing key components like guest enumeration. So the

Re: [Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-25 Thread Daniel P. Berrange
On Thu, Mar 25, 2010 at 08:26:09AM +, Vincent Hanquez wrote: On 24/03/10 21:40, Anthony Liguori wrote: If so, what C clients you expected beyond libvirt? Users want a C API. I don't agree that libvirt is the only C interface consumer out there. (I've seen this written too many times

Re: [Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-25 Thread Daniel P. Berrange
On Thu, Mar 25, 2010 at 02:56:52PM +, Vincent Hanquez wrote: On Thu, Mar 25, 2010 at 01:59:22PM +, Daniel P. Berrange wrote: From my point of view, i wouldn't want to write a high level management toolstack in C, specially since the API is well defined JSON which is easily

Re: [Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-25 Thread Daniel P. Berrange
On Thu, Mar 25, 2010 at 03:14:24PM +, Vincent Hanquez wrote: On Thu, Mar 25, 2010 at 03:07:20PM +, Daniel P. Berrange wrote: I agree apps shouldn't use it for RPC, but admins using the interactive user monitor are just as deserving of stable commands args. I think, once QMP

[Qemu-devel] Re: [PATCH 0/4] monitor: Convert do_set_link() to QObject, QError

2010-03-25 Thread Daniel P. Berrange
On Wed, Mar 24, 2010 at 04:20:53PM -0300, Luiz Capitulino wrote: On Tue, 23 Mar 2010 11:27:54 +0100 Markus Armbruster arm...@redhat.com wrote: PATCH 3/4 changes syntax of set_link's second argument from up|down to on|off. I feel that the argument needs to be boolean in QMP, and this is

[Qemu-devel] [PATCH] Remove magic numbers for VNC message IDs from code

2010-03-31 Thread Daniel P. Berrange
The code processing incoming sending outgoing messages from/to clients used embedded magic numbers for all message IDs. This made the code a little hard to follow. Add constants in the vnc.h header file for all message IDs and use them in the code Signed-off-by: Daniel P. Berrange berra

Re: [Qemu-devel] [PATCH] Remove magic numbers for VNC message IDs from code

2010-03-31 Thread Daniel P. Berrange
On Wed, Mar 31, 2010 at 12:07:51PM -0500, Anthony Liguori wrote: On 03/31/2010 11:45 AM, Daniel P. Berrange wrote: diff --git a/vnc.h b/vnc.h index 0a7487b..8752de0 100644 --- a/vnc.h +++ b/vnc.h @@ -276,6 +276,57 @@ enum { #define VNC_FEATURE_COPYRECT_MASK(1

[Qemu-devel] [PATCH] Remove magic numbers for VNC message IDs from code

2010-03-31 Thread Daniel P. Berrange
The code processing incoming sending outgoing messages from/to clients used embedded magic numbers for all message IDs. This made the code a little hard to follow. Add constants in the vnc.h header file for all message IDs and use them in the code Signed-off-by: Daniel P. Berrange berra

[Qemu-devel] Re: libvirt vs. in-qemu management

2010-04-06 Thread Daniel P. Berrange
On Mon, Apr 05, 2010 at 11:11:48PM +0200, Alexander Graf wrote: Howdy, I've been thinking a bit further on the whole issue around libvirt and why the situation as is isn't satisfying. I came to the following points that currently hurt building ease of use for KVM: 1) Brand This is

[Qemu-devel] Re: libvirt vs. in-qemu management

2010-04-06 Thread Daniel P. Berrange
On Tue, Apr 06, 2010 at 01:14:36AM +0300, Avi Kivity wrote: On 04/06/2010 12:11 AM, Alexander Graf wrote: I can imagine 1) going away if we would set libvirt + virt-manager as _the_ front-end and have everyone focus on it. I suppose it would also help to rebrand it by then, but I'm not

[Qemu-devel] Re: libvirt vs. in-qemu management

2010-04-06 Thread Daniel P. Berrange
On Tue, Apr 06, 2010 at 02:49:23PM +0200, Alexander Graf wrote: Daniel P. Berrange wrote: On Tue, Apr 06, 2010 at 01:14:36AM +0300, Avi Kivity wrote: On 04/06/2010 12:11 AM, Alexander Graf wrote: I can imagine 1) going away if we would set libvirt + virt-manager as _the_

[Qemu-devel] Re: libvirt vs. in-qemu management

2010-04-06 Thread Daniel P. Berrange
On Tue, Apr 06, 2010 at 02:43:47PM +0200, Alexander Graf wrote: Daniel P. Berrange wrote: With appliances there are two core aspects 1. The description of VM hardware requirements 2. The disk format Traditionally VMware appliances have shipped a VMX file for 1. and a VMDK file

[Qemu-devel] Re: libvirt vs. in-qemu management

2010-04-06 Thread Daniel P. Berrange
On Tue, Apr 06, 2010 at 03:53:16PM +0200, Alexander Graf wrote: Daniel P. Berrange wrote: If instead there was a common machine description file that everyone knows, there'd be a single point of knowledge. A RHEL-V admin could work on plain qemu. A qemu developer would feel right at home

[Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-09 Thread Daniel P. Berrange
On Fri, Apr 09, 2010 at 09:41:39AM -0400, Chris Lalancette wrote: Hello, In response to a lot of the talk of qemud lately on qemu-devel, the libvirt community would like to put forward a proposal to help enable debug/advanced options when using various hypervisors. The goals of this API

Re: [Qemu-devel] race condition when exec'ing qemu -incoming followed by monitor cont

2010-04-09 Thread Daniel P. Berrange
On Fri, Apr 09, 2010 at 12:03:54PM -0400, Laine Stump wrote: (Please forgive (and correct!) any inaccuracies in my description of qemu's workings - I've only recently started looking at it directly, rather than through the lens of libvirt) libvirt implements a domain restore operation by:

[Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-12 Thread Daniel P. Berrange
On Fri, Apr 09, 2010 at 02:16:06PM -0400, Chris Lalancette wrote: On 04/09/2010 10:27 AM, Daniel P. Berrange wrote: Raw access to the qemu monitor will be disabled by default; the monitorpassthrough/ tag enables the ability to send QMP (or text, if you are using older qemu) messages

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-12 Thread Daniel P. Berrange
On Sun, Apr 11, 2010 at 11:17:38PM +0100, Jamie Lokier wrote: Richard W.M. Jones wrote: On Fri, Apr 09, 2010 at 10:06:51PM +0100, Jamie Lokier wrote: Daniel P. Berrange wrote: I think this alteration of existing args is fr too complex fragile, and way overkill. Would

Re: [libvirt] [Qemu-devel] Re: Libvirt debug API

2010-04-12 Thread Daniel P. Berrange
On Mon, Apr 12, 2010 at 01:23:08PM +0100, Jamie Lokier wrote: Daniel Veillard wrote: On Sun, Apr 11, 2010 at 11:17:38PM +0100, Jamie Lokier wrote: Parsing libvirt output and having to guess which option corresponds to what from the libvirt config sounds very fragile and also a rather

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-12 Thread Daniel P. Berrange
On Mon, Apr 12, 2010 at 09:56:50AM -0400, Chris Lalancette wrote: On 04/12/2010 08:41 AM, Daniel P. Berrange wrote: I don't think there's much to be gained from having an XML element to turn on/off use of these APIs. If an app doesn't want to use them, it can simply not link to libvirt

Re: [Qemu-devel] [FOR 0.12][PATCH] monitor: Accept input only byte-wise

2010-04-16 Thread Daniel P. Berrange
On Fri, Dec 04, 2009 at 02:05:29PM +0100, Jan Kiszka wrote: This allows to suspend command interpretation and execution synchronously, e.g. during migration. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- monitor.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

[Qemu-devel] Re: [FOR 0.12][PATCH] monitor: Accept input only byte-wise

2010-04-16 Thread Daniel P. Berrange
On Fri, Apr 16, 2010 at 01:14:11PM +0200, Paolo Bonzini wrote: The QEMU code appears to be written to assume that it will recvmsg() a complete monitor command in one go + process that, because it closes the FD the moment the data from any recvmsg() is dealt with. This is buggy anyway.

Re: [Qemu-devel] [PATCH 07/22] qemu-error: Introduce get_errno_string()

2010-04-21 Thread Daniel P. Berrange
On Tue, Apr 20, 2010 at 06:09:37PM -0300, Luiz Capitulino wrote: There are error handling functions in QEMU which print errno codes to the user. While it's debatable if this is good from a user perspective, sometimes it's the best you can do because it's what system calls return and this is

Re: [Qemu-devel] [PATCH 07/22] qemu-error: Introduce get_errno_string()

2010-04-21 Thread Daniel P. Berrange
On Wed, Apr 21, 2010 at 12:12:14PM -0300, Luiz Capitulino wrote: On Wed, 21 Apr 2010 18:42:38 +0400 (MSD) malc av1...@comtv.ru wrote: On Wed, 21 Apr 2010, Kevin Wolf wrote: Am 21.04.2010 10:28, schrieb Daniel P. Berrange: On Tue, Apr 20, 2010 at 06:09:37PM -0300, Luiz Capitulino

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-23 Thread Daniel P. Berrange
On Thu, Apr 22, 2010 at 01:45:27PM -0500, Anthony Liguori wrote: On 04/09/2010 09:27 AM, Daniel P. Berrange wrote: On Fri, Apr 09, 2010 at 09:41:39AM -0400, Chris Lalancette wrote: domain type='kvm' namemyguest/name ... debug monitorpassthrough/ commandline

Re: [libvirt] [Qemu-devel] Re: Libvirt debug API

2010-04-23 Thread Daniel P. Berrange
On Thu, Apr 22, 2010 at 01:47:55PM -0500, Anthony Liguori wrote: On 04/12/2010 07:23 AM, Jamie Lokier wrote: Daniel Veillard wrote: On Sun, Apr 11, 2010 at 11:17:38PM +0100, Jamie Lokier wrote: It's not that hard to write this for trivial extra options: emulator/bin/sh -c

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-23 Thread Daniel P. Berrange
On Fri, Apr 23, 2010 at 08:40:49AM -0500, Anthony Liguori wrote: On 04/23/2010 05:28 AM, Daniel P. Berrange wrote: On Thu, Apr 22, 2010 at 01:45:27PM -0500, Anthony Liguori wrote: On 04/09/2010 09:27 AM, Daniel P. Berrange wrote: On Fri, Apr 09, 2010 at 09:41:39AM -0400, Chris

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-23 Thread Daniel P. Berrange
On Fri, Apr 23, 2010 at 08:48:51AM -0500, Anthony Liguori wrote: On 04/23/2010 07:48 AM, Avi Kivity wrote: On 04/22/2010 09:49 PM, Anthony Liguori wrote: real API. Say, adding a device libvirt doesn't know about or stopping the VM while libvirt thinks it's still running or anything like

Re: [libvirt] [Qemu-devel] Re: Libvirt debug API

2010-04-23 Thread Daniel P. Berrange
On Fri, Apr 23, 2010 at 05:24:34PM +0300, Avi Kivity wrote: On 04/23/2010 04:48 PM, Anthony Liguori wrote: On 04/23/2010 07:48 AM, Avi Kivity wrote: On 04/22/2010 09:49 PM, Anthony Liguori wrote: real API. Say, adding a device libvirt doesn't know about or stopping the VM while libvirt

Re: [Qemu-devel] [PATCH] make /usr/bin/qemu the native arch

2007-07-08 Thread Daniel P. Berrange
On Sun, Jul 08, 2007 at 02:21:02PM +0200, Robert Millan wrote: Hi, Shouldn't /usr/bin/qemu be an alias for qemu-system-$(ARCH), where $(ARCH) is the native architecture? Defaulting to i386 doesn't make much sense nowadays, specially since x86_64 is gradually obsoleting it. Management

Re: [Qemu-devel] [PATCH] make /usr/bin/qemu the native arch

2007-07-08 Thread Daniel P. Berrange
On Sun, Jul 08, 2007 at 06:04:51PM +0100, Ricardo Almeida wrote: On 7/8/07, Daniel P. Berrange [EMAIL PROTECTED] wrote: On Sun, Jul 08, 2007 at 02:21:02PM +0200, Robert Millan wrote: Shouldn't /usr/bin/qemu be an alias for qemu-system-$(ARCH), where $(ARCH) is the native architecture

Re: [Qemu-devel] Crash: When Host HDD is full

2007-07-12 Thread Daniel P. Berrange
On Thu, Jul 12, 2007 at 07:12:58PM +0300, Avi Kivity wrote: Mike Swanson wrote: On Wednesday 11 July 2007 08:19:48 Alexey Eremenko wrote: Problem 1: When Host HDD is full, all guests simply crash. Tried with dynamically growing .VMDK hard disk. It shouldn't happen. For example, both

[Qemu-devel] PATCH: Ensure RTL 8139 MMIO regions are 4k apart

2007-07-16 Thread Daniel P. Berrange
The current QEMU code for the RTL-8193 network device has some issues if there is more than one device activated in a guest. Specifically, even if you specify difference MAC addresses, inside the guest all NICs end up seeing the same MAC - the MAC of the last NIC. Full details are recorded in

Re: [Qemu-devel] PATCH: Ensure RTL 8139 MMIO regions are 4k apart

2007-07-16 Thread Daniel P. Berrange
On Mon, Jul 16, 2007 at 06:07:18PM +0100, Paul Brook wrote: The hw/rtl8139.c code is passing 0x100 in as the size parameter for the cpu_register_physical_memory call, despite the fact that the API contract says size has to be a multiple of page size. Have you tried recent CVS? This

[Qemu-devel] Re: [kvm-devel] [RFC][PATCH 00/01]qemu VM entrypoints

2007-07-20 Thread Daniel P. Berrange
On Fri, Jul 20, 2007 at 05:57:29PM -0400, David Windsor wrote: On 7/20/07, James Morris [EMAIL PROTECTED] wrote: On Fri, 20 Jul 2007, Daniel P. Berrange wrote: It could be - if your put the policy at the control API layer instead of in QEMU itself. I think that libvirt may be a bit too

Re: [Qemu-devel] [PATCH] smoother sdl display mouse

2007-07-24 Thread Daniel P. Berrange
On Tue, Jul 24, 2007 at 07:50:30PM +0200, Jindrich Makovicka wrote: Hi, the attached patch modifies the SDL display refresh code so the mouse and keyboard events are processed each 10 ms instead of 30. This causes much better mouse behavior due to lower latency. By default, display is

[Qemu-devel] PATCH 0/8: Authentication support for the VNC server

2007-07-31 Thread Daniel P. Berrange
The current VNC server implementation does not have support for the authentication of incoming client connections. The following series of patches provide support for a number of alternatives, all compliant with the VNC protocol spec. The simplest mechanism (and the weakest) is the traditional VNC

Re: [Qemu-devel] PATCH 1/8: Refactor VNC server setup API

2007-07-31 Thread Daniel P. Berrange
This patch splits the vnc_display_init function into two parts, the resulting vnc_display_init function merely initializes a little state. The new vnc_display_open function is responsible for starting the server. This refactoring is in preparation for the next patch. diff -r cdd882fa7018 vl.c ---

Re: [Qemu-devel] PATCH 2/8: Extend monitor 'change' command for VNC

2007-07-31 Thread Daniel P. Berrange
This patch extends the QEMU monitor 'change' command so that it can be used to change the configuration of the VNC server. On the command line the user can use -vnc none, and then issue the 'change vnc :1' command later from the monitor. This is utilized in the next patch to let the monitor fetch

Re: [Qemu-devel] PATCH 3/8: VNC password authentication

2007-07-31 Thread Daniel P. Berrange
This patch introduces support for VNC protocols upto 3.8 and with it, support for password based authentication. VNC's password based authentication is not entirely secure, but it is a standard and the RFB spec requires that all clients support it. The password can be provided by using the monitor

Re: [Qemu-devel] PATCH 4/8: VeNCrypt basic TLS support

2007-07-31 Thread Daniel P. Berrange
This patch introduces minimal support for the VeNCrypt protocol extension. This layers use of TLS (aka SSL) into the VNC data stream, providing session encryption. This patch is the bare minimum protocol support. It is enabled by using the 'tls' option flag eg -vnc :1,tls' This is not secure on

<    1   2   3   4   5   6   7   8   9   10   >