Questions about "QEMU gives wrong MPIDR value for Arm CPU types with MT=1" (gitlab issue #1608)

2024-04-13 Thread Dorjoy Chowdhury
Hi, Hope everyone is doing well. I was looking at "Bite Sized" tagged QEMU issues in gitlab to see if there is anything that makes sense for me as a first time contributor. I see this issue "QEMU gives wrong MPIDR value for Arm CPU types with MT=1" (gitlab URL:

[PATCH] target/arm: fix MPIDR value for ARM CPUs with SMT

2024-04-19 Thread Dorjoy Chowdhury
- neoverse-n1 - neoverse-n2 Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1608 Signed-off-by: Dorjoy Chowdhury --- hw/arm/npcm7xx.c | 2 +- hw/arm/sbsa-ref.c | 21 - hw/arm/virt.c | 18 +++--- target/arm/cpu.c | 14

Re: [PATCH] target/arm: fix MPIDR value for ARM CPUs with SMT

2024-04-21 Thread Dorjoy Chowdhury
On Sun, Apr 21, 2024 at 11:40 AM Richard Henderson wrote: > > On 4/19/24 11:31, Dorjoy Chowdhury wrote: > > + > > +/* > > + * Instantiate a temporary CPU object to build mp_affinity > > + * of the possible CPUs. > > + */ > > +cpuobj =

Re: Questions about "QEMU gives wrong MPIDR value for Arm CPU types with MT=1" (gitlab issue #1608)

2024-04-15 Thread Dorjoy Chowdhury
On Mon, Apr 15, 2024 at 5:35 PM Peter Maydell wrote: > > On Sat, 13 Apr 2024 at 20:59, Dorjoy Chowdhury wrote: > > > > Hi, > > Hope everyone is doing well. I was looking at "Bite Sized" tagged QEMU > > issues in gitlab to see if there is anything tha

Re: [PATCH] target/arm: fix MPIDR value for ARM CPUs with SMT

2024-04-25 Thread Dorjoy Chowdhury
On Mon, Apr 22, 2024 at 5:26 PM Peter Maydell wrote: > > On Mon, 22 Apr 2024 at 11:46, Peter Maydell wrote: > > > > On Sun, 21 Apr 2024 at 06:40, Richard Henderson > > wrote: > > > > --- a/target/arm/cpu.c > > > > +++ b/target/arm/cpu.c > > > > @@ -1314,8 +1314,18 @@ static void

Re: [PATCH] target/arm: fix MPIDR value for ARM CPUs with SMT

2024-05-03 Thread Dorjoy Chowdhury
On Fri, May 3, 2024 at 10:28 PM Peter Maydell wrote: > > On Fri, 19 Apr 2024 at 19:31, Dorjoy Chowdhury wrote: > > > > Some ARM CPUs advertise themselves as SMT by having the MT[24] bit set > > to 1 in the MPIDR register. These CPUs have the thread id in Aff0[7:0] >

Re: [PATCH] target/arm: fix MPIDR value for ARM CPUs with SMT

2024-05-03 Thread Dorjoy Chowdhury
On Fri, May 3, 2024 at 10:28 PM Peter Maydell wrote: > > On Fri, 19 Apr 2024 at 19:31, Dorjoy Chowdhury wrote: > > > > Some ARM CPUs advertise themselves as SMT by having the MT[24] bit set > > to 1 in the MPIDR register. These CPUs have the thread id in Aff0[7:0] >

Re: [PATCH] target/arm: fix MPIDR value for ARM CPUs with SMT

2024-05-02 Thread Dorjoy Chowdhury
On Thu, May 2, 2024 at 6:14 PM Marcin Juszkiewicz wrote: > > W dniu 19.04.2024 o 20:31, Dorjoy Chowdhury pisze: > > -uint64_t arm_build_mp_affinity(int idx, uint8_t clustersz) > > +uint64_t arm_build_mp_affinity(ARMCPU *cpu, int idx, uint8_t clustersz) > > { &

[PATCH] hw/arm/npcm7xx: remove setting of mp-affinity

2024-05-04 Thread Dorjoy Chowdhury
The value of the mp-affinity property being set in npcm7xx_realize is always the same as the default value it would have when arm_cpu_realizefn is called if the property is not set here. So there is no need to set the property value in npcm7xx_realize function. Signed-off-by: Dorjoy Chowdhury

Re: [PATCH] target/arm: fix MPIDR value for ARM CPUs with SMT

2024-05-04 Thread Dorjoy Chowdhury
On Sat, May 4, 2024 at 7:31 PM Peter Maydell wrote: > > On Fri, 3 May 2024 at 19:14, Dorjoy Chowdhury wrote: > > > > On Fri, May 3, 2024 at 10:28 PM Peter Maydell > > wrote: > > > In the meantime, there is one tiny bit of this that we can > > >

[PATCH v1 0/2] AWS Nitro Enclave emulation support

2024-05-18 Thread Dorjoy Chowdhury
.md Dorjoy Chowdhury (2): machine/microvm: support for loading EIF image machine/nitro-enclave: new machine type for AWS nitro enclave MAINTAINERS | 10 + configs/devices/i386-softmmu/default.mak | 1 + docs/system/i386/nitro-enclave.rst | 58 +++ hw/i

[PATCH v1 2/2] machine/nitro-enclave: new machine type for AWS nitro enclave

2024-05-18 Thread Dorjoy Chowdhury
://docs.aws.amazon.com/enclaves/latest/user/nitro-enclave.html [2] https://aws.amazon.com/ec2/ Signed-off-by: Dorjoy Chowdhury --- MAINTAINERS | 10 ++ configs/devices/i386-softmmu/default.mak | 1 + docs/system/i386/nitro-enclave.rst | 58 ++ hw/i386/Kconfig

[PATCH v1 1/2] machine/microvm: support for loading EIF image

2024-05-18 Thread Dorjoy Chowdhury
-format [2] https://aws.amazon.com/ec2/nitro/nitro-enclaves/ Signed-off-by: Dorjoy Chowdhury --- hw/i386/eif.c | 486 hw/i386/eif.h | 20 ++ hw/i386/meson.build | 2 +- hw/i386/microvm.c | 134 +++- 4 files changed, 640 insertions

Re: [PATCH v1 0/2] AWS Nitro Enclave emulation support

2024-05-18 Thread Dorjoy Chowdhury
Hi, I just noticed the reference URL for number [4] in my cover-letter is incorrect. On Sat, May 18, 2024 at 2:08 PM Dorjoy Chowdhury wrote: > > Hi, > > Hope everyone is doing well. I am working on adding AWS Nitro Enclave[1] > emulation support in QEMU. Alexander Graf

Re: [PATCH v1 1/2] machine/microvm: support for loading EIF image

2024-05-27 Thread Dorjoy Chowdhury
Hi Philippe, Thank you for reviewing. On Mon, May 27, 2024 at 4:47 PM Philippe Mathieu-Daudé wrote: > > Hi Dorjoy, > > On 18/5/24 10:07, Dorjoy Chowdhury wrote: > > An EIF (Enclave Image Format)[1] image is used to boot an AWS nitro > > enclave[2] virtual machin

Re: [PATCH v1 1/2] machine/microvm: support for loading EIF image

2024-05-27 Thread Dorjoy Chowdhury
Hey Alex, On Mon, May 27, 2024 at 9:51 PM Alexander Graf wrote: > > > On 27.05.24 16:52, Dorjoy Chowdhury wrote: > > Hi Philippe, > > Thank you for reviewing. > > > > On Mon, May 27, 2024 at 4:47 PM Philippe Mathieu-Daudé > > wrote: > >> Hi Dorj

Re: [PATCH v1 1/2] machine/microvm: support for loading EIF image

2024-05-22 Thread Dorjoy Chowdhury
Hi Daniel, Thanks for reviewing. On Wed, May 22, 2024 at 9:32 PM Daniel P. Berrangé wrote: > > On Sat, May 18, 2024 at 02:07:52PM +0600, Dorjoy Chowdhury wrote: > > An EIF (Enclave Image Format)[1] image is used to boot an AWS nitro > > enclave[2] virtual machine. The

Re: [PATCH] target/arm: fix MPIDR value for ARM CPUs with SMT

2024-05-31 Thread Dorjoy Chowdhury
Hi Peter, On Fri, May 31, 2024, 6:53 PM Peter Maydell wrote: > On Fri, 3 May 2024 at 17:53, Dorjoy Chowdhury > wrote: > > > > On Fri, May 3, 2024 at 10:28 PM Peter Maydell > wrote: > > > > > > On Fri, 19 Apr 2024 at 19:31, Dorjoy Chowdhury > wrot