Re: [PATCH v15 02/11] s390x/cpu topology: add topology entries on CPU hotplug

2023-02-02 Thread Nina Schoetterl-Glausch
On Wed, 2023-02-01 at 14:20 +0100, Pierre Morel wrote: > The topology information are attributes of the CPU and are > specified during the CPU device creation. > > On hot plug we: > - calculate the default values for the topology for drawers, > books and sockets in the case they are not

Re: [PATCH v20 06/21] s390x/cpu topology: interception of PTF instruction

2023-05-04 Thread Nina Schoetterl-Glausch
TOPOLOGY KVM extension. > > The PTF instructions with function code 0 and 1 are intercepted > and must be emulated by the userland hypervisor. > > During RESET all CPU of the configuration are placed in > horizontal polarity. > > Signed-off-by: Pierre Morel Reviewed-by: Nin

Re: [PATCH v21 16/20] tests/avocado: s390x cpu topology entitlement tests

2023-07-12 Thread Nina Schoetterl-Glausch
On Wed, 2023-07-05 at 12:22 +0200, Thomas Huth wrote: > On 30/06/2023 11.17, Pierre Morel wrote: > > This test takes care to check the changes on different entitlements > > when the guest requests a polarization change. > > > > Signed-off-by: Pierre Morel > > --- > >  

Re: [PATCH v21 14/20] tests/avocado: s390x cpu topology core

2023-07-12 Thread Nina Schoetterl-Glausch
-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch > --- [...] > diff --git a/tests/avocado/s390_topology.py > b/tests/avocado/s390_topology.py > new file mode 100644 > index 00..1758ec1f13 > --- /dev/null > +++ b/tests/avocado/s390_topology.py > @@ -0

Re: [PATCH v21 11/20] qapi/s390x/cpu topology: CPU_POLARIZATION_CHANGE qapi event

2023-07-18 Thread Nina Schoetterl-Glausch
e Morel Reviewed-by: Nina Schoetterl-Glausch

Re: [PATCH v21 08/20] qapi/s390x/cpu topology: set-cpu-topology qmp command

2023-07-18 Thread Nina Schoetterl-Glausch
ty to optimize the > usage of the vCPUs. > > The command has a feature unstable for the moment. > > Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch

Re: [PATCH v21 01/20] s390x/cpu topology: add s390 specifics to CPU topology

2023-07-18 Thread Nina Schoetterl-Glausch
Reviewed-by: Nina Schoetterl-Glausch Some notes below. The s390x/ prefix in the title might suggest that this patch is s390 specific, but it touches common files. On Fri, 2023-06-30 at 11:17 +0200, Pierre Morel wrote: > S390 adds two new SMP levels, drawers and books to the CPU > to

Re: [PATCH v21 16/20] tests/avocado: s390x cpu topology entitlement tests

2023-07-14 Thread Nina Schoetterl-Glausch
On Wed, 2023-07-12 at 22:11 +0200, Thomas Huth wrote: > On 12/07/2023 21.37, Nina Schoetterl-Glausch wrote: > > On Wed, 2023-07-05 at 12:22 +0200, Thomas Huth wrote: > > > On 30/06/2023 11.17, Pierre Morel wrote: > > > > This test takes care to check the changes on

Re: [PATCH v21 16/20] tests/avocado: s390x cpu topology entitlement tests

2023-07-19 Thread Nina Schoetterl-Glausch
On Wed, 2023-07-19 at 16:08 +0200, Pierre Morel wrote: > > On 7/14/23 18:30, Nina Schoetterl-Glausch wrote: > > On Wed, 2023-07-12 at 22:11 +0200, Thomas Huth wrote: > > > On 12/07/2023 21.37, Nina Schoetterl-Glausch wrote: > > > > On Wed, 2023-07-05

Re: [PATCH v20 15/21] tests/avocado: s390x cpu topology polarisation

2023-05-22 Thread Nina Schoetterl-Glausch
Try to be consistent in the spelling of polarization. You use an s in the title and in the test name below. On Tue, 2023-04-25 at 18:14 +0200, Pierre Morel wrote: > Polarization is changed on a request from the guest. > Let's verify the polarization is accordingly set by QEMU. > > Signed-off-by:

Re: [PATCH v20 14/21] tests/avocado: s390x cpu topology core

2023-05-22 Thread Nina Schoetterl-Glausch
On Tue, 2023-04-25 at 18:14 +0200, Pierre Morel wrote: > Introduction of the s390x cpu topology core functions and > basic tests. > > We test the corelation between the command line and > the QMP results in query-cpus-fast for various CPU topology. > > Signed-off-by: Pierre Morel > --- >

Re: [PATCH v20 16/21] tests/avocado: s390x cpu topology entitlement tests

2023-05-22 Thread Nina Schoetterl-Glausch
On Tue, 2023-04-25 at 18:14 +0200, Pierre Morel wrote: > This test takes care to check the changes on different entitlements > when the guest requests a polarization change. > > Signed-off-by: Pierre Morel > --- > tests/avocado/s390_topology.py | 56 ++ > 1 file

Re: [PATCH v21 03/20] target/s390x/cpu topology: handle STSI(15) and build the SYSIB

2023-07-25 Thread Nina Schoetterl-Glausch
On Fri, 2023-06-30 at 11:17 +0200, Pierre Morel wrote: > On interception of STSI(15.1.x) the System Information Block > (SYSIB) is built from the list of pre-ordered topology entries. > > Signed-off-by: Pierre Morel > --- > MAINTAINERS | 1 + > qapi/machine-target.json

Re: [PATCH v21 05/20] s390x/cpu topology: resetting the Topology-Change-Report

2023-07-25 Thread Nina Schoetterl-Glausch
f-by: Pierre Morel > Reviewed-by: Thomas Huth Reviewed-by: Nina Schoetterl-Glausch

Re: [PATCH v21 01/20] s390x/cpu topology: add s390 specifics to CPU topology

2023-07-24 Thread Nina Schoetterl-Glausch
On Fri, 2023-07-21 at 13:24 +0200, Pierre Morel wrote: > > On 7/18/23 18:31, Nina Schoetterl-Glausch wrote: > > Reviewed-by: Nina Schoetterl-Glausch > > > > Some notes below. > > > > The s390x/ prefix in the title might suggest that this patch > > is

Re: [PATCH v21 12/20] qapi/s390x/cpu topology: query-cpu-polarization qmp command

2023-07-26 Thread Nina Schoetterl-Glausch
On Fri, 2023-06-30 at 11:17 +0200, Pierre Morel wrote: > The query-cpu-polarization qmp command returns the current > CPU polarization of the machine. > > Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch [...]

Re: [PATCH v21 03/20] target/s390x/cpu topology: handle STSI(15) and build the SYSIB

2023-07-27 Thread Nina Schoetterl-Glausch
On Fri, 2023-06-30 at 11:17 +0200, Pierre Morel wrote: > On interception of STSI(15.1.x) the System Information Block > (SYSIB) is built from the list of pre-ordered topology entries. > > Signed-off-by: Pierre Morel > --- > MAINTAINERS | 1 + > qapi/machine-target.json

Re: [PATCH v21 02/20] s390x/cpu topology: add topology entries on CPU hotplug

2023-07-24 Thread Nina Schoetterl-Glausch
t; still get some advantage of the CPU topology. > > Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch if you address Thomas' comments.

Re: [PATCH] git-submodule.sh: allow running in validate mode without previous update

2023-06-20 Thread Nina Schoetterl-Glausch
> for all submodules passed on the command line. > > With this change, "ignore" mode is not needed anymore. > > Reported-by: Nina Schoetterl-Glausch > Fixes: b11f9bd96f4 ("configure: move SLOF submodule handling to > pc-bios/s390-ccw", 2023-06-06) > Signed-off-

Re: [PATCH] git-submodule.sh: allow running in validate mode without previous update

2023-06-21 Thread Nina Schoetterl-Glausch
On Tue, 2023-06-20 at 22:44 +0200, Paolo Bonzini wrote:        > Il mar 20 giu 2023, 19:35 Nina Schoetterl-Glausch ha > scritto: > > > +            modules="$modules $m" > > > +            grep $m $substat > /dev/null 2>&1 || $GIT submodule status &

Re: [PATCH] git-submodule.sh: allow running in validate mode without previous update

2023-06-21 Thread Nina Schoetterl-Glausch
On Wed, 2023-06-21 at 16:07 +0200, Nina Schoetterl-Glausch wrote: > On Tue, 2023-06-20 at 22:44 +0200, Paolo Bonzini wrote:        > > Il mar 20 giu 2023, 19:35 Nina Schoetterl-Glausch ha > > scritto: > > > > +            modules="$modules $m" > > >

Re: [PATCH v2] git-submodule.sh: allow running in validate mode without previous update

2023-06-23 Thread Nina Schoetterl-Glausch
> for all submodules passed on the command line. > > With this change, "ignore" mode is not needed anymore. > > Reported-by: Nina Schoetterl-Glausch > Fixes: b11f9bd96f4 ("configure: move SLOF submodule handling to > pc-bios/s390-ccw", 2023-06-06) Reviewed-by: Ni

Re: [PATCH 07/10] pc-bios/s390-ccw: always build network bootloader

2023-06-16 Thread Nina Schoetterl-Glausch
On Mon, 2023-06-05 at 11:52 +0200, Paolo Bonzini wrote: > In the beginning, the network bootloader was considered experimental and > thus optional, but it is well established nowadays and configure always > checks for roms/SLOF before compiling pc-bios/s390-ccw. Only if run in a git repository,

Re: [PATCH v20 10/21] machine: adding s390 topology to info hotpluggable-cpus

2023-05-08 Thread Nina Schoetterl-Glausch
On Tue, 2023-04-25 at 18:14 +0200, Pierre Morel wrote: > S390 topology adds books and drawers topology containers. > Let's add these to the HMP information for hotpluggable cpus. > > Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch if you fix the nits below. >

Re: [PATCH v20 12/21] qapi/s390x/cpu topology: query-cpu-polarization qmp command

2023-05-10 Thread Nina Schoetterl-Glausch
On Tue, 2023-04-25 at 18:14 +0200, Pierre Morel wrote: > The query-cpu-polarization qmp command returns the current > CPU polarization of the machine. > > Signed-off-by: Pierre Morel > --- > qapi/machine-target.json | 30 ++ > hw/s390x/cpu-topology.c | 14

Re: [PATCH v20 03/21] target/s390x/cpu topology: handle STSI(15) and build the SYSIB

2023-05-03 Thread Nina Schoetterl-Glausch
On Wed, 2023-05-03 at 10:43 +0200, Pierre Morel wrote: > On 5/2/23 19:22, Nina Schoetterl-Glausch wrote: > > On Tue, 2023-04-25 at 18:14 +0200, Pierre Morel wrote: > > > On interception of STSI(15.1.x) the System Information Block > > > (SYSIB) is built from the l

Re: [PATCH v20 08/21] qapi/s390x/cpu topology: set-cpu-topology qmp command

2023-05-08 Thread Nina Schoetterl-Glausch
On Tue, 2023-04-25 at 18:14 +0200, Pierre Morel wrote: > The modification of the CPU attributes are done through a monitor > command. > > It allows to move the core inside the topology tree to optimize > the cache usage in the case the host's hypervisor previously > moved the CPU. > > The same

Re: [PATCH v20 11/21] qapi/s390x/cpu topology: CPU_POLARIZATION_CHANGE qapi event

2023-05-08 Thread Nina Schoetterl-Glausch
On Tue, 2023-04-25 at 18:14 +0200, Pierre Morel wrote: > When the guest asks to change the polarization this change > is forwarded to the upper layer using QAPI. > The upper layer is supposed to take according decisions concerning > CPU provisioning. > > Signed-off-by: Pierre Morel > --- >

Re: [RFC] docs/s390: Fix wrong command example in s390-cpu-topology.rst

2023-11-27 Thread Nina Schoetterl-Glausch
s->len, which is equal to ms->smp.max_cpus. > > Fix the wrong "core-id" 112 because it is greater than maxcpus (36) in Maybe s/is greater/isn't less/ since the valid ids are 0-35 inclusive. > -smp. > > Cc: Nina Schoetterl-Glausch > Signed-off-by: Zhao Li

Re: question on s390x topology: KVM only, or also TCG?

2024-03-14 Thread Nina Schoetterl-Glausch
On Thu, 2024-03-14 at 16:54 +0100, Thomas Huth wrote: > On 14/03/2024 16.49, Claudio Fontana wrote: > > Hello Pierre, Ilya, > > > > I have a question on the s390x "topology" feature and examples. > > > > Mainly, is this feature supposed to be KVM accelerator-only, or also > > available when

Re: [PATCH] docs/s390: clarify even more that cpu-topology is KVM-only

2024-03-14 Thread Nina Schoetterl-Glausch
that we can point to, > whenever we need to reference accelerators and how to select them. > > Signed-off-by: Claudio Fontana Reviewed-by: Nina Schoetterl-Glausch Tested-by: Nina Schoetterl-Glausch (meaning I ran make html) > --- > docs/system/introduction.rst | 2 ++ > doc

Re: [PATCH] target/s390x: improve cpu compatibility check error message

2024-03-14 Thread Nina Schoetterl-Glausch
On Thu, 2024-03-14 at 20:00 +0100, Claudio Fontana wrote: > some users were confused by this message showing under TCG: > > Selected CPU generation is too new. Maximum supported model > in the configuration: 'xyz' > > Try to clarify that the maximum can depend on the accel by > adding also the

Re: [PATCH v2] target/s390x: improve cpu compatibility check error message

2024-03-15 Thread Nina Schoetterl-Glausch
dd a > hint to try a different one. > > Also add a hint for features mismatch to suggest trying > different accel, QEMU and kernel versions. > > Signed-off-by: Claudio Fontana Reviewed-by: Nina Schoetterl-Glausch > --- > target/s390x/cpu_models.c | 22 +++

Re: [PATCH 2/3] migration: Drop unnecessary check in ram's pending_exact()

2024-03-20 Thread Nina Schoetterl-Glausch
On Wed, 2024-01-17 at 15:58 +0800, pet...@redhat.com wrote: > From: Peter Xu > > When the migration frameworks fetches the exact pending sizes, it means > this check: > > remaining_size < s->threshold_size > > Must have been done already, actually at migration_iteration_run(): > > if

Re: [PATCH 2/3] migration: Drop unnecessary check in ram's pending_exact()

2024-03-20 Thread Nina Schoetterl-Glausch
I cc'ed Juan, but it looks like he is no longer with Redhat.

Re: [PATCH 2/3] migration: Drop unnecessary check in ram's pending_exact()

2024-03-20 Thread Nina Schoetterl-Glausch
On Wed, 2024-03-20 at 14:57 -0400, Peter Xu wrote: > On Wed, Mar 20, 2024 at 06:51:26PM +0100, Nina Schoetterl-Glausch wrote: > > On Wed, 2024-01-17 at 15:58 +0800, pet...@redhat.com wrote: > > > From: Peter Xu > > > > > > When the migration frameworks fetch

<    1   2   3