Re: [Qemu-devel] [PATCHv2 RFC] makefile: detect corrupted elf files

2013-05-22 Thread Stefan Weil
Am 22.05.2013 00:07, schrieb Michael S. Tsirkin: Once in a while make gets killed and doesn't clean up partial object files after it. Result is nasty errors from link. This hack checks object is well formed before linking, and rebuilds it if not. Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PATCH] Remove unnecessary break statements

2013-05-24 Thread Stefan Weil
. Signed-off-by: Stefan Weil s...@weilnetz.de --- hw/display/cirrus_vga.c |1 - hw/timer/exynos4210_mct.c|1 - target-arm/translate.c |1 - target-s390x/mem_helper.c|1 - target-unicore32/translate.c |1 - 5 files changed, 5 deletions(-) diff --git a/hw/display

Re: [Qemu-devel] [PATCH] Remove unnecessary break statements

2013-05-24 Thread Stefan Weil
Am 24.05.2013 14:33, schrieb Richard W.M. Jones: On Fri, May 24, 2013 at 12:19:25PM +0200, Stefan Weil wrote: Fix these warnings from cppcheck: hw/display/cirrus_vga.c:2603: hw/sd/sd.c:348: hw/timer/exynos4210_mct.c:1033: target-arm/translate.c:9886: target-s390x/mem_helper.c:518: target

Re: [Qemu-devel] Win32 QEMU binaries built from MinGW fail (access violation)

2013-05-25 Thread Stefan Weil
Am 25.05.2013 03:56, schrieb Dan: I've been trying to build QEMU source directly with MinGW. The compile/link works but there are tons of warnings (mostly Wformat). Once I try to run the binaries in Windows though, I quickly hit access violations once the HD image is mounted. I've tested on

Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files

2013-05-26 Thread Stefan Weil
Am 26.05.2013 14:31, schrieb Michael S. Tsirkin: On Sun, May 26, 2013 at 10:12:21AM +0100, Peter Maydell wrote: On 26 May 2013 08:35, Michael S. Tsirkin m...@redhat.com wrote: On Sat, May 25, 2013 at 05:32:24PM +, Blue Swirl wrote: Another way to handle this would be to enhance GCC and

Re: [Qemu-devel] [PATCH] qapi: pad GenericList value fields to 64 bits

2013-05-26 Thread Stefan Weil
Am 27.05.2013 05:20, schrieb Michael Roth: With the introduction of native list types, we now have types such as int64List where the 'value' field is not a pointer, but the actual 64-bit value. On 32-bit architectures, this can lead to situations where 'next' field offset in GenericList does

[Qemu-devel] [PATCH] audio: Replace macro GCC_ATTR by GCC_FMT_ATTR and use inline functions

2013-06-09 Thread Stefan Weil
GCC_ATTR was only used in audio_int.h, so it is now unused and the definition can be removed from compiler.h. Signed-off-by: Stefan Weil s...@weilnetz.de --- audio/audio_int.h |8 +++- include/qemu/compiler.h |3 --- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git

[Qemu-devel] [PATCH] i.MX31: Fix PRCS bit test

2013-06-09 Thread Stefan Weil
cppcheck detected a condition which was always false. According to the MCIMX31 Reference Manual, the PRCS bits have to be 01 to select the Frequency Pre-Multiplier (FPM). PRCS uses bits 1 and 2, so we have to test for 2. Signed-off-by: Stefan Weil s...@weilnetz.de --- hw/misc/imx_ccm.c |2

[Qemu-devel] [PATCH] xilinx_axienet: Fix bit mask code

2013-06-09 Thread Stefan Weil
Obviously the code wanted to mask the lower bits but failed to do so because of a missing . cppcheck detected a conditional expression which was always true (1 7). Signed-off-by: Stefan Weil s...@weilnetz.de --- Please review - I did not look for a Xilinx manual to see whether the code

[Qemu-devel] [PATCH] device tree: Fix cppcheck warning

2013-06-10 Thread Stefan Weil
Fix this cppcheck warning: Checking device_tree.c... device_tree.c:216: style: Checking if unsigned variable 'r' is less than zero. Signed-off-by: Stefan Weil s...@weilnetz.de --- device_tree.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/device_tree.c b/device_tree.c

[Qemu-devel] [PATCH] hw/scsi: Don't increment a boolean value

2013-06-10 Thread Stefan Weil
This fixes a warning from cppcheck. Signed-off-by: Stefan Weil s...@weilnetz.de --- hw/scsi/vmw_pvscsi.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c index 48d12f4..446f723 100644 --- a/hw/scsi/vmw_pvscsi.c +++ b/hw/scsi

[Qemu-devel] [PATCH] hw/xen: Use g_free instead of free and fix potential memory leaks

2013-06-10 Thread Stefan Weil
The wrong functions and the missing calls of g_free were reported by cppcheck. Signed-off-by: Stefan Weil s...@weilnetz.de --- hw/xen/xen_pt_config_init.c |4 ++-- xen-all.c |8 +--- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/hw/xen

[Qemu-devel] [PATCH] target-sparc: Replace free by g_free

2013-06-10 Thread Stefan Weil
The wrong function was reported by cppcheck. Signed-off-by: Stefan Weil s...@weilnetz.de --- target-sparc/cpu.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-sparc/cpu.c b/target-sparc/cpu.c index 290b580..13bb7bb 100644 --- a/target-sparc/cpu.c +++ b/target-sparc

Re: [Qemu-devel] [Qemu-trivial] [PATCH] audio: Replace macro GCC_ATTR by GCC_FMT_ATTR and use inline functions

2013-06-11 Thread Stefan Weil
Am 11.06.2013 14:38, schrieb Michael Tokarev: [Removing malc's email since it bounces] 09.06.2013 16:22, Stefan Weil wrote: GCC_ATTR was only used in audio_int.h, so it is now unused and the definition can be removed from compiler.h. Signed-off-by: Stefan Weil s...@weilnetz.de [snip

Re: [Qemu-devel] [PATCH] hw/xen: Use g_free instead of free and fix potential memory leaks

2013-06-11 Thread Stefan Weil
Am 11.06.2013 13:02, schrieb Stefano Stabellini: On Mon, 10 Jun 2013, Stefan Weil wrote: The wrong functions and the missing calls of g_free were reported by cppcheck. Signed-off-by: Stefan Weil s...@weilnetz.de Acked-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Are you happy

Re: [Qemu-devel] [Qemu-trivial] [PATCH] block: Remove unused assignment (fixes warning from clang)

2013-09-29 Thread Stefan Weil
Am 29.09.2013 21:44, schrieb Michael Tokarev: 28.09.2013 13:55, Stefan Weil wrote: [...] diff --git a/blockdev.c b/blockdev.c index 8aa66a9..8c83f6f 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1926,7 +1926,6 @@ void qmp_drive_mirror(const char *device, const char *target, } else

Re: [Qemu-devel] [Qemu-trivial] [PATCH] migration: Fix compiler warning ('caps' may be used uninitialized)

2013-09-29 Thread Stefan Weil
Am 29.09.2013 22:13, schrieb Michael Tokarev: 29.09.2013 19:41, Stefan Weil wrote: The QEMU buildbot default_i386_debian_6_0 shows this warning: CCmigration.o migration.c: In function 'qmp_query_migrate_capabilities': migration.c:149: warning: 'caps' may be used uninitialized

Re: [Qemu-devel] [Qemu-trivial] [PATCH] migration: Fix compiler warning ('caps' may be used uninitialized)

2013-09-30 Thread Stefan Weil
Am 30.09.2013 11:59, schrieb Markus Armbruster: Stefan Weil s...@weilnetz.de writes: Am 29.09.2013 22:13, schrieb Michael Tokarev: 29.09.2013 19:41, Stefan Weil wrote: The QEMU buildbot default_i386_debian_6_0 shows this warning: CCmigration.o migration.c: In function

[Qemu-devel] [PATCH] qemu-char: Fix potential out of bounds access to local arrays

2013-09-30 Thread Stefan Weil
. There is no obvious reason why width or height could need 8 characters, so reduce it to 7 characters which together with the terminating '\0' fit into the arrays. Cc: qemu-stable qemu-sta...@nongnu.org Signed-off-by: Stefan Weil s...@weilnetz.de --- This is not a critical error because only

Re: [Qemu-devel] [PATCH] coroutine: add ./configure --disable-coroutine-pool

2013-09-30 Thread Stefan Weil
Am 30.09.2013 11:06, schrieb Stefan Hajnoczi: On Fri, Sep 27, 2013 at 06:49:18PM +0200, Stefan Weil wrote: Am 27.09.2013 11:11, schrieb Stefan Hajnoczi: On Fri, Sep 27, 2013 at 07:20:21AM +0200, Stefan Weil wrote: Am 11.09.2013 16:42, schrieb Stefan Hajnoczi: The 'gthread' coroutine backend

Re: [Qemu-devel] [PATCH] coroutine: add ./configure --disable-coroutine-pool

2013-10-01 Thread Stefan Weil
Am 01.10.2013 09:29, schrieb Gabriel Kerneis: On Tue, Oct 01, 2013 at 07:51:24AM +0200, Stefan Weil wrote: $ wine i386-softmmu/qemu-system-i386 -L pc-bios -cdrom /var/tmp/mini.iso -sdl # or -vnc :1 = Assertion in qemu-coroutine-lock.c:99. Could you please provide the backtrace for this? I

Re: [Qemu-devel] [PATCH v5 0/5] Do not set SO_REUSEADDR on Windows

2013-10-01 Thread Stefan Weil
Am 01.10.2013 10:11, schrieb Sebastian Ottlik: On 23.09.2013 12:33, Sebastian Ottlik wrote: On 18.09.2013 18:58, Stefan Weil wrote: If failures only happen when something is very wrong (like an invalid socket id), an assertion might be better, and we could remove the 'silent' parameter

[Qemu-devel] [Bug 1233225] Re: mips/mipsel linux user float division problem

2013-10-01 Thread Stefan Weil
I can confirm that something is strange with MIPS Linux user emulation, but get a different result (which is also wrong): # Your test code is in file divtest.c. $ mipsel-linux-gnu-gcc-4.7 -g -static divtest.c $ mipsel-linux-user/qemu-mipsel a.out 0.00 Some more tests: printf(%f\n, a *

[Qemu-devel] [Bug 1233225] Re: mips/mipsel linux user float division problem

2013-10-01 Thread Stefan Weil
Here is the related commit found by git bisect: $ git bisect bad 68473f15d4c9948986618f63828825beafcaf1cf is the first bad commit commit 68473f15d4c9948986618f63828825beafcaf1cf Author: Richard Henderson r...@twiddle.net Date: Sun Feb 10 10:30:46 2013 -0800 mips64-linux-user: Enable 64-bit

Re: [Qemu-devel] [Bug 1233225] Re: mips/mipsel linux user float division problem

2013-10-01 Thread Stefan Weil
Am 01.10.2013 20:14, schrieb Stefan Weil: Here is the related commit found by git bisect: $ git bisect bad 68473f15d4c9948986618f63828825beafcaf1cf is the first bad commit commit 68473f15d4c9948986618f63828825beafcaf1cf Author: Richard Henderson r...@twiddle.net Date: Sun Feb 10 10:30:46

Re: [Qemu-devel] [Bug 1233225] Re: mips/mipsel linux user float division problem

2013-10-01 Thread Stefan Weil
Am 02.10.2013 03:39, schrieb Peter Maydell: On 2 October 2013 02:51, Stefan Weil 1233...@bugs.launchpad.net wrote: I can confirm that something is strange with MIPS Linux user emulation, but get a different result (which is also wrong): # Your test code is in file divtest.c. $ mipsel-linux

Re: [Qemu-devel] [PATCH] block/iscsi: reenable iscsi_co_get_block_status

2013-10-02 Thread Stefan Weil
.bdrv_co_discard = iscsi_co_discard, Reviewed-by: Stefan Weil s...@weilnetz.de

[Qemu-devel] [PULL 4/5] slirp: call socket_set_fast_reuse instead of setting SO_REUSEADDR

2013-10-02 Thread Stefan Weil
Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Stefan Weil s...@weilnetz.de --- slirp/misc.c |3 +-- slirp/socket.c |4 +--- slirp/tcp_subr.c |6 ++ slirp/udp.c |4 ++-- 4 files changed, 6 insertions(+), 11 deletions(-) diff --git a/slirp/misc.c b/slirp

[Qemu-devel] [PULL 0/5] net: Add and use new function socket_set_fast_reuse

2013-10-02 Thread Stefan Weil
The following changes since commit a684f3cf9b9b9c3cb82be87aafc463de8974610c: Merge remote-tracking branch 'kraxel/seabios-1.7.3.2' into staging (2013-09-30 17:15:27 -0500) are available in the git repository at: git://qemu.weilnetz.de/qemu.git mingw for you to fetch changes up to

[Qemu-devel] [PULL 2/5] gdbstub: call socket_set_fast_reuse instead of setting SO_REUSEADDR

2013-10-02 Thread Stefan Weil
Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Stefan Weil s...@weilnetz.de --- gdbstub.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 2b7f22b..0e5a3f5 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1553,7 +1553,7 @@ static void

[Qemu-devel] [PULL 1/5] util: add socket_set_fast_reuse function which will replace setting SO_REUSEADDR

2013-10-02 Thread Stefan Weil
and prevent unused variable warnings if NDEBUG is defined. Signed-off-by: Sebastian Ottlik ott...@fzi.de Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Stefan Weil s...@weilnetz.de --- include/qemu/sockets.h |1 + util/oslib-posix.c | 12 util/oslib-win32.c

[Qemu-devel] [PULL 3/5] net: call socket_set_fast_reuse instead of setting SO_REUSEADDR

2013-10-02 Thread Stefan Weil
where it is sensible to have multiple sockets listen on the same ip and port and we should set SO_REUSEADDR on windows. Signed-off-by: Sebastian Ottlik ott...@fzi.de Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Stefan Weil s...@weilnetz.de --- net/socket.c | 19

[Qemu-devel] [PULL 5/5] util: call socket_set_fast_reuse instead of setting SO_REUSEADDR

2013-10-02 Thread Stefan Weil
Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Stefan Weil s...@weilnetz.de --- util/qemu-sockets.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index 095716e..6b97dc1 100644 --- a/util/qemu-sockets.c +++ b/util/qemu

Re: [Qemu-devel] [PATCH v6 0/5] Do not set SO_REUSEADDR on Windows

2013-10-02 Thread Stefan Weil
Am 02.10.2013 14:28, schrieb Eric Blake: On 10/02/2013 04:23 AM, Sebastian Ottlik wrote: This patchset disables most uses of SO_REUSEADDR on Windows and replaces it with calls to the new function socket_set_fast_reuse. On Windows systems the default behaviour is equivalent to SO_REUSEADDR on

Re: [Qemu-devel] [Qemu-trivial] [PATCH] migration: Fix compiler warning ('caps' may be used uninitialized)

2013-10-02 Thread Stefan Weil
Am 02.10.2013 21:02, schrieb Michael Tokarev: How about this: diff --git a/migration.c b/migration.c index b4f8462..6066ab4 100644 --- a/migration.c +++ b/migration.c @@ -146,22 +146,16 @@ uint64_t migrate_max_downtime(void) MigrationCapabilityStatusList

[Qemu-devel] [PATCH] util/path: Fix type which is longer than 8 bit for MinGW

2013-10-02 Thread Stefan Weil
the other systems. MinGW-w32 is not affected: it does not declare d_type. Signed-off-by: Stefan Weil s...@weilnetz.de --- util/path.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/path.c b/util/path.c index f0c6962..623219e 100644 --- a/util/path.c +++ b/util

Re: [Qemu-devel] [PATCH] coroutine: add ./configure --disable-coroutine-pool

2013-10-02 Thread Stefan Weil
Am 02.10.2013 10:54, schrieb Stefan Hajnoczi: This is an interesting backtrace. The 'current' thread-local variable from coroutine-win32.c is NULL or doesn't have a caller assigned. Please post 'thread apply all bt' so we can identify the other threads. Stefan The other threads don't have

Re: [Qemu-devel] [Qemu-trivial] [PATCH] util/path: Fix type which is longer than 8 bit for MinGW

2013-10-05 Thread Stefan Weil
Am 05.10.2013 11:10, schrieb Michael Tokarev: 03.10.2013 00:40, Stefan Weil wrote: While dirent-d_type is 8 bit for most systems, it is 32 bit for MinGW. Reducing it to 8 bit results in a compiler warning because the macro is_dir_maybe compares that 8 bit value with 32 bit constants. Using

Re: [Qemu-devel] [Qemu-trivial] [PATCH] migration: Fix compiler warning ('caps' may be used uninitialized)

2013-10-05 Thread Stefan Weil
MIGRATION_CAPABILITY_MAX; i++) { if (head == NULL) { head = g_malloc0(sizeof(*caps)); Thanks, /mjt Reviewed-by: Stefan Weil s...@weilnetz.de

Re: [Qemu-devel] [PATCH] cpu-exec(): also reload CPUClass *cc after longjmp return

2013-10-05 Thread Stefan Weil
Am 05.10.2013 19:54, schrieb Juergen Lock: On Fri, Oct 04, 2013 at 09:15:37AM +0200, Jan Kiszka wrote: On 2013-10-03 18:05, Peter Maydell wrote: On 3 October 2013 23:09, Juergen Lock qem...@jelal.kn-bremen.de wrote: Local variable CPUClass *cc needs to be reloaded after return from longjmp

Re: [Qemu-devel] [PATCH] config-host.mak: escape configure arguments

2013-10-05 Thread Stefan Weil
Am 06.10.2013 00:18, schrieb Gabriel Kerneis: On Sun, Oct 06, 2013 at 12:54:08AM +0900, Peter Maydell wrote: So this sed script appears to convert literal newlines in the input Is that what's intended? Yes. It doesn't seem very useful because if you cut-n-paste (or pipe) 'hello\nworld' into

Re: [Qemu-devel] NBD support for mingw32 (windows)

2013-10-10 Thread Stefan Weil
Am 10.10.2013 10:52, schrieb Goshen, OrX: Hi, This patch adds support for NBD under mingw32. It contains a small hack with the use of Sleep(). signed-off-by: Goshen, OrX orx.gos...@intel.com mailto:orx.gos...@intel.com, Ocheretny, Pavel pavel.ochere...@intel.com

Re: [Qemu-devel] [PATCH] Use qemu-project.org domain name

2013-10-10 Thread Stefan Weil
Am 10.10.2013 11:39, schrieb Stefan Hajnoczi: qemu.org is held by a third-party and no core community contributor has access to the DNS configuration. This leaves the website exposed to outages due to DNS issues or IP address changes. For example, if the web server IP address needs to change

[Qemu-devel] [PATCH] misc: New spelling fixes in comments

2013-10-10 Thread Stefan Weil
compatiblity - compatibility continously - continuously existance - existence usefull - useful shoudl - should Signed-off-by: Stefan Weil s...@weilnetz.de --- block/iscsi.c|2 +- hw/ppc/spapr.c |2 +- target-alpha/translate.c |2 +- tests/test-throttle.c

Re: [Qemu-devel] [PATCH] Spelling fixes

2013-10-10 Thread Stefan Weil
Am 08.07.2013 17:14, schrieb Corentin Chary: The comments (and most of the code) are from libvncserver (and, earlier, from THE 'ZYWRLE' VNC CODEC SOURCE CODE. as described in the header):

Re: [Qemu-devel] [PATCH] Spelling fixes

2013-10-11 Thread Stefan Weil
Am 11.10.2013 03:34, schrieb Peter Maydell: On 11 October 2013 04:11, Stefan Weil s...@weilnetz.de wrote: Am 08.07.2013 17:14, schrieb Corentin Chary: The comments (and most of the code) are from libvncserver (and, earlier, from THE 'ZYWRLE' VNC CODEC SOURCE CODE. as described in the header

Re: [Qemu-devel] [PATCH] Use qemu-project.org domain name

2013-10-11 Thread Stefan Weil
Am 11.10.2013 09:55, schrieb Stefan Hajnoczi: On Thu, Oct 10, 2013 at 07:42:30PM +0200, Stefan Weil wrote: Am 10.10.2013 11:39, schrieb Stefan Hajnoczi: qemu.org is held by a third-party and no core community contributor has access to the DNS configuration. This leaves the website exposed

[Qemu-devel] [PATCH v2] misc: Spelling and other fixes in comments

2013-10-11 Thread Stefan Weil
* it's - its * Grammar fix in ui/vnc-enc-zywrle.h. In the same context a sentence with unclear meaning which could not be fixed was removed. Signed-off-by: Stefan Weil s...@weilnetz.de --- This is an update of patch http://patchwork.ozlabs.org/patch/257416/ (Spelling fixes). v2: Don't try

Re: [Qemu-devel] [PATCH v2] misc: Spelling and other fixes in comments

2013-10-11 Thread Stefan Weil
Am 11.10.2013 21:12, schrieb Peter Maydell: On 12 October 2013 04:06, Stefan Weil s...@weilnetz.de wrote: * it's - its * Grammar fix in ui/vnc-enc-zywrle.h. In the same context a sentence with unclear meaning which could not be fixed was removed. Signed-off-by: Stefan Weil s...@weilnetz.de

[Qemu-devel] [PATCH v3] misc: Spelling and grammar fixes in comments

2013-10-11 Thread Stefan Weil
* it's - its * grammar fix in ui/vnc-enc-zywrle.h Signed-off-by: Stefan Weil s...@weilnetz.de --- This is v3 of http://patchwork.ozlabs.org/patch/257416/. v3: Don't try to improve a strange sentence in the same context (Of cause [...]). qapi-schema.json|2 +- slirp/if.c

Re: [Qemu-devel] [PATCH v3] misc: Spelling and grammar fixes in comments

2013-10-11 Thread Stefan Weil
Am 11.10.2013 22:03, schrieb Don Koch: On 10/11/2013 03:34 PM, Stefan Weil wrote: * it's - its * grammar fix in ui/vnc-enc-zywrle.h Signed-off-by: Stefan Weil s...@weilnetz.de --- This is v3 of http://patchwork.ozlabs.org/patch/257416/. v3: Don't try to improve a strange sentence

Re: [Qemu-devel] [PATCH v2] net/net: Change the default mac address of nic

2013-10-14 Thread Stefan Weil
Am 15.10.2013 06:17, schrieb Mike Qiu: Changelog to v1: Find remainder of macaddr-a[5] by modulo 256, otherwise it may be overflow by add index++. The default mac address is 52:54:00:12:34:56 + index, this will cause problem that when we boot up more than one guest with all mac

Re: [Qemu-devel] [PATCH v2] net/net: Change the default mac address of nic

2013-10-15 Thread Stefan Weil
Am 15.10.2013 07:57, schrieb mike: On 10/15/2013 01:07 PM, Stefan Weil wrote: Am 15.10.2013 06:17, schrieb Mike Qiu: Changelog to v1: Find remainder of macaddr-a[5] by modulo 256, otherwise it may be overflow by add index++. The default mac address is 52:54:00:12:34:56 + index

Re: [Qemu-devel] [PULL 54/61] blockdev: Remove IF_* check for read-only blockdev_init

2013-10-15 Thread Stefan Weil
Am 11.10.2013 17:05, schrieb Kevin Wolf: IF_NONE allows read-only, which makes forbidding it in this place for other types pretty much pointless. Instead, make sure that all devices for which the check would have errored out check in their init function that they don't get a read-only

Re: [Qemu-devel] [PULL 54/61] blockdev: Remove IF_* check for read-only blockdev_init

2013-10-15 Thread Stefan Weil
Am 15.10.2013 17:59, schrieb Kevin Wolf: Am 15.10.2013 um 17:53 hat Stefan Weil geschrieben: Am 11.10.2013 17:05, schrieb Kevin Wolf: IF_NONE allows read-only, which makes forbidding it in this place for other types pretty much pointless. Instead, make sure that all devices for which

Re: [Qemu-devel] [Bug 1240669] Re: sd_init() generates SIGSEGV when passed NULL

2013-10-16 Thread Stefan Weil
Am 16.10.2013 22:10, schrieb Devin Boyer: ** Description changed: Ran into a bug following the following tutorial: - http://balau82.wordpress.com/2010/03/10/u-boot-for-arm-on-qemu/ + http://balau82.wordpress.com/2010/03/10/u-boot-for-arm-on-qemu/ I built QEMU from a clone of master

Re: [Qemu-devel] [Qemu-ppc] [PATCH V2] Fix float64_to_uint64

2013-10-17 Thread Stefan Weil
Am 17.10.2013 11:40, schrieb Alexander Graf: On 16.10.2013, at 23:10, Tom Musta tommu...@gmail.com wrote: The comment preceding the float64_to_uint64 routine suggests that the implementation is broken. And this is, indeed, the case. This patch properly implements the conversion of a 64-bit

[Qemu-devel] [PATCH] virtio: Remove unneeded memcpy

2013-10-17 Thread Stefan Weil
-blks, so it is a memcpy of 64 byte with source == destination which can be removed. Reported-by: Dave Airlie airl...@gmail.com Signed-off-by: Stefan Weil s...@weilnetz.de --- hw/block/virtio-blk.c |1 - 1 file changed, 1 deletion(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c

Re: [Qemu-devel] virtio-blk wierd memcpy

2013-10-17 Thread Stefan Weil
Am 17.10.2013 20:49, schrieb Dave Airlie: In my failing attempts to valgrind qemu (how to people live like this?), I spotted this in the logs ==19521== Source and destination overlap in memcpy(0x31d38938, 0x31d38938, 64) ==19521==at 0x4A0A343: memcpy@@GLIBC_2.14 (in

[Qemu-devel] [PATCH] configure: Add config.status to recreate the current configuration

2013-10-20 Thread Stefan Weil
. Makefile now uses config.status, but also includes transitional code for the old mechanism. Signed-off-by: Stefan Weil s...@weilnetz.de --- This patch still does not escape special characters in the command line. I expect that most users don't use such characters, so they have no problem. It's

Re: [Qemu-devel] [PATCH] MAINTAINERS: add block driver sub-maintainers

2013-10-21 Thread Stefan Weil
/MAINTAINERS index 77edacf..da18a23 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -857,3 +857,41 @@ Stable 0.10 L: qemu-sta...@nongnu.org T: git git://git.qemu-project.org/qemu-stable-0.10.git S: Orphan + +Block drivers +- [...] +VDI +M: Stefan Weil s...@weilnetz.de +S

Re: [Qemu-devel] [Qemu-trivial] [PATCH v3] misc: Spelling and grammar fixes in comments

2013-10-22 Thread Stefan Weil
Am 21.10.2013 10:46, schrieb Michael Tokarev: So guys, do we agree to apply this or not, after all? :) Thanks, /mjt The discussion was a bit confusing. Finally, the patch got two reviews (Reviewed-by: Peter Maydell peter.mayd...@linaro.org, Reviewed-By: Don Koch dk...@verizon.com, see

Re: [Qemu-devel] qemu 1.6.1

2013-10-23 Thread Stefan Weil
Am 23.10.2013 11:00, schrieb Paolo Bonzini: Il 23/10/2013 08:39, Michael W. Bombardieri ha scritto: Hi, My newly built qemu/win32 binary (v1.6.1) crashes in qemu-system-i386 and qemu-system-x86_64 when booting from an install CD. C:\Program Files\qemuqemu-system-x86_64 -boot d -vnc

Re: [Qemu-devel] qemu 1.6.1

2013-10-24 Thread Stefan Weil
Am 24.10.2013 12:38, schrieb Paolo Bonzini: Il 23/10/2013 21:26, Stefan Weil ha scritto: Am 23.10.2013 11:00, schrieb Paolo Bonzini: Il 23/10/2013 08:39, Michael W. Bombardieri ha scritto: Hi, My newly built qemu/win32 binary (v1.6.1) crashes in qemu-system-i386 and qemu-system-x86_64 when

Re: [Qemu-devel] qemu 1.6.1

2013-10-26 Thread Stefan Weil
Am 24.10.2013 23:47, schrieb Paolo Bonzini: Il 24/10/2013 17:37, Stefan Weil ha scritto: Yes, that works, too. It also fixes the problem with the assertion (tested with Wine). No, we cannot remove from_, because the same interface is also used for Linux and other hosts which don't have

Re: [Qemu-devel] qemu 1.6.1

2013-10-27 Thread Stefan Weil
Am 27.10.2013 07:54, schrieb Paolo Bonzini: Here is the code with annotations broken works - push %ebx sub$0x18,%espsub$0x1c,%esp

Re: [Qemu-devel] qemu 1.6.1

2013-10-27 Thread Stefan Weil
Am 27.10.2013 07:54, schrieb Paolo Bonzini: I think the problem is that 0x20(%esp) gets somehow corrupted at the instruction I highlighted with **. The simplest fix then would be to add a barrier() before and after SwitchToFiber. Paolo I added some debugging output (see code at

Re: [Qemu-devel] [PATCH] configure: Add config.status to recreate the current configuration

2013-10-28 Thread Stefan Weil
Am 20.10.2013 18:39, schrieb Stefan Weil: The latest configure invocation was saved in config-host.mak and could be extracted from that file to recreate the configuration. Now it is saved in a new file config.status which can be directly executed to recreate the configuration. The file name

Re: [Qemu-devel] [PATCH] cpu-exec: Fix compiler warning (-Werror=clobbered)

2013-10-28 Thread Stefan Weil
Am 18.09.2013 09:48, schrieb Jan Kiszka: On 2013-09-18 09:26, Peter Maydell wrote: [...] And gcc's documentation of the 'noreturn' attribute specifically says it does not affect the exceptional path where the function returns via longjmp. OK, that is the clarifying bit of information. Now

Re: [Qemu-devel] [PATCH] vl: fix build when configured with no graphic support

2013-10-28 Thread Stefan Weil
: +(void)ds; break; #if defined(CONFIG_CURSES) case DT_CURSES: Reviewed-by: Stefan Weil s...@weilnetz.de

[Qemu-devel] [PATCH v2] linux-user: Fix stat64 syscall for SPARC64

2013-10-30 Thread Stefan Weil
Some targets use a stat64 structure for the stat64 syscall while others use a stat structure. SPARC64 used the wrong kind. Instead of extending the conditional compilation in syscall.c, now a macro TARGET_HAS_STRUCT_STAT64 is defined whenever a target has a target_stat64. Signed-off-by: Stefan

[Qemu-devel] [PATCH v2] cpu-exec: Fix compiler warning (-Werror=clobbered)

2013-10-31 Thread Stefan Weil
, x 0 which does not need it but won't give warnings). There were bug reports for clang and gcc 4.5.0, while gcc 4.5.1 was reported to work fine without the reload code. Signed-off-by: Stefan Weil s...@weilnetz.de --- v2: Don't remove the code which causes the warnings, but use it only

Re: [Qemu-devel] [PATCH v2] cpu-exec: Fix compiler warning (-Werror=clobbered)

2013-10-31 Thread Stefan Weil
Am 31.10.2013 20:41, schrieb Jan Kiszka: On 2013-10-31 20:31, Stefan Weil wrote: Reloading of local variables after sigsetjmp is only needed for some buggy compilers. The code which should reload these variables causes compiler warnings with gcc 4.7 when compiler optimizations are enabled

Re: [Qemu-devel] [PATCH RFC] Do not set SO_REUSEADDR on Windows

2013-09-04 Thread Stefan Weil
Am 04.09.2013 16:41, schrieb Peter Maydell: On 4 September 2013 15:27, Paolo Bonzini pbonz...@redhat.com wrote: Il 04/09/2013 16:22, Sebastian Ottlik ha scritto: This patchset disabels all use of SO_REUSEADDR on Windows. On Windows systems the default behavior is equivalent to SO_REUSEADDR on

[Qemu-devel] [PATCH] tci: Add implementation of rotl_i64, rotr_i64

2013-09-04 Thread Stefan Weil
It is used by qemu-ppc64 when running Debian's busybox-static. Signed-off-by: Stefan Weil s...@weilnetz.de --- This patch is also useful for QEMU 1.6. tcg/tci/tcg-target.c |1 - tci.c| 10 +- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/tcg/tci

Re: [Qemu-devel] [PATCH] tci: Add implementation of rotl_i64, rotr_i64

2013-09-04 Thread Stefan Weil
Am 04.09.2013 22:49, schrieb Stefan Weil: It is used by qemu-ppc64 when running Debian's busybox-static. Signed-off-by: Stefan Weil s...@weilnetz.de --- This patch is also useful for QEMU 1.6. ... so I should have added qemu-stable. Done now. tcg/tci/tcg-target.c |1 - tci.c

Re: [Qemu-devel] [PATCH] tci: Add implementation of rotl_i64, rotr_i64

2013-09-05 Thread Stefan Weil
Am 05.09.2013 14:00, schrieb Jay Foad: diff --git a/tci.c b/tci.c index 18c888e..94b7851 100644 --- a/tci.c +++ b/tci.c @@ -952,8 +952,16 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr) break; #if TCG_TARGET_HAS_rot_i64 case INDEX_op_rotl_i64: +

[Qemu-devel] [Bug] qemu-sparc64 broken

2013-09-05 Thread Stefan Weil
Here is the result of running Debian's busybox-static for sparc64: $ sparc64-linux-user/qemu-sparc64 /usr/gnemul/qemu-sparc64/bin/busybox ls -l block.c ?rwxr-x--T1 stefan root 1378329541 Jan 1 1970 block.c It's obviously wrong. All other user emulations return the correct result: $

Re: [Qemu-devel] [Bug] qemu-sparc64 broken

2013-09-05 Thread Stefan Weil
Am 05.09.2013 23:32, schrieb Peter Maydell: On 5 September 2013 21:35, Stefan Weil s...@weilnetz.de wrote: In a first analysis of this, I noticed that it is impossible to run qemu-sparc64 under gdb (raised fatal signal). You probably just need to let the signals go through to the target... I

Re: [Qemu-devel] [PATCH] linux-user: Fix wrong use of stat instead of stat64 for sparc64

2013-09-06 Thread Stefan Weil
Am 06.09.2013 19:16, schrieb Peter Maydell: On 6 September 2013 17:46, Stefan Weil s...@weilnetz.de wrote: This test case is fixed now: sparc64-linux-user/qemu-sparc64 /usr/gnemul/qemu-sparc64/busybox ls -l block.c Signed-off-by: Stefan Weil s...@weilnetz.de --- linux-user/syscall.c

[Qemu-devel] [PATCH] linux-user: Fix wrong use of stat instead of stat64 for sparc64

2013-09-06 Thread Stefan Weil
This test case is fixed now: sparc64-linux-user/qemu-sparc64 /usr/gnemul/qemu-sparc64/busybox ls -l block.c Signed-off-by: Stefan Weil s...@weilnetz.de --- linux-user/syscall.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c

Re: [Qemu-devel] [PATCH] Makefile: Remove some more files when cleaning

2013-09-07 Thread Stefan Weil
Am 25.07.2013 18:24, schrieb Stefan Weil: Signed-off-by: Stefan Weil s...@weilnetz.de --- Makefile |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 29f1043..80aeb18 100644 --- a/Makefile +++ b/Makefile @@ -237,7 +237,8 @@ clean

Re: [Qemu-devel] [PATCH] tci: Add implementation of rotl_i64, rotr_i64

2013-09-09 Thread Stefan Weil
Am 09.09.2013 16:53, schrieb Aurelien Jarno: On Wed, Sep 04, 2013 at 10:51:54PM +0200, Stefan Weil wrote: Am 04.09.2013 22:49, schrieb Stefan Weil: It is used by qemu-ppc64 when running Debian's busybox-static. Signed-off-by: Stefan Weil s...@weilnetz.de --- This patch is also useful

Re: [Qemu-devel] [RFC 1/2] include/: import sizes.h from barebox

2013-09-09 Thread Stefan Weil
Am 09.09.2013 19:32, schrieb Aurelien Jarno: On Wed, Sep 04, 2013 at 11:35:27AM +0400, Antony Pavlov wrote: @@ -0,0 +1,48 @@ +/* + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free

Re: [Qemu-devel] [PATCH] configure: detect endian via compile test

2013-09-09 Thread Stefan Weil
Am 28.08.2013 10:21, schrieb James Hogan: On 1 July 2013 04:30, Mike Frysinger vap...@gentoo.org wrote: This avoids needing to execute a program and keeping an (incomplete) list when cross-compiling. Signed-off-by: Mike Frysinger vap...@gentoo.org This fixes mipsel cross compiling. I also

[Qemu-devel] [RFC] TCI for ARM and other hosts with aligned args (was: Re: [RFC] TCG unit testing)

2013-09-10 Thread Stefan Weil
Am 23.08.2013 23:18, schrieb Richard Henderson: I don't see how TCI really comes into this except as Yet Another Backend to be tested. Indeed, such unit testing could show that TCI is in fact broken wrt helpers, depending on the host abi. E.g. tci never defines TCG_TARGET_CALL_ALIGN_ARGS.

Re: [Qemu-devel] [RFC] TCI for ARM and other hosts with aligned args

2013-09-10 Thread Stefan Weil
Am 10.09.2013 23:52, schrieb Richard Henderson: On 09/10/2013 02:34 PM, Stefan Weil wrote: For native compilations, TCG_TARGET_CALL_ALIGN_ARGS can be set from configure. Cross compilations cannot set that macro automatically (or is there some way to do this?) I can't think of a way

Re: [Qemu-devel] [RFC] TCI for ARM and other hosts with aligned args

2013-09-10 Thread Stefan Weil
Am 11.09.2013 00:22, schrieb Peter Maydell: On 10 September 2013 23:04, Stefan Weil s...@weilnetz.de wrote: busybox-static from Debian running on 32 bit Linux: $ alpha-linux-user/qemu-alpha -d in_asm /usr/gnemul/qemu-alpha/bin/busybox pwd host mmap_min_addr=0x1 Reserved 0x21e000 bytes

[Qemu-devel] [Bug 1007269] Re: Can’t install or boot up 32bit win8 guest.

2013-09-11 Thread Stefan Weil
*** This bug is a duplicate of bug 921208 *** https://bugs.launchpad.net/bugs/921208 It's not a KVM bug, but a well known problem of QEMU without KVM (TCG). There is currently no solution. ** Changed in: qemu Status: Invalid = Confirmed ** This bug has been marked a duplicate of bug

[Qemu-devel] [PATCH] *-user: Fix typo in comment (ulocking - unlocking)

2013-09-12 Thread Stefan Weil
Signed-off-by: Stefan Weil s...@weilnetz.de --- bsd-user/qemu.h |2 +- linux-user/qemu.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h index 1998af6..ddc74ed 100644 --- a/bsd-user/qemu.h +++ b/bsd-user/qemu.h @@ -381,7 +381,7

[Qemu-devel] [PATCH] translate-all: Fix formatting of dump output

2013-09-12 Thread Stefan Weil
-004000802000 0080 rw- Signed-off-by: Stefan Weil s...@weilnetz.de --- translate-all.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/translate-all.c b/translate-all.c index 2c923c6..3b97c66 100644 --- a/translate-all.c +++ b/translate-all.c @@ -1679,8 +1679,9

[Qemu-devel] [PATCH] MAINTAINERS: Add missing entry to filelist for TCI target

2013-09-12 Thread Stefan Weil
tci.c is also a maintained part of the TCI implementation. Signed-off-by: Stefan Weil s...@weilnetz.de --- MAINTAINERS |1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index d128ed0..4d634f2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -842,6 +842,7 @@ TCI target

[Qemu-devel] [PATCH] *-user: Improve documentation for lock_user function

2013-09-12 Thread Stefan Weil
Add a missing function and replace and by any. BSD und Linux use the same documentation here, so fix both. Signed-off-by: Stefan Weil s...@weilnetz.de --- bsd-user/qemu.h |4 ++-- linux-user/qemu.h |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/bsd-user/qemu.h

[Qemu-devel] [PATCH] tci: Fix qemu-alpha on 32 bit hosts (wrong assertions)

2013-09-12 Thread Stefan Weil
because they are either wrong or unnecessary (when sizeof(tcg_target_ulong) = sizeof(target_ulong)). Cc: qemu-stable qemu-sta...@nongnu.org Signed-off-by: Stefan Weil s...@weilnetz.de --- tci.c | 12 1 file changed, 12 deletions(-) diff --git a/tci.c b/tci.c index cea7234..0202ed9

[Qemu-devel] [PATCH] tci: Detect function argument alignment

2013-09-12 Thread Stefan Weil
This fixes TCI on ARM hosts (tested with Debian's busybox-static running in linux-user emulation). Signed-off-by: Stefan Weil s...@weilnetz.de --- configure| 63 ++ tcg/tci/tcg-target.h |6 - 2 files changed, 68 insertions

[Qemu-devel] [PATCH 3/3] misc: Use new rotate functions

2013-09-12 Thread Stefan Weil
Signed-off-by: Stefan Weil s...@weilnetz.de --- target-arm/iwmmxt_helper.c |2 +- tcg/optimize.c | 12 tci.c |8 3 files changed, 9 insertions(+), 13 deletions(-) diff --git a/target-arm/iwmmxt_helper.c b/target-arm/iwmmxt_helper.c

Re: [Qemu-devel] [PATCH] tci: Fix qemu-alpha on 32 bit hosts (wrong assertions)

2013-09-12 Thread Stefan Weil
Am 12.09.2013 20:39, schrieb Richard Henderson: On 09/12/2013 11:17 AM, Stefan Weil wrote: @@ -1093,7 +1093,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr) tmp8 = helper_ldb_mmu(env, taddr, tci_read_i(tb_ptr)); #else host_addr

[Qemu-devel] [PATCH 2/3] bitops: Add rotate functions (rol8, ror8, ...)

2013-09-12 Thread Stefan Weil
These functions were copies from include/linux/bitopts.h. Signed-off-by: Stefan Weil s...@weilnetz.de --- include/qemu/bitops.h | 82 + 1 file changed, 82 insertions(+) diff --git a/include/qemu/bitops.h b/include/qemu/bitops.h index 06e2e6f

[Qemu-devel] [PATCH 0/3] Add and use bit rotate functions

2013-09-12 Thread Stefan Weil
The first patch was already sent to qemu-devel and is only included here because patch 3 is based on it. Only patch 1 is needed for qemu-stable. It looks like shift values of 0 or 32/64 work as expected because the compiler knows the pattern used to implement the rotate operation, so the code

[Qemu-devel] [PATCH 1/3] tci: Add implementation of rotl_i64, rotr_i64

2013-09-12 Thread Stefan Weil
It is used by qemu-ppc64 when running Debian's busybox-static. Cc: qemu-stable qemu-sta...@nongnu.org Signed-off-by: Stefan Weil s...@weilnetz.de Reviewed-by: Richard Henderson r...@twiddle.net --- tcg/tci/tcg-target.c |1 - tci.c| 10 +- 2 files changed, 9

  1   2   3   4   5   6   7   8   9   10   >