Re: [PATCH 3/3] hw/display/artist: rewrite vram access mode handling

2022-01-25 Thread Sven Schnelle
Gerd Hoffmann writes: > Hi, > >> +static void artist_vram_write4(ARTISTState *s, struct vram_buffer *buf, >> + uint32_t offset, uint32_t data) > >> +static int get_vram_offset(ARTISTState *s, struct vram_buffer *buf, >> + int pos, int

[PATCH 3/3] hw/display/artist: rewrite vram access mode handling

2022-01-21 Thread Sven Schnelle
is that both the linear framebuffer and the register based vram access can now be combined into one function. This makes the linux 'stifb' framebuffer work, and both HP-UX 10.20 and HP-UX 11.11 are still working. Signed-off-by: Sven Schnelle --- hw/display/artist.c | 416

[PATCH 2/3] hw/display/artist: allow to disable/enable cursor

2022-01-21 Thread Sven Schnelle
Allow to disable/enable the cursor via the cursor control register. Signed-off-by: Sven Schnelle --- hw/display/artist.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/display/artist.c b/hw/display/artist.c index 7956a1a5c3..cfae92d3e8 100644 --- a/hw/display

[PATCH 0/3] hw/display/artist: cursor & buffer mode fixes

2022-01-21 Thread Sven Schnelle
Hi List, this set contains two fixes too make the cursor work with HP-UX' X-server, and one large rewrite to make the Linux framebuffer work with artist on hppa. Sven Schnelle (3): hw/display/artist: fix cursor position hw/display/artist: allow to disable/enable cursor hw/display/artist

[PATCH 1/3] hw/display/artist: fix cursor position

2022-01-21 Thread Sven Schnelle
fixes the cursor position problems for all HP-UX versions. Signed-off-by: Sven Schnelle --- hw/display/artist.c | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/hw/display/artist.c b/hw/display/artist.c index 21b7fd1b44..7956a1a5c3 100644 --- a/hw

Re: [PATCH 5/5] hw/display/artist: Fix framebuffer access for Linux

2022-01-15 Thread Sven Schnelle
Sven Schnelle writes: > Philippe Mathieu-Daudé writes: > >> +Sven >> >> On 12/1/22 22:07, Helge Deller wrote: >>> This patch fixes two problems which prevented Linux to access the >>> artist graphics framebuffer: >>> The check if

Re: [PATCH 5/5] hw/display/artist: Fix framebuffer access for Linux

2022-01-15 Thread Sven Schnelle
Philippe Mathieu-Daudé writes: > +Sven > > On 12/1/22 22:07, Helge Deller wrote: >> This patch fixes two problems which prevented Linux to access the >> artist graphics framebuffer: >> The check if the framebuffer or the color map should be accessed was >> incomplete. By using the

Re: [PATCH] net: tulip: Set PCI revision to match dec21143

2020-06-10 Thread Sven Schnelle
ut > > Cc: Marc-André Lureau > > Cc: Paolo Bonzini > > Cc: Peter Maydell > > Cc: Prasad J Pandit > > Cc: Sven Schnelle > > --- > > hw/net/tulip.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/hw/net/tulip.c

Re: [PATCH] fix out of bounds check

2020-02-29 Thread Sven Schnelle
On Sat, Feb 29, 2020 at 10:50:40AM +0100, Sven Schnelle wrote: > Signed-off-by: Sven Schnelle > --- > hw/display/artist.c | 18 ++ > 1 file changed, 6 insertions(+), 12 deletions(-) That was supposed to only go to Helge for testing, so please ignore. Sven

[PATCH] fix out of bounds check

2020-02-29 Thread Sven Schnelle
Signed-off-by: Sven Schnelle --- hw/display/artist.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/hw/display/artist.c b/hw/display/artist.c index f3a1375224..6cc85eb292 100644 --- a/hw/display/artist.c +++ b/hw/display/artist.c @@ -340,14 +340,13

Re: [PULL 4/9] hw/display/artist: Avoid drawing line when nothing to display

2020-02-29 Thread Sven Schnelle
On Tue, Feb 18, 2020 at 11:39:24AM -0800, Richard Henderson wrote: > From: Philippe Mathieu-Daudé > > Signed-off-by: Philippe Mathieu-Daudé > Message-Id: <20200214001303.12873-5-f4...@amsat.org> > Signed-off-by: Richard Henderson > --- > hw/display/artist.c | 3 +++ > 1 file changed, 3

Re: [PATCH] net: tulip: check frame size and r/w data length

2020-02-15 Thread Sven Schnelle
Hi, thanks for your patch. On Tue, Feb 11, 2020 at 01:09:30PM +0530, P J P wrote: > From: Prasad J Pandit > diff --git a/hw/net/tulip.c b/hw/net/tulip.c > index cfac2719d3..aca2a3f17f 100644 > --- a/hw/net/tulip.c > +++ b/hw/net/tulip.c > @@ -164,27 +164,35 @@ static void

Re: [PATCH 1/5] hw/display/artist: Move trace event to draw_line()

2020-02-15 Thread Sven Schnelle
; > if (endx < 0) { > endx = 0; > } > > if (starty < 0) { > starty = 0; > } > > if (endy < 0) { > endy = 0; > } > > > if (endx < 0) { > return; > } > > if (endy < 0) { > return; > } > > -trace_artist_draw_line(startx, starty, endx, endy); > draw_line(s, startx, starty, endx, endy, false, -1, -1); > } > > static void draw_line_end(ARTISTState *s, bool update_start) > { > > int startx = artist_get_x(s->vram_start); > int starty = artist_get_y(s->vram_start); > int endx = artist_get_x(s->line_end); > int endy = artist_get_y(s->line_end); > > -trace_artist_draw_line(startx, starty, endx, endy); > draw_line(s, startx, starty, endx, endy, update_start, -1, -1); > } > > -- > 2.21.1 > Acked-by: Sven Schnelle

Re: [PATCH 2/5] hw/display/artist: Remove pointless initialization

2020-02-15 Thread Sven Schnelle
th + x; > } > > if (skip_pix > 0) { > skip_pix--; > } else { > artist_rop8(s, p, color); > } > > if (e > 0) { > artist_invalidate_lines(buf, y, 1); > y += incy; > e += diago; > } else { > e += horiz; > } > x++; > } while (x <= x2 && (max_pix == -1 || --max_pix > 0)); > } > -- > 2.21.1 > Acked-by: Sven Schnelle

Re: [PATCH 5/5] hw/display/artist: Remove dead code (CID 1419388 & 1419389)

2020-02-15 Thread Sven Schnelle
gt; > if (endx < 0) { > endx = 0; > } > > if (starty < 0) { > starty = 0; > } > > if (endy < 0) { > endy = 0; > } > > - > -if (endx < 0) { > -return; > -} > - > -if (endy < 0) { > -return; > -} > - > draw_line(s, startx, starty, endx, endy, false, -1, -1); > } > > -- > 2.21.1 > Acked-by: Sven Schnelle

Re: [PATCH 3/5] hw/display/artist: Delay some variables initialization

2020-02-15 Thread Sven Schnelle
ata + x * s->width + y; > } else { > p = buf->data + y * s->width + x; > } > > if (skip_pix > 0) { > skip_pix--; > } else { > artist_rop8(s, p, color); > } > > if (e > 0) { > artist_invalidate_lines(buf, y, 1); > y += incy; > e += diago; > } else { > e += horiz; > } > x++; > } while (x <= x2 && (max_pix == -1 || --max_pix > 0)); > } > -- > 2.21.1 > Acked-by: Sven Schnelle

Re: [PATCH v5 4/6] hppa: add emulation of LASI PS2 controllers

2020-01-19 Thread Sven Schnelle
On Fri, Jan 03, 2020 at 07:15:49AM +0100, Philippe Mathieu-Daudé wrote: > On 12/20/19 10:15 PM, Sven Schnelle wrote: > > Signed-off-by: Sven Schnelle > > --- > > hw/hppa/Kconfig| 1 + > > hw/hppa/lasi.c | 10 +- > > hw/input/Kconfig

Re: [PATCH v5 5/6] hppa: Add emulation of Artist graphics

2019-12-23 Thread Sven Schnelle
Hi Philippe, On Sun, Dec 22, 2019 at 01:37:48PM +0100, Philippe Mathieu-Daudé wrote: > > > > +if (vga_interface_type != VGA_NONE) { > > +dev = qdev_create(NULL, "artist"); > > +qdev_init_nofail(dev); > > +s = SYS_BUS_DEVICE(dev); > > +sysbus_mmio_map(s, 0,

Re: [PATCH 1/2] hppa: Do not enable artist graphics with -nographic option

2019-12-22 Thread Sven Schnelle
Hi Helge, On Sat, Dec 21, 2019 at 11:24:02PM +0100, Helge Deller wrote: > When qemu was started with the -nographic option, do not enable the > artist graphic card emulation. Hmm, isn't '-nographic -vnc' a valid option that wouldn't work anymore in that case? I used '-nographic -vga none' to

[PATCH v5 5/6] hppa: Add emulation of Artist graphics

2019-12-20 Thread Sven Schnelle
This adds emulation of Artist graphics good enough to get a Text console on both Linux and HP-UX. The X11 server from HP-UX also works. Signed-off-by: Sven Schnelle --- hw/display/Kconfig |4 + hw/display/Makefile.objs |1 + hw/display/artist.c | 1450

[PATCH v5 4/6] hppa: add emulation of LASI PS2 controllers

2019-12-20 Thread Sven Schnelle
Signed-off-by: Sven Schnelle --- hw/hppa/Kconfig| 1 + hw/hppa/lasi.c | 10 +- hw/input/Kconfig | 3 + hw/input/Makefile.objs | 1 + hw/input/lasips2.c | 289 + hw/input/ps2.c | 5 + hw/input

[PATCH v5 2/6] hppa: Add support for LASI chip with i82596 NIC

2019-12-20 Thread Sven Schnelle
. Signed-off-by: Helge Deller Signed-off-by: Sven Schnelle --- MAINTAINERS | 2 + hw/hppa/Kconfig | 1 + hw/hppa/Makefile.objs | 2 +- hw/hppa/hppa_sys.h | 2 + hw/hppa/lasi.c | 360 ++ hw/hppa/machine.c

[PATCH v5 1/6] hw/hppa/dino.c: Improve emulation of Dino PCI chip

2019-12-20 Thread Sven Schnelle
From: Helge Deller The tests of the dino chip with the Online-diagnostics CD ("ODE DINOTEST") now succeeds. Additionally add some qemu trace events. Signed-off-by: Helge Deller Signed-off-by: Sven Schnelle Reviewed-by: Philippe Mathieu-Daudé --- MAINTAINERS | 2 +- hw/h

[PATCH v5 0/6] HPPA: i82596, PS/2 and graphics emulation

2019-12-20 Thread Sven Schnelle
): hw/hppa/dino.c: Improve emulation of Dino PCI chip hppa: Add support for LASI chip with i82596 NIC Sven Schnelle (4): ps2: accept 'Set Key Make and Break' commands hppa: add emulation of LASI PS2 controllers hppa: Add emulation of Artist graphics seabios-hppa: update to latest version

[PATCH v5 3/6] ps2: accept 'Set Key Make and Break' commands

2019-12-20 Thread Sven Schnelle
HP-UX sends both the 'Set key make and break (0xfc) and 'Set all key typematic make and break' (0xfa). QEMU response with 'Resend' as it doesn't handle these commands. HP-UX than reports an PS/2 max retransmission exceeded error. Add these commands and just reply with ACK. Signed-off-by: Sven

Re: [PATCH v4 5/6] hppa: Add emulation of Artist graphics

2019-12-20 Thread Sven Schnelle
Hi, On Fri, Dec 20, 2019 at 05:36:36PM +0100, Helge Deller wrote: > On 20.12.19 08:26, Helge Deller wrote: > > On 19.12.19 01:28, Richard Henderson wrote: > >> On 11/3/19 10:56 AM, Sven Schnelle wrote: > >>> This adds emulation of Artist graphics good enough >

Re: [PATCH v4 0/6] HPPA: i82596, PS/2 and graphics emulation

2019-11-23 Thread Sven Schnelle
On Sun, Nov 03, 2019 at 09:56:01PM +0100, Sven Schnelle wrote: > Hi, > > these series adds quite a lot to the HPPA emulation in QEMU: > i82596 emulation from Helge, PS/2 and Artist graphics emulation. > [..] Ping? :-) Regards Sven

Re: [PATCH v3 5/6] hppa: Add emulation of Artist graphics

2019-11-03 Thread Sven Schnelle
Hi Mark, On Sun, Nov 03, 2019 at 08:56:43PM +, Mark Cave-Ayland wrote: > On 01/11/2019 21:59, Sven Schnelle wrote: > > > On Sat, Oct 26, 2019 at 07:54:40PM +0200, Sven Schnelle wrote: > >> Hi Mark, > >> > >> On Sat, Oct 26, 2019 at 1

[PATCH v4 2/6] hppa: Add support for LASI chip with i82596 NIC

2019-11-03 Thread Sven Schnelle
. Signed-off-by: Helge Deller Signed-off-by: Sven Schnelle --- MAINTAINERS | 2 + hw/hppa/Kconfig | 1 + hw/hppa/Makefile.objs | 2 +- hw/hppa/hppa_sys.h | 2 + hw/hppa/lasi.c | 360 ++ hw/hppa/machine.c

[PATCH v4 3/6] ps2: accept 'Set Key Make and Break' commands

2019-11-03 Thread Sven Schnelle
HP-UX sends both the 'Set key make and break (0xfc) and 'Set all key typematic make and break' (0xfa). QEMU response with 'Resend' as it doesn't handle these commands. HP-UX than reports an PS/2 max retransmission exceeded error. Add these commands and just reply with ACK. Signed-off-by: Sven

[PATCH v4 0/6] HPPA: i82596, PS/2 and graphics emulation

2019-11-03 Thread Sven Schnelle
with i82596 NIC Sven Schnelle (4): ps2: accept 'Set Key Make and Break' commands hppa: add emulation of LASI PS2 controllers hppa: Add emulation of Artist graphics seabios-hppa: update to latest version MAINTAINERS |4 +- hw/display/Kconfig |4 + hw/display

[PATCH v4 5/6] hppa: Add emulation of Artist graphics

2019-11-03 Thread Sven Schnelle
This adds emulation of Artist graphics good enough to get a Text console on both Linux and HP-UX. The X11 server from HP-UX also works. Signed-off-by: Sven Schnelle --- hw/display/Kconfig |4 + hw/display/Makefile.objs |1 + hw/display/artist.c | 1449

[PATCH v4 1/6] hw/hppa/dino.c: Improve emulation of Dino PCI chip

2019-11-03 Thread Sven Schnelle
From: Helge Deller The tests of the dino chip with the Online-diagnostics CD ("ODE DINOTEST") now succeeds. Additionally add some qemu trace events. Signed-off-by: Helge Deller Signed-off-by: Sven Schnelle Reviewed-by: Philippe Mathieu-Daudé --- MAINTAINERS | 2 +- hw/h

[PATCH v4 4/6] hppa: add emulation of LASI PS2 controllers

2019-11-03 Thread Sven Schnelle
Signed-off-by: Sven Schnelle --- hw/hppa/Kconfig| 1 + hw/hppa/lasi.c | 10 +- hw/input/Kconfig | 3 + hw/input/Makefile.objs | 1 + hw/input/lasips2.c | 289 + hw/input/ps2.c | 5 + hw/input

Re: [PATCH v3 5/6] hppa: Add emulation of Artist graphics

2019-11-01 Thread Sven Schnelle
Hi Mark, On Sat, Oct 26, 2019 at 07:54:40PM +0200, Sven Schnelle wrote: > Hi Mark, > > On Sat, Oct 26, 2019 at 10:35:20AM +0100, Mark Cave-Ayland wrote: > > > > However, the VRAM in Artist is not really exposed to the Host. Instead, > > > there's the Chipset inbet

[PATCH v3] fdc/i8257: implement verify transfer mode

2019-11-01 Thread Sven Schnelle
or I/O read/write control signals will be generated. Hervé proposed to remove all the dma_mode_ok stuff from fdc to have a more clear boundary between DMA and FDC, so this patch also does that. Suggested-by: Hervé Poussineau Signed-off-by: Sven Schnelle --- hw/block/fdc.c | 61

[PATCH v2] fdc/i8257: implement verify transfer mode

2019-10-30 Thread Sven Schnelle
or I/O read/write control signals will be generated. Hervé proposed to remove all the dma_mode_ok stuff from fdc to have a more clear boundary between DMA and FDC, so this patch also does that. Suggested-by: Hervé Poussineau Signed-off-by: Sven Schnelle --- hw/block/fdc.c | 39

Re: [PATCH v3 5/6] hppa: Add emulation of Artist graphics

2019-10-26 Thread Sven Schnelle
Hi Mark, On Sat, Oct 26, 2019 at 10:35:20AM +0100, Mark Cave-Ayland wrote: > > However, the VRAM in Artist is not really exposed to the Host. Instead, > > there's the Chipset inbetween that can do byte swapping (Colormap is LE, > > VRAM is BE) and Bit-to-Byte/Word/Dword conversion. For example

Re: [PATCH v3 5/6] hppa: Add emulation of Artist graphics

2019-10-25 Thread Sven Schnelle
Hi Mark, On Thu, Oct 24, 2019 at 09:51:31PM +0100, Mark Cave-Ayland wrote: > On 22/10/2019 21:59, Sven Schnelle wrote: > > > This adds emulation of Artist graphics good enough > > to get a Text console on both Linux and HP-UX. The > > X11 server from HP-UX also wo

Re: [PATCH v3 3/6] ps2: accept 'Set Key Make and Break' commands

2019-10-23 Thread Sven Schnelle
Hi Philippe, On Wed, Oct 23, 2019 at 01:08:35PM +0200, Philippe Mathieu-Daudé wrote: > Hi Sven, > > (Please Cc reviewers who previously commented your patch) > > On 10/22/19 10:59 PM, Sven Schnelle wrote: > > HP-UX sends both the 'Set key make and break (0xfc) and > >

[PATCH v3] net: add tulip (dec21143) driver

2019-10-23 Thread Sven Schnelle
-off-by: Sven Schnelle Message-Id: <20191022155413.4619-1-sv...@stackframe.org> Reviewed-by: Peter Maydell --- Changes in v3: - fix whitespace - fix format string in read/write functions Changes in v2: - changed tulip_desc_{read,write} to take a struct descriptor * and no longer use a

Re: [PATCH v2] net: add tulip (dec21143) driver

2019-10-23 Thread Sven Schnelle
On Tue, Oct 22, 2019 at 05:00:16PM +0100, Peter Maydell wrote: > > There are a couple of minor wrong-indent nits: > > > +static void tulip_update_ts(TULIPState *s, int state) > > +{ > > +s->csr[5] &= ~(CSR5_TS_MASK << CSR5_TS_SHIFT); > > +s->csr[5] |= (state & CSR5_TS_MASK) <<

[PATCH v3 2/6] hppa: Add support for LASI chip with i82596 NIC

2019-10-22 Thread Sven Schnelle
. Signed-off-by: Helge Deller Signed-off-by: Sven Schnelle --- MAINTAINERS | 2 + hw/hppa/Kconfig | 1 + hw/hppa/Makefile.objs | 2 +- hw/hppa/hppa_sys.h | 2 + hw/hppa/lasi.c | 360 ++ hw/hppa/machine.c

[PATCH v3 4/6] hppa: add emulation of LASI PS2 controllers

2019-10-22 Thread Sven Schnelle
Signed-off-by: Sven Schnelle --- hw/hppa/Kconfig| 1 + hw/hppa/lasi.c | 10 +- hw/input/Kconfig | 3 + hw/input/Makefile.objs | 1 + hw/input/lasips2.c | 289 + hw/input/ps2.c | 5 + hw/input

[PATCH v3 5/6] hppa: Add emulation of Artist graphics

2019-10-22 Thread Sven Schnelle
This adds emulation of Artist graphics good enough to get a Text console on both Linux and HP-UX. The X11 server from HP-UX also works. Signed-off-by: Sven Schnelle --- hw/display/Kconfig |3 + hw/display/Makefile.objs |1 + hw/display/artist.c | 1336

[PATCH v3 1/6] hw/hppa/dino.c: Improve emulation of Dino PCI chip

2019-10-22 Thread Sven Schnelle
From: Helge Deller The tests of the dino chip with the Online-diagnostics CD ("ODE DINOTEST") now succeeds. Additionally add some qemu trace events. Signed-off-by: Helge Deller Signed-off-by: Sven Schnelle Reviewed-by: Philippe Mathieu-Daudé --- MAINTAINERS | 2 +- hw/h

[PATCH v3 0/6] HPPA: i82596, PS/2 and graphics emulation

2019-10-22 Thread Sven Schnelle
Deller (2): hw/hppa/dino.c: Improve emulation of Dino PCI chip hppa: Add support for LASI chip with i82596 NIC Sven Schnelle (4): ps2: accept 'Set Key Make and Break' commands hppa: add emulation of LASI PS2 controllers hppa: Add emulation of Artist graphics seabios-hppa: update

[PATCH v3 3/6] ps2: accept 'Set Key Make and Break' commands

2019-10-22 Thread Sven Schnelle
HP-UX sends both the 'Set key make and break (0xfc) and 'Set all key typematic make and break' (0xfa). QEMU response with 'Resend' as it doesn't handle these commands. HP-UX than reports an PS/2 max retransmission exceeded error. Add these commands and just reply with ACK. Signed-off-by: Sven

[PATCH v2] net: add tulip (dec21143) driver

2019-10-22 Thread Sven Schnelle
-off-by: Sven Schnelle --- Changes in v2: - changed tulip_desc_{read,write} to take a struct descriptor * and no longer use a single pci DMA write, instead write one struct member at a time. - fix _tulip_receive function name - fix reset function and provide tulip_qdev_reset() for dc

Re: [PATCH v2 3/6] ps2: accept 'Set Key Make and Break' commands

2019-10-22 Thread Sven Schnelle
Hi Philippe, On Tue, Oct 22, 2019 at 11:50:14AM +0200, Philippe Mathieu-Daudé wrote: > On 10/22/19 7:54 AM, Sven Schnelle wrote: > > HP-UX sends both the 'Set key make and break (0xfc) and > > 'Set all key typematic make and break' (0xfa). QEMU response > > with 'Resend'

[PATCH v2 4/6] hppa: add emulation of LASI PS2 controllers

2019-10-22 Thread Sven Schnelle
Signed-off-by: Sven Schnelle --- hw/hppa/Kconfig| 1 + hw/hppa/lasi.c | 10 +- hw/input/Kconfig | 3 + hw/input/Makefile.objs | 1 + hw/input/lasips2.c | 289 + hw/input/ps2.c | 5 + hw/input

[PATCH v2 1/6] hw/hppa/dino.c: Improve emulation of Dino PCI chip

2019-10-21 Thread Sven Schnelle
From: Helge Deller The tests of the dino chip with the Online-diagnostics CD ("ODE DINOTEST") now succeeds. Additionally add some qemu trace events. Signed-off-by: Helge Deller Signed-off-by: Sven Schnelle --- MAINTAINERS | 2 +- hw/hppa/dino.c

[PATCH v2 2/6] hppa: Add support for LASI chip with i82596 NIC

2019-10-21 Thread Sven Schnelle
. Signed-off-by: Helge Deller Signed-off-by: Sven Schnelle --- MAINTAINERS | 2 + hw/hppa/Kconfig | 1 + hw/hppa/Makefile.objs | 2 +- hw/hppa/hppa_sys.h | 2 + hw/hppa/lasi.c | 360 ++ hw/hppa/machine.c

[PATCH v2 5/6] hppa: Add emulation of Artist graphics

2019-10-21 Thread Sven Schnelle
This adds emulation of Artist graphics good enough to get a Text console on both Linux and HP-UX. The X11 server from HP-UX also works. Signed-off-by: Sven Schnelle --- hw/display/Kconfig |3 + hw/display/Makefile.objs |1 + hw/display/artist.c | 1336

[PATCH v2 0/6] HPPA: i82596, PS/2 and graphics emulation

2019-10-21 Thread Sven Schnelle
region' as that patch requires some more work - added shortlog to seabios update - use const and MAKE_64BIT_MASK in dino.c Regards, Sven Helge Deller (2): hw/hppa/dino.c: Improve emulation of Dino PCI chip hppa: Add support for LASI chip with i82596 NIC Sven Schnelle (4): ps2: accept 'Set Key

[PATCH v2 3/6] ps2: accept 'Set Key Make and Break' commands

2019-10-21 Thread Sven Schnelle
HP-UX sends both the 'Set key make and break (0xfc) and 'Set all key typematic make and break' (0xfa). QEMU response with 'Resend' as it doesn't handle these commands. HP-UX than reports an PS/2 max retransmission exceeded error. Add these commands and just reply with ACK. Signed-off-by: Sven

Re: [PATCH 3/7] hppa: remove ISA region

2019-10-21 Thread Sven Schnelle
Hi Richard, On Mon, Oct 21, 2019 at 11:17:24AM -0700, Richard Henderson wrote: > On 10/20/19 1:47 PM, Sven Schnelle wrote: > > B160L doesn't have an ISA bus, and we no longer need it to > > workaround missing hardware, so remove it. > > > > Signed-off-by: Sven Sch

[PATCH 2/7] hppa: Add support for LASI chip with i82596 NIC

2019-10-20 Thread Sven Schnelle
. Signed-off-by: Helge Deller Signed-off-by: Sven Schnelle --- MAINTAINERS | 2 + hw/hppa/Kconfig | 1 + hw/hppa/Makefile.objs | 2 +- hw/hppa/hppa_sys.h | 2 + hw/hppa/lasi.c | 360 ++ hw/hppa/machine.c

[PATCH 6/7] hppa: Add emulation of Artist graphics

2019-10-20 Thread Sven Schnelle
This adds emulation of Artist graphics good enough to get a Text console on both Linux and HP-UX. The X11 server from HP-UX also works. Signed-off-by: Sven Schnelle --- hw/display/Kconfig |3 + hw/display/Makefile.objs |1 + hw/display/artist.c | 1336

[PATCH 4/7] ps2: accept 'Set Key Make and Break' commands

2019-10-20 Thread Sven Schnelle
HP-UX sends both the 'Set key make and break (0xfc) and 'Set all key typematic make and break' (0xfa). QEMU response with 'Resend' as it doesn't handle these commands. HP-UX than reports an PS/2 max retransmission exceeded error. Add these commands and just reply with ACK. Signed-off-by: Sven

[PATCH 5/7] hppa: add emulation of LASI PS2 controllers

2019-10-20 Thread Sven Schnelle
Signed-off-by: Sven Schnelle --- hw/hppa/Kconfig| 1 + hw/hppa/lasi.c | 10 +- hw/input/Kconfig | 3 + hw/input/Makefile.objs | 1 + hw/input/lasips2.c | 289 + hw/input/ps2.c | 5 + hw/input

[PATCH 1/7] hw/hppa/dino.c: Improve emulation of Dino PCI chip

2019-10-20 Thread Sven Schnelle
From: Helge Deller The tests of the dino chip with the Online-diagnostics CD ("ODE DINOTEST") now succeeds. Additionally add some qemu trace events. Signed-off-by: Helge Deller Signed-off-by: Sven Schnelle --- MAINTAINERS | 2 +- hw/hppa/dino.c

[PATCH 0/7] HPPA: i82596, PS/2 and graphics emulation

2019-10-20 Thread Sven Schnelle
: Improve emulation of Dino PCI chip hppa: Add support for LASI chip with i82596 NIC Sven Schnelle (5): hppa: remove ISA region ps2: accept 'Set Key Make and Break' commands hppa: add emulation of LASI PS2 controllers hppa: Add emulation of Artist graphics seabios-hppa: update to latest

[PATCH 3/7] hppa: remove ISA region

2019-10-20 Thread Sven Schnelle
B160L doesn't have an ISA bus, and we no longer need it to workaround missing hardware, so remove it. Signed-off-by: Sven Schnelle --- hw/hppa/hppa_hardware.h | 1 - hw/hppa/machine.c | 32 2 files changed, 33 deletions(-) diff --git a/hw/hppa

[PATCH] fdc: support READ command with VERIFY DMA mode

2019-10-20 Thread Sven Schnelle
transfer never finished, and Teledisk reported an error. Signed-off-by: Sven Schnelle --- hw/block/fdc.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/hw/block/fdc.c b/hw/block/fdc.c index ac5d31e8c1..8a1228df78 100644 --- a/hw/block/fdc.c +++ b/hw/block/fdc.c

[PATCH] net: add tulip (dec21143) driver

2019-10-19 Thread Sven Schnelle
-off-by: Sven Schnelle --- MAINTAINERS | 6 + hw/net/Kconfig | 5 + hw/net/Makefile.objs | 1 + hw/net/trace-events | 14 + hw/net/tulip.c | 992 +++ hw/net/tulip.h | 265 +++ include/hw/pci

Re: [PATCH 0/2] tests/acceptance: Add tests for the PA-RISC machine

2019-10-18 Thread Sven Schnelle
Hi Philippe, On Fri, Oct 18, 2019 at 04:23:10PM +0200, Philippe Mathieu-Daudé wrote: > Sven since you tested this series, can I add your Tested-by tag? Sure, please do. > On Thu, Oct 10, 2019 at 2:21 PM Philippe Mathieu-Daudé > wrote: > > > > This tests boot a HP-UX firmware CD-ROM which

Re: [Qemu-devel] [PATCH 2/2] target/hppa: prevent trashing of temporary in do_depw_sar()

2019-09-13 Thread Sven Schnelle
Hi Philippe, On Fri, Sep 13, 2019 at 12:58:14PM +0200, Philippe Mathieu-Daudé wrote: > Hi Sven, > > On 9/13/19 12:17 PM, Sven Schnelle wrote: > > nullify_over() calls brcond which destroys all temporaries. > > > > Signed-off-by: Sven Schnelle > > ---

[Qemu-devel] [PATCH 1/2] target/hppa: prevent trashing of temporary in trans_mtctl()

2019-09-13 Thread Sven Schnelle
nullify_over() calls brcond which destroys all temporaries. Signed-off-by: Sven Schnelle --- target/hppa/translate.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index 53e17d8963..b12525d535 100644 --- a/target/hppa

[Qemu-devel] [PATCH 2/2] target/hppa: prevent trashing of temporary in do_depw_sar()

2019-09-13 Thread Sven Schnelle
nullify_over() calls brcond which destroys all temporaries. Signed-off-by: Sven Schnelle --- target/hppa/translate.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index b12525d535..c1b2822f60 100644 --- a/target

[Qemu-devel] [PATCH 0/2] HPPA tcg fixes

2019-09-13 Thread Sven Schnelle
Hi Richard, here are two patches for HPPA tcg. QEMU was crashing with a tcg assert because dead temporaries where used. This could be observed at the end· of a HP-UX 11.11 installation, or by running the STARBASE X11 demos in HP-UX 10.20. Thanks, Sven Sven Schnelle (2): target/hppa: prevent

Re: [Qemu-devel] [PATCH] target/hppa: Avoid squishing DISAS_IAQ_N_STALE_EXIT

2019-03-12 Thread Sven Schnelle
ng delivered. > > Reported-by: Sven Schnelle > Signed-off-by: Richard Henderson > --- > > Sven, this should be a better fix for your 11/11. Indeed, much better. Tested-by: Sven Schnelle Thanks Sven

Re: [Qemu-devel] [PATCH 11/11] target/hppa: call eval_interrupt() after ssm

2019-03-12 Thread Sven Schnelle
Hi Richard, On Mon, Mar 11, 2019 at 09:01:32PM -0700, Richard Henderson wrote: > On 3/11/19 8:28 PM, Richard Henderson wrote: > > On 3/11/19 12:16 PM, Sven Schnelle wrote: > >> HP-UX (all versions) is losing timer interrupts, which leads to > >> hangs. Pressing a key on

[Qemu-devel] [PATCH 08/11] target/hppa: allow multiple itlbp without itlba

2019-03-11 Thread Sven Schnelle
The ODE software calls itlbp on existing TLB entries without calling itlba first, so this seems to be valid. Signed-off-by: Sven Schnelle --- target/hppa/mem_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/hppa/mem_helper.c b/target/hppa/mem_helper.c index

[Qemu-devel] [PATCH 02/11] target/hppa: fix TLB handling for page 0

2019-03-11 Thread Sven Schnelle
to the first empty entry. That is because an empty entry will match address 0 in helper_iitlba() Signed-off-by: Sven Schnelle --- target/hppa/mem_helper.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/target/hppa/mem_helper.c b/target/hppa/mem_helper.c index

[Qemu-devel] [PATCH 01/11] target/hppa: fix overwriting source reg in addb

2019-03-11 Thread Sven Schnelle
When one of the source registers is the same as the destination register, the source register gets overwritten with the destionation value before do_add_sv() is called, which leads to unexpection condition matches. Signed-off-by: Sven Schnelle --- target/hppa/translate.c | 4 +++- 1 file

[Qemu-devel] [PATCH 04/11] target/hppa: add TLB trace events

2019-03-11 Thread Sven Schnelle
To ease TLB debugging add a few trace events, which are disabled by default so that there's no performance impact. Signed-off-by: Sven Schnelle --- Makefile.objs| 1 + target/hppa/mem_helper.c | 20 ++-- target/hppa/op_helper.c | 2 ++ target/hppa/trace-events

[Qemu-devel] [PATCH 03/11] target/hppa: report ITLB_EXCP_MISS for ITLB misses

2019-03-11 Thread Sven Schnelle
Signed-off-by: Sven Schnelle --- target/hppa/mem_helper.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target/hppa/mem_helper.c b/target/hppa/mem_helper.c index f30824f4e1..07ecfaf092 100644 --- a/target/hppa/mem_helper.c +++ b/target/hppa/mem_helper.c @@ -96,9 +96,7

[Qemu-devel] [PATCH 10/11] target/hppa: exit TB if either Data or Instruction TLB changes

2019-03-11 Thread Sven Schnelle
in all cases if Instruction translation is enabled. Signed-off-by: Sven Schnelle --- target/hppa/translate.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index a393a12252..fcacff963e 100644 --- a/target/hppa

[Qemu-devel] [PATCH 07/11] target/hppa: fix b,gate instruction

2019-03-11 Thread Sven Schnelle
b,gate does GR[t] ← cat(GR[t]{0..29},IAOQ_Front{30..31}); instead of saving the link address to register t. Signed-off-by: Sven Schnelle --- target/hppa/translate.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index

[Qemu-devel] [PATCH 00/11] target/hppa patches

2019-03-11 Thread Sven Schnelle
seen any problems with these HP-UX 10.20 anymore, and Linux also still works. Thanks Sven Sven Schnelle (11): target/hppa: fix overwriting source reg in addb target/hppa: fix TLB handling for page 0 target/hppa: report ITLB_EXCP_MISS for ITLB misses target/hppa: add TLB trace events

[Qemu-devel] [PATCH 09/11] target/hppa: add TLB protection id check

2019-03-11 Thread Sven Schnelle
Signed-off-by: Sven Schnelle --- target/hppa/cpu.h| 4 target/hppa/mem_helper.c | 28 ++-- 2 files changed, 30 insertions(+), 2 deletions(-) diff --git a/target/hppa/cpu.h b/target/hppa/cpu.h index 861bbb1f16..d808796ee3 100644 --- a/target/hppa/cpu.h +++ b

[Qemu-devel] [PATCH 05/11] target/hppa: remove PSW I/R/Q bit check

2019-03-11 Thread Sven Schnelle
HP ODE use rfi to set the Q bit, and i don't see anything in the documentation that this is forbidden. So remove it. Signed-off-by: Sven Schnelle --- target/hppa/op_helper.c | 5 - 1 file changed, 5 deletions(-) diff --git a/target/hppa/op_helper.c b/target/hppa/op_helper.c index

[Qemu-devel] [PATCH 06/11] target/hppa: ignore DIAG opcode

2019-03-11 Thread Sven Schnelle
DIAG is usually only used by diagnostics software as it's CPU specific. In most of the cases it's better to ignore it and log a message that it's not implemented. Signed-off-by: Sven Schnelle --- target/hppa/insns.decode | 3 +++ target/hppa/translate.c | 6 ++ 2 files changed, 9

[Qemu-devel] [PATCH 11/11] target/hppa: call eval_interrupt() after ssm

2019-03-11 Thread Sven Schnelle
. Calling eval_interrupt() after PSW_I is set seems to fix this. Signed-off-by: Sven Schnelle --- target/hppa/cpu.h| 1 + target/hppa/int_helper.c | 2 +- target/hppa/op_helper.c | 6 ++ 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/target/hppa/cpu.h b/target/hppa/cpu.h index

Re: [Qemu-devel] [PATCH 1/2] lsi: 810/895A are always little endian

2019-03-08 Thread Sven Schnelle
Hi Paolo, can you please also queue this patch? This is the last one required to get HP-UX 10.20 running in QEMU. It still needs -d nochain, but that's a different story... Thanks Sven On Mon, Feb 18, 2019 at 06:55:28PM +0100, Sven Schnelle wrote: > Signed-off-by: Sven Schnelle > ---

[Qemu-devel] [PATCH v2 5/5] lsi: return dfifo value

2019-03-05 Thread Sven Schnelle
Code was assigning DFIFO, but didn't return the value to users. Signed-off-by: Sven Schnelle --- hw/scsi/lsi53c895a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c index 7d66d1a870..3783779da6 100644 --- a/hw/scsi/lsi53c895a.c

[Qemu-devel] [PATCH v2 2/5] lsi: use enum type for s->waiting

2019-03-05 Thread Sven Schnelle
This makes the code easier to read - no functional change. Signed-off-by: Sven Schnelle Reviewed-by: Philippe Mathieu-Daudé --- hw/scsi/lsi53c895a.c | 42 +++--- 1 file changed, 23 insertions(+), 19 deletions(-) diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi

[Qemu-devel] [PATCH v2 3/5] lsi: use enum type for s->msg_action

2019-03-05 Thread Sven Schnelle
This makes the code easier to read - no functional change. Signed-off-by: Sven Schnelle Reviewed-by: Philippe Mathieu-Daudé --- hw/scsi/lsi53c895a.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c

[Qemu-devel] [PATCH v2 1/5] lsi: use ldn_le_p()/stn_le_p()

2019-03-05 Thread Sven Schnelle
Instead of using the open-coded versions, use the helper already present as this makes the code easier to read and less error-prone. Signed-off-by: Sven Schnelle Reviewed-by: Philippe Mathieu-Daudé --- hw/scsi/lsi53c895a.c | 24 1 file changed, 4 insertions(+), 20

[Qemu-devel] [PATCH v2 0/5] LSI53C895 cleanups

2019-03-05 Thread Sven Schnelle
Hi, this series contains a few cosmetic cleanups and one small bugfix for the LSI53C895 emulation. Regards Sven Sven Schnelle (5): lsi: use ldn_le_p()/stn_le_p() lsi: use enum type for s->waiting lsi: use enum type for s->msg_action lsi: use SCSI phase names instead of numbers in

[Qemu-devel] [PATCH v2 4/5] lsi: use SCSI phase names instead of numbers in trace

2019-03-05 Thread Sven Schnelle
This makes trace logs much easier to read, especially for people who are not fluent in SCSI. Signed-off-by: Sven Schnelle Reviewed-by: Philippe Mathieu-Daudé --- hw/scsi/lsi53c895a.c | 31 +++ hw/scsi/trace-events | 6 +++--- 2 files changed, 26 insertions(+), 11

Re: [Qemu-devel] [PATCH 2/5] lsi: use enum type for s->waiting

2019-03-04 Thread Sven Schnelle
Hi Philippe, On Tue, Mar 05, 2019 at 12:18:01AM +0100, Philippe Mathieu-Daudé wrote: > > > > +enum { > > +LSI_NOWAIT, > > You forgot the comment for NOWAIT. I thought LSI_NOWAIT is self-explaining, but will add that. > > int waiting; > > When a field is not used by migration, you

Re: [Qemu-devel] [PATCH 1/5] lsi: use ldn_le_p()/stn_le_p()

2019-03-04 Thread Sven Schnelle
Hi Eric, On Mon, Mar 04, 2019 at 12:40:50PM -0600, Eric Blake wrote: > On 3/4/19 12:09 PM, Sven Schnelle wrote: > > Signed-off-by: Sven Schnelle > > The commit header says "what" (good), but the commit body says nothing at > all (generally, it should say "

[Qemu-devel] [PATCH 4/5] lsi: use SCSI phase names instead of numbers in trace

2019-03-04 Thread Sven Schnelle
Signed-off-by: Sven Schnelle --- hw/scsi/lsi53c895a.c | 24 ++-- hw/scsi/trace-events | 4 ++-- 2 files changed, 20 insertions(+), 8 deletions(-) diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c index d1eb2cf074..f635d56e0f 100644 --- a/hw/scsi/lsi53c895a.c +++ b/hw

[Qemu-devel] [PATCH 5/5] lsi: return dfifo value

2019-03-04 Thread Sven Schnelle
Code was assigning DFIFO, but didn't return the value to users. Signed-off-by: Sven Schnelle --- hw/scsi/lsi53c895a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c index f635d56e0f..a0e0c57b9b 100644 --- a/hw/scsi/lsi53c895a.c

[Qemu-devel] [PATCH 3/5] lsi: use enum type for s->msg_action

2019-03-04 Thread Sven Schnelle
This makes the code easier to read - no functional change. Signed-off-by: Sven Schnelle --- hw/scsi/lsi53c895a.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c index fb9c6db4b2..d1eb2cf074 100644

[Qemu-devel] [PATCH 2/5] lsi: use enum type for s->waiting

2019-03-04 Thread Sven Schnelle
This makes the code easier to read - no functional change. Signed-off-by: Sven Schnelle --- hw/scsi/lsi53c895a.c | 42 +++--- 1 file changed, 23 insertions(+), 19 deletions(-) diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c index 6d280f8b77

[Qemu-devel] [PATCH 1/5] lsi: use ldn_le_p()/stn_le_p()

2019-03-04 Thread Sven Schnelle
Signed-off-by: Sven Schnelle --- hw/scsi/lsi53c895a.c | 24 1 file changed, 4 insertions(+), 20 deletions(-) diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c index 25c6926039..6d280f8b77 100644 --- a/hw/scsi/lsi53c895a.c +++ b/hw/scsi/lsi53c895a.c @@ -289,8

Re: [Qemu-devel] [PATCH] lsi: check if SIGP bit is already set in Wait reselect

2019-03-04 Thread Sven Schnelle
Hi List, is this patch going to be accepted? Thanks Sven On Sun, Feb 17, 2019 at 12:37:17PM +0100, Sven Schnelle wrote: > If SIGP is set, the 'Wait for Reselection' command should jump > immediately to the address stored in the second DWORD of the > instruction. This fixes spuri

<    1   2   3   >