Re: [PATCH V1 26/26] migration: only-migratable-modes

2024-05-09 Thread Fabiano Rosas
Steve Sistare writes: > Add the only-migratable-modes option as a generalization of only-migratable. > Only devices that support all requested modes are allowed. > > Signed-off-by: Steve Sistare > --- > include/migration/misc.h | 3 +++ > include/sysemu/sysemu.h| 1 - >

Re: [PATCH V1 25/26] migration: fix mismatched GPAs during cpr-exec

2024-05-09 Thread Fabiano Rosas
off-by: Steve Sistare Just a detail below. Reviewed-by: Fabiano Rosas > --- > include/exec/memory.h | 12 > migration/ram.c | 15 +-- > system/memory.c | 10 -- > 3 files changed, 29 insertions(+), 8 deletions(-) > > diff --git a/includ

Re: [PATCH V1 24/26] seccomp: cpr-exec blocker

2024-05-09 Thread Fabiano Rosas
Steve Sistare writes: > cpr-exec mode needs permission to exec. Block it if permission is denied. > > Signed-off-by: Steve Sistare Reviewed-by: Fabiano Rosas

Re: [PATCH V1 23/26] migration: misc cpr-exec blockers

2024-05-09 Thread Fabiano Rosas
Steve Sistare writes: > Add blockers for cpr-exec migration mode for devices and options that do > not support it. > > Signed-off-by: Steve Sistare Reviewed-by: Fabiano Rosas

Re: [PATCH V1 22/26] migration: ram block cpr-exec blockers

2024-05-09 Thread Fabiano Rosas
> > Also add a blocker for RAM_GUEST_MEMFD. Preserving guest_memfd may be > sufficient for cpr-exec, but it has not been tested yet. > > - Steve extra text here > > Signed-off-by: Steve Sistare Reviewed-by: Fabiano Rosas

Re: [PATCH V1 21/26] migration: migrate_add_blocker_mode

2024-05-09 Thread Fabiano Rosas
Steve Sistare writes: > Define a convenience function to add a migration blocker for a single mode. > > Signed-off-by: Steve Sistare Reviewed-by: Fabiano Rosas

Re: [PATCH V1 09/26] migration: vmstate_register_named

2024-05-09 Thread Fabiano Rosas
Fabiano Rosas writes: > Steve Sistare writes: > >> Define vmstate_register_named which takes the instance name as its first >> parameter, instead of generating the name from VMStateIf of the Object. >> This will be needed to register objects that are not Objects. Pass t

Re: [PATCH V1 09/26] migration: vmstate_register_named

2024-05-09 Thread Fabiano Rosas
me parameter to vmstate_register_with_alias_id. > > Signed-off-by: Steve Sistare Reviewed-by: Fabiano Rosas

[PULL v2 10/13] migration: Remove block migration

2024-05-08 Thread Fabiano Rosas
Reviewed-by: Markus Armbruster Reviewed-by: Peter Xu Signed-off-by: Fabiano Rosas --- MAINTAINERS |1 - docs/about/deprecated.rst | 10 - docs/about/removed-features.rst | 14 + docs/devel/migration/main.rst |2 +- include/migration/misc.h|6 - m

[PULL v2 02/13] migration: move trace-point from migrate_fd_error to migrate_set_error

2024-05-08 Thread Fabiano Rosas
From: Vladimir Sementsov-Ogievskiy Cover more cases by trace-point. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Fabiano Rosas Reviewed-by: Peter Xu Signed-off-by: Fabiano Rosas --- migration/migration.c | 4 +++- migration/trace-events | 2 +- 2 files changed, 4 insertions

[PULL v2 05/13] migration: process_incoming_migration_co(): rework error reporting

2024-05-08 Thread Fabiano Rosas
-by: Fabiano Rosas --- migration/migration.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index b307a4bc59..a9599838e6 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -735,14 +735,16

[PULL v2 07/13] migration: Remove 'skipped' field from MigrationStats

2024-05-08 Thread Fabiano Rosas
The 'skipped' field of the MigrationStats struct has been deprecated in 8.1. Time to remove it. Deprecation commit 7b24d32634 ("migration: skipped field is really obsolete."). Reviewed-by: Markus Armbruster Reviewed-by: Peter Xu Signed-off-by: Fabiano Rosas --- docs/about/depr

[PULL v2 01/13] migration/ram.c: API Conversion qemu_mutex_lock(), and qemu_mutex_unlock() to WITH_QEMU_LOCK_GUARD macro

2024-05-08 Thread Fabiano Rosas
From: Will Gyda migration/ram.c: API Conversion qemu_mutex_lock(), and qemu_mutex_unlock() to WITH_QEMU_LOCK_GUARD macro Signed-off-by: Will Gyda Reviewed-by: Peter Xu Signed-off-by: Fabiano Rosas --- migration/ram.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff

[PULL v2 11/13] migration: Remove non-multifd compression

2024-05-08 Thread Fabiano Rosas
commit 864128df46 ("migration: Deprecate old compression method"). Acked-by: Markus Armbruster Reviewed-by: Peter Xu Signed-off-by: Fabiano Rosas --- docs/about/deprecated.rst | 11 - docs/about/removed-features.rst | 55 hw/core/machine.c | 1 - migration/m

[PULL v2 12/13] migration: Deprecate fd: for file migration

2024-05-08 Thread Fabiano Rosas
thought to be rarely used currently and instead establish a 1:1 correspondence between fd: URI and socket transport, and file: URI and file transport. Reviewed-by: Peter Xu Signed-off-by: Fabiano Rosas --- docs/about/deprecated.rst | 14 ++ migration/fd.c| 12

[PULL v2 13/13] hmp/migration: Fix "migrate" command's documentation

2024-05-08 Thread Fabiano Rosas
appending it at the end of the command description. Add a hint for how to query the migration results in detached mode. - Add "postcopy" keyword to "resume/-r" help messages, as it only applies to postcopy. Cc: Dr. David Alan Gilbert Cc: Fabiano Rosas Fixes: 7

[PULL v2 08/13] migration: Remove 'inc' option from migrate command

2024-05-08 Thread Fabiano Rosas
Signed-off-by: Fabiano Rosas --- docs/about/deprecated.rst | 9 -- docs/about/removed-features.rst | 14 + hmp-commands.hx | 13 +++- migration/block.c | 1 - migration/migration-hmp-cmds.c | 18 ++- migration/migration.c

[PULL v2 03/13] migration: process_incoming_migration_co(): complete cleanup on failure

2024-05-08 Thread Fabiano Rosas
From: Vladimir Sementsov-Ogievskiy Make call to migration_incoming_state_destroy(), instead of doing only partial of it. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Fabiano Rosas Reviewed-by: Peter Xu Signed-off-by: Fabiano Rosas --- migration/migration.c | 5 + 1 file

[PULL v2 04/13] migration: process_incoming_migration_co(): fix reporting s->error

2024-05-08 Thread Fabiano Rosas
From: Vladimir Sementsov-Ogievskiy It's bad idea to leave critical section with error object freed, but s->error still set, this theoretically may lead to use-after-free crash. Let's avoid it. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Fabiano Rosas Reviewed-by: Peter Xu Sig

[PULL v2 09/13] migration: Remove 'blk/-b' option from migrate commands

2024-05-08 Thread Fabiano Rosas
patch. Deprecation commit 8846b5bfca ("migration: migrate 'blk' command option is deprecated."). Reviewed-by: Markus Armbruster Reviewed-by: Peter Xu Signed-off-by: Fabiano Rosas --- .gitlab-ci.d/buildtest.yml | 2 +- docs/about/deprecated.rst| 9 -- docs/abo

[PULL v2 06/13] qapi: introduce exit-on-error parameter for migrate-incoming

2024-05-08 Thread Fabiano Rosas
as well So, if we want to change the behavior of x-exit-preconfig, it should be another patch. Signed-off-by: Vladimir Sementsov-Ogievskiy Acked-by: Markus Armbruster Reviewed-by: Fabiano Rosas Reviewed-by: Peter Xu Signed-off-by: Fabiano Rosas --- migration/migration-hmp-cmds.c | 2

[PULL v2 00/13] Migration patches for 2024-05-08

2024-05-08 Thread Fabiano Rosas
Vladimir's new exit-on-error parameter - Fabiano's removals and deprecations series (block migration and non-multifd compression removed) - Peter's documentation fix for HMP migrate command v2: - updated Peter's documentation fix. ------

Re: [PATCH 2/9] migration: Fix file migration with fdset

2024-05-08 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Fri, Apr 26, 2024 at 11:20:35AM -0300, Fabiano Rosas wrote: >> When the migration using the "file:" URI was implemented, I don't >> think any of us noticed that if you pass in a file name with the >> format "/dev/fds

Re: [PATCH 8/9] migration: Add support for fdset with multifd + file

2024-05-08 Thread Fabiano Rosas
Peter Xu writes: > On Wed, May 08, 2024 at 09:53:48AM +0100, Daniel P. Berrangé wrote: >> On Fri, Apr 26, 2024 at 11:20:41AM -0300, Fabiano Rosas wrote: >> > Allow multifd to use an fdset when migrating to a file. This is useful >> > for the scenario where the man

Re: [PATCH V1 08/26] migration: vmstate_info_void_ptr

2024-05-07 Thread Fabiano Rosas
Steve Sistare writes: > Define VMSTATE_VOID_PTR so the value of a pointer (but not its target) > can be saved in the migration stream. This will be needed for CPR. > > Signed-off-by: Steve Sistare Reviewed-by: Fabiano Rosas

Re: [PATCH V1 07/26] migration: VMStateId

2024-05-07 Thread Fabiano Rosas
Steve Sistare writes: > Define a type for the 256 byte id string to guarantee the same length is > used and enforced everywhere. > > Signed-off-by: Steve Sistare Reviewed-by: Fabiano Rosas

Re: [PATCH V1 05/26] migration: precreate vmstate

2024-05-07 Thread Fabiano Rosas
Steve Sistare writes: > Provide the VMStateDescription precreate field to mark objects that must > be loaded on the incoming side before devices have been created, because > they provide properties that will be needed at creation time. They will > be saved to and loaded from their own QEMUFile,

Re: [PATCH 4/4] virtio-gpu: add x-vmstate-version

2024-05-07 Thread Fabiano Rosas
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Machine <= 8.2 use v1. > > Signed-off-by: Marc-André Lureau Reviewed-by: Fabiano Rosas

Re: [PATCH 0/4] Fix "virtio-gpu: fix scanout migration post-load"

2024-05-07 Thread Fabiano Rosas
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Hi, > > The aforementioned patch breaks virtio-gpu device migrations for versions > pre-9.0/9.0, both forwards and backwards. Versioning of `VMS_STRUCT` is more > complex than it may initially appear, as evidenced in the

Re: [PATCH V1 01/26] oslib: qemu_clear_cloexec

2024-05-07 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Mon, May 06, 2024 at 08:27:15PM -0300, Fabiano Rosas wrote: >> Steve Sistare writes: >> >> +cc dgilbert, marcandre >> >> > Define qemu_clear_cloexec, analogous to qemu_set_cloexec. >> > >> > Signed-off-by: S

Re: [PATCH V1 06/26] migration: precreate vmstate for exec

2024-05-06 Thread Fabiano Rosas
Steve Sistare writes: > Provide migration_precreate_save for saving precreate vmstate across exec. > Create a memfd, save its value in the environment, and serialize state > to it. Reverse the process in migration_precreate_load. > > Signed-off-by: Steve Sistare > --- >

Re: [PATCH V1 01/26] oslib: qemu_clear_cloexec

2024-05-06 Thread Fabiano Rosas
any and they're not in CC. Looks suspicious. =) Here's a fresh one, hopefully it won't spend another 4 years in the drawer: Reviewed-by: Fabiano Rosas > --- > include/qemu/osdep.h | 9 + > util/oslib-posix.c | 9 + > util/oslib-win32.c | 4 > 3 files chan

Re: [PATCH V1 03/26] migration: SAVEVM_FOREACH

2024-05-06 Thread Fabiano Rosas
Steve Sistare writes: > Define an abstraction SAVEVM_FOREACH to loop over all savevm state > handlers, and replace QTAILQ_FOREACH. Define variants for ALL so > we can loop over all handlers vs a subset of handlers in a subsequent > patch, but at this time there is no distinction between the

Re: [PATCH V1 04/26] migration: delete unused parameter mis

2024-05-06 Thread Fabiano Rosas
Steve Sistare writes: > Signed-off-by: Steve Sistare Reviewed-by: Fabiano Rosas

Re: [PATCH 2/3] vfio/migration: Emit VFIO device migration state change QAPI event

2024-05-06 Thread Fabiano Rosas
Markus Armbruster writes: > Peter, Fabiano, I'd like to hear your opinion on the issue discussed > below. > > Avihai Horon writes: > >> On 02/05/2024 13:22, Joao Martins wrote: >>> External email: Use caution opening links or attachments >>> >>> >>> On 01/05/2024 13:28, Avihai Horon wrote:

Re: [PATCH 2/9] migration: Fix file migration with fdset

2024-05-03 Thread Fabiano Rosas
Peter Xu writes: > On Fri, May 03, 2024 at 04:56:08PM -0300, Fabiano Rosas wrote: >> Peter Xu writes: >> >> > On Fri, Apr 26, 2024 at 11:20:35AM -0300, Fabiano Rosas wrote: >> >> When the migration using the "file:" URI was implemented, I don't

Re: [PATCH 7/9] monitor: fdset: Match against O_DIRECT

2024-05-03 Thread Fabiano Rosas
Peter Xu writes: > On Fri, Apr 26, 2024 at 11:20:40AM -0300, Fabiano Rosas wrote: >> We're about to enable the use of O_DIRECT in the migration code and >> due to the alignment restrictions imposed by filesystems we need to >> make sure the flag is only used

Re: [PATCH 6/9] tests/qtest/migration: Add tests for file migration with direct-io

2024-05-03 Thread Fabiano Rosas
Peter Xu writes: > On Fri, Apr 26, 2024 at 11:20:39AM -0300, Fabiano Rosas wrote: >> The tests are only allowed to run in systems that know about the >> O_DIRECT flag and in filesystems which support it. >> >> Signed-off-by: Fabiano Rosas > > Mostly: > >

Re: [PATCH 5/9] migration/multifd: Add direct-io support

2024-05-03 Thread Fabiano Rosas
Peter Xu writes: > On Fri, Apr 26, 2024 at 11:20:38AM -0300, Fabiano Rosas wrote: >> When multifd is used along with mapped-ram, we can take benefit of a >> filesystem that supports the O_DIRECT flag and perform direct I/O in >> the multifd threads. This brings a si

Re: [PATCH 4/9] migration: Add direct-io parameter

2024-05-03 Thread Fabiano Rosas
Peter Xu writes: > On Fri, Apr 26, 2024 at 11:20:37AM -0300, Fabiano Rosas wrote: >> Add the direct-io migration parameter that tells the migration code to >> use O_DIRECT when opening the migration stream file whenever possible. >> >> This is currently only used wi

Re: [PATCH 3/9] tests/qtest/migration: Fix file migration offset check

2024-05-03 Thread Fabiano Rosas
Peter Xu writes: > On Fri, Apr 26, 2024 at 11:20:36AM -0300, Fabiano Rosas wrote: >> When doing file migration, QEMU accepts an offset that should be >> skipped when writing the migration stream to the file. The purpose of >> the offset is to allow the management layer to

Re: More doc updates needed for new migrate argument @channels

2024-05-03 Thread Fabiano Rosas
Peter Xu writes: > On Fri, May 03, 2024 at 09:13:27AM -0400, Steven Sistare wrote: >> On 5/3/2024 8:49 AM, Fabiano Rosas wrote: >> > Markus Armbruster writes: >> > >> > > Commit 074dbce5fcce (migration: New migrate and migrate-incoming >>

Re: [PATCH 2/9] migration: Fix file migration with fdset

2024-05-03 Thread Fabiano Rosas
Peter Xu writes: > On Fri, Apr 26, 2024 at 11:20:35AM -0300, Fabiano Rosas wrote: >> When the migration using the "file:" URI was implemented, I don't >> think any of us noticed that if you pass in a file name with the >> format "/dev/fdset/N", t

Re: [PULL 13/13] hmp/migration: Fix documents for "migrate" command

2024-05-03 Thread Fabiano Rosas
Markus Armbruster writes: > Fabiano Rosas writes: > >> From: Peter Xu >> >> Peter missed the Sphinx HMP document for the "resume/-r" flag in commit >> 7a4da28b26 ("qmp: hmp: add migrate "resume" option"). Add it. Avoid >

Re: [PATCH 0/9] migration/mapped-ram: Add direct-io support

2024-05-02 Thread Fabiano Rosas
Peter Xu writes: > On Fri, Apr 26, 2024 at 11:20:33AM -0300, Fabiano Rosas wrote: >> If the user is not passing in a file name which QEMU can open at will, >> we must then require that the user pass the two file descriptors with >> the flags already properly set. We'll use

[PULL 02/13] migration: move trace-point from migrate_fd_error to migrate_set_error

2024-05-02 Thread Fabiano Rosas
From: Vladimir Sementsov-Ogievskiy Cover more cases by trace-point. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Fabiano Rosas Reviewed-by: Peter Xu Signed-off-by: Fabiano Rosas --- migration/migration.c | 4 +++- migration/trace-events | 2 +- 2 files changed, 4 insertions

[PULL 00/13] Migration patches for 2024-05-02

2024-05-02 Thread Fabiano Rosas
RD cleanup - Vladimir's new exit-on-error parameter - Fabiano's removals and deprecations series (block migration and non-multifd compression removed) - Peter's documentation fix for HMP migrate command -------- Fabiano Rosas (6): migrati

[PULL 08/13] migration: Remove 'inc' option from migrate command

2024-05-02 Thread Fabiano Rosas
Signed-off-by: Fabiano Rosas --- docs/about/deprecated.rst | 9 -- docs/about/removed-features.rst | 14 + hmp-commands.hx | 13 +++- migration/block.c | 1 - migration/migration-hmp-cmds.c | 18 ++- migration/migration.c

[PULL 12/13] migration: Deprecate fd: for file migration

2024-05-02 Thread Fabiano Rosas
thought to be rarely used currently and instead establish a 1:1 correspondence between fd: URI and socket transport, and file: URI and file transport. Reviewed-by: Peter Xu Signed-off-by: Fabiano Rosas --- docs/about/deprecated.rst | 14 ++ migration/fd.c| 12

[PULL 09/13] migration: Remove 'blk/-b' option from migrate commands

2024-05-02 Thread Fabiano Rosas
patch. Deprecation commit 8846b5bfca ("migration: migrate 'blk' command option is deprecated."). Reviewed-by: Markus Armbruster Reviewed-by: Peter Xu Signed-off-by: Fabiano Rosas --- .gitlab-ci.d/buildtest.yml | 2 +- docs/about/deprecated.rst| 9 -- docs/abo

[PULL 04/13] migration: process_incoming_migration_co(): fix reporting s->error

2024-05-02 Thread Fabiano Rosas
From: Vladimir Sementsov-Ogievskiy It's bad idea to leave critical section with error object freed, but s->error still set, this theoretically may lead to use-after-free crash. Let's avoid it. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Fabiano Rosas Reviewed-by: Peter Xu Sig

[PULL 05/13] migration: process_incoming_migration_co(): rework error reporting

2024-05-02 Thread Fabiano Rosas
-by: Fabiano Rosas --- migration/migration.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index b307a4bc59..a9599838e6 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -735,14 +735,16

[PULL 11/13] migration: Remove non-multifd compression

2024-05-02 Thread Fabiano Rosas
commit 864128df46 ("migration: Deprecate old compression method"). Acked-by: Markus Armbruster Reviewed-by: Peter Xu Signed-off-by: Fabiano Rosas --- docs/about/deprecated.rst | 11 - docs/about/removed-features.rst | 55 hw/core/machine.c | 1 - migration/m

[PULL 01/13] migration/ram.c: API Conversion qemu_mutex_lock(), and qemu_mutex_unlock() to WITH_QEMU_LOCK_GUARD macro

2024-05-02 Thread Fabiano Rosas
From: Will Gyda migration/ram.c: API Conversion qemu_mutex_lock(), and qemu_mutex_unlock() to WITH_QEMU_LOCK_GUARD macro Signed-off-by: Will Gyda Reviewed-by: Peter Xu Signed-off-by: Fabiano Rosas --- migration/ram.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff

[PULL 13/13] hmp/migration: Fix documents for "migrate" command

2024-05-02 Thread Fabiano Rosas
move "detach/-d" to a separate section rather than appending it at the end of the command description. Cc: Dr. David Alan Gilbert Cc: Fabiano Rosas Cc: Markus Armbruster Signed-off-by: Peter Xu Reviewed-by: Fabiano Rosas Signed-off-by: Fabiano Rosas --- hmp-commands.hx | 9 +

[PULL 03/13] migration: process_incoming_migration_co(): complete cleanup on failure

2024-05-02 Thread Fabiano Rosas
From: Vladimir Sementsov-Ogievskiy Make call to migration_incoming_state_destroy(), instead of doing only partial of it. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Fabiano Rosas Reviewed-by: Peter Xu Signed-off-by: Fabiano Rosas --- migration/migration.c | 5 + 1 file

[PULL 06/13] qapi: introduce exit-on-error parameter for migrate-incoming

2024-05-02 Thread Fabiano Rosas
as well So, if we want to change the behavior of x-exit-preconfig, it should be another patch. Signed-off-by: Vladimir Sementsov-Ogievskiy Acked-by: Markus Armbruster Reviewed-by: Fabiano Rosas Reviewed-by: Peter Xu Signed-off-by: Fabiano Rosas --- migration/migration-hmp-cmds.c | 2

[PULL 10/13] migration: Remove block migration

2024-05-02 Thread Fabiano Rosas
Reviewed-by: Markus Armbruster Reviewed-by: Peter Xu Signed-off-by: Fabiano Rosas --- MAINTAINERS |1 - docs/about/deprecated.rst | 10 - docs/about/removed-features.rst | 14 + docs/devel/migration/main.rst |2 +- include/migration/misc.h|6 - m

[PULL 07/13] migration: Remove 'skipped' field from MigrationStats

2024-05-02 Thread Fabiano Rosas
The 'skipped' field of the MigrationStats struct has been deprecated in 8.1. Time to remove it. Deprecation commit 7b24d32634 ("migration: skipped field is really obsolete."). Reviewed-by: Markus Armbruster Reviewed-by: Peter Xu Signed-off-by: Fabiano Rosas --- docs/about/depr

Re: [PATCH] hmp/migration: Fix documents for "migrate" command

2024-05-02 Thread Fabiano Rosas
, slightly cleanup the lines, move "detach/-d" to a separate > section rather than appending it at the end of the command description. > > Cc: Dr. David Alan Gilbert > Cc: Fabiano Rosas > Cc: Markus Armbruster > Signed-off-by: Peter Xu Reviewed-by: Fabiano Rosas

Re: [PATCH] target/loongarch/kvm: Fix VM recovery from disk failures

2024-05-02 Thread Fabiano Rosas
Peter Xu writes: > On Tue, Apr 30, 2024 at 11:00:24AM -0300, Fabiano Rosas wrote: >> Philippe Mathieu-Daudé writes: >> >> > (Cc'ing migration maintainers) >> > >> > On 30/4/24 03:23, Song Gao wrote: >> >> vmstate does not save kvm_sta

Re: [PATCH v6 5/5] qapi: introduce exit-on-error parameter for migrate-incoming

2024-04-30 Thread Fabiano Rosas
eep current behavior by >default > - it does exit on error by itself as well > So, if we want to change the behavior of x-exit-preconfig, it should be > another patch. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Acked-by: Markus Armbruster Reviewed-by: Fabiano Rosas

Re: [PATCH v6 3/5] migration: process_incoming_migration_co(): fix reporting s->error

2024-04-30 Thread Fabiano Rosas
Vladimir Sementsov-Ogievskiy writes: > It's bad idea to leave critical section with error object freed, but > s->error still set, this theoretically may lead to use-after-free > crash. Let's avoid it. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Fabiano Rosas

[PATCH v3 4/6] migration: Remove block migration

2024-04-30 Thread Fabiano Rosas
Reviewed-by: Markus Armbruster Signed-off-by: Fabiano Rosas --- MAINTAINERS |1 - docs/about/deprecated.rst | 10 - docs/about/removed-features.rst | 14 + docs/devel/migration/main.rst |2 +- include/migration/misc.h|6 - meson.build

[PATCH v3 5/6] migration: Remove non-multifd compression

2024-04-30 Thread Fabiano Rosas
commit 864128df46 ("migration: Deprecate old compression method"). Acked-by: Markus Armbruster Signed-off-by: Fabiano Rosas --- docs/about/deprecated.rst | 11 - docs/about/removed-features.rst | 55 hw/core/machine.c | 1 - migration/meson.build

[PATCH v3 1/6] migration: Remove 'skipped' field from MigrationStats

2024-04-30 Thread Fabiano Rosas
The 'skipped' field of the MigrationStats struct has been deprecated in 8.1. Time to remove it. Deprecation commit 7b24d32634 ("migration: skipped field is really obsolete."). Reviewed-by: Markus Armbruster Reviewed-by: Peter Xu Signed-off-by: Fabiano Rosas --- docs/about/depr

[PATCH v3 6/6] migration: Deprecate fd: for file migration

2024-04-30 Thread Fabiano Rosas
thought to be rarely used currently and instead establish a 1:1 correspondence between fd: URI and socket transport, and file: URI and file transport. Signed-off-by: Fabiano Rosas --- docs/about/deprecated.rst | 14 ++ migration/fd.c| 12 2 files changed, 26

[PATCH v3 0/6] migration removals & deprecations

2024-04-30 Thread Fabiano Rosas
(loose terms) like the old string API did. So we cannot map 1:1 from fd: to any transport because fd: allows *both* file migration and socket migration. Fabiano Rosas (6): migration: Remove 'skipped' field from MigrationStats migration: Remove 'inc' option from migrate command migration

[PATCH v3 3/6] migration: Remove 'blk/-b' option from migrate commands

2024-04-30 Thread Fabiano Rosas
patch. Deprecation commit 8846b5bfca ("migration: migrate 'blk' command option is deprecated."). Reviewed-by: Markus Armbruster Signed-off-by: Fabiano Rosas --- .gitlab-ci.d/buildtest.yml | 2 +- docs/about/deprecated.rst| 9 -- docs/about/removed-features.rst | 1

[PATCH v3 2/6] migration: Remove 'inc' option from migrate command

2024-04-30 Thread Fabiano Rosas
The block incremental option for block migration has been deprecated in 8.2 in favor of using the block-mirror feature. Remove it now. Deprecation commit 40101f320d ("migration: migrate 'inc' command option is deprecated."). Reviewed-by: Markus Armbruster Signed-off-by: Fabiano Rosas

Re: [PATCH] target/loongarch/kvm: Fix VM recovery from disk failures

2024-04-30 Thread Fabiano Rosas
Philippe Mathieu-Daudé writes: > (Cc'ing migration maintainers) > > On 30/4/24 03:23, Song Gao wrote: >> vmstate does not save kvm_state_conter, >> which can cause VM recovery from disk to fail. > > Cc: qemu-sta...@nongnu.org > Fixes: d11681c94f ("target/loongarch: Implement kvm_arch_init_vcpu")

Re: [PATCH v2 6/6] migration: Deprecate fd: for file migration

2024-04-29 Thread Fabiano Rosas
Peter Xu writes: > On Fri, Apr 26, 2024 at 10:14:08AM -0300, Fabiano Rosas wrote: >> The fd: URI can currently trigger two different types of migration, a >> TCP migration using sockets and a file migration using a plain >> file. This is in conflict with the recently

Re: [PATCH v2 3/6] migration: Remove 'blk/-b' option from migrate commands

2024-04-29 Thread Fabiano Rosas
Peter Xu writes: > On Mon, Apr 29, 2024 at 02:18:57PM -0300, Fabiano Rosas wrote: >> Peter Xu writes: >> >> > On Fri, Apr 26, 2024 at 10:14:05AM -0300, Fabiano Rosas wrote: >> >> @@ -2003,21 +1997,7 @@ static bool migrate_prepare(MigrationSt

Re: [PATCH v2 3/6] migration: Remove 'blk/-b' option from migrate commands

2024-04-29 Thread Fabiano Rosas
Peter Xu writes: > On Fri, Apr 26, 2024 at 10:14:05AM -0300, Fabiano Rosas wrote: >> @@ -2003,21 +1997,7 @@ static bool migrate_prepare(MigrationState *s, bool >> blk, bool resume, >> } >> } >> >> -if (blk) { >> -if (migr

Re: [PATCH v3 4/4] qapi: introduce exit-on-error parameter for migrate-incoming

2024-04-29 Thread Fabiano Rosas
Vladimir Sementsov-Ogievskiy writes: > On 25.04.24 23:30, Fabiano Rosas wrote: >>> @@ -797,13 +801,18 @@ fail: >>> MIGRATION_STATUS_FAILED); >>> migration_incoming_state_destroy(); >>> >>> -if (migrate_h

[PATCH 3/9] tests/qtest/migration: Fix file migration offset check

2024-04-26 Thread Fabiano Rosas
: 3dc35470c8 ("tests/qtest: migration-test: Add tests for file-based migration") Signed-off-by: Fabiano Rosas --- tests/qtest/migration-test.c | 70 +--- 1 file changed, 65 insertions(+), 5 deletions(-) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migrat

[PATCH 9/9] tests/qtest/migration: Add a test for mapped-ram with passing of fds

2024-04-26 Thread Fabiano Rosas
. Signed-off-by: Fabiano Rosas --- tests/qtest/migration-test.c | 90 1 file changed, 90 insertions(+) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index 512b7ede8b..d83f1bdd4f 100644 --- a/tests/qtest/migration-test.c +++ b/tests/qtest

[PATCH 7/9] monitor: fdset: Match against O_DIRECT

2024-04-26 Thread Fabiano Rosas
flag. Signed-off-by: Fabiano Rosas --- monitor/fds.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/monitor/fds.c b/monitor/fds.c index 4ec3b7eea9..62e324fcec 100644 --- a/monitor/fds.c +++ b/monitor/fds.c @@ -420,6 +420,11 @@ int monitor_fdset_dup_fd_add(int64_t fdset_id

[PATCH 1/9] monitor: Honor QMP request for fd removal immediately

2024-04-26 Thread Fabiano Rosas
on_fdset_fd->removed has been explicitly set. Signed-off-by: Fabiano Rosas --- monitor/fds.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/monitor/fds.c b/monitor/fds.c index d86c2c674c..4ec3b7eea9 100644 --- a/monitor/fds.c +++ b/monitor/fds.c @@ -173,

[PATCH 8/9] migration: Add support for fdset with multifd + file

2024-04-26 Thread Fabiano Rosas
be opened with RDONLY. Signed-off-by: Fabiano Rosas --- docs/devel/migration/main.rst | 18 ++ docs/devel/migration/mapped-ram.rst | 6 - migration/file.c| 38 - 3 files changed, 60 insertions(+), 2 deletions(-) diff --git a/

[PATCH 2/9] migration: Fix file migration with fdset

2024-04-26 Thread Fabiano Rosas
lain file name. This requires storing the fdset_id somewhere. We can then use this stored fdset_id to do cleanup at the end and also fix the second issue. Fixes: 385f510df5 ("migration: file URI offset") Signed-off-by: Fabiano Rosas --- migration/file.c | 48 +++

[PATCH 5/9] migration/multifd: Add direct-io support

2024-04-26 Thread Fabiano Rosas
descriptor to be used exclusively for direct I/O. The second file descriptor can be obtained by QEMU by re-opening the migration file (already possible), or by being provided by the user or management application (support to be added in future patches). Signed-off-by: Fabiano Rosas --- migration

[PATCH 4/9] migration: Add direct-io parameter

2024-04-26 Thread Fabiano Rosas
Signed-off-by: Fabiano Rosas --- include/qemu/osdep.h | 2 ++ migration/migration-hmp-cmds.c | 11 +++ migration/options.c| 30 ++ migration/options.h| 1 + qapi/migration.json| 18 +++--- util/osdep.c

[PATCH 6/9] tests/qtest/migration: Add tests for file migration with direct-io

2024-04-26 Thread Fabiano Rosas
The tests are only allowed to run in systems that know about the O_DIRECT flag and in filesystems which support it. Signed-off-by: Fabiano Rosas --- tests/qtest/migration-helpers.c | 42 + tests/qtest/migration-helpers.h | 1 + tests/qtest/migration-test.c

[PATCH 0/9] migration/mapped-ram: Add direct-io support

2024-04-26 Thread Fabiano Rosas
lab.com/farosas/qemu/-/pipelines/1269352083 Fabiano Rosas (9): monitor: Honor QMP request for fd removal immediately migration: Fix file migration with fdset tests/qtest/migration: Fix file migration offset check migration: Add direct-io parameter migration/multifd: Add direct-io s

Re: [PATCH 3/6] migration: Remove 'blk/-b' option from migrate commands

2024-04-26 Thread Fabiano Rosas
Markus Armbruster writes: > Markus Armbruster writes: > >> Fabiano Rosas writes: >> >>> The block migration is considered obsolete and has been deprecated in >>> 8.2. Remove the migrate command option that enables it. This only >>> affects th

Re: [PATCH 0/6] migration removals & deprecations

2024-04-26 Thread Fabiano Rosas
Markus Armbruster writes: > Fabiano Rosas writes: > >> Markus Armbruster writes: >> >>> Doesn't apply for me. What's your base? >> >> 88daa112d4 ("Merge tag 'migration-20240423-pull-request' of >> https://gitlab.com/peterx/qemu into stagin

[PATCH v2 4/6] migration: Remove block migration

2024-04-26 Thread Fabiano Rosas
Signed-off-by: Fabiano Rosas --- MAINTAINERS |1 - docs/about/deprecated.rst | 10 - docs/about/removed-features.rst | 14 + docs/devel/migration/main.rst |2 +- include/migration/misc.h|6 - meson.build |2 - meson_o

[PATCH v2 3/6] migration: Remove 'blk/-b' option from migrate commands

2024-04-26 Thread Fabiano Rosas
patch. Deprecation commit 8846b5bfca ("migration: migrate 'blk' command option is deprecated."). Signed-off-by: Fabiano Rosas --- .gitlab-ci.d/buildtest.yml | 2 +- docs/about/deprecated.rst| 9 -- docs/about/removed-features.rst | 14 +++ migration/migration-hmp-cmds

[PATCH v2 0/6] migration removals & deprecations

2024-04-26 Thread Fabiano Rosas
://lore.kernel.org/r/20240425150939.19268-1-faro...@suse.de Fabiano Rosas (6): migration: Remove 'skipped' field from MigrationStats migration: Remove 'inc' option from migrate command migration: Remove 'blk/-b' option from migrate commands migration: Remove block migration migration: Remove non

[PATCH v2 5/6] migration: Remove non-multifd compression

2024-04-26 Thread Fabiano Rosas
commit 864128df46 ("migration: Deprecate old compression method"). Signed-off-by: Fabiano Rosas --- docs/about/deprecated.rst | 11 - docs/about/removed-features.rst | 55 hw/core/machine.c | 1 - migration/meson.build | 1 - migration/migration-

[PATCH v2 2/6] migration: Remove 'inc' option from migrate command

2024-04-26 Thread Fabiano Rosas
The block incremental option for block migration has been deprecated in 8.2 in favor of using the block-mirror feature. Remove it now. Deprecation commit 40101f320d ("migration: migrate 'inc' command option is deprecated."). Signed-off-by: Fabiano Rosas --- docs/about/deprecated.rst

[PATCH v2 6/6] migration: Deprecate fd: for file migration

2024-04-26 Thread Fabiano Rosas
thought to be rarely used currently and instead establish a 1:1 correspondence between fd: URI and socket transport, and file: URI and file transport. Signed-off-by: Fabiano Rosas --- docs/about/deprecated.rst | 14 ++ 1 file changed, 14 insertions(+) diff --git a/docs/about/depreca

[PATCH v2 1/6] migration: Remove 'skipped' field from MigrationStats

2024-04-26 Thread Fabiano Rosas
The 'skipped' field of the MigrationStats struct has been deprecated in 8.1. Time to remove it. Deprecation commit 7b24d32634 ("migration: skipped field is really obsolete."). Reviewed-by: Markus Armbruster Signed-off-by: Fabiano Rosas --- docs/about/deprecated.rst | 6 --

Re: [PATCH 0/6] migration removals & deprecations

2024-04-26 Thread Fabiano Rosas
Markus Armbruster writes: > Doesn't apply for me. What's your base? 88daa112d4 ("Merge tag 'migration-20240423-pull-request' of https://gitlab.com/peterx/qemu into staging") Probably clashed with the other removals from Philippe.

Re: [PATCH v4 04/14] util/dsa: Implement DSA task enqueue and dequeue.

2024-04-25 Thread Fabiano Rosas
Hao Xiang writes: > * Use a safe thread queue for DSA task enqueue/dequeue. > * Implement DSA task submission. > * Implement DSA batch task submission. > > Signed-off-by: Hao Xiang > --- > include/qemu/dsa.h | 28 +++ > util/dsa.c | 201

Re: [PATCH v4 03/14] util/dsa: Implement DSA device start and stop logic.

2024-04-25 Thread Fabiano Rosas
Hao Xiang writes: > * DSA device open and close. > * DSA group contains multiple DSA devices. > * DSA group configure/start/stop/clean. > > Signed-off-by: Hao Xiang > Signed-off-by: Bryan Zhang > --- > include/qemu/dsa.h | 72 +++ > util/dsa.c | 316

Re: [PATCH v4 04/14] util/dsa: Implement DSA task enqueue and dequeue.

2024-04-25 Thread Fabiano Rosas
Hao Xiang writes: > * Use a safe thread queue for DSA task enqueue/dequeue. > * Implement DSA task submission. > * Implement DSA batch task submission. > > Signed-off-by: Hao Xiang > --- > include/qemu/dsa.h | 28 +++ > util/dsa.c | 201

Re: [PATCH v4 02/14] util/dsa: Add dependency idxd.

2024-04-25 Thread Fabiano Rosas
Hao Xiang writes: > Idxd is the device driver for DSA (Intel Data Streaming > Accelerator). The driver is fully functioning since Linux > kernel 5.19. This change adds the driver's header file used > for userspace development. Have you looked at the update-linux-headers script?

Re: [PATCH v3 4/4] qapi: introduce exit-on-error parameter for migrate-incoming

2024-04-25 Thread Fabiano Rosas
Vladimir Sementsov-Ogievskiy writes: > Now we do set MIGRATION_FAILED state, but don't give a chance to > orchestrator to query migration state and get the error. > > Let's provide a possibility for QMP-based orchestrators to get an error > like with outgoing migration. > > For

  1   2   3   4   5   6   7   8   9   10   >