I will leave KAMP in the next days. Update email to stay reachable.
Signed-off-by: Peter Lieven
---
MAINTAINERS | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index b270eb8e5b..995f1156f9 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3428,7
Am 24.03.22 um 12:06 schrieb Hanna Reitz:
On 24.03.22 11:42, Peter Lieven wrote:
Am 24.03.22 um 11:40 schrieb Stefano Garzarella:
On Thu, Mar 24, 2022 at 10:52:04AM +0100, Peter Lieven wrote:
Am 22.03.22 um 10:38 schrieb Hanna Reitz:
On 21.03.22 09:31, Stefano Garzarella wrote:
On Sat, Mar
Am 24.03.22 um 11:40 schrieb Stefano Garzarella:
On Thu, Mar 24, 2022 at 10:52:04AM +0100, Peter Lieven wrote:
Am 22.03.22 um 10:38 schrieb Hanna Reitz:
On 21.03.22 09:31, Stefano Garzarella wrote:
On Sat, Mar 19, 2022 at 04:15:33PM +0100, Peter Lieven wrote:
Am 18.03.2022 um 17:47
Am 22.03.22 um 10:38 schrieb Hanna Reitz:
On 21.03.22 09:31, Stefano Garzarella wrote:
On Sat, Mar 19, 2022 at 04:15:33PM +0100, Peter Lieven wrote:
Am 18.03.2022 um 17:47 schrieb Stefano Garzarella :
On Fri, Mar 18, 2022 at 04:48:18PM +0100, Peter Lieven wrote:
Am 18.03.2022 um 09:25
> Am 18.03.2022 um 17:47 schrieb Stefano Garzarella :
>
> On Fri, Mar 18, 2022 at 04:48:18PM +0100, Peter Lieven wrote:
>>
>>
>>>> Am 18.03.2022 um 09:25 schrieb Stefano Garzarella :
>>>
>>> On Thu, Mar 17, 2022 at 07:27:05PM +0100, Pete
> Am 18.03.2022 um 09:25 schrieb Stefano Garzarella :
>
> On Thu, Mar 17, 2022 at 07:27:05PM +0100, Peter Lieven wrote:
>>
>>
>>>> Am 17.03.2022 um 17:26 schrieb Stefano Garzarella :
>>>
>>> Commit d24f80234b ("block/rbd: incr
> Am 17.03.2022 um 17:26 schrieb Stefano Garzarella :
>
> Commit d24f80234b ("block/rbd: increase dynamically the image size")
> added a workaround to support growing images (eg. qcow2), resizing
> the image before write operations that exceed the current size.
>
> We recently added support
Am 01.02.22 um 15:39 schrieb Kevin Wolf:
> Am 13.01.2022 um 15:44 hat Peter Lieven geschrieben:
>> V1->V2:
>> Patch 1: Treat a hole just like an unallocated area. [Ilya]
>> Patch 2: Apply workaround only for pre-Quincy librbd versions and
>> ensure default
Am 19.01.22 um 15:57 schrieb Stefano Garzarella:
> On Fri, Jan 14, 2022 at 11:58:40AM +0100, Ilya Dryomov wrote:
>> On Thu, Jan 13, 2022 at 3:44 PM Peter Lieven wrote:
>>>
>>> V1->V2:
>>> Patch 1: Treat a hole just like an unallocated area. [Ilya]
>
...@nongnu.org
Signed-off-by: Peter Lieven
---
block/rbd.c | 42 --
1 file changed, 40 insertions(+), 2 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index 20bb896c4a..d174d51659 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -1320,6 +1320,7 @@ static
a hole like an unallocated area. There are no
callbacks
for unallocated areas so just bail out if we hit a hole.
Fixes: 0347a8fd4c3faaedf119be04c197804be40a384b
Suggested-by: Ilya Dryomov
Cc: qemu-sta...@nongnu.org
Signed-off-by: Peter Lieven
---
block/rbd.c | 10 +-
1 file changed, 5
V1->V2:
Patch 1: Treat a hole just like an unallocated area. [Ilya]
Patch 2: Apply workaround only for pre-Quincy librbd versions and
ensure default striping and non child images. [Ilya]
Peter Lieven (2):
block/rbd: fix handling of holes in .bdrv_co_block_status
block/
> Am 12.01.2022 um 22:06 schrieb Ilya Dryomov :
>
> On Wed, Jan 12, 2022 at 9:39 PM Peter Lieven wrote:
>>
>>> Am 12.01.22 um 10:05 schrieb Ilya Dryomov:
>>> On Mon, Jan 10, 2022 at 12:42 PM Peter Lieven wrote:
>>>> the assumption that
Am 12.01.22 um 10:05 schrieb Ilya Dryomov:
> On Mon, Jan 10, 2022 at 12:42 PM Peter Lieven wrote:
>> the assumption that we can't hit a hole if we do not diff against a snapshot
>> was wrong.
>>
>> We can see a hole in an image if we diff against base if there e
Am 12.01.22 um 10:59 schrieb Ilya Dryomov:
> On Mon, Jan 10, 2022 at 12:43 PM Peter Lieven wrote:
>> librbd had a bug until early 2022 that affected all versions of ceph that
>> supported fast-diff. This bug results in reporting of incorrect offsets
>> if the offset parameter
Am 10.01.22 um 15:18 schrieb Stefano Garzarella:
> On Mon, Jan 10, 2022 at 12:41:54PM +0100, Peter Lieven wrote:
>> librbd had a bug until early 2022 that affected all versions of ceph that
>> supported fast-diff. This bug results in reporting of incorrect offsets
>> if
: 0347a8fd4c3faaedf119be04c197804be40a384b
Cc: qemu-sta...@nongnu.org
Signed-off-by: Peter Lieven
---
block/rbd.c | 55 +
1 file changed, 34 insertions(+), 21 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index def96292e0..5e9dc91d81 100644
--- a/block/rbd.c
+++ b
Peter Lieven (2):
block/rbd: fix handling of holes in .bdrv_co_block_status
block/rbd: workaround for ceph issue #53784
block/rbd.c | 72 +
1 file changed, 50 insertions(+), 22 deletions(-)
--
2.25.1
://tracker.ceph.com/issues/53784
Cc: qemu-sta...@nongnu.org
Signed-off-by: Peter Lieven
---
block/rbd.c | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/block/rbd.c b/block/rbd.c
index 5e9dc91d81..260cb9f4b4 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -1333,6
Am 06.01.22 um 17:01 schrieb Ilya Dryomov:
> On Thu, Jan 6, 2022 at 4:27 PM Peter Lieven wrote:
>> Am 05.10.21 um 10:36 schrieb Ilya Dryomov:
>>> On Tue, Oct 5, 2021 at 10:19 AM Peter Lieven wrote:
>>>> Am 05.10.21 um 09:54 schrieb Ilya Dryomov:
>>>>>
Am 06.01.22 um 18:47 schrieb Ilya Dryomov:
> On Thu, Jan 6, 2022 at 5:33 PM Peter Lieven wrote:
>> Am 06.01.22 um 17:01 schrieb Ilya Dryomov:
>>> On Thu, Jan 6, 2022 at 4:27 PM Peter Lieven wrote:
>>>> Am 05.10.21 um 10:36 schrieb Ilya Dryomov:
>>>>>
Am 06.01.22 um 17:01 schrieb Ilya Dryomov:
On Thu, Jan 6, 2022 at 4:27 PM Peter Lieven wrote:
Am 05.10.21 um 10:36 schrieb Ilya Dryomov:
On Tue, Oct 5, 2021 at 10:19 AM Peter Lieven wrote:
Am 05.10.21 um 09:54 schrieb Ilya Dryomov:
On Thu, Sep 16, 2021 at 2:21 PM Peter Lieven wrote
Am 05.10.21 um 10:36 schrieb Ilya Dryomov:
On Tue, Oct 5, 2021 at 10:19 AM Peter Lieven wrote:
Am 05.10.21 um 09:54 schrieb Ilya Dryomov:
On Thu, Sep 16, 2021 at 2:21 PM Peter Lieven wrote:
the qemu rbd driver currently lacks support for bdrv_co_block_status.
This results mainly
kiy (1):
> qemu-img: make is_allocated_sectors() more efficient
>
> qemu-img.c | 23 +++
> tests/qemu-iotests/122 | 1 +
> tests/qemu-iotests/122.out | 2 ++
> 3 files changed, 22 insertions(+), 4 deletions(-)
>
Tested-by: Peter Lieven
Am 04.12.21 um 00:04 schrieb Vladimir Sementsov-Ogievskiy:
> 03.12.2021 14:17, Peter Lieven wrote:
>> Am 19.05.21 um 18:48 schrieb Kevin Wolf:
>>> Am 19.05.2021 um 15:24 hat Peter Lieven geschrieben:
>>>> Am 20.04.21 um 18:52 schrieb Vladimir Sementsov-Ogievskiy:
>
> Am 04.12.2021 um 00:04 schrieb Vladimir Sementsov-Ogievskiy
> :
>
> 03.12.2021 14:17, Peter Lieven wrote:
>>> Am 19.05.21 um 18:48 schrieb Kevin Wolf:
>>> Am 19.05.2021 um 15:24 hat Peter Lieven geschrieben:
>>>> Am 20.04.21 um 18:52 schrieb Vlad
Am 19.05.21 um 18:48 schrieb Kevin Wolf:
> Am 19.05.2021 um 15:24 hat Peter Lieven geschrieben:
>> Am 20.04.21 um 18:52 schrieb Vladimir Sementsov-Ogievskiy:
>>> 20.04.2021 18:04, Kevin Wolf wrote:
>>>> Am 20.04.2021 um 16:31 hat Vladimir Sementsov-Ogievskiy gesch
Am 26.10.21 um 16:53 schrieb Peter Lieven:
Am 25.10.21 um 14:58 schrieb Kevin Wolf:
Am 25.10.2021 um 13:39 hat Peter Lieven geschrieben:
Am 16.09.21 um 14:34 schrieb Peter Lieven:
Am 09.07.21 um 12:21 schrieb Kevin Wolf:
Am 08.07.2021 um 20:23 hat Peter Lieven geschrieben:
Am 08.07.2021 um
Am 25.10.21 um 14:58 schrieb Kevin Wolf:
> Am 25.10.2021 um 13:39 hat Peter Lieven geschrieben:
>> Am 16.09.21 um 14:34 schrieb Peter Lieven:
>>> Am 09.07.21 um 12:21 schrieb Kevin Wolf:
>>>> Am 08.07.2021 um 20:23 hat Peter Lieven geschrieben:
>>>>&
Am 16.09.21 um 14:34 schrieb Peter Lieven:
Am 09.07.21 um 12:21 schrieb Kevin Wolf:
Am 08.07.2021 um 20:23 hat Peter Lieven geschrieben:
Am 08.07.2021 um 14:18 schrieb Kevin Wolf :
Am 07.07.2021 um 20:13 hat Peter Lieven geschrieben:
Am 06.07.2021 um 17:25 schrieb Kevin Wolf :
Am 06.07.2021
is not available all areas are reported to be allocated
which is the current behaviour if bdrv_co_block_status is not implemented.
Signed-off-by: Peter Lieven
---
block/rbd.c | 112
1 file changed, 112 insertions(+)
V4->V5:
- ren
is not available all areas are reported to be allocated
which is the current behaviour if bdrv_co_block_status is not implemented.
Signed-off-by: Peter Lieven
---
block/rbd.c | 111
1 file changed, 111 insertions(+)
V3->V4:
- make req.exi
Am 05.10.21 um 10:36 schrieb Ilya Dryomov:
On Tue, Oct 5, 2021 at 10:19 AM Peter Lieven wrote:
Am 05.10.21 um 09:54 schrieb Ilya Dryomov:
On Thu, Sep 16, 2021 at 2:21 PM Peter Lieven wrote:
the qemu rbd driver currently lacks support for bdrv_co_block_status.
This results mainly
Am 05.10.21 um 10:36 schrieb Ilya Dryomov:
On Tue, Oct 5, 2021 at 10:19 AM Peter Lieven wrote:
Am 05.10.21 um 09:54 schrieb Ilya Dryomov:
On Thu, Sep 16, 2021 at 2:21 PM Peter Lieven wrote:
the qemu rbd driver currently lacks support for bdrv_co_block_status.
This results mainly
Am 05.10.21 um 09:54 schrieb Ilya Dryomov:
On Thu, Sep 16, 2021 at 2:21 PM Peter Lieven wrote:
the qemu rbd driver currently lacks support for bdrv_co_block_status.
This results mainly in incorrect progress during block operations (e.g.
qemu-img convert with an rbd image as source
Am 09.07.21 um 12:21 schrieb Kevin Wolf:
Am 08.07.2021 um 20:23 hat Peter Lieven geschrieben:
Am 08.07.2021 um 14:18 schrieb Kevin Wolf :
Am 07.07.2021 um 20:13 hat Peter Lieven geschrieben:
Am 06.07.2021 um 17:25 schrieb Kevin Wolf :
Am 06.07.2021 um 16:55 hat Peter Lieven geschrieben:
I
is not available all areas are reported to be allocated
which is the current behaviour if bdrv_co_block_status is not implemented.
Signed-off-by: Peter Lieven
---
V2->V3:
- check rbd_flags every time (they can change during runtime) [Ilya]
- also check for fast-diff invalid flag [Ilya]
- *
Am 24.08.21 um 22:39 schrieb Ilya Dryomov:
On Mon, Aug 23, 2021 at 11:38 AM Peter Lieven wrote:
Am 22.08.21 um 23:02 schrieb Ilya Dryomov:
On Tue, Aug 10, 2021 at 3:41 PM Peter Lieven wrote:
the qemu rbd driver currently lacks support for bdrv_co_block_status.
This results mainly
Am 22.08.21 um 23:02 schrieb Ilya Dryomov:
On Tue, Aug 10, 2021 at 3:41 PM Peter Lieven wrote:
the qemu rbd driver currently lacks support for bdrv_co_block_status.
This results mainly in incorrect progress during block operations (e.g.
qemu-img convert with an rbd image as source
is not available all areas are reported to be allocated
which is the current behaviour if bdrv_co_block_status is not implemented.
Signed-off-by: Peter Lieven
---
V1->V2:
- add commit comment [Stefano]
- use failed_post_open [Stefano]
- remove redundant assert [Stefano]
- add macro+comment for the ma
Am 10.08.21 um 10:51 schrieb Stefano Garzarella:
On Mon, Aug 09, 2021 at 03:41:36PM +0200, Peter Lieven wrote:
Please, can you add a description?
For example also describing what happens if RBD image does not support
RBD_FEATURE_FAST_DIFF.
Sure.
Signed-off-by: Peter Lieven
---
block
Signed-off-by: Peter Lieven
---
block/rbd.c | 119
1 file changed, 119 insertions(+)
diff --git a/block/rbd.c b/block/rbd.c
index dcf82b15b8..ef1eaa6af3 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -88,6 +88,7 @@ typedef struct BDRVRBDState
> Am 08.07.2021 um 14:18 schrieb Kevin Wolf :
>
> Am 07.07.2021 um 20:13 hat Peter Lieven geschrieben:
>>> Am 06.07.2021 um 17:25 schrieb Kevin Wolf :
>>> Am 06.07.2021 um 16:55 hat Peter Lieven geschrieben:
>>>> I will have a decent look after my vacati
> Am 06.07.2021 um 17:25 schrieb Kevin Wolf :
>
> Am 06.07.2021 um 16:55 hat Peter Lieven geschrieben:
>>> Am 06.07.2021 um 15:19 schrieb Kevin Wolf :
>>>
>>> Am 02.07.2021 um 19:23 hat Ilya Dryomov geschrieben:
>>>> This series migrate
task->complete is a bool not an integer.
Signed-off-by: Peter Lieven
---
block/rbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/rbd.c b/block/rbd.c
index 01a7b94d62..dcf82b15b8 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -1066,7 +1066,7 @@ static
adding myself as a designated reviewer.
Signed-off-by: Peter Lieven
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 516db737d1..cfda57e825 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3058,6 +3058,7 @@ F: block/vmdk.c
RBD
M: Ilya Dryomov
> Am 06.07.2021 um 17:25 schrieb Kevin Wolf :
>
> Am 06.07.2021 um 16:55 hat Peter Lieven geschrieben:
>>>> Am 06.07.2021 um 15:19 schrieb Kevin Wolf :
>>>
>>> Am 02.07.2021 um 19:23 hat Ilya Dryomov geschrieben:
>>>> This series migr
> Am 06.07.2021 um 15:19 schrieb Kevin Wolf :
>
> Am 02.07.2021 um 19:23 hat Ilya Dryomov geschrieben:
>> This series migrates the qemu rbd driver from the old aio emulation
>> to native coroutines and adds write zeroes support which is important
>> for block operations.
>>
>> To achieve
> Am 02.07.2021 um 14:46 schrieb Ilya Dryomov :
>
> On Fri, Jul 2, 2021 at 11:09 AM Peter Lieven wrote:
>>
>> this series migrates the qemu rbd driver from the old aio emulation
>> to native coroutines and adds write zeroes support which is import
oes is always efficient:
$ qemu-io -c 'help write' | grep -- '-[zun]'
-n, -- with -z, don't allow slow fallback
-u, -- with -z, allow unmapping
-z, -- write zeroes using blk_co_pwrite_zeroes
$ qemu-io -f rbd -c 'write -z -u -n 0 1M' rbd:foo/bar
write failed: Operation not suppor
librbd supports 1 byte alignment for all aio operations.
Currently, there is no API call to query limits from the ceph backend.
So drop the bdrv_refresh_limits completely until there is such an API call.
Signed-off-by: Peter Lieven
Reviewed-by: Ilya Dryomov
---
block/rbd.c | 9 -
1
even luminous (version 12.2) is unmaintained for over 3 years now.
Bump the requirement to get rid of the ifdef'ry in the code.
Qemu 6.1 dropped the support for RHEL-7 which was the last supported
OS that required an older librbd.
Signed-off-by: Peter Lieven
---
block/rbd.c | 120
return error codes from librbd
- Patch 6: - add support for thick provisioning [Jason]
- do not set write zeroes alignment
- Patch 7: new patch
Peter Lieven (6):
block/rbd: bump librbd requirement to luminous release
block/rbd: store object_size in BDRVRBDState
block/rbd: update s
Signed-off-by: Peter Lieven
Reviewed-by: Ilya Dryomov
---
block/rbd.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index 6b1cbe1d75..b4caea4f1b 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -90,6 +90,7 @@ typedef struct
Signed-off-by: Peter Lieven
---
block/rbd.c | 252 +++-
1 file changed, 90 insertions(+), 162 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index 1f8dc84079..be0471944a 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -66,22 +66,6 @@ typedef
while at it just call rbd_get_size and avoid rbd_stat.
Signed-off-by: Peter Lieven
---
block/rbd.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index b4caea4f1b..1f8dc84079 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -968,15 +968,14
> Am 26.06.2021 um 17:57 schrieb Ilya Dryomov :
>
> On Mon, Jun 21, 2021 at 10:49 AM Peter Lieven wrote:
>>
>>> Am 18.06.21 um 12:34 schrieb Ilya Dryomov:
>>> On Fri, Jun 18, 2021 at 11:00 AM Peter Lieven wrote:
>>>> Am 16.06.21 um 14:34 sch
Am 18.06.21 um 12:34 schrieb Ilya Dryomov:
On Fri, Jun 18, 2021 at 11:00 AM Peter Lieven wrote:
Am 16.06.21 um 14:34 schrieb Ilya Dryomov:
On Wed, May 19, 2021 at 4:28 PM Peter Lieven wrote:
Signed-off-by: Peter Lieven
---
block/rbd.c | 37 -
1 file
Am 17.06.21 um 16:43 schrieb Ilya Dryomov:
> On Wed, May 19, 2021 at 4:27 PM Peter Lieven wrote:
>> Signed-off-by: Peter Lieven
>> ---
>> block/rbd.c | 255 ++--
>> 1 file changed, 87 insertions(+), 168 deletions(-)
>
Am 16.06.21 um 14:34 schrieb Ilya Dryomov:
> On Wed, May 19, 2021 at 4:28 PM Peter Lieven wrote:
>> Signed-off-by: Peter Lieven
>> ---
>> block/rbd.c | 37 -
>> 1 file changed, 36 insertions(+), 1 deletion(-)
>>
>>
Am 16.06.21 um 14:26 schrieb Ilya Dryomov:
> On Wed, May 19, 2021 at 4:26 PM Peter Lieven wrote:
>> even luminous (version 12.2) is unmaintained for over 3 years now.
>> Bump the requirement to get rid of the ifdef'ry in the code.
>> Qemu 6.1 dropped the support for RHEL
Signed-off-by: Peter Lieven
---
block/rbd.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index 6b1cbe1d75..b4caea4f1b 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -90,6 +90,7 @@ typedef struct BDRVRBDState {
char *snap
Signed-off-by: Peter Lieven
---
block/rbd.c | 37 -
1 file changed, 36 insertions(+), 1 deletion(-)
diff --git a/block/rbd.c b/block/rbd.c
index 0d8612a988..ee13f08a74 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -63,7 +63,8 @@ typedef enum
Signed-off-by: Peter Lieven
---
block/rbd.c | 255 ++--
1 file changed, 87 insertions(+), 168 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index 97a2ae4c84..0d8612a988 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -66,22 +66,6 @@ typedef
librbd supports 1 byte alignment for all aio operations.
Currently, there is no API call to query limits from the ceph backend.
So drop the bdrv_refresh_limits completely until there is such an API call.
Signed-off-by: Peter Lieven
---
block/rbd.c | 9 -
1 file changed, 9 deletions
6: - add support for thick provisioning [Jason]
- do not set write zeroes alignment
- Patch 7: new patch
Peter Lieven (6):
block/rbd: bump librbd requirement to luminous release
block/rbd: store object_size in BDRVRBDState
block/rbd: update s->image_size in qemu_rbd_getlength
in case the image size changed we should adjust our internally stored size as
well.
Signed-off-by: Peter Lieven
---
block/rbd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/rbd.c b/block/rbd.c
index b4caea4f1b..97a2ae4c84 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -976,6 +976,7
even luminous (version 12.2) is unmaintained for over 3 years now.
Bump the requirement to get rid of the ifdef'ry in the code.
Qemu 6.1 dropped the support for RHEL-7 which was the last supported
OS that required an older librbd.
Signed-off-by: Peter Lieven
---
block/rbd.c | 120
Am 20.04.21 um 18:52 schrieb Vladimir Sementsov-Ogievskiy:
> 20.04.2021 18:04, Kevin Wolf wrote:
>> Am 20.04.2021 um 16:31 hat Vladimir Sementsov-Ogievskiy geschrieben:
>>> 15.04.2021 18:22, Kevin Wolf wrote:
In order to avoid RMW cycles, is_allocated_sectors() treats zeroed areas
like
Von meinem iPhone gesendet
> Am 19.04.2021 um 14:31 schrieb Kevin Wolf :
>
> Am 19.04.2021 um 11:13 hat Peter Lieven geschrieben:
>>
>>
>>>> Am 19.04.2021 um 10:36 schrieb Peter Lieven :
>>>
>>>
>>>
>>>> Am 15.04.
> Am 19.04.2021 um 10:36 schrieb Peter Lieven :
>
>
>
>> Am 15.04.2021 um 17:22 schrieb Kevin Wolf :
>>
>> Peter, three years ago you changed 'qemu-img convert' to sacrifice some
>> sparsification in order to get aligned requests on the target image.
> Am 15.04.2021 um 17:22 schrieb Kevin Wolf :
>
> Peter, three years ago you changed 'qemu-img convert' to sacrifice some
> sparsification in order to get aligned requests on the target image. At
> the time, I thought the impact would be small, but it turns out that
> this can end up wasting
Am 03.03.21 um 19:47 schrieb Jason Dillaman:
> On Wed, Mar 3, 2021 at 12:41 PM Stefano Garzarella
> wrote:
>> Hi Jason,
>> as reported in this BZ [1], when qemu-img creates a QCOW2 image on RBD
>> writing data is very slow compared to a raw file.
>>
>> Comparing raw vs QCOW2 image creation with
Am 01.03.21 um 11:59 schrieb Kevin Wolf:
> Am 26.02.2021 um 13:33 hat Peter Lieven geschrieben:
>> Am 26.02.21 um 10:27 schrieb Alberto Garcia:
>>> On Thu 25 Feb 2021 06:34:48 PM CET, Peter Lieven wrote:
>>>> I was wondering if there is a way to check from outside
Am 26.02.21 um 10:27 schrieb Alberto Garcia:
> On Thu 25 Feb 2021 06:34:48 PM CET, Peter Lieven wrote:
>> I was wondering if there is a way to check from outside (qmp etc.) if
>> a throttled block device has exceeded the iops_max_length seconds of
>> time bursting up to iop
Hi,
I was wondering if there is a way to check from outside (qmp etc.) if a
throttled block device has exceeded the iops_max_length seconds of time
bursting up to iops_max and is now hard limited to the iops limit that is
supplied?
Would it be also a good idea to exetend the accounting to
Am 15.02.21 um 13:13 schrieb Kevin Wolf:
Am 15.02.2021 um 12:45 hat Peter Lieven geschrieben:
Am 15.02.21 um 12:41 schrieb Daniel P. Berrangé:
On Mon, Feb 15, 2021 at 12:32:24PM +0100, Peter Lieven wrote:
Am 15.02.21 um 11:24 schrieb Daniel P. Berrangé:
On Tue, Jan 26, 2021 at 12:25:34PM
Am 15.02.21 um 12:51 schrieb Daniel P. Berrangé:
On Mon, Feb 15, 2021 at 12:45:01PM +0100, Peter Lieven wrote:
Am 15.02.21 um 12:41 schrieb Daniel P. Berrangé:
On Mon, Feb 15, 2021 at 12:32:24PM +0100, Peter Lieven wrote:
Am 15.02.21 um 11:24 schrieb Daniel P. Berrangé:
On Tue, Jan 26, 2021
Am 15.02.21 um 11:20 schrieb Kevin Wolf:
Am 26.01.2021 um 12:25 hat Peter Lieven geschrieben:
Signed-off-by: Peter Lieven
---
block/rbd.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index f68ebcf240..7abd0252c9 100644
Am 15.02.21 um 12:41 schrieb Daniel P. Berrangé:
On Mon, Feb 15, 2021 at 12:32:24PM +0100, Peter Lieven wrote:
Am 15.02.21 um 11:24 schrieb Daniel P. Berrangé:
On Tue, Jan 26, 2021 at 12:25:34PM +0100, Peter Lieven wrote:
even luminous (version 12.2) is unmaintained for over 3 years now.
Bump
Am 15.02.21 um 11:19 schrieb Daniel P. Berrangé:
On Mon, Feb 15, 2021 at 11:11:23AM +0100, Kevin Wolf wrote:
Am 26.01.2021 um 12:25 hat Peter Lieven geschrieben:
even luminous (version 12.2) is unmaintained for over 3 years now.
Bump the requirement to get rid of the ifdef'ry in the code
Am 15.02.21 um 11:24 schrieb Daniel P. Berrangé:
On Tue, Jan 26, 2021 at 12:25:34PM +0100, Peter Lieven wrote:
even luminous (version 12.2) is unmaintained for over 3 years now.
Bump the requirement to get rid of the ifdef'ry in the code.
We have clear rules on when we bump minimum versions
Am 05.02.21 um 09:18 schrieb Max Reitz:
> On 04.02.21 21:09, Peter Lieven wrote:
>> Am 02.02.21 um 16:51 schrieb Eric Blake:
>>> On 1/28/21 8:07 AM, Peter Lieven wrote:
>>>> Signed-off-by: Peter Lieven
>>> Your commit message says 'what', but not 'why'. G
Am 02.02.21 um 16:51 schrieb Eric Blake:
> On 1/28/21 8:07 AM, Peter Lieven wrote:
>> Signed-off-by: Peter Lieven
> Your commit message says 'what', but not 'why'. Generally, the one-line
> 'what' works well as the subject line, but you want the commit body to
> give an argum
Signed-off-by: Peter Lieven
diff --git a/docs/tools/qemu-img.rst b/docs/tools/qemu-img.rst
index b615aa8419..7d4564c2b8 100644
--- a/docs/tools/qemu-img.rst
+++ b/docs/tools/qemu-img.rst
@@ -209,6 +209,10 @@ Parameters to dd subcommand:
.. program:: qemu-img-dd
+.. option:: -n
+
+ Skip
Signed-off-by: Peter Lieven
---
block/rbd.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index a191c74619..1028596c68 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -90,6 +90,7 @@ typedef struct BDRVRBDState {
char *snap
even luminous (version 12.2) is unmaintained for over 3 years now.
Bump the requirement to get rid of the ifdef'ry in the code.
Signed-off-by: Peter Lieven
---
block/rbd.c | 120
meson.build | 13 --
2 files changed, 17 insertions
in case the image size changed we should adjust our internally stored size as
well.
Signed-off-by: Peter Lieven
---
block/rbd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/rbd.c b/block/rbd.c
index 1028596c68..f68ebcf240 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -964,6 +964,7
Signed-off-by: Peter Lieven
---
block/rbd.c | 253 ++--
1 file changed, 86 insertions(+), 167 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index 7abd0252c9..d11a3c6dd1 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -66,22 +66,6 @@ typedef
librbd supports 1 byte alignment for all aio operations.
Currently, there is no API call to query limits from the ceph backend.
So drop the bdrv_refresh_limits completely until there is such an API call.
Signed-off-by: Peter Lieven
---
block/rbd.c | 9 -
1 file changed, 9 deletions
Signed-off-by: Peter Lieven
---
block/rbd.c | 36 +++-
1 file changed, 35 insertions(+), 1 deletion(-)
diff --git a/block/rbd.c b/block/rbd.c
index d11a3c6dd1..35dc1dc90e 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -63,7 +63,8 @@ typedef enum
son]
- do not set write zeroes alignment
- Patch 7: new patch
Peter Lieven (7):
block/rbd: bump librbd requirement to luminous release
block/rbd: store object_size in BDRVRBDState
block/rbd: update s->image_size in qemu_rbd_getlength
block/rbd: add bdrv_attach_aio_context
Signed-off-by: Peter Lieven
---
block/rbd.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index f68ebcf240..7abd0252c9 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -91,6 +91,7 @@ typedef struct BDRVRBDState {
char *namespace
error('could not link librados')
> +else
> + warning('could not link librados, disabling')
> +endif
>endif
> endif
>
That was fast, tank you.
Tested-by: Peter Lieven
Peter
Am 25.01.21 um 22:57 schrieb Paolo Bonzini:
> On 25/01/21 20:47, Peter Lieven wrote:
>>> Can you include the meson-logs/meson-log.txt output?
>>
>> Sure:https://pastebin.com/u3XtbDvQ
>
> Does this work for you?
>
> diff --git a/meson.build b/meson.build
&
Am 25.01.21 um 16:24 schrieb Paolo Bonzini:
> On 25/01/21 15:31, Peter Lieven wrote:
>> on Dedian / Ubuntu configure does no longer detect librbd / librados
>> since the switch to meson.
>>
>> I need to add dirs: ['/usr/lib'] to the cc.find_library for librados
>>
Am 25.01.21 um 15:13 schrieb Peter Lieven:
> Hi,
>
>
> on Dedian / Ubuntu configure does no longer detect librbd / librados since
> the switch to meson.
>
> I need to add dirs: ['/usr/lib'] to the cc.find_library for librados and
> librbd. But I am not familiar with
Hi,
on Dedian / Ubuntu configure does no longer detect librbd / librados since the
switch to meson.
I need to add dirs: ['/usr/lib'] to the cc.find_library for librados and
librbd. But I am not familiar with meson
and can't say if thats the appropriate fix.
I would be thankful for a hint.
Am 21.01.21 um 20:42 schrieb Jason Dillaman:
> On Wed, Jan 20, 2021 at 6:01 PM Peter Lieven wrote:
>>
>>> Am 19.01.2021 um 15:20 schrieb Jason Dillaman :
>>>
>>> On Tue, Jan 19, 2021 at 4:36 AM Peter Lieven wrote:
>>>>> Am 18.01.21 um 23:33
> Am 19.01.2021 um 15:20 schrieb Jason Dillaman :
>
> On Tue, Jan 19, 2021 at 4:36 AM Peter Lieven wrote:
>>> Am 18.01.21 um 23:33 schrieb Jason Dillaman:
>>> On Fri, Jan 15, 2021 at 10:39 AM Peter Lieven wrote:
>>>> Am 15.01.21 um 16:27 schrieb Jas
1 - 100 of 2519 matches
Mail list logo
