Re: [PATCH][Qemu-devel] Single stepping for PPC broken!

2008-03-11 Thread Jason Wessel
Marius Groeger wrote: On Wed, 9 Jan 2008, Marius Groeger wrote: On Wed, 9 Jan 2008, Marius Groeger wrote: I'm having problems with qemu's (-M prep, -cpu 604) handling of the MSR_SE bit. My gdbstub can successfully step along regular code, but qemu chokes when stepping over a

Re: [PATCH][Qemu-devel] Single stepping for PPC broken!

2008-02-13 Thread Marius Groeger
On Mon, 11 Feb 2008, Rob Landley wrote: On Thursday 10 January 2008 07:57:50 Marius Groeger wrote: The attached patch fixes the problem, but I have to admit I can't tell for sure if this doesn't break other things (such as qemu's built-in GDB server). Could some QEMU ppc expert please

Re: [PATCH][Qemu-devel] Single stepping for PPC broken!

2008-02-13 Thread Daniel Jacobowitz
On Wed, Feb 13, 2008 at 09:46:44AM +0100, Marius Groeger wrote: if ((tb-pc TARGET_PAGE_MASK) == (dest TARGET_PAGE_MASK) !ctx-singlestep_enabled) { .. } else { gen_set_T1(dest); #if defined(TARGET_PPC64) if (ctx-sf_mode) gen_op_b_T1_64(); else #endif

Re: [PATCH][Qemu-devel] Single stepping for PPC broken!

2008-02-13 Thread Daniel Jacobowitz
On Wed, Feb 13, 2008 at 04:52:22PM +0100, Marius Groeger wrote: On Wed, 13 Feb 2008, Daniel Jacobowitz wrote: On Wed, Feb 13, 2008 at 09:46:44AM +0100, Marius Groeger wrote: if ((tb-pc TARGET_PAGE_MASK) == (dest TARGET_PAGE_MASK) !ctx-singlestep_enabled) { No, if you've

Re: [PATCH][Qemu-devel] Single stepping for PPC broken!

2008-02-13 Thread Marius Groeger
On Wed, 13 Feb 2008, Daniel Jacobowitz wrote: The else block will be entered if !A, or if A B. Yeah - oops - sorry :-) Regards Marius -- Marius Groeger SYSGO AG Embedded and Real-Time Software Voice: +49 6136 9948 0 FAX: +49 6136 9948 10 www.sysgo.com |

Re: [PATCH][Qemu-devel] Single stepping for PPC broken!

2008-02-11 Thread Rob Landley
On Thursday 10 January 2008 07:57:50 Marius Groeger wrote: The attached patch fixes the problem, but I have to admit I can't tell for sure if this doesn't break other things (such as qemu's built-in GDB server). Could some QEMU ppc expert please comment on this? Looks fine to me, but I don't

Re: [PATCH][Qemu-devel] Single stepping for PPC broken!

2008-01-10 Thread Marius Groeger
On Wed, 9 Jan 2008, Marius Groeger wrote: On Wed, 9 Jan 2008, Marius Groeger wrote: I'm having problems with qemu's (-M prep, -cpu 604) handling of the MSR_SE bit. My gdbstub can successfully step along regular code, but qemu chokes when stepping over a branch instruction like blr.