Hi Peter,
> From: Peter Maydell
> Sent: Tuesday, May 7, 2024 10:03 AM
>
> On Tue, 7 May 2024 at 01:11, Salil Mehta wrote:
> >
> > > From: Peter Maydell
> > > Sent: Monday, May 6, 2024 10:29 AM
> > > To: Salil Mehta
> > >
> > > On Mon, 6 May 2024 at 10:06, Salil Mehta
> > >
On Tue, 7 May 2024 at 01:11, Salil Mehta wrote:
>
> > From: Peter Maydell
> > Sent: Monday, May 6, 2024 10:29 AM
> > To: Salil Mehta
> >
> > On Mon, 6 May 2024 at 10:06, Salil Mehta
> > wrote:
> > >
> > > Hi Peter,
> > >
> > > Thanks for the review.
> > >
> > > > From: Peter
> From: Peter Maydell
> Sent: Monday, May 6, 2024 10:29 AM
> To: Salil Mehta
>
> On Mon, 6 May 2024 at 10:06, Salil Mehta
> wrote:
> >
> > Hi Peter,
> >
> > Thanks for the review.
> >
> > > From: Peter Maydell When do we need to
> > > destroy a single address space in this way
On Mon, 6 May 2024 at 10:06, Salil Mehta wrote:
>
> Hi Peter,
>
> Thanks for the review.
>
> > From: Peter Maydell
> > When do we need to destroy a single address space in this way that means
> > we need to keep a count of how many ASes the CPU currently has? The
> > commit message talks
Hi Peter,
Thanks for the review.
> From: Peter Maydell
> Sent: Saturday, May 4, 2024 2:41 PM
>
> On Tue, 12 Mar 2024 at 02:02, Salil Mehta
> wrote:
> >
> > Virtual CPU Hot-unplug leads to unrealization of a CPU object. This
> > also involves destruction of the CPU AddressSpace. Add
On Tue, 12 Mar 2024 at 02:02, Salil Mehta wrote:
>
> Virtual CPU Hot-unplug leads to unrealization of a CPU object. This also
> involves destruction of the CPU AddressSpace. Add common function to help
> destroy the CPU AddressSpace.
>
> Signed-off-by: Salil Mehta
> Tested-by: Vishnu Pajjuri
>
Hi Zhukeqian,
On Fri, Mar 15, 2024 at 1:17 AM zhukeqian wrote:
> Hi Salil,
>
> [...]
>
> +void cpu_address_space_destroy(CPUState *cpu, int asidx) {
> +CPUAddressSpace *cpuas;
> +
> +assert(cpu->cpu_ases);
> +assert(asidx >= 0 && asidx < cpu->num_ases);
> +/* KVM cannot
Hi Salil,
[...]
+void cpu_address_space_destroy(CPUState *cpu, int asidx) {
+CPUAddressSpace *cpuas;
+
+assert(cpu->cpu_ases);
+assert(asidx >= 0 && asidx < cpu->num_ases);
+/* KVM cannot currently support multiple address spaces. */
+assert(asidx == 0 || !kvm_enabled());
+
+
Virtual CPU Hot-unplug leads to unrealization of a CPU object. This also
involves destruction of the CPU AddressSpace. Add common function to help
destroy the CPU AddressSpace.
Signed-off-by: Salil Mehta
Tested-by: Vishnu Pajjuri
Reviewed-by: Gavin Shan
Tested-by: Xianglai Li
Tested-by:
