Re: [PATCH v2 1/2] igb: fix link state on resume

2024-01-31 Thread Jason Wang
On Wed, Jan 24, 2024 at 6:30 PM Laurent Vivier wrote: > > On resume igb_vm_state_change() always calls igb_autoneg_resume() > that sets link_down to false, and thus activates the link even > if we have disabled it. > > The problem can be reproduced starting qemu in paused state (-S) and > then

Re: [PATCH v2 1/2] igb: fix link state on resume

2024-01-28 Thread Akihiko Odaki
On 2024/01/24 19:29, Laurent Vivier wrote: On resume igb_vm_state_change() always calls igb_autoneg_resume() that sets link_down to false, and thus activates the link even if we have disabled it. The problem can be reproduced starting qemu in paused state (-S) and then set the link to down.

[PATCH v2 1/2] igb: fix link state on resume

2024-01-24 Thread Laurent Vivier
On resume igb_vm_state_change() always calls igb_autoneg_resume() that sets link_down to false, and thus activates the link even if we have disabled it. The problem can be reproduced starting qemu in paused state (-S) and then set the link to down. When we resume the machine the link appears to