Re: [PATCH v3 01/12] util/log: convert debug_regions to GList

2024-03-04 Thread Sven Schnelle
Alex Bennée writes: >> So i wonder >> whether we should convert all of those functions to GArray? (if >> possible, i haven't checked) > > I think that would depend on access patterns and flexibility. For the > dfilter there is no particular need for sorting and the principle > operation is a

Re: [PATCH v3 01/12] util/log: convert debug_regions to GList

2024-03-04 Thread Alex Bennée
Sven Schnelle writes: > Alex Bennée writes: > >> Sven Schnelle writes: >> >>> In preparation of making the parsing part of qemu_set_dfilter_ranges() >>> available to other users, convert it to return a GList, so the result >>> can be used with other functions taking a GList of struct Range. >>

Re: [PATCH v3 01/12] util/log: convert debug_regions to GList

2024-03-04 Thread Richard Henderson
On 3/4/24 03:13, Sven Schnelle wrote: Alex Bennée writes: Sven Schnelle writes: In preparation of making the parsing part of qemu_set_dfilter_ranges() available to other users, convert it to return a GList, so the result can be used with other functions taking a GList of struct Range.

Re: [PATCH v3 01/12] util/log: convert debug_regions to GList

2024-03-04 Thread Sven Schnelle
Alex Bennée writes: > Sven Schnelle writes: > >> In preparation of making the parsing part of qemu_set_dfilter_ranges() >> available to other users, convert it to return a GList, so the result >> can be used with other functions taking a GList of struct Range. > > Why do we need to convert it

Re: [PATCH v3 01/12] util/log: convert debug_regions to GList

2024-03-04 Thread Sven Schnelle
Alex Bennée writes: > Sven Schnelle writes: > >> In preparation of making the parsing part of qemu_set_dfilter_ranges() >> available to other users, convert it to return a GList, so the result >> can be used with other functions taking a GList of struct Range. > > Why do we need to convert it

Re: [PATCH v3 01/12] util/log: convert debug_regions to GList

2024-03-04 Thread Alex Bennée
Sven Schnelle writes: > In preparation of making the parsing part of qemu_set_dfilter_ranges() > available to other users, convert it to return a GList, so the result > can be used with other functions taking a GList of struct Range. Why do we need to convert it to a Glist? When I originally

[PATCH v3 01/12] util/log: convert debug_regions to GList

2024-03-01 Thread Sven Schnelle
In preparation of making the parsing part of qemu_set_dfilter_ranges() available to other users, convert it to return a GList, so the result can be used with other functions taking a GList of struct Range. Signed-off-by: Sven Schnelle --- util/log.c | 36 ++-- 1