Re: [PATCH v3 1/1] os-posix: asynchronous teardown for shutdown on Linux

2022-08-30 Thread Markus Armbruster
Please excuse my late reply; I was on vacation. Daniel P. Berrangé writes: > On Tue, Aug 09, 2022 at 08:40:24AM +0200, Claudio Imbrenda wrote: >> This patch adds support for asynchronously tearing down a VM on Linux. >> >> When qemu terminates, either naturally or because of a fatal signal, >>

Re: [PATCH v3 1/1] os-posix: asynchronous teardown for shutdown on Linux

2022-08-23 Thread Daniel P . Berrangé
On Fri, Aug 12, 2022 at 09:26:23AM +0200, Claudio Imbrenda wrote: > On Thu, 11 Aug 2022 23:05:52 -0300 > Murilo Opsfelder Araújo wrote: > > > On 8/11/22 11:02, Daniel P. Berrangé wrote: > > [...] > > >>> Hmm, I was hoping you could just use SIGKILL to guarantee that this > > >>> gets killed off.

Re: [PATCH v3 1/1] os-posix: asynchronous teardown for shutdown on Linux

2022-08-12 Thread Claudio Imbrenda
On Fri, 12 Aug 2022 08:38:59 -0300 Murilo Opsfelder Araújo wrote: > On 8/12/22 04:26, Claudio Imbrenda wrote: > > On Thu, 11 Aug 2022 23:05:52 -0300 > > Murilo Opsfelder Araújo wrote: > > > >> On 8/11/22 11:02, Daniel P. Berrangé wrote: > >> [...] > > Hmm, I was hoping you could just

Re: [PATCH v3 1/1] os-posix: asynchronous teardown for shutdown on Linux

2022-08-12 Thread Murilo Opsfelder Araújo
On 8/12/22 04:26, Claudio Imbrenda wrote: On Thu, 11 Aug 2022 23:05:52 -0300 Murilo Opsfelder Araújo wrote: On 8/11/22 11:02, Daniel P. Berrangé wrote: [...] Hmm, I was hoping you could just use SIGKILL to guarantee that this gets killed off. Is SIGKILL delivered too soon to allow for the

Re: [PATCH v3 1/1] os-posix: asynchronous teardown for shutdown on Linux

2022-08-12 Thread Claudio Imbrenda
On Thu, 11 Aug 2022 23:05:52 -0300 Murilo Opsfelder Araújo wrote: > On 8/11/22 11:02, Daniel P. Berrangé wrote: > [...] > >>> Hmm, I was hoping you could just use SIGKILL to guarantee that this > >>> gets killed off. Is SIGKILL delivered too soon to allow for the > >>> main QEMU process to have

Re: [PATCH v3 1/1] os-posix: asynchronous teardown for shutdown on Linux

2022-08-11 Thread Murilo Opsfelder Araújo
On 8/11/22 11:02, Daniel P. Berrangé wrote: [...] Hmm, I was hoping you could just use SIGKILL to guarantee that this gets killed off. Is SIGKILL delivered too soon to allow for the main QEMU process to have exited quickly ? yes, I tried. qemu has not finished exiting when the signal is

Re: [PATCH v3 1/1] os-posix: asynchronous teardown for shutdown on Linux

2022-08-11 Thread Daniel P . Berrangé
On Thu, Aug 11, 2022 at 03:56:23PM +0200, Claudio Imbrenda wrote: > On Thu, 11 Aug 2022 13:27:44 +0100 > Daniel P. Berrangé wrote: > > > On Tue, Aug 09, 2022 at 08:40:24AM +0200, Claudio Imbrenda wrote: > > > This patch adds support for asynchronously tearing down a VM on Linux. > > > > > >

Re: [PATCH v3 1/1] os-posix: asynchronous teardown for shutdown on Linux

2022-08-11 Thread Claudio Imbrenda
On Thu, 11 Aug 2022 13:27:44 +0100 Daniel P. Berrangé wrote: > On Tue, Aug 09, 2022 at 08:40:24AM +0200, Claudio Imbrenda wrote: > > This patch adds support for asynchronously tearing down a VM on Linux. > > > > When qemu terminates, either naturally or because of a fatal signal, > > the VM is

Re: [PATCH v3 1/1] os-posix: asynchronous teardown for shutdown on Linux

2022-08-11 Thread Christian Borntraeger
Am 11.08.22 um 14:27 schrieb Daniel P. Berrangé: [...] --- a/qemu-options.hx +++ b/qemu-options.hx @@ -4743,6 +4743,23 @@ HXCOMM Internal use DEF("qtest", HAS_ARG, QEMU_OPTION_qtest, "", QEMU_ARCH_ALL) DEF("qtest-log", HAS_ARG, QEMU_OPTION_qtest_log, "", QEMU_ARCH_ALL) +#ifdef

Re: [PATCH v3 1/1] os-posix: asynchronous teardown for shutdown on Linux

2022-08-11 Thread Daniel P . Berrangé
On Tue, Aug 09, 2022 at 08:40:24AM +0200, Claudio Imbrenda wrote: > This patch adds support for asynchronously tearing down a VM on Linux. > > When qemu terminates, either naturally or because of a fatal signal, > the VM is torn down. If the VM is huge, it can take a considerable > amount of time

Re: [PATCH v3 1/1] os-posix: asynchronous teardown for shutdown on Linux

2022-08-11 Thread Claudio Imbrenda
On Wed, 10 Aug 2022 17:30:41 -0300 Murilo Opsfelder Araújo wrote: > Hi, Claudio. Hi Murilo, [...] > I've smoke-tested this on ppc and everything looks fine. > For what's worth: > > Reviewed-by: Murilo Opsfelder Araujo > Tested-by: Murilo Opsfelder Araujo thanks a lot for testing this! >

Re: [PATCH v3 1/1] os-posix: asynchronous teardown for shutdown on Linux

2022-08-10 Thread Murilo Opsfelder Araújo
Hi, Claudio. On 8/9/22 03:40, Claudio Imbrenda wrote: This patch adds support for asynchronously tearing down a VM on Linux. When qemu terminates, either naturally or because of a fatal signal, the VM is torn down. If the VM is huge, it can take a considerable amount of time for it to be

[PATCH v3 1/1] os-posix: asynchronous teardown for shutdown on Linux

2022-08-09 Thread Claudio Imbrenda
This patch adds support for asynchronously tearing down a VM on Linux. When qemu terminates, either naturally or because of a fatal signal, the VM is torn down. If the VM is huge, it can take a considerable amount of time for it to be cleaned up. In case of a protected VM, it might take even