Re: [PATCH v3 10/26] migration: Move cleanup after after error reporting in qemu_savevm_state_setup()

2024-03-04 Thread Cédric Le Goater
On 3/5/24 04:32, Peter Xu wrote: On Mon, Mar 04, 2024 at 01:28:28PM +0100, Cédric Le Goater wrote: This will help preserving the error set by .save_setup() handlers. Signed-off-by: Cédric Le Goater IIUC this is about the next patch. I got fully confused before reading into the next one.

Re: [PATCH v3 10/26] migration: Move cleanup after after error reporting in qemu_savevm_state_setup()

2024-03-04 Thread Peter Xu
On Mon, Mar 04, 2024 at 01:28:28PM +0100, Cédric Le Goater wrote: > This will help preserving the error set by .save_setup() handlers. > > Signed-off-by: Cédric Le Goater IIUC this is about the next patch. I got fully confused before reading into the next one. IMHO we can squash it into where

[PATCH v3 10/26] migration: Move cleanup after after error reporting in qemu_savevm_state_setup()

2024-03-04 Thread Cédric Le Goater
This will help preserving the error set by .save_setup() handlers. Signed-off-by: Cédric Le Goater --- migration/savevm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/savevm.c b/migration/savevm.c index