Re: [PATCH v4 10/11] tests/tcg/s390x: Tests for Vector Enhancements Facility 2

2022-04-12 Thread David Hildenbrand
On 05.04.22 19:03, David Miller wrote: > Recommendation for comment? > > /* vri-d encoding matches vrr for 4b imm. > .insn does not handle this encoding variant. > */ > Sorry for the late reply. ".insn doesn't handle vri-d properly. So instead, we use vrr, which matches vri-d with a 4b imm

Re: [PATCH v4 10/11] tests/tcg/s390x: Tests for Vector Enhancements Facility 2

2022-04-05 Thread David Miller
Recommendation for comment? /* vri-d encoding matches vrr for 4b imm. .insn does not handle this encoding variant. */ Christian: I will push another patch version as soon as that's decided. (unless you prefer to choose the comment and edit during staging) On Tue, Apr 5, 2022 at 6:13 AM David

Re: [PATCH v4 10/11] tests/tcg/s390x: Tests for Vector Enhancements Facility 2

2022-04-05 Thread David Hildenbrand
On 01.04.22 17:25, Christian Borntraeger wrote: > Am 01.04.22 um 17:02 schrieb David Miller: >> vrr is almost a perfect match (it is for this, larger than imm4 would >> need to be split). >> >> .long : this would be uglier. >> use enough to be filled with nops after ? >> or use a 32b and 16b

Re: [PATCH v4 10/11] tests/tcg/s390x: Tests for Vector Enhancements Facility 2

2022-04-01 Thread Christian Borntraeger
Am 01.04.22 um 17:02 schrieb David Miller: vrr is almost a perfect match (it is for this, larger than imm4 would need to be split). .long : this would be uglier. use enough to be filled with nops after ? or use a 32b and 16b instead if it's in .text it should make no difference. I will let

Re: [PATCH v4 10/11] tests/tcg/s390x: Tests for Vector Enhancements Facility 2

2022-04-01 Thread David Miller
vrr is almost a perfect match (it is for this, larger than imm4 would need to be split). .long : this would be uglier. use enough to be filled with nops after ? or use a 32b and 16b instead if it's in .text it should make no difference. On Fri, Apr 1, 2022 at 2:42 AM Christian Borntraeger

Re: [PATCH v4 10/11] tests/tcg/s390x: Tests for Vector Enhancements Facility 2

2022-04-01 Thread Christian Borntraeger
Am 01.04.22 um 04:15 schrieb David Miller: Hi, There is some issue with instruction sub/alt encodings not matching, but I worked around it easily. I'm dropping the updated patch for the tests in here. I know I should resend the entire patch series as a higher version really, and will do so.

Re: [PATCH v4 10/11] tests/tcg/s390x: Tests for Vector Enhancements Facility 2

2022-03-31 Thread David Miller
On Thu, Mar 31, 2022 at 10:15 PM David Miller wrote: > > Hi, > > There is some issue with instruction sub/alt encodings not matching, > but I worked around it easily. > > I'm dropping the updated patch for the tests in here. > I know I should resend the entire patch series as a higher version >

Re: [PATCH v4 10/11] tests/tcg/s390x: Tests for Vector Enhancements Facility 2

2022-03-31 Thread David Miller
Hi, There is some issue with instruction sub/alt encodings not matching, but I worked around it easily. I'm dropping the updated patch for the tests in here. I know I should resend the entire patch series as a higher version really, and will do so. I'm hoping someone can tell me if it's ok to

Re: [PATCH v4 10/11] tests/tcg/s390x: Tests for Vector Enhancements Facility 2

2022-03-31 Thread David Miller
Sorry, Didn't notice this, as it was on v4 patch emails. I assume since there is no other follow up after a week, CI jobs are not being updated and I should change samples to use .insn. I will try to get this out tomorrow. Thanks, - David Miller On Wed, Mar 23, 2022 at 1:13 PM Thomas Huth

Re: [PATCH v4 10/11] tests/tcg/s390x: Tests for Vector Enhancements Facility 2

2022-03-23 Thread Thomas Huth
On 22/03/2022 11.31, Thomas Huth wrote: On 22/03/2022 09.53, David Hildenbrand wrote: On 22.03.22 01:04, David Miller wrote: [...] diff --git a/tests/tcg/s390x/Makefile.target b/tests/tcg/s390x/Makefile.target index 8c9b6a13ce..921a056dd1 100644 --- a/tests/tcg/s390x/Makefile.target +++

Re: [PATCH v4 10/11] tests/tcg/s390x: Tests for Vector Enhancements Facility 2

2022-03-22 Thread Thomas Huth
On 22/03/2022 09.53, David Hildenbrand wrote: On 22.03.22 01:04, David Miller wrote: [...] diff --git a/tests/tcg/s390x/Makefile.target b/tests/tcg/s390x/Makefile.target index 8c9b6a13ce..921a056dd1 100644 --- a/tests/tcg/s390x/Makefile.target +++ b/tests/tcg/s390x/Makefile.target @@ -16,6

Re: [PATCH v4 10/11] tests/tcg/s390x: Tests for Vector Enhancements Facility 2

2022-03-22 Thread David Hildenbrand
On 22.03.22 01:04, David Miller wrote: > Signed-off-by: David Miller > Signed-off-by: Richard Henderson Checkpatch complains about three things: ERROR: space prohibited between function name and open parenthesis '(' #262: FILE: tests/tcg/s390x/vxeh2_vlstr.c:115: +vler (, , ES16); vtst(vd,

[PATCH v4 10/11] tests/tcg/s390x: Tests for Vector Enhancements Facility 2

2022-03-21 Thread David Miller
Signed-off-by: David Miller Signed-off-by: Richard Henderson --- tests/tcg/s390x/Makefile.target | 8 ++ tests/tcg/s390x/vxeh2_vcvt.c| 97 + tests/tcg/s390x/vxeh2_vlstr.c | 146 tests/tcg/s390x/vxeh2_vs.c | 91