Re: [Qemu-devel] [PATCH] fix SDL mouse events processing

2008-03-13 Thread Aurelien Jarno
On Wed, Mar 05, 2008 at 01:54:53PM +, Samuel Thibault wrote: Here is a revamped patch: This fixes SDL mouse events processing: - GetRelativeMouseState() always returns the last position, so when the polling loop gets several mouse events in one go, we would send useless 'no move'

Re: [Qemu-devel] [PATCH] fix SDL mouse events processing

2008-03-13 Thread Samuel Thibault
Aurelien Jarno, le Thu 13 Mar 2008 20:50:51 +0100, a écrit : On Wed, Mar 05, 2008 at 01:54:53PM +, Samuel Thibault wrote: This fixes SDL mouse events processing: - GetRelativeMouseState() always returns the last position, so when the polling loop gets several mouse events in one go,

[Qemu-devel] [PATCH] fix SDL mouse events processing

2008-03-05 Thread Samuel Thibault
Hello, The patch below fixes SDL mouse events processing: - GetRelativeMouseState always returns the last position, so when the polling loop gets several mouse events in one go, we would send useless 'no move' events. - So as to make sure we don't miss any mouse click / double click, we

Re: [Qemu-devel] [PATCH] fix SDL mouse events processing

2008-03-05 Thread Johannes Schindelin
Hi, On Wed, 5 Mar 2008, Samuel Thibault wrote: The patch below fixes SDL mouse events processing: - GetRelativeMouseState always returns the last position, so when the polling loop gets several mouse events in one go, we would send useless 'no move' events. - So as to make sure we don't

Re: [Qemu-devel] [PATCH] fix SDL mouse events processing

2008-03-05 Thread Samuel Thibault
Johannes Schindelin, le Wed 05 Mar 2008 14:09:10 +0100, a écrit : What is this good for? (I imagine that it would make sense to add a comment to document why this is here, for clueless people like me.) Maybe it is to initialise the state of the mouse buttons? That's it. This means that

Re: [Qemu-devel] [PATCH] fix SDL mouse events processing

2008-03-05 Thread Samuel Thibault
Here is a revamped patch: This fixes SDL mouse events processing: - GetRelativeMouseState() always returns the last position, so when the polling loop gets several mouse events in one go, we would send useless 'no move' events, let's avoid that. - So as to make sure we don't miss any mouse

Re: [Qemu-devel] [PATCH] fix SDL mouse events processing

2008-03-05 Thread Johannes Schindelin
Hi, On Wed, 5 Mar 2008, Samuel Thibault wrote: Here is a revamped patch: Thanks, and thanks for the explanations, too. Ciao, Dscho