[Qemu-devel] [PATCH] target-i386: pc: fix crash when attempting hotplug CPU with negative ID

2013-05-30 Thread Igor Mammedov
QMP command { 'execute': 'cpu-add', 'arguments': { 'id': -1 }} may cause QEMU SIGSEGV at: piix4_cpu_hotplug_req () ... g-sts[cpu_id / 8] |= (1 (cpu_id % 8)); ... Since for PC in current implementation id should be in range [0...maxcpus) and maxcpus already checked, add check for

Re: [Qemu-devel] [PATCH] target-i386: pc: fix crash when attempting hotplug CPU with negative ID

2013-05-30 Thread Andreas Färber
Am 30.05.2013 17:09, schrieb Igor Mammedov: QMP command { 'execute': 'cpu-add', 'arguments': { 'id': -1 }} may cause QEMU SIGSEGV at: piix4_cpu_hotplug_req () ... g-sts[cpu_id / 8] |= (1 (cpu_id % 8)); ... Since for PC in current implementation id should be in range